kc3-lang/angle

Log

Author Commit Date CI Message
Kimmo Kinnunen a04cb42a 2025-01-30T16:26:44 Metal: Remove autorelease use from libANGLE parts Use adoptObjCPtr() instead of AUTORELEASE to make all code uniform and more easy to reason about. Bug: angleproject:393263506 Change-Id: I15ea7e29784bcbe6bee6341fe288b340db813538 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6216870 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Austin Annestrand e87d87f8 2025-01-29T22:23:27 CL: Add NDRange region chunk max GWS clamp Some implementations provide a value for maxComputeWorkGroupCount that goes beyond uint32_t when multiplied by local work size (to get the max global work size). This change clamps product to UINT32_MAX if that case occurs. Bug: angleproject:42267085 Change-Id: Ide87ef7be473c52db23c16ebf1e44a7fdcaf3081 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6217421 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 8157f927 2025-02-03T09:22:32 Roll Chromium from b795d308ae56 to 8cb2fac8059f (840 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b795d308ae56..8cb2fac8059f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3ec76f733b..a9640b2af4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/de2110201a..e87a266983 * third_party/android_build_tools/error_prone/cipd: nMRsstwSV_yyzV8beLhNfywd81JUi3QmAXpbHD0stscC..PW_AkPGAdnmLPk-dG161a_wYd9FRhQ9INn9f8HKj3fcC * third_party/android_build_tools/lint/cipd: pVQ05VquWske4TcBSXyzfgZCS5VBomVXJ0NTXXbbnS4C..ADzNzHHqZEK8ELtfKxVHQE9nlzafzaM7bW-0FJdyqeUC * third_party/android_build_tools/manifest_merger/cipd: k__Rs3pAmfiyzS9AAiiKHzBQdzs7iAx4u9fgScVOwTsC..dpBIpmqeRKRSK-XETu-3uRvAutKAS22ulPVpm1l0MpoC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/19f086d093..d516686190 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c88ad7af1a..98b7273c8d * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/4997b50ea0..6b4e376d45 * third_party/r8/cipd: -ksREVIoU_CBsrSenB5wAU_Tq0gG1fDRaQC7_MFT6BMC..ukddmPlorF_6XXPBcxDxCmK2PSAJlhu_MDUhZQCz1l8C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6afc0a4470..a037c8c5ad * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/34721d4450..748b34e9eb No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I9eb335fbc9c0535b0f460bc57ac26522b042b81f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6223543 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 91a559c9 2025-02-03T08:01:38 Roll VK-GL-CTS from cf81553b703a to 48e7f3020f52 (9 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/cf81553b703a..48e7f3020f52 2025-01-31 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2025-01-31 mateusz.bahyrycz@mobica.com Utils functions fix for compute only 2025-01-31 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.5 into vk-gl-cts/main 2025-01-31 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.11 into vk-gl-cts/main 2025-01-31 ziga@lunarg.com Fix structs going out of scope in shader object tests 2025-01-31 ziga@lunarg.com Test pipelines with dynamic states and without related shader stages 2025-01-31 rgarcia@igalia.com Test DGC IES with dynamic alpha to coverage enable 2025-01-31 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2025-01-28 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I40fabdd9f856cf2551cfd8f07fc1b72e678b86d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6223542 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gowtham Tammana 44b5f0a5 2025-01-06T16:01:28 OpenCL: Pass in options to the CTS tests In the case where options are specified, pass them down to the CTS tests. New tests with options for copy_images, fill_images and bruteforce are added. The changes in `angle.json` file are autogenerated by running `python3 scripts.run_code_generation.py` Bug: angleproject:388319897 Change-Id: I1c7e133d8df00e008857b652132b45975f61a08e Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6153935 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Austin Annestrand <a.annestrand@samsung.com>
Geoff Lang c0b224c3 2025-01-31T12:20:00 Re-enable EXT_base_instance on the Vulkan backend. Vulkan has native support for the base instance draw calls and does not go through the emulation paths. Bug: angleproject:355645824 Change-Id: I370ece42cffff6df5b1c070d637c20e071598de7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6216375 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 65c07386 2024-12-04T16:17:49 Vulkan: Limit dyn vertex input state WA on QCOM * Limited the workaround for dynamic vertex input state so it is enabled on the later version in which it has been fixed. Bug: angleproject:381384988 Change-Id: I71db843e4ce247691dae2c7d0db32678d12492be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6072407 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana 433d14e0 2025-01-28T17:05:32 CL/Vulkan: Submit an empty command on command buffer reset On resetting the command buffer, the queue serial associated with it wont get signalled leading to causality issues. Instead submit an empty command to maintain queue serial timelines. Bug: angleproject:392934330 Change-Id: I53996b295d2744b58487e483dd45918e48f58c83 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6207673 Reviewed-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov e6115fdd 2025-01-27T19:37:25 Vulkan: Fix and simplify Wayland window resize The `doDeferredAcquireNextImage()` may only be called with `forceSwapchainRecreate == true` argument when in `ImageAcquireState::NeedToAcquire` state. In any case, method must not be called when state is `ImageAcquireState::Ready`. Instead of adding state check to the `WindowSurfaceVkWayland::getAttachmentRenderTarget()` method, this change removes this method entirely, since calling `doDeferredAcquireNextImage()` is not required (as well as the `mResided` member). The `WindowSurfaceVkWayland::mExtents` will be compared with the current extent in the `checkForOutOfDateSwapchain()` since "perFrameWindowSizeQuery" feature is enabled for Wayland. Bug: angleproject:40096815 Change-Id: I31608d52ba72305cbb31220f21829ad18f9d2ce7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6203062 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen c411081f 2025-01-30T15:18:20 Metal: Remove RenderUtils mtl::Context base RenderUtils is not using mtl::Context error handling for anything. Bug: angleproject:392938089 Change-Id: I1ef86db8f03ff34bb54726a0aad31d07fb1b44ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6218788 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Austin Annestrand 2567dc4f 2025-01-30T11:20:57 CL/VK: Add spv validation for program build Bug: angleproject:42266976 Change-Id: I529395cba2d935cd6117c9c18fefd9a27903e2a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6216570 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Austin Annestrand fb2ae3fb 2024-11-26T16:23:52 CL/VK: Missing ext check in reflection parser When parsing "spv::OpExtInst", we also need to check for "ext_inst_type" to be clspv reflection type. Otherwise we might end up parsing bogus/non clspv ext type instructions. Bug: angleproject:42266976 Change-Id: Iab115f44890ce83fea09fb39be24b45ee2fa827b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6216569 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Kimmo Kinnunen 7d37d970 2025-01-30T13:47:59 Make error messages end in a dot Some messages had dot and some not. Fix by adding dot to all error message string literals. Best effort, for free form string literals, check ANGLE_CHECK invocation sites only. Bug: angleproject:392938089 Change-Id: Idedc3fe1d1e186fb91b5e54407df87f6830995a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6218460 Reviewed-by: Geoff Lang <geofflang@chromium.org>
Amirali Abdolrashidi 1df10f8a 2025-01-29T14:50:21 Unsuppress VUID-VkImageViewCreateInfo-pNext-01585 * Updated ImageHelper::DeriveCreateInfoPNext() to check the usage flags as well. * If the image uses the storage bit, the format list should not be added to it as pNext. Otherwise, if the count is not zero, it expects the format used in its image view to be one of the stated formats and will result in a VVL if this is not the case. Bug: angleproject:42264452 Change-Id: I789ec5a9751366029929c4c25a942056df13b9ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6216381 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen eb0e72e0 2025-01-30T09:50:27 Mark error strings as inline constexpr Some WebKit build configurations are seeing duplicated strings. A global constexpr implies static, which allows that each compile unit gets its own instance. A global inline constexpr guarantees that the instance address evaluates same for all address takers. This should guarantee that the strings are not duplicated. Use char[] instead of char * to guarantee that referencers would get the length. Bug: angleproject:392938089 Change-Id: I5652ed8807d5052abe41671f4a0005905fe8d30b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6218459 Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Austin Annestrand 0549137f 2025-01-30T13:15:09 CL/VK: Fix cmd queue deadlock on clFlush Issue was that app-thread held mCommandQueueMutex for clFlush duration. App-thread notifies the queue-thread via "mHasWorkSubmitted" condition-variable. Queue-thread later calls finishQueueSerial(), and that routine tries to recursively grab mCommandQueueMutex. This change avoids this by unlocking app-thread before it notifies the queue-thread (also takes capture of QueueSerial before unlocking). Bug: angleproject:375231041 Change-Id: I71e0c9f9455a86b97acbc88107b0edbc05ce33a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6194198 Commit-Queue: Gowtham Tammana <g.tammana@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 0c2d793c 2025-01-31T11:52:51 Manual roll vulkan-deps from 3a89e5275402 to 430dae9cea66 (15 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/3a89e5275402..430dae9cea66 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/5165b6d2bdff5244e8aef6408441a962424cf2d1..c1c4712c75bc123dac21daea5dfffd416e103e59 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/3364b982713a0440d1d342dd5eec65b122a61b71..04b4a204aa501992ae85a207be1e200e195c98e1 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/e43027aa41c4f51b12d79aeae53ff608951c36ec..39f924b810e561fd86b2558b6711ca68d4363f68 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/369afe24d1351d6e03cbfc3daf1fc5f6cd103649..0508dee4ff864f5034ae6b7f68d34cb2822b827d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/7658238ddc50d7ef1fe923d95b7112597a5adc68..c52931f012cb7b48e42bbf2050a7fb2183b76406 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/1ddbe6c40aeaf98d4138f07c325ebb01beeece68..fe7a09b13899c5c77d956fa310286f7a7eb2c4ed https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/cc4c765c9ccacabd6338f348082841846053abb9..c3dc948b0b960b3a01506b57a15ecee2a9e31bf2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: If34c6c40f06e14b42316a05ad5dc59a9c9314c9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6220892 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 34aeaa17 2025-01-31T09:10:25 Roll Chromium from a51c83d792dd to b795d308ae56 (631 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a51c83d792dd..b795d308ae56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/381f9f22a0..3ec76f733b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/98d613eb20..de2110201a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ce598256f2..c88ad7af1a * third_party/fuchsia-sdk/sdk: version:27.20250129.4.1..version:27.20250130.7.1 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/0d8d089914..4997b50ea0 * third_party/r8/cipd: twmEo-SOTxF2yvzPBCZ6XnSnzi3RekGMhUHTIhc5ox8C..-ksREVIoU_CBsrSenB5wAU_Tq0gG1fDRaQC7_MFT6BMC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/961fba8da2..b74f5d5c0d * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/35179fc54f..3d14d0d9ec * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/544050827c..6afc0a4470 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/47b4070816..34721d4450 * tools/skia_goldctl/mac_amd64: rB-KKpciKP6EJPB7uDYVpqHCFEaz7IF5JTCYggCznmcC..w4KjkADnVRHE8TgQXpDuP6qD3uivftyQ3ue-Ee-gqWQC No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I8e9a20ce9dbca5f358fc03c60a594733443aa701 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6219670 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Rafay Khurram 439dfe5e 2024-12-12T00:37:13 CL/Vulkan: Add options passed to clspv compiler * Passes rte mode and image feature macros options to clspv compiler * Adds image feature macros device reported cl features Tests-Passing: OCLCTS.test_compiler features_macro, OCLCTS.test_samplerless_reads, OCLCTS.test_image_streams, OCLCTS.test_basic image_param Bug: angleproject:42266936 Change-Id: Ifd2b2c49a525ba3ee4be572de004fd317b0ff1ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6089949 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Rafay Khurram <r.khurram@samsung.com>
Charlie Lao 9d934912 2025-01-09T11:31:42 Vulkan: Use VkEvent to track transform feedback buffer write This CL adds event tracking into BufferHelper class: mCurrentWriteEvent is used to track the write event and mCurrentReadEvents is used to track all different reads from the buffer. Since you can have multiple different reads accumulate over time, read events are an array of EventStage and the actual VkAccessFlags per event is tracked in mCurrentReadEventsAccessFlags. Note that this is specifically designed to allow pipelineBarrier and eventBarrier to co-exist. If mCurrentReadStages contains more bits than mCurrentReadEvents, the remaining bits will be using pipelineBarrier. Similarly if mCurrentWriteStages contains more bits than mCurrentWriteEvent, the remaining bits will be using pipelineBarrier. A heuristic tracking is also added to track the buffer writes over a period of time. Right now we will opt buffer into VkEvent if the buffer ever written by transform feedback in the heuristic tracking window. This could be expanded in future if we found more usage pattern that would be benefit from using VkEvent. Also note that DrawIndirect and VertexInput will be using the same VkEvent to track. It still will be using different VkAccessFlags since the access flags comes from buffer instead of event. Bug: angleproject:360274928 Change-Id: I027ffed8a0fbff7f280f42cf70564b8a3f243d69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6085490 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 03019646 2025-01-29T10:36:38 Vulkan: Fix invalidate of emulated format followed by more draws If invalidating a color image with emulated channels, a clear is automatically staged so the emulated channels don't contain invalid data later. This is problematic with deferred clears; the clear marks the framebuffer attachment as dirty, and the next command causes `FramebufferVk::syncState` to pick the clear up as a deferred clear. This is normally correct, except if the following command is another draw call; in that case, the render pass does not close, yet the clear is cached in `mDeferredClears`. When the render pass later closes, it undoes the invalidate and attempts to remove the clear from the image... but it does not exist there anymore (it's in `mDeferredClears`). Next usage of the image then clears it, undoing the draws after invalidate. In this case, the simplest approach is to close the render pass right away here. Note that it is not possible to make `FramebufferVk::syncState` avoid picking up the clear in `mDeferredClears`, not apply the clear, _and_ keep the render pass open; because future uses of the image (like with |glReadPixels|) will not trigger `FramebufferVk::syncState` and the clear won't be done. Bug: angleproject:353167428 Change-Id: Ie677bd12d9f11953cdcd5e4c374b59c4f63e7456 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6214331 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 02bd7ad6 2025-01-29T12:18:08 Revert "Force logging ANativeWindow events for debugging." This reverts commit 08365628f4fdb72308757574f7ae414875150f9b. Reason for revert: no longer needed Original change's description: > Force logging ANativeWindow events for debugging. > > Temporarily switch from LOGV to LOGI, > so that logs from these events show in release builds of ANGLE: > onNativeWindowCreated > onNativeWindowDestroyed > onNativeWindowRedrawNeeded > onNativeWindowResized > > These are only printed in ANGLE tests. > > Bug: chromium:339457761 > Change-Id: I0d81b05348ee3184fdc90da1a16e69704bcc084a > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5526470 > Reviewed-by: Roman Lavrov <romanl@google.com> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: chromium:339457761 Change-Id: I63bd69945ef997374f2184d7c72cf2cc3e301a04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6215272 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll a870888a 2025-01-30T10:01:18 Roll vulkan-deps from 0a35e614cfbd to 3a89e5275402 (14 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/0a35e614cfbd..3a89e5275402 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/633e9b6e15b7b142eb311ecc316858eab5425033..0549c7127c2fbab2904892c9d6ff491fa1e93751 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/2b2e05e088841c63c0b6fd4c9fb380d8688738d3..e7294a8ebed84f8c5bd3686c68dbe12a4e65b644 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/bdf077623c55dabae66ce64639086b4391e14016..3364b982713a0440d1d342dd5eec65b122a61b71 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/0d99e5aad4299d8e4b3bcf4bf1e1bea4a32a9044..cc4c765c9ccacabd6338f348082841846053abb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Iaf74dbf889388ac22d282ba89ffd5fdc8bd73d21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6217422 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll df67137f 2025-01-30T07:02:16 Roll Chromium from d33160322271 to a51c83d792dd (575 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d33160322271..a51c83d792dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f50a45f36e..381f9f22a0 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4521cec19f..6b4eaa1ed0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/602354bd16..98d613eb20 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/065e549702..aaed376e01 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6fba8f15dc..19f086d093 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9f48a4ca85..ce598256f2 * third_party/fuchsia-sdk/sdk: version:26.20250117.5.1..version:27.20250129.4.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/12150825ca..2e25154d49 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/c015540044..0d8d089914 * third_party/r8/cipd: kXrlzFdbtrTA5fGDhJngfPu9c-g4zvKJfzY9ar7HDqwC..twmEo-SOTxF2yvzPBCZ6XnSnzi3RekGMhUHTIhc5ox8C * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/19ead498eb..35179fc54f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/dab4e480ea..544050827c * tools/luci-go: git_revision:83f8c966f0ca5b6d249d042c7ca6f6deba3c7464..git_revision:c36fd1e86ba464371c3e6d817c14f2b40d43cb29 * tools/luci-go: git_revision:83f8c966f0ca5b6d249d042c7ca6f6deba3c7464..git_revision:c36fd1e86ba464371c3e6d817c14f2b40d43cb29 * tools/luci-go: git_revision:83f8c966f0ca5b6d249d042c7ca6f6deba3c7464..git_revision:c36fd1e86ba464371c3e6d817c14f2b40d43cb29 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7c0f6f0781..47b4070816 * tools/skia_goldctl/linux: S8KkLIhCwVe-hsj8R5K7Mc2puD0PkQY0t_YQZ0-rrDwC..M1GANqZ-d2Qp4DHOEtmfafgGkTeeDLKJUreuBV_psroC * tools/skia_goldctl/mac_amd64: eCSZRvEvRPq8bq7BcZ086o2PMGFHGmrnIlrtgq_3WNcC..rB-KKpciKP6EJPB7uDYVpqHCFEaz7IF5JTCYggCznmcC * tools/skia_goldctl/mac_arm64: 9SDFiZaagGd9jEbCtYfv3VgwH2Bn4McoYBAVJoeCGc8C..Nej3vvoT_ssGeDCs5clWDgEDHARO4KP8W3EKOLNxXTkC * tools/skia_goldctl/win: Hx02LAyUjppCjvPbUB4_ekvQILOOxwptggbjbqFAKxEC..Mg04jm-4f1YP4Vv2GYoJdIv8gxvPFQSgwovCzVlN-w0C No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I79f68cc5a81a9f6fe67e801e9f5e0a7ab4863d4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6216216 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen 5325904b 2025-01-29T14:43:35 Metal: Simplify error checking Use normal ANGLE_CHECK, ANGLE_CHECK_GL_ALLOC, ANGLE_CHECK_GL_MATH when appropriate. Use ANGLE_MTL_CHECK for checking Metal NSError return value. Remove mtl::ErrorHandler::handleError variant that responds to NSError. Uses "Internal error." that occur due to implementation bugs. Binary size is already expended with __FILE__ et al to disambiguate the location. The descriptions were not actionable for the API client and sometimes wrong cut-and-paste. Bug: angleproject:392938089 Change-Id: If9525d3d1610d5bc757855053600d78d2a1526c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6211841 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cody Northrop 5798be5e 2025-01-13T07:45:11 FrameCapture: Fix framebuffer bindings in MEC While capturing an app, I was crashing on the line reading replayState.getReadFramebuffer()->id() That's because replayState did not have a read framebuffer bound, and we dereferenced nullptr. replayState is a default state that we've created and we're modifying to make it *look* like apiState. We should be updating replayState to match the framebuffers bound in apistate. In this case state*Framebuffer is read from apiState and is the value we want to propagate. AFAICT these have been incorrect since they landed in the initial implementation, but the code is complex: https://chromium-review.googlesource.com/c/angle/angle/+/1689329 Test: Tower of Fantasy capture Bug: b/389808881 Change-Id: Ibf7bc56cd385c34139676c5813926f756bb38f42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6174746 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Gowtham Tammana e330d959 2024-04-09T15:13:48 CL/Vulkan: Add native builtins to clspv compiler Add a set of native builtins that are known to perform better for Samsung devices. A feature condition `uses_native_builtin_cl_kernel` is setup in `vk_featurs.json` for control of the selection. The following files are autogenerated - FeaturesVk_autogen.h - angle_features_autogen.cpp - angle_features_autogen.h Bug: angleproject:361717757 Change-Id: I10ffad0cbf1d4c2e9bfeea768311d90b0f65af2d Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6092036 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand b4cac1ad 2025-01-29T10:59:22 CL/VK: Hotfix: Implementation of Compute Pipeline Cache Unnecessary "new" that was leaking when moving raw ptr to cache map. Easy fix is to stack allocate and std::move the object to container when finished initializing. Bug: angleproject:391672281 Change-Id: I7b0f922de2a1332e8e452e87bc498d3c9907d7d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6214690 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 6f5b32d0 2025-01-29T18:55:21 Suppress flaky end2end test on Linux NVIDIA Vulkan ClearTextureEXTTestES31Renderable.Clear3D Bug: angleproject:362486580 Change-Id: Iff0195d85c828d172ea4b9e150b62da7df0769d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6215271 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Kimmo Kinnunen 43e7384d 2025-01-28T18:28:44 Metal: Fix a race in failing compilation subtasks Program link invokes two link subtasks, one MSL compilation per shader in program. If these tasks would fail, they would race to write the error message to the error string held in link object. Fix by recording the error message to the compile tasks and forwarding it to the context when sub task result is fetched. Bug: angleproject:392652319 Change-Id: Icb369f7bd62da5155d7915f2743ac53d91d61ea8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6207769 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Liza Burakova 40523499 2025-01-29T12:13:45 WebGPU: Emulate line loops for drawElements Bug: angleproject:383356846 Change-Id: I82a6dfad4a1c5d434f029701611e4b61344655f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6086120 Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mohan Maiya 9975e80b 2025-01-28T17:25:38 Vulkan: Bugfix in SPIRV entrypoint transformation Perform varying precision fixer transformation before other shader-stage-specific transforms that could potentially modify the interfaceList. Also enhance EXTBlendFuncExtendedDrawTest by enabling additional config with VaryingsRequireMatchingPrecisionInSpirv feature enabled Bug: angleproject:386749841 Change-Id: Ife4a2f932415296f1565527e50a2b8646cd7697d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6207741 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Yuly Novikov af4817db 2025-01-29T14:12:02 Suppress angle_oclcts_non_uniform_work_group failures on Linux NVIDIA Bug: angleproject:42267085 Change-Id: I13f85d8b7ed140f3a10262fe335de664cfd68624 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6213432 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuly Novikov 00f0b887 2025-01-29T14:04:38 Skip pokemon_go flaky crash on Linux Intel Bug: angleproject:392938092 Change-Id: Ie46582b91fc498640b2651f3e04aaf7d1769da6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6213430 Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 95af326c 2025-01-29T10:01:44 Roll vulkan-deps from ef9be82521e9 to 0a35e614cfbd (14 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/ef9be82521e9..0a35e614cfbd Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/6eeaaadd15eb8603af175504427a7ebcc0364815..5165b6d2bdff5244e8aef6408441a962424cf2d1 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/a4680e67d0bad1dcc8a0fca2fc4b6f33519ae093..369afe24d1351d6e03cbfc3daf1fc5f6cd103649 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/abf70b95ed671aac7f2ed90fa5a16888fb33f1d8..0d99e5aad4299d8e4b3bcf4bf1e1bea4a32a9044 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ib398405a95e9360952af5b5b7aeeacd35fd28d39 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6210122 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Igor Nazarov b5809efa 2025-01-16T17:56:47 Delay eglSwapInterval() effect until swap ... and fix resetting effect of `eglSwapInterval()` call by changing the `EGL_RENDER_BUFFER` attribute, and resetting desired shared present mode when calling `eglSwapInterval()`. Bug: angleproject:390333526 Change-Id: I473c7d4c5929e2179bbcd378b3695d10213644de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6169922 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll 83a6d223 2025-01-29T08:31:06 Roll Chromium from 1ecb21e0f634 to d33160322271 (638 revisions) https://chromium.googlesource.com/chromium/src.git/+log/1ecb21e0f634..d33160322271 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f56ffde666..f50a45f36e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a660247d3c..4521cec19f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0d6228c8b2..602354bd16 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/5f29517d08..065e549702 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/af7eadb024..9f48a4ca85 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2e25154d49..12150825ca * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/7e0f3a8471..634228a732 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/75ca665df9..c015540044 * third_party/r8/cipd: VSVmC5R_5xS8P4rv9--88KTcqKPfJ6oDKRQ-hX9IRsUC..kXrlzFdbtrTA5fGDhJngfPu9c-g4zvKJfzY9ar7HDqwC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d04dc8f182..dab4e480ea * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/47158e077c..7c0f6f0781 * tools/skia_goldctl/mac_amd64: rB-KKpciKP6EJPB7uDYVpqHCFEaz7IF5JTCYggCznmcC..eCSZRvEvRPq8bq7BcZ086o2PMGFHGmrnIlrtgq_3WNcC No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I501e5ad1e3341a34a6a00948926c193875403e0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6210207 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao f231d94b 2025-01-13T14:58:16 Vulkan: Add kBufferMemoryBarrierData to mirror image Right now we only maintain a mapping from EventStage (which is a value of VkPipelineStageFlags) to VkPipelineStageFlags for images. For next CL we need to indicate if use VkEvent is preferred or not for a given PipelineStage access. This CL expands kPipelineStageFlagBitMap (and renamed to kBufferMemoryBarrierData) to contain both the VkPipelineStages and EventStage to indicate if VkEvent should be used or not, similar to kImageMemoryBarrierData but a lot simpler. Right now it all set to EventStage::InvalidEnum which means will use pipelineBarrier. This will change in next CL. This CL also does some clean up: A few BufferHelper related functions changed argument from ErrorContext* to Context*, mainly because of BufferHelper::release() now takes Context* as argument so that we can recycle events within context's share group without lock. ImageLayoutToMemoryBarrierDataMap is added to replace angle::PackedEnumMap<ImageLayout, ImageMemoryBarrierData> kEventStageAndPipelineStageFlagsMap is removed. InitializeEventAndPipelineStagesMap is now using kImageMemoryBarrierData directly to construct mEventStageToPipelineStageFlagsMap. As result of this, EventAndPipelineBarrierHaveMatchingStageFlags is also removed since InitializeEventStageToVkPipelineStageFlagsMap already ensures this. Bug: angleproject:360274928 Change-Id: Idb74f3e4120ca9a04b8eccb7ed034aa769024bf9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6172763 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Austin Annestrand e0cbdbb5 2025-01-15T14:08:45 CL/VK: Enable dispatch region chunking This change does two things: - Allow non-uniform workgroup size - Dispatches that go beyond VK workgroup count limit Bug: angleproject:42267085 Change-Id: I1f2da93252e466b811273ee34d9d38e454f11686 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6180550 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Austin Annestrand 95635ef0 2025-01-23T16:30:41 CL/VK: Implementation of Compute Pipeline Cache. Implemented ComputePipelineCache, hash map from OpenCL and OpenGL compute state vectors to compiled pipelines. Implemented ComputePipelineDesc, a tightly packed description of the current compute state. Compute Pipeline State includes the specialization constants, Pipeline Options (Protected, Robust). Updated-by: Austin Annestrand <a.annestrand@samsung.com> Bug: angleproject:391672281 Change-Id: I88944dc169d194d1b2c75747769d7346b041fa75 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6191437 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Geoff Lang 1161ac8e 2025-01-23T13:25:01 WebGPU: Implement no-op gl_PointSize Support writing to the gl_PointSize builtin but do not pass it to the next shader stages. Bug: angleproject:392604862 Change-Id: I845a3edeb0ce8e7ea41a5e96e5f3b443100f2cbf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6194555 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Roman Lavrov d9128ff4 2025-01-28T09:43:58 Clean up Galaxy expectations for A/S23 and S24 Exynos/QC Split A23 and S23 into separate lists GALAXYS24EXYNOS for S24 Exynos ("International") GALAXYS24QUALCOMM for S24 Qualcomm Bug: angleproject:359904354 Bug: b/338429767 Change-Id: If9c1f184df6c6f15e3b5d5af3a7e1310cb445984 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6207255 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop fa0de0dd 2025-01-27T17:32:49 restricted_trace_perf: Support --fps-limit Simply passes the flag and value through. Test: restricted_trace_perf.py --fps-limit 30 ... Bug: b/376300037 Change-Id: I344492944babed33edcbdae6b2906795d31715e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6204802 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 91985374 2025-01-28T10:01:29 Roll vulkan-deps from 7425f0646395 to ef9be82521e9 (20 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7425f0646395..ef9be82521e9 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/bd1f1c263fc10969eb4a4b393e774a75ffcb2673..633e9b6e15b7b142eb311ecc316858eab5425033 https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/4897b17f67bd6ddfeabb9c4e0bf5e8298eab3064..6eeaaadd15eb8603af175504427a7ebcc0364815 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/173fe3c60a8d9c7d35d7842ae267bb9df267a127..bdf077623c55dabae66ce64639086b4391e14016 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/ce3fbf53c8f77d04bc23d573a45b57fb6ed52e86..a4680e67d0bad1dcc8a0fca2fc4b6f33519ae093 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/8ec84823afa46cd054c8b094269eab958e078010..1ddbe6c40aeaf98d4138f07c325ebb01beeece68 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/258528b408898da932e3c681ff731b0be73fd9fc..abf70b95ed671aac7f2ed90fa5a16888fb33f1d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I90dcca8ad121234488b662e8896b6f8129f2d668 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6204256 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7085b6b1 2025-01-28T02:01:28 Roll SwiftShader from a87fa39f6446 to 86cf34f50cbe (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/a87fa39f6446..86cf34f50cbe 2025-01-27 swiftshader.regress@gmail.com Regres: Update test lists @ a87fa39f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: If0d2773d29a69a51e29476da175a35ee80513167 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6205823 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 806277c6 2025-01-28T07:01:03 Roll Chromium from 44e2240f3d75 to 1ecb21e0f634 (630 revisions) https://chromium.googlesource.com/chromium/src.git/+log/44e2240f3d75..1ecb21e0f634 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2e946a1769..f56ffde666 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/eb00e5b142..0d6228c8b2 * third_party/android_build_tools/error_prone/cipd: 8BhbnOXLLwq5cMmiboLj9_ep5FeMNwJuVPvz9BrY1PoC..nMRsstwSV_yyzV8beLhNfywd81JUi3QmAXpbHD0stscC * third_party/android_build_tools/lint/cipd: 1veHvODGn5XZ5IcxP36LQZ16pvydqdtMVqfm4Bj3EFcC..pVQ05VquWske4TcBSXyzfgZCS5VBomVXJ0NTXXbbnS4C * third_party/android_build_tools/manifest_merger/cipd: 2izJpKHtwg2L4dRBZvMneb2h_7370lDH6yuhAgnAYc0C..k__Rs3pAmfiyzS9AAiiKHzBQdzs7iAx4u9fgScVOwTsC * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/77a800d729..af7eadb024 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/68c77f0566..75ca665df9 * third_party/r8/cipd: J6-Klb-dVUAdm4YtIE1uNG5nm8u4MbS2NVRoOkGx6pMC..VSVmC5R_5xS8P4rv9--88KTcqKPfJ6oDKRQ-hX9IRsUC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/ce8b65518e..961fba8da2 * third_party/siso/cipd: git_revision:250e61b595d4f46eeff5901d3218bb2eaecf575b..git_revision:0b6159c39573013a79a47f8544200df07a6a74fc * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/0b5dab2791..19ead498eb * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e262f0f889..d04dc8f182 * tools/luci-go: git_revision:e3703a4d1c29e8355653c19b59b0aa793a850956..git_revision:83f8c966f0ca5b6d249d042c7ca6f6deba3c7464 * tools/luci-go: git_revision:e3703a4d1c29e8355653c19b59b0aa793a850956..git_revision:83f8c966f0ca5b6d249d042c7ca6f6deba3c7464 * tools/luci-go: git_revision:e3703a4d1c29e8355653c19b59b0aa793a850956..git_revision:83f8c966f0ca5b6d249d042c7ca6f6deba3c7464 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/dbbf0e0bee..47158e077c * tools/skia_goldctl/linux: B1lNvmnjnO7yf_AfZgDPUmoCdMreSDhPPROwkiWk8jQC..S8KkLIhCwVe-hsj8R5K7Mc2puD0PkQY0t_YQZ0-rrDwC * tools/skia_goldctl/mac_amd64: Cb2Fx5W46eaNENhgoYiw8Tabe1JjHh7MEjab7fYNmjEC..rB-KKpciKP6EJPB7uDYVpqHCFEaz7IF5JTCYggCznmcC * tools/skia_goldctl/mac_arm64: yEMI787ucvQWVBOeW4q8TMjvZz_yNOwB1aKRtLYfR1kC..9SDFiZaagGd9jEbCtYfv3VgwH2Bn4McoYBAVJoeCGc8C * tools/skia_goldctl/win: uk3Q5uckAHDJH6eZZtZzxgWfE_SSuRlZ38RpWSjFIu8C..Hx02LAyUjppCjvPbUB4_ekvQILOOxwptggbjbqFAKxEC No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I9451442dd1628944cf43336f2c39b9d8b2e16a1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6204804 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gowtham Tammana 0878d854 2024-10-29T12:24:22 CL/Vulkan: Query spv version from renderer Query the SPV version to be used by the clspv from the Vulkan renderer and set it up accordingly. Bug: angleproject:361717757 Change-Id: I6b1497120c21402386cb52a751970830e5cd7f3e Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5973716 Reviewed-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 7fe2a36c 2025-01-24T19:47:01 Vulkan: Parse Samsung Vulkan driver version Use driver version instead of API version to disable imageless framebuffer feature Bug: angleproject:386749841 Change-Id: Ia7bf06210224d399d60d6c1000c4fb8179f1239c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6199891 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Alex Dean 2e36e947 2025-01-16T15:12:22 CL/VK: kernel's arg.handle update properly when setArg Fix arg.handle to be an underlying CL object type. Bug: angleproject:390488741 Change-Id: I8a9d3981a46f17e9af906f0e345c17585a332b30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6180553 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Austin Annestrand <a.annestrand@samsung.com> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Geoff Lang 885a8060 2025-01-24T12:27:10 WebGPU: Implement depth/stencil test. Force the compare function to Always when depth or stencil tests are disabled. Bug: angleproject:392604945 Change-Id: I67265b2e5eabe8e9fc3d1222140ee1b6a7c5cefa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6198040 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Liza Burakova <liza@chromium.org>
Geoff Lang bec97bbb 2025-01-23T13:29:04 WebGPU: Flip Y for ReadPixels ReadPixels results are upside down. Flip the results in the PackPixels functions. TODO: Re-evaluate if this needs to be default-FBO only once more tests are running. Bug: angleproject:42267090 Change-Id: Ia5e5ee218de2e754f5de02a826f664d2f71efb76 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6194557 Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 0f75fc3d 2025-01-20T14:10:41 Vulkan: Transition foreign images to the FOREIGN queue on submit Vulkan's interaction with AHB and dmabuf images is through the FOREIGN queue family. When ANGLE uses these images, it must take ownership of the images by doing a queue family ownership transfer (QFOT) away from the FOREIGN queue family and into the graphics queue family used by the Vulkan backend. Prior to this change, ANGLE would do the QFOT away from FOREIGN once such a foreign image is imported into an EGL image. Afterwards, usage in ANGLE works correctly. What ANGLE did not handle is when a foreign entity wants to use these images _after_ ANGLE has used them. For the above to work correctly, ANGLE must do a QFOT back into FOREIGN before the image can be used by the foreign entity. Unfortunately, EGL does not provide a clear point for this hand-off to happen. ANGLE has no choice then to proactively transition the images back into FOREIGN at some point "just in case". For some native drivers, this hand-off to FOREIGN can be quite frequent. For example, on Android for most vendors there is no actual layout transition between graphics and FOREIGN queue families (the actual data layout is the same), so a cache flush/invalidate at strategic points (such as the end of the command buffer) is sufficient as equivalent to transition to FOREIGN (and another at the beginning of the command buffer as equivalent to transition from FOREIGN). As a layer over Vulkan's formalism, ANGLE is less lucky; it has to enumerate exactly which image is being transitioned to and away from FOREIGN. Transitions away from FOREIGN are in principle easy. As long as the image is marked as being in the FOREIGN queue family, it will automatically transition to the graphics queue family on first use. In this change, when a foreign image is transitioned out of the FOREIGN queue, it's added to a list of images to be transitioned back to FOREIGN at submit time. Once submission is done, the image may or may not actually be used by a foreign entity, but ANGLE cannot know that. The next time the image is used in ANGLE, it is transitioned out of FOREIGN. Verifying correctness with multi-threading is tricky, and relies on GL's requirement that access in one context is followed by a synchronization and rebind in another context before it can be used there. This means that the image's transition to FOREIGN (at the end of one submission) naturally happens before the transition back from FOREIGN (at the beginning of the next submission). Because the set of images to transition is tracked in the context, submissions in other contexts don't interfere with the above logic. The situation can be more complicated with one-off submissions, but fortunately, no such usage of foreign images is present. Another wrinkle is simultaneous usage of the image as read-only in two contexts. According to GL, this is not a hazard and requires no synchronization. However this is broken in ANGLE even for non-foreign images (see http://anglebug.com/42266349), because as what _seems_ like read-only usage of the image from GL's point of view (like sampling from the image), there are associated write operations from Vulkan's point of view (image layout transitions and QFOT). This change does not attempt to address this corner case. Bug: angleproject:42263241 Bug: angleproject:42262454 Bug: angleproject:390443243 Bug: chromium:382527242 Change-Id: Idd4ef1fecfa3fccf1a4063f1bddb08d28b85386b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6184604 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 47c64ce2 2025-01-24T16:15:26 Vulkan: Fix driver version parsing Bug: chromium:371512561 Change-Id: I469c4ae71613fdfdfd7e58602b5a7262342acba7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6199184 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll 8d76df50 2025-01-27T10:01:52 Roll vulkan-deps from 1b571b5a7b3c to 7425f0646395 (14 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1b571b5a7b3c..7425f0646395 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/3f129d076b44221b8b56a63215446d33b570ced8..4897b17f67bd6ddfeabb9c4e0bf5e8298eab3064 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/e02275ec02b68e3d175528f768871c97ae9eee90..173fe3c60a8d9c7d35d7842ae267bb9df267a127 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/a03d2f6d5753b365d704d58161825890baad0755..e43027aa41c4f51b12d79aeae53ff608951c36ec https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/1586f33d6d79eb9ffa5963ce4f70423986b95d8a..ce3fbf53c8f77d04bc23d573a45b57fb6ed52e86 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/8ce2501d2511b6f4e6389a03ff08c4e84d54fa25..7658238ddc50d7ef1fe923d95b7112597a5adc68 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/f07e27717a642fa193c967440f21ed634ea17987..8ec84823afa46cd054c8b094269eab958e078010 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/afad70fbb26c643b19cf53a5990852a4d83664b6..258528b408898da932e3c681ff731b0be73fd9fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ia0016ff0c2769e7c8be65b2a69ce705ee62b593c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6200657 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 06c5bb50 2025-01-27T08:01:47 Roll VK-GL-CTS from a9988483c086 to cf81553b703a (18 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/a9988483c086..cf81553b703a 2025-01-24 lorenzo@khronosgroup.org Update external sources for SPIRV-Tools and glslang 2025-01-24 gleese@broadcom.com Simplify feature struct consistency checking 2025-01-24 macjurga@amd.com Improve indirect build AS BuildRangeInfo coverage 2025-01-24 rgarcia@igalia.com Test feedback loop on separate mip levels 2025-01-24 rgarcia@igalia.com Test not binding unused vertex bindings 2025-01-24 piotr.byszewski@mobica.com Fix validation error in separate_channels DR tests 2025-01-24 marcin.zajac@cognizant.com Fix validation errors in shader_object tests 2025-01-24 mateusz.bahyrycz@mobica.com Depth stencil buffer copy fix for compute only 2025-01-24 mateusz.bahyrycz@mobica.com Barrier pipeline/shader stages fix for compute only 2025-01-24 rgarcia@igalia.com Do not check fragment shader outputs that are not written to 2025-01-24 rgarcia@igalia.com Test undefined values do not crash compiler 2025-01-24 rgarcia@igalia.com Test DGC with dynamic patch control points 2025-01-24 rgarcia@igalia.com Test varying sample shading state in indirect execution sets 2025-01-24 rgarcia@igalia.com Test alpha to coverage with alpha to one 2025-01-24 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.1 into vk-gl-cts/main 2025-01-23 gleese@broadcom.com Add VK_KHR_depth_clamp_zero_one 2025-01-23 lorenzo@khronosgroup.org Update Vulkan headers to 1.4.305, spirv tools, headers, glslang, amber 2025-01-17 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I1a46a354166d3a3019477a1dc0e4adfd0b0ec158 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6199492 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 037e7bfa 2025-01-27T07:00:11 Roll Chromium from 67eb0a3b5a40 to 44e2240f3d75 (752 revisions) https://chromium.googlesource.com/chromium/src.git/+log/67eb0a3b5a40..44e2240f3d75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e13953ced0..2e946a1769 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e0898cdec9..eb00e5b142 * third_party/android_build_tools/error_prone/cipd: DFqEkqm_CBBWylsmJnAMv2md7Kx6X9l3I3y8De6nmuAC..8BhbnOXLLwq5cMmiboLj9_ep5FeMNwJuVPvz9BrY1PoC * third_party/android_build_tools/manifest_merger/cipd: ESxV7cNgPg8y2RupSn5lYWBzQQMMK5Ai729X_Zhv_zwC..2izJpKHtwg2L4dRBZvMneb2h_7370lDH6yuhAgnAYc0C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/567ad21ab4..e531e94991 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8c858fc98c..77a800d729 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/b24bb82dd0..68c77f0566 * third_party/r8/cipd: 3iC3eGx7wAPZJhIJjRdLvqyiJHhKFVT1Eq6-uccHw9oC..J6-Klb-dVUAdm4YtIE1uNG5nm8u4MbS2NVRoOkGx6pMC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/9d0d7c0c17..ce8b65518e * third_party/siso/cipd: git_revision:6e20453c920920cade25e28fc443472eb22ddb41..git_revision:250e61b595d4f46eeff5901d3218bb2eaecf575b * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/0d66cc525a..0b5dab2791 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b3fef6ee99..dbbf0e0bee * tools/skia_goldctl/linux: 1TplvrLyzA9FlWhQRWdX9SaTfuZaPdvQ9BMG0wNhy98C..B1lNvmnjnO7yf_AfZgDPUmoCdMreSDhPPROwkiWk8jQC * tools/skia_goldctl/mac_amd64: aGSV8FRvSVFoQndmtzdgxKhvRR5fHzqV4Out1xJ8IdQC..Cb2Fx5W46eaNENhgoYiw8Tabe1JjHh7MEjab7fYNmjEC * tools/skia_goldctl/mac_arm64: J_hsft9STSA1c91EbHgGONUGi_KYtolnyIbXIM_1ps8C..yEMI787ucvQWVBOeW4q8TMjvZz_yNOwB1aKRtLYfR1kC * tools/skia_goldctl/win: iu7P4Y4eMVlvfq6mCvSlP12RQuqVdmIjndnnxIbxy4IC..uk3Q5uckAHDJH6eZZtZzxgWfE_SSuRlZ38RpWSjFIu8C No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I37fccee175780e57dafe072bb8a3fd9ee514a2d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6199491 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 8c317940 2025-01-16T17:51:12 Vulkan: Add feature flag to use VkEvent for buffer barriers Bug: angleproject:360274928 Change-Id: Ie6e48a0a57c016571a1e94c0105a231c749c76f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6180394 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 8c298ec9 2025-01-12T22:53:32 Vulkan: Use surfaceless queries with headless EGL configs Bug: angleproject:389342064 Change-Id: If5ec101f5ef5135febe3fe12d5c309fe2a35f07c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6169254 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Artem Kharytoniuk d7ea4b2c 2025-01-06T20:40:48 Vulkan: Use syncval extra properties for error suppression Bug: angleproject:391284743 Change-Id: I594a70e7d06f1d73647407dbac1afece666a7c5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6180310 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alex Dean d926d80d 2025-01-16T09:53:35 CL/VK: Fix enqueueFillImage & enqueueMapImage lock and waitlist Fix in enqueueFillImage and enqueueMapImage. Semantically should be using scoped lock and processWaitlist() instead of enqueueWaitForEvents(). Bug: angleproject:390387802 Change-Id: I86173a079aa7fdd54a8b7158ec8214147cfb7cd2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6179619 Reviewed-by: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand b5c12605 2025-01-22T13:44:13 CL: Limit max work size/offset to UINT32_MAX Set a hard limit of UINT32_MAX on work item/offset for OpenCL's clEnqueueNDRangeKernel cmd for all backends (simplifies handling). Bug: angleproject:42267067 Change-Id: Ied1685609b3818e4c3a366a03770dc361198639c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6191436 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Austin Annestrand <a.annestrand@samsung.com>
Roman Lavrov adb52e06 2025-01-23T17:36:44 Avoid unnecessary copy ctor calls of gl::DepthStencilState That object has a user defined copy ctor to copy padding (https://crrev.com/c/783990). This together with copying instead of using a reference results in a function call (which just wraps memcpy) Bug: b/383305597 Change-Id: Ia92e726a887bd12ab14c1ca53f79c0b13b57a199 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6194695 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 41225dc8 2025-01-24T02:01:17 Roll SwiftShader from 73053a0586b0 to a87fa39f6446 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/73053a0586b0..a87fa39f6446 2025-01-24 dneto@google.com tests/kokoro: use clang-format 13 2025-01-24 dneto@google.com tests/kokoro: use gcc 13 instead of gcc 9 2025-01-23 syoussefi@google.com Support VK_GOOGLE_surfaceless_query 2025-01-23 victorvianna@google.com [cpp23] Remove usage of std::aligned_storage/union<> in swiftshader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I5a5bb5bca6819bf57c562def1c3f275e15742aeb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6198020 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c51485be 2025-01-24T10:01:25 Roll vulkan-deps from dcf521eec97a to 1b571b5a7b3c (5 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/dcf521eec97a..1b571b5a7b3c Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/22a33d6742e2edfcdab947179c073428b427be9c..bd1f1c263fc10969eb4a4b393e774a75ffcb2673 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/4aa537a5c6bef1fea7edea718a564bc0a1869450..e02275ec02b68e3d175528f768871c97ae9eee90 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/30169d29b89039700b9fd7d3d01f62f3e2641847..afad70fbb26c643b19cf53a5990852a4d83664b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I81b373f5ab340f134a08d140a61c0d3a8d82e985 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6196640 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 57eee4fa 2025-01-24T07:02:28 Roll Chromium from 098b675df0b0 to 67eb0a3b5a40 (601 revisions) https://chromium.googlesource.com/chromium/src.git/+log/098b675df0b0..67eb0a3b5a40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/962bdd52d3..e13953ced0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cd8c3f3a23..e0898cdec9 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3c28682788..5f29517d08 * third_party/android_build_tools/error_prone/cipd: Q3oiuVxuq1jkWhjfnfCSviXK8BbbB9n6_4jz3x_Mo3kC..DFqEkqm_CBBWylsmJnAMv2md7Kx6X9l3I3y8De6nmuAC * third_party/android_build_tools/manifest_merger/cipd: XR6gkuLVsVOJ1Ysmv0JCjHrWaTNjvh2a6EwSENxyrqsC..ESxV7cNgPg8y2RupSn5lYWBzQQMMK5Ai729X_Zhv_zwC * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/d430128984..16e8416791 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/49e10123de..8c858fc98c * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/8205ccf0f2..7e0f3a8471 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/7fb16ccf18..b24bb82dd0 * third_party/r8/cipd: ZTHhAJg0CQvNxfBmE7mECwY-jJDQ7kknVwVvZpQzLLIC..3iC3eGx7wAPZJhIJjRdLvqyiJHhKFVT1Eq6-uccHw9oC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/179c871982..9d0d7c0c17 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/cd073aaae9..0d66cc525a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/facb7d1306..e262f0f889 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d7b110a48a..b3fef6ee99 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I856d7f1e5cbd18294801a544245d12d52377c536 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6196639 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 54b69688 2025-01-21T11:28:59 Vulkan: Add max memory allocation size limit check During memory allocation, we should make sure that the attempted allocation size does not exceed the maximum allowed size. Failure to do so may result in validation errors. * Added the following object to the renderer: mMaintenance3Properties * It holds the following device property: maxMemoryAllocationSize * Inline renderer function: getMaxMemoryAllocationSize() * Buffer and image allocation sizes will now be checked with the function above. * In case of exceeding the maximum allocation size, a device OOM error is returned after issuing a warning: * MemoryAllocationTracker::onExceedingMaxMemoryAllocationSize() * Removed the suppression for the test failing due to this issue. * Removed the maxMemoryAllocationSize VVL skip targeted for MockICD. * Suppressed tests on S22 that now fail due to exceeding this limit: * KHR-GLES[31/32].core.texture_buffer.texture_buffer_max_size Bug: angleproject:391002353 Change-Id: Id271066bd872c80344ef8531653afda3e6b40a93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6187981 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Charlie Lao c3f9109e 2025-01-09T17:22:41 Vulkan: Change EventMaps from struct to class For better encapsulation, this CL turns struct EventMaps to class RefCountedEventArray. Bug: angleproject:360274928 Change-Id: Ie28996fdb95d5a830399e6fa6cd5602f403e8725 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6164698 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao c7ad15e3 2025-01-23T13:37:28 Vulkan: de-duplicate ImageHelper::barrierImpl and barrierImplOneOff barrierImpl is renamed to recordBarrierImpl barrierImplOneOff renamed to recordBarrierOneOffImpl barrierImpl contains all the common logic between recordBarrierImpl and recordBarrierOneOffImpl. Bug: angleproject:390443243 Change-Id: I01ce9ea3f1f0acb30fe0efcdd20bd1caaa248a7c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6195570 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao fbd230f5 2025-01-23T12:59:06 Vulkan: Split ErrorContext into ErrorContext and Context ErrorContext continue to be context for error handling. vk::Context is added to serve as common base class for ContextVk and CLContextVk. Bug: angleproject:390443243 Change-Id: Ifac0b1d2d714ce610693ce60a35459c6c9cddf1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6191438 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 1250a7d9 2025-01-23T22:04:25 Manual roll vulkan-deps from e8b712767b9e to dcf521eec97a (52 revisions) Manual roll requested by romanl@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/e8b712767b9e..dcf521eec97a Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b5dc38707208efae0b7a1606790ca33d237d950e..22a33d6742e2edfcdab947179c073428b427be9c https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/4446967600048557909231722d2c92212b6ca258..3f129d076b44221b8b56a63215446d33b570ced8 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/b9d5ced92ac454caf526c3b80d5105a1f38878ce..4aa537a5c6bef1fea7edea718a564bc0a1869450 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/315964ad5aabd5b148a484e5fbea8a365c8d1eb3..8ce2501d2511b6f4e6389a03ff08c4e84d54fa25 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/7b23ba7a5f86936a8d783baf64a77c38977d6890..f07e27717a642fa193c967440f21ed634ea17987 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/1ce4b30307301d20d58040e088eb57c5ea8bb6ad..30169d29b89039700b9fd7d3d01f62f3e2641847 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Iccfe07746c3b344b5e5aa48653a9a5f90967f854 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6195571 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi c1214ec2 2025-01-22T14:22:56 Vulkan: Rename Context to ErrorContext In preparation for adding another Context (derived by GL and CL contexts), which includes logic that pertains to command recording (such as barrier tracking). Bug: angleproject:390443243 Change-Id: Idf495b62e63fb9aa901a2f16447fdaf3c2acd90b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6191248 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov 92cc4e02 2025-01-22T16:07:00 Vulkan: Fix incorrect initial RP layout for shared present Renderpass was using `ImageLayout::ColorWrite` as initial layout for the SharedPresent image. Vulkan validation did not detect errors because of limitations (or bug?): once command buffer with barrier is submitted, layers no longer track the current layout, and therefore skip the check. In other words, it seems like VVL only track layout transitions within a command buffer. Transition to `ImageLayout::SharedPresent` currently performed using one-off command buffer, which is always immediately submitted. This is the reason why VVL was ignoring the error for so long. Bug was discovered in `EGLSingleBufferTest.AcquireImageFromSwapImpl` during local testing, where one-off command buffer was replaced with outside RP commands. Other tests were still working fine, because they are using `glClear()` in the very first flush - no renderpass in the first submission, and so VVL can't track the layout once it is used in a renderpass in the second submission. Bug: angleproject:42262606 Change-Id: I19404b5be706e54e53890c2fec9cb4796296c698 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6182598 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Yuly Novikov 2d71b6b7 2025-01-23T16:56:02 Suppress dEQP failures on S22 dEQP-GLES31.functional.geometry_shading.instanced.geometry_output_different_32_invocations dEQP-GLES31.functional.geometry_shading.instanced.geometry_output_different_max_invocations KHR-GLES31.core.geometry_shader.primitive_counter.* KHR-GLES32.core.geometry_shader.primitive_counter.* Bug: angleproject:386749841 Change-Id: I41f399ab914d000d6b606170b6d191b61840eec8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6194732 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Torne (Richard Coles) b2349dbf 2025-01-16T15:51:42 Sync third_party/android_system_sdk metadata with Chromium. ANGLE's DEPS currently reference the same version of the system SDK as the main Chromium repo but the README and OWNERS have lagged behind; copy the current version over from Chromium. Bug: chromium:378273193 Change-Id: I3709b4866ee96377a9e4a95ce2a6228261c9cdcf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6179719 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Richard (Torne) Coles <torne@chromium.org>
Austin Annestrand 55f421f6 2025-01-22T13:47:29 CL/VK: Add missing ArgumentWorkgroup case Missed nop-case when processing kernel resources during enqueueNDRangeKernel (avoids false-reporting of UNIMPLEMENTED during routine). Bug: angleproject:42267067 Change-Id: I0785ab94769fcb9b28ca0ff86d8104cc95056e5d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6191435 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 47bb7b7e 2025-01-23T02:01:28 Roll SwiftShader from b99f866d5a5c to 73053a0586b0 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/b99f866d5a5c..73053a0586b0 2025-01-22 ynovikov@chromium.org Fix Gerrit authentication If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I96bd9dd038d03cebfaca892f1694dd22f90b5533 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6193757 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 901010cd 2025-01-22T16:09:36 Update the submit access permission group Bug: b/389769530 Change-Id: Ic5fae18b55ccf750aa94779f90b5e959ec406a1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6191473 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll fb7f19d8 2025-01-23T07:05:23 Roll Chromium from 3360895f5dfb to 098b675df0b0 (646 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3360895f5dfb..098b675df0b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8fe56cd1b6..962bdd52d3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/debf7b946c..cd8c3f3a23 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/5cc19c9883..3c28682788 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/9325732da8..6fba8f15dc * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a4131b9447..49e10123de * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/a485ddbbb2..7fb16ccf18 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/a4e44a8e44..6f49850910 * third_party/r8/cipd: IeZEJCRJvyn60PrXJLIyw7cb3gwHgcMv3bxkNOh3jZYC..ZTHhAJg0CQvNxfBmE7mECwY-jJDQ7kknVwVvZpQzLLIC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/4029e38509..179c871982 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/99dfe10b67..cd073aaae9 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/594fb4f80b..facb7d1306 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bf624dc83c..d7b110a48a No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I1aa14fb4609d9a46826345fdd04b9a08098f79ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6191635 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 40267ddc 2025-01-14T12:51:00 Vulkan: Add bufferWrite for multiple shader stages This is mostly a clean up CL. When a buffer is used in multiple shader stages, it was inserting barrier multiple times by calling bufferWrite in a loop. This creates unnecessary barrier against one shader stage to another shader stage. This CL adds a multiple shader stages version of bufferWrite that takes "const gl::ShaderBitSet &writeShaderStages" as an argument, in consistency to bufferRead. Otherwise this creates a problem in future CLs where we use VkEvent to track the write and you end up with WAW of the VkEvent that has not submitted. Bug: angleproject:360274928 Bug: angleproject:42262235 Change-Id: I923dc9df39318d337f67f4fa0f6a68f336df24f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6180948 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 51cdae04 2025-01-21T18:41:15 Update dEQP-GLES2.functional.shaders.random* test expectations Most tests have been fixed with the latest qualcomm drivers, except 1 test is still failing: dEQP-GLES2.functional.shaders.random.all_features.fragment.39. Bug: b/328156792 Bug: b/338287961 Change-Id: Ib2ff74c6ae7e9f39958617fb8d00b9b1f89878ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6188697 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu 0acd0a17 2025-01-21T18:31:32 Remove fixed dEQP-EGL.functional.*pbuffer tests from skip list These tests pass with latest ANGLE version d9c0aa4aff. Bug: b/330906568 Bug: b/328156792 Bug: b/332784194 Change-Id: Ib42fe3cfb22f3f7a1bd84609f927cc47613a4920 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6188696 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu 9867010e 2025-01-21T18:17:37 Remove fixed dEQP renderbuffer test from skipped test list Test passes with the latest ANGLE version d9c0aa4aff. Bug: b/328156792 Bug: b/333959262 Change-Id: I231feb43af69a1dab877fd3d3bd915b73d56d4b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6187619 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu fd94ce5b 2025-01-21T18:05:41 Update the deqp blend equation advanced test expectations on qualcomm Some of the dEQP-GLES31.functional.blend_equation_advanced* tests are fixed by the latest qualcomm drivers. There are 9 remaining tests still failing. Update the expectation file with these 9 tests. Bug: b/328156792 Bug: b/345581214 Change-Id: I995b0f8a14d18f8ed4d1cdd27c334bdb09387d97 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6187617 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuxin Hu e5a4924e 2025-01-21T17:42:50 Remove fixed dEQP copy texture tests from skipped test list Tests passed with the latest qualcomm drivers. Bug: b/347306270 Bug: b/328156792 Change-Id: I8d6c0cb04d13635a91b0d774c56d8f3f72bc0e4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6187616 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxiang Qian 308cfc62 2025-01-13T14:54:18 Do not reset buffer age after query The spec doesn't mention that we need to reset the buffer age if no rendering after last call of eglQuerySurface to query EGL_BUFFER_AGE_KHR. Age was also reset after first time of query. Remove it to align with spec. New end2end test is also added. Bug: angleproject:391039188 Change-Id: I00c96e3a71ea2c9abcb86ebaf520243408dedd52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6185135 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Dirk Pranke 072eec08 2025-01-21T13:09:44 Use `exec_script_allowlist` in GN now that it is available. This CL renames the gn dotfile variable `exec_script_whitelist` to `exec_script_allowlist`, in order to be more inclusive. Bug: chromium:40713186 Change-Id: Iaf5ef131a64f3189e675acfd090c7043c3138df8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6188240 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Charlie Lao 1d25be59 2025-01-09T11:09:22 Vulkan: Pass Context instead of Renderer to BufferHelper APIs This is preparation CL for later CL. In later CL we need to access context argument in BufferHelper's barrier related functions. release() also preferred to have context argument so that the events can be recycled within share group. Because of this, a lot of functions has to propagate back to pass context as argument instead of renderer. Bug: angleproject:360274928 Change-Id: I13e930666eeeefbcff7b542d0e3126f3b07ce286 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6164686 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 680ff1f4 2025-01-22T19:17:40 Suppress flaky end2end test on Linux NVIDIA Vulkan ClearTextureEXTTestES31Renderable.Clear2DArray ClearTextureEXTTestES31Renderable.ClearCubeMap ClearTextureEXTTestES31Renderable.ClearCubeMapArray Bug: angleproject:362486580 Change-Id: I4254a4c28cb0b201d9e94511d5ddc8cce975d1c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6190629 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Yuly Novikov 4be68add 2025-01-22T18:24:24 Skip OcclusionQueriesTest.WrongSkippedQuery Fails on Win Intel UHD 770 Vulkan Bug: angleproject:388144480 Change-Id: Iee4bbae63991bb7d678bdd0777b45647322f3843 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6191327 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov e029a2f2 2025-01-22T14:48:16 Fix llvm-libc README.chromium Bug: chromium:391452992 Change-Id: I0fdc64035a36067b146afb73cd1f684b4496909e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6189887 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
WeiCong Yu 90e3f6bd 2025-01-17T23:10:55 executable path has non-ASCII characters, metal not available On ARM64 MacOS 15.0.x, Metal Shader with newLibraryWithSource didn't work if the executable path contains non-ASCII characters. Bug: chromium:389559087 Change-Id: I0482c01e2a11973f56c712b36062ed78f3cecf9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6174286 Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Igor Nazarov d8a95bf7 2024-12-19T17:35:05 Vulkan: Protect OneOff commands recording with pool mutex Bug: angleproject:384940864 Change-Id: I518c54ae4b0fc5da0e58d330f8c531bc8d65529e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6108843 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll 4237cca5 2025-01-22T07:35:51 Roll Chromium from f7e71ead6201 to 3360895f5dfb (583 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f7e71ead6201..3360895f5dfb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/07bda45dd1..8fe56cd1b6 * buildtools/reclient: re_client_version:0.174.0.d516e7c7-gomaip..re_client_version:0.175.0.98046de5-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8dfce7d0d7..debf7b946c * third_party/android_build_tools/lint/cipd: Tg-Mjqa6mWRSbiUa675M1IqGLmr236y3smiJ-Qdz5gkC..1veHvODGn5XZ5IcxP36LQZ16pvydqdtMVqfm4Bj3EFcC * third_party/android_build_tools/manifest_merger/cipd: yd6w2zQr48NAkrzrzEj2OmMzI-kANsmD6lvKhfXluAsC..XR6gkuLVsVOJ1Ysmv0JCjHrWaTNjvh2a6EwSENxyrqsC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/16be26db22..9325732da8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/40e4ea3b09..a4131b9447 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/12809bfa85..a485ddbbb2 * third_party/r8/cipd: DJU_YH-xmuJ4kRnli6eXC-q9Q21-GPFj4YVZyAqKSWoC..IeZEJCRJvyn60PrXJLIyw7cb3gwHgcMv3bxkNOh3jZYC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/668908cb48..4029e38509 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/8b8933b592..99dfe10b67 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b248a90291..bf624dc83c No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I9f4ff271488b1b3062868e2f15870017840dff5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6188711 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 3734b432 2025-01-21T14:24:42 Suppress some clear tests on Linux/Intel/GL * Suppressed the following tests on Linux/Intel/OpenGL due to observed flakiness on the bots: * ClearTextureEXTTestES31Unrenderable.Clear3D * (ismatch in output values) * ClearTextureEXTTestES31Renderable.Clear2DArray * (FBO status is shown as incomplete) Bug: angleproject:384967031 Change-Id: I46e23e95619c6836b03edf6a52514b138f1542dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6182634 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Charlie Lao a5016e31 2025-01-17T17:50:27 Vulkan: Fix typos found by gerrit spellchecker Bug: angleproject:360274928 Change-Id: Idbffd7a4609f28d161bd0a11ace817856dcd750c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6182930 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 0afc3323 2025-01-21T12:46:28 Add fast path to ValidCap for most frequent cases glEnable/Disable are commonly called with the ones that are now on the fast path. GL_POLYGON_OFFSET_FILL seems slightly less common but still frequent enough to be inlined. This noticeably reduces the number of function calls in DO2 trace as well as branch predictor load (confirmed by cpu counter stats from a mobile device), and just this change appears to improve wall_time a bit. Bug: b/383305597 Change-Id: I8fa42de64d79f6638b312891f440d796dd95c57c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6184086 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov e06a8369 2025-01-21T14:56:09 Tests: fix IndexConversionPerfTest using unaligned offset Breaking Win perf bots since https://crrev.com/c/6151227 Bug: angleproject:385264236 Change-Id: I807b9823b5e1dfb12ec4ee7fe48d6addd568c224 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6187621 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Neil Zhang 0554e7f0 2025-01-09T10:05:12 Vulkan: Resume render pass queries when render pass reactivates Bug: angleproject:388144480 Change-Id: Ibcf3b247f347705feed4aa43d237406ccb142704 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6185098 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Steven Noonan 801993bc 2025-01-18T21:48:41 handle Qualcomm's mixed vendor IDs This is a weird situation. Up until Qualcomm had a native Vulkan driver for Windows (with the Snapdragon X series chips), the only vendor ID observable on Windows was 0x4D4F4351. This was reported through DXGI, device manager, etc. But with their native Vulkan driver, they now report 0x5143 as well: VkPhysicalDeviceProperties: --------------------------- apiVersion = 1.3.295 (4206887) driverVersion = 0.807.0 (2150789120) vendorID = 0x5143 deviceID = 0x36334330 deviceType = PHYSICAL_DEVICE_TYPE_INTEGRATED_GPU deviceName = Qualcomm(R) Adreno(TM) X1-85 GPU pipelineCacheUUID = 0eba4509-4351-0000-0000-010c05430000 And yet, DXGI still reports 0x4D4F4351. Cool, huh? Let's teach IsQualcomm to understand both vendor IDs to ensure the device is correctly detected as a tile-based renderer in the Vulkan backend. Bug: angleproject:390866623 Change-Id: I9170c30262ace269498f066e922a279c7e981de6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6183621 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Steven Noonan <steven@uplinklabs.net>
angle-autoroll 012d4353 2025-01-21T09:15:22 Roll Chromium from 367ef52f4b2b to f7e71ead6201 (386 revisions) https://chromium.googlesource.com/chromium/src.git/+log/367ef52f4b2b..f7e71ead6201 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/64e296c42a..07bda45dd1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e52ba4f90d..8dfce7d0d7 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3bc6350ea4..5cc19c9883 * third_party/android_build_tools/error_prone/cipd: 7c91BXn6VPvSmr-dFRYaNVkfHjRN1jdMIN4EcrPem9cC..Q3oiuVxuq1jkWhjfnfCSviXK8BbbB9n6_4jz3x_Mo3kC * third_party/android_build_tools/lint/cipd: _77LT8DN3c2A3RPC4ctJk-kOk2K_QEuS3_aQty7g384C..Tg-Mjqa6mWRSbiUa675M1IqGLmr236y3smiJ-Qdz5gkC * third_party/android_build_tools/manifest_merger/cipd: osgd04hyZB3eu5L7oiL6irk9AqRBX9lOxNLsaCmUCowC..yd6w2zQr48NAkrzrzEj2OmMzI-kANsmD6lvKhfXluAsC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b15611f18b..16be26db22 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/80d1969422..40e4ea3b09 * third_party/r8/cipd: PO3aHSPf_6XsPQhr5ej6sRCj8EXUTKutmhlFCLBeak4C..DJU_YH-xmuJ4kRnli6eXC-q9Q21-GPFj4YVZyAqKSWoC * third_party/r8/d8/cipd: U3Jf_ewWOZyxa6vyO3wjNIgm8XIz1yFk-4k3-wqDL44C..DJU_YH-xmuJ4kRnli6eXC-q9Q21-GPFj4YVZyAqKSWoC * third_party/siso/cipd: git_revision:0721be7440a7c67f8369fcce1ca01932638641bb..git_revision:6e20453c920920cade25e28fc443472eb22ddb41 * third_party/turbine/cipd: dz8pRLjwNlToJ0tS14T-TDQJNikmFXEDByMo-OzBbl0C..qNNUfaj7w4cSHTjVawVaZpq0pABVec9LcFebN19wm4EC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/b9cb8f8d3e..8b8933b592 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f3f536fa16..594fb4f80b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1d1846688b..b248a90291 * tools/skia_goldctl/mac_amd64: i1pCGOButmwiJERJNRCcVJvvq5eJVXmgn6naqj5pIUwC..aGSV8FRvSVFoQndmtzdgxKhvRR5fHzqV4Out1xJ8IdQC No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I481e1b0915a65ada5c018bb3a64fac1eb1eee42f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6186864 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0