doc/ContributingCode.md


Log

Author Commit Date CI Message
Geoff Lang ab0140b0 2024-04-25T10:23:51 Update CLA contact information in the documentation. Bug: angleproject:0 Change-Id: Iefc4527fd6ddf79e319cef8ff8a92a791fb47547 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5489679 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi d788c2c0 2023-12-04T22:43:39 Remove team members no longer part of the project Bug: None Change-Id: I66bf34ece50995fdecfab55a2198e9946e9be4cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5087208 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Caleb Raitto 95c60d90 2023-02-07T16:39:46 Fix broken links https://chromium-review.googlesource.com/new-password serves a 404 -- it's changed to https://chromium.googlesource.com/new-password Bug:chromium:1412557 Change-Id: I229d8f493d2452c929b872ac79cb3434e6ceeaab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4224884 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Lingfeng Yang 8f9b6d29 2021-10-04T13:35:30 Add advice to download commit-msg hook Thought this was taken care of with `gclient sync` but it seems like a manual download is needed now. Bug: angleproject:6517 Change-Id: I87499149b810c873827883628104963178a14fed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3203171 Commit-Queue: Lingfeng Yang <lfy@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Jamie Madill 2c9226e6 2021-10-04T16:07:23 Add docs on how to request CQ/issue tracker access. Bug: angleproject:3096 Change-Id: I375c19826855ad10d94ae24c8f32a06df93245aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3202477 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Ian Elliott 312e91c8 2021-07-16T14:25:35 Two fixes to DevSetup.md Change master->main and eliminate a redundant/premature Linux instruction. Bug: angleproject:0 Change-Id: Ic7171f860de8acc22050a4d4858cfd318f36b9e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035863 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
John Plate 8650381e 2021-03-10T20:08:10 Avoid implication that adding the issue number is optional Bug: angleproject:1944 Change-Id: I89867c20c724c8db4d8edeb15fa4e32769f2a578 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2749596 Commit-Queue: John Plate <jplate@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Ian Elliott a2491911 2020-10-07T13:56:37 Document how to revert/reland a CL Bug: angleproject:5141 Change-Id: I9a0a2ae18dc298250f8fc6fba2eb0042a31dc369 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2458846 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 0bba1100 2020-03-27T14:39:44 Update OWNERS information. Also includes some documentation maintenance. Bug: angleproject:4511 Change-Id: I7ecce494909f06387875ff85a10004d0c446bbaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2124597 Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jamie Madill 457588ef 2020-03-16T14:11:33 Add more documentation on testing infrastructure. Adds more info on the amount of testing ANGLE runs and our various configs. Adds a few other notes and cross-links. Bug: angleproject:1944 Change-Id: I76e46783bd6a3f84d3e170bd30ea2e6d57911143 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2105715 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 5efb36b9 2019-11-25T16:14:55 Automatically call flex/bison if necessary ANGLE translator's parser code generation is changed to use the binaries of flex/bison stored in the cloud. scripts/run_code_generation.py now automatically runs these files if the input files change. Bug: angleproject:3419 Change-Id: Icce4247f93b27baf8ee12dbb16112fa2cc98c111 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940572 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 96c696db 2019-07-17T14:16:03 Update the documentation on ANGLE's two reviewer policy. BUG=angleproject:3704 Change-Id: I3df6f7935397b4a98db0eed569868def3e0fd701 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1707113 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang ba9a21af 2019-04-15T09:25:25 Update suggested reviewers documentation. BUG=angleproject:1944 Change-Id: I17becf44a86969c0929e51b548cf90220027fb75 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565060 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Frank Henigman ddc41208 2018-08-23T22:11:55 Rename .gypi -> .gni. Rename and reformat all gyp files. They were previously converted to gn but not renamed to preserve continuity in git. This rename completes the removal of all traces of gyp. BUG=angleproject:1569 Change-Id: I50123105d8881583184ffc564bed65d9fbe4d41c Reviewed-on: https://chromium-review.googlesource.com/1187885 Commit-Queue: Frank Henigman <fjhenigman@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Frank Henigman a7f97a27 2018-08-21T00:04:05 Gyp is dead. Long live gn. Remove the gyp build. The .gypi files were not renamed so that diff and rebase would work on this change. They will be renamed in a separate change. BUG=angleproject:1569 Change-Id: If8a217027633293664b820104f91a4ca5889b24e Reviewed-on: https://chromium-review.googlesource.com/1187380 Commit-Queue: Frank Henigman <fjhenigman@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill ac6d90ea 2018-08-21T13:10:36 Add more test param documentation to perf tests. Also add links from other pages. Bug: angleproject:1944 Change-Id: I344ce075973bd45942d52b819385cb74a5a073ca Reviewed-on: https://chromium-review.googlesource.com/1183629 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Geoff Lang aac6df40 2018-03-12T13:00:33 Update documentation to mention ANGLE committer status and bug editing permissions. BUG=angleproject:1944 Change-Id: I37d6f22c18e65bd53b75702f0f13ec818b83c34d Reviewed-on: https://chromium-review.googlesource.com/959224 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Luc Ferron <lucferron@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Geoff Lang bf0a40bb 2017-12-01T11:30:14 Improve documentation about selecting intial CL reviewers. BUG=angleproject:2274 BUG=769026 Change-Id: I8128a438a0831ebc4d6693085a41c41182d259c7 Reviewed-on: https://chromium-review.googlesource.com/803854 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Frank Henigman c677795f 2017-11-27T00:15:54 docs: fix links and typos Update stale/broken links. Use consistent link style: - links between our files should relative - omit filename for links within same file - don't specify heading id Don't use same heading twice in one file because the markdown compilers on googlesource.com and github have different ways of disambiguating them, so this is the easiest way to have links work on both sites. BUG=angleproject:1569 Change-Id: Iefd5ab8014d582a017f64e383f301ea0b8e60433 Reviewed-on: https://chromium-review.googlesource.com/789445 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Jamie Madill d0fcb90d 2017-03-21T17:39:21 Update testing documentation. BUG=angleproject:1944 Change-Id: Iac643f896cfb4c8c23474c744fcb2a073207db26 Reviewed-on: https://chromium-review.googlesource.com/457430 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Frank Henigman c31b7411 2016-12-08T21:57:19 Fix typos in docs. BUG=None Change-Id: Ib201d91c586717b3027996b379240619173d828d Reviewed-on: https://chromium-review.googlesource.com/418337 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Jamie Madill 5e2e145d 2016-12-01T12:50:11 Update bison/flex docs. BUG=None Change-Id: Id4b9674b6e98b8313c47f3fbc78cc93d137ec14c Reviewed-on: https://chromium-review.googlesource.com/415569 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
anatoly techtonik 27b96979 2016-06-03T09:14:57 Add how to update working copy after change is submitted Change-Id: I387249d29822d91a6126f6c25cb35e8b80cb4c36 Reviewed-on: https://chromium-review.googlesource.com/349460 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
anatoly techtonik 064da41c 2016-05-23T16:43:40 doc/ContributingCode.md add more links needed at given context Change-Id: I331ac7b24fd35735a0822a6b86ece66e1847f475 Reviewed-on: https://chromium-review.googlesource.com/347130 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang f85a8439 2015-11-03T11:15:31 Update the testing documentation to include the trybots. BUG=504872 Change-Id: I9cbbe92afc9df6a4cb8f3ddf0c547492c6765c8e Reviewed-on: https://chromium-review.googlesource.com/310011 Reviewed-by: Jamie Madill <jmadill@chromium.org> Tested-by: Geoff Lang <geofflang@chromium.org>
Jamie Madill 951fffd3 2015-07-20T16:56:52 Update ContributingCode to mention 'git cl format'. BUG=angleproject:762 Change-Id: Ic0f862ac901eb793266e68ce26cc9be67d5cb12d Reviewed-on: https://chromium-review.googlesource.com/286862 Tested-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Geoff Lang 13e569d5 2015-06-05T14:33:37 Move the most popular wiki articles into markdown files. Change-Id: Ide6ef3d9995d1f3f66de4b340a60b4bf350a9ddb Reviewed-on: https://chromium-review.googlesource.com/275479 Reviewed-by: Shannon Woods <shannonwoods@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Tested-by: Geoff Lang <geofflang@chromium.org>