kc3-lang/angle

Log

Author Commit Date CI Message
Shahbaz Youssefi ae5c3b96 2024-10-08T17:02:21 Boilerplate for GL_ARM_shader_framebuffer_fetch_depth_stencil Bug: angleproject:352364582 Change-Id: I94c670db5546564a6f60bb513a6d7f3f5bd5778c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5916771 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 3e8d09a1 2024-10-08T17:01:02 Vulkan: Enable FRAGMENT_SHADER_FRAMEBUFFER_FETCH_MRT_ARM ANGLE correctly handles MRT with gl_LastFragColorARM, this property should have been set to true. Bug: b/269233744 Change-Id: Iaa554df57292fcc5c12281e2e098b6451f63d5e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5916770 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski c9606f00 2024-10-07T10:15:14 Fix extensions moved to core in GLES 3.2 The GL_EXT_texture_cube_map_array, GL_EXT_texture_buffer, and GL_OES_texture_storage_multisample_2d_array extensions were moved into core in ES3.2, but validation still required enabling extensions. Added 3.2 as a sufficiency. Test: angle_end2end_tests --gtest_filter=*CompressedTexImageCubeMapArray* Bug: b/371940347 Change-Id: Ie73a76087b6b52775d44ae79efd7f48e9fc90eb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5912120 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Cody Northrop 30ae44bf 2024-10-09T14:17:03 Tests: Skip going_balls on Windows Intel Bug: b/372513853 Change-Id: Iec11e1acf3a36f7261cf46adcdfedd826ac88050 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5922076 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Cody Northrop 98b5cf46 2024-10-08T19:50:18 Tests: Add Piano Fire trace Test: angle_trace_tests --gtest_filter="*piano_fire*" Bug: b/372291936 Change-Id: Ia3ad52781e251c01246fb01fd800112b0d0f82d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5918738 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 2bb5b443 2024-10-08T19:39:30 Tests: Add Billiards City trace Test: angle_trace_tests --gtest_filter="*billiards_city* Bug: b/372288799 Change-Id: I2e23d648d8fe27807ccbab26c28ad509349d2a01 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5917649 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Cody Northrop ba292370 2024-10-08T19:58:29 Vulkan: Disable imageless framebuffers on Qualcomm and PowerVR * Qualcomm with imageless framebuffers, vkCreateFramebuffer loops forever * PowerVR with imageless framebuffer spends enormous amounts of time in framebuffer destruction and creation. ANGLE doesn't cache imageless framebuffers, instead adding them to garbage collection, expecting them to be lightweight. Tests: dead_cells, chrono_trigger, batman_telltale Bug: b/369693310, b/372273294 Change-Id: I43714154661c4415ec10511ed096da7c23a9a8ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5918740 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Solti f0a66ba2 2024-10-09T00:26:15 remove angle_gl_driver_all_angle when resetting Test: presubmit Bug: b/367348883 Change-Id: Ief115403cd2a908873750c97f416255e61410893 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5918343 Commit-Queue: Solti Ho <solti@google.com> Auto-Submit: Solti Ho <solti@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 4984fe12 2024-10-08T14:37:15 Add a test for framebuffer fetch and multisampling To ensure that the fragment shader is implicitly run per-sample, such that the read values are per-sample. Bug: angleproject:42264719 Change-Id: I66968ea2dd92106f222ad6a43ffef0e75ad36528 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5917026 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 1c14a0b0 2024-10-09T09:51:08 Roll Chromium from 3bc95aca3c88 to a2c49c9bb8d4 (704 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3bc95aca3c88..a2c49c9bb8d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f2790bfa32..9061d30e63 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/42e3e21a6d..0a905dcb6d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e702ecee42..3e8bac7e47 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/af5dc104cd..4479191661 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c109945e72..cd2f5c45b2 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e8d7247aa3..f114473071 * third_party/r8/d8/cipd: yEomA-IPmb_JtuiEvwgtxRHtSEaICkDY1sDko_rQGO0C..3KCj5eRYCvGGYs5i90pRaeihkzsqgUGc4OkICT8AOlIC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7972e4dcd8..b034f0989d * tools/skia_goldctl/linux: -WwsoLGIeY9CdK9XppXR9Q_l6IVn4roukf6qEQv5YNwC..BdWMV7sJLp28VJJNlam5_ltmby9s48pcPT-5B0JK8XoC * tools/skia_goldctl/mac_amd64: hhcjERw_9St0a6aoG-4qcqu3as4VN_08SbDnaNcm53oC..9fL0fAY6ZL6WvmlHB3sbhAk0X_gUAkWqEPhD6OvvXHYC * tools/skia_goldctl/mac_arm64: FBgwCI1fflbcYLhG8hlzODBQIBcYe9MPiFFR_tcTBJEC..MkLRSRGZOHFEwEODhaoBZgH5cnuASaGzk9LFCcZyERQC * tools/skia_goldctl/win: 4nH7g70rYeJlUxm49v3invhG2FjAPPK18QlAZ6gwVVoC..kNBzNzYf8OoLGUy6DKauab6uj2G176E0fz_em9akpGAC No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I50511d340b5672030af9ad54f4fa5e21a60d8eae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5917461 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov d0e2141a 2024-09-30T16:55:59 Tests: GLES1 offscreen replay uses GL_OES_framebuffer_object ANGLE allows to mix GLES1 with non-GLES1 calls but the native driver crashes on e.g. glGenRenderbuffers. Use GL_OES_framebuffer_object so that we can render ANGLE and native the same way (glGenRenderbuffersOES etc) There is no glBlitFramebuffer for GLES1 though, so instead of that render a single frame to the default framebuffer. Also resize the grid from 1/3 screen to fullscreen for more useful screenshots, and remove window /= 4 resize to simplify. Bug: b/370508393 Change-Id: I9c8ac46937aa09f1be186a07548c1ec7e5b15579 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5899376 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi 878e1c92 2024-10-07T16:34:54 Vulkan: Fix line-loop draw arrays after elements Currently, when drawing line-loop arrays in Vulkan, an index buffer is created to assist in drawing (since Vulkan does not natively include a line-loop draw mode). However, when LL array draw calls are mixed with non-LL element draw calls, it can lead to some rendering issues due to the fact that the proper index buffer is not obtained. * In VertexArrayVk::handleLineLoop(), if the cached indices are the same as the last draw, the same index buffer is obtained from the LineLoopHelper object. * (Using the newly added getCurrentIndexBuffer()) * Added unit test in which a triangle element draw is places between two LL array draws. Before the fix, the second LL draw would result in an incorrect line draw. Bug: chromium:40911000 Change-Id: Ibba9a0cb2b77a2b6ae2c1e9230afe3d16b70cb63 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5908694 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Roman Lavrov dd66a284 2024-10-04T13:10:14 Perf tests: custom throttling excludes VIRTUAL-SKIN*-MODEL-* These seems to be using different units and get stuck in throttling. Also ignore VIRTUAL-SKIN*-CHARGE-* which I think was the intent but the check ended up in the wrong place. Bug: b/371573999 Change-Id: I2a9e6fbbb41bebfc5d9d85ee187f4f0918dd5e61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5905236 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 0b78963d 2024-06-18T12:38:38 Perf tests: add thermalservice custom temp throttling E.g. --custom-throttling-thermalservice-temp=36 IThermal interface isn't available on all devices. thermalservice is another way to get similar data, but with its own limitations (for example, on Pixel we don't see CPU ODPM temps there while we do get them with IThermal). Unlike --custom-throttling-temp that we use on Pixel, this flag does not attempt to disable vendor throttling (not sure there is even a way to do that outside of Pixel). Vendor throttling can affect perf results, higher custom temps increase odds of that happening mid-way during a trial. Bug: b/347956784 Change-Id: I1166e07e4a5c88417eb379d5cb6a7440b169d073 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5639336 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi aa61c076 2024-10-08T12:14:13 Autogen files for GL_ARM_shader_framebuffer_fetch_depth_stencil Bug: angleproject:352364582 Change-Id: I3e736195be3a21c2ae48b4ab2922f9ae7bfcbf32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5916185 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev af33337a 2024-10-07T00:00:00 Metal: Remove unused MSL helpers These helpers are never emitted. Bug: angleproject:372169468 Change-Id: I306164aaf4db1b7070e3e4a0599f0f02a1e29c7d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5912762 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuly Novikov cea5f080 2024-10-08T15:45:35 Enable retries in angle_deqp_gles2_webgpu_tests on Mac Bug: angleproject:42265067 Change-Id: I8117a0503a7dc09af83769063f6b2b915d4da430 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5913101 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi aec90a8d 2024-10-07T10:56:24 Fix ignoring blit bits when attachments are missing GLES requires that the bits provided to glBlitFramebuffer are silently ignored if either the read or draw framebuffer is missing the corresponding attachment. In WebGL, this is forbidden. ANGLE was forbidding this because of WebGL, but a recent CTS test revealed that we shouldn't be doing that when !WebGL. Bug: angleproject:370917919 Change-Id: I202fbf665d8a102f0aea72709b80dfdabeb71a2e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5912614 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 0f7371ae 2024-10-07T00:00:00 Metal: Remove ANGLE_tensor macro Its replacement is never used. Fixed: angleproject:372053408 Change-Id: I1d54efcc1a1ecac1d0c6dae5ff7524b501297fe0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5912904 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll b40f367e 2024-10-08T10:52:49 Roll vulkan-deps from dd729cf1f807 to a7919b0e1d20 (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/dd729cf1f807..a7919b0e1d20 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f69d2768e534132e8626c4817c80e95464dcda8e..9d00d6d6cad638bebc7cd852b1e6e1244de42679 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/ada92f84927350c8f3567a06e23e4ff2b04f6810..4310fd4edae21d711ab31f5183704ad320329419 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/8bdce6d842ca9f9bd0a4119963b0eb10693f5b23..bd1c8ea9c6ac51e4c3a6ddb9d602bb204678eb5f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/6991ccb68890681b1a3e0f56acd8f53b20ad1e79..c9a5acda16dc2759457dc856b5d7df00ac5bf4a2 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/9d084cf28b2f32ef2a43a53801c7d4bf53d8fa2c..65b79bac615ec1c47ab61a02d55a3bba871b56b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ifae54d2ad74b46551fd15d422f4c2fcf82698218 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5915694 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll db8df613 2024-10-08T07:00:51 Roll Chromium from af63b8cf2be2 to 3bc95aca3c88 (508 revisions) https://chromium.googlesource.com/chromium/src.git/+log/af63b8cf2be2..3bc95aca3c88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/884faaff73..f2790bfa32 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c803031bdb..42e3e21a6d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a5cf433ad7..e702ecee42 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3a61fbe304..af5dc104cd * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5304f2bbb3..c109945e72 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/8c26b4bd2f..e8d7247aa3 * third_party/r8/cipd: qDEWilHtZCtMDPEZQ3CLijYxmHHxS7n9FhzVEue1pX4C..3KCj5eRYCvGGYs5i90pRaeihkzsqgUGc4OkICT8AOlIC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/8f4868f290..09f2684d99 * tools/luci-go: git_revision:a1a693f7ec8f9b8d29843f5a68693c43d692d941..git_revision:78b3b3ca47e64b3280a5dd5b83c23ce89f04d328 * tools/luci-go: git_revision:a1a693f7ec8f9b8d29843f5a68693c43d692d941..git_revision:78b3b3ca47e64b3280a5dd5b83c23ce89f04d328 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/eb9827468d..7972e4dcd8 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I898f50e4422a4c3ca383d7ccf78f2fb62b761ea5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5912128 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 166b72c9 2024-09-30T19:07:26 GL_ANGLE_blob_cache implementation. Bug: chromium:370538323 Change-Id: Ic51a951e78b48b315e36f518bcc39ff2d54660a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5900761 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cody Northrop 770dc68f 2024-10-04T13:05:24 Tests: Add Thief Puzzle trace Test: angle_trace_tests --gtest_filter="*thief_puzzle*" Bug: b/371518149 Change-Id: I593964bdf4a39edf2445a54a400f5faddd4fcaff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5909872 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Geoff Lang 492cf265 2024-09-27T13:44:22 Stubs for GL_blob_cache_angle Bug: chromium:370538323 Change-Id: Ib56b28c24305db8931f382b16a24975b7277fa7e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5900760 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 37c69bd6 2024-10-07T11:00:14 Tests: gold tests assert that filter matches a test As described on the bug, test retries result in an unexpected value passed to --isolated-script-test-filter, which doesn't match any traces. Assert that there is a match as a (permanent) workaround. Bug: chromium:371977204 Change-Id: I415507ea999005a9ac04489582cf77b7d3e29e2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5912615 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 07ad37e1 2024-10-07T09:57:17 Roll Chromium from f110bcc1488e to af63b8cf2be2 (761 revisions) Add tools/ubsan/vptr_ignorelist.txt suppressing LLVM due to https://chromium-review.googlesource.com/c/chromium/src/+/5854259 https://chromium.googlesource.com/chromium/src.git/+log/f110bcc1488e..af63b8cf2be2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9b11bd3a6a..884faaff73 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/7f979120bf..c803031bdb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/445152c103..a5cf433ad7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ae4dff4412..3a61fbe304 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6af18461ad..5304f2bbb3 * third_party/fuchsia-sdk/sdk: version:24.20240927.1.1..version:24.20241004.3.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/100430be35..8c26b4bd2f * third_party/siso/cipd: git_revision:dc7a06223e4ccbde049613ed802448b0c8baf5af..git_revision:6b2665e870db2df4da1c184a2aec2f98dcb75000 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/9454d9302a..8f4868f290 * tools/luci-go: git_revision:dd13340e3303af77ba58ca4b6453ca3b610f533f..git_revision:a1a693f7ec8f9b8d29843f5a68693c43d692d941 * tools/luci-go: git_revision:dd13340e3303af77ba58ca4b6453ca3b610f533f..git_revision:a1a693f7ec8f9b8d29843f5a68693c43d692d941 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/fc8a6438be..eb9827468d * tools/skia_goldctl/linux: g3oB7WN3FMw7wV_mjPXv5MHR_Ruh1F1yUfuErTH4dPEC..-WwsoLGIeY9CdK9XppXR9Q_l6IVn4roukf6qEQv5YNwC * tools/skia_goldctl/mac_amd64: -dmq848gM8JND4yLD470jkRVPqRmN7oqhAviMidflqQC..hhcjERw_9St0a6aoG-4qcqu3as4VN_08SbDnaNcm53oC * tools/skia_goldctl/mac_arm64: V4RKA9I-Wvyg57Iei5NfgLTp2hu93q4ZO-nyvfrd7n0C..FBgwCI1fflbcYLhG8hlzODBQIBcYe9MPiFFR_tcTBJEC * tools/skia_goldctl/win: IEkpUUyFJ5mwc9yz1CuRdzTEGMzgAYuS7Pr7uegUXoQC..4nH7g70rYeJlUxm49v3invhG2FjAPPK18QlAZ6gwVVoC No update to Clang. Bug: None Change-Id: Iaf3c3a86bd566e30e472e17d17b9e5cb088b3ee0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5912236 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop c99f1106 2024-10-05T17:21:37 Debug: Allow forcing GL_RENDERER and GL_VENDOR It can often be useful to force the GL_RENDERER and GL_VENDOR strings to values recognized by applications. Bug: b/371749458 Change-Id: I045a76e733e1b59ad257caceed396847abf3d7fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5910908 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev cd10ad46 2024-09-30T00:00:00 Metal: Rework allowSamplerCompareGradient feature * AMD drivers may fail when a sample_compare function is used with explicit derivatives. To avoid such failures, the effective level is computed from the texture size, passed derivatives, and texture coordinates, if needed. The level value is then used for sample_compare instead of the explicit derivatives. * Apple2 GPUs do not support setting texture sampler compare state via Metal API. As a result, all sample_compare functions including those without LOD options do not work on Apple2 GPUs. This feature was attempting to incorrectly emulate a subset of sample_compare functions with a hard-coded compare state. There are no plans to support shadow samplers on Apple2 GPUs, as it would require non-trivial emulation, so this feature is no longer relevant for that platform. * Metal on macOS 10.15 only supports constant zero as the level parameter for sample_compare functions. Ignoring the passed derivatives and using zero LOD on old OS versions is a better fallback than dropping the derivatives altogether because many applications use the derivatives to set the level to zero anyway. Bug: angleproject:365066518 Bug: angleproject:368059227 Change-Id: I4028421b785ae49328b72658e0a9783275461779 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5903970 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Mohan Maiya b3d85cce 2024-09-30T14:28:35 Vulkan: Consolidate write colorspace override states ColorspaceState struct is now used to cache write colorspace related states to determine the colorspace of Vulkan draw image views. ImageViewHelper methods are called during initialization and when colorspace related states are toggled dynamically which in turn process these states and determine the final write colorspace. We can now fully support rendering to EGLImages, with colorspace overrides, via texture or renderbuffer EGLImage targets Bug: angleproject:40644776 Tests: ImageTest*Colorspace*Vulkan MultithreadingTestES3.SharedSrgbTextureMultipleContexts*Vulkan ReadPixelsPBOTest.SrgbUnorm*Vulkan Change-Id: I2be2cd3b5b2b4ac8ecb803c34cde2b846cbd1cbe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5901256 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Yuly Novikov 95379bb4 2024-10-07T14:14:16 Suppress flaky end2end test on Linux NVIDIA Vulkan SixteenBppTextureTestES3.RGB5A1UploadRGBA8 Bug: angleproject:362486580 Change-Id: I2e2f36cce2e98e92b6b84d816cf09dd778a5e21d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5913434 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 6d6a1686 2024-10-07T10:01:49 Roll vulkan-deps from 2be80b8bd62c to dd729cf1f807 (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/2be80b8bd62c..dd729cf1f807 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a729c86d78552ec7e05e3748448e7a99f6f2a696..f69d2768e534132e8626c4817c80e95464dcda8e https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/522dfead39eb232b3873f0e7cfe57cde6b9e69c1..ada92f84927350c8f3567a06e23e4ff2b04f6810 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/29f979ee5aa58b7b005f805ea8df7a855c39ff37..14345dab231912ee9601136e96ca67a6e1f632e7 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/0a786ee3e4fd3602f68ff0ffd9fdcb12e0efb646..8c907ea21fe0147f791d79051b18e21bc8c4ede0 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/a17bc71a8f722d9fdf42f19b863616762ec38db4..9d084cf28b2f32ef2a43a53801c7d4bf53d8fa2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ic14409df0449724d18c4ccde1975c5fbd1596587 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5912237 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 53b9dcdc 2024-10-07T08:01:35 Roll VK-GL-CTS from 179dd9f858f0 to 5dd667ee8fa8 (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/179dd9f858f0..5dd667ee8fa8 2024-10-02 lordalcol@users.noreply.github.com Create vulkan-cts-withdrawal-2024-10.txt If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I262bf2002457e93f5d27ae4f4b8dc0d043a00484 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5911567 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi aacbf041 2024-10-05T01:30:39 Revert "Vulkan: Enable build on Chrome/Android" This reverts commit e2a238511238fdd94b260f3397db5271c1c1e45a. Reason for revert: Adds 1MB to Chrome's binary size. Reverting for now so ANGLE continues to roll in Chrome. We'll reland it once it's confirmed the increase is fine. https://chromium-review.googlesource.com/c/chromium/src/+/5910406 Original change's description: > Vulkan: Enable build on Chrome/Android > > Bug: chromium:371512561 > Change-Id: I4cecb44550c5de5ee843e2db0fc138b5aaab3c71 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5905861 > Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: chromium:371512561 Change-Id: Ia64de24d0d74e854b0ad0c3e62775e266e6edc16 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5910112 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Mohan Maiya b38cc7fa 2024-09-30T12:43:09 Vulkan: Consolidate read colorspace override states ColorspaceState struct is now used to cache read colorspace related states to determine the colorspace of Vulkan read image views. ImageViewHelper methods are called during initialization and when colorspace related states are toggled dynamically which in turn process these states and determine the final read colorspace. Bug: angleproject:40644776 Tests: ImageTest*Colorspace*Vulkan SRGBTextureTest.SRGB*TextureParameter*Vulkan SRGBTextureTestES3.SRGBDecodeTexelFetch*Vulkan Change-Id: I16b3666cd80865936b826dc0738fc9210dabeda9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5901255 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Mohan Maiya 605c2f85 2024-09-27T12:00:58 Vulkan: Bugfix in FramebufferVk::blit(...) If any color attachment of GL_DRAW_FRAMEBUFFER is already in use in the currently started renderpass, don't reuse the renderpass for blit. Bug: angleproject:40644776 Tests: Texture2DTestES3.UnitTest_DMSAA_dst_read* Change-Id: Ib4266fc65d0ac7151f362f263e9e706adb1231ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5895158 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana f9709279 2024-09-20T16:02:56 CL/Vulkan: Add support for printf builtin processing The support for printf builtin in clspv enabled through the SPIR-V non-semantic clspv reflection instructions - PrintfInfo and PrintfBufferStorageBuffer [1]. The printf buffer is setup with a separate descriptor layout and the pipeline layout is updated accordingly. Also, printf is enabled as default option now for clspv. [1]: https://github.com/KhronosGroup/SPIRV-Registry/blob/master/nonsemantic/NonSemantic.ClspvReflection.html Bug: angleproject:369724757 Change-Id: I20b245eb0fea69941bd1aeb42534f8b729ec17e8 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5893958 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao b61f9f9e 2024-10-04T11:07:23 Vulkan: Add operator<< for descriptorSet for debugging Right now it is using streamOut() function which is hard to use with WARN(). This replaces the streamOut function with standard c++ operator<< so that we can use in WARN()/INFO() along with other logs for debugging. Bug: b/368566032 Change-Id: Iec98b4c59f360cbbfb8fbdd85d5d1150fcca8f4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5908773 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao d147a2ca 2024-10-04T10:45:55 Vulkan: release descriptorSets from TextureVk::refreshImageViews When texture has to refresh its imageViews, the existing descriptorSet cache will become obsolete (because the cache key contains view's uniqueSerial). This CL proactively releases all cache so that we don't keep these invalid cache any more. Bug: b/368566032 Change-Id: I82a221b8b8fd072ee3a52b11264addba385526d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5908772 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao eb4eaea9 2024-10-03T17:15:21 Vulkan: Improve SharedCacheKeyManager::addKey performance This function walks a vector of keys. When there are many keys this could be slow. Also when we have to grow the vector size, it involves memory reallocation which means copy the data from old storage to new storage. This CL changes mSharedCacheKeys to use std::deque instead of vector which solves storage reallocation problem. It also adds angle::BitSet64<64> to track all available (i.e., empty) slots in mSharedCacheKeys so that we don't have to loop most of time. You only loop all keys once to find all empty slots and then subsequent addKey() call will be O(1) until all empty slots are used. Bug: b/368566032 Change-Id: I4d32b461761f1cd64380f5527883b84357bb44c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5908690 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev a921694b 2024-09-30T00:00:00 Metal: Support EXT_texture_shadow_lod Bug: angleproject:365108862 Change-Id: Ieb0b53253c5d9091e0c74baccf808622d9578d5f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5907407 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev d550d96f 2024-09-30T00:00:00 Metal: Remove allowSamplerCompareLod feature * Apple2 GPUs do not support setting texture sampler compare state via Metal API. As a result, all sample_compare functions including those without LOD options do not work on Apple2 GPUs. This feature was attempting to incorrectly emulate a subset of sample_compare functions with a hard-coded compare state. There are no plans to support shadow samplers on Apple2 GPUs, as it would require non-trivial emulation, so this feature is not needed. * Metal on macOS 10.15 only supports constant zero as the level parameter for sample_compare functions. Ignoring the requested level and using zero on old OS versions is a better fallback than dropping the parameter altogether because many applications set the level to zero anyway. Bug: angleproject:365066518 Bug: angleproject:368059227 Change-Id: I2cdc0bda5842842d62ad5663427da7f1f37bddda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5907619 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Geoff Lang c94c37c1 2024-09-23T17:22:27 WebGPU: Skip ReadPixels if texture creation failed If texture creation failed due to an unsupported format, ReadPixels would crash calling a null conversion function. Mark this case as UNIMPLEMENTED for now. Bug: angleproject:42266974 Change-Id: Ifa34d9db3d0d14e8e382c2323b4e70d2b1a7d2a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5889090 Reviewed-by: Liza Burakova <liza@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cody Northrop f1458429 2024-10-04T09:50:38 Tests: Add Going Balls trace Test: angle_trace_tests --gtest_filter="*going_balls*" Bug: b/371526637 Change-Id: I4fad1ef0e7ec450b22f86767398d3283e2c89427 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5908703 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Shahbaz Youssefi e2a23851 2024-10-04T12:33:04 Vulkan: Enable build on Chrome/Android Bug: chromium:371512561 Change-Id: I4cecb44550c5de5ee843e2db0fc138b5aaab3c71 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5905861 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cody Northrop 3f132f0c 2024-10-03T19:36:20 Tests: Add Woodoku trace Test: angle_trace_tests --gtest_filter="*woodoku*" Bug: b/371501416 Change-Id: I766aac5f0409ab65264955685ac2267c2de457eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5908693 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Yuly Novikov c861f0d6 2024-10-04T14:18:52 Skip KHR-GLES3.framebuffer_blit.scissor_blit on S22 Started failing after VK-GL-CTS roll. https://chromium-review.googlesource.com/c/angle/angle/+/5903935 https://ci.chromium.org/ui/p/angle/builders/ci/android-arm64-exp-s22-test/1316/overview Bug: b/267953710 Change-Id: I63e09c9c1d73a230cf2c12fc079793390d00b095 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5905074 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cody Northrop e8fdc341 2024-10-03T17:50:20 Android: Update targetSDK to 34 Since ANGLE ships as part of the platform, we need to target a more recent SDK version. Resulting Android.bp diff: $ diff Android.bp.before Android.bp.after 8034c8034 < target_sdk_version: "33", --- > target_sdk_version: "34", 8061c8061 < target_sdk_version: "33", --- > target_sdk_version: "34", 8100c8100 < target_sdk_version: "33", --- > target_sdk_version: "34", Bug: b/369722011 Change-Id: Ide7506256305733cc4617e798a67704fa729caa8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5908423 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll ad8627a8 2024-10-04T10:01:11 Roll vulkan-deps from 1d7fd2888081 to 2be80b8bd62c (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/1d7fd2888081..2be80b8bd62c Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/bd03f39b0b81d86ea58f0970ba7070256b07b860..5d4562d56eb3cc8ac23f70fd48e549d0751b2fde https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/c173df736cb89ba4daba0beec039317292f22e0d..522dfead39eb232b3873f0e7cfe57cde6b9e69c1 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/656a02f08e85606f547ece0a1a27555aa09c3c20..a17bc71a8f722d9fdf42f19b863616762ec38db4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: If0e30cc8b5834ff48b7a0113fd6fb267f6f05182 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5908702 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9f609a5c 2024-10-04T10:01:04 Roll SwiftShader from 07d3f212a083 to 7a9a492a38b7 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/07d3f212a083..7a9a492a38b7 2024-10-03 qjw@chromium.org ssci: use canonical date format If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ic1304b3edd12246878a1dfe615787a01e3c81483 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5909162 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 92577388 2024-10-04T08:09:40 Roll Chromium from 4bfccb8742c8 to f110bcc1488e (573 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4bfccb8742c8..f110bcc1488e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * third_party/android_build_tools/lint/cipd: FIrvFhnAkhayioL689w9SrLa3E5lcstHK5bWCJy_uiEC..8os9DzCgPex0dFtZslAlzowMLYeKXFCQHSJMJYTodZsC * third_party/android_build_tools/manifest_merger/cipd: SXrT41DFdxtTN78HQooJiwMnwvQg7mHm4fTvrJc0_7MC..p2c9mSgfF-HErc8CM-jOFuuMbaMK-POsiqbeG5plk2cC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/25ef35ff22..ae4dff4412 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1e4e7f1a9a..6af18461ad * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e2d898ca22..100430be35 * third_party/r8/cipd: Vw4Ch7k1MIcGy2EYCmf4gIRSZr8KSEr0E5ho9L2zcPUC..qDEWilHtZCtMDPEZQ3CLijYxmHHxS7n9FhzVEue1pX4C * tools/luci-go: git_revision:bf797b21e5dbcb1466cd527a1aa8e2ecf1910fbd..git_revision:dd13340e3303af77ba58ca4b6453ca3b610f533f * tools/luci-go: git_revision:bf797b21e5dbcb1466cd527a1aa8e2ecf1910fbd..git_revision:dd13340e3303af77ba58ca4b6453ca3b610f533f * tools/skia_goldctl/linux: e7Gk9PeahSm_1EW8BSVIxLgejp9-R3WXXegqgIk69QEC..g3oB7WN3FMw7wV_mjPXv5MHR_Ruh1F1yUfuErTH4dPEC * tools/skia_goldctl/mac_amd64: zpYpWppDloimrDAYrVHDgQB3NuEiNfOk3q_77nEk86EC..-dmq848gM8JND4yLD470jkRVPqRmN7oqhAviMidflqQC * tools/skia_goldctl/mac_arm64: 1norVnXR43-T0QyBNiOWV0f5r4x0OL_2l8rnWTtfTK4C..V4RKA9I-Wvyg57Iei5NfgLTp2hu93q4ZO-nyvfrd7n0C * tools/skia_goldctl/win: Wkeo4Rwl-O3syAKz9UTENaXo584kMfbEjQtVd4Q3k6cC..IEkpUUyFJ5mwc9yz1CuRdzTEGMzgAYuS7Pr7uegUXoQC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ie04f740e77bbd8d33cbd41cbb6abfb8f0fee55a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5908426 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi cd7f2949 2024-10-03T14:14:41 GL: Workaround constructor bug on Nvidia Bug: chromium:328015191 Change-Id: Id581d4eef63860c213313d2d2faaa316685904b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5905821 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi b16d105f 2024-10-03T10:25:32 Remove Desktop GL front-end support For Desktop GL applications, please use Zink! Bug: angleproject:370937467 Change-Id: Ie734634bb62a2e98c80e1b32d8b3d34624da3c04 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5905428 Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 6024e9c0 2024-10-02T08:01:43 Manual roll VK-GL-CTS from 65470ff2e321 to 179dd9f858f0 (27 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/65470ff2e321..179dd9f858f0 2024-09-30 lorenzo@khronosgroup.org Fix build 2024-09-30 mark@igalia.com Support standalone executable builds on Android 2024-09-30 javed@igalia.com Add tests for draw count clamping with null index buffer 2024-09-30 piotr.byszewski@mobica.com Capture replay tests for VK_EXT_descriptor_buffer 2024-09-30 javed@igalia.com Add tests vkCmdDrawIndexedIndirectCount draw count clamping 2024-09-30 rgarcia@igalia.com Add R8 and R16 large image tests in host image copy test group 2024-09-30 ziga@lunarg.com Add missing linked shader object test case 2024-09-30 tapani.palli@intel.com Fix issues with GLX reset notification strategy 2024-09-30 kamil.goras@mobica.com Split KHR-GLES32.core.tessellation_shader.vertex.vertex_spacing 2024-09-30 jimblackler@google.com Handle resize events in EGL bounding box tests. 2024-09-30 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-09-30 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_EXT_depth_clamp_control' into main 2024-09-30 lorenzo@khronosgroup.org Update Vulkan spec to 1.3.296 2024-09-30 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_compute_shader_derivatives' into main 2024-09-20 lorenzo@khronosgroup.org Update SPIRV-Tools, SPIRV-Headers, glslang, Vulkan-Docs, Vulkan-ValidationLayers external sources 2024-09-19 piotr.byszewski@mobica.com Check limits before running mapping_to_large_index DRLR test 2024-09-19 ziga@lunarg.com Test pipeline without render pass or VkPipelineRenderingCreateInfo 2024-09-19 piotr.byszewski@mobica.com Remove invalid dynamic rendering local read tests 2024-09-19 piotr.byszewski@mobica.com Fix pipeline binary graphics tests 2024-09-19 piotr.byszewski@mobica.com Fix pNext chain loop in FSR tests 2024-09-19 kamil.goras@mobica.com Split KHR-Single-GL46.arrays_of_arrays 2024-09-19 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (glGetUniform), PART 11 2024-09-19 marcin.hajder@mobica.com Port KC-CTS tests to VK-GL-CTS (scissor_blit), PART 12 2024-09-19 marcin.zajac@mobica.com Suballocated DRM images 2024-09-19 piotr.byszewski@mobica.com Test feedback loop with dynamic rendering local read 2024-09-19 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.9 into vk-gl-cts/main 2024-09-18 jimblackler@google.com Fix error in test logging in all CtsDeqpTestCases If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: Idbc50f78119327844e1488db25d58c1c588f9ff6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5903935 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Gowtham Tammana b5d548bb 2024-09-20T17:06:54 CL/Vulkan: Update map interface for CLMemoryVk Clean up the map interface of the CLMemoryVk to account for any offsets. Bug: angleproject:369724757 Change-Id: I12c7bf2f7f94cd7fbf57a8ee10748d2275a2ba70 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5893956 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana 0a452697 2024-09-19T16:33:26 CL/Vulkan: Enable support for multiple descriptor set handling The clspv transcompiler can generate multiple descriptor sets depending on the kernel e.g. printf storage buffer is setup in a separate descriptor set, and kernel arguments in a separate descriptor set. This change enables setting up of multiple descriptor sets and appropriately bind them. Also, creation of descriptor set and pipeline layout are deferred to kernel enqueue time as it is quite possible that kernels are built in a batch before their use. Bug: angleproject:369724757 Change-Id: I80eb93f4a3b8afc7461c299cc283526cc4b872fa Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5893955 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Gowtham Tammana 371539c3 2024-09-19T16:26:44 CL/Vulkan: Move descriptor set and pipeline layout cache to context Move the descriptor set and pipeline layout caches to context so that cache is shared across programs. Bug: angleproject:369724757 Change-Id: I517d0cc712adb3f8b91d68e5bca8d3ac3ddb39ff Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5893954 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll e97a9ba6 2024-10-03T12:43:27 Roll SwiftShader from 72ca2005cd32 to 07d3f212a083 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/72ca2005cd32..07d3f212a083 2024-10-03 swiftshader.regress@gmail.com Regres: Update test lists @ 72ca2005 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: If632b9478f8e0763dc23168886dbf202525c5922 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5907357 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 627a3c52 2024-10-03T10:01:23 Roll vulkan-deps from 7aaa4e9a5b34 to 1d7fd2888081 (12 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7aaa4e9a5b34..1d7fd2888081 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/f47ac1956e0206f8f908e2ac6f982a4058001d72..bd03f39b0b81d86ea58f0970ba7070256b07b860 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/ec59c77a3bb5c747a369931ef101ac7c14823f2f..a62b032007b2e7a69f24a195cbfbd0cf22d31bb0 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/d9c1aee6a609c6d6ec1caab4def80720c44bd08d..c173df736cb89ba4daba0beec039317292f22e0d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/789f86b62b8bc15dcf427da5254e485c7cb69993..656a02f08e85606f547ece0a1a27555aa09c3c20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I2ad5577f90e5c82e582a759efdf479a5e59a36da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5905777 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 01eb0220 2024-10-03T07:46:37 Roll Chromium from 7b11e2d1e07c to 4bfccb8742c8 (590 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7b11e2d1e07c..4bfccb8742c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * third_party/android_build_tools/error_prone/cipd: V6_XfH4kpaWINZD2dKHYp2_PuYLe0ay7fzbaY2HUrSMC..15eqqvDTRtPu1Sy8b4WuOiqkivE9ibCjSdoOtqJYyBEC * third_party/android_build_tools/manifest_merger/cipd: nF0aNBggEihalcCW3jCKPV8O-xsiz2xTWqzRjbCLyIYC..SXrT41DFdxtTN78HQooJiwMnwvQg7mHm4fTvrJc0_7MC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ffa948a18e..25ef35ff22 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e1f9cd1981..1e4e7f1a9a * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/ae0729a012..829f51051c * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/37c7d984b0..71735e82a6 * third_party/r8/cipd: I9NkcalmFScQACQtkXVKfzARFBmSev5KPsswXhNBQy8C..Vw4Ch7k1MIcGy2EYCmf4gIRSZr8KSEr0E5ho9L2zcPUC * tools/luci-go: git_revision:825ada410ecdfd314f075a609b46ceb61dfa6442..git_revision:bf797b21e5dbcb1466cd527a1aa8e2ecf1910fbd * tools/luci-go: git_revision:825ada410ecdfd314f075a609b46ceb61dfa6442..git_revision:bf797b21e5dbcb1466cd527a1aa8e2ecf1910fbd * tools/skia_goldctl/linux: MGzTqxIhMiRM2-6RgzsZFtumPnzV1TK3ZAi_6wCi3TcC..e7Gk9PeahSm_1EW8BSVIxLgejp9-R3WXXegqgIk69QEC * tools/skia_goldctl/mac_amd64: EofOxC6ilCLtxC0iTbRKFI-IhhFd9GpM7kHznbfEOmIC..zpYpWppDloimrDAYrVHDgQB3NuEiNfOk3q_77nEk86EC * tools/skia_goldctl/mac_arm64: Alc4d73HA0rpjzmwe3tldUxbROvQQ2MVkDoMVFh8TfIC..1norVnXR43-T0QyBNiOWV0f5r4x0OL_2l8rnWTtfTK4C * tools/skia_goldctl/win: _if0lxk5UzUITg0A-UWCM5n2hKP3bHSMG3u4G1ethVsC..Wkeo4Rwl-O3syAKz9UTENaXo584kMfbEjQtVd4Q3k6cC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I8a8931b332af8ff2d0289a796d1ec1639ed029fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5906624 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski 9edd74e2 2024-10-02T09:31:31 Tests: Add Traffic Rider trace Test: angle_trace_tests --gtest_filter="*traffic_rider*" Bug: b/370733451 Change-Id: I35703fcbc350fbbcaf3544ba6143d5bbb1966483 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5902662 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Austin Annestrand 55980dbd 2024-06-07T13:45:23 common: Improve/fix spir-v utils This change improves the handling of macroed-sections of the code. Also, fixed some typos. Bug: angleproject:370557215 Change-Id: I437b8c4d835dada4554569c72ef7100568c6be48 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5898609 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Corentin Wallez be8cc064 2024-10-02T15:12:42 DisplayWgpu: Remove wgpu::FeatureName::SurfaceCapabilities This feature used to allow querying the wgpu::TextureUsage allowed with a wgpu::Surface. This is no longer necessary to have as an extension since wgpu::Surface supports this capability by default (after it was made a replacement of wgpu::SwapChain). Remove the now useless mention of this feature that was blocking the removal of the feature's code from Dawn. Bug: b/42241264 Change-Id: Ia097f2f6077fa655a2b4b495cdcf3f1fa5f23d55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5904059 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cody Northrop f680925b 2024-10-01T14:07:03 Tests: Add Warhammer 40000 Freeblade trace Test: angle_trace_tests --gtest_filter="*warhammer_40000_freeblade*" Bug: b/370798324 Change-Id: I77b95721363f3d2cc97a52b2e83ffe5d92e40305 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5902286 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jiewei Qian 435bd0a9 2024-10-02T16:37:06 ssci: use canonical date format Bug: chromium:370881022 Change-Id: Ie8a310b11517fd1be7f95f246bcb9cfe48d95791 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5903336 Auto-Submit: Jiewei Qian <qjw@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 80aced82 2024-10-02T10:01:17 Roll vulkan-deps from fb8f0127fca4 to 7aaa4e9a5b34 (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/fb8f0127fca4..7aaa4e9a5b34 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/b2b32340f481d2c024e96a39aa26b7391684e554..f47ac1956e0206f8f908e2ac6f982a4058001d72 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/fae95496d8c8047ae206345955c111fd62b5fd5d..8bdce6d842ca9f9bd0a4119963b0eb10693f5b23 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/b827793aa5431861d83cd8f6b5f4054bd2e727e6..789f86b62b8bc15dcf427da5254e485c7cb69993 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ic7551b039ea29a16f3499f48c62934ab689e7a7e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5903303 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 5aa20fd1 2024-10-02T10:01:42 Roll SwiftShader from 8580e3a98e50 to 72ca2005cd32 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/8580e3a98e50..72ca2005cd32 2024-10-01 swiftshader.regress@gmail.com Regres: Update test lists @ 8580e3a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Iafdd3481dd140bfe02e237ea946b0bb209387a3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5903699 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll bba8c292 2024-10-02T09:26:42 Roll Chromium from dd17ed0c05d9 to 7b11e2d1e07c (692 revisions) https://chromium.googlesource.com/chromium/src.git/+log/dd17ed0c05d9..7b11e2d1e07c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/b952ef48c3..ffa948a18e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6dec85272d..e1f9cd1981 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/3c26edd0c3..ae0729a012 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/b7cdacaadb..37c7d984b0 * third_party/r8/cipd: LHNTk_-ajFbwrjtRsvuqgsLQGXD5dbTlWyV1MJ4_u2EC..I9NkcalmFScQACQtkXVKfzARFBmSev5KPsswXhNBQy8C * tools/luci-go: git_revision:cb4b10bea51ea74dbdfeb6d377481c884ab23db8..git_revision:825ada410ecdfd314f075a609b46ceb61dfa6442 * tools/luci-go: git_revision:cb4b10bea51ea74dbdfeb6d377481c884ab23db8..git_revision:825ada410ecdfd314f075a609b46ceb61dfa6442 * tools/skia_goldctl/linux: 4s_ABtbPMrcHw-KqJwj3L7vboveu3iDg8e7n8uRmve8C..MGzTqxIhMiRM2-6RgzsZFtumPnzV1TK3ZAi_6wCi3TcC * tools/skia_goldctl/mac_amd64: 2hD9HfEqA8X9avGf12065M8P4WL34srX9Ba31JyGgWQC..EofOxC6ilCLtxC0iTbRKFI-IhhFd9GpM7kHznbfEOmIC * tools/skia_goldctl/mac_arm64: JK9cZP89yujG9N6OVFr-rqipABokDP_AfO0itS1ewdMC..Alc4d73HA0rpjzmwe3tldUxbROvQQ2MVkDoMVFh8TfIC * tools/skia_goldctl/win: hnJ2kurx2k7B9cFvcdV0wdw_62bq1NtnKmN98DP7N40C.._if0lxk5UzUITg0A-UWCM5n2hKP3bHSMG3u4G1ethVsC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I130a7fc84380ac7c399f29e2fb94231bc99050f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5903302 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 7ff7775b 2024-09-19T00:00:00 Metal: Align internal texture wrapper names Used consistent internal names for all ESSL 3.00 texture wrappers. Bug: angleproject:368059227 Change-Id: I69c162d7b1557bb9a92cba902f4fdd5b4c30ee2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5890621 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev 371ab6d8 2024-09-19T00:00:00 Metal: Refactor texture wrappers * Removed variadic macros. * Removed invalid overloads. * Added MSL compile guards to not fail shader compilation on macOS 10.15. Bug: angleproject:368059227 Change-Id: I5376b410670a50cf700f1c33823f43c89c10b876 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5893780 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev 86872374 2024-09-19T00:00:00 Metal: Refactor textureGrad wrappers * Removed variadic macros. * Removed an invalid overload. * Updated emitter to not output unused variants. * Added MSL compile guards to not fail shader compilation on macOS 10.15. Bug: angleproject:368059227 Change-Id: I816b8b96b264d0ca943bca566987755460b3a72f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5893778 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 39b5f5fc 2024-09-19T00:00:00 Metal: Refactor textureLod wrappers * Removed variadic macros. * Removed an invalid overload. * Updated emitter to not output unused variants. * Added MSL compile guards to not fail shader compilation on macOS 10.15. Bug: angleproject:368059227 Change-Id: If15fcb0cb772e3ee2e2e1669f894fb8de4e76578 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5896390 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev 80e5e611 2024-09-19T00:00:00 Metal: Refactor textureGradOffset wrappers * Removed variadic macros. * Removed invalid overloads. * Updated emitter to not output unused variants. * Added MSL compile guards to not fail shader compilation on macOS 10.15. Bug: angleproject:368059227 Change-Id: I47e0c04176bd9f4b6e6abcd266ae4c673135c93b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5893503 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Gowtham Tammana cc44090d 2024-09-18T12:28:53 Vulkan: Add an extra descriptor set index In the case of CL, the clspv transcompiler can generate upto four descriptor set indices, so add an extra index to vk::DescriptorSetIndex. Also, adding aliases for CL specific naming. Bug: angleproject:369724757 Change-Id: I45ef8a6d9246c7863ebc6edf08479bc7c661c151 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5893953 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Imran Ziad 0040cda1 2024-09-25T18:16:36 Vulkan: Invalidate host visible non-coherent buffers on mapping We can not trust the cache during CPU readback when the buffer memory type is non-coherent. Bug: b/366134076 Change-Id: I89920cfa468ee0be0feb607fea9d60bc0732191f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5890707 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Imran Ziad <imranziad@chromium.org>
angle-autoroll 65ece029 2024-10-01T10:01:48 Roll vulkan-deps from 223523f05dc0 to fb8f0127fca4 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/223523f05dc0..fb8f0127fca4 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/46ef757e048e760b46601e6e77ae0cb72c97bd2f..a729c86d78552ec7e05e3748448e7a99f6f2a696 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/56dd9f2344a7be1d218a54549a4a5e39c1e85073..fae95496d8c8047ae206345955c111fd62b5fd5d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/2020cec4111c87d85b167d583180b839f0c736c5..6991ccb68890681b1a3e0f56acd8f53b20ad1e79 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/a71907b8577c994b1c69adfa7315d55bbe79656e..0a786ee3e4fd3602f68ff0ffd9fdcb12e0efb646 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/8bb1ad96a6204dd85b4af293eddc76a6f6ea3a54..b827793aa5431861d83cd8f6b5f4054bd2e727e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Id728ae4f898ca6445a29afc47c4fb8358d4307a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5900958 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 81c11961 2024-10-01T07:51:32 Roll Chromium from a588c34f73df to dd17ed0c05d9 (541 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a588c34f73df..dd17ed0c05d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/208275633f..445152c103 * third_party/android_build_tools/error_prone/cipd: YE3pEw2WCnBXxGYzRUWClmkwiGF1u9FtWzN_NpztxlgC..V6_XfH4kpaWINZD2dKHYp2_PuYLe0ay7fzbaY2HUrSMC * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2c16d7f80b..6dec85272d * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d0c57cb48f..3c26edd0c3 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/9846aba7d4..b7cdacaadb * third_party/r8/cipd: fPtOVFF2pWq045gaoD8_EIc8Kg9zbgBc6ydnAE7ATicC..LHNTk_-ajFbwrjtRsvuqgsLQGXD5dbTlWyV1MJ4_u2EC * third_party/turbine/cipd: jgDuyha_VOnbWcvPhoSVjeQWyIfb_WwGGzpBQOhrFZsC..vSia3h9tzpwpP_goLj4HMdl7_FEB5iVCv9nU5ZXOfIMC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I5929befa166c6378cd98602cd9a5b7158013cca6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5901574 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 572fd30e 2024-09-25T13:33:01 Clean up LineLoopIndirectTest The helper test function runTest() for LineLoopIndirectTest includes some special cases in its args that are not used in all cases, such as consecutive indirect calls. This CL aims to split this function into separate test cases to make each test more readable. * Added functions for some of the common procedures. * Split runTest() into each test suite with the help of the common functions and values as well as the special cases for each. * Removed runTest() from this test suite. * Updated an old bug number (667 -> 42265165). Bug: angleproject:360758685 Change-Id: I98e1facff0a6bad0ee2deca9313644379345d9c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5892535 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Amirali Abdolrashidi 67a5ea45 2024-09-23T16:09:12 Vulkan: Fix the error from multiple lineloop draws Since Vulkan does not support line-loop draws natively, such a draw call requires the conversion of the related buffers to prepare them for this operation. For glDrawElementsIndirect(), the index and the indirect buffers would need conversion. However, what currently happens in this case is that the original buffer pointer is overwritten after the conversion, removing the link to the original buffer. Therefore, if there is a second line-loop call just after the first, it will try to use the converted buffer as the new source, which leads to errors due the buffer already being in use. The index buffer for the draw is bound when the related dirty bit is handled. Therefore, instead of using the draw index buffer directly for handling the line-loop scenario, we can use the index buffer in the form of a local pointer passed between functions. Then, in order to reconcile line-loop with the other cases, the draw index buffer is set just before setting up the indexed draw. * Functions handling line-loop draws do not modify the element array buffer in VertexArrayVk directly, but use local buffer pointers to pass the current element array pointer to further processing and drawing. * Added mCurrentElementArrayBuffer for ContextVk to be bound to the index buffer to used for draw instead of the one from its vertex array object. * Before the indexed draw, mCurrentElementArrayBuffer is set to the last destination index buffer. * Added unit test that makes a line-loop draw and then a non-LL call using the same element array. Bug: angleproject:360758685 Change-Id: I6d6328f6326c1a1f9f80e5ef346aa077c867d344 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5878764 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Juston Li e06b07a9 2024-09-27T18:17:16 Vulkan: populate ycbcr conversionDesc for yuv VkFormats For this case, the external format has a vulkan equivalent VkFormat and is YUV, so conversionDesc needs to be populated. YcbcrConversionDesc::update() expects externalFormat to be 0 in this case since it has an equivalent. Bug: b/368429977 Bug: b/352595520 Change-Id: Ifdae7a539555d78bbbf9d11cdbb946cb815c7709 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5896250 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Roman Lavrov 03b5ea39 2024-09-27T14:03:16 Traces: --offscreen syncs on N-2 frame GPU completion This avoids the issue described on the bug where an app's assumption about double buffering can create a race. This prevents the replay from getting too far ahead rendering to offscreen framebuffers. Also correct mOffscreenFramebuffers to use mTotalFrameCount as the use of mOffscreenFrameCount appears accidental. Bug: angleproject:370089935 Change-Id: I30f438eb66201fe77d61710cbe6e90d47e839dd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5895974 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi 7c811715 2024-09-25T11:09:44 Vulkan: fix crash when clearing stencil with ClearBuffer Follow up to [1] which fixed a crash with glClear, but the bug remained with glClearBufferiv. This change refactors the "is stencil write masked out" query to always take the framebuffer's stencil bit count into account (practically always 8), which also happens to make the rest of the code checking this query more accurate in the presence of nonsense masks where the bottom 8 bits are 0. [1]: https://chromium-review.googlesource.com/c/angle/angle/+/3315158 Bug: chromium:40207259 Bug: angleproject:42266334 Change-Id: I68a6b0b75c67ed2cdc8c4d03b243efe5495efce1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5889788 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 163e24e4 2024-09-30T10:01:30 Roll vulkan-deps from 4c709b68a2c6 to 223523f05dc0 (12 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4c709b68a2c6..223523f05dc0 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/74bbd88af4c48ac1244be6bc4e579e0aa34797a4..b2b32340f481d2c024e96a39aa26b7391684e554 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/b1ad37b175940db03ee4e1fee9a14cc349281ec1..d9c1aee6a609c6d6ec1caab4def80720c44bd08d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/4eaa6df4250693b4a2b654ca2464b25a299d94fe..56dd9f2344a7be1d218a54549a4a5e39c1e85073 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/05e068941b49277189d0bbcdc5f722724eb3c5a3..2020cec4111c87d85b167d583180b839f0c736c5 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/699302d21c532c091e3e6a98f0bb6697668d79f7..8bb1ad96a6204dd85b4af293eddc76a6f6ea3a54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I3bd42b5ced107038d0c69bbcf9e3bd58cafcf65b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5898293 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll cedad475 2024-09-30T08:11:58 Roll Chromium from 37b223759e13 to a588c34f73df (702 revisions) https://chromium.googlesource.com/chromium/src.git/+log/37b223759e13..a588c34f73df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/525c52ee51..9b11bd3a6a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/50c43ab677..7f979120bf * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3abdc95e31..208275633f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ac3b7937a3..2c16d7f80b * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4283da1005..e2d898ca22 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/dc70138c3e..9846aba7d4 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/37bbf271c6..490643fe6e * third_party/r8/cipd: -oM8N-lmpKbHYjMAwUrPFcXuIU-At8GNBRcN7lw1yQYC..fPtOVFF2pWq045gaoD8_EIc8Kg9zbgBc6ydnAE7ATicC * third_party/siso/cipd: git_revision:e8827a58e51f92cc53a44fb40db89dbde507f800..git_revision:dc7a06223e4ccbde049613ed802448b0c8baf5af * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/4e7090e945..9454d9302a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d29ec9d823..7566fe8521 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/55c874fc83..fc8a6438be * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/554b1c2ae9..5acd9395d2 * tools/skia_goldctl/linux: nhLF1m8qLFIszoP0noX1fdsk_QSNi-jLb9e3J5BslIQC..4s_ABtbPMrcHw-KqJwj3L7vboveu3iDg8e7n8uRmve8C * tools/skia_goldctl/mac_amd64: P8z9DQNHdJruN8-dvIYUO7kga7HmjgOPwDKbZnNttoMC..2hD9HfEqA8X9avGf12065M8P4WL34srX9Ba31JyGgWQC * tools/skia_goldctl/mac_arm64: ag9qROrBBrm16IGPth-JG7XHTYuTnejH1ce3mBa98KsC..JK9cZP89yujG9N6OVFr-rqipABokDP_AfO0itS1ewdMC * tools/skia_goldctl/win: qfl-q1Kob2At5EGwvztaZNPvvD9Nl730_iDtGMTdPOAC..hnJ2kurx2k7B9cFvcdV0wdw_62bq1NtnKmN98DP7N40C No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I050160084ceb548ae49834b8ecaf7d58d1856030 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5897348 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski 7b0212b3 2024-09-27T10:02:58 Retrace cod_mobile for minimum requirements Test: angle_trace_tests --gtest_filter=*cod_mobile Bug: b/369984808 Change-Id: Ibf3b5c446311d27b0a78867cbd8cc523f76adcbc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5895156 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shufen Ma 0621c95c 2024-09-09T09:43:43 Add test for repeated indirect line loop draws This test is used to verify that two indirect draws drawing line loop and sharing the same index buffer works. Bug: angleproject:360758685 Change-Id: I4386e404ed0e0accf0dbb1edab8671e7f2d9939d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5855003 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev baf0c6b2 2024-09-19T00:00:00 Metal: Refactor texture[Lod]Offset wrappers * Removed variadic macros. * Removed invalid textureLodOffset overload. * Split bias variants into separate wrappers. * Updated emitter to not output unused variants. Bug: angleproject:368059227 Change-Id: I983d84685479e5154f2ecfb15b525c1acbb9e280 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5890517 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev bc9c772d 2024-09-19T00:00:00 Metal: Refactor textureProj[Offset] wrappers * Removed variadic macros. * Split bias variants into separate wrappers. * Updated emitter to not output unused variants. Bug: angleproject:368059227 Change-Id: I6e08e92dfbc2378bfc4ccd7760dbe28f6bc64f27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5893163 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 15a64b27 2024-09-27T10:01:53 Roll vulkan-deps from 4b313c0d5593 to 4c709b68a2c6 (36 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4b313c0d5593..4c709b68a2c6 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/96899e0f47045846b3b77cd9a9710c6366d9f859..46ef757e048e760b46601e6e77ae0cb72c97bd2f https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/a24a94aa0d1fc4e5556bdf9c6b2afe8eacc55326..74bbd88af4c48ac1244be6bc4e579e0aa34797a4 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/2a9b6f951c7d6b04b6c21fe1bf3f475b68b84801..ec59c77a3bb5c747a369931ef101ac7c14823f2f https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/362ce7c60d040ed927464ed4f29c688dbc541886..b1ad37b175940db03ee4e1fee9a14cc349281ec1 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/c6391a7b8cd57e79ce6b6c832c8e3043c4d9967b..29f979ee5aa58b7b005f805ea8df7a855c39ff37 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/6b31cf1995f78f26e0f2fe136343ed09bd35f09b..4eaa6df4250693b4a2b654ca2464b25a299d94fe https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/4c63e845962ff3b197855f3ae4907a47d0863f5a..05e068941b49277189d0bbcdc5f722724eb3c5a3 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/6fb0c125afec7b9d724d598f4dca6c61648be35f..a71907b8577c994b1c69adfa7315d55bbe79656e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/de3e5dc69c0220183dd94783d803f6c665fdf90e..699302d21c532c091e3e6a98f0bb6697668d79f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I803e270ce3048cbd2e34c85069cbfe774243ffec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5895151 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 474b7c2e 2024-09-27T08:40:20 Roll Chromium from da7173a2a2dd to 37b223759e13 (591 revisions) https://chromium.googlesource.com/chromium/src.git/+log/da7173a2a2dd..37b223759e13 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/87926d0c65..525c52ee51 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d57511c7e0..50c43ab677 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2073e87e1b..3abdc95e31 * third_party/android_build_tools/manifest_merger/cipd: 9RefiB8U2iqJIwRvhr9i3Ef7V4fbSA3E7wgrSfaCVUcC..nF0aNBggEihalcCW3jCKPV8O-xsiz2xTWqzRjbCLyIYC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c35a3f7fb5..b952ef48c3 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/950ee67c12..ac3b7937a3 * third_party/fuchsia-sdk/sdk: version:24.20240919.7.1..version:24.20240927.1.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/423aee3f0c..4283da1005 * third_party/r8/cipd: yEomA-IPmb_JtuiEvwgtxRHtSEaICkDY1sDko_rQGO0C..-oM8N-lmpKbHYjMAwUrPFcXuIU-At8GNBRcN7lw1yQYC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/6081c91f33..4e7090e945 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2acd1a1871..d29ec9d823 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ac29d2a893..55c874fc83 * tools/skia_goldctl/linux: fHdSe87RtA3Dr-1IxzURvA8sdjj4e7OLtfuCQUq1MOYC..nhLF1m8qLFIszoP0noX1fdsk_QSNi-jLb9e3J5BslIQC * tools/skia_goldctl/mac_amd64: efDh-AUeT-p8unLvlJEi-YlO7_tUtsHKBhLGybqPqroC..P8z9DQNHdJruN8-dvIYUO7kga7HmjgOPwDKbZnNttoMC * tools/skia_goldctl/mac_arm64: pTmvrhu0Q9BfxM-0OBU5c9MDCINFu0GquHoEs0O5sYoC..ag9qROrBBrm16IGPth-JG7XHTYuTnejH1ce3mBa98KsC * tools/skia_goldctl/win: lUcFIeW4Xswb1NlNNtvMBXvNCoRTAu2y2SaaFnGtyvsC..qfl-q1Kob2At5EGwvztaZNPvvD9Nl730_iDtGMTdPOAC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ib08f5c96a09081b823ea38fb3adae6325630860b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5894154 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mark Lobodzinski 0ec8a7f1 2024-09-26T11:06:25 Prevent multiple solutions when retracing with get_min_reqs Skip extensions that implicitly enable other extensions in the retracer script when running to determine minimum requirements. Test: Retrace cod_mobile with get_min_reqs Bug: b/42266279 Change-Id: Iee6f629d1b338362809ff8880d8a5d9ed7c574de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5893959 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Shahbaz Youssefi 05c62ebc 2024-09-24T13:41:57 Fix check for whether stencil write is masked out The stencil write mask is the only thing that decides what bits get written to. Previously, this was masked with the reference bitmask to determine if any bits get written to, which is incorrect. The effect of this was that the Vulkan backend would use the READ_ONLY layout for the depth/stencil attachment even though stencil could have been written to the attachment. Bug: angleproject:42266334 Change-Id: Ice6a35f4691fc8e09c7d5e1db6439c3079dfa039 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5887905 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev b4ec5850 2024-09-19T00:00:00 Metal: Refactor textureProj(Grad|Lod)[Offset] wrappers * Removed variadic macros. * Updated emitter to not output unused variants. * Added MSL compile guards to not fail shader compilation on macOS 10.15. Bug: angleproject:368059227 Change-Id: If9d9479c056da6a76cff78c7c5b42101a0fcce1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5893255 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Geoff Lang fe8c0390 2024-09-25T19:00:34 WGSL: Run SeparateCompoundStructDeclarations to name structs Borrow SeparateCompoundStructDeclarations from the Metal backend to separate struct definitions and name nameless structs. Refactor id generation into a callback. Bug: angleproject:42267100 Change-Id: I8ed6f13113a5d5e450d30ce187ce1df52e572000 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5889089 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Geoff Lang 7e249881 2024-09-25T17:31:18 HLSL: Emulate mix functions when the last parameter is a bool. Add emulation for the ESSL 310 variants of mix that use int and uint vectors and a bool selector. Bug: angleproject:369533080 Change-Id: I0491c50c65529b9d922d4745c0989131b9981048 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5892352 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: dan sinclair <dsinclair@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 994bbbfc 2024-09-23T23:30:10 Vulkan: Don't require renderability in AHBs If the AHB usage includes GPU_FRAMEBUFFER, in practice it should be impossible for the corresponding Vulkan format to not be renderable. However, to guard against potential driver bugs, renderability is still checked if the AHB usage includes that bit. Bug: b/368429977 Change-Id: Iae23432c369cd933f14c143f67c08720d76009fc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5881904 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Hao Li 2af09236 2024-09-24T13:55:04 Vulkan: Enable monolithic pipelines on Intel Windows The hang issue is fixed and not reproduced on Intel Windows drivers 101.5379 and later. Bug: angleproject:369043994 Change-Id: Ic395ca47e65fa6467baf09e54b7e24c0d7d71ad3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5885989 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 94a8bfa8 2024-09-26T07:32:42 Roll Chromium from 0570283bb92a to da7173a2a2dd (623 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0570283bb92a..da7173a2a2dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a35a64253a..87926d0c65 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c50ea35e09..d57511c7e0 * buildtools/linux64: git_revision:e30a1fe26e5e72cb7cb9f27d9abe2330e4115ae5..git_revision:95b0f8fe31a992a33c040bbe3867901335c12762 * buildtools/mac: git_revision:e30a1fe26e5e72cb7cb9f27d9abe2330e4115ae5..git_revision:95b0f8fe31a992a33c040bbe3867901335c12762 * buildtools/win: git_revision:e30a1fe26e5e72cb7cb9f27d9abe2330e4115ae5..git_revision:95b0f8fe31a992a33c040bbe3867901335c12762 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4dfba9953e..2073e87e1b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/0ec07e3188..d2ea9f0eb1 * third_party/android_build_tools/manifest_merger/cipd: 58MT5WKMssYfSsFXPJl_FgaazDD-eTRZ36mxEteFDKkC..9RefiB8U2iqJIwRvhr9i3Ef7V4fbSA3E7wgrSfaCVUcC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4e0ee76004..c35a3f7fb5 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8050ac421d..950ee67c12 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/06d85ffb29..423aee3f0c * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/448b409508..d0c57cb48f * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/65882647a0..6081c91f33 * tools/luci-go: git_revision:89012fa4a0c088cc353b23c6af126e2832114ef6..git_revision:cb4b10bea51ea74dbdfeb6d377481c884ab23db8 * tools/luci-go: git_revision:89012fa4a0c088cc353b23c6af126e2832114ef6..git_revision:cb4b10bea51ea74dbdfeb6d377481c884ab23db8 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/34e5cbb62b..ac29d2a893 * tools/skia_goldctl/linux: exn-2zl58W0X1OMx6QST_oflnyhWKJjt2Uy9FfygO0MC..fHdSe87RtA3Dr-1IxzURvA8sdjj4e7OLtfuCQUq1MOYC * tools/skia_goldctl/mac_amd64: nDAmPEM8gXi2n-F_vMDlo5aM0EggPcVi9Ri5qgsAeCsC..efDh-AUeT-p8unLvlJEi-YlO7_tUtsHKBhLGybqPqroC * tools/skia_goldctl/mac_arm64: FgBrUVRF_27TQWvlZa7M0pUBdN6gKi_VLPur0iyeOzoC..pTmvrhu0Q9BfxM-0OBU5c9MDCINFu0GquHoEs0O5sYoC * tools/skia_goldctl/win: rldVtBn5UM_uxLb4WwsN7JyUCeJ_dGVWuwZHgfbG0ngC..lUcFIeW4Xswb1NlNNtvMBXvNCoRTAu2y2SaaFnGtyvsC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I7baaa4d31a7f7ce3f1dc46cbb03fcb2d4e1939e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5893033 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton 966739ac 2024-09-19T23:49:06 Drop PLS support for EXT_shader_pixel_local_storage Supporting this backend drastically increased the complexity of the codebase, with little return. We don't support memoryless attachments on the web anyway, and since this extension requires us to literally draw the load/store operations, input attachments on Vulkan perform better. Once this implemention is completely removed, we will delete the PLS allow list, which isn't required for the other PLS implementations. Bug: angleproject:7279 Change-Id: Ibb036d36cbd33467e7a94398ce171cda7349e4f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5874412 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Matthew Denton a6ee4641 2024-09-25T11:41:47 WGSL: Output default uniform block and accesses to it Default uniforms are put into a WGSL struct, and all accesses of those uniforms now output struct accesses. Similarly to I/O vars and builtins, these are outputted in a pre-pass, but in the future it might make sense to do what Vulkan does and do an AST transformation to put the default uniforms into a UBO which should be outputted similarly. This does not handle bool, matCx2, or array of element size < 16. Bug: angleproject:42267100 Change-Id: If29e2895a8aba3212b581813316af87273c1515c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5878759 Reviewed-by: Liza Burakova <liza@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Yuly Novikov fe6c13d7 2024-09-25T13:34:49 Skip dota_underlords on Linux NVIDIA Recently became flaky on GTX 1660 driver 535.183.1.0. Bug: angleproject:369533074 Change-Id: Ieba8657366687f742812643cb25cadfd7ba09817 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5889565 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0