kc3-lang/angle

Log

Author Commit Date CI Message
yanhongchen b03a018c 2023-06-15T19:36:16 Android: Add privapp-permissions XML Bug: angleproject:8210 Bug: b/242671681 Change-Id: I57d14eb026fab319e080cedcfefd5c160c1321d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4617552 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com>
Geoff Lang 1d496191 2023-07-13T14:14:08 Revert "Terminate the display if initialization fails." This reverts commit ebaadc6c2cba4085e0d31ca7deebd00192e33f64. Reason for revert: Breaking some Chrome/Dawn tests that use the VK backend Original change's description: > Terminate the display if initialization fails. > > If DisplayImpl::initialize fails, call terminate to ensure no resources > are leaked. > > This is a speculative fix for dual GPU macs not falling back to the > low power GPU. DisplayMtl leaks the metal device if it fails to > initialize due to unsupported GPU families or vendors. > > Bug: chromium:1322521 > Change-Id: Ie227216bc92ef2834ec50190fbb78bec45e9c053 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4641107 > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> Bug: chromium:1322521 Change-Id: I379521130071623a8d050d2cadf2059c0b696d32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678359 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 394c90ea 2023-07-12T15:58:04 Remove stale autogen files The GL entry points were combined per major version in: https://chromium-review.googlesource.com/c/angle/angle/+/2566592 But the stale minor-version based autogenerated files were not removed. Bug: angleproject:2621 Change-Id: I8c793a7d5e44e323dd4d702747ccb9bb58105e19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678351 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi fd80ef86 2023-07-12T13:35:44 Remove redundant mip-level-size validation The ValidImageSizeParameters function already calls ValidMipLevel. The few places that called ValidMipLevels are fixed not to redundantly do so. Bug: angleproject:8224 Change-Id: I8e0745edb68be97a6903d7801560212cc53d0d6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678285 Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 27465cda 2023-07-13T10:01:05 Roll vulkan-deps from 4ba3255697ef to ad8a66bf7d69 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4ba3255697ef..ad8a66bf7d69 Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/d0006a3938..f1ba373ef0 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7ff331af66..9ab811a125 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/011b0090ed..c3065a7aed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ibb6582a8c777d7aa38318c439fa0a98104634db7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4681277 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a7e31a4e 2023-07-13T10:01:15 Roll SwiftShader from dda70a3ef9fe to 151fa797ee3e (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/dda70a3ef9fe..151fa797ee3e 2023-07-12 aredulla@google.com [ssci] Added Shipped field to READMEs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I6e8b8e0d551766b260adc255f3ede6966719f4e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4683185 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6946ca87 2023-07-13T07:00:34 Roll Chromium from 3d5d845687d5 to de1153f640b8 (604 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3d5d845687d5..de1153f640b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e7cd327c47..4c5f2bf0f3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0732a94e42..a59ee3caa2 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/14eb523de5..996d3d5271 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4ca1551fb4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/43bf9b7258..7265d88a45 * third_party/r8: GB_DKiGwJt0TJAnCuEsWhGQdS_JTlr-KQRb0J6aO-r8C..Sz7S7AlqFPYB_t29P5b6i5K80Wq00mpvN2y8aNUAqo0C * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/1206f0dbef..61dc0bd13f * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/e5b5f210e7..ffa8abcd30 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c29b6b927f..4786f206b4 * tools/luci-go: git_revision:5d9f8239e3691bb585eeb88103ee6b4a8d212c0e..git_revision:1b0aa1222dd6e11673230e5b093d0a8ed6244e95 * tools/luci-go: git_revision:5d9f8239e3691bb585eeb88103ee6b4a8d212c0e..git_revision:1b0aa1222dd6e11673230e5b093d0a8ed6244e95 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3fd043fc8b..f7c0d5e54a * tools/skia_goldctl/linux: 6IuiEt6PqBPJ4kLiJ80ktH5SSuZwmG3r9o0xjRAYkNkC..rm5mLaL8XD6eQvwq5a1oqtyfUbbjnUo1uQlcF6zoxLAC * tools/skia_goldctl/mac_amd64: Ts8bufL5zc4XHclA3vKuDS5FyicKlY7XQ_luGzlpdQ4C..D2Xn7R8I-IEY0P-2JklhAHVSbuuUizevvyMlfXENjKkC * tools/skia_goldctl/mac_arm64: wk3OK108QbrE71cy85i0x-mRelw2_Hln3-7oAEyjA8cC..xKGurBAqifTBoPNsTYQDrb9o_k5Twba5Dh1qwgE3iR8C * tools/skia_goldctl/win: ECZgbn-oQ7jsny_alVyAdR5ZDzOuPhKMX-YhZPdfnBIC..rpb78oS4WtlmYjaFPtWhEWaEIOXmzXAoSTnFu9WwSmsC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I0f289bf738f9cd7cb1281d248e3669fc4956e2c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4681416 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 8ae9f28d 2023-07-11T16:35:19 Make context-loss state atomic This state can be set by other threads, including those without a context in the share group; context loss can originate from the Display and is propagated to all contexts. This change makes the relevant flags atomic which are read with relaxed memory order to minimize their impact on performance. Bug: angleproject:8224 Change-Id: I1f0a29210e07cd153db79fdc01d551cf96df4143 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678784 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao f5986fbb 2023-07-11T12:11:20 Vulkan: Dont break RP if there is actual render feedback loop There is a bit terminology confusion here that will be fixed in next CL. If a depth attachment is read only, then there is no feedback loop, we should not call feedback loop for read only depth attachment. The real depth render feedback loop mode is formed when we write to depth and sample from depth at the same time. In this condition, the content is undefined per OpenGLES spec section 9.3.1 (https://registry.khronos.org/OpenGL/specs/es/3.2/es_spec_3.2.pdf). The shouldSwitchToReadOnlyDepthStencilFeedbackLoopMode() implementation handles the usage case that the same render pass has depth write and then switch to read only. Under this usage there is no actual feedback loop, and we should still work properly by end current render pass and start a new render pass with read only depth attachment. This implementation also treating the actual feedback loop case exactly the same way by ending render pass first, even though this is undefined behavior. gangstar_vegas has the exact this undefined behavior usage case, where it write and sample from depth buffer at the same draw call. Native driver is not ending the render pass but ANGLE currently does. This puts ANGLE into worse performance. Since this is undefined behavior, either way is correct. This CL checks if there is an actual feedback loop in the current render pass and if yes, we adopt the native driver's behavior that keep the current render pass going. This improves gangstar_vegas frame time from 4.365ms to 3.89ms, and interestingly, yield the same golden image. Bug: b/289436017 Change-Id: Ifc04ecd8ad6455a88e8615bd5452b9cce88c6687 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4679361 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 2a08c33b 2023-07-10T17:47:49 Vulkan: Avoid flushCommandsAndEndRenderPass for readonlyDS switch When we switch to read only depth stencil mode, right now we always call flushCommandsAndEndRenderPass, even though the started render pass is empty and loadOp is load. This flush will cause render pass actually submitted and color attachment being cleared and then color attachment gets loaded in the subsequent render pass. In this CL, we only flush if the depthStencil attachment has clear or written This CL save one renderPass for the following app traces: antutu_refinery, aztec_ruins, manhattan_10, manhattan_31. Bug: b/290833623 Change-Id: I13b7a968d797b4c913f1cfbe9677d9b8abe791d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4674087 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi 9962f078 2023-07-11T15:39:50 Pass only context-private state to private entry points This change ensures that the implementation for these entry points cannot access anything other than context-private state. Bug: angleproject:8224 Change-Id: I988672b138d861db25e91d71ab8c34baa4e8ebee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678783 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 491c2a54 2023-07-11T15:20:09 Split the context-private part of the state cache In preparation for passing it directly to entry point implementations, ensuring no access to the share-group-accessible part. Bug: angleproject:8224 Change-Id: I705e6a8fb5204bab71caffff4dcb56d16c3d6e10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678782 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 40111c68 2023-07-11T14:21:21 Rename context-local to context-private state Bug: angleproject:8224 Change-Id: I1bb39475043f8fb14d683d11a038b4850692a8c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678781 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop c93682d3 2023-07-12T11:08:25 Revert "Stop rolling third_party/cpu_features" This reverts commit da710ac3f731c128caf0aff75c0cd6e58a0591af Reason for revert: Causes Android roll to fail http://anglebug.com/8255 Original change's description: > Stop rolling third_party/cpu_features > > It was probably needed for zlib previously but now zlib already depends > on the ndk's cpufeatures. There are no references to third_party > cpu_features in the generated Android.bp. > > Bug: b/289259681 > Change-Id: Ib849b26391d0c23e533662094e74384c267c8620 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4656761 > Reviewed-by: Solti Ho <solti@google.com> > Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> > Auto-Submit: Roman Lavrov <romanl@google.com> > Commit-Queue: Solti Ho <solti@google.com> Test: scripts/roll_aosp.sh Bug: angleproject:8255 Change-Id: I2a879a3675a1c041a0e6ffff2be886aa693e486d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4680107 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 75e64719 2023-07-12T10:01:34 Roll SwiftShader from 3e73cce1c470 to dda70a3ef9fe (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/3e73cce1c470..dda70a3ef9fe 2023-07-11 jif@google.com [LLVM 16] Have Swiftshader built with Android.bp use LLVM 16. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ib06f37931e7291887caf54a19c4601d87e79066b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4681283 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Phan Quang Minh 4cab5e94 2023-07-12T10:04:10 Vulkan: Enable timeline semaphores if supported by device This is needed for a similar change in Chromium to function with `--enable-features=VulkanFromANGLE`. Bug: angleproject:8253 Change-Id: I422964ea010c650439dd4797ee8ba7b533f26a87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675807 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 2134a9de 2023-07-12T10:01:34 Roll vulkan-deps from 03c816988bfd to 4ba3255697ef (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/03c816988bfd..4ba3255697ef Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/eaa7057768..44779f508a * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4be7d0e3ca..7ff331af66 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/db290809b5..011b0090ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I82ccb55b54c9e8d30eb9a889a08cb48eb9f0771f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4679255 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 94ceedb7 2023-07-10T00:00:00 Add GL_EXT_texture_compression_astc_decode_mode stubs Bug: angleproject:8254 Change-Id: I2a839139b5738710e32842b04db35eab8fb04687 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4679683 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 1aa2c87c 2023-07-12T07:01:45 Roll Chromium from d0f9360d7ae6 to 3d5d845687d5 (622 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d0f9360d7ae6..3d5d845687d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/143d726c8e..e7cd327c47 * buildtools/linux64: git_revision:11e12b0ef870b42ecd3b489a194c0c434a054d25..git_revision:fae280eabe5d31accc53100137459ece19a7a295 * buildtools/mac: git_revision:11e12b0ef870b42ecd3b489a194c0c434a054d25..git_revision:fae280eabe5d31accc53100137459ece19a7a295 * buildtools/win: git_revision:11e12b0ef870b42ecd3b489a194c0c434a054d25..git_revision:fae280eabe5d31accc53100137459ece19a7a295 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/7a9572876c..0732a94e42 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/aa4f4558ff..e197e4c396 * third_party/android_build_tools/lint: z1zqFkwGcjud6JnSJ-81QiOYgD-OlvkQg5Fgt_gHwtoC..OPMAEfzTB1WPytaO0pMOPg9GHVByubIOUvOsCwKS1oQC * third_party/android_build_tools/manifest_merger: oD5bP72e45KzyT-yHx9yFfQcqpEfOUERdpMaR7rkTRcC..kxzD7gkXhEJiL_u2jVkpX0Npl2MLoSvbnBezhq29dAgC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2565a43987 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e5277508c8..43bf9b7258 * third_party/jdk: CAecD8de4xl5Dzo6fbtuVg-F4wY-ejtCBAmN3Qhj0J8C..9-e8GxXJduErc9j3s5VUmbAWTorSHxvcn23GNjYtCNwC * third_party/r8: FxcKKMhpNz8EQC9ZdDwB64ZzLm1VrWw21A_m20AOKaAC..GB_DKiGwJt0TJAnCuEsWhGQdS_JTlr-KQRb0J6aO-r8C * third_party/requests/src: https://chromium.googlesource.com/external/github.com/kennethreitz/requests.git/+log/refs/tags/..c7e0fc087c * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/7eff33bc00..1206f0dbef * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/7b20bcffe9..e5b5f210e7 * tools/luci-go: git_revision:15be1e7f953cb4ef6d88aba86f57ca28724d1c9a..git_revision:5d9f8239e3691bb585eeb88103ee6b4a8d212c0e * tools/luci-go: git_revision:15be1e7f953cb4ef6d88aba86f57ca28724d1c9a..git_revision:5d9f8239e3691bb585eeb88103ee6b4a8d212c0e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/56589b6087..3fd043fc8b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4b4a958480..86375f9e21 * tools/skia_goldctl/linux: 209WoWuXITgke_BJDnvM7aTy7wu2jFOUPYs4uIoJ3CAC..6IuiEt6PqBPJ4kLiJ80ktH5SSuZwmG3r9o0xjRAYkNkC * tools/skia_goldctl/mac_amd64: vEHTSSZiGWhNdCjMGZ22sj4PfyPzgoIIkV97YXOJeKEC..Ts8bufL5zc4XHclA3vKuDS5FyicKlY7XQ_luGzlpdQ4C * tools/skia_goldctl/mac_arm64: CcHM6-LZ7_b-Api718RTCYQPD0v17lWKuQBaz42b8r4C..wk3OK108QbrE71cy85i0x-mRelw2_Hln3-7oAEyjA8cC * tools/skia_goldctl/win: u5j7yik1xZdFc9dECFfFDX9vRP9go2GpqukfJwOLCbgC..ECZgbn-oQ7jsny_alVyAdR5ZDzOuPhKMX-YhZPdfnBIC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ie61d1ebe8be0620b0d41d6ee8a39d49b97a29527 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4679254 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang ebaadc6c 2023-06-24T08:41:15 Terminate the display if initialization fails. If DisplayImpl::initialize fails, call terminate to ensure no resources are leaked. This is a speculative fix for dual GPU macs not falling back to the low power GPU. DisplayMtl leaks the metal device if it fails to initialize due to unsupported GPU families or vendors. Bug: chromium:1322521 Change-Id: Ie227216bc92ef2834ec50190fbb78bec45e9c053 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4641107 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Yuxin Hu 759027e8 2023-07-07T14:51:56 Enable the new deqp khr test suites on Bot This CL enables the deqp khr test suites added in https://chromium-review.googlesource.com/c/angle/angle/+/4654841 on below bots: pixel4 vulkan backend pixel6 vulkan backend windows vulkan backend linux swiftshader backend linux swiftshader backend tsan linux swiftshader backend asan The current linux driver on bot does not support the new test suites on vulkan backend. We will enable the test suites on linux vulkan backend after we upgrade the bot machine driver to a newer version: https://bugs.chromium.org/p/chromium/issues/detail?id=1271688 Bug: b/286921997 Bug: angleproject:8251 Change-Id: I659424efc09028f685edff076711c9089ec635d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4673582 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Oliver Wolff 6473008c 2018-08-22T13:12:07 winrt: Fix initialization of zero-sized window The clientRect might be empty when creating a window of zero size. The side effect of a division by zero is that matrix transformation fails and hence the swapchain gets into an invalid state. See: https://code.qt.io/cgit/qt/qtbase.git/tree/src/angle/patches/0005-ANGLE-Fix-initialization-of-zero-sized-window.patch?h=5.15 Signed-off-by: L. E. Segovia <amy@amyspark.me> Bug: None Change-Id: Idbaed72deadb7b87052ac27e194a40d1810e6f7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661674 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 9b63700b 2023-07-11T10:25:40 Translator: Reorganize files This change makes the translator files more organized by: - Grouping files that are specific to a certain output under their own directory, - Moving transformations under tree_ops - Removing Direct from metal translation now that that SPIR-V Cross path is removed Bug: angleproject:6394 Change-Id: Iaf5bb8d5604b84748dece029821b1f77b2813967 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4678780 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Geoff Lang 4e6124da 2023-06-23T14:46:28 GL: Ensure all instanced attributes have a buffer with data Apple OpenGL drivers sometimes crash when given an instanced draw with a buffer that has never been given data. It's not efficient to check if the attribute is both zero-sized and instanced so just ensure that every time a zero-sized buffer is bound to an attribute, it gets initialized with some data. Bug: chromium:1456243 Change-Id: I66b7c7017843153db2df3bc50010cba765d03c5f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4642048 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Oliver Wolff 5922b83b 2018-08-22T13:01:10 D3D11: Fix Windows Store D3D Trim and Level 9 requirements Due to additional validation not covered in previous patches, the Windows Store certification compatibility had regressed. These changes ensure that the required D3D behaviors are met. See: https://code.qt.io/cgit/qt/qtbase.git/tree/src/angle/patches/0003-ANGLE-Fix-Windows-Store-D3D-Trim-and-Level-9-require.patch?h=5.15 Co-authored-by: L. E. Segovia <amy@amyspark.me> Signed-off-by: L. E. Segovia <amy@amyspark.me> Bug: None Change-Id: If8bc2f8cd4b2f84e1d92a1627951da2537212125 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661673 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi f0653461 2023-07-11T10:13:09 Translator: Fix metal-only build Bug: angleproject:6306 Change-Id: I068dc93528b7583ddc84836ac73b52adcde890f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4677722 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi f5ad056b 2023-07-10T22:13:34 GL: Fix ScalarizeVecAndMatConstructorArgs and move to gl/ This transformation was buggy and was disabled. Originally, it was intended to be used everywhere. It is now needed for a GL driver workaround. This change reimplements this transformation and uses it as a GL workaround. Bug: chromium:1420130 Change-Id: I42d63fa5844bcf683ac41e61925aa637e033ca2e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4676634 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 0312c76f 2023-07-10T15:12:52 Translator: Move metal-only transformation to its own dir Bug: angleproject:6306 Change-Id: I5ff453f03cccd1c4bcec59e21a18fc6049598383 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675654 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 648f24c9 2023-07-10T17:59:29 Start Mac AMD 13.4.1 experiment Bug: chromium:1462473 Change-Id: Ic30d5f5a0999c10949581aff813febdb83a8cef9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675805 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
angle-autoroll 7de7b9a4 2023-07-11T10:01:30 Roll vulkan-deps from 869b279baef4 to 03c816988bfd (17 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/869b279baef4..03c816988bfd Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/3ebb72cc74..eaa7057768 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/870fd1e17a..4be7d0e3ca * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/179b26a792..2565ffa31e * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/9d38cccf33..8b94e87bff * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/39090f9152..6e7fa4d975 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/db466666ac..db290809b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Idb10483c233a386723d71bd478c396ba5546947c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675703 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll daeef9fa 2023-07-11T07:00:57 Roll Chromium from 749d653d9a36 to d0f9360d7ae6 (471 revisions) https://chromium.googlesource.com/chromium/src.git/+log/749d653d9a36..d0f9360d7ae6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/194f8687fe..143d726c8e * buildtools/linux64: git_revision:1de45d1a11cc9f8cb5c75a031386151e1c384847..git_revision:11e12b0ef870b42ecd3b489a194c0c434a054d25 * buildtools/mac: git_revision:1de45d1a11cc9f8cb5c75a031386151e1c384847..git_revision:11e12b0ef870b42ecd3b489a194c0c434a054d25 * buildtools/win: git_revision:1de45d1a11cc9f8cb5c75a031386151e1c384847..git_revision:11e12b0ef870b42ecd3b489a194c0c434a054d25 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/24349b4e60..7a9572876c * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/fa6fe66454..aa4f4558ff * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/ea2e39562f..14eb523de5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7d7df42f80 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/247429efd9..e5277508c8 * third_party/jdk: -1zDGMOzS_Qsja50TakJCSqN9C9TYppQrsny4HATSQwC..CAecD8de4xl5Dzo6fbtuVg-F4wY-ejtCBAmN3Qhj0J8C * third_party/six: https://chromium.googlesource.com/chromium/src/third_party/six/+log/c96255caa8..32c68ae5c1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/eaa6ca74e2..c29b6b927f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/21264809df..56589b6087 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I89b29bf8b6a8a065b70a1c6037f0ddd4c804b955 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4676841 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Sunny Sachanandani 7bcd88cc 2023-07-06T15:44:44 gl: Do not propagate copyTexSubImage2D error to client https://chromium-review.googlesource.com/c/angle/angle/+/4662393 ensured that BlitGL::copyTexSubImage allowed the caller to fallback when the underlying copyTexSubImage2D call failed, but the GL error was also propagated to the client due to the Context::handleError call in CheckError - that error still causes webgl conformance failures even though the pixel expectations are now satisfied. This CL makes BlitGL::copyTexSubImage use getError directly so that the error is not propagated to the client. Bug: chromium:1458040 Change-Id: I3e4c06871c55d449facbe471c78e84f68b529f60 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4671325 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
Shahbaz Youssefi c0069e62 2023-07-05T21:53:34 Vulkan: Enable ANGLE_pack_reverse_row_order This allows testing the compute path implementation of PBO download for SNORM targets. Bug: b/286882707 Change-Id: I01393f8cad96bf8857a0dfb1638ff2c6366c28a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4668228 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Amirali Abdolrashidi b0e262fb 2023-07-10T11:33:53 Group Texture3DTestES2 skips on iOS GL Bug: angleproject:8213 Change-Id: Ib00bd8d28aa58a56012f2b46f4ac153481d1be38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4674080 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll db6b0357 2023-07-10T16:24:53 Manual roll Chromium from 8a1e61637248 to 749d653d9a36 (139 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/8a1e61637248..749d653d9a36 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,cnorthrop@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/11876f21fd..24349b4e60 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7d7df42f80 * third_party/turbine: 9rSngS4o9OIlNubLcU1zXF_w0dPYif6AS-_k1pPAV1kC..2I2Nz480QsuCxpQ1lMfbigX8l5HAhX3_ykWU4TKRGo4C No update to Clang. Bug: None Tbr: cnorthrop@google.com,ynovikov@google.com Change-Id: I7fd7532722aca9f5a7d7bdd42bf3a0ef92fe95f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675961 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 8b0e5413 2023-06-14T13:27:42 Metal: Put a limit on the total MTLLibrary objects cached Use an MRU for holding the cached libraries in mtl::LibraryCache. Using a maximum cache size of 128 and a GC size of 32 yields the same ratio of cache hits as before (40%) while cycling out the more unique shaders that are not re-used. Lowering the cache size to 64 or 96 yields a hit rate of 30-35%. Bug: chromium:1329376 Change-Id: I75dd6b20cf3f8b67c4b3c31da4e05e1857ad61db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4614362 Reviewed-by: Quyen Le <lehoangquyen@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 10194966 2023-07-10T13:56:13 Skip 2 flaky Perf tests on Win Intel Vulkan pubg_mobile_launch flaky timeout monster_hunter_stories flaky context lost Bug: angleproject:7929, angleproject:7557 Change-Id: I45d7b22bd3186419a584314c6c1f52ed0427ec8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4674342 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Yuly Novikov b2b1363a 2023-07-10T12:29:03 Skip Texture3DTestES2.DefineTexture2DArrayShouldFail on iOS GL Bug: angleproject:8213 Change-Id: I5487bd7b0a8033445d5552bb8d86dc3af80f1305 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4674340 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 5d3ca3ba 2023-07-10T07:01:37 Roll Chromium from 96802d0bdfdd to 8a1e61637248 (514 revisions) https://chromium.googlesource.com/chromium/src.git/+log/96802d0bdfdd..8a1e61637248 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6b59eb95c1..194f8687fe * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f11186bf34..1cc82962cb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b4958339ec..11876f21fd * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..7d7df42f80 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4303140531..247429efd9 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/f37f647574..7b20bcffe9 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/50358e9b66..eaa6ca74e2 No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: I28cf76358fda84b7e4df0cf18c344821adec4fbf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4674826 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 6ee402f6 2023-07-06T16:56:28 Clamp the max Framebuffer width and height to 16 bit GraphicsDriverUniforms struct packs framebuffer width and height into a 32 bit uint, meaning the maximum width and height supported are 16 bit each. We should make sure below values do not exceed the maximum value of a 16-bit uint: caps.maxFramebufferWidth caps.maxFramebufferHeight caps.maxRenderbufferSize so that the application won't try to create a FBO with width/height exceeding 16-bit. We have clamped the caps.max2DTextureSize to 32768, it makes sense to clamp the FBO width and height to the same value. Bug: b/286921997 Change-Id: Iae598b37215c58d1a0f6a50bba9f391d4d23d1f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4671327 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 3c814a34 2023-07-05T15:18:22 Include files declared in compiler.gni in shader program cache key We should invalidate the program cache when the files declared in compiler.gni changes. Add those files for shader cache key calculations. Bug: angleproject:4981 Bug: b/285871779 Change-Id: I9a8a65c1b02c4efcc6126d8b77017ddd8328e7a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4662395 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev b57d5638 2023-06-29T00:00:00 Reland "Cleanup multiview support" This is a reland of commit 9a7c0b88ba68e328d3f5f7991a6df0ab5de92311 Original change's description: > Cleanup multiview support > > * Removed remaining mentions of ANGLE_multiview > > * Removed AST transformations used only in > the side-by-side multiview implementation > > * Changed the type of the internal ViewID_OVR > variable to use the dedicated qualifier > > * Removed side-by-side multiview support > from the D3D11 renderer > > * Removed an unused helper for side-by-side > multiview support from the OpenGL renderer > > * Removed obsoleted test suppressions Fixed: angleproject:3341 Change-Id: I3ce9304c79c0873462c73e8cf02b85f7a1aaf874 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4669604 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Mohan Maiya 8b680c93 2023-07-07T09:24:44 Vulkan: Bug fix in GetAvailableValidationLayers(...) GetAvailableValidationLayers(...) had a bug where it did not account for a subset of kVkValidationLayerNames being available. Bug: angleproject:8247 Change-Id: Id7bc3570b2caf5550ca9d011a3ba9429702af8af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4673189 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Roman Lavrov 5997f1d7 2023-07-07T16:01:36 Fix little_cpu_power collection. Currently always getting 0, significantly undercounting cpu power at least in some cases (e.g. I saw 1700 vs 4300 in fishdom) Bug: b/284462263 Change-Id: Idd525f25cfc419a4a9d23a3fc99e938e99e1e715 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672592 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Charlie Lao 3cc3327c 2023-07-07T10:29:45 Vulkan: limit preferCPUForBufferSubData flag to mali job manager This feature flag was introduced with testing on pixel 6 pro with aliexpress trace. The GPU has a job manager does the scheduling and transfer workload was put in the same job queue as geometry work which causing unnecessary bubble in the pipeline. This problem does not exist on newer GPU architecture where it has a command stream front end that transfer has its own dedicated queue. As test result on pixel 7 devices indicates, this feature flag shows no difference on pixel 7with aliexpress trace, and has negative perf impact with gangstar_vegas trace. This CL limits the feature flag to ARM's job manager based GPU. This improves gangstar_vegas frame time from 8.4576ms to 4.6370ms on pixel 7 pro. Bug: b/289436017 Change-Id: I604fb1e26d0a99bcf8f4c2574ced360c31ac712d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4671326 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 04c0cc8d 2023-07-06T21:58:06 Simplify aliasing-exception logic in entry point generation Bug: angleproject:8224 Change-Id: Ic54c233ab3d8a0f9a1ac803804aea770c6f7cc07 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672145 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 51320fab 2023-07-06T16:01:58 Make most GLES1 entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: I80223340348d62a56109324ab3e4f935e53419b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4670407 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi eb205e68 2023-07-06T13:34:28 Make the glPatchParameteri entry point lockless This entry points only sets context-local state and thus doesn't require locking. Bug: angleproject:8224 Change-Id: I17975a97aa7f68c3ddf2ef78069b8f519fdc4c1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4670405 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Igor Nazarov <i.nazarov@samsung.com>
Shahbaz Youssefi 5869fb3b 2023-07-06T22:13:36 Remove big-GL files from normal builds of ANGLE Bug: angleproject:7533 Change-Id: I3616296d9923310200830a921190813e3ecfe80b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672146 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi 732a8f07 2023-07-05T17:03:46 Move max-shader-compile-threads state out of LocalState While this state is indeed context-local, setting it calls into the backend (GL backend specifically, where it forwards the call to the driver). The call to set this state is rare and now worth the risk associated with making it lockless. Bug: angleproject:8224 Change-Id: I3af395721fa18b9345698870c0da63e8cac83610 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4666355 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll f9b16593 2023-07-07T15:05:41 Manual roll Chromium from e506ce09bac4 to 96802d0bdfdd (1526 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/chromium/src.git/+log/e506ce09bac4..96802d0bdfdd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f87ccdf42a..6b59eb95c1 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6d00f8d8c5..f11186bf34 * buildtools/linux64: git_revision:da5fe01bce4ae84b2619caca7a3aa7ec7d3eb8a7..git_revision:1de45d1a11cc9f8cb5c75a031386151e1c384847 * buildtools/mac: git_revision:da5fe01bce4ae84b2619caca7a3aa7ec7d3eb8a7..git_revision:1de45d1a11cc9f8cb5c75a031386151e1c384847 * buildtools/win: git_revision:da5fe01bce4ae84b2619caca7a3aa7ec7d3eb8a7..git_revision:1de45d1a11cc9f8cb5c75a031386151e1c384847 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ac3cb62a5a..b4958339ec * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/b5862634ee..ae5ee2a38f * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/4cb10f1315..fa6fe66454 * third_party/android_build_tools/lint: DjoXGsdMeTwnppye9Nwe5ozhXIqKyJQDzgb0nTFH8SAC..z1zqFkwGcjud6JnSJ-81QiOYgD-OlvkQg5Fgt_gHwtoC * third_party/android_build_tools/manifest_merger: MN3CF2GQ8xeB6obj4qf5J6l15-NoA43u4__RQTTe8I4C..oD5bP72e45KzyT-yHx9yFfQcqpEfOUERdpMaR7rkTRcC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/36fd99b5ae..6514de5457 * third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/a72ec125fa..4b4eee2d24 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..451fa58bf6 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/872ac9bd3d..4303140531 * third_party/ijar: https://chromium.googlesource.com/chromium/src/third_party/ijar/+log/19617929c3..e2247b3708 * third_party/kotlin_stdlib: bhkmCcKzQ5IXUsDnWkRfouPfdzzyrgw40PUzRvArrGEC..Z1gsqhL967kFQecxKrRwXHbl-vwQjpv0l7PMUZ0EVO8C * third_party/markupsafe: https://chromium.googlesource.com/chromium/src/third_party/markupsafe/+log/13f4e8c9e2..006709ba3e * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/678d565421..c468546c25 * third_party/r8: vw5kLlW3-suSlCKSO9OQpFWpR8oDnvQ8k1RgKNUapQYC..FxcKKMhpNz8EQC9ZdDwB64ZzLm1VrWw21A_m20AOKaAC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/f999826d2d..7eff33bc00 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/39d4cc4ec8..f37f647574 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/75c7faf556..50358e9b66 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/33899440a1..21264809df * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/57b3b9e7c0..9a047fd494 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/159b3b88fd..4b4a958480 Clang version changed llvmorg-17-init-12166-g7586aeab:llvmorg-17-init-16420-g0c545a44 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/75c7faf55603c3ced48829d6f122e9719ff168e0..50358e9b66c22540954585c1b8df092d69eeb7f0/scripts/update.py Bug: None Tbr: ianelliott@google.com,ynovikov@google.com Change-Id: I6af984fb327e9b028cb3d48b89be73676192ba1c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672995 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 9cd1205f 2023-07-07T12:22:14 Skip street_fighter_iv_ce on SwiftShader keyframe=86, runs very slow on SwS: https://anglebug.com/8243#c1 Bug: angleproject:8243 Change-Id: Iae3c758ea6b6e6a2a68f91a1355c10bc9c92f432 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672588 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 44acab29 2023-07-07T12:02:51 Use latest build-tools from android_sdk (same as catapult) https://crsrc.org/c/third_party/catapult/devil/devil/android/sdk/build_tools.py;drc=8a3feaaaab63b383fb6b138be2986e9ad6dcaca2;l=61 Also do not fall back to just 'aapt' as that isn't hermetic. Bug: angleproject:7670 Change-Id: Ided9dfe16d6c6815c3425bdc64b2d572bbe564c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672808 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov da710ac3 2023-06-29T09:36:42 Stop rolling third_party/cpu_features It was probably needed for zlib previously but now zlib already depends on the ndk's cpufeatures. There are no references to third_party cpu_features in the generated Android.bp. Bug: b/289259681 Change-Id: Ib849b26391d0c23e533662094e74384c267c8620 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4656761 Reviewed-by: Solti Ho <solti@google.com> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Solti Ho <solti@google.com>
Anne Redulla 66c2e4fc 2023-07-04T17:02:07 [ssci] Added Shipped field to READMEs This CL adds the Shipped field (and may update the License File field) in Chromium READMEs. Changes were automatically created, so if you disagree with any of them (e.g. a package is used only for testing purposes and is not shipped), comment the suggested change and why. See the LSC doc at go/lsc-chrome-metadata. Bug: b/285450740 Change-Id: I770554248e33c1e50938cc32daee36a83b643ec9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672125 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 65ae56ba 2023-07-07T10:01:23 Roll vulkan-deps from c421d230f1c1 to 869b279baef4 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c421d230f1c1..869b279baef4 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f2f60da66f..db466666ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ifaa2d0b7d639fe0a5c9fa392c05b384f75e8b458 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4672746 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 7e0fb7e4 2023-07-05T17:20:23 Make glIsEnabled* entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: I6fe40bf4381e1d42248358f773ec9d5675883ada Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4666356 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 72c26926 2023-07-05T16:31:23 Make pack/unpack and hint entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: I5694d319df61a7a9df1766cf1f723b9a05208209 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4666352 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 208dfe28 2023-07-05T15:18:57 Make glStencil* entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: I612d8219ba038464173490b2c261e9e7b229c83f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661702 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c3c2f450 2023-07-05T14:52:10 Make glBlend* entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: Ie811c35ae7b65106db9af9f7531ad3a5e0bd4f8c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661701 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 44395930 2023-07-05T11:59:23 Make various state setting entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: I428c23cc862e9356d571bc085b5df0bf48017175 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661700 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 9daac2b7 2023-07-05T11:36:46 Make glEnable/Disable entry points lockless These entry points only set context-local state and thus don't require locking. Bug: angleproject:8224 Change-Id: Id4eab729115bd75f82e1ec7a27355c821a7c4320 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661697 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi fede75ff 2023-07-06T11:38:35 Fix multi-draw's gl_DrawID in non-multi-draw draws The uniform value for gl_DrawID was never reset, so if a program was first used with multi-draw and then without it, gl_DrawID would not contain zero. Test credit info-tibo@orange.fr Bug: angleproject:8245 Change-Id: I73a613ab2858cde4633fadf6a1a523e462167eb0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4662137 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Steven Noonan <steven@uplinklabs.net> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi 0892420b 2023-06-28T23:03:51 Vulkan: Optimize PBO download between RGBA and BGRA Google Meet hits this path in Chrome when blurring the background. The CPU readback was particularly slow on Intel/Mesa where readback from the temp buffer took hundreds of milliseconds. This change adds a compute shader that directly copies from the image to the pack buffer in simple but common cases. Bug: b/286882707 Change-Id: I9877ea01e3d8377db96f2539362aca67cf832b4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4657058 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu c934d86b 2023-06-28T16:29:10 Update dEQP-GLES mustpass List 1. Reordered gCaseListFiles. 2. Added below must pass list as they are required by the Khronos CTS: gles2-khr-noctx-master.txt gles32-khr-noctx-master.txt gles32-khr-single.txt 3. Added new test package to run the tests in these mustpass lists: angle_deqp_khr_noctx_gles2_tests angle_deqp_khr_noctx_gles32_tests angle_deqp_khr_single_gles32_tests Newly added tests will not be executed on bot yet. There will be follow-up CL to add these tests on bot. Bug: b/286921997 Change-Id: Ibc7dbf81dca67ad7be440d559f5b4ee0211c6c41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4654841 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi be41fe29 2023-07-04T15:35:46 Make glColor/DepthMask entry points lockless These entry points only set state that is entirely accessed by the owning context (context-local) and thus don't require locking. glColorMask* functions also affect the cached context state (in particular draw validity), so the relevant cached state is also modified to support being locklessly modified. Bug: angleproject:8224 Change-Id: I221b4efa25fc1c11419d1ac942f1c37e59ec92c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4658173 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi f0deadab 2023-07-06T15:19:03 Revert "Cleanup multiview support" This reverts commit 9a7c0b88ba68e328d3f5f7991a6df0ab5de92311. Reason for revert: Suspected cause of crash on Canary Original change's description: > Cleanup multiview support > > * Removed remaining mentions of ANGLE_multiview > > * Removed AST transformations used only in > the side-by-side multiview implementation > > * Changed the type of the internal ViewID_OVR > variable to use the dedicated qualifier > > * Removed side-by-side multiview support > from the D3D11 renderer > > * Removed an unused helper for side-by-side > multiview support from the OpenGL renderer > > * Removed obsoleted test suppressions > > Fixed: angleproject:3341 > Change-Id: I5e0706cbf26ea820b51400124ddbf2624b738f17 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4660046 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Bug: chromium:1462504 Bug: chromium:1462505 Bug: chromium:1462506 Bug: chromium:1462478 Bug: chromium:1462531 Change-Id: Ie0e76b1c6823db19f68bb67fdfc8abc00cc62f88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4666209 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 25f3eafc 2023-07-06T10:01:13 Roll vulkan-deps from df22aa218f6a to c421d230f1c1 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/df22aa218f6a..c421d230f1c1 Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/3469b164e2..d0006a3938 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/ad5f8ee975..179b26a792 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2221fe60db..f2f60da66f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Iefa982f31e88febe619c1d3147d978aa56f03ccf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4668616 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott d2d44dda 2023-07-05T17:29:57 Mac: Suppress flaky/crashing test Bug: angleproject:8091 Bug: angleproject:8244 Change-Id: I5825d6268ec0f5b6e31dabad6ecb6bfff1a48677 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4667811 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Sunny Sachanandani 2a5c05df 2023-07-05T14:24:54 gl: Handle copyTexSubImage2D failures manually https://chromium-review.googlesource.com/c/angle/angle/+/4662093 was a previous attempt at graceful fallback from copyTexSubImage2D, but the approach in that CL doesn't quite work since it produces an error when returning from the function which makes the caller also propagate the error instead of falling back to blit via shader. This CL makes it so that we handle the error manually and return an angle::result::Continue with *copySucceededOut=false to indicate to the caller that it should try a fallback. Bug: chromium:1458040 Change-Id: I3cd66dcaa6069d5527c3e73190d72ffbba98ae4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4662393 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 67994c6f 2023-07-05T16:18:44 Workaround app bug with using ESSL 100 extension in ESSL 310 An app has been found that uses GL_OES_EGL_image_external and GL_OES_texture_3D which are ESSL-100-only extensions in an ESSL 310 shader. Workaround this app bug by allowing these extensions to be used in all versions. Bug: b/285871779 Change-Id: I82262fc407db48d1fdd66967681c8102029cd0b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4666351 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop ec8fb51b 2023-07-03T11:44:26 Tests: Add Evony: The King's Return trace Test: angle_trace_tests --gtest_filter="*evony_the_kings_return*" Bug: b/266237531 Bug: b/275096133 Change-Id: I32daa8b1bd4f3253887d02a5127ef4682df4951a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4664602 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Kenneth Russell 9d9ca90b 2023-06-30T15:31:03 Properly validate _ADJACENCY primitive modes. After a refactoring in Issue angleproject:5483 and Issue chromium:1185267, the _ADJACENCY primitive modes were being validated as legal in context versions where they were not supported. Thanks to lehoangquyen@ for an initial version of this CL and one of the two new tests. Verified locally on an ASAN build on macOS (by manually disabling SwiftShader, where ASAN does not work) that the new tests pass cleanly. Test: SimpleOperationTest.PrimitiveModeLinesAdjacentNegativeTest Test: SimpleOperationTest.DrawsWithNoAttributeData Bug: chromium:1457840 Change-Id: Icb0945e0081ca6f97355dc60f75d60c3f4f68565 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661672 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 4db13081 2023-07-04T14:40:31 Make glClearColor/Depth/Stencil entry points lockless These entry points only set state that is entirely accessed by the owning context and thus don't require locking. Bug: angleproject:8224 Change-Id: I6cddee865ffd38e228f8f87dd14adffb916e0fed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4658172 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 8a8c8fc2 2023-07-05T13:19:25 Roll chromium_revision ad19957265..e506ce09ba (1165395:1165897) Change log: https://chromium.googlesource.com/chromium/src/+log/ad19957265..e506ce09ba Full diff: https://chromium.googlesource.com/chromium/src/+/ad19957265..e506ce09ba Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e0690c7c78..f87ccdf42a * buildtools/linux64: git_revision:4bd1a77e67958fb7f6739bd4542641646f264e5d..git_revision:da5fe01bce4ae84b2619caca7a3aa7ec7d3eb8a7 * buildtools/mac: git_revision:4bd1a77e67958fb7f6739bd4542641646f264e5d..git_revision:da5fe01bce4ae84b2619caca7a3aa7ec7d3eb8a7 * buildtools/win: git_revision:4bd1a77e67958fb7f6739bd4542641646f264e5d..git_revision:da5fe01bce4ae84b2619caca7a3aa7ec7d3eb8a7 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/7d4c4bf473..b5862634ee * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/f5874af13b..ea2e39562f * third_party/android_sdk/public: -VRKr36Uw8L_iFqqo9nevIBgNMggND5iWxjidyjnCgsC..YK9Rzw3fDzMHVzatNN6VlyoD_81amLZpN1AbmkdOd6AC * third_party/android_sdk/public: RSI3iwryh7URLGRgJHsCvUxj092woTPnKt4pwFcJ6L8C..HWVsGs2HCKgSVv41FsOcsfJbNcB0UFiNrF6Tc4yRArYC * third_party/android_sdk/public: eo5KvW6UVor92LwZai8Zulc624BQZoCu-yn7wa1z_YcC..u-bhWbTME6u-DjypTgr3ZikCyeAeU6txkR9ET6Uudc8C * third_party/android_system_sdk: RGY8Vyf8jjszRIJRFxZj7beXSUEHTQM90MtYejUvdMgC..4QeolYaSKWBtVTgzJU4tHUfzA9OJTDM8YUcD426IctwC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..48b31edbfc * third_party/jdk: 2Of9Pe_OdO4xoAATuiLDiMVNebKTNO3WrwJGqil4RosC..-1zDGMOzS_Qsja50TakJCSqN9C9TYppQrsny4HATSQwC * third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/264c07d7e6..515dd10de9 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/36a80749cf..75c7faf556 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/422351564c..159b3b88fd DEPS diff: https://chromium.googlesource.com/chromium/src/+/ad19957265..e506ce09ba/DEPS No update to Clang. BUG=None Change-Id: I4b8366a4585826221f2843682088ac100dd44f2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661021 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
angle-autoroll 82d73bd3 2023-07-05T10:01:05 Roll SwiftShader from 222e07b368b1 to 3e73cce1c470 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/222e07b368b1..3e73cce1c470 2023-07-04 jif@google.com [LLVM 16] Shifts do not generate poison values If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ic45b57e18351792befb4bfc03b2d624dc195c376 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4666691 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 461fb932 2023-07-05T10:01:01 Roll vulkan-deps from 347306080b87 to df22aa218f6a (1 revision) https://chromium.googlesource.com/vulkan-deps.git/+log/347306080b87..df22aa218f6a Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4400858043..2221fe60db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I6cfb1597d0ec286e43825a19baa4c233575561cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4666764 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b41c42f4 2023-07-04T18:57:22 Manual roll vulkan-deps from e21365bc9170 to 347306080b87 (3 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/e21365bc9170..347306080b87 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/58459c2b1a..870fd1e17a * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/dce85674e2..9d38cccf33 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/2e5260d44c..39090f9152 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com,ynovikov@google.com Change-Id: Idd54e19b1837ac34f213338fab68d553446c6104 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4664873 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll cb5cd76d 2023-07-03T15:54:58 Manual roll vulkan-deps from 2b2cba62bfea to e21365bc9170 (38 revisions) Manual roll requested by ynovikov@google.com Suppress new VUIDs: "VUID-vkCmdDrawIndexed-None-08608", "VUID-vkCmdDraw-None-08753", "VUID-vkCmdDrawIndexed-None-08753", https://chromium.googlesource.com/vulkan-deps.git/+log/2b2cba62bfea..e21365bc9170 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/9575e33186..3ebb72cc74 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/2d3a152081..b8e742c91b * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/310a67020a..58459c2b1a * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/b6a29e5ca8..ad5f8ee975 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a1d9d485ce..dce85674e2 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/247c806c93..2e5260d44c * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/926ffb1f41..4400858043 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:8242 Change-Id: I475146b418565e633043f6b57cb07baedcff02ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4662877 Commit-Queue: Ian Elliott <ianelliott@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
Yuly Novikov c67d97ba 2023-07-04T15:11:14 Expand dEQP-EGL suppression dEQP-EGL.functional.robustness.reset_context.shaders.out_of_bounds_non_robust.reset_status.writes.* fail also on SwiftShader Windows. Bug: chromium:1462139, b/286921997 Change-Id: If20b217ba47f3c3cc0da7a17478424798b406408 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4664801 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 55279449 2023-07-03T19:42:52 Roll chromium_revision 2e0371f07e..ad19957265 (1162850:1165395) Don't update testing beyond https://chromium.googlesource.com/chromium/src/testing/+/8e38c8e8a6b4251a2f9584d9d9bfbf261d0c1835 Remove $mixin_append usage due to https://chromium.googlesource.com/chromium/src/testing/+/a5415f3c674a065cc541c618df12262073d4d10e Change log: https://chromium.googlesource.com/chromium/src/+log/2e0371f07e..ad19957265 Full diff: https://chromium.googlesource.com/chromium/src/+/2e0371f07e..ad19957265 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e4262406c0..e0690c7c78 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f089c59d7c..6d00f8d8c5 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/b272a1c128..84fb809dd6 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/b5a43ecdac..f1c687e0aa * testing: https://chromium.googlesource.com/chromium/src/testing/+log/46c0754180..ac3cb62a5a * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/66a5ea107e..7d4c4bf473 * third_party/android_build_tools/lint: kqQgSDAgfuKTUIT8gpYlhM9gvajbtIDs_ApDbh3wdNIC..DjoXGsdMeTwnppye9Nwe5ozhXIqKyJQDzgb0nTFH8SAC * third_party/android_build_tools/manifest_merger: pRHDE8UAgipcDQINCUsRz94lgm5BHQjiL-BLF6d6xC4C..MN3CF2GQ8xeB6obj4qf5J6l15-NoA43u4__RQTTe8I4C * third_party/android_toolchain: version:2@r25c.cr1..R_8suM8m0oHbZ1awdxGXvKEFpAOETscbfZxkkMthyk8C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..48b31edbfc * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f0fba1d307..872ac9bd3d * third_party/fuchsia-sdk/sdk: version:13.20230626.3.1..version:13.20230629.2.1 * third_party/turbine: G8Cku1fztaDd9to_8gk3PNWM2iRacAxD9zcUAgUPUEAC..9rSngS4o9OIlNubLcU1zXF_w0dPYif6AS-_k1pPAV1kC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/f81f385906..f999826d2d * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/5c2008090e..39d4cc4ec8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/053092c268..36a80749cf * tools/luci-go: git_revision:39f255d5875293d3e1d978888b819ac124a8b0cc..git_revision:15be1e7f953cb4ef6d88aba86f57ca28724d1c9a * tools/luci-go: git_revision:39f255d5875293d3e1d978888b819ac124a8b0cc..git_revision:15be1e7f953cb4ef6d88aba86f57ca28724d1c9a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f80577ef22..33899440a1 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/daed2f7981..422351564c * tools/skia_goldctl/linux: tVDltUu_xw7_tk4k-rnp7Ua8pKhf3EEHmTwX5c6BS4AC..209WoWuXITgke_BJDnvM7aTy7wu2jFOUPYs4uIoJ3CAC * tools/skia_goldctl/mac_amd64: ov_DuOSHCneWQSTW6AZ9gWHEeoJxXEYDX9dl_0rA_d0C..vEHTSSZiGWhNdCjMGZ22sj4PfyPzgoIIkV97YXOJeKEC * tools/skia_goldctl/mac_arm64: 3wDkZAVD4vV1dNhXfRNMOUBvODbzJ23AVmmsFbTsbkQC..CcHM6-LZ7_b-Api718RTCYQPD0v17lWKuQBaz42b8r4C * tools/skia_goldctl/win: yW7os_HVMoE-wq04olb6B7GNgEmaYZYPN0ecTzPPBdkC..u5j7yik1xZdFc9dECFfFDX9vRP9go2GpqukfJwOLCbgC DEPS diff: https://chromium.googlesource.com/chromium/src/+/2e0371f07e..ad19957265/DEPS No update to Clang. Bug: chromium:1456553 Change-Id: I1c18e6c6f68c7d24ae72a6754c707397a4c739d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4660052 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Alexey Knyazev 9a7c0b88 2023-06-29T00:00:00 Cleanup multiview support * Removed remaining mentions of ANGLE_multiview * Removed AST transformations used only in the side-by-side multiview implementation * Changed the type of the internal ViewID_OVR variable to use the dedicated qualifier * Removed side-by-side multiview support from the D3D11 renderer * Removed an unused helper for side-by-side multiview support from the OpenGL renderer * Removed obsoleted test suppressions Fixed: angleproject:3341 Change-Id: I5e0706cbf26ea820b51400124ddbf2624b738f17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4660046 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Mohan Maiya 75813905 2023-06-30T08:47:29 Update ANGLEExtensionAvailability test expectation ANGLEExtensionAvailability test should allow vendors that support VK_EXT_image_2d_view_of_3d Vulkan extension to expose EGL_KHR_gl_texture_3D_image extension string with the Vulkan backend. Bug: angleproject:7320 Test: ImageTest.ANGLEExtensionAvailability* Change-Id: I3f6d407e100827604124e312bb61a59dbfb50dac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4658874 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Sunny Sachanandani e70b9b4f 2023-06-26T14:03:54 gl: Use ANGLE_GL_TRY_ALWAYS_CHECK for CopyTexSubImage CopyTexSubImage fails with certain formats on Pixel 2 & 4 with a driver error. TextureGL::copySubTextureHelper has a fallback path to handle errors, but it gets skipped because BlitGL::copyTexSubImage uses ANGLE_GL_TRY which doesn't check for GL errors in release builds. This CL fixes that by using ANGLE_GL_TRY_ALWAYS_CHECK instead which is anyway intended for any GL call that might allocate memory behind the scenes. Bug: chromium:1458040 Change-Id: If660f3ef9968338d4ecf7fa20ab481aad84ed981 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4662093 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Ian Elliott db3537aa 2023-07-03T15:56:42 Vulkan: Suppress VVL "VUID-vkCmdDraw-None-08608" Bug: angleproject:8242 Change-Id: Ia446cfc370ad6ade4967644416dee9e18aaaa0d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4664612 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll bcfc214f 2023-06-27T09:49:12 Roll Chromium from 14fa1a826dad to 2e0371f07e01 (1224 revisions) Manually update third_party/flatbuffers https://chromium.googlesource.com/chromium/src.git/+log/14fa1a826dad..2e0371f07e01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4438010153..e4262406c0 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ad9b993f2f..f089c59d7c * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/745104ff4a..b272a1c128 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/75c78f8f64..46c0754180 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8f8f07bdce..66a5ea107e * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/3b0115d9f8..4cb10f1315 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1a0894f20f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/98d3bb27f0..f0fba1d307 * third_party/flatbuffers/src: https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/13fc75cb6b..28861d1d7d * third_party/fuchsia-sdk/sdk: version:13.20230622.3.1..version:13.20230626.3.1 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/9b4ea9e0d4..5c2008090e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ff9b9e9ce2..053092c268 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/31a576a999..daed2f7981 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I7bf9a5c427845ac28e9cc70051c9b07381313cc9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4649047 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 0e8a8e0f 2023-07-03T16:00:35 Roll VK-GL-CTS from 12bc45af35d5 to e7b180ad5366 (12 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/12bc45af35d5..e7b180ad5366 2023-07-03 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.6 into vk-gl-cts/main 2023-06-30 lorenzo@khronosgroup.org Merge "Merge remote-tracking branch 'vk-gl-cts/vulkansc-cts-1.0.1'" into main 2023-06-30 aitor@lunarg.com Add EGL_ANDROID_RECORDABLE to config testing 2023-06-30 rgarcia@igalia.com Add GPL variants to fragment shader barycentric tests 2023-06-30 rgarcia@igalia.com Test tessellation state switches 2023-06-30 cturner@igalia.com Vk Video: Upgrade the NVIDIA parser interface to version 0.9.9 2023-06-30 paulthomson@google.com Skip dEQP-VK.api.info.android.* if not Android 2023-06-30 scerveau@igalia.com cts: add deviceName to SessionInfo 2023-06-30 rgarcia@igalia.com Test maxSamplerLodBias 2023-06-30 cturner@igalia.com Update handling of field flags for improved compatibility. 2023-06-26 gleese@broadcom.com Switch float controls tests from deBool to C++ bool 2023-06-26 gleese@broadcom.com Remove duplicate direct linking options If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I55e947c71f921d7ef55ffb5f2b61b0a19f304170 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4662878 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 574d163f 2023-07-03T14:36:59 Manual roll vulkan-deps from 23a32754e715 to 2b2cba62bfea (29 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/23a32754e715..2b2cba62bfea Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/10db9d4e19..3469b164e2 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/54691dcd73..310a67020a * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/c1a8560c5c..b6a29e5ca8 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/b02d69f3a1..a1d9d485ce * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/07924a8a49..247c806c93 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/cb9c77d609..926ffb1f41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ianelliott@google.com,ynovikov@google.com Change-Id: I4b5e433bdd24644f6e502f10f21974b670b2a0b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4662876 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Igor Nazarov 25ce3dfe 2023-06-29T15:51:55 Use compare_exchange_weak() in AllocateGlobalMutexImpl() Speculative fix of the crash. New logic will ensure that `currentMutex` is not `nullptr` when returned from `AllocateGlobalMutexImpl()` Also removed explicit memory order for safety (no actual difference in generated code on ARM64/x86-64, but ARM generates less instructions). Bug: chromium:1457915 Change-Id: I8d932ee499f9d8ee4e38ab2173f4f1cefd0aa294 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4650794 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 20cc4a9b 2023-06-26T00:00:00 D3D11: Fix non-trivial blits for snorm buffers Bug: angleproject:8048 Change-Id: Ifec7ea71e0ab88f545ae088b0faae4b95512a207 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4654315 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Charlie Lao 16657963 2023-06-28T09:42:52 Vulkan: Improve SyncVk::serverWait If sync object has already finished, there is no need to insert pipeline barrier. With this CL, asphalt_9 average frame time reduces from 5.464 ms to 5.268 ms (-3.58%), making it 85% of native GLES (4.49 ms) on pixel 7 pro. Bug: b/277644512 Change-Id: I112ccef0619da3c05cba44066327edc0bb81c366 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4651599 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi ccf8530b 2023-06-27T16:01:58 Split context state by locality of get/set effect Some state are purely local to the context when get or set. For example, the state of depth test does not affect and is not affected by any other state. Some state on the other hand may affect other contexts. In particular, some objects are shared between contexts of a share group, and may affect each other through the observer interface. These sets of state are separated to create a clear boundary between state that can and cannot be accessed without holding the share group lock. A follow up change removes locking from the entry points that purely access the former set of states. For the latter state, it is likely possible to access most if not all of them without holding a lock, but careful inspection is required before that can be considered. In particular, most entry points that simply bind an object are likely harmless if the ref counter is turned atomic. Bug: angleproject:8224 Change-Id: I91c3fa9de870c13d48012a5e06c177dab4010907 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4651375 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 5f581f87 2023-06-27T20:38:03 Pass dirty bits by value Split CL from follow up change where the dirty bits need to be passed by value as they are calculated from two sets. Many cached dirty bits are turned to constexpr as a result. Bug: angleproject:8224 Change-Id: Ibdb3090d6ee93788e1502b72bce55f4677937c58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4650074 Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Alexey Knyazev 0e7c79e3 2023-06-29T00:00:00 Vulkan: Fix resolve with multiple targets of different formats Ensure that the appropriate code path is taken when resolving into multiple target buffers of different formats. Bug: chromium:1123524 Change-Id: Ic25a52ba069a2209c907226613fde1109823c094 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4650561 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 2b56dc3e 2023-06-29T10:01:31 Roll SwiftShader from 47b5898a4fa7 to 222e07b368b1 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/47b5898a4fa7..222e07b368b1 2023-06-28 bclayton@google.com Update Marl to aa9e85b21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Icc991a00ec7ee708bf0daf3a4ab81f4da5b8e009 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4656618 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 77c4b677 2023-06-28T08:23:23 Vulkan: Suppress PointSize VVL error Bug: angleproject:8237 Bug: angleproject:2796 Bug: b/288961771 Change-Id: I7e4b364225c61fd72091e9d84d45eb71a02a5597 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4653398 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Cody Northrop <cnorthrop@google.com>
angle-autoroll 0c1b3609 2023-06-28T10:01:19 Roll SwiftShader from afd97bf1e914 to 47b5898a4fa7 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/afd97bf1e914..47b5898a4fa7 2023-06-27 bclayton@google.com Update Marl to 13e0eb522 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ib379bbed87b4975e35ffdb1db7604be155dd8937 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4654431 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
L. E. Segovia ed391dae 2022-03-25T16:36:39 Replace `extern thread_local` to avoid GCC < 9.1 bug GCC generates broken code for mingw-w64 target when accessing `extern thread_local` variables from another compilation unit. See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104862 See: https://invent.kde.org/graphics/krita/-/blob/master/3rdparty/ext_googleangle/02-patches_krita/0017-Replace-extern-thread_local-to-avoid-GCC-mingw-w64-b.patch Co-authored-by: Alvin Wong <alvinhochun@gmail.com> Bug: None Change-Id: Ief0036054e644d40b8b0e86ed990280e566da2a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4637587 Auto-Submit: L. E. Segovia <amy@amyspark.me> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Steven Noonan f150cf10 2023-06-23T02:56:09 Vulkan: minor pipeline cache chunk key hash bugfix The hash key was not correctly streaming the chunk index into the key string -- "chunkIndex" here is a uint8_t, which the ostream incorrectly identified as a character rather than byte. So the "std::hex" modifier didn't have any effect and chunkIndex 0 had a truncated key. Bug: angleproject:8231 Change-Id: Icb4977b658214979e08f66fcb98217259d4799ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4639493 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Steven Noonan 113f847b 2023-06-26T12:07:52 centralize basic OS/platform detection functions We had multiple different places that defined these, and with varying naming schemes. Centralize them to be defined in platform_helpers.h. Also renaming the IsApple(uint32_t) functions to IsAppleGPU(uint32_t) to avoid ambiguous meaning: "IsApple" should mean "is Apple-vended OS" while "IsAppleGPU" should mean "is Apple GPU vendor ID". Bug: angleproject:8229 Change-Id: If4e3fc5ac1b5b8ad416663950a1b2ee912ccad99 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4647291 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Steven Noonan <steven@uplinklabs.net> Auto-Submit: Steven Noonan <steven@uplinklabs.net> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0