|
b2ff69f8
|
2020-10-09T08:54:00
|
|
Suppress Mac/GL test failures with standalone runner.
These tests fail when run in certain orders with display reusei
on the bots. See issues for list of suppressed tests.
Bug: angleproject:5154
Bug: angleproject:5153
Change-Id: I1b4a523ba000785f4f8c26eeb236c518481ed7af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462715
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
c759206c
|
2020-10-07T12:02:14
|
|
fix an instance of bugprone-unused-return-value
This new clang-tidy check fires when the result of a function like
`unique_ptr.release()` is unused. Sometimes this is intentional, other
times, it's not (e.g., the dev intended to `.reset()`).
Bug: chromium:1134714
Change-Id: I9b6bc9e847e5c27d68707a4f33d37b225ded34fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2458188
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
5291cbad
|
2020-10-09T10:01:58
|
|
Roll SPIRV-Tools from fc8264854c53 to c2553a315f5c (5 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fc8264854c53..c2553a315f5c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: If001c4eb01adfdc349719f9aab8bb77722a1d123
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463245
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
1cf632e0
|
2020-10-09T10:01:50
|
|
Roll SwiftShader from 952149303d06 to 51b03d58fb17 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/952149303d06..51b03d58fb17
2020-10-09 bclayton@google.com SpirvShaderDebugger: Fix store() of arrays
2020-10-09 bclayton@google.com SpirvShaderDebugger: Improve ASSERT() messages
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I58214fff9f6b91f592033e07e50aa40a6afe9a83
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463244
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
500eeff4
|
2020-10-09T10:01:45
|
|
Roll Vulkan-ValidationLayers from 24184fe81c6f to 0046c31f2f96 (2 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/24184fe81c6f..0046c31f2f96
2020-10-08 nathaniel@lunarg.com layers: Fix ImageView format compatibility error
2020-10-07 shannon@lunarg.com build: Update known-good files for 1.2.156 header
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: Ieec1da74d36bd07a4c1eaa114e44986a5e4de10b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463243
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
f30ae360
|
2020-10-09T10:01:30
|
|
Roll Vulkan-Loader from dc8a96d60b6b to 14ad927e679a (2 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/dc8a96d60b6b..14ad927e679a
2020-10-08 dorian.apanel@gmail.com Handling also zero size override paths.
2020-10-08 dorian.apanel@gmail.com loader: Override layer load when custom allocator used.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: Ib7634589744013e845ae600dffa3fe6f853a3f32
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463242
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
fc8f5e0a
|
2020-10-09T07:00:12
|
|
Roll Chromium from 090102a7065c to 77bfcdcde874 (466 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/090102a7065c..77bfcdcde874
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/d058068a4b..f12b0ac8bf
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/17295a5c35..26fd14f32d
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7054864146..ed409570c0
No update to Clang.
Bug: None
Tbr: timvp@google.com
Change-Id: Ib54c76f7997a6cac606d68532fd67cd98ad7a59c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462165
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
e0780931
|
2020-10-08T17:57:47
|
|
Suppress gl_test failures on Mac ARM64 (Apple DTK)
BuiltinVariableFragDepthClampingFloatRBOTest.Below1/ES3_OpenGL
CopyTexImageTest.DeleteAfterCopyingToTextures/ES2_OpenGL
GLSLTest.MaxVaryingVec2Arrays/ES2_Metal
GLSLTest.MaxVaryingVec3ArrayAndOneFloatArray/ES2_Metal
GLSLTest.MoreNestedCompoundStructsWithSamplersAsFunctionArg/ES2_OpenGL
GLSLTest.NestedCompoundStructsWithSamplersAsFunctionArg/ES2_OpenGL
GLSLTest.NestedStructsWithSamplersAsFunctionArg/ES2_OpenGL
GLSLTest.NestedStructsWithSamplersAsFunctionArg/ES3_OpenGL
MipmapTestES3.BaseLevelTextureBug/ES3_OpenGL
MipmapTestES3.GenerateMipmapBaseLevel/ES3_OpenGL
MipmapTestES3.GenerateMipmapCubeBaseLevel/ES3_OpenGL
MipmapTestES3.GenerateMipmapMaxLevel/ES3_OpenGL
MipmapTestES3.GenerateMipmapPreservesOutOfRangeMips/ES3_OpenGL
OcclusionQueriesTest.MultiQueries/ES2_Metal
Texture2DBaseMaxTestES3.GenerateMipmapAfterRedefineAndRebase/ES3_OpenGL
Texture2DFloatTestES2.TextureFloatLinearLegacyTest/ES2_Metal
Texture2DFloatTestES2.TextureFloatLinearLegacyTest/ES2_OpenGL
Texture2DFloatTestES2.TextureFloatLinearTest/ES2_Metal
Texture2DFloatTestES2.TextureFloatLinearTest/ES2_OpenGL
Texture2DFloatTestES3.TextureFloatLinearLegacyTest/ES3_OpenGL
Texture2DFloatTestES3.TextureFloatLinearTest/ES3_OpenGL
TimerQueriesTest.TimeElapsed/ES3_OpenGL
TimerQueriesTest.TimeElapsedMulticontextTest/ES3_OpenGL
WebGLCompatibilityTest.TextureCopyingFeedbackLoops/ES2_OpenGL
WebGLCompatibilityTest.TextureCopyingFeedbackLoops/ES3_OpenGL
Bug: chromium:1132295
Change-Id: If64dc67275063c8046dbc941d92de273fbc226e5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461674
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
cd8eb564
|
2020-10-08T09:59:10
|
|
GL: Work around Mac glBindBufferRange issue.
Mac GL drivers generat errors when binding transform feedback buffers
with glBindBufferBase/glBindBufferRange when the buffer has not been
bound to any binding point before. Work around this by simply binding
the buffer first.
Bug: angleproject:5140
Change-Id: I1895f8367412135c100a5072117c929be8a8e90b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461826
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
36f0464a
|
2020-10-08T14:45:51
|
|
Target the "absl" component for component builds.
When performing a component build, we need to make sure our targets are
accessing abseil from the component when is_component_build=true.
Bug: chromium:1134776
Change-Id: Iaf5ee7176b4b8d84b3bafeaa259e476062a1e1dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461454
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
f8117992
|
2020-10-08T14:53:53
|
|
Suppress TransformFeedbackTest.RecordAndDrawWithScissorTest
TransformFeedbackTest.RecordAndDrawWithScissorTest is flaky on
"Mac Pro FYI Release (AMD)", so suppressing for now.
Bug: chromium:1135841
Test: TransformFeedbackTest.RecordAndDrawWithScissorTest
Change-Id: If610d7868950d1e2663c52b5194f6065a5900525
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461455
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
57f86257
|
2020-10-08T12:38:50
|
|
Support RGB -> BGRX copies in copySubImage.
This was showing up in the following test for me on OSX:
IOSurfaceClientBufferTest.CopySubImageToBGRX8888IOSurface/ES2_Vulkan_SwiftShader
Test: angle_end2end_tests on OSX 10.15
Bug: angleproject:5147
Change-Id: I666dc832e8be33cde1617c849990c6092f4e2240
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462041
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
4dae43d8
|
2020-10-08T11:04:50
|
|
Vulkan: Disable vkCreateDevice-physical-device-features-not-retrieved
Disable
UNASSIGNED-BestPractices-vkCreateDevice-physical-device-features-not-retrieved
while the Khronos issue is investigated.
Bug: angleproject:5149
Change-Id: I680cf264d6356cf219826902d7fdf2304e27ebab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461475
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
a5db7d6e
|
2020-10-08T11:01:46
|
|
Vulkan: Disable UNASSIGNED-CoreValidation-DevLimit-MissingQueryCount
Disable UNASSIGNED-CoreValidation-DevLimit-MissingQueryCount while the
Khronos issue is investigated.
Bug: angleproject:5148
Change-Id: If3cd4b028182a06411b928417e7c778ea02189d1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462075
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
a2491911
|
2020-10-07T13:56:37
|
|
Document how to revert/reland a CL
Bug: angleproject:5141
Change-Id: I9a0a2ae18dc298250f8fc6fba2eb0042a31dc369
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2458846
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
887b1346
|
2020-10-02T01:12:01
|
|
Vulkan: Add resolve/unresolve counters
With this change, render-pass-related counters are calculated at render
pass creation time and stored alongside the render pass handle (and
serial) in the render pass cache. On every use, the render pass'
counters are accumulated over the global counters.
Additionally, this change adds MSRTT resolve and unresolve counters to
render pass counters.
Bug: angleproject:4836
Change-Id: If15a789e5a7d66c7ea5a2315bc76fe045ce57491
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444099
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
102074d1
|
2020-10-06T17:13:16
|
|
Pass in Command::Clear to framebuffer syncState
In preparation for some clear-related optimizations.
Bug: angleproject:4836
Change-Id: I32ceb2b8a690ed13dac81e1ffe073436d6e24421
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2453464
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
6dfd855a
|
2020-03-25T03:02:08
|
|
Metal: Implement fence sync
Bug: angleproject:2634
Change-Id: If1f7bb12c0e661c8e4b5677798a92440995819e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2433325
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
0c046aff
|
2020-10-08T10:01:45
|
|
Roll Vulkan-ValidationLayers from e171d8431cfa to 24184fe81c6f (3 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e171d8431cfa..24184fe81c6f
2020-10-07 nathaniel@lunarg.com refactor: Move CALL_STATE into best_practices
2020-10-07 mark@lunarg.com readme: Update contact info
2020-10-07 lionel.g.landwerlin@intel.com tests: Keep QueryPerfIncompletePasses from triggering VU00817
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I3e13c7764bb430c93f48a97a7395d5f2f3f27f68
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461388
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
a8bb3df7
|
2020-10-08T10:01:41
|
|
Roll glslang from bacaef3237c5 to 2067d1a93e6e (8 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/bacaef3237c5..2067d1a93e6e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I95e50c1daf8e032cdd70dfe9126c8d58d82ac610
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461387
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
5f00d6bc
|
2020-10-08T10:01:30
|
|
Roll Vulkan-Loader from a638f3acae94 to dc8a96d60b6b (2 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a638f3acae94..dc8a96d60b6b
2020-10-07 pdaniell@nvidia.com Fix formatting issue.
2020-10-07 pdaniell@nvidia.com Fix some issues when EnumerateAdapterPhysicalDevices is available
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: Ief8353ba32e633b83f4135bd5dc2d00bb6349e13
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461406
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
cfd451ed
|
2020-10-08T10:02:14
|
|
Roll SwiftShader from 635de036d766 to 952149303d06 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/635de036d766..952149303d06
2020-10-08 bclayton@google.com SpirvShaderDebugger: Have Function inherit LexicalBlock
2020-10-07 capn@google.com Remove float division-by-zero prevention
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I46e38b5ec92086f750ce42ae4423fcf8e19700c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461407
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
6a09a9d4
|
2020-10-08T07:01:07
|
|
Roll Chromium from a5a8696e5087 to 090102a7065c (466 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/a5a8696e5087..090102a7065c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/854fdb73c8..d058068a4b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/0fa2c0deee..17295a5c35
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/54a9cb2f54..c89bad5e6d
* tools/luci-go: git_revision:83c3df996b224edf5061840744395707a0e513e7..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
* tools/luci-go: git_revision:83c3df996b224edf5061840744395707a0e513e7..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
* tools/luci-go: git_revision:83c3df996b224edf5061840744395707a0e513e7..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/cc0ee19df9..7054864146
* tools/skia_goldctl/linux: dMvix4BkhDJmKBK1tudaxlOMub1Dif3ZPcqzSY72-ZAC..ehm_yIO4CdwsvaJZJPQ2xBXAFv3KXEgrDpTY3AaK7EYC
* tools/skia_goldctl/mac: xJncEfNMb0HaDG9EglMx2YNbKAxqk6qJbckhfn0BXb8C..wIHfWG-DQOw0ISbpkWZrm2f2GoKa3H1Z4I2w8MxhlVIC
* tools/skia_goldctl/win: cLgS219WFD65Hr6NfoCQYA5KEE2FfO3FBl30KYhpTFoC..ixP2POw1dVLvzG-YPiGAJdFrTLwpr--nwyQr_S5FoRkC
No update to Clang.
Bug: angleproject:5038,angleproject:5124
Tbr: timvp@google.com
Change-Id: Ic1b5300ae727a297ac0628c46d37c994eeb6c6fc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2458792
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
1a87f1f0
|
2020-10-06T17:15:34
|
|
Add a test for deferred clears and 0-sized scissor clears
The Vulkan backend no-ops such clears before flushing deferred clears.
Deferred clears are actually not gathered when doing a scissored clear,
so this is not an issue. An ASSERT is added along with a regression
test.
Bug: angleproject:4836
Change-Id: I5ea5bab499ced41e13023ffb6b821e3caefb9ab2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2453466
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
36ccb695
|
2020-10-07T14:43:01
|
|
Ensure a CGL context is current for WindowSurfaceCGL.
WindowSurfaceCGL does quite a bit of emulation using GL textures and
renderbuffers but some of these operations need to happen during EGL
functions when there may be no native context current.
Add a helper that ensures a context is current for operations that
manipulate GL objects.
Bug: angleproject:5138
Change-Id: Ic9f87aa26fd178a40510836c3aca8814382f92e5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2456051
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
a21ef78c
|
2020-10-07T15:49:38
|
|
Skip GLES1ConformanceTest.SpotExpDir for Win+Vulkan
The test GLES1ConformanceTest.SpotExpDir/ES1_Vulkan is failing on
Win7/10 on AMD/Nvidia. This will suppress the failure while we
investigate the issue.
Bug: chromium:1136238
Test: GLES1ConformanceTest.SpotExpDir/ES1_Vulkan
Change-Id: I16d08c741b46f88f59bc2a182ed06fbb91fdb61f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2458693
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
068617d6
|
2020-10-05T20:42:57
|
|
Fix debug message formatting.
Also includes a refactor of GLenum utils.
Bug: angleproject:5131
Change-Id: Ic2d974ef5612b3609ae66bcca087cc0442f43888
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2447042
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
2d9d904e
|
2020-10-07T09:36:05
|
|
Roll Chromium manually from edbb6564c87b to a5a8696e5087 (458 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/edbb6564c87b..a5a8696e5087
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/6186e428fc..854fdb73c8
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/1c37217884..0fa2c0deee
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c5290b5af7..7e5979b1dd
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5e26fff7a7..cc0ee19df9
No update to Clang.
Bug: angleproject:5038,angleproject:5124
Change-Id: Idcfbd8a5887c76b15d5a8aa424233eaef5de3a96
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2457127
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
98117b9d
|
2020-10-07T12:44:10
|
|
Move entry point enum utils to common.
These are now used in debug.cpp.
Bug: angleproject:5131
Change-Id: Ibe1f0e3e2919a9e2f2b85c3ed80a77617266913e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451973
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
|
|
22ed1e59
|
2020-10-05T17:59:27
|
|
Vulkan: Remove depth stencil access out of RenderPassDesc
Vulkan spec says that image layout is not counted toward render pass
compatibility:
"Two render passes are compatible if their corresponding color, input,
resolve, and depth/stencil attachment references are compatible and if
they are otherwise identical except for: Initial and final image layout
in attachment descriptions Image layout in attachment references"
This CL removes the depth stencil access mode information out of
RenderPassDesc structure. It is essentially partially reverted the
change from crrev.com/c/2354280
Bug: b/170134600
Change-Id: Iada4d89c3249489b47db3046952e7cb10f252891
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451597
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
4c5f602c
|
2020-10-07T10:13:34
|
|
DisplayNULL::makeCurrent() must install DebugAnnotator
When the ANGLE end2end tests change back-ends, the null driver must
install the correct global DebugAnnotator, so that the DebugAnnotator
from another driver is not used.
Bug: chromium:1135860
Change-Id: I11aa386995283aa214df1faa62392dc6a6cbef0d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2457126
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
34951b79
|
2020-10-07T17:48:16
|
|
build: Remove no-op calls to set_sources_assignment_filter
Chromiun no longer use set_sources_assignment_filter() anywhere in the
build, so these are no longer needed.
Bug: chromium:1018739
Change-Id: Ibaf8c11c29fc0bbd63afded3e4a52bd5e07a8283
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2456588
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
|
|
|
a51c2a0b
|
2020-10-07T10:01:58
|
|
Roll SPIRV-Tools from 63cc22d645ba to fc8264854c53 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/63cc22d645ba..fc8264854c53
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I739b98910e8b6f5363cc504e7099d9c6a2447e1b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2455530
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
468f049c
|
2020-10-07T10:01:46
|
|
Roll Vulkan-Tools from 14289452a832 to 1abaced34b84 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/14289452a832..1abaced34b84
2020-10-06 shannon@lunarg.com build: Update known-good files for 1.2.156 header
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I72d885f16ddcaaf15d612501469776cf5400f0de
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2455529
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
1ad5ea79
|
2020-10-07T10:01:14
|
|
Roll SwiftShader from afe6ca45b6da to 635de036d766 (3 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/afe6ca45b6da..635de036d766
2020-10-06 srisser@google.com Replace WARN with a LOG_TRAP
2020-10-06 srisser@google.com Reflect VK_KHR_create_renderpass2 being core
2020-10-06 zzyiwei@google.com Update Vulkan headers to version 1.2.156
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I1032b611d84dbdeb3825cbc23126bb4a9a0feb10
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2455526
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
0122a2a6
|
2020-10-07T10:01:45
|
|
Roll Vulkan-ValidationLayers from c7d7610581df to e171d8431cfa (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c7d7610581df..e171d8431cfa
2020-10-06 mark@lunarg.com chassis: Remove vestigial pound-define
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I6f078ffe0fc5475a33de42a54ede8b3448447412
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2455528
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
7d1c7ff4
|
2020-10-07T10:01:29
|
|
Roll Vulkan-Loader from 3610ce9fa2d8 to a638f3acae94 (3 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3610ce9fa2d8..a638f3acae94
2020-10-06 shannon@lunarg.com build: Update known-good files for 1.2.156 header
2020-10-06 brecht@sanders.org loader: Fixes build with MinGW-w64 8.0.0.
2020-10-06 charles@lunarg.com docs: Update build.md for static build changes
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: Id216247e0617f38ce72dfe34b408653556b22553
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2455527
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
10d329d9
|
2020-10-07T09:14:56
|
|
Roll VK-GL-CTS from 02da53e45d9e to 618e41c871d6 (7 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/02da53e45d9e..618e41c871d6
2020-10-05 alexander.galazin@arm.com Update Vulkan headers
2020-10-03 alexander.galazin@arm.com Notice of withdrawal of Vulkan CTS 1.2.0.x
2020-10-02 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/master
2020-10-02 ari.suonpaa@siru.fi Fix result checking of output location tests
2020-10-02 r.potter@samsung.com Experimental crash postmortem use-after-free test
2020-09-28 alexander.galazin@arm.com Update glslang, SPIR-V Tools and Headers
2020-09-28 alexander.galazin@arm.com Update Vulkan headers
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC timvp@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com,angle-bots+autoroll-info@google.com
Change-Id: Icc1a573ea50c75b08c98c4c2f0e29be436df9605
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2455428
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
8af9ef3b
|
2020-10-06T10:59:07
|
|
Add emulated format clear perf test
Bug: angleproject:4836
Change-Id: If900d288630ba5fbf82b8b1ce2ccab681cfc50c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451481
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
3df629c5
|
2020-10-06T15:49:35
|
|
Fix a crash in FormatStringIntoVector
It was wrong to use vararg after vsnprintf() affected it.
Luckily, we don't need to call vsnprintf() on vararg,
since the previous call of vsnprintf() on varargCopy
already gives us the length that we need.
Bug: angleproject:5131
Change-Id: Ie9b62e92ef8ab7e06b51e034c99a5fde20c1ceaf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2453930
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
d5fa6ea9
|
2020-04-29T04:13:54
|
|
Vulkan: Implement OES_draw_buffers_indexed
Bug: angleproject:4394
Change-Id: I7db9c695c233b2daf740acc654b1b2e546a8b681
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2172739
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
385fb40f
|
2020-10-04T13:29:13
|
|
Capture/Replay: Don't capture deleted shaders.
ANGLE can sometimes hold on to deleted shaders while they're still in
use. This would happen when re-capturing captured application. A bunch
of shaders would be still around after used in the program linking
step because they are still attached to the program. Fix this by not
skipping the capture for shader that have been deleted but are still
in the resource map. Noticed while capturing the T-Rex replay.
Bug: angleproject:5134
Change-Id: I04e3e96b43e445d7b467e6db0325ecd0d821549d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2449162
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
2441399f
|
2020-10-05T20:42:56
|
|
Test Utils: Read available stream data on posix.
ANGLE would only read one chunk of stdout/stderr data at a
time. We would end up slowing down reading one chunk every
few hundred MS for tests with a very large output stream.
Test: *debug_negative_coverage*
Bug: angleproject:3162
Change-Id: I072cba147a6d86c02a2eda051ff61ed981990798
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2447040
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
9413c402
|
2020-10-03T10:58:12
|
|
Vulkan: Move CommandBatch for threading support
Will need access to CommandBatch class in threading worker.
Bug: b/154030730
Change-Id: Ia79eab77a81b135c22bdeecbaf65bf3c301dc987
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2447442
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
82962a0d
|
2020-10-04T11:50:02
|
|
Capture/Replay: Complete RasterizerState capture.
The dither check was incorrect. Fix the dither capture and add the
missing rasterizer discard and polygon offset capture. Noticed when
capturing the T-Rex replay.
Bug: angleproject:5134
Change-Id: I5222625175ec7e078a9c0ad6c6fd3507db3a7769
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2449158
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
a22a19a4
|
2020-10-04T13:16:46
|
|
Add a --no-finish option to the perf tests.
We can use this to re-capture replays.
Bug: angleproject:5134
Change-Id: I765e0bbb66cfdd822ffa981f2b5533157d024cac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2449161
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
57c6af7d
|
2020-10-04T12:18:29
|
|
Capture/Replay: Fix temp shader ID.
We could mess up capturing Program #1 by using a temp shader ID of 1.
Instead we can use a shader ID that isn't used in the application.
Noticed when capturing from the T-Rex replay.
Bug: angleproject:5134
Change-Id: Ic6fefe9d8cdf327a5ebbb47539b2e11161a4b13c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2449159
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
9f5eb0b8
|
2020-10-05T08:18:05
|
|
Vulkan: Add OES_sample_shading extension support
Support OES_sample_shading extension if the underlying
Vulkan ICD supports sampleRateShading.
Bug: angleproject:3587
Tests: dEQP-GLES31.functional.sample_shading.*
Change-Id: I1b324c1ad3ea3b2157d3cbe0abcdf7085aa4231b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444213
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
974c2371
|
2020-10-04T12:22:38
|
|
Perf Tests: Run at least 1 step.
We could end up in some very slow scenes (e.g. when debugging). This
could produce a step count of zero which doesn't make sense. Noticed
while capturing the T-Rex replay.
Bug: angleproject:5134
Change-Id: Ibf2439961dfb3c01649dcab37acead7b6e2ab345
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2449160
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
bc4ec4c1
|
2020-10-05T17:10:18
|
|
Vulkan: Plumb OpenGL ES commands to AGI/debuggers
Use vkCmd*DebugUtilsLabelEXT() calls to delimit all GLES commands, and
group them under GLES draw/dispatch calls. Plumb calls from the EVENT
macro (for every GL entrypoint) to vkCmd*DebugUtilsLabelEXT() via a
newly-implemented DebugAnnotatorVk class. Use a new dirty bit so that
cached entrypoints are associated with a triggering draw/dispatch
command.
The DebugAnnotatorVk::beginEvent() method saves a string in a vector
of all GL commands in ContextVk. The dirty bit converts the strings
into begin-end vkCmd*DebugUtilsLabelEXT() pairs. The
DebugAnnotatorVk::endEvent() method makes the final
vkCmdEndDebugUtilsLabelEXT() call for a draw/dispatch command.
Enable the OGL->VK mapping feature by setting
"angle_enable_trace = true" in GN args.
Bug: b/162068318
Bug: b/169243237
Change-Id: I61b6a8d113168c0ce578d6efd002d8a393659aba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451517
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
0faa4a3d
|
2020-09-19T00:12:35
|
|
Add BlendIntegerTest.MRT
Bug: angleproject:5071
Bug: angleproject:5125
Bug: angleproject:5126
Change-Id: I58539ae721efa6bcaff04c52cb8137b303d3db1e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2418716
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
82683093
|
2020-10-02T15:53:03
|
|
Rename ui/ozone/ozone.gni to build/config/ozone.gni
This CL depends on:
https://chromium-review.googlesource.com/c/chromium/src/+/2427423
Bug: chromium:1129223
Change-Id: I16d845772d13541153ee4775dbe6ba75f8485d7d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2447030
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
deb785d9
|
2020-10-06T12:45:58
|
|
Roll SPIRV-Tools from f15133788010 to 63cc22d645ba (4 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f15133788010..63cc22d645ba
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: If0844b308e147e473744d36aacb45859a3d0ecaf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451650
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
3453f745
|
2020-10-06T10:01:46
|
|
Roll Vulkan-ValidationLayers from b588cd4df419 to c7d7610581df (4 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b588cd4df419..c7d7610581df
2020-10-05 coki04@gmail.com tracker: Retire work when checking Timeline Semaphore Value
2020-10-05 btolsch@gmail.com layers: Reorder conditions to avoid uninitialized values
2020-10-05 bethau@microsoft.com layers: Fix false positives when importing AHardwareBuffers
2020-10-05 btolsch@gmail.com layers: Fix validation object leaks
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: Idecbb504caea21663eb64372b90a8fec89f227ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2452220
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
12be895d
|
2020-10-06T10:01:14
|
|
Roll SwiftShader from b3c1e71eb1cb to afe6ca45b6da (4 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/b3c1e71eb1cb..afe6ca45b6da
2020-10-05 bclayton@google.com Merge changes I48e99f11,I1a914ff6
2020-10-05 capn@google.com Regres: limit the number of GL tests opening X connections
2020-10-05 bclayton@google.com CMake: Add flag for controlling the logging level
2020-10-05 bclayton@google.com third_party/cppdap: Roll forward to 1fd23dda
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: Id48e7906ac1d6c9711082bdf0c11aa2e557587e5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2452219
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
e4eb9c05
|
2020-10-06T10:01:30
|
|
Roll Vulkan-Loader from 7c07085ad1cc to 3610ce9fa2d8 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/7c07085ad1cc..3610ce9fa2d8
2020-10-06 lenny@lunarg.com docs: Remove outdated references to WDK
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I149bc8870af2c455647114fc4932f700d0911e03
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451950
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
f6e983b8
|
2020-10-06T07:01:19
|
|
Roll Chromium from 78d150eb2790 to edbb6564c87b (486 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/78d150eb2790..edbb6564c87b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/4317485981..6186e428fc
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/ddb20d82f3..1c37217884
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f513a0bef6..c5290b5af7
* tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/ee1e244813..f685c086bd
No update to Clang.
Bug: angleproject:5124
Tbr: timvp@google.com
Change-Id: I853a2ef9421337c2d345a082c053aff24d23fdaa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451603
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
08142700
|
2020-10-01T19:30:03
|
|
Work-around test runner & DebugAnnotator
Note: This precedes another CL that needs this change.
DebugAnnotator uses a global variable. The test runner doesn't change
state between testing different back-ends. This works-around the
problem by setting the global variable when the context is switched.
Because the GL back-end doesn't have its own DebugAnnotator sub-class,
add a Display* to DisplayImpl::makeCurrent(), so that
DisplayGL::makeCurrent() can install the front-end-Display's
DebugAnnotator.
Note: the Vulkan back-end gets this fix even though the new
DebugAnnotatorVk class will be added in a follow-on CL.
Bug: b/162068318
Bug: b/169243237
Bug: angleproject:5121
Change-Id: If08626a5310f9b4e3210e1a897a6886248e4d8ac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451423
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
23624c53
|
2020-10-05T21:07:02
|
|
Test Runner: More docs.
Bug: angleproject:3162
Change-Id: I5b282d7815973cef9f7e029bc3c65cf42729e009
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451596
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
77e3d0ae
|
2020-09-25T14:12:04
|
|
Vulkan: Defer the depthStencil buffer layout change to endRenderPass
Depth stencil layout may change while we build the render pass,
depending on the read/write access been made. Right now we are always
inserting a layout change barrier at the start of render pass. Later on
when the read/write property changes, we insert another layout change
barrier. Similarly, we maintain the attachmentOps and
RenderPassDesc::mPackedColorAttachmentRangeAndDSAccess as we changes
read/write access. This makes code quite commplicated. This CL moves
mReadOnlyDepthStencilMode from FramebufferVK to CommandBufferHelper
object and we only maintain that boolean while we updating the
read/write access. Then at the end of render pass or when depthStencil
image is deleted, we update attachmentOps and mRenderPassDesc and layout
transition all at once and only done once. This simplifies the read only
depth stencil mode implementation a lot.
Bug: b/168953278
Change-Id: Ie263b4526c82a9858e5d1f141ea58f499187a3ca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2432075
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
f074d61a
|
2020-09-28T21:40:57
|
|
Plumb EntryPoint & Context to DebugAnnotator/EVENT()
This makes it easier to plumb debug labels to a future
DebugAnnotatorVk class.
Bug: b/162068318
Bug: b/169243237
Change-Id: I01e3779569c27c91252dc2874f6deaec526afd6f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451516
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
86ca5d2b
|
2020-10-01T11:56:05
|
|
Vulkan: Add plumbing to render pass when ImageHelper gets deleted
ImageHelper object is not refcounted and garbage collected and
endRenderPass call is deferred until next render pass starts. This
caused a situation that an ImageHelper object gets deleted while still
referenced in the open render pass. This CL make sure that we call into
all shared context's open renderpass when an image goes away so that
they can take appropriate action for this.
Bug: b/169618408
Change-Id: I5075e805980084db82ca3e699462272eee5d2d59
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2443571
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
da61c40e
|
2020-10-06T01:57:55
|
|
Revert "Work-around test runner & DebugAnnotator"
This reverts commit e44c94d96a9b65615fe8f5038e124763ac8c45e5.
Reason for revert: Breaks build of DisplayGbm on ChromeOS:
src/libANGLE/renderer/gl/egl/gbm/DisplayGbm.{h,cpp}
First failing builds:
https://ci.chromium.org/p/chromium/builders/ci/ChromeOS%20FYI%20Release%20%28amd64-generic%29/1608
https://ci.chromium.org/p/chromium/builders/ci/ChromeOS%20FYI%20Release%20%28kevin%29/2212
Original change's description:
> Work-around test runner & DebugAnnotator
>
> Note: This precedes another CL that needs this change.
>
> DebugAnnotator uses a global variable. The test runner doesn't change
> state between testing different back-ends. This works-around the
> problem by setting the global variable when the context is switched.
>
> Because the GL back-end doesn't have its own DebugAnnotator sub-class,
> add a Display* to DisplayImpl::makeCurrent(), so that
> DisplayGL::makeCurrent() can install the front-end-Display's
> DebugAnnotator.
>
> Note: the Vulkan back-end gets this fix even though the new
> DebugAnnotatorVk class will be added in a follow-on CL.
>
> Bug: b/162068318
> Bug: b/169243237
> Bug: angleproject:5121
> Change-Id: I748e8a1fd09b72e07242ac7fb39154537dcce534
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444095
> Reviewed-by: Ian Elliott <ianelliott@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
> Commit-Queue: Ian Elliott <ianelliott@google.com>
TBR=courtneygo@google.com,ianelliott@google.com,jmadill@chromium.org
Change-Id: I99df2716951726ead24961dc3d27a7ec63aeda80
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/162068318
Bug: b/169243237
Bug: angleproject:5121
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451420
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
|
|
|
a8d4457c
|
2020-10-02T23:51:57
|
|
Change shader compile failures into an info message.
This reduces spam in our unit tests. Speeds up test execution.
Bug: angleproject:3162
Change-Id: I286a18b3ce862c4e4155076b2ee3f93c9db2eb33
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2447041
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
d3aa1e9c
|
2020-10-03T01:31:33
|
|
Test Runner: Pass dEQP args to child processes.
This fixes the sharding to use the specified back-end. With
the bug ANGLE would start the platform default back-end instead.
Bug: angleproject:3162
Change-Id: Ib2453dd3c58ea40fb36619301865ae0818038d15
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2447043
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
f0d9471c
|
2020-10-02T23:51:57
|
|
Test Runner: More misc improvements.
- reduces default batch size from 1000 -> 256
- reduces default max processes to a max of 16
- stripes tests when in bot mode
- prints less spam when waiting for child processes
The striping and smaller batch size can help with slow tests.
The max process limit seemed to prevent errors on Linux.
Bug: angleproject:3162
Change-Id: Ibed89ca35db54c62ec8ed63b32bc5aed916faec9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2447037
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
e44c94d9
|
2020-10-01T19:30:03
|
|
Work-around test runner & DebugAnnotator
Note: This precedes another CL that needs this change.
DebugAnnotator uses a global variable. The test runner doesn't change
state between testing different back-ends. This works-around the
problem by setting the global variable when the context is switched.
Because the GL back-end doesn't have its own DebugAnnotator sub-class,
add a Display* to DisplayImpl::makeCurrent(), so that
DisplayGL::makeCurrent() can install the front-end-Display's
DebugAnnotator.
Note: the Vulkan back-end gets this fix even though the new
DebugAnnotatorVk class will be added in a follow-on CL.
Bug: b/162068318
Bug: b/169243237
Bug: angleproject:5121
Change-Id: I748e8a1fd09b72e07242ac7fb39154537dcce534
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444095
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
7004523a
|
2020-10-02T23:51:57
|
|
KHR_debug: Fix off-by-one message length.
The dEQP tests were timing out due to the "get message" call skipping
messages. The get call had a bufSize that ANGLE was rejecting as too
small because it didn't include the null terminator. The dEQP test
would pass but would always take ten seconds. I noticed this when
debugging the ANGLE test launcher and seeing batch timeouts.
Bug: angleproject:5130
Change-Id: Ie9f949218590b98a11f6c10b1f86074e90dbca17
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2447039
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
9214fc18
|
2020-10-05T17:53:48
|
|
Suppress failing Mac GL dEQP-GLES3 tests.
dEQP-GLES3.functional.fbo.completeness.renderable.texture.color0.stencil_index8
dEQP-GLES3.functional.fbo.completeness.renderable.texture.stencil.stencil_index8
dEQP-GLES3.functional.fbo.completeness.renderable.texture.depth.stencil_index8
Bug: angleproject:5136
Change-Id: I3e534df7312f173716952adc7ef24ac052914308
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451317
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
f69aaf60
|
2020-10-05T21:50:10
|
|
Replaced allow_list with files_to_check
Link to the inclusivity rules
https://source.android.com/setup/contribute/respectful-code
Bug: b/162834212
Change-Id: I2bb65ca7ae73109dc858c93f3a9f973ebfe9d4cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451318
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Trevor Black <vantablack@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
be73728d
|
2020-10-03T17:52:25
|
|
Improve capture replay tests.
Removes the custom logger class and uses the python logging class.
Moves the argument descriptions into argparse help.
Keep build directories around by default. Essential for normal use.
Print more debug messages.
Bug: angleproject:5133
Change-Id: Ida48828512abe60ee7d16873cbdb87c58529a60a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2446898
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
8608b402
|
2020-10-04T11:42:08
|
|
Capture/Replay: Don't capture XFB 0 in MEC.
This will only add an extra unused XFB object. Noticed when capturing
from the T-Rex replay.
Bug: angleproject:5134
Change-Id: Ia368f9e9f59f9ea7473ac88928a413001fa99496
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2449157
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
0ff24ae0
|
2020-10-05T14:54:31
|
|
Suppress failing Mac GL dEQP tests.
dEQP-GLES2.functional.fbo.completeness.renderable.texture.color0.stencil_index8
dEQP-GLES2.functional.fbo.completeness.renderable.texture.stencil.stencil_index8
dEQP-GLES2.functional.fbo.completeness.renderable.texture.depth.stencil_index8
Bug: angleproject:5136
Change-Id: I787bf4505a5c10d47fa669423df8a7510e28bcab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2450916
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
61b13f8f
|
2020-09-30T16:29:04
|
|
Tests: Update two traces, remove one
* Update candy_crush and temple_run to use more recent
capture headers.
* Remove subway_surfer because the app no longer uses
GLES. Its Unity backend now runs Vulkan, so we can't
re-record it.
Test: angle_perftests --gtest_filter="*Trace*"
Bug: angleproject:4845
Change-Id: I9d219f2be05813c50b31287a65bfc099787d114c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2441851
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
505a8d05
|
2020-09-26T23:40:51
|
|
Capture/Replay: Split very large replay function.
This allows a replay of the T-Rex offscreen benchmark.
Bug: angleproject:5133
Change-Id: I9998c4785e61a6410863a1cd8a8a569b1e08098a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2446897
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
c15d1e2d
|
2020-09-26T15:11:43
|
|
Capture/Replay: Generalize function splitting.
We can use this to split up the replay function as well as very large
setup functions. This will let us replay the gfxbench offscreen
benchmarks directly.
Bug: angleproject:5133
Change-Id: Ic24f25f2ab6821e68356a28a698cb84301e99be2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2446896
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
34445b29
|
2020-10-02T15:23:35
|
|
FrameCapture: More fixes for app updates
* Disable GL_EXT_map_buffer_range during capture, several
native GLES drivers do not support it.
* Unmap buffers before updating them during Reset. Some native
drivers require it.
Test: Temple Run on multiple systems
Bug: angleproject:4845
Change-Id: I9aea9c220320095aee87da107320b8fcad6c0a2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2447029
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
ef897a9c
|
2020-10-05T10:01:15
|
|
Roll SwiftShader from 375fee944c76 to b3c1e71eb1cb (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/375fee944c76..b3c1e71eb1cb
2020-10-02 nicolascapens@google.com Regres: List regressions before summary
2020-10-02 vantablack@google.com Added support for AndroidHardwareBuffer
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I6765670fbd22e6c37290c1ef51823b9148eb765a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2448992
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
b33da9ae
|
2020-10-05T10:01:58
|
|
Roll SPIRV-Tools from d91afd8de27a to f15133788010 (3 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d91afd8de27a..f15133788010
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I9509dbb7a234dfd00d9457d522dcdd0068dd2ea8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2448213
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
d8b31486
|
2020-10-05T10:01:38
|
|
Roll Vulkan-Headers from e1ba543c6789 to 94ff600cc862 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/e1ba543c6789..94ff600cc862
2020-10-05 oddhack@sonic.net Update for Vulkan-Docs 1.2.156
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Change-Id: Iefb59064e9acccd309eaaef2993f60c70de73dd9
Bug: None
Tbr: timvp@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2448959
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
e56466d4
|
2020-10-05T07:01:08
|
|
Roll Chromium from 7b91afe96128 to 78d150eb2790 (541 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/7b91afe96128..78d150eb2790
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/9cc0704ecc..4317485981
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/5538030635..ddb20d82f3
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3187b54c0c..54a9cb2f54
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/921f371807..f513a0bef6
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/410285a57e..5e26fff7a7
No update to Clang.
Bug: angleproject:5124
Tbr: jonahr@google.com
Change-Id: I51018170b29a3c03e59c856db57d4f0d780c20d3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2449150
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
50070481
|
2020-10-02T01:03:41
|
|
Vulkan: Render pass creation cleanup
Bug: angleproject:4836
Change-Id: If7b0beef4b32149bebb0f63558ac34d0c3cd79c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444098
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
c5494728
|
2020-10-02T00:55:28
|
|
Vulkan: Free up 2 bits in PackedAttachmentOpsDesc
These bits will be used to aid in invalidation of
multisampled-render-to-texture attachments.
Bug: angleproject:4836
Change-Id: Ib2b438386f8cd8c057bc0ef16144b9d2ddbc1594
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444097
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
23825b12
|
2020-10-02T16:32:32
|
|
Test Runner: Set interrupted to 'false' normally.
The bug here was to output 'interrupted: true' when running
in --bot-mode. Instead in normal execution we will output
that we were not interrupted.
Bug: angleproject:3162
Bug: chromium:1134619
Change-Id: I3842e90466473ff05b0b90bc4660f88606a3c9f6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2446851
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
c488f0c9
|
2020-10-02T16:23:08
|
|
Suppress flaky test on Win/Intel/GL.
CopyTextureTestES3.ES3UnormFormats/ES3_OpenGL
Bug: angleproject:5127
Change-Id: I93628beb92b8d9b4d8c6f70b32d15ed9add54667
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2446595
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
e815afbf
|
2020-09-07T22:09:22
|
|
First pass at increasing inclusivity
Link to the inclusivity rules
https://source.android.com/setup/contribute/respectful-code
Bug: b/162834212
Bug: chromium:1097198
Change-Id: Ied5a9e3879d72bff3f77ea6fcda9b82f30c32c2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2396737
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Trevor Black <vantablack@google.com>
|
|
7a92d958
|
2020-07-21T16:32:49
|
|
Implement GL_OES_texture_stencil8
Add extension to Caps and code gen files.
Add to Validation of TexImage
Add all the autogen for new extension
Fix swizzle for stencil only
Add LoadFunction
Fix formatutils
Add validation
Test: angle_deqp_egl_tests
--deqp-case=GLES31.functional.stencil_texturing.format.stencil_index8_2d
Bug: angleproject:3231
Change-Id: Id59c7d183ea1658732887e99637d9c8faab938e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404327
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
|
513095e9
|
2020-10-02T11:47:19
|
|
Disable AMD OpenGL testing on Windows ANGLE tests.
Our current CI testing for AMD is quite out-of-date and unsupported.
If necessary we could skip based on a GPU device ID.
Bug: angleproject:5123
Change-Id: Idf919a330aa9903ad80aba38f745d4a35d1b501e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2446092
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
c6dc9d73
|
2020-09-19T20:09:34
|
|
Vulkan: Add a test and fix the bug with draw/invalidate/clear
This adds a test that does draw with depth enabled, then disable depth
test but with depth mask still enabled. Then invalidate framebuffer and
followed by a clear. That clear will go down clearWithCommand path and
should still work and data stored.
Bug: b/169590459
Change-Id: I6dd30d6a1e12ad7820d98fe79445c336cfa3a643
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2422081
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
e9a82849
|
2020-10-02T11:29:44
|
|
Skip ResizeWindowWithDraw test on all Linux.
Flakes on NVIDIA Linux as well when run in certain orders.
Bug: angleproject:4453
Change-Id: I7565b7868518d01d5e928ce95d0edb8abd651e28
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2446091
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
a2d9abef
|
2020-10-01T16:28:59
|
|
Vulkan: Add OES_sample_shading extension entry points
Addition of just the entry points for OES_sample_shading extension.
Bug: angleproject:3587
Change-Id: I7ef5ceb846d130c2d1e0b4ea7dcbe92452b5d7d3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444212
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
348814f9
|
2020-09-30T09:50:10
|
|
EGL: Add stencil8 to configs
Add stencil8 option to Depth and Stencil of configs based on
support of stencil8 format from GLES.
Add stencil8 to configs
Adjust dEQP-EGL expectations
Unblocks dEQP-EGL.functional.*.*_no_depth_stencil tests
Test: angle_deqp_egl_tests
Bug: angleproject:3231
Change-Id: I57d7085a71a5b0dc45803351c9116a1694668852
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2430191
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
2f3d18f2
|
2020-10-01T05:58:44
|
|
Vulkan: Fix unresolve disagreement between FB and RP
FramebufferVk::updateRenderPass reset the render pass description, but
not the framebuffer description. This caused a disagreement between the
two regarding which attachments need to be unresolved. Later,
FramebufferVk::startNewRenderPass could miscalculate whether a new
framebuffer needs to be generated based on changes in unresolve
attachments.
For example:
- say in the first render pass color needs to be unresolved. Both RP
and FB desc would remember this (each being keys for their respective
caches).
- A following operation triggers syncState such that FB desc changes
(for example rebind of attachment), which cleared RP desc but not FB
desc's unresolve attachment state.
- If the next render pass does not require an unresolve (for example due
to a clear or invalidate), then the framebuffer is not recreated
because according to RP desc at the start and end of
FramebufferVk::startNewRenderPass there has been no change in
unresolve mask.
* At start there's no unresolve because of syncState clearing it.
* At end there's no unresolve because there's no need for unresolve.
- In the end, the framebuffer used for the first render pass would be
used for the second render pass as well. Note that:
* The first render pass included an unresolve, i.e. two subpasses.
* The second render pass requires one subpass according to its RP
desc.
It's quite easy to accidentally have the framebuffer correctly recreated
(based on the reset RP desc) before FramebufferVk::startNewRenderPass.
Note that since syncState has called updateRenderPass, FB desc has
necessarily changed, and mFramebuffer is nullptr, so any call to
FramebufferVk::getFramebuffer would recreate the framebuffer.
Both clear and invalidate call FramebufferVk::getFramebuffer.
The issue is reproducible in situations where clear/invalidate has been
called before the framebuffer is modified, and then draw is issued after
the modification. An ASSERT is added to catch discrepencies between RP
desc and FB desc to catch bugs even when the issue doesn't manifest
itself as a VVL error.
Bug: angleproject:4836
Change-Id: I8a0d116402a6c298377d03e0908baa942019ccd5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2442379
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
527064f1
|
2020-10-02T10:01:29
|
|
Roll Vulkan-Loader from 0c0ac2c6c458 to 7c07085ad1cc (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0c0ac2c6c458..7c07085ad1cc
2020-10-01 lenny@lunarg.com loader: Fix incorrect allocation error cleanup
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: jonahr@google.com
Change-Id: I2594abe522813ea09b7525ff87a6b182dfff79a2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2445061
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
4bb78856
|
2020-10-02T10:01:45
|
|
Roll Vulkan-ValidationLayers from 7a78cc629cca to b588cd4df419 (4 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7a78cc629cca..b588cd4df419
2020-10-01 mark@lunarg.com chassis: Make gpuaf/debugprintf add'l parm void*
2020-10-01 jleger@qti.qualcomm.com fix formatting error
2020-10-01 jleger@qti.qualcomm.com Add fix for renderpass compatibility
2020-10-01 jeremyg@lunarg.com state_tracker: Remove 'using std::*' statements
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: jonahr@google.com
Change-Id: I2612ffebd6b287f0f303a98ddee7ac567763d8b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2445062
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
073ff5fe
|
2020-10-02T10:01:46
|
|
Roll Vulkan-Tools from c5c6265c026e to 14289452a832 (2 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/c5c6265c026e..14289452a832
2020-10-01 charles@lunarg.com vulkaninfo: Add more portability macro guards
2020-10-01 charles@lunarg.com vulkaninfo: properly macro guard the portability features.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: jonahr@google.com
Change-Id: I2618db2a3b4cf6306b68fb8fc9053bd1a5dce4c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2445063
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
a2618061
|
2020-10-02T10:01:14
|
|
Roll SwiftShader from 5e947adaf26e to 375fee944c76 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/5e947adaf26e..375fee944c76
2020-10-02 zzyiwei@google.com Use vndk/window.h instead of the system one
2020-10-01 swiftshader.regress@gmail.com Regres: Update test lists @ 5e947ada
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: jonahr@google.com
Change-Id: I8317cc5e94ba148993be70910c95b62807db4044
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2445060
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
2b7e7262
|
2020-10-02T10:00:58
|
|
Roll SPIRV-Tools from 615fbe6cbc78 to d91afd8de27a (7 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/615fbe6cbc78..d91afd8de27a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: jonahr@google.com
Change-Id: Id07d30f214dafc716c2b41aa2297021e7405df1d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2445059
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
7530bab3
|
2020-10-02T07:00:19
|
|
Roll Chromium from 5efa84e265f7 to 7b91afe96128 (507 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/5efa84e265f7..7b91afe96128
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/83b9c33a0b..9cc0704ecc
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/66ad7ae099..5538030635
No update to Clang.
Bug: None
Tbr: jonahr@google.com
Change-Id: I5f39cb814435589c2cec8c37efa277c40a904306
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2444100
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
1fd3e5d8
|
2020-10-01T10:00:18
|
|
Test Runner: Fix race in watchdog timeouts.
This fixes a TSAN warning that popped up with the standalone test
runner. The watchdog timer actually was never started so timeouts
were not working as intended. It also switches the timeout mode
to call _Exit which skips all the atexit handlers and avoids some
races on teardown. This change also speeds up the TestSuiteTest.
Also a small fix to GetTempDir that was including an extra path
separator on Windows.
Bug: angleproject:3162
Bug: angleproject:5117
Change-Id: I0e7880a08b61bbb6e30c65665d5c0acec2d78db2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2442381
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|