|
0e021199
|
2021-09-08T12:31:47
|
|
Gold Tests: Append "show all results" to triage links.
This should allow for easier triage when CL authors run into new
images that don't match the goldens.
Bug: skia:12428
Change-Id: I60fee615f23f5a1b36ddbe6c6708498fb3def46e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3149571
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
047e9833
|
2021-08-30T10:00:51
|
|
Traces: Move skia gold Python scripts.
Moving this folder up one level allows us to enforce that every
subdirectory in the restricted_traces folder is a trace folder. This
makes it easier to batch delete or move traces.
Bug: angleproject:5133
Change-Id: I5af24ce6c233f50dea2e6ffcaef6d489b03914c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3130441
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
48da1c35
|
2021-07-16T13:24:34
|
|
Vulkan: Prefer the local vulkan loader over the system one.
Load the Vulkan loader ourselves and give vkGetInstanceProcAddr to
volk. This allows us to always prefer loading from the current module
directory instead of using the platform-specific ordering.
Refactor angle::Library loading to use ModuleDir instead of
ApplicationDir.
CL originally authored by Geoff Lang.
Bug: chromium:1219969
Change-Id: I21d1926e90fd66e1c23cea7323991ae55f3d22d4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035444
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
d99864c0
|
2021-06-07T12:48:01
|
|
Gold Tests: Fix flaky test handling.
Indead of just retrying the batch, retry individual tests.
This should correctly handle the Intel flake pattern.
Bug: angleproject:5415
Change-Id: I029c2514ff8e7a45184c5c105bf2d0350171da29
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2940049
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
8c51ac2b
|
2021-06-02T19:50:46
|
|
Gold Tests: Fix sharding + batching.
Clearing the GTEST args from the env vars will run the proper subset
of tests instead of applying sharding arguments twice. This should
fix the tests on the bots running a small subset of the tests.
Also updates logging control for the script.
Bug: angleproject:5966
Change-Id: Ic8a21e6aacfed17eff836d4301a6a50464b2cb92
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2935196
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
1429130b
|
2021-05-28T14:02:58
|
|
Gold Tests: Fix batch result reporting
Previously artifacts were not reset for a new trace in a batch
Bug: angleproject:5966
Change-Id: Ia6ed8c070eaaeca7e6cea887419666f630648df8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2925218
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
ce7d80bd
|
2021-05-27T18:16:07
|
|
Gold Tests: Fix batch uploading
Uploading to Gold used to stop after the first failure in the batch
Bug: angleproject:5966
Change-Id: Iff89c106b18a9aab5a43742a6085c5f9a3c9a188
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2923784
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
163f6ac0
|
2021-05-26T10:57:18
|
|
Gold Tests: Add batching.
This should speed up test runs on Android, which are currently much
slower than the other platforms.
Bug: angleproject:5966
Change-Id: I57890522b64d1d195ea0be56b4f68b6d54192d64
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2919888
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
17c45b65
|
2021-05-25T10:06:47
|
|
infra: Shard restricted_trace_gold_tests.
Reduces shard time from 50+ min to <10 min per shard.
Bug: angleproject:5966
Change-Id: Ia230d71a66ac9a273a10e0389cc04d8c5737bc4a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2915566
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
3ff08c44
|
2021-05-14T15:41:50
|
|
Gold Tests: Implement flaky retries and sharding.
This CL implements two features: first off we can now split the tests
into several shards which we can run independently on different
machines.
Second it implements a simple retry mechanism that will retry a failed
test a number of times and count any first passing test as a pass.
Bug: angleproject:5875
Bug: angleproject:5966
Change-Id: Ieef4ea0e4eebdb286a32de3b1e3fef4f2eda0600
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2897546
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
31d48df1
|
2021-04-07T11:15:14
|
|
restricted trace tests: Fix script.
This script was not parsing the trace list properly and was
running no tests.
Bug: angleproject:5811
Change-Id: I925bc16ac476823ca2f850d4a9e208b9bb5deb62
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2810805
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
4ec7021c
|
2021-01-27T16:41:45
|
|
Report angle_restricted_trace_gold_tests as interrupted on Exception
Otherwise step is reported as failed but build as succeeded
Bug: chromium:1153299
Change-Id: Id21d7ceafd04553634463be5acb64c070d251abb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2653859
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
d4439824
|
2020-11-08T16:17:20
|
|
Gold Trace Tests: Fix JSON output with empty test set.
Previously we would leave an empty test suite name with no tests run.
According to the JSON test results spec this is likely a malformed
output and we should instead include just an empty "tests" key.
Bad:
"tests": {
"angle_restricted_trace_gold_tests": {}
}
Good:
"tests": {}
Bug: angleproject:5299
Change-Id: I459da593df150d804130f9c63e05d031e77a16a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525147
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
c07bd2f2
|
2020-11-05T08:58:14
|
|
Ensure trace test failures are unexpected.
This will make the names of the failures show up in Milo.
Bug: angleproject:5310
Change-Id: I64e1f5ffff04ec70a44f8f3d0c339da2bca6b216
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2520539
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
6372a56f
|
2020-11-04T14:07:03
|
|
Gold trace tests: Add logging for filter misses.
The prior fix still didn't work. Add logging to debug why.
Bug: angleproject:5299
Change-Id: I758cfa87066e1cdf4a5d1289c030943e9bded58d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519400
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
6ef8f848
|
2020-11-04T11:10:48
|
|
Trace Gold Tests: Fix filter name.
Was incorrectly checking the individual test name instead of the full
name including the test suite.
Bug: angleproject:5299
Change-Id: I60df15bf1a748ce24d54f56b48ffe6eaca2ba54b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519396
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
302f234d
|
2020-11-03T14:55:55
|
|
Gold Trace Tests: Handle test filter.
This will allow the Chromium recipe retry mechanism to work properly.
That in turn will let the recipe properly fail tests that pass without
the patch and fail with the patch.
Bug: angleproject:5299
Change-Id: Ic744e125779c6bc6a091e1ed89ac1be6b97fd942
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518172
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
cb1a3ce5
|
2020-10-29T10:13:40
|
|
Skia Gold: Fix Android stdout parsing.
A recent change in Chromium broke how we were parsing stdout for
capturing system info on Android. Fix the break and also update
some helper scripts to work better when run manually.
Bug: angleproject:5261
Change-Id: Iecc00bbe540461ab50ea31b5245b8b38a7250956
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2507633
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
11d94d86
|
2020-09-23T15:16:19
|
|
Integrate Skia Gold with restricted trace tests.
The implementation is based heavily on the Chromium Skia Gold
Python classes in //build/skia_gold_common .
Results will be visible here: https://angle-gold.skia.org/
Currently results are not visible until this CL lands.
Bug: angleproject:4090
Bug: b/168049670
Change-Id: I7a5d64fe35583ad7ea6360804a0f6b72cd9f6d8b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2430179
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
962e3473
|
2020-09-25T00:22:27
|
|
Fix return code of restricted trace tests.
The prior script was incorrectly comparing a boolean result with a
number and producing the opposite result: True would be reported as a
failure, and False would be reported as success.
Bug: angleproject:4090
Bug: b/168049670
Change-Id: I47ec684a57c455c6a833232d0a49774b265f7b39
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2430667
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
2a09e891
|
2020-09-22T09:32:32
|
|
Isolated script args in restricted trace tests.
This will allow us to pass CQ since CQ requires isolated script output
args. We can also update this logic later to fail CQ if the golden
image check fails.
Bug: angleproject:4090
Bug: b/168049670
Change-Id: I81c5571e8742e641ebd8c9cbd8e1c89f583c725c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2423212
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
eed069b3
|
2020-09-22T08:55:32
|
|
Give restricted gold tests executable bit.
Bug: angleproject:4090
Bug: b/168049670
Change-Id: Ie3a46d4689e40958460c1f26a228645d84b3305c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2423211
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
5ec560fb
|
2020-09-17T17:18:25
|
|
Add restricted trace golden image script test.
The script reads the list of tests from the restricted traces JSON and
runs angle_perftests once for each test. Running the tests in a batch
seems unstable on some platfroms so running each test separately works
around that limitation. It does not yet interact with Skia Gold. The
Gold integration will come later once this basic skeleton is running
on the bots.
Also updates the perf tests to exit more quickly with --one-frame-only.
This will speed up the screenshots.
Example run with trigger.py:
https://chromium-swarm.appspot.com/task?id=4ecb985330a33910
Bug: angleproject:4090
Bug: b/168049670
Test: tested with trigger.py
Change-Id: I52820dfba2acfbc5d638673c37297877e8476adb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2417641
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|