kc3-lang/angle

Log

Author Commit Date CI Message
Liza Burakova bff0b1e4 2024-02-15T18:22:12 Change enum value for webgpu to unused value. Bug: angleproject:8476 Change-Id: I62c2d6d6dc0bf2125e0be9ae9a7205f46e9fc871 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5301496 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 6d4706bf 2024-02-15T14:03:45 WGPU: Add a angle_dawn_dir build override. This will allow Chromium to point out the dawn directory to ANGLE and disable the WebGPU backend if dawn does not exist. Bug: angleproject:8477 Change-Id: I5191b33dcf64ec1694f7be4ccc855b27d6fd0f76 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5301615 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi aa244358 2024-02-06T14:44:39 Reland "Vulkan: Get rid of X11 include in DisplayVkXcb.cpp" This is a reland of commit 8abbe2836bb49faba8a97e2df59058290e1c385a In the reland, the xcb-util dependency is removed. Original change's description: > Vulkan: Get rid of X11 include in DisplayVkXcb.cpp > > Bug: angleproject:8520 > Change-Id: Iaa251b0ba2858873b8d22e8f9e5dae7a2567c95e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5273489 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> Bug: angleproject:8520 Change-Id: I238e0a6c3b94398c10fa1bc39c5a0b4261797311 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5292774 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 6d589ff6 2024-02-12T15:26:54 Trace perf: support custom thermal throttling for tests Vendor throttling kicks in rather quickly and starts affecting e.g. cpu/gpu freqs, which can be hard to predict and increases variance in our tests. This change implements support for disabling vendor throttling (re-enabled at the end, including ctrl-C) and using a custom temperature threshold for VIRTUAL-SKIN sensors, which are checked after each test runs. This allows to set the threshold to higher values and run the device hotter without touching cpu/gpu freqs while running tests, and then dissipate heat (if necessary) by sleeps between tests. This also allows to reduce fixed-time sleeps between tests as we're monitoring the temperatures. Only some of our trace tests heat up the device sufficiently to actually require throttling, and with active cooling I was able to avoid sleeps almost through the entire run. However, sleeps might also be needed to prevent battery from discharging, so also add a flag to sleep until a given battery level is reached after each test. Example usage, sleeping between tests until all sensors are below 39C but also battery level is at least 30%: --custom-throttling-temp=39 --min-battery-level=30 Bug: b/315042901 Change-Id: I7660fc36b1103e20e4cc97312d396f3667739481 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5288455 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi ec2603d6 2024-02-14T13:02:35 Fix build in absence of SSE support Bug: angleproject:8536 Change-Id: Ic74c775b9291fb6bb75adcaeeab0a5f01c2cfa3b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5296385 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi b380ed1f 2024-02-14T09:31:26 Vulkan: Add EGL_ANGLE_global_fence_sync Chrome has an implicit assumption that due to context virtualization, signaling a fence in one context results in synchronization with _all_ contexts that have previously made submissions. This is not per EGL spec, but the functionality is easily implementable in the Vulkan backend. In the Vulkan backend, each context is given its own "timeline" of submissions (tracked by serials associated with "indices"). The required functionality is implemented through a new EGL fence sync object whose sole difference is that it synchronizes with all the existing timelines rather than the one of the current context. Bug: b/318721705 Change-Id: I6c45d065e592d0d4ed627ce9695196b1086d5021 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5297396 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 40dfb3a8 2024-02-12T00:00:00 Fix length() translation for clip/cull distance arrays * Fixed a failing assertion when the arrays are resized. * Added a compile error for length() when the arrays are unsized. Fixed: angleproject:8527 Change-Id: I6379336c546b008095f0875e5b5b4e8e0e5ba3e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5293914 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen d6ceac91 2024-02-12T20:37:58 Metal: Add support for binding slices to images Add support for binding Metal MTLTextureType2DArray texture slices to EGL images. Bug: angleproject:8531 Change-Id: I938e75c81bf36d3885f3bdcb0d1007e1f87e20c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5290374 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Shahbaz Youssefi 195c142d 2024-02-14T15:09:54 GLSL test for side effects in prune-able loop Bug: angleproject:8532 Change-Id: Ie872e957b78454d725575b05721f9b3f213889f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5297407 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Liza Burakova e8a3493f 2024-02-14T21:51:00 Initialize DisplayWgpu This change adds basic initialize to DisplayWgpu as well as adding APIs for DisplayGLX and DisplayWgpu. These APIs are necessary to ensure DisplayWgpu doesn't pull in necessary X11 headers that break builds. Bug: angleproject:8477 Change-Id: Icc6d9e7246a741def7a0337a296f9c1f9cec1415 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5259979 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
Shahbaz Youssefi 2cae27c2 2024-02-14T10:38:18 Vulkan: Enable the doubleDepthBiasConstantFactor feature on NV Experimentally found to make behavior more consistent with other platforms. Discovered through a Dawn issue [1]. [1]: https://bugs.chromium.org/p/dawn/issues/detail?id=2076 Bug: b/249380591 Change-Id: I27777397d717da0d400b9e15508b17b5329e1e8e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5296380 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen 197beb4d 2024-02-13T15:47:32 Metal: Crash if for loop body is optimized away Loops might have their bodies optimized away. For case like `for(;;) if(false);` the constant pruning happens at parse phase. The else branch (e.e. no else branch, nullptr) would be selected as the body. Some code treated the body as optional, some code treated it as required. Define it as required, and remove all conditional code related to the loop body. Bug: angleproject:8532 Change-Id: Ic35f1bf78e63ceb2cee7b96ba99e788efc282e6f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5291554 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Shahbaz Youssefi dbc6bd9d 2024-02-12T14:07:49 Reland "Vulkan: Fix alignment issues with SecondaryCommandBuffer" This is a reland of commit e53270c9ca1afe393d6d7d0359e81cf6755b6ca5 Original change's description: > Vulkan: Fix alignment issues with SecondaryCommandBuffer > > This solves undefined behaviour on 64-bit systems. This inflates the > size of a few commands, but most commands either already did align to 8 > bytes or could be aligned to 8 bytes with a few tweaks. > > Bug: angleproject:7852 > Change-Id: Ie61976d5bf8df7790acd95c0e15d4c79402622a1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5288636 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7852 Change-Id: Ie206e66fc21c5db7c9e67eb478d9cddada5db8e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5296376 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Austin Annestrand c673c837 2024-01-08T19:05:38 OpenCL/Vulkan: Initial support for platform/device Introduce OpenCL platform and device object creation for Vulkan backend in ANGLE. Bug: angleproject:8498 Change-Id: I5af9a23ed343648115bd9f0e81cd7a53080e2982 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5233365 Commit-Queue: Austin Annestrand <a.annestrand@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Kimmo Kinnunen b8e56d5d 2023-11-20T15:41:44 Fix an assert when overwriting TexImage binding Fix an assert when overwriting a image binding with multiple eglBindTexImage calls on the same texture. Bug: angleproject:8521 Change-Id: Ie7247017fd73c523b889278ec19a09ecf0683692 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5272912 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 243f8ad9 2024-02-14T11:44:58 Revert "Vulkan: Fix alignment issues with SecondaryCommandBuffer" This reverts commit e53270c9ca1afe393d6d7d0359e81cf6755b6ca5. Reason for revert: breaks x86 Android build: https://chromium-review.googlesource.com/c/chromium/src/+/5293321 https://ci.chromium.org/ui/p/chromium/builders/try/android-x86-rel/144329/overview Original change's description: > Vulkan: Fix alignment issues with SecondaryCommandBuffer > > This solves undefined behaviour on 64-bit systems. This inflates the > size of a few commands, but most commands either already did align to 8 > bytes or could be aligned to 8 bytes with a few tweaks. > > Bug: angleproject:7852 > Change-Id: Ie61976d5bf8df7790acd95c0e15d4c79402622a1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5288636 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7852 Change-Id: Id9c7a94ccc12816bc9e8c3803bd940550d9f7953 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5295854 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll 7490ad4d 2024-02-14T10:01:43 Roll vulkan-deps from 2cedf06e4cdf to 063ea20a64fc (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/2cedf06e4cdf..063ea20a64fc Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/47a02a987c..9fd0fcd737 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b7413609cf..f9184c6501 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I3c97ae6df114b8ea747fd8052e15e2a3cd2a9e8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5295018 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d8340c15 2024-02-14T07:00:53 Roll Chromium from b650d7fcd665 to 29bec8631d2f (631 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b650d7fcd665..29bec8631d2f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a301b4f2a6..2cece96e17 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e6b0b51699..c37870b5fd * third_party/android_build_tools/lint: KBVVjzxe9TcHEv-JSKko21bFKEolQZXJDvUREjbrrlkC..Hgob1AcE3OjuqT1wUs6DioB-Vfs96VKmh1vKON4ujigC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/99cae5876c..51589f432d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f76550541c..a5a09d23fa * third_party/kotlin_stdlib: 7f5xFu_YQrbg_vacQ5mMcUFIkMPpvM_mQ8QERRKYBvUC..-uFeIws_FQzyqmgZlGL37ooRLAD8mwClD33O8rZwnTsC * third_party/r8: szZgxadOOC_Yfq3DhP5R0WR2LMRiVMVrt71WNfL5taIC..tp4vVuXzmyHJxDFlwxDb7RYZLLEufc3EnGTyOTCTNkgC * tools/luci-go: git_revision:c7b026b3a6a1f877ce46a90c5f761b10e5149891..git_revision:3df60a11d33a59614c0e8d2bccc58d8c30984901 * tools/luci-go: git_revision:c7b026b3a6a1f877ce46a90c5f761b10e5149891..git_revision:3df60a11d33a59614c0e8d2bccc58d8c30984901 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/50b5d62710..1972d63ee9 * tools/skia_goldctl/linux: 8xvDLWxU0ipGlMbwh07HD9us6YUasvqj9enFMIhuA5YC..zK5gXUdYtOJO_5L0VqpL13_iPtatoApMRsbAJ-AObycC * tools/skia_goldctl/mac_amd64: 4QY9kfg-XVCCc4fSkPGACm8r2hA_QhxFcrmJG4qyzEgC..I77LRdzh6aOopDPydG6LuPfDh6BbH4IFqWH8WWesWlMC * tools/skia_goldctl/mac_arm64: 4dKQux2uWzdVCj0jAeSf4toiJ2pvSwH0ElDobPMlryEC..JRekXzEdC8R2yKoqGJvHhZ516qC1pJwyHAxOuqTyDREC * tools/skia_goldctl/win: H7jFTr_bQujHnqv-ThbCTD9kI56AeRAoAWaewJIdqcwC..fWJiw3sBoMGqR2SS2otkCsOmnqK4iXZUWzTVfqw0cssC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I4c44be29a159375dde8f3a08c2b136941f041c68 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5295017 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi e53270c9 2024-02-12T14:07:49 Vulkan: Fix alignment issues with SecondaryCommandBuffer This solves undefined behaviour on 64-bit systems. This inflates the size of a few commands, but most commands either already did align to 8 bytes or could be aligned to 8 bytes with a few tweaks. Bug: angleproject:7852 Change-Id: Ie61976d5bf8df7790acd95c0e15d4c79402622a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5288636 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi e45b2fd8 2024-02-08T12:34:06 Vulkan: Implement ANGLE_translated_shader_source Support for this extension was dropped when ANGLE generated SPIR-V directly. Generating disassembled SPIR-V is not ideal as it incurs a large binary size. The online SPIR-V tool found at https://www.khronos.org/spir/visualizer/ is capable of disassembling SPIR-V from hex values. ANGLE now implements this extension by outputting the SPIR-V in hex values and relying on this tool. Bug: angleproject:8523 Change-Id: I1a0529785147acee7b49a7a75b24f7d107ef690c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5278566 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Andrew Grieve d9665098 2024-02-12T13:53:32 Do not use hardcoded ".cr.so" extension for android component builds This will enable me to remove the extension for component builds Bug: chromium:324916799 Change-Id: I20bd8f93706d182fe6ebb3022240f81fec9de449 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5287577 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Kimmo Kinnunen 9d344b5c 2024-02-13T17:54:12 Uniform block reference in constuctors crash Passing uniform block instance name to a built-in constructor would cause type confusion. Block this by failing to parse. Bug: angleproject:8533 Change-Id: I5a676b41e2f3d766ece4ed472debc1c874753293 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5290897 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
angle-autoroll ebc151d5 2024-02-13T10:01:46 Roll vulkan-deps from 4985acbd814d to 2cedf06e4cdf (12 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4985acbd814d..2cedf06e4cdf Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/30661abd9c..47a02a987c * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/e77d03080b..d3c2a6fa95 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a8959dc653..b7413609cf * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/f24bab1ea1..d7db171ca5 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9d00ae6c66..1518a84bb7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ifeaf7a94711a34e7bba8bdfe84e22594197235f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5287952 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2cbf6613 2024-02-13T07:05:09 Roll Chromium from 3009d13b1e1a to b650d7fcd665 (3044 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3009d13b1e1a..b650d7fcd665 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f4542781a5..a301b4f2a6 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d1fe4728f6..f35a7d885a * buildtools/reclient: re_client_version:0.130.0.546556b-gomaip..re_client_version:0.131.1.784ddbb-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c64b78ce9e..e6b0b51699 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/d391aa34a6..d353dfb095 * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/f349efeefb..14d1e3676b * third_party/android_build_tools/manifest_merger: xxtHLi-sldjnrAZqfTewA7Ai7T_i46GDTkbeOQm4Da4C..DEhOvoBwWVbV8XAI9NG-tn5g27KeMh2pXa44mY4dY10C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/b03f3ff6f4..f39e9d8c1a * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/4d99ea187e..8c00b6678c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f092a8625f..99cae5876c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0696c428b0..f76550541c * third_party/fuchsia-sdk/sdk: version:18.20240127.1.1..version:18.20240207.3.1 * third_party/ijar: https://chromium.googlesource.com/chromium/src/third_party/ijar/+log/e2247b3708..ebabc6deb7 * third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/e2d024354e..c9c77525ea * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/3c2f3884e6..9d119c1f4a * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/fb278689d9..a7b3d968a3 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/fc505746f0..8bad7bd6ec * third_party/markupsafe: https://chromium.googlesource.com/chromium/src/third_party/markupsafe/+log/0bad08bb20..e582d7f0ed * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/e1ae7a6663..af720261b5 * third_party/r8: yr6NtXUFlwC0IMXpA-KKdgva5QQ8ME9lm0LD3wz3lSQC..szZgxadOOC_Yfq3DhP5R0WR2LMRiVMVrt71WNfL5taIC * third_party/turbine: 7NPeRX_XAc2XOUX7V9moyIEyM8RjjPdAhRK-8DLzk_oC..s-hdujub30RR2mH9Qf7pHv6h9uNGEiYVs6W1VXWeEe8C * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/646b7f5697..4b5807f344 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/b9d6e4a6ed..84dacdbf12 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d5858b5684..894ad691c6 * tools/luci-go: git_revision:0d11be367258bfe14a13ff1afcf43a0bc6aedb45..git_revision:c7b026b3a6a1f877ce46a90c5f761b10e5149891 * tools/luci-go: git_revision:0d11be367258bfe14a13ff1afcf43a0bc6aedb45..git_revision:c7b026b3a6a1f877ce46a90c5f761b10e5149891 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0f0ac05e41..68fa723131 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6dfec558a0..50b5d62710 * tools/skia_goldctl/linux: 407H-TbIdlUjRbGWaMLTbSuhauPqvPICdysGuqJvZwUC..8xvDLWxU0ipGlMbwh07HD9us6YUasvqj9enFMIhuA5YC * tools/skia_goldctl/mac_amd64: lkI4UMXstA7DR9LqFykhbBB0sT-pbajdPVIN8nO1xCwC..4QY9kfg-XVCCc4fSkPGACm8r2hA_QhxFcrmJG4qyzEgC * tools/skia_goldctl/mac_arm64: lhItSTy1WLT7ZDUaklin1sNQ2vdQFPwVcEKC5gRty-4C..4dKQux2uWzdVCj0jAeSf4toiJ2pvSwH0ElDobPMlryEC * tools/skia_goldctl/win: 14DPIsHsHs60_8PzIoLPiLesYnsN_0qV7RUmyNCr3zMC..H7jFTr_bQujHnqv-ThbCTD9kI56AeRAoAWaewJIdqcwC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I617a02dfad21dc0bf06b1bf6fe720983b92a49c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5288948 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev cb7d3cc2 2024-02-09T00:00:00 Treat clip/cull distance built-ins as having side effects The sizes of these built-in arrays may be affected by indexing them with constant integral expressions so such operations should not be optimized out. Fixed related failures during MSL and HLSL translation. Fixed: angleproject:8525 Change-Id: I8460aa03b997ebc4142ee2d9f81eeefe13661336 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5285436 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Liza Burakova e784b1ec 2024-02-09T16:23:17 Manual roll dawn This change rolls dawn to add an upstream change that sets a clang flag in non-chromium builds of dawn. ANGLE needs this flag in order to build dawn native. Bug: angleproject:8474 Change-Id: Ibb476368cc35b66bcb7c2edca7d9f2515058595f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5277473 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
Yuly Novikov 239e8caa 2024-02-12T11:29:20 Capture/Replay: Disallow concurrent ninja processes. To confirm whether reclient flaky failures are due to concurrency. Bug: b/323830218 Change-Id: I79ed257675624393135f9072fd207a46b4d2a30e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5285434 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll 9fd5167e 2024-02-12T10:01:20 Roll vulkan-deps from 3834da2004ec to 4985acbd814d (77 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/3834da2004ec..4985acbd814d Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/f6f9840eab..30661abd9c * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/03b485dc47..b8fcf307f1 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/1c9115b562..e77d03080b * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e5fcb7facf..a8959dc653 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/ea45703eff..5ac36269f5 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/90b990e43b..e0d594e05b * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/5a5e17fbcc..f24bab1ea1 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/b6f52799ec..86de0a0a9d * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6f55c100c6..9d00ae6c66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I96117c6fae07af2d432810a1df04c1d2d9b5edec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5285096 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Forbes eaddd3ba 2024-02-09T15:39:43 Vulkan: use linear chroma filter for ycbcr by default This aligns our choice of initial chroma filter with the initial sampler state in a texture object with target GL_TEXTURE_EXTERNAL_OES. It is still possible to confuse the backend in some edge cases (which will be addressed with later patches), but at least we have the default right. Bug: b/315387961 Test: atest CtsNativeHardwareTestCases Test: atest CtsMediaDecoderTestCases Change-Id: I2430a084a95010c7c5084cd858d4255e531e6f13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5278362 Commit-Queue: Chris Forbes <chrisforbes@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll 1d752a10 2024-02-06T07:00:51 Roll Chromium from c1ca24b91ed5 to 3009d13b1e1a (567 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c1ca24b91ed5..3009d13b1e1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/90c5422aa9..f4542781a5 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fc9e646cb3..d1fe4728f6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d1cf265406..c64b78ce9e * third_party/android_build_tools/manifest_merger: _BpuezAM4mQeQj5WNI7H6zkNx4nV2d8uGzcoJOlLQJcC..xxtHLi-sldjnrAZqfTewA7Ai7T_i46GDTkbeOQm4Da4C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/905de831f6..b03f3ff6f4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/432aa4ae6c..f092a8625f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/af6eabff53..0696c428b0 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/0c4e8fac5c..fb278689d9 * third_party/r8: X4a6wa4_8gQP775zUTVOXJEtzMNByOt6xLvdOc2_i_MC..yr6NtXUFlwC0IMXpA-KKdgva5QQ8ME9lm0LD3wz3lSQC * third_party/siso: git_revision:669c48208b82db909d20a0e61f33f6f0f6916e08..git_revision:3cd0e6e55246b8eca6646e33b124e54e67fc5660 * third_party/turbine: KfCqNpZ5XxbfuKiIsjeMWFX-6aJc5WN37x9weHyVDIkC..7NPeRX_XAc2XOUX7V9moyIEyM8RjjPdAhRK-8DLzk_oC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/262783cfa8..d5858b5684 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/132e8c9896..6dfec558a0 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I69c44b67d4bd0767a91660d028c370abf0bbd1bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5271344 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Saifuddin Hitawala 275e6f4f 2024-02-02T16:46:14 D3D: Add multiplanar support to d3d11 glTexSubImage2D Add multiplanar format support to Angle's D3D11 glTexSubImage2D. This is needed with multiplanar shared images, where we write all planes of a d3d shared image through WritePixelsYUV in raster decoder and need to do this via an intermediate texture for d3d11. This change checks for multiplanar format supported by Image11 and then goes through TextureD3D::commitRegion and performs copyTexture and then copySubResource. Added necessary test that tests for full texture copy and a subregion copy and reads back and verifies. Bug: chromium:40262482 Change-Id: I74c9978e62339375f6623f7f0a609bcb16c4b970 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5263039 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Saifuddin Hitawala <hitawala@chromium.org>
Geoff Lang e489dac0 2024-02-02T13:52:47 Allow BGRA -> RGBA for glCopyTex[Sub]Image The opposite RGBA->BGRA was already allowed for handling platform- specific default framebuffers. This allows the copying a IOSurface- backed framebuffers to RGBA textures. Bug: chromium:1523778 Change-Id: I124a4acc8c8fcdd1d3aae861d756d17022c4b4cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5254778 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 5d9abeca 2024-02-06T16:24:34 Revert "Suppress VUID-VkGraphicsPipelineCreateInfo-dynamicRendering-06576" This reverts commit 39b9d94750328ec33aad244ddf28d16d9e748b2d. Reason for revert: Fixed upstream: https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/7439 Original change's description: > Suppress VUID-VkGraphicsPipelineCreateInfo-dynamicRendering-06576 > > VVL is still working on a fix for > https://bugs.chromium.org/p/angleproject/issues/detail?id=8516#c2. > > Suppress the VVL error to unblock the vulkan-deps > auto roller > > Bug: angleproject:8516 > Change-Id: I58a2593fe0bdde5d53e07ee68e6b83847cd41d37 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5263501 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:8516 Change-Id: Iec2a523e56040b2173489f26a38fe6df6fe1b609 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5273485 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 56e5fa80 2024-02-09T10:38:44 Mark bison deps as not shipped Bug: b/324489325 Bug: b/324489327 Change-Id: Ie11fbe14688f176756729c3192fa680d46c6d2ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5281221 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 58ccdab9 2024-02-09T14:05:57 Roll VK-GL-CTS from b3344240e7fc to b9ec0d4bdf99 (8 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/b3344240e7fc..b9ec0d4bdf99 2024-02-09 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main 2024-02-09 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2024-02-09 c.hambacher@samsung.com Fix protected memory violations in global priority transition tests 2024-02-09 gleese@broadcom.com Always generate 4 component border colours 2024-02-09 jasuarez@igalia.com Ensure GL functions are initialized before choosing EGL configuration 2024-02-09 marcin.hajder@mobica.com removed GLES31.functional.stencil_texturing.misc.compare_mode_effect due to spec collision 2024-02-09 macjurga@amd.com Do not treat queryPool's availability as boolean 2024-02-09 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: I595855f01a9752943df58fd589a69bf8a79c2581 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5281807 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Liza Burakova c3d06480 2024-02-08T21:51:23 Add dawn to IGNORED_DIRECTORIES. This change adds dawn to the presubmit script's list of IGNORED_DIRECTORIES as dawn has partition alloc as an optional dependency. Bug: angleproject:8477 Change-Id: Ib5937b2a18739370a5865870831ec7326664ae69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5278568 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Yuly Novikov 73fa1b08 2024-02-09T14:38:39 Use -fno-define-target-os-macros for libpng So that https://crrev.com/c/5244629 can roll into ANGLE. Bug: chromium:41492875, angleproject:8524 Change-Id: Id047aa7bbc6846380e770d968a20fbd7d69ab64b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5282082 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Chris Forbes 3ad163d0 2024-02-09T12:29:40 Vulkan: Don't attach format features 2 version of AHB structure There's no need to attach both VkAndroidHardwareBufferFormatPropertiesANDROID *and* VkAndroidHardwareBufferFormatProperties2ANDROID here. We don't use anything from the `2` variant so just drop it. Bug: b/315387961 Change-Id: I23166743010550ad3f6bb0144c9665b392deac66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5275259 Commit-Queue: Chris Forbes <chrisforbes@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Solti 475784f5 2024-02-07T21:24:36 suppress VUID-VkPipelineVertexInputStateCreateInfo-pNext-pNext Bug: angleproject:8522 Bug: b/324243941 Change-Id: I825986e7c98f50522d7ba25c0c78839802c42c3d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5277631 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Solti Ho <solti@google.com>
Roman Lavrov c603a4f1 2024-02-08T10:53:27 Don't perf warn about ETC1->ETC2 emulation as it is efficient Format is forwards compatible: https://crsrc.org/c/third_party/angle/src/libANGLE/renderer/gl/formatutilsgl.cpp;drc=21f16cb16333802dfa942d67cac59885f904301d;l=701 Added hasInefficientlyEmulatedImageFormat() helper Bug: b/302115557 Change-Id: Ibc82c27ecf4e3afbfaac52cb45bdda776c50b4b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5278562 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yiwei Zhang ef78e570 2024-02-07T20:52:19 Revert "Vulkan: disable warmUpPipelineCacheAtLink for Venus" This reverts commit 0be59b3d83dd7b72daf2aab9d03702cfa46d4751. Needed by GPL. Meanwhile, the prior jank issue with Dota Underlords has been worked around separately. Bug: b/323708819, b/267577845 Test: parallel shader warmup works with ANGLE-on-Venus Change-Id: I61c63581b8c4e4c776842e7906e52d268e024ed2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5277630 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Solti Ho f431641a 2024-02-07T17:27:51 Revert "Vulkan: Get rid of X11 include in DisplayVkXcb.cpp" This reverts commit 8abbe2836bb49faba8a97e2df59058290e1c385a. Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/5274193 Original change's description: > Vulkan: Get rid of X11 include in DisplayVkXcb.cpp > > Bug: angleproject:8520 > Change-Id: Iaa251b0ba2858873b8d22e8f9e5dae7a2567c95e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5273489 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> Bug: angleproject:8520 Change-Id: I91bdd48d8893cbe3a6eed8058c0034a4ef1aed0a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5276987 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Solti Ho <solti@google.com>
Kimmo Kinnunen ab71d751 2024-02-07T14:25:32 Fix an assert on multidim array constructors Fail early instead of asserting when trying to parse a multidimensional array constructor call with unsized argument array argument. int A[]; int B[int[][](A)]; Bug: angleproject:8519 Change-Id: Iee2c70318eebd2def57ffab8db709d1076692922 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5272434 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 8abbe283 2024-02-06T14:44:39 Vulkan: Get rid of X11 include in DisplayVkXcb.cpp Bug: angleproject:8520 Change-Id: Iaa251b0ba2858873b8d22e8f9e5dae7a2567c95e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5273489 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Liza Burakova 98d3f327 2024-02-01T20:36:37 Change python import conditions to match dawn's. This change modifies the import conditions for jinja2 as it's required by dawn, as well as markupsafe's conditions as it's required by jinja2. Bug: angleproject:8477 Change-Id: I52ed73d14ac0d8d1a077c1c6cc05d3de066ebcf7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5259980 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bani Singh cf77126a 2024-02-06T15:50:15 Turn off ADC explicitly Prevent ADC to be used for windows bots, use gce instead. Bug: b/323830218 Change-Id: I15e0faeb2a22b6bcb933f8cecbe986489e4f2991 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5273482 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang e62bd70a 2024-01-29T14:18:07 Metal: Disable Metal on older Mac models with GPU family 1. Skip the creation of the default Metal device entirely on macs that would not pass the GPU family checks. Bug: chromium:1322521 Change-Id: I7bdc3631125a0535370328b0e1bcba347cbbd5d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5245647 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Mohan Maiya d05c9a5e 2024-01-25T13:01:49 Frontend support for QCOM foveated extensions Add frontend state management to support foveated rendering extensions. Bug: angleproject:8484 Test: Texture2D*Foveation* Change-Id: I0e1be9f11b2d442207674562da760f5bfd7debc8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5208091 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 11eb5eb7 2024-01-30T10:59:45 Traces: support checkout of individual traces Example .gclient to checkout a couple traces only: 'checkout_angle_restricted_trace_antutu_refinery': True, 'checkout_angle_restricted_trace_bubble_shooter': True, To be used in conjuction with gn args, e.g.: angle_restricted_traces=["antutu_refinery", "bubble_shooter"] Note: when need perfetto, we'd also need to add: 'checkout_angle_perfetto': True, because it defaults to checkout_angle_restricted_traces which is not being set to True in this case. Bug: b/322507257 Bug: b/322779830 Change-Id: I404e26919899c8874b570d6ffa80c86fabfd3348 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5249196 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 9d165231 2024-02-05T07:00:51 Roll Chromium from 37f9e1b14cf7 to c1ca24b91ed5 (609 revisions) https://chromium.googlesource.com/chromium/src.git/+log/37f9e1b14cf7..c1ca24b91ed5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/78ad07d164..90c5422aa9 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/43e76969b9..fc9e646cb3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/32ff18c00f..d1cf265406 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e8367e6d6e..432aa4ae6c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7142bf166c..af6eabff53 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/030b3ed3a4..3c2f3884e6 * third_party/r8: Cwp-cRksMvELPD_6Gt9Cse08DbIIA8_am3yQuDCx_wYC..X4a6wa4_8gQP775zUTVOXJEtzMNByOt6xLvdOc2_i_MC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/de6b303a89..262783cfa8 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f5c1c96a7b..0f0ac05e41 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c6dfd64fd9..132e8c9896 No update to Clang. Bug: angleproject:5038,angleproject:6245 Tbr: yuxinhu@google.com Change-Id: I0d092d7a6e4e111c68a0ac4aae284396d87cc388 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5266694 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 5a061558 2024-01-31T13:05:59 Vulkan: Update dynamic buffer size policy When allocating a dynamic buffer, it is checked if the new data can fit in an existing allocation. However, if the size of the new data exceeds that of the current buffer, a new one is allocated. To avoid using too much memory, if the data size is less than a threshold (a fraction of the current buffer size, a smaller size will be used for the new buffer. However, with a specific pattern for the new sizes, combined with the threshold value, there could be many allocations and deallocations, which can affect the performance. In this CL, the policy to update the dynamic buffer size is updated to avoid this issue. * Instead of using a smaller buffer when the required size is less than 1/4 of the current buffer size, it is done when the average required size is less than 1/8 of the current size. * Added a decaying average required size for the DynamicBuffer object. * mSizeInRecentHistory * For each new buffer allocation, the new required size is used with the average size to calculate the new average. * For each calculation, kDecayCoeffPercent is used as the weight for the existing average, and the rest is the new required size, plus rounding. * kDecayCoeffPercent is currently set to 20%. * sizeIgnoringHistory renamed to minRequiredBlockSize for more clarity. Bug: b/322216767 Change-Id: Idcabbbe50f656910fe2103925e4d6d8602ca3425 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5254218 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll efd35e3d 2024-02-02T21:28:38 Roll VK-GL-CTS from 1aeae2d1d57e to b3344240e7fc (2 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/1aeae2d1d57e..b3344240e7fc 2024-02-02 rgarcia@igalia.com Test enabling the stencil test without an stencil attachment 2024-02-02 marcin.zajac@mobica.com Vulkan Video encode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Id7cbc257eb078a317ef6bb1c78f07f221ffb5dc0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5263699 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 39b9d947 2024-02-02T13:32:30 Suppress VUID-VkGraphicsPipelineCreateInfo-dynamicRendering-06576 VVL is still working on a fix for https://bugs.chromium.org/p/angleproject/issues/detail?id=8516#c2. Suppress the VVL error to unblock the vulkan-deps auto roller Bug: angleproject:8516 Change-Id: I58a2593fe0bdde5d53e07ee68e6b83847cd41d37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5263501 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Chris Forbes f5f3304a 2024-02-02T16:27:38 Vulkan: Simplify handling of YUV filtering support When the requested filtering mode changes, we need to consider whether it is actually supported by the Vulkan driver. Now that we support renderable YUV textures, there are now three interesting cases: 1) The texture has a VkFormat, and so filtering support can be queried from GPDFP, as was already done. 2) The texture is imported from an opaque AHB using an external format, that format is renderable, and so we have assigned one of the EXTERNALn angle formats. This was *not* covered properly, and would lead to VVL errors or UB. 3) The texture is imported from an opaque AHB using an external format, and we have not assigned an EXTERNALn angle format to it, because the format is not renderable, or the Vulkan driver is missing the external format resolve functionality; In this case the angle format is NONE. This was similarly *not* covered properly, although the code did attempt to protect itself from querying the capabilities of format NONE. VVL errors and UB were still possible. To most simply cover all of these cases, capture whether the image has the VK_FORMAT_FEATURE_SAMPLED_IMAGE_YCBCR_CONVERSION_LINEAR_FILTER feature upfront, and forget about format lookups in the internals of the YcbcrConversionDesc. Bug: b/315387961 Change-Id: Ie140293d52c2b88bf06ef19bc54bb1c95927b8ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5259719 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov d5720c86 2024-01-29T15:39:57 Reland "Add third_party/perfetto" This is a reland of commit 4b76bead8f18cccde1a6322038038d66871168d9. No additional change on top of original CL. The issue https://b.corp.google.com/issues/323199418 was caused by a mistake during manual merge between aosp ANGLE and chromium ANGLE: https://android-review.git.corp.google.com/c/platform/external/angle/+/2937802/-1..1 The third_party/perfetto was not supposed to land in aosp because Android doesn't support submodules. The third_party/perfetto is supposed to be deleted by skia auto-roller. But if it is a manual roll, we need to manually delete the submodules. Original change's description: > Add third_party/perfetto > > Conditional on checkout_angle_restricted_traces = True in .gclient > > Cloned from android, similarly to Chromium: > https://crsrc.org/c/DEPS;drc=8f0a542b7501f6c09e8c9c6e273a9bf18742faf5;l=1664 > For now not auto-rolled, will likely need to figure out a way to as > "prebuilts" are rolled around once a month, which we don't neccessarily > need but not sure how long the previous ones remain available. > Bug: b/322779830 > Change-Id: I7c763d26f8a4d446502682bbf6d39dbd5e743827 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5245648 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Roman Lavrov <romanl@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> Bug: b/322779830 Change-Id: I51d5dff753ed0b57ee91218a070bfbdeb33e9c44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5259749 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi c70c329e 2024-01-31T15:59:19 Vulkan: Fix texture copy vs pre-rotation A minor error where the destination offsets were swapped based on source rotation. Bug: b/319336510 Change-Id: I5541f8d0bf0b7306b951d2601c8c27ffedb8470e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5254238 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll ffe758b1 2024-02-02T16:44:53 Roll VK-GL-CTS from fe0d0f90469f to 1aeae2d1d57e (11 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/fe0d0f90469f..1aeae2d1d57e 2024-02-02 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-02-02 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2024-02-02 amber@igalia.com Remove frexp/frexp_st spir-v assembly tests 2024-02-02 ziga@lunarg.com Test vkDestroyShaderEXT with NULL handle 2024-02-02 cturner@igalia.com Ensure the custom video device is setup correctly 2024-02-02 cturner@igalia.com Wait for sparse allocation signal 2024-02-02 jbolz@nvidia.com Fix object counting issue in host_visible depth test 2024-02-02 marcin.hajder@mobica.com State leak in NegativeShaderApiTests 2024-02-02 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main 2024-02-01 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2024-01-29 alexander.galazin@imgtec.com Notice of withdrawal of Vulkan SC CTS 1.0.1.x If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I06239466c569ba0d14d4a47703daeda0a0814f98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5262300 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand 82ba79ff 2024-01-08T15:22:59 OpenCL: Update CLtypes.h to cl_types.h This change/enhancement is to keep codebase more consistent since vulkan backend versions of this header use lowercase-snake_case for file name. Bug: angleproject:8501 Change-Id: I223712c72db06425d192ddfe7300e5475c341e38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5233364 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 0c3a6aa6 2024-02-02T10:01:31 Roll SwiftShader from d040a5bab638 to eb75201a4e03 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/d040a5bab638..eb75201a4e03 2024-02-01 syoussefi@google.com Revert "Default to use llvm16" 2024-02-01 yuxinhu@google.com Add llvm-16.0 required files for windows platform 2024-02-01 yuxinhu@google.com Revert^2 "LLVMReactor: Remove CreateFreeze() call" 2024-01-30 rsworktech@outlook.com Default to use llvm16 2024-01-30 syoussefi@google.com Fix MSAN complaint about uninitialized (and unused) value If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ie4f9ae186beac2d983d57e447f48baa699d398a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5261673 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a45a6c1d 2024-02-02T07:48:23 Roll Chromium from 861058c0b131 to 37f9e1b14cf7 (513 revisions) https://chromium.googlesource.com/chromium/src.git/+log/861058c0b131..37f9e1b14cf7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a18493935f..78ad07d164 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d8688b9036..43e76969b9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/65cf295f16..32ff18c00f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c75e76358d..e8367e6d6e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/92469e017f..7142bf166c * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/28aa23ffb4..030b3ed3a4 * third_party/r8: MNhASYP6ZVlHl8MT2UzlSGnCH9LMHjUMkz49rrlsb7wC..Cwp-cRksMvELPD_6Gt9Cse08DbIIA8_am3yQuDCx_wYC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/244bd6f732..b9d6e4a6ed * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a9f8e2f885..c6dfd64fd9 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ia47b95ad267be3fb546d202fec2eb8a1a566c576 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5261719 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand f8c06f10 2023-11-30T17:45:35 OpenCL: Add types to cl_mem origin and region Now using cl::MemOffset and cl::Coordinate. Bug: angleproject:8439 Change-Id: Id775fe78467d3b56d2a7cc87f793221ab5e04bc5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5078244 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi ecc35205 2024-01-25T23:58:25 Move uniform block dirty bits to State When glUniformBlockBinding changes the mapping from a program uniform block to a buffer binding, all contexts in the share group need to reprocess the affected block index. Prior to this change, the dirty bits that indicated which blocks have their mapping redefined were placed in the program executable, and were reset by the first context that processed them. As a result, the other contexts in the share group where not aware of such modifications. Similarly, when a buffer changed in one context, the mapped program blocks were marked dirty, with similar cross-context issues. In this change, the dirty bits are moved to State, so every context would react to these changes. Bug: angleproject:8493 Change-Id: I5712002224cbc4a576bf2ac46e8e75f26ebc5b2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5238991 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll ea1cea77 2024-02-01T08:34:02 Roll Chromium from d3635c12e43a to 861058c0b131 (574 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d3635c12e43a..861058c0b131 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7a16bc81a9..a18493935f * buildtools/reclient: re_client_version:0.128.1.7c74998-gomaip..re_client_version:0.130.0.546556b-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/46ea5627a5..65cf295f16 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/594e0ed1c4..d391aa34a6 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/719cd9d917..c75e76358d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/10bd39fd47..92469e017f * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f48a08be15..0c4e8fac5c * third_party/r8: -2s3swpHJcZRAGeWCKjYARXN0pneLMhyYGBkbbAqz6gC..MNhASYP6ZVlHl8MT2UzlSGnCH9LMHjUMkz49rrlsb7wC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3ccf8c4439..de6b303a89 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I012fb974f72ffb373cd7966ad60525237f5a2f94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5255839 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 1abfdc37 2024-01-31T10:24:51 Remove suppression of VVL error Remove the suppression of VVL error VUID-VkFramebufferAttachmentImageInfo-viewFormatCount-09536. This change in ANGLE https://chromium-review.googlesource.com/c/angle/angle/+/5246088 properly fixed the VVL error. Bug: angleproject:7553 Bug: angleproject:8513 Change-Id: Ic866bae689a649fdabfde8e80a882595e2e7947c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5249864 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuxin Hu 6340ed68 2024-01-31T19:26:10 Revert "Add third_party/perfetto" This reverts commit 4b76bead8f18cccde1a6322038038d66871168d9. Reason for revert: To unblock Android build team https://b.corp.google.com/issues/323199418 Original change's description: > Add third_party/perfetto > > Conditional on checkout_angle_restricted_traces = True in .gclient > > Cloned from android, similarly to Chromium: > https://crsrc.org/c/DEPS;drc=8f0a542b7501f6c09e8c9c6e273a9bf18742faf5;l=1664 > > For now not auto-rolled, will likely need to figure out a way to as > "prebuilts" are rolled around once a month, which we don't neccessarily > need but not sure how long the previous ones remain available. > > Bug: b/322779830 > Change-Id: I7c763d26f8a4d446502682bbf6d39dbd5e743827 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5245648 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Roman Lavrov <romanl@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> Bug: b/322779830 Change-Id: I777b06ed2732eb198785a21d04de1f63bec7cef5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5249865 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Peiyong Lin <lpy@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Liza Burakova 157088ad 2024-01-30T20:24:50 Add EGL extension for WebGPU Bug: angleproject:8476 Change-Id: Ic5aad4eb56239d9346c6ba1f812d070ce85131a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5245895 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
Matthew Leibowitz a70b6f56 2024-01-26T20:37:07 Add support for WinUI3/Windows App SDK Adds the necessary build args and code changes to support building ANGLE for WinUI 3 (aka Windows App SDK). To reduce the set of changes, and because it is functionally the same, a Windows App SDK build is basically a UWP build, but with an extra define so that the code can make a few changes to the namespaces and includes used. The main changes to the code are: - ICoreWindow is no longer used - Dispatcher has a few changes in naming and args - ISwapChainPanel is now in a different namespace Bug: angleproject:8490 Change-Id: Ibb298e3e86e8298dac12c2019eac7996a8185c51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5230637 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Bani Singh 0640f651 2024-01-30T17:42:31 USE GCE Credentials for Chrome Bot In case of bot, use GCE instead of automatic_auth which will no longer fall back to ADC (and hence GCE). Bug: b/319246651 Change-Id: I86942c30bea911b1cc89870a748bf564584af660 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5249329 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll be8d1c24 2024-01-31T07:01:37 Roll Chromium from 84709e977bd1 to d3635c12e43a (585 revisions) https://chromium.googlesource.com/chromium/src.git/+log/84709e977bd1..d3635c12e43a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/de7324e572..7a16bc81a9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ec54c350e6..46ea5627a5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/92b51e4fd5..719cd9d917 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b808b1bcdd..10bd39fd47 * third_party/r8: C9JntVaHiVuPur-3AdTgT9LdF-92xV5S53GPX-ahZsMC..-2s3swpHJcZRAGeWCKjYARXN0pneLMhyYGBkbbAqz6gC No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I2e943a9e14eee9efbf78b119e5ca8dd83c09117c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5249862 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 0ada0b7f 2024-01-29T16:36:18 Test: Add Plague Inc. trace Test: angle_trace_tests --gtest_filter="*plague_inc*" Bug: b/321562592 Change-Id: I1a68b80659517aec61315e51cacc486f44410cdf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5250428 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
angle-autoroll b514d773 2024-01-30T21:43:57 Manual roll vulkan-deps from 97f44eb2b9df to 3834da2004ec (22 revisions) Manual roll requested by yuxinhu@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/97f44eb2b9df..3834da2004ec Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/79536da264..f6f9840eab * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/ae6a8b3971..1c9115b562 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/69197ba90b..e5fcb7facf * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/ca4c1e6e42..90b990e43b * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/7c6d640a5c..5a5e17fbcc * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/822dd7f3a6..b6f52799ec * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/60dd0ad44f..6f55c100c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I7919d893c02b945d191081606e5c0fddd0213668 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5251515 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Kaiyi Li dcffb53e 2024-01-30T19:41:49 Revert "Clean up ANGLE on system build configuration." This reverts commit 98e026685123f19f01304dcdc1deb2f52cb80f67. Reason for revert: This CL breaks the build for the downstream user that is using the main branch ANGLE on some old udc branch Android tree(b/322960439): Original change's description: > Clean up ANGLE on system build configuration. > > Now that ANGLE on system is in fully released, clean up the build file > configuration and remove the flags. > > Bug: b/293503000 > Test: atest CtsAngleIntegrationHostTestCases > Change-Id: Ic31911e097b479861d380e44ec424131c928a9aa > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5234093 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Auto-Submit: Peiyong Lin <lpy@google.com> > Commit-Queue: Peiyong Lin <lpy@google.com> Bug: b/293503000 Bug: b/322960439 Change-Id: I506150d7e5802b8f6cc0fee45105a5423ab06b5d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5251056 Commit-Queue: Peiyong Lin <lpy@google.com> Auto-Submit: Kaiyi Li <kaiyili@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Peiyong Lin <lpy@google.com>
Cody Northrop 9ca81c7e 2024-01-21T13:35:06 FrameCapture: Handle zero vertex count draws Seeing the following from GLES1 (note count = 0): glDrawArrays(context = 1, mode = GL_POINTS, first = 0, count = 0) This crahes in FrameCaptureShared::captureClientArraySnapshot: 'length_error was thrown in -fno-exceptions mode with message "vector"' The function assumes vertexCount will always be greater than zero. This CL updates it to detect the empty case and simply return. Negative counts are already handled as a GL error. Test: Plague Inc MEC Bug: b/321562592 Change-Id: I3613eaac297a3471dc998b023bf2658413cb5d1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5250427 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mike Schuchardt <mikes@lunarg.com>
Geoff Lang 98846aa8 2024-01-30T10:23:48 Metal: Temporarily disable asm injection. Some Mac11 bots started to fail after the asm injection started. Disable this path to determine if it was the root cause. Bug: chromium:1522730,chromium:1513738 Change-Id: I2580f124735f576257bb46fbf47394ff845384f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5249328 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll e8498029 2024-01-30T09:08:07 Roll Chromium from 0fdef08dd9c7 to 84709e977bd1 (621 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0fdef08dd9c7..84709e977bd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ddaf87b1f3..de7324e572 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/897c7702b3..ec54c350e6 * third_party/android_build_tools/lint: X7sJxpJN0p6qi1dgpI9-UFA2YDe2O2A1kF0QZjBJpmYC..KBVVjzxe9TcHEv-JSKko21bFKEolQZXJDvUREjbrrlkC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f448d5bf8e..92b51e4fd5 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/68c511349d..b808b1bcdd * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/63c0cec034..646b7f5697 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/13de3f85f1..a9f8e2f885 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I2c0d2b951f7435157cfb3d87df31dfffafc4416c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5248566 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya ab4aed3f 2024-01-29T10:59:58 Bugfix in PixelLocalStorageTest Add GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST to following tests - - PixelLocalStorageValidationTest - PixelLocalStorageCompilerTest - PixelLocalStorageTestPreES3 Bug: angleproject:7279 Change-Id: Ibd2e682be195fddff1cf638e37d12bcc740cf3a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5243831 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Mohan Maiya 5c2fc02b 2024-01-29T16:49:28 Vulkan: Bugfix in ImageFormat FixedVector::operator[] does not update FixedVector::mSize. Need to call FixedVector::push_back(...) instead. Bug: angleproject:7553 Change-Id: I544a68276d1635957a27d21c222f50f71d35a609 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5246088 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 349e75cc 2024-01-29T16:41:42 Suppress VUID-VkFramebufferAttachmentImageInfo-viewFormatCount-09536 After this VVL change: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+/40d989c436d43538be341cd614a595505ce907cc, the newly added VVL error starts to be thrown on multiple ANGLE bots. Suppress this VVL error to unblock the vulkan-deps roller first. Will investigate later how to fix the VVL error in ANGLE. Bug: angleproject:8513 Change-Id: I7d74ff762c3b78d70c3ba5139c1b6955d4cd49e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5247713 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 0c4d6446 2024-01-24T10:38:45 Rework uniform block <-> uniform buffer mapping In GLES, the shader declares which buffer binding a block (uniform, storage or atomic counter) is bound to. For example: layout(binding = 1) uniform ubo0 { ... }; layout(binding = 2) uniform ubo1 { ... }; layout(binding = 1) uniform ubo2 { ... }; In the above, ubo0 and ubo2 use data from the buffer bound to index 2 (through glBindBufferRange), while ubo1 uses data from the buffer bound to index 1. For uniform blocks in particular, omitting the binding is allowed, in which case it is implicitly bound to buffer 0. GLES allows uniform blocks (and only uniform blocks) to remap their bindings through calls to glUniformBlockBinding. This means that the mapping of uniform blocks in the program (ubo0, ubo1, ubo2) to the buffer bindings is not constant. For storage blocks and atomic counter buffers, this binding _is_ constant and is determined at link time. At link time, the mapping of blocks to buffers is determined based on values specified in the shaders. This info is stored was stored in gl::InterfaceBlock::binding (for UBOs and SSBOs), and gl::AtomicCounterBuffer::binding. For clarity, this change renames these members to ...::inShaderBinding. When glUniformBlockBinding is called, the mapping is updated. Prior to this change, gl::InterfaceBlock::binding was directly updated, trumping the mapping determined at link time. A bug here was that after a call to glProgramBinary, GL expects the mappings to reset to their original link-time values, but instead ANGLE restored the mappings to what was configured at the time the binary was retrieved. This change tracks the uniform block -> buffer binding mapping separately from the link results so that the original values can be restored during glProgramBinary. In the process, the support data structures for tracking this mapping are moved to ProgramExecutable and the algorithms are simplified. Program Pipeline Objects maintain this mapping identically to Programs and no longer require a special and more costly path when a buffer state changes. This change prepares for but does not yet fix the more fundamental bug that the dirty bits are tracked in the program executable instead of the context state, which makes changes not propagate to all contexts correctly. Bug: angleproject:8493 Change-Id: Ib0999f49be24db06ebe9a4917d06b90af899611e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5235883 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 4b76bead 2024-01-29T15:39:57 Add third_party/perfetto Conditional on checkout_angle_restricted_traces = True in .gclient Cloned from android, similarly to Chromium: https://crsrc.org/c/DEPS;drc=8f0a542b7501f6c09e8c9c6e273a9bf18742faf5;l=1664 For now not auto-rolled, will likely need to figure out a way to as "prebuilts" are rolled around once a month, which we don't neccessarily need but not sure how long the previous ones remain available. Bug: b/322779830 Change-Id: I7c763d26f8a4d446502682bbf6d39dbd5e743827 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5245648 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 4a5abf6d 2024-01-29T15:58:38 Add Dawn checkout condition to .gitmodules Following https://crrev.com/c/5229822 Need to run "gclient gitmodules" to update the file. I had to revert the "dummy_chromium" change it makes though. Bug: angleproject:8474 Change-Id: If85989baa25edc6b2686d310bfb6c378f6ed5ba8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5245649 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Peiyong Lin 98e02668 2024-01-24T23:47:11 Clean up ANGLE on system build configuration. Now that ANGLE on system is in fully released, clean up the build file configuration and remove the flags. Bug: b/293503000 Test: atest CtsAngleIntegrationHostTestCases Change-Id: Ic31911e097b479861d380e44ec424131c928a9aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5234093 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Peiyong Lin <lpy@google.com> Commit-Queue: Peiyong Lin <lpy@google.com>
Geoff Lang c6d827e4 2024-01-25T13:00:46 Disable the Context shared lock on Android for Chrome. Bug: angleproject:7537 Change-Id: I2409185058edfefb4b9a4160a0bf6475b77606b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5236723 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 3fdf576a 2024-01-26T14:37:42 Vulkan: Workaround Nvidia driver bug with OpSelect Bug: angleproject:8503 Change-Id: I4bd2580056df3d970a1316d0dbeaaad7590aa947 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5237873 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 0ea24ef2 2024-01-26T16:50:39 Unsuppress passing tests Bug: angleproject:3871 Bug: angleproject:3872 Bug: angleproject:3879 Bug: angleproject:4686 Bug: angleproject:4704 Bug: angleproject:4718 Bug: angleproject:4721 Bug: angleproject:4792 Bug: angleproject:5086 Bug: angleproject:5313 Bug: angleproject:6109 Change-Id: I0d0f88a388cd2f19da99a7defd0ab8d98db0e6e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5241306 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 863d4862 2024-01-27T17:42:19 Work around MSAN complaint with pool allocator - Part 2 Cache a member variable accessed after destructor so MSAN doesn't consider it having an uninitialized value. Bug: b/314793573 Change-Id: I7cb515205ed5bf3ba52d68220866009dd04f2d08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5243114 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 3fe42527 2024-01-29T11:00:54 OpenCL: Fix input -> inputs for clspv_c_strings Update to inputs so that we can regenerate the spirv_c_strings.hpp output here. Bug: angleproject:8369,angleproject:8510 Change-Id: I12c0d8197b883ca45b8e03e3eb5e8c6302efbb88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5243618 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 351b85f2 2024-01-29T10:01:11 Roll SwiftShader from 3bc9ccd923da to d040a5bab638 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/3bc9ccd923da..d040a5bab638 2024-01-26 thakis@chromium.org Merge two upstream LLVM commits If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ied63e403e45b5f41418980a47b20b9f70c1d26c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5244239 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9545bdbd 2024-01-29T07:01:32 Roll Chromium from 70e6bcc15839 to 0fdef08dd9c7 (58 revisions) https://chromium.googlesource.com/chromium/src.git/+log/70e6bcc15839..0fdef08dd9c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1fde7f2264..897c7702b3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/31bf504bc3..f448d5bf8e * third_party/siso: git_revision:c892a2c62436b0d4ffbf1e5c559c73cd0f5c7e31..git_revision:669c48208b82db909d20a0e61f33f6f0f6916e08 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I442575046720f2af861a20cb5cc88eff684c0e4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5243616 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2f4f3dcf 2024-01-28T17:49:44 Manual roll Chromium from 4d771baa2602 to 70e6bcc15839 (609 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/chromium/src.git/+log/4d771baa2602..70e6bcc15839 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7cc3e886b6..ddaf87b1f3 * buildtools/linux64: git_revision:fc722252439ea3576c241773f5ee14eb8470e2ef..git_revision:a2e2717ea670249a34b0de4b3e54f268d320bdfa * buildtools/mac: git_revision:fc722252439ea3576c241773f5ee14eb8470e2ef..git_revision:a2e2717ea670249a34b0de4b3e54f268d320bdfa * buildtools/win: git_revision:fc722252439ea3576c241773f5ee14eb8470e2ef..git_revision:a2e2717ea670249a34b0de4b3e54f268d320bdfa * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4520417968..1fde7f2264 * third_party/android_build_tools/manifest_merger: fPIg5SQ9nbj982soSMoZlTPVfZ2zVKZRusg-r0ONCxUC.._BpuezAM4mQeQj5WNI7H6zkNx4nV2d8uGzcoJOlLQJcC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/64c1253280..905de831f6 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/75329f416d..31bf504bc3 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2bc81cdf4f..68c511349d * third_party/fuchsia-sdk/sdk: version:17.20240120.1.1..version:18.20240127.1.1 * third_party/r8: K1NPmXz0aZCAGGtC5UESEmqwT5-x6QNNb0Jo0umsez4C..C9JntVaHiVuPur-3AdTgT9LdF-92xV5S53GPX-ahZsMC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d7f25fb1d4..13de3f85f1 No update to Clang. Bug: None Tbr: romanl@google.com,syoussefi@google.com Change-Id: Ic4947fc49d5b5a035c41e56b19fff84ab6072c91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5243712 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 9318a143 2024-01-11T15:58:44 Add __asm__("") statements to loop bodies in MSL. This prevents erasure of infinite loops during optimization passes. Bug: chromium:1513738 Change-Id: I84a305b5e7fd824531d9e3ebae5496ddec030bac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5191166 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Shahbaz Youssefi 0beed753 2024-01-26T12:42:28 Work around MSAN complaint with pool allocator Cache a member variable accessed after destructor so MSAN doesn't consider it having an uninitialized value. Bug: b/314793573 Change-Id: I45044e0801ae12a80301240b4de05e9cae03dcc1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5238220 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Chris Forbes 6367f541 2024-01-25T10:16:04 Vulkan: supply YcbcrConversionDesc earlier Previously, the AHB import path would allow ImageHelper to build a bogus YcbcrConversionDesc (in initExternal) and then later overwrite it with what it wanted. The intermediate state was not necessarily valid, and could cause assertion failures and VVL errors. Instead, have ImageHelper clients provide the conversion they want upfront. In the non-external case, build an appropriate conversion for formats which need them, before delegating to initExternal. Bug: b/315387961 Change-Id: Icc8f561bb2de0289ceec56d41978b8c4651a47a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5232769 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Chris Forbes <chrisforbes@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll eaf15b35 2024-01-26T16:35:26 Manual roll VK-GL-CTS from 03517cba39ae to fe0d0f90469f (2 revisions) Manual roll requested by romanl@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/03517cba39ae..fe0d0f90469f 2024-01-26 marcin.hajder@mobica.com Fix for deqp-runmode=stdout-caselist 2024-01-26 marcin.hajder@mobica.com Fix for texture_border_clamp to check if texture format is filterable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ia319ccfeb0b6002b92edd79791aab215716f6781 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5241043 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bani Singh 66517b0b 2024-01-26T18:18:05 Revert "Use ADC for GCE VM" This reverts commit 2dfbedee7d4f9c84f278818217a1fa0908d6cbee. Reason for revert: May be causing credentials errors Original change's description: > Use ADC for GCE VM > > In case of bot, use ADC instead of automatic_auth which will in the > future be done through credshelper and will not support ADC. > > Test: Locally ran script with no errors, and tested that running > autoninja respects environment variables > > Bug: b/319246651 > Change-Id: I58a282047d387ef54659dbb195cc117b3459d2e8 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5212967 > Reviewed-by: Roman Lavrov <romanl@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Commit-Queue: Cody Northrop <cnorthrop@google.com> Bug: b/319246651 Change-Id: I315651d99e937c331183b28ea7d7d665b43fc6d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5236466 Auto-Submit: Bani Singh <banisingh@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Geoff Lang f405b999 2024-01-19T11:18:49 Make RefCountObject use atomics for the reference count When the context share lock is disabled it is possible for races with EGL Image reference counting causing the EGL Image to be deleted. egl::Image already protects its members with a mutex but the siblings also hold a reference to the egl::Image, if siblings are added and removed at the same time, writing to the ref count races and the egl::Image can be deleted while still being referenced. Bug: angleproject:6957 Change-Id: I3da8691136b6dbcffb2094187c81cafda077e50d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5214270 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 6c23a423 2024-01-26T08:37:12 Tests: skip one of dEQP texture_border_clamp tests on SwS dEQP-GLES31.functional.texture.border_clamp.range_clamp.linear_float_color Bug: angleproject:8507 Change-Id: Ie332c086ca9b145187f4461f646a5e534d323054 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5238216 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Alexey Knyazev 02aa605a 2024-01-25T00:00:00 Metal: Include only the <metal_stdlib> header Removed the logic for generating individual include macros as <metal_stdlib> provides all functions. Fixed: angleproject:8504 Change-Id: I8c83ca8cc2443a4b64e4e022a3a694c7643be569 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5237274 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
angle-autoroll 8034d09c 2024-01-26T13:23:26 Manual roll VK-GL-CTS from 0f6fd3de8110 to 03517cba39ae (14 revisions) Manual roll requested by romanl@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/0f6fd3de8110..03517cba39ae 2024-01-26 rgarcia@igalia.com Test short lines with mesh shaders 2024-01-26 michal.jakubek@mobica.com Unify deFloat with tcu::Float16 2024-01-26 piotr.byszewski@mobica.com Improve binding model shader access tests 2024-01-26 rgarcia@igalia.com Test indirect dispatches with different alignments 2024-01-26 piotr.byszewski@mobica.com Initialize monolithic pipeline layout 2024-01-26 mnahiyan@amd.com Fix access flags for dynamic state resolve tests 2024-01-25 ivan.briano@intel.com Remove extended_usage_bit_compatibility with image_format_list tests 2024-01-25 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/vulkan-cts-1.3.8 2024-01-25 lorenzo@khronosgroup.org Update Vulkan headers to public version 1.3.276 2024-01-25 lorenzo@khronosgroup.org Allow VK_KHR_load_store_op_none 2024-01-22 lorenzo.dalcol@gmail.com Allow Vulkan CTS 1.3.8.0 2024-01-19 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_load_store_op_none' into vulkan-cts-1.3.8 2024-01-19 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_line_rasterization' into vulkan-cts-1.3.8 2024-01-19 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_index_type_uint8' into vulkan-cts-1.3.8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I8777b52f11b06a4573f8c5a5dc185b4ac78d33de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5239634 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Matthew Leibowitz 36013d99 2024-01-24T01:21:10 Improve build for UWP/Windows 10 These changes update the code for more modern compilers. The changes include: A) Not using deprecated APIs When Windows 8.1 was removed in commit 39b110184e2675afbfda1fd70b10ca112127ae74 the code was not updated to use the new APIs and still use the things that should not be used: > DisplayProperties may be altered or unavailable > for releases after Windows 8.1. Instead, use > DisplayInformation. B) Use correct casting There was also some changes in commit 5eadaf85b42ab1cbb1efcda558db58a3fe5a446a to properly cast from EGLNativeWindowType to IInspectable*, but this was not all of the cases. C) Prepare for WinUI3 There is another change that moves types into a using to reduce verbosity as well as make it easier/cleaner to build for WinUI/Windows App SDK. Bug: angleproject:8496 Change-Id: Ia11b7f92cb4abc524ab8316125e80a22898a8f6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5232157 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0