kc3-lang/angle

Log

Author Commit Date CI Message
Amirali Abdolrashidi c51259ec 2023-12-14T15:58:56 Vulkan: Ignore tex coord at draw if tex disabled In GLES1, it is possible to disable texture rendering in some cases. It is done using glDisable(GL_TEXTURE_2D). In that case, if TexCoordPointer has been enabled in the client state prior to disabling the texture, its data should no longer be used, especially if the primitive changes to use more vertices. In that case, there is a risk of unauthorized memory access. In this CL, the active vertex attributes are updated accordingly if texture is disabled using the aforementioned API call. * Updated GLES1 renderer to ignore TexCoordPointer if texture has been disabled. * Added GLES1 tests for tex coord pointer, including tests to make sure that tex coord pointer is no longer used if the texture is disabled using glDisable(), and that it is used again when texture is enabled using glEnable(). * To ensure that tex coord pointer is not used, the test draws using enough vertex data that would exceed the texcoord array size, which can trigger segfault if accessed. Bug: b/310688730 Change-Id: I5d259c83a172cc1a11733c0b42c2f9b02c9b2967 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5124259 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
angle-autoroll 016b1033 2023-12-20T17:46:45 Manual roll vulkan-deps from 06ba2decfb32 to 9c3a33aed0ec (44 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/06ba2decfb32..9c3a33aed0ec Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/a7785ea1ff..c155f881ee * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e03c8f5c8e..f0cc85efdb * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/41263fc5aa..80207f9da8 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/979242bdd7..40633a61aa * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/8f6c0e51dc..b42addf414 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/b89f4b8415..524f8910d0 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0c6e58c7f0..ea496a3de8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com,ynovikov@google.com Change-Id: Ibe87c94ba0e647022b6888fa3bc98bb8e445f1dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5141506 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 0aaa8de9 2023-12-19T23:23:40 Vulkan: Fix memory tracking vs external texture acquire ... with a layout of GL_NONE. Bug: angleproject:8464 Change-Id: I94690c5693c5bcb6d510e4a27097206f0da58a41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5138656 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi e9c0241d 2023-12-19T10:23:13 Vulkan: Rely on Vulkan 1.1 entry points in tests Some KHR entry points that were promoted to Vulkan 1.1 no longer seem to be loadable with their KHR symbols. Bug: angleproject:8464 Change-Id: Id5417e5b047e6bd34d144fead518f771c17658e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5135676 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6951508b 2023-12-19T19:30:05 Manual roll vulkan-deps from de368ee1bf18 to 06ba2decfb32 (1 revision) Manual roll requested by ynovikov@google.com Suppress SYNC-HAZARD validation errors in vkQueueSubmit(), enabled by https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/7129 https://chromium.googlesource.com/vulkan-deps.git/+log/de368ee1bf18..06ba2decfb32 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/eebe1dfcef..0c6e58c7f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: b/316013423 Change-Id: Id63a3ddd4615f8a520b68588db4520d30a687598 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5137081 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 82c95b30 2023-12-20T07:01:16 Roll Chromium from 9a3d5ea818e6 to 71a57680b06d (589 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9a3d5ea818e6..71a57680b06d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b3e01488a0..f2f5a10150 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5fe189d3b5..e8e9f90e58 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a478c1743a..edab5262fa * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/23118cc3c3..49c8dd3237 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/d855d8bc2e..715a7b8509 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/3bb3983367..3cafb40647 * third_party/r8: FxJgCW2a6MbqM5WkyXAxu91pykj7_QAYNerG9ettPPAC..7Bh-YvMIvXQguOKifHK0dPByTf-YalKg29UInFS7lLAC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/dbe34d7b76..289bde07a0 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/13930ba900..9f03ce32b7 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I1d3b182b29aee878ef43cf21612bc9de1c0a5ebd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5139198 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 5a062a39 2023-12-14T21:15:59 Do not update the vertex attribute limit on divisor change The effect of the divisor on the vertex attribute limit is accounted for in StateCache::updateVertexElementLimitsImpl since https://chromium-review.googlesource.com/c/angle/angle/+/5101508, and so the vertex attribute's mCachedElementLimit is now independent of the divisor. Bug: angleproject:8448 Change-Id: I3f76986d6b8d3ba6b0ebd955f9a26854ee8c20e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5122996 Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 9f148c41 2023-12-14T00:00:00 Metal: Fix triangle fan indices generation * Ensured that the second index is preserved when skipping leading primitive restart values * Restricted the search loop to the index count * Ensured that draw calls are skipped when the generated index buffer is empty to avoid Metal validation errors, also for line loops Fixed: angleproject:6458 Change-Id: I3194eb9db3e7e225448901edce167a2091563cd5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5132092 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
angle-autoroll e3600abb 2023-12-19T15:55:05 Manual roll vulkan-deps from 510bed662233 to de368ee1bf18 (34 revisions) Manual roll requested by ynovikov@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/510bed662233..de368ee1bf18 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/9a35abff55..a7785ea1ff * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6b4f0c9d0b..e03c8f5c8e * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/19a863ccce..41263fc5aa * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0133778cb1..979242bdd7 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/1ee9eea9f1..8f6c0e51dc * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/4a89051018..b89f4b8415 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/3d6bdd9dc7..eebe1dfcef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,geofflang@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com,ynovikov@google.com Change-Id: I22cec01f0906202cfb0b3ae9b15f6da6e2bb574f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5132325 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 66da618c 2023-12-19T16:25:35 Skip UniformBufferTest.BufferBlockBindingChange on Mac NVIDIA GL Flaky Bug: angleproject:8465 Change-Id: Ic923a3af4937a346fdba0b80d486a9ed8e46402e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5136275 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 80db7c4b 2023-10-17T10:03:06 Vulkan: Remove fixed VU suppressions Bug: angleproject:5309 Bug: b/175584609 Change-Id: I8f952a1feb235b6bd060b5fe0b89c01fde6f84be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4946592 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 59d0e50b 2023-12-19T07:34:27 Roll Chromium from 511b16a33b04 to 9a3d5ea818e6 (459 revisions) https://chromium.googlesource.com/chromium/src.git/+log/511b16a33b04..9a3d5ea818e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ad3bfe9769..b3e01488a0 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a481c9ee1a..5fe189d3b5 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8c03186e63..a478c1743a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2298e63899..23118cc3c3 * third_party/fuchsia-sdk/sdk: version:17.20231211.2.1..version:17.20231218.3.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/28d7125795..d855d8bc2e * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c7c5649e8b..8806fb8bb2 * third_party/r8: w4FEa7Y-q3MIsKwjR0LC_-fPnANe8DlIIAWD_pMF5z0C..FxJgCW2a6MbqM5WkyXAxu91pykj7_QAYNerG9ettPPAC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/562a4372d1..002f75df25 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/d888191c19..9d7648a0c7 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ebb8297256..13930ba900 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I110ef3adbeec45dc0126a1c7b497de9acc8103bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5133385 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang bd5dce9a 2023-11-21T15:39:04 Metal: Use MTLEvent instead of MTLSharedEvent when possible Refactor mtl::Sync to be abstract and have multiple implementations using either MTLEvent or MTLSharedEvent. Use MTLEvent in all cases except for EGL Syncs when the user sets the sync type to EGL_SYNC_METAL_SHARED_EVENT_ANGLE. Determine completion of the sync object by watching for completion of the command buffer where the event's signaling was enqueued. Avoid any sleep loops by waiting on a condition_variable which is notified when the completed queue serial is updated. Forked from CLs by sky@ and kbr@ Bug: angleproject:8153 Change-Id: I4547444b596366496c811cb9954872b85ab14ad8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5133706 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Shahbaz Youssefi 4bf40237 2023-12-18T15:24:15 GL: Fix missing glUniformBlockBinding handling When a program is current and this call is made, the program is made dirty so that the GL backend reacts to this call. Prior to https://chromium-review.googlesource.com/c/angle/angle/+/4922969, the program was made dirty when its executable was installed as well (if it had any UBOs dirty), but that change removed it. As a result, if this call was made while the program was _not_ current, the GL backend would miss processing it. This call ensures that the appropriate dirty bit is set when the program is made current again. This revealed a bug in the Vulkan backend where sometimes the executable's dirty bits would not get reset. This was benign but fired an assertion, and is fixed in this CL as well. Bug: chromium:1511506 Change-Id: Iae86ba0aa5b8f9e4f20dd6df6002d37e405280e7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5123005 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Yiwei Zhang 1e4c4c76 2023-12-18T19:35:13 Vulkan: avoid disabling explicitlyCastMediumpFloatTo16Bit for venus We disabled it to work around below legacy skia cts: CtsSkQPTestCases org.skia.skqp.SkQPRunner#gles_gradient_many_stops The test no longer exists in newer skia cts. Meanwhile, we have to drop the workaround for other precision issue on Mali-G52. Bug: b/316474995 Test: dEQP-GLES2.functional.shaders.algorithm.rgb_to_hsl_vertex Change-Id: I18394595632d05657e96f8b9c9675b4dd959d92b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5133372 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Yiwei Zhang <zzyiwei@chromium.org>
angle-autoroll d704273d 2023-12-18T10:01:40 Roll SwiftShader from 77be35e337bb to 2fa7e9b99ae4 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/77be35e337bb..2fa7e9b99ae4 2023-12-15 dnfield@google.com Support a static build rule for swiftshader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Id2376205e9c18e69474783b6de2566c12eb8ec9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5129891 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 466e0b5a 2023-12-18T07:47:04 Roll Chromium from bdc028a23412 to 511b16a33b04 (571 revisions) https://chromium.googlesource.com/chromium/src.git/+log/bdc028a23412..511b16a33b04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/caa7a57c21..ad3bfe9769 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9325d4d500..a481c9ee1a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/172dd7d235..8c03186e63 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/99f5e4d09e..28d7125795 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/90769c8b0c..562a4372d1 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/fb38cd74c6..d888191c19 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0da27905d2..e592c0f866 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/465ab5e2d6..ebb8297256 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Ia4065386ed24793410f0a185883f76b59fe3280c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5130886 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 40f4de8f 2023-12-15T10:17:32 Vulkan: Ensure we use cached memory for readPixels stagingBuffer Previous CL crrev.com/c/5112759 does not solve the performance issue for ChromeOS. The reason is that on more recent intel GPU, there is no hostVisibleCachedCoherent heap. When we allocate staging buffer, we specify CachedCoherent as the preferredFlags instead of requiredFlags. This means we still end up getting UncachedCoherent since VMA tries to respect coherent bits as first priority. This CL Changes CachedCoherent to CachedPreferCoherent, and made Cached as required bit, thus ensures the memory allocated is cached. Since coherent bit may not be honored, thus we have to call invalidate/flush (which underline implementation will check the bit and early out if no need). Somehow on ARM GPU using cachedNonCoherent staging buffer causing many test failures, even though we do call invalidate() after allocation, and tests pass on all other GPUs. It almost indicates ARM driver have a bug with invalidate() that it is not doing expected. But before I can be sure and fixed, I added feature bit to keep ARM the old behavior, which uses UnCached memory for readPixels which should suffer the performance as well. Bug: b/315836169 Bug: b/310701311 Change-Id: I1eec6105ce74275faa893b0206be8470f0cde72f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5122318 Commit-Queue: Charlie Lao <cclao@google.com> Auto-Submit: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Stephen White a950f005 2023-12-06T18:58:35 Move compressed format validation to Vk backend. Add test to call glCompressedTexSubImage3D() from a pixel unpack buffer. This currently fails on OpenGL. Bug: angleproject:8449 Change-Id: I863b602e39a14878af8745ff62b408bdd879bc98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5100348 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Austin Annestrand 80893f26 2023-11-30T16:57:15 OpenCL: Remove unneeded impl getters Some of the OpenCL backend (impl) getters are not needed. These are the size query for image creation, and CL source retrieval for program objects not created from source. Bug: angleproject:8438 Change-Id: I76b39b75f1ae76ec0c3c94d5715632cb9dd4900a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5078243 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 66d29149 2023-10-16T12:43:43 OpenCL: Add scaffolding to renderer/vulkan code Start off ANCLE (OpenCL on ANGLE) with backend scaffolding code with placeholder API error returns until they are later implemented. Bug: angleproject:8377 Change-Id: I223d3482cce097ccb298e121fc03ec416e8958fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4950556 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 18a68f6d 2023-12-07T16:23:10 Fix vertex attribute limit check Bug: angleproject:8448 Change-Id: Ie5d2b71f0be86b31ec74a1d55501b60a25245668 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5101508 Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Austin Annestrand 5e619b21 2023-11-29T14:56:59 OpenCL: DoubleFpConfig query validation fix There is currently a minor bug in the CL validation code that unconditionally validates "cl_khr_fp64" extension string when client queries for fp64 support. This is correct behavior for OpenCL 1.1 and lower. However for OpenCL 1.2 and greater, this became a core query for clGetDeviceInfo via "CL_DEVICE_DOUBLE_FP_CONFIG". Thus, on some 1.2 and greater implementations (ANGLE CL passthrough), this extension string wouldn't be specified since its a core API query in that case - and validation check will incorrectly fail via: ANGLE_VALIDATE_EXTENSION(info.khrFP64) Fix is to conditionally check this for the appropriate CL versions. Bug: angleproject:8436 Change-Id: Id2bb5699fa523061d738af19edb465a78dbd880d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5075775 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 3439e421 2023-12-15T11:37:53 Vulkan: Remove AHB workaround for camera app This is now fixed in camera app main branch. The workaround is removed here. Bug: b/239181279 Change-Id: I782baf7a42a8c9a897f1947d8b2f6feba606ce29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5126931 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand c1aaa313 2023-11-29T18:54:06 OpenCL: Updated autogen script for updated CL error handling Part 3 of Issue 8435: Updated entrypoint autogen script for CL to: - Remove errorCode param for all CL APIs returning CL objects - Init CL error TLS object for all CL APIs prior to calling ANGLE FE Bug: angleproject:8435 Change-Id: I4f1784c0bda393d5f3126f205f17ec24662424ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5075774 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand ed7c31c7 2023-11-29T18:31:43 OpenCL: Replace error-passing APIs to use angle::Result Part 2 of Issue 8435: This part replaces existing error handling for all CL APIs that return CL objects to now use "angle::Result". Bug: angleproject:8435 Change-Id: I75e41c7cbb06220cabec7cc9f9cb5107a3b6bd6d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5075773 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Gowtham Tammana cd56b248 2023-12-08T15:36:17 third_party/clspv: Add GN build files The clspv project uses CMake for build. Adding support for GN build in here. The build is currently setup to generate linux/x86 and android/arm64 artifacts for now and relevant gn files are placed in `third_party/clspv` location. Bug: angleproject:8369 Change-Id: Iec7ef1916617a8b8a93324ff7302f89bd571b814 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106594 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll dea00fff 2023-12-15T16:20:42 Roll VK-GL-CTS from ecdec25ff753 to fa3dcc95cfc0 (15 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/ecdec25ff753..fa3dcc95cfc0 2023-12-15 rgarcia@igalia.com Test redundant binds with dynamic and static state 2023-12-15 Tyler.Schneider@amd.com Ray Query stress tests cases: dEQP-VK.ray_query.stress.* 2023-12-15 boris.zanin@amd.com VK_KHR_cooperative_matrix - multicomponent 2023-12-15 rgarcia@igalia.com Test frag shader library with varying sample counts 2023-12-15 rgarcia@igalia.com Remove many ESO and GPL variants without significant coverage loss 2023-12-15 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main 2023-12-15 ziga@lunarg.com Fix ds formats in depth_stencil_resolve tests 2023-12-15 gleese@broadcom.com Remove data for tests that don't exist 2023-12-15 cturner@igalia.com Fix missing queue selection logic in several transfer_only tests 2023-12-15 amber@igalia.com Make extra padding draws in the indirect draws tests produce incorrect output. 2023-12-15 lorenzo@khronosgroup.org Add pass/fail results for each session in cts-run-summary.xml 2023-12-15 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2023-12-14 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main 2023-12-12 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main 2023-12-10 ziga@lunarg.com Update vulkan-docs and merge dev/VK_KHR_vertex_attribute_divisor into main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: solti@google.com Change-Id: Ic9a182666ef032f41ce4c6e0910fdf692b8a9783 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5126168 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a1789bef 2023-12-15T07:01:42 Roll Chromium from a7af25804d20 to bdc028a23412 (543 revisions) https://chromium.googlesource.com/chromium/src.git/+log/a7af25804d20..bdc028a23412 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/87e1b716a4..caa7a57c21 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/6ba5182022..9325d4d500 * buildtools/reclient: re_client_version:0.124.1.13f78cc-gomaip..re_client_version:0.125.0.f3883c2-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/301a3438a2..172dd7d235 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/15a737bc5c..8c91f1a73b * third_party/android_build_tools/manifest_merger: _2qAeWRS5XnDom8pAt4e7GuEof_KB86zQO0Lnr5uQBQC..Wk3Q4wN95_lB58e1sRWAgXljF18hHuJI60JbyPmqXVoC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/396204ce89..2298e63899 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6444de14d1..390005586b * third_party/kotlin_stdlib: QEHg036Jc2HWG4-ao7usl1QUexRidGFFSgqqWUpmK-YC..KIU1zubKhCbwM8mZNhGe3NriMr5QZRo3mHdOu4rAYowC * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/dbea847672..99f5e4d09e * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/6bd25883ff..c7c5649e8b * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/b66828a72c..fb38cd74c6 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3beb3d18f0..465ab5e2d6 No update to Clang. Bug: None Tbr: solti@google.com Change-Id: Idc24f32f8d46d3b06247fc52d0c6bdddb9e9a278 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5124330 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand a9512a9f 2023-11-29T14:56:29 OpenCL: Replace error-return APIs to use angle::Result The motivation of converting existing CL APIs using "cl_int errorCode" to now use "angle::Result" is for better interop with internal ANGLE plumbing/abstractions. To facilitate this, we now make use of a TLS errorCode object that we set internally and read from entrypoint/stubs layer so that we can propagate back to user. Bug: angleproject:8435 Change-Id: I7c2a786019c33c56649be4b6e8b61bc318497bb1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5075772 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Peiyong Lin fca3eb6b 2023-12-12T23:00:41 Refactor ANGLE settings UI. This patch refactors the ANGLE settings UI to make sure it aligns better with the settings global variables. This patch: 1) moves all ANGLE rule parsing logic to its own class, the parsing will only parse the rule and store them, it currently does not set the settings global variables; 2) removes the global enablement as it is now an option in Developer options and that one has better guarding condition; 3) refactors the logic to query all packages in the system, instead of constructing them with raw package name, use application name to allow a more user-friendly UI, and also allow to toggle for system applications. 4) adds two new entries to allow building ANGLE apk without any ANGLE libraries; 5) adds a README.md file to document the design. 6) removes unused functions and variables and minor renames. Bug: b/293503000 Test: manual Change-Id: I7287935791c00040b0eacba7dce3e4df5eb4de3e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5118135 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Peiyong Lin <lpy@google.com>
Alexey Knyazev 8f966559 2023-12-07T00:00:00 Metal: Fix matrix vertex attributes with mixed sources Updated VertexArrayMtl::setupDraw to support matrix vertex attributes that use current and array values simultaneously. Simplified the helper function. Fixed: angleproject:8456 Change-Id: I09a26a978cda4b9ac3747325ad571d5ad2fff72d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5116500 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Quyen Le <lehoangquyen@chromium.org>
angle-autoroll bb51167b 2023-12-14T07:01:51 Roll Chromium from 9197ec952f31 to a7af25804d20 (593 revisions) https://chromium.googlesource.com/chromium/src.git/+log/9197ec952f31..a7af25804d20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/3f2733bfc4..87e1b716a4 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/8d75795be6..6ba5182022 * buildtools/linux64: git_revision:7367b0df0a0aa25440303998d54045bda73935a5..git_revision:85944ebc24a90ec1e489e85a46fdc68542c3146f * buildtools/mac: git_revision:7367b0df0a0aa25440303998d54045bda73935a5..git_revision:85944ebc24a90ec1e489e85a46fdc68542c3146f * buildtools/win: git_revision:7367b0df0a0aa25440303998d54045bda73935a5..git_revision:85944ebc24a90ec1e489e85a46fdc68542c3146f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/23d202a3d2..301a3438a2 * third_party/android_build_tools/lint: HauAZeOm40GKv93v51MaoIilRbuPDo29QhN98r7kQaMC..pvFK7MtH5IsrWhv7D-JOyKc5CPgDCyDAWjN_DbAFjVwC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/c2cfac4228..7a76422eef * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/bdaddf92ea..396204ce89 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/18bb70aed6..6444de14d1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/1f70899ab6..dbea847672 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d5e7c425e0..6bd25883ff * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/278e5fbafc..3bb3983367 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/41759e11ec..e1ae7a6663 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/69a2e01edd..90769c8b0c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3ccfff74a0..dbe34d7b76 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/884774321e..802db79a6a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2eeaae46cb..3beb3d18f0 Clang version changed llvmorg-18-init-12938-geb1d5065:llvmorg-18-init-14420-gea3a3b25 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/3ccfff74a0d0cda8ddf2612cc09217278fb018bc..dbe34d7b760dc429ddc938fa19b92c2b330a72ec/scripts/update.py Bug: None Tbr: solti@google.com Change-Id: I3a511ea37be475f736fe570730bd14a9e0ad2b09 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5121652 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yiwei Zhang 524bcb8e 2023-12-13T20:21:38 Vulkan: avoid forcing preferSubmitAtFBOBoundary with Venus It turns out benefiting Venus atop ARM while hurting in a non-trivial way on old Gen Intel due to execbuf overhead. Bug: b/314847707 Test: 2%+ gain for trex on ANV on CML Change-Id: I61eb18a05e94c97ee6a4d70f98ae30423155e632 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5118128 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Solti c8604e97 2023-12-13T19:48:16 suppress VUID-VkVertexInputBindingDivisorDescriptionKHR-divisor-01870 Unblock the autoroller first Bug: angleproject:8454, b/316176944 Change-Id: I7f692a81e7a8b0189f83ce6f00e0cec6e2d7e2b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5118126 Commit-Queue: Solti Ho <solti@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Solti Ho df4d9667 2023-12-13T18:28:53 Revert "Optimize HandleAllocator for fast ID churning." This reverts commit b25ffe5a9775cc912a304c8552dd9c097a93420a. Reason for revert: b/316162914 Original change's description: > Optimize HandleAllocator for fast ID churning. > > Instead of calculating ranges of IDs and the overhead with updating > them every allocation/release, store a released ID list in a small > FastVector. > > Optimize the allocate path for the "good case" of no reserved IDs so > that it either pops the last released ID or incriments a next value and > returns it. Release has a similar cost of just a push_back when there > are no reserved IDs. > > This adds a small fixed memory cost due to the FastVector and a dynamic > memory cost of mReleasedList having up to N elements where N is the > maxmimum total handles allocated at one time. > > Bug: angleproject:8434 > Change-Id: I7c5aa126b5303c105cd2464d0d0933b922cc2b8f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5101509 > Reviewed-by: Charlie Lao <cclao@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:8434 Change-Id: Ide43d787b6942cc6b622e3b5d938bfbbbf3b3ebb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5120277 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuly Novikov 1c9ac273 2023-12-13T17:34:19 Remove mentions of "no GTest" dEQP targets in docs. Suites removed in https://chromium-review.googlesource.com/c/angle/angle/+/3173251 Bug: None Change-Id: I59ffc95f3772f8d4ea89133083fe2612b1d5ee39 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5117260 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll bdd3a778 2023-12-13T07:00:03 Roll Chromium from fd8978318166 to 9197ec952f31 (617 revisions) https://chromium.googlesource.com/chromium/src.git/+log/fd8978318166..9197ec952f31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2711b553c3..3f2733bfc4 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d7e0ec1306..8d75795be6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a5c15ce1b6..23d202a3d2 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/c4a82efb2f..c2cfac4228 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d3f7f448d3..bdaddf92ea * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/aa65be9856..18bb70aed6 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a88e6d6daa..1f70899ab6 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/dd5fc1316c..69a2e01edd * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d689bae2fa..2eeaae46cb No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I6db743e5a70f394b9c485c7e1bd717f49a3710ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5118122 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gowtham Tammana cdacdf63 2023-12-11T11:18:34 llvm: Move it to third_party/llvm/src Clone the llvm_project into third_party src location to make for README.chromium and related files. Bug: angleproject:8369 Change-Id: I625eefd8fd883a956985d217f33274ebe7fbe7ed Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5111802 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang b25ffe5a 2023-12-07T16:36:29 Optimize HandleAllocator for fast ID churning. Instead of calculating ranges of IDs and the overhead with updating them every allocation/release, store a released ID list in a small FastVector. Optimize the allocate path for the "good case" of no reserved IDs so that it either pops the last released ID or incriments a next value and returns it. Release has a similar cost of just a push_back when there are no reserved IDs. This adds a small fixed memory cost due to the FastVector and a dynamic memory cost of mReleasedList having up to N elements where N is the maxmimum total handles allocated at one time. Bug: angleproject:8434 Change-Id: I7c5aa126b5303c105cd2464d0d0933b922cc2b8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5101509 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev e172c104 2023-12-07T00:00:00 Metal: Fix temporary array initialization Ensure that temporary array declarations have literal initializers to bypass Metal compiler issues. Fixed the following tests on Apple silicon: dEQP-GLES2.functional.shaders.indexing.tmp_array .float_const_write_dynamic_loop_read_fragment .float_const_write_dynamic_loop_read_vertex .float_const_write_dynamic_read_fragment .float_const_write_dynamic_read_vertex Fixed: angleproject:7058 Change-Id: Id4a360b0a5a15da43ce4626c6dfe03556cc9d0f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5115898 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Solti 5e63cee5 2023-12-12T20:59:44 update e2e expectation Bug: b/316013423 Change-Id: I4a70fdc0b38d8e412c0ca1035564aecb1f1dbc32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5118119 Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Solti Ho <solti@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 35e49df7 2023-12-11T21:16:57 FrameCapture: Skip eglQueryContext We don't use the return value of the call, so it can be omitted from the capture. Test: Flip capture Bug: b/308208067 Change-Id: Ib3dfea2b7bd5638092bd691e66c6b9e2b6fabf15 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5112776 Reviewed-by: Mike Schuchardt <mikes@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 9b66848f 2023-12-11T20:54:30 FrameCapture: Handle context Reset with no calls The code was assuming that setDefaultResetCalls adds reset calls for an entry point, but it has logic for skipping if the current state is already default. This CL checks to see if we added any calls for the entry point before trying to iterate through them. Test: Flip capture Bug: b/308208067 Change-Id: I8a214b0eb0df068d6b3172c0ca1406f6751f91ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5114271 Reviewed-by: Mike Schuchardt <mikes@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Kieron Josephs 282a5fb4 2023-12-08T15:53:17 Fix out-of-bounds vector index when using SPIR-V precision fixer Accessing mVariableInfoById after id has been replaced by the precision fixer was causing an out-of-bounds access. Running SpirvVaryingPrecisionFixer::modifyEntryPointInterfaceList before SpirvSecondaryOutputTransformer::modifyEntryPointInterfaceList was causing an out-of-bounds access for the same reason. Bug: angleproject:8452 Change-Id: I54f7f105ec2fb5aeb3e4234e8e3e052bcc42977c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5105193 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang f8fae1ff 2023-12-08T13:20:36 Validate Uniform variable limits with each iteration VariablePacker would loop over all variables and sum up the total row counts before validating. Each variable can take hundreds of rows so it is possible to overflow the counters before validating them. Validate the limits with each iteration and early-out when the limits are exceeded. https://bugzilla.mozilla.org/show_bug.cgi?id=1864587 Bug: chromium:1864587 Change-Id: Ic235ada1516a0d5a9948d82b22f6316a037c09ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106408 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 398cfb4b 2023-12-12T08:09:41 Roll Chromium from f9f8b1a54ff6 to fd8978318166 (587 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f9f8b1a54ff6..fd8978318166 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e2ef5faece..2711b553c3 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/48eb5d0b33..d7e0ec1306 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8a289204b0..a5c15ce1b6 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6edbd6b5ca..d3f7f448d3 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1714cc6e5a..aa65be9856 * third_party/fuchsia-sdk/sdk: version:16.20231129.1.1..version:17.20231211.2.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/16665d119a..a88e6d6daa * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/147f175921..b66828a72c * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bc59d8d3cf..d689bae2fa No update to Clang. Bug: None Tbr: solti@google.com Change-Id: I73fb0cd578d9f8ff67e30022f63bb7c6e0287776 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5114867 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao de591cff 2023-12-11T13:15:30 Vulkan: Add CachedCoherent staging buffer Right now if we allocate a coherent staging buffer, it always uncached. I believe the reason it picked uncached is that most usage for staging buffer is data flow from CPU to GPU. CPU only sequentially write into staging buffer. Uncached may has better performance here due to write combined. But this performs horrible if CPU ever read from it. This CL adds a CachedCoherent staging buffer and let staging buffer use that for coherent memory. UncachedCoherent is currently not used, but I still kept here in case we find regression for certain type of usage. Bug: b/315836169 Change-Id: Ica331914c1f4729baa9d2eab048dc3099a2887b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5112759 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Alexey Knyazev 5c8cb8a6 2023-12-07T00:00:00 Update WebGLReadOutsideFramebufferTest tests Enabled robust resource init for these tests as they access out-of-bounds values. This flag is required to pass some of the tests on Vulkan backend. WebGL clients always set it. Fixed subresource index computation on D3D11 to pass CopyTexSubImage3D with 3D textures there. Added a similar test for 2D array textures. Bug: angleproject:4092 Fixed: angleproject:4136 Change-Id: I191c6df3c672e583568aadecac5885da015cfa8b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106511 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Geoff Lang f035cdb4 2023-12-11T13:45:22 Fix SyncID initializer. Requires brace initialization to work on all compilers. Bug: angleproject:8430 Change-Id: I6e79f2446f057bf9eaaaecfc9f82b26320c5ba56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5111600 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop 80fca933 2023-12-08T18:30:01 Tests: Add Thimbleweed Park trace Test: angle_trace_tests --gtest_filter="*thimbleweed_park*" Bug: b/315540661 Change-Id: I78d45d51531b81dbe05427db0dff4dc685b98cbc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106864 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
angle-autoroll 5259efe8 2023-12-11T07:48:58 Roll Chromium from 27249fedce4b to f9f8b1a54ff6 (725 revisions) https://chromium.googlesource.com/chromium/src.git/+log/27249fedce4b..f9f8b1a54ff6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6fdac9cc5e..e2ef5faece * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9a7b235810..48eb5d0b33 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1633d23fc7..8a289204b0 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/025aa883df..15a737bc5c * third_party/android_build_tools/manifest_merger: SdNR04V227YL22FMmKoS4AdLYwv6MJe8HBAZKNhXoCsC.._2qAeWRS5XnDom8pAt4e7GuEof_KB86zQO0Lnr5uQBQC * third_party/android_toolchain/ndk: XSjN84pHxBPX13CrUj3fQjEroncvFGGeJY9wDVEDswoC..NSOM616pOQCfRfDAhC72ltgjyUQp9lAWCMzlmgB18dAC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/69bde63990..6edbd6b5ca * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/05a55efaa9..1714cc6e5a * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4ab8957af3..16665d119a * third_party/r8: NyEPLS024hp8BUV5gx7DSIZzgCEWY-tevgRF8F1RWYgC..w4FEa7Y-q3MIsKwjR0LC_-fPnANe8DlIIAWD_pMF5z0C * third_party/siso: git_revision:acf6e472017229d73c507e50c8660c2d3a2021e0..git_revision:d8744c99a9e175e6c4569de0717bd8c53981ce0c * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/143660d186..147f175921 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/28cba3ec32..3ccfff74a0 * tools/luci-go: git_revision:1ea45c1829514ff20c476f083462e7b8fdfaf9ae..git_revision:0ffd60c8bd4fa542fb8d7c6a60ead9b96dc4387a * tools/luci-go: git_revision:1ea45c1829514ff20c476f083462e7b8fdfaf9ae..git_revision:0ffd60c8bd4fa542fb8d7c6a60ead9b96dc4387a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/2206f69ffd..0da27905d2 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e582bc0452..bc59d8d3cf * tools/skia_goldctl/linux: Zoe29KUyqS2oKisSjN23NSWAF2ABY3oXtvnMcmNgFf8C..gF8-tllaG53TS_NMzDyBBEon5i-UMVdhPADIv_39ZpsC * tools/skia_goldctl/mac_amd64: JqbiGnBxG8TPvCgKA3OOreiQ59Tn_xZoQOrWCP7rzOUC..5z5sg3DatlGfhGSg6wO3JTMyBofd0Dr9_bCBVDBfuJYC * tools/skia_goldctl/mac_arm64: 6U5_zURvPx2a03ZdJP9q_CPrUrIp3nU7x9u9a7ZWvFsC..tJys4TOPo-asafdTKs677RtNMEWct4WvJ4-SDmdqoYkC * tools/skia_goldctl/win: zEvgRWYnnTxGYfan6MIEqFyxyBfzgryl755RHBP98wYC..wCfWvHnVA6RiLbvH5NL3Pc51a6uladkFepTSj06s370C No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Idb8348aad9d291c7dc77f83be889637083d982e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5108441 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gowtham Tammana c8507249 2023-12-07T13:34:22 clspv: Move it to third_party/clspv/src Clone the clspv into third_party src location to make way for GN build files. Bug: angleproject:8369 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Change-Id: Id27d131ca7d5c0e941d9d770924587cdd3e5d8e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106593 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 7288507c 2023-12-07T00:00:00 Lift SNORM framebuffer completeness suppressions The CTS has been updated to allow GL_EXT_render_snorm exposure on OpenGL ES 3.0 contexts. Bug: angleproject:8048 Change-Id: If00df67dbcb541565ad236983b9d406a9f4444e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106510 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev bc301691 2023-12-07T00:00:00 Run PackUnpackTest on all backends Fixed negative zero serialization for capture/replay. Bug: angleproject:4092 Change-Id: Ic12a556f56e40064da8bf3a8ce7d01af92c7086a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106509 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev ede15b85 2023-12-07T00:00:00 Metal: Run multi draw tests Added ANGLE_INSTANTIATE_TEST_COMBINE_3. Used the new macro for multi draw and BVBI tests. Bug: angleproject:6963 Change-Id: If05800f92f670bf21b7ff889a2fb8bb30f62a488 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106508 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao d0eb968d 2023-12-08T16:11:46 Vulkan: Fix the AHB leak for AHB backed buffer object For client buffer backed OpenGL buffer object, we call InitAndroidExternalMemory which calls AHB acquire. But when buffer object is released/destroyed, we never call ReleaseAndroidExternalMemory, which end up leaking AHB. Bug: b/314791770 Change-Id: I693c74213e73008497a6dfeca93ea62e84c71352 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106599 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Charlie Lao <cclao@google.com>
Alexey Knyazev 0b0b4b22 2023-12-07T00:00:00 Avoid UB in VertexAttributeTestES3.DrawWithUnalignedData The test uses a signed normalized vertex attribute, which requires a floating point vertex input. Bug: angleproject:7001 Fixed: angleproject:7068 Change-Id: I97afc97b03a58130e0d6ee63ec7ee3e44f1e0230 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5105194 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 87eee12f 2023-12-08T22:01:29 Manual roll vulkan-deps from fb2389e52832 to 510bed662233 (8 revisions) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/fb2389e52832..510bed662233 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/e6b013a492..f349c91274 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a0308b56d8..0133778cb1 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/2feac58733..4a89051018 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/847a8a1f8a..3d6bdd9dc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I2105b0b769863e8e1c57f32ff5f609f9d313bdfc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106850 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f57ab75f 2023-12-08T16:45:00 Roll VK-GL-CTS from af594bc856e5 to ecdec25ff753 (11 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/af594bc856e5..ecdec25ff753 2023-12-08 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2023-12-08 gleese@broadcom.com Remove descriptions from all Vulkan test groups 2023-12-08 rgarcia@igalia.com Switch vertex input binding stride without binding new buffers 2023-12-08 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2023-12-07 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2023-12-07 ziga@lunarg.com Add MSRTSS tests where input attachment is not rendered to 2023-12-07 rgarcia@igalia.com Test null multisample state with alphaToOne disabled 2023-12-07 javed@igalia.com Add test for gl_PointSize clamping on max point size. 2023-12-07 ziga@lunarg.com Add vkMergePipelineCaches tests 2023-12-07 russellc@nvidia.com Add setVisible for VulkanWindowDirectDrm 2023-12-07 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I2dc00b81e97ed5d90ebf8d0dae44be571ee2044b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5105590 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang c27a4a1d 2023-11-27T14:44:07 Re-use EGL sync object allocations. Create a pool of EGL sync objects with their implementations that can be re-used. Update all backend implementations to support multiple calls to initialize/destroy. Pool size of 32 chosen through experimentation using Chrome. Bug: angleproject:8430 Change-Id: I86fea41aed35eddccc953efb3802bf5fdb7f3cb2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5063341 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 4732409f 2023-12-08T07:01:01 Roll Chromium from e567f1f8ed1d to 27249fedce4b (492 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e567f1f8ed1d..27249fedce4b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8b5921ef0c..6fdac9cc5e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/a19d89f939..9a7b235810 * buildtools/reclient: re_client_version:0.123.1.b4c22d0-gomaip..re_client_version:0.124.1.13f78cc-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/eb3062b377..1633d23fc7 * third_party/android_build_tools/lint: 0myhyR77F6-p8FkluxgAw-t0PcSPOLVMoRUV8zqCBIkC..HauAZeOm40GKv93v51MaoIilRbuPDo29QhN98r7kQaMC * third_party/android_toolchain/ndk: NSOM616pOQCfRfDAhC72ltgjyUQp9lAWCMzlmgB18dAC..XSjN84pHxBPX13CrUj3fQjEroncvFGGeJY9wDVEDswoC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/97b05366a4..69bde63990 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/60f6c8a860..05a55efaa9 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/df5952f59c..4ab8957af3 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e88fcc906f..d5e7c425e0 * third_party/r8: g0IMQK-a9MiyqyQd6f26Ut45q36vivXE9UFtVa8mM38C..NyEPLS024hp8BUV5gx7DSIZzgCEWY-tevgRF8F1RWYgC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/925b4391a1..143660d186 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/85bbbfc395..e582bc0452 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I7f9952ec63d700c10aaa0772c9045054943a1de5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5101972 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi b8ca8de4 2023-12-05T13:36:53 Vulkan: Don't crash when glCopyTexImage2D redefines itself The Vulkan backend marks a level being redefined as such before doing the copy. If a single-level texture was being redefined, it releases it so it can be immediately reallocated. If the source of the copy is the same texture, this causes a crash. This can be properly supported by using a temp image to do the copy, but that is not implemented in this change. Bug: chromium:1501798 Change-Id: I9dde99aa0b88bc7d5f582ff15772f70b36f424e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5089150 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 8dbdd57c 2023-12-07T11:21:13 Roll vulkan-deps from bc34fe665e84 to fb2389e52832 (16 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/bc34fe665e84..fb2389e52832 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/0fedf7d95a..9a35abff55 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/7c335edc66..e6b013a492 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/cca08c63ce..1c6bb27435 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/b79c10bac1..a0308b56d8 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/67cda9672b..1ee9eea9f1 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8739b87fcf..847a8a1f8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I2fa61f5e9913a16afe90428d154fa01767927456 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5099084 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e4f1f1e3 2023-12-07T09:34:24 Roll Chromium from d6f0715fbaaf to e567f1f8ed1d (592 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d6f0715fbaaf..e567f1f8ed1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7d0812ef48..8b5921ef0c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/894e045303..a19d89f939 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/dbd7cb3e68..eb3062b377 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/0764ad493e..025aa883df * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/093f85fdf8..97b05366a4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/916dda0a0b..60f6c8a860 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/7f2dd14f5d..df5952f59c * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/4cb5c2cefe..e88fcc906f * third_party/r8: ntZT6d-gLBdyTo-D6ie-hZXbQqDe_YNG3RK5ah85jBsC..g0IMQK-a9MiyqyQd6f26Ut45q36vivXE9UFtVa8mM38C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/991b697d2c..28cba3ec32 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3044fe1fd3..85bbbfc395 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ic8e78f63b2f5105b3b48110ce7a5718b5bb4f62b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5098158 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll fd957a65 2023-12-07T10:01:49 Roll SwiftShader from 4befa3ada54c to 77be35e337bb (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/4befa3ada54c..77be35e337bb 2023-12-06 syoussefi@google.com Remove VK_GOOGLE_sampler_filtering_precision If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I8d914be718336ec2ca119b1737399d42c0dea5cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5098532 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi dc4b1acd 2023-11-30T15:42:32 Translator: Limit private variable size to 64KB This is indirectly fixing an issue where passing large arrays in SPIR-V such that an internal cast is needed (such as array inside interface block copied to local varaible) causes an overflow of the instruction length limit (in the absence of OpCopyLogical). By limiting the size of private variables to 32KB, this limitation is indirectly enforced. It was observed that all the test shaders added in this CL fail on the Nvidia OpenGL drivers, so such a limit seems to be reasonble. Bug: chromium:1505009 Change-Id: Ia36134b2bf8501a5b875814db3566be28b183e0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5077408 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d788c2c0 2023-12-04T22:43:39 Remove team members no longer part of the project Bug: None Change-Id: I66bf34ece50995fdecfab55a2198e9946e9be4cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5087208 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 6d9f0aee 2023-11-30T00:00:00 Metal: Ensure helper invocations when derivatives are used Set sample coverage mask to ensure that fragment shader helper invocations are performed when derivatives are used. Fixed the following tests on Apple silicon: dEQP-GLES2.functional.texture.mipmap .2d.projected.nearest_linear_repeat .2d.projected.linear_linear_repeat .cube.projected.linear_nearest .cube.projected.linear_linear dEQP-GLES3.functional.texture.mipmap .2d.projected.nearest_nearest_mirror .2d.projected.linear_nearest_clamp .2d.projected.linear_nearest_repeat .2d.projected.linear_nearest_mirror .2d.projected.nearest_linear_repeat .2d.projected.linear_linear_clamp .2d.projected.linear_linear_repeat .3d.projected.nearest_nearest_mirror .3d.projected.linear_nearest_clamp .3d.projected.linear_nearest_repeat .3d.projected.nearest_linear_clamp .3d.projected.nearest_linear_mirror .3d.projected.linear_linear_clamp .3d.projected.linear_linear_repeat Fixed: angleproject:8443 Fixed: angleproject:7023 Change-Id: I13fc52532b94de098dcf3e9f5f02d48a6c8913c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5089131 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Gowtham Tammana ac4cb708 2023-12-04T16:04:44 DEPS: Add clspv and llvm deps clspv is a OpenCL C to Vulkan compute shader compiler useful for CL implementation on Vulkan. Add these as third party modules in Angle. Bug: angleproject:8369 Change-Id: If31e755525a8e71d727b528d2f3a7f3c7fdd55d8 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5085667 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Daniel Cheng bc7af34c 2023-12-06T00:15:33 Use googletest flag macros to access googletest flags. The implementation details of flags can change; fixing this proactively makes it easier to roll googletest. Bug: chromium:1409870 Change-Id: I5efa2487d9e38e122ca20f201748faf8e8050347 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5092928 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org>
angle-autoroll df5e37b0 2023-12-06T11:10:51 Roll vulkan-deps from 299bb7684789 to bc34fe665e84 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/299bb7684789..bc34fe665e84 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/72b403ad71..0fedf7d95a * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/63656eb768..8739b87fcf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I769266b783e60bd148c8cd6e69cfbd18dd763080 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5094393 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c31476c1 2023-12-06T07:01:18 Roll Chromium from 624a7aa7a053 to d6f0715fbaaf (606 revisions) https://chromium.googlesource.com/chromium/src.git/+log/624a7aa7a053..d6f0715fbaaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b2f7b93383..7d0812ef48 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0ac67b7cef..894e045303 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4837aac5d8..dbd7cb3e68 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e9e09fc19c..093f85fdf8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/963000950b..916dda0a0b * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/caccdb0407..7f2dd14f5d * third_party/r8: RVHUDXQq4bO_rJwe8vsZtb57_mnqCVm0WNcp0H9bLecC..ntZT6d-gLBdyTo-D6ie-hZXbQqDe_YNG3RK5ah85jBsC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/60751d2b6f..925b4391a1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/90bafacea8..991b697d2c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/55f4b3f9c4..2206f69ffd * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/569c4f0b27..3044fe1fd3 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I979f5ee6cc809c135668b96bf0e5075af7cec9d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5092689 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop f58ba088 2023-11-05T16:40:37 Tests: Add Warcraft Rumble trace Test: angle_trace_tests --gtest_filter="*warcraft_rumble*" Bug: b/309345647 Change-Id: I6e78fb0465edcfa97943ff8374c568dcd9b8eba7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5007173 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi e9d5f13e 2023-12-04T22:36:41 Vulkan: More trace points in the readpixels path Occassionally we hit a bad path in this case, this change makes it clearer from the traces which bad path is hit. Bug: b/310701311 Change-Id: Ic674d6396b0e88f1a1db3ded7efe195fb7397135 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5087207 Reviewed-by: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 9bfe5847 2023-12-05T18:44:02 Manual roll vulkan-deps from 66a2496b8cff to 299bb7684789 (32 revisions) Manual roll requested by abdolrashidi@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/66a2496b8cff..299bb7684789 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/a1138bacff..72b403ad71 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/a3da0e87fa..7c335edc66 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0d87845532..6b4f0c9d0b * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/9d27c893cd..19a863ccce * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f4ae60be27..b79c10bac1 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/98d168c168..67cda9672b * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/1fb77ad1d4..2feac58733 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7add1ebaaf..63656eb768 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I69cacef57e9c73161958177269fa87f7c3bda9a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5090128 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Alexey Knyazev d7077e9f 2023-12-05T00:00:00 Update macOS end2end expectations Bug: angleproject:2273 Bug: angleproject:2408 Bug: angleproject:3837 Bug: angleproject:5325 Bug: angleproject:5360 Bug: angleproject:5594 Bug: angleproject:6358 Bug: angleproject:6418 Bug: angleproject:6454 Bug: angleproject:6457 Bug: angleproject:6540 Bug: angleproject:6702 Bug: angleproject:6751 Bug: angleproject:7068 Bug: angleproject:7309 Bug: angleproject:7445 Change-Id: I7f4c012ed2de6af83188ed69170b19f8d2bb19de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5087774 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 0ff2c771 2023-12-05T15:17:22 Revert "aosp: remove gclient flag --delete_unversioned_trees" This reverts commit c40f1a04271f5a99fda8b9e48b521493210e13bc. Reason for revert: doesn't help Original change's description: > aosp: remove gclient flag --delete_unversioned_trees > > Suggested by Gerrit folks: b/305091097#comment13 > This flag has been set for a long time, but after migration to > submodules it might be causing trouble. > > Bug: b/305091097 > Change-Id: I9eba5bf4ebe192942ab72b7670628f957b03ecc6 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5077411 > Auto-Submit: Roman Lavrov <romanl@google.com> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Bug: b/305091097 Change-Id: I6b954f01cb10e030af72e7965343e4007ba21c35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5087159 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Alexey Knyazev 5d70a41c 2023-11-30T00:00:00 Metal: Use a separate struct for last fragment data Used a separate MSL struct type for reading from framebuffer attachments to not fetch unnecessary draw buffers and to be able to set a sample mask. Removed TranslatorMSL::isSampleMaskAllowed() Ensured that the lastFragmentOut variable is not added when PLS does not use framebuffer fetch. Fixed: angleproject:8442 Change-Id: Ia3320fc6063277479b5aa9b7fea34457465add75 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5079450 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 37c86f7c 2023-12-05T07:59:50 Roll Chromium from 192be4e9edea to 624a7aa7a053 (615 revisions) https://chromium.googlesource.com/chromium/src.git/+log/192be4e9edea..624a7aa7a053 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9b8bc79c29..b2f7b93383 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d11c27b4cb..0ac67b7cef * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3fdf1cf406..4837aac5d8 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/95eabf6f99..e9e09fc19c * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/081bca8cb3..963000950b * third_party/r8: 40RdMjvS_7M6jwmYUMU3GHGAayTXD9X2CoOLHzA5HZwC..RVHUDXQq4bO_rJwe8vsZtb57_mnqCVm0WNcp0H9bLecC * third_party/siso: git_revision:1ea45c1829514ff20c476f083462e7b8fdfaf9ae..git_revision:acf6e472017229d73c507e50c8660c2d3a2021e0 * third_party/turbine: e8ccyNXO5wVjI0vv5W8kfA101BaaLNjNiVH1JddpdWkC..M27KV5bN2pvX97rzQXxamxLUFHmKEes8wvZevk8nU2YC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bb2261c395..569c4f0b27 No update to Clang. Bug: angleproject:6430,angleproject:7079 Tbr: abdolrashidi@google.com Change-Id: I5322da02c506baa3c5b245664624f7f2e7707acc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5085585 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 74f9da02 2023-12-04T19:53:25 Vulkan: Remove spam about depth/stencil feedback loop It triggers a warning even if the application is appropriately using BASE and MAX levels to avoid feedback loop. Bug: b/289436017 Change-Id: Ie7e8281908802e91dfaad1b49dd95197ac6de1a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5086070 Commit-Queue: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Cody Northrop 18d51f01 2023-12-03T18:26:12 Tests: Add Black Clover M trace Test: angle_trace_tests --gtest_filter="*black_clover_m*" Bug: b/314683298 Change-Id: Icee6102aa5161f2054134831e00eb99b8048c448 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5082209 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Chris Forbes a1cd2198 2023-12-04T11:42:13 Fix yuv_2_rgb and rgb_2_yuv GLSL function emulation The color conversions themselves were already correct, but Y was assumed to be full range, and u,v assumed to be centered on zero. This change folds the range expansion and chroma bias into the transforms. In order to accomplish the bias the matrices are extended to be mat4x3, and the provided color value is extended to a vec4 with w=1. Various other methods are possible (and potentially more efficient if the standard is not a constant) but just folding everything into the matrices is the most straightforward. Test: atest CtsNativeHardwareTestCases Bug: b/308437613 Change-Id: I33f797450c9ad9e758100eb8530d86548939f4ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5082558 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 4f09451a 2023-12-04T07:00:24 Roll Chromium from f38cb20b11bf to 192be4e9edea (197 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f38cb20b11bf..192be4e9edea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f99b6dbc03..d11c27b4cb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0a6bb23039..3fdf1cf406 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/13c08122f7..caccdb0407 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: Ibfdee80141a2d855d26b2478b1ee97799a3e12d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5082697 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi fb6b960c 2023-11-27T14:24:28 Remove GL_CHROMIUM_texture_filtering_hint This was using an unregistered Vulkan extension to set the precision of SwiftShader's internal filtering for the sake of Chrome. That's baked in at build instead. Bug: angleproject:8349 Bug: chromium:726075 Change-Id: I12849d2d29d99626f22a92ee9d74366f78658476 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5063344 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 6d3fc554 2023-12-02T15:01:06 Manual roll Chromium from d0afe9132509 to f38cb20b11bf (472 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/chromium/src.git/+log/d0afe9132509..f38cb20b11bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a443f73cbc..9b8bc79c29 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ba3cb9e951..f99b6dbc03 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0c6d88fd75..0a6bb23039 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/be49b4d066..95eabf6f99 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cccca95d8f..081bca8cb3 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/3467ae2512..13c08122f7 * third_party/r8: A5uzwWQ1XpXtSZMcM7n-u9qcngzVKnyyRVBrJw1STFMC..40RdMjvS_7M6jwmYUMU3GHGAayTXD9X2CoOLHzA5HZwC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/67da756b88..dd5fc1316c * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/3ee0331f3c..60751d2b6f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b084c92e02..55f4b3f9c4 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d55cd8bab4..bb2261c395 No update to Clang. Bug: None Tbr: romanl@google.com,syoussefi@google.com Change-Id: I18600aa55d1eb98b9c2a338bd3d67e3e3a39a8d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5081264 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao 90767546 2023-12-01T12:27:15 Vulkan: Add test for __samplerExternal2DY2YEXT then swizzle Added a correctness test SourceYUVTextureTargetExternalRGBSampleYUVSampleWithSwizzle for applying swizzle after sampler. Also removed some bug workaround for VVL and drivers since they are fixed now. Bug: b/309480316 Change-Id: If82b2251745a96335b535c67b6e0c0847268b25b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5080497 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 554d761a 2023-12-01T15:14:22 Tests: Add AFK Arena trace Test: angle_trace_tests --gtest_filter="*afk_arena*" Bug: b/314365671 Change-Id: Id0213199b0e75919701be8ec9e216a224a6725d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5078682 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi caa5e4ea 2023-11-30T14:12:42 Translator: Fail compilation if too many struct fields If there are too many struct fields, SPIR-V cannot be produced (as it has a hard limit of 16383 fields). The Nvidia GL driver has also been observed to fail when there are too many fields. Bug: chromium:1505009 Change-Id: If9b01716c1cab35a6e537da64421e29fe0eda91e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5074629 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Mark Lobodzinski 25f448f4 2023-12-01T12:33:27 Tests: Add Walking Dead Survivors trace Test: angle_trace_tests --gtest_filter=TraceTest.walking_dead_survivors Bug: b/314311102 Change-Id: Icf104613b59a8de0f89fc5fa3dd6db4ad9a3dc2b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5080498 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 6df603ed 2023-11-30T13:53:00 Translator: Optimize field-name-collision check As each field of the struct was encountered, its name was linearly checked against previously added fields. That's O(n^2). The name collision check is now moved to when the struct is completely defined, and is done with an unordered_map. Bug: chromium:1505009 Change-Id: If28d738254a541450912eba4ed168424dad9d8be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5077407 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
angle-autoroll 77812001 2023-12-01T15:11:52 Manual roll vulkan-deps from f4204cd3fb57 to 66a2496b8cff (1 revision) Manual roll requested by romanl@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/f4204cd3fb57..66a2496b8cff Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/64fb8917ea..7add1ebaaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I5bf8e2b9960543a316e5f4432cd3b2e9b4297010 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5079284 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Sergey Kataev 75e13e68 2023-11-29T22:19:46 Metal should not inline non-const global initialisers Bug: angleproject:8403 Change-Id: Iaa6126d7043931a16104ea84c5f7e737017dabc3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5076256 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Sergey Kataev <sergeyka@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 0f7dedef 2023-12-01T18:08:01 Roll VK-GL-CTS from faf4fbbc8f8e to af594bc856e5 (11 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/faf4fbbc8f8e..af594bc856e5 2023-12-01 sricker@nvidia.com Add additional vksc descriptor pool tests 2023-12-01 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main 2023-12-01 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2023-12-01 rgarcia@igalia.com Regenerate mustpass for main 2023-11-30 rgarcia@igalia.com Test Z Export without MS info in frag shader library 2023-11-30 ziga@lunarg.com Enable required features in nested_cmd_buffer tests 2023-11-30 anna.lesniewska@intel.com Use compute queue instead of transfer queue in compute queue support check 2023-11-30 mirela.nicolescu@broadcom.com Descriptor_indexing tests: use nearest filtering 2023-11-30 rgarcia@igalia.com Test many indirect draws and dispatches in sec. cmd. buffers 2023-11-30 rgarcia@igalia.com Add new multi draw tests that do not depend on DrawIndex 2023-11-30 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ic76aca3e99b1671cef6c0bf228a3c659e012f52d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5079058 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9a7e4882 2023-12-01T14:36:53 Manual roll Chromium from 996514892366 to d0afe9132509 (733 revisions) Manual roll requested by romanl@google.com https://chromium.googlesource.com/chromium/src.git/+log/996514892366..d0afe9132509 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bb826aaf00..a443f73cbc * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b17c7e870e..ba3cb9e951 * buildtools/reclient: re_client_version:0.121.0.e622934-gomaip..re_client_version:0.123.1.b4c22d0-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9213eae588..0c6d88fd75 * third_party/android_build_tools/lint: hPW0THuEdVxwGMSWqn9CZgyFBNXe9sXc2NJsh1hiliIC..0myhyR77F6-p8FkluxgAw-t0PcSPOLVMoRUV8zqCBIkC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ee967548fe..be49b4d066 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9e5fc28b6b..cccca95d8f * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/0ad014cff4..3467ae2512 * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/bbe2764382..278e5fbafc * third_party/r8: 1cleC9ETmNTNjX-TQoPj14Siz7FFAy6HR6x5pbSS00oC..A5uzwWQ1XpXtSZMcM7n-u9qcngzVKnyyRVBrJw1STFMC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/990e9cdeeb..90bafacea8 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5b7313d3e5..b084c92e02 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/913a358a00..d55cd8bab4 Clang version changed llvmorg-18-init-12422-g74cdb8e6:llvmorg-18-init-12938-geb1d5065 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/990e9cdeeb4b639b6468a7f11206d22b6ecc258e..90bafacea8b63686eb658a8249a9f719e0df9981/scripts/update.py Bug: None Tbr: romanl@google.com Change-Id: Ia6437b21f40253effcd0f4857677be0c00c1c620 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5079282 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi ab992c3e 2023-12-01T11:51:13 Clarify which link failed in link program perf test Bug: angleproject:8417 Change-Id: I5445518fdf6dcc2533ea055588221d6e45c45d9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5077412 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi b46cf698 2023-11-30T11:00:18 Vulkan: Fix Android deadlock with querying buffer age Similar to eglSwapBuffers, eglQuerySurface with EGL_BUFFER_AGE_EXT can cause a call to vkAcquireNextImageKHR. Bug: angleproject:6851 Bug: b/313975825 Change-Id: If3f0521219cab9aba2aeb2b70958bf0f197bc96a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5077406 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev edcfab40 2023-11-23T00:00:00 Metal: Implement textureCubeGrad transformation for AGX Wrapped all affected built-in function calls with helpers that transform derivative values. Fixed all *.texturegrad.* dEQP failures on Apple silicon. Fixed: angleproject:7021 Fixed: angleproject:8433 Change-Id: I16b023840ad267ab72d31fde3cb0fa7048e5310c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5071254 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Roman Lavrov eef89870 2023-12-01T09:47:40 Trace tests: skip mini_world on win intel native Flaking Bug: angleproject:8440 Change-Id: Iff415531d4820937ef5e42c8fcba05c305494c38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5078288 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov c40f1a04 2023-12-01T09:17:04 aosp: remove gclient flag --delete_unversioned_trees Suggested by Gerrit folks: b/305091097#comment13 This flag has been set for a long time, but after migration to submodules it might be causing trouble. Bug: b/305091097 Change-Id: I9eba5bf4ebe192942ab72b7670628f957b03ecc6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5077411 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0