|
acf2f3ad
|
2017-11-21T19:22:44
|
|
Apply Chromium style fixes.
This addresses several minor code quality issues that are validated
in Chromium, but not yet applied to ANGLE:
* constructors and destructors must be defined out-of-line
* auto is not allowed for simple pointer types
* use override everywhere instead of virtual
* virtual functions must also be defined out-of-line
Slightly reduces binary size for me (~2k on Win, 150k on Linux).
Bug: angleproject:1569
Change-Id: I073ca3365188caf5f29fb28d9eb207903c1843e6
Reviewed-on: https://chromium-review.googlesource.com/779959
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
03fd0356
|
2017-11-20T16:30:10
|
|
D3D11: Push index range computation deeper.
If we can make the index range computation happen as late as possible,
we won't have to check it during the fastest draw call paths.
This change makes it easier to skip re-computing some index range
checks by only checking it in one place in IndexDataManager, and by
making it a lazy check; the check is never evaluated if the primitive
restart workaround is not enabled.
Future work can also push the index range computation for vertex info
later, so we only evaluate it in the cases where we need it.
BUG=angleproject:2229
Change-Id: Ic55fac9e23fd35a119ddff475355a43095d2e3e9
Reviewed-on: https://chromium-review.googlesource.com/764675
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
57ae8c16
|
2017-08-30T12:14:29
|
|
GLES3: Auto-generate entry points source.
Lots of incidental fixes to formatting and naming.
Adds specific default return type overloads for ClientWaitSync and
GetUniformBlockIndex.
BUG=angleproject:1309
Change-Id: Id67cbc0b19fc2cb94c859ab8390f1ff36b1bbd25
Reviewed-on: https://chromium-review.googlesource.com/637203
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
2e29b13d
|
2017-08-28T17:22:11
|
|
Fix some default return values in auto-gen.
We don't generally test for the default return values of function
calls that have validation errors, but the auto-gen script might
not have been returning things correctly. For GLint values, default to
returning -1 instead of zero.
BUG=angleproject:1309
Change-Id: I736b5a7ef9b50ca1509087fe933c4a4e526531d8
Reviewed-on: https://chromium-review.googlesource.com/636522
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
44183cce
|
2017-08-01T12:48:34
|
|
Micro-optimizations to draw call entry point.
Thanks to Markus from NVIDIA. This inlines some methods and optimizes
the check if a uniform is a bool type.
BUG=angleproject:2119
Change-Id: I6f2c2d22c577458b39de600d3c56ec8e1a456a7a
Reviewed-on: https://chromium-review.googlesource.com/591699
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
|
ee769dd2
|
2017-05-04T11:38:30
|
|
GLES2: Auto-generate entry points file.
BUG=angleproject:1309
Change-Id: I7817444c3ea56f932fe769a860f4a70b29262019
Reviewed-on: https://chromium-review.googlesource.com/483427
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
180973c7
|
2017-04-28T14:42:07
|
|
Fix params.h compilation.
The ANGLE_PARAM_TYPE_INFO macro was referencing the TypeInfo static
member that was only added when release asserts are enabled.
BUG=angleproject:747
BUG=chromium:716323
Change-Id: I0657dde69c62ab697b3c095fe19f38c130188cef
Reviewed-on: https://chromium-review.googlesource.com/490687
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
|
|
|
ae39958a
|
2017-04-28T10:42:42
|
|
Fix params.h compilation.
Because our ASSERT macro always references the conditional expression,
not defining TypeInfo was causing a compile error on builders which
had release asserts disabled.
BUG=angleproject:747
BUG=chromium:716323
Change-Id: I3b5f27e39235f26b8bef5921c2d398320eb0ebaf
Reviewed-on: https://chromium-review.googlesource.com/490426
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
9c9b40ac
|
2017-04-26T16:31:57
|
|
Use parameter cache to skip passing IndexRange.
For DrawElements et al., we can use a simple design to store
entry point parameters and compute index ranges lazily. This allows
us to compute the index range outside of the validation layer.
Fixing this will let us implement a few things, such as the no error
extension. It will also allow auto-generation of the entry points,
since we won't have to have special cases for certain entry
points. It will also help fix the syncState layering problem. Now the
cached parameter helper (which is owned by the Context) can make the
impl layer calls, instead of the validation layer calling the impl
directly.
We use a small array in Context to gather parameters in a generic
way without reallocation on call. We also check type safety by storing
a type info struct which can handle inheritance between type classes.
Optional variables for the cache determine when to re-compute values.
The intent with gatherParams is to call this in every entry point, and
have in most cases be a no-op. In some cases like for IndexRange, we
store some parameters for later use. The inheritance scheme enables
auto-generation of the entry points by keeping signatures similar.
BUG=angleproject:747
Change-Id: I871e99e1334cf6e61ef8da62fde3ced094903f8a
Reviewed-on: https://chromium-review.googlesource.com/474119
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|