|
c8a7c033
|
2020-11-07T09:12:47
|
|
Vulkan: Move primary command buffer to CommandQueue.
This brings CommandQueue one step closer to the worker thread.
Bug: b/172704839
Change-Id: I35225c5f302e34e3feb38a35c22b6d8e6f4ad10c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524543
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
580b775f
|
2020-11-09T14:57:28
|
|
Traces: Use 4 download threads.
This should significantly speed up checkout on dev machines.
Bug: angleproject:5133
Change-Id: Iba20182c600ea8e17de47bb4e84b2e4191d301d3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2527721
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
489f2c83
|
2020-11-06T17:24:28
|
|
Perf Tests: Trace multiple threads.
This uses a little helper list to map thread IDs into simple serials
that we output as 'tid' in our trace JSON file. We can use this to
analyze the behaviour of the command processor thread.
Bug: b/172704839
Change-Id: Ic1b5f3ec8427cb310833d1f589503daec4812681
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524542
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
2e74c452
|
2020-11-06T16:45:21
|
|
Vulkan: Make feature names consistent.
This gives the features the exact same name as the member variable.
It fixes a bunch of inconsistencies between the variable name and the
external string identifier.
Ideally these could be auto-generated from JSON.
Bug: b/172704839
Change-Id: Id75c01db544672234435c3dd727c927027b9236d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524541
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
3806696c
|
2020-11-06T23:04:35
|
|
Fix expectations file for prerotation dEQP executables
Bug: angleproject:4901
Change-Id: Ibc930a27887a3ba710168a9b122d46aac1530984
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2523548
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
34130c2e
|
2020-11-07T15:11:14
|
|
Vulkan: Rewrite interpolateAtOffset to account for Y-flip
In order to fully suppot OES_shader_multisample_interpolation
rewrite interpolateAtOffset's offset parameter to account for
Y-coordinate flip.
Bug: angleproject:3589
Tests: dEQP-GLES31.functional.shaders.multisample_interpolation.
interpolate_at_offset.*.default_framebuffer
Change-Id: I6bf72ceb1c0466ff5d4a92b72d1ec9e2552d6f2a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524711
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
06eaaac5
|
2020-11-06T16:33:13
|
|
Fix trace writing in angle_perftests.
We can use this to produce AGI-like reports in standalone desktop.
Bug: b/172704839
Change-Id: Ifc510232e3da81210e22429b6cea9800e2723e06
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524540
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
a5e0a4bc
|
2020-11-08T11:10:12
|
|
Vulkan: Support VK_KHR_image_format_list for AHB backed EGL image
AHB backed EGL images create the VkImage through external sibling
images. Create those images with VK_KHR_image_format_list extension
support enabled.
Bug: angleproject:3756
Bug: angleproject:5281
Test: angle_end2end_tests.exe
--gtest_filter=ImageTest*SourceAHB*Colorspace*Vulkan
Change-Id: I28c22f9d2f2423daa9228e4d42772b380ab7b8b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525109
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
eaab2e34
|
2020-11-09T11:24:09
|
|
Vulkan: add explicit template specialization for barrierImpl
ImageHelper::barrierImpl with secondary command buffer is used in
other translation units. Linking fails if compiler has optimized
out symbol for secondary command buffer.
Bug: angleproject:5324
Change-Id: I588d0d949a9b2eee04d8103effc485ab23d679c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2526082
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9217d49d
|
2020-11-08T09:18:33
|
|
Vulkan: Add EXT_external_buffer entry points
Addition of the entry points for EXT_external_buffer extension.
Bug: angleproject:5073
Change-Id: I5dc9f74dfd68c1e83e17ca15166df4cd4c20fca2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525104
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
40c5e53e
|
2020-11-09T10:01:07
|
|
Roll SwiftShader from 612ded0654a0 to 4ed9d3498dcf (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/612ded0654a0..4ed9d3498dcf
2020-11-06 vhau@google.com Modify gralloc0 implementation
2020-11-06 jaebaek@google.com SpirvShaderDebugger: Correct member index for DebugValue
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I1ecdb3394c4fe8c52c3f09ab03ccbe178c495fcf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2526363
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
2e236c33
|
2020-11-09T10:01:25
|
|
Roll Vulkan-Headers from 87451c55aa8b to 670ffea9d61b (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/87451c55aa8b..670ffea9d61b
2020-11-09 oddhack@sonic.net Update for Vulkan-Docs 1.2.160
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Change-Id: Ia6d4d889cf62e7dc38a9fcb6de223fb256f21bbd
Bug: None
Tbr: courtneygo@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525861
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
46f5f438
|
2020-11-09T07:01:14
|
|
Roll Chromium from 52d33a46255e to 61aafe6377ea (506 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/52d33a46255e..61aafe6377ea
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/dc348c17b4..6dd14a4537
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/c8d7f9564e..2de3a18349
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/2d8c1340f0..0fe1450acb
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..434681c237
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/df43926725..aa9ff5db33
* tools/skia_goldctl/linux: GVpht0r-QjWXa70RBjnj16oVOukePZsPqR9WjoyczEQC..O3XpMr3WCt1GviS8wGsldM7NCVb2wabpHx0lJZEemjIC
* tools/skia_goldctl/mac: E1HzztCcEvl2qwMi8jlWEeRipywovPX1tvzNMap-XFgC..9ofAReQA7h1bDa9kU-Rmr4_0AEQli7Pnj3lsid5AisAC
* tools/skia_goldctl/win: DsHjiYrgPxP5IjJ3QDF-DgcQwV_lMq60ESSU1CwXBSkC..lSgrnuo5FQl_aJkQyR7BSuMSrKb37G40wPe4xQBmTnEC
No update to Clang.
Bug: None
Tbr: courtneygo@google.com
Change-Id: If41692440b822876d6e49350b507daac47fa0e6f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525680
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
d4439824
|
2020-11-08T16:17:20
|
|
Gold Trace Tests: Fix JSON output with empty test set.
Previously we would leave an empty test suite name with no tests run.
According to the JSON test results spec this is likely a malformed
output and we should instead include just an empty "tests" key.
Bad:
"tests": {
"angle_restricted_trace_gold_tests": {}
}
Good:
"tests": {}
Bug: angleproject:5299
Change-Id: I459da593df150d804130f9c63e05d031e77a16a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525147
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
aca3d408
|
2020-11-05T20:53:37
|
|
Fix return value of cube map array imageStore.
Should be void according to the spec. Noticed while working on texture
buffer.
Bug: angleproject:3584
Change-Id: I79a671c82fa117bab69bc2e6b35c840aa30429c5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521241
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
18fcb4ad
|
2020-11-06T07:22:17
|
|
Vulkan: Enable a subset of ImageTest colorspace tests
This patch does the following -
1. Expose EGL_KHR_image_gl_colorspace only if the underlying
ICD supports VK_KHR_image_format_list extension
2. Create VkImageViews from EGLimage's format
3. Fix bugs in ImageTest colorspace tests
Bug: angleproject:3756
Bug: angleproject:5281
Test: angle_end2end_tests.exe
--gtest_filter=ImageTest*Colorspace*Vulkan
Change-Id: I618ae009e83d0a6b27a0a50165f736784717e404
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2523670
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
e2ecb2dd
|
2020-11-03T19:26:00
|
|
Enable logging API commands to Android logcat
This enables logging API commands to Android logcat. It is enabled
via the following GN arg:
angle_enable_android_api_logcat = true
On desktop, API commands can continue to be logged to the
"angle_debug.txt" file via a different mechanism, with the GN arg:
angle_enable_trace = true
Bug: b/170249632
Change-Id: Id52e75f966a97692ec6d69eb3d254ba295a151c2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519094
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
|
|
|
06a9d529
|
2020-11-04T19:57:27
|
|
Add build flag to control runtime annotator checks.
This restores the prior path where angle_enable_trace would let ANGLE
write a debug.txt file without needing environment variables or
run-time annotator attachments.
Bug: b/170249632
Change-Id: I28693f038572638eb6531c5bb8e42d6cc7a65451
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2523912
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
9825695e
|
2020-11-03T15:29:38
|
|
Vulkan: Increase CommandBufferHelper pool size
For interesting threading behavior need more than two command buffer
helper objects in the pool.
Bug: b/170328907
Change-Id: I394a583f2241ef094abba7a4645a200b9308e466
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518134
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
21eb41ac
|
2020-11-05T16:54:25
|
|
Generate executables for prerotation deqp tests
This change generates angle_deqp_gles*_rotate*_tests executables which
choose the appropriate mustpass file.
Bug: angleproject:4901
Change-Id: Ie6ac4b80d480b0f590b5baf1fa244fd601b5beed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522415
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
55934550
|
2020-11-05T07:13:39
|
|
Vulkan: Don't refresh image views unnecessarily
If the underlying ICD supports VK_KHR_image_format_list
extension we will have created both the linear and sRGB
image views, reuse them instead of refreshing them.
Bug: angleproject:3609
Bug: angleproject:4561
Bug: angleproject:5281
Change-Id: Ie34f08b3554a07f94911bebf925e38d702bc3c36
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518387
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
|
43acf3ba
|
2020-07-31T15:43:57
|
|
GL: Compiler changes for GL_OES_texture_buffer
This extension is core in GLES 3.2
This CL enables the extension, added 412 new dEQP tests for texture
buffer. 410 of these tests pass, but there are two tests that fail,
detailed in anglebug.com/4933
Also includes a fix for completeness checks.
Based on a CL by Jonah Ryan-Davis.
Bug: angleproject:3573
Bug: angleproject:4933
Change-Id: I45759d765c88c64f21b592eab01d910dc4bc8da3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521239
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
7616dfbd
|
2020-11-04T18:23:22
|
|
Vulkan: Allow Android properties to override features
Can enable/disable ANGLE feature via Android properties:
debug.angle.feature_overrides_enabled and
debug.angle.feature_overrides_disabled which take a string of ':'
separated feature strings.
Bug: b/170328907
Change-Id: I815b42c5cfae85a39f0f753eabd56e264ea38baf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514200
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
a481bee2
|
2020-11-04T18:20:24
|
|
Add GetEnvironmentVarOrUnCachedAndroidProperty
GetEnvironmentVarOrAndroidProperty will first return the given
variableName from the processes enviroment if defined. If not defined
and running on Android, will look up the corresponding property and
store it in the environment.
The framecapture code wants to see when the Android property changes so
add an uncached version of GetEnvironmentVarOrAndroidProperty that
always does the getprop command (which can be time consuming).
Bug: b/170328907
Change-Id: I0624c0646889435cb6f6eb20a6d3cceb6ae3eb48
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2520107
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
4323ed0c
|
2020-11-06T12:45:12
|
|
Perf Tests: Fix test time with max steps performed.
This lets the default test time be 10 minutes when using a maximum
steps value. This will prevent the current 10 second limit from
kicking in and aborting. Also changes the --test-time override to
be more clearly a calibration time, and adds a new --test-time that
lets the user override the actual trial test time.
Bug: b/172480147
Change-Id: I630aa8d3c9e118bb5f0100b38f37e717e12f3538
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2523371
Reviewed-by: Paul Thomson <paulthomson@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
6507c1ed
|
2020-11-05T23:21:17
|
|
Tests: Add Clash of Clans trace
Note: Hand edits required to compile this trace.
ANGLE_REPLAY_EXPORT was removed from each of the entry points in the
header. See build logs in patch set 1 of this CL for full output.
Test: angle_perftests --gtest_filter="*clash_of_clans*"
Bug: b/172626835
Change-Id: I63bab8f059a2c73c0a2fcd5b70fd92abf3bd4650
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521180
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
156c227d
|
2020-11-06T13:06:02
|
|
Remove the amend commit from roll_aosp.sh
Bug: b/150458033
Change-Id: Ice5711a672b63a7dac0618749c7e56d862e0e5ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2523373
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
27ea50a5
|
2020-11-05T22:24:28
|
|
Capture/Replay: Restore buffer bindings during Reset
Emit code to reset all buffer bindings to how they were at the
beginning during MEC.
Test: Capture Clash of Clans
Bug: angleproject:4048
Bug: b/172626835
Change-Id: I5a5446304d119f51a018c8fe88ff386243d19749
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521179
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
e70b1527
|
2020-11-06T12:51:35
|
|
Always use the -f flag with rm in roll_aosp.sh
rm will error when the file is missing without the -f flag. We delete a
few files without checking that they exist first.
Bug: b/150458033
Change-Id: I5a104d383f59d418eaa55534526194f626c88f57
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2523372
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
a9415a85
|
2020-11-06T08:33:49
|
|
Update DevSetup.
We no longer require a specific version of the Windows SDK.
Also include updated instructions on how to setup Goma.
Bug: angleproject:1944
Change-Id: I5f9e714ebd69ba04eddc1b1fc2f95d1fde67a47f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522419
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
940dc786
|
2020-11-05T13:54:56
|
|
Re-enable GLES31 test that is no longer flaky
Fixed by:
https://swiftshader-review.googlesource.com/c/SwiftShader/+/50008
The specific flaky crash was reported here:
https://bugs.chromium.org/p/angleproject/issues/detail?id=4482#c15
Bug: angleproject:4482
Change-Id: Ia77b4b094446d14866bee5fd461a0a4eea52491e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521237
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
|
|
|
af16c638
|
2020-11-06T09:50:51
|
|
Perf Tests: Add --max-steps-performed argument.
This will limit the total number of steps run in the test.
When using this argument we skip warmp & calibration.
Renames the prior --steps argument to --steps-per-trial.
Bug: b/172480147
Change-Id: Iae7cce26d66ca0bbdb21c1f511a6bfa246bd204e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519404
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
6a8d5bcb
|
2020-11-06T11:22:36
|
|
Fix wrong working directory for roll_aosp.sh
Bug: b/150458033
Change-Id: I17c605cbe02341b31855dc771225bf0c95445bfd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522009
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
f2a78926
|
2020-11-05T14:01:39
|
|
Symbol Table: Error on duplicate group keys.
This prevents newer group keys from overwriting old ones.
Prevents bugs from creeping in like happened during texture buffer
development.
Bug: angleproject:3573
Change-Id: Iea69cac988e2cf4802a9f64c54cb694d32f1d3e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521238
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
b59437cb
|
2020-11-06T11:07:32
|
|
Check out depot_tools in roll_aosp.sh
Bug: b/150458033
Change-Id: I8b299f96d74499669495ca25d5b08711db90ce61
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522008
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
bb5848d8
|
2020-11-06T10:12:29
|
|
Vulkan: Remove vertex attribute aliasing suppressions
Some suppresions on the GLES3 dEQP expectations file were not removed.
Bug: angleproject:4249
Change-Id: Idcf2da50bb4ae4e6feb62fdb1d44d78aba9041a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522420
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
49d9785e
|
2020-11-06T10:01:18
|
|
Roll SPIRV-Tools from c2b2b5788575 to a61d07a72763 (3 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c2b2b5788575..a61d07a72763
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I11dc44325b0992b14a43fc754586290828cbf1ed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522887
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
0781b693
|
2020-11-06T10:01:07
|
|
Roll SwiftShader from ad54c71632cc to 612ded0654a0 (4 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/ad54c71632cc..612ded0654a0
2020-11-05 srisser@google.com Merge changes I3c4f10f7,I5b7ddc75
2020-11-05 capn@google.com Fix Android.bp build after SPIRV-Tools update
2020-11-05 amaiorano@google.com Subzero: fix invalid arg access on Windows x86 for split variables
2020-11-05 amaiorano@google.com Subzero: fix non-deterministic stack layout and code-gen
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: angleproject:4482
Tbr: courtneygo@google.com
Change-Id: Ia05307b40847dfa6c82b6a53d67706294848a392
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522886
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
32e36bbe
|
2020-11-06T10:01:27
|
|
Roll Vulkan-Tools from 51c1c5ab56d5 to bd0ebb680792 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/51c1c5ab56d5..bd0ebb680792
2020-11-04 shannon@lunarg.com build: Update known-good files for 1.2.159 header
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I995f8b69aab80f8d96524459971bdf49fc844adb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522888
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
dc515d41
|
2020-11-06T07:00:05
|
|
Roll Chromium from 3c7580ad595f to 52d33a46255e (441 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/3c7580ad595f..52d33a46255e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/01b3fe480e..dc348c17b4
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b6526d9ad3..6302c11756
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f1516a7e59..c8d7f9564e
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b8b4d61dd3
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/952382f2b0..192a0edbbe
* tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596
* tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596
* tools/luci-go: git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb..git_revision:1a022d3a4c50be4207ee93451255d71896416596
* tools/skia_goldctl/linux: TzGLaAGOIbgS9g3WS2NIL32_zXI1HeLIIIuDk25O4kwC..GVpht0r-QjWXa70RBjnj16oVOukePZsPqR9WjoyczEQC
* tools/skia_goldctl/mac: Yf-uk3I5Yz6gjKV3mct2yoXT580dpRG4hwbIx8CpW5MC..E1HzztCcEvl2qwMi8jlWEeRipywovPX1tvzNMap-XFgC
* tools/skia_goldctl/win: 6OGcfUna6B3W4PwFB6GuIVRffBaiDQ1HHaOxlOn9FvgC..DsHjiYrgPxP5IjJ3QDF-DgcQwV_lMq60ESSU1CwXBSkC
No update to Clang.
Bug: angleproject:4766
Tbr: courtneygo@google.com
Change-Id: I704ad78ca6474bfa46bed10e84d19b053d485273
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522879
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
04cfe18d
|
2020-11-05T17:50:53
|
|
Metal: Fix typo in TextureMtl::bindToShader
Bug: angleproject:2634
Change-Id: I56d13dda7a6c0ad002db15cb780d7bf6b430bf65
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519712
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
3dfaeeb0
|
2020-10-30T16:57:44
|
|
Vulkan: Don't flush deferred clears on READ framebuffer sync
Deferred clears are not collected when syncing the READ framebuffer.
Prior to this change, we had in FramebufferVk::syncState:
if (READ && deferredClears.any())
{
flushDeferredClears();
}
However, this is impossible / unnecessary:
- Every operation whose syncState (for the DRAW framebuffer) collects
deferred clears will flush the deferred clears. In fact, it's an
error for the next operation's syncState to encounter pre-existing
deferred clears.
- The READ framebuffer is synced before the DRAW framebuffer. This
makes it impossible for there to be deferred clears when READ is
synced.
It may be necessary to swap the order in which the READ and DRAW
framebuffers are synced. See http://anglebug.com/5266. In that case,
if the READ and DRAW framebuffers are identical:
- The DRAW framebuffer's sync will collect deferred clears. The READ
framebuffer's sync will see deferred clears, but it must not flush
them!
Bug: angleproject:4988
Change-Id: I179002d739608ccb8bda95d4379dc6d54e2bf4bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2511372
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
6f755d21
|
2020-11-05T16:12:38
|
|
Fix trigger.py using deprecated parameters.
This changes the script to query the command from mb.py then
call swarming trigger with -raw-cmd and -relative-cwd.
See http://crbug.com/chrome-operations/94
Bug: None
Change-Id: I1e11cd2e1314a4e96e1ee5a42b311f0c3cb5058b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2521240
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
e53efb18
|
2020-11-03T16:22:19
|
|
Allow choosing EAGL or CGL at runtime
Dean Jackson made this change downstream in WebKit:
https://bugs.webkit.org/show_bug.cgi?id=216722
Change ANGLE to dynamically load either EAGL (OpenGLES) or CGL (OpenGL)
depending on both compile and runtime configurations.
Intel Mac -> CGL
Intel Mac Catalyst -> CGL
Intel iOS Simulator -> EAGL
iOS Device -> EAGL
Apple Silicon Mac -> CGL
Apple Silicon Mac Catalyst (with Mac app) -> CGL
Apple Silicon Mac Catalyst (with iOS app) -> EAGL
The trickiest bit is Apple Silicon Mac Catalyst, which depends on the
type of the application it is attempting to run. In that case ANGLE must
compile both the CGL and EAGL interfaces and then pick one to use after
launch.
Bug: angleproject:5253
Change-Id: Iba167b3cc3105e457dcfc9bc14147d0fc3e70bac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2500185
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
|
fbaae6ce
|
2020-07-24T11:47:12
|
|
GL: Add support for GL_OES/EXT_texture_buffer
This extension is core in 3.2
Based on a CL by Jonah Ryan-Davis.
Bug: angleproject:3573
Bug: angleproject:4933
Change-Id: Ib5ce038414075a5cdce36e9404e25d7af33fb39c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519401
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d77e85a8
|
2020-11-03T22:23:18
|
|
Vulkan: Store image updates per level
This optimization allows iterating only over updates of a certain level
or range of levels, instead of having to iterate over every update and
filter out the ones matching the desired level(s).
Bug: angleproject:4891
Change-Id: Ied04f4b28f05d37b9add61c7f4d54cc328c0be86
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519095
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d30f0114
|
2020-11-05T17:46:53
|
|
Metal: Early loop exit during attachments clear
Added BitSetIteratorTest.IterationOrder
Bug: angleproject:2634
Change-Id: I0e9c6ad4d19bbb7d691e46b7ec720e918b170371
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2520956
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
2d964a47
|
2020-10-30T16:46:30
|
|
Vulkan: Defer clears even if following command is scissored
Take the following scenario:
1. glClear
2. glScissor(half of framebuffer)
3. glDrawArrays
The clear in step 1 is deferred. When FramebufferVk::syncState is
called in step 3, the deferred clear was applied using
vkCmdClearColorImage because the draw call is scissored. This causes
loadOp=LOAD to be used after the clear because the render pass is
started too small (the same size as the scissor).
This change makes scissored operations also take advantage of
loadOp=LOAD with deferred clears. A number of changes are made to this
effect:
- FramebufferVk::syncState no longer limits collecting deferred clears
to no-scissor.
- FramebufferVk::startNewRenderPass automatically expands the render
area to full size if it's clearing any attachment.
- A number of bugs are fixed where FramebufferVk::flushDeferredClears is
called with the scissor area. Instead, flushDeferredClears now
unconditionally uses the complete render area. Note that these bugs
didn't have symptoms as "scissor" and "deferred clears" were mutually
exclusive.
Bug: angleproject:4988
Change-Id: I24fc3d88bf9c8998869b36c863692d0f0acce994
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2511371
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
56ea854e
|
2020-10-13T15:57:07
|
|
Metal: Allow unswizzled BC1 RGB
Refine DXT1CompressedTextureTest.DXT1Alpha to pass on more
configurations.
Fix the test's payload so that all 16 pixels use code 3.
Refine texture swizzling detection.
Bug: angleproject:2634
Bug: angleproject:5049
Change-Id: If9e1ab63220170a54954234ea205e19583b0df0a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2467896
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
c07bd2f2
|
2020-11-05T08:58:14
|
|
Ensure trace test failures are unexpected.
This will make the names of the failures show up in Milo.
Bug: angleproject:5310
Change-Id: I64e1f5ffff04ec70a44f8f3d0c339da2bca6b216
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2520539
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
3942e801
|
2020-11-05T10:01:18
|
|
Roll SPIRV-Tools from bcf5b211db92 to c2b2b5788575 (3 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/bcf5b211db92..c2b2b5788575
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I0e311dd24d753720f6f39b9a84a64b233d96963e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2520387
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
986a2443
|
2020-11-05T10:01:07
|
|
Roll SwiftShader from 19f01495a8a1 to ad54c71632cc (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/19f01495a8a1..ad54c71632cc
2020-11-04 capn@google.com Fix Vulkan benchmarks build
2020-11-04 capn@google.com Fix unaligned access on depth values
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: Ia785672bddd6980e55d5ababdf634d46f8bb5bb6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2520622
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
57ca464f
|
2020-11-05T10:01:09
|
|
Roll Vulkan-Loader from 07bbf14a831b to f635feea18cb (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/07bbf14a831b..f635feea18cb
2020-11-02 shannon@lunarg.com build: Update known-good files for 1.2.159 header
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I1ca4934966a757e62ba4ae9655b7ab43af96f824
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2520530
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
1e59a0e1
|
2020-11-05T07:01:40
|
|
Roll Chromium from 9c36b5262108 to 3c7580ad595f (415 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/9c36b5262108..3c7580ad595f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/465d72166f..01b3fe480e
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/95fa84e35d..b6526d9ad3
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/616adef0a3..f1516a7e59
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/dbf0550693..2d8c1340f0
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b8b4d61dd3
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/d044036fd8..eedd6353ca
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c37ae578a8..952382f2b0
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/28a51d0a2e..df43926725
No update to Clang.
Bug: None
Tbr: courtneygo@google.com
Change-Id: I32b2e5755aa2f72ea3c08767b095c3ec72175c3a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519866
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
1e494cae
|
2020-10-07T19:26:01
|
|
Vulkan: Add support for EXT_copy_image
Add support for GL_EXT_copy_image which allows
image data transfer between image objects.
This is implemented by using the vkCmdCopyImage
API call.
Bug: angleproject:3593
Test: dEQP-GLES31.functional.copy_image.*
Change-Id: I30a34a8711b5d2e5834064d7453e03d6ec0df478
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2393955
Commit-Queue: Brandon Schade <b.schade@samsung.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
658ede5d
|
2020-11-04T15:53:09
|
|
LuminanceWorkaroundTextureSwizzleBug test bug fix
This test would create an sRGB format texture without
checking for the GL_EXT_texture_sRGB extension. Skip
the test if it is not supported.
Bug: angleproject:5281
Change-Id: I491e874201c26c9f828772a0fbebaea307ab57a0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519865
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
27af0b2d
|
2020-10-19T16:49:48
|
|
Reland "ANGLE_platform_angle_device_context_volatile_* extensions"
This is a reland of e70f6aa679dd72eca5c88c71b0932928e92d6067
Original change's description:
> ANGLE_platform_angle_device_context_volatile_* extensions
>
> Change from Kimmo Kinnunen downstream:
> https://bugs.webkit.org/show_bug.cgi?id=216106
>
> Add two extensions for EAGL and CGL backends to declare the
> underlying platform context being "volatile". It means that
> the thread-global current context is being modified behind
> ANGLE. If ANGLE context is marked volatile for a particular
> API, it will sync the underlying context for every EGL
> function that needs the context. Most intuitive use is
> for the client to call eglMakeCurrent before calling any
> gl function if the client knowns the platform state might
> be dirty.
>
> Implement eglReleaseThread for EAGL and CGL backends.
> Releasing thread will unset the platform current context.
>
> Fix a bug of omitting EGL_ANGLE_device_eagl from being
> advertised.
>
> Bug: angleproject:5104
> Change-Id: I1ec98ad35bc0caada23556ae8697fdef20f65b1a
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2486548
> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Bug: angleproject:5104
Change-Id: I88265625a4bb4c1412532768d17d7b4356c7be41
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508842
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
|
|
|
fa616931
|
2020-09-03T14:58:03
|
|
Mark uniform samplers in an array unused per element
https://bugs.webkit.org/show_bug.cgi?id=215630
Fix an issue with the OpenGL backend where entire arrays of
uniforms would be marked as unused if a single element was
reported as unused by the driver.
Bug: angleproject:5006
Change-Id: I9bbb75a5f113472393e8d9f1fb60a7865aa9529a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2486540
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
|
|
|
a0e91016
|
2020-10-30T10:01:36
|
|
Vulkan: Don't break the render pass on scissor change
Prior to this change, the render area was decided when the render pass
was started, and remained fixed. If a small scissor was initially used,
this created a render pass with a small area. If then the scissor
region was expanded, the render pass was broken.
This change instead expands the render area on scissor change to avoid
breaking the render pass. If glInvalidateSubFramebuffer previously
successfully resulted in storeOp=DONT_CARE, this optimization may need
to undo that. As a result, the invalidate area is stored in the render
pass and if the render area grows beyond that, invalidate is undone.
Bug: angleproject:4988
Change-Id: I4e8039dec53a95a193a97cb40db3f71e397568d6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508983
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
bf1a4627
|
2020-11-04T12:48:47
|
|
Vulkan: Enable GL_EXT_buffer_storage extension
This change 7bbe497 accidentally disabled support
for GL_EXT_buffer_storage extension for the Vulkan
backend, enable it again.
Bug: angleproject:5056
Tests: angle_end2end_tests --gtest_filter=BufferStorageTestES3*Vulkan
Change-Id: If4da2fe2c3e8b098875c89643d366f15fd0ea8b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519875
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
74e50cac
|
2020-11-04T12:47:52
|
|
Vulkan: Suppress VUID-VkImageViewCreateInfo-usage-02652
Bug: angleproject:5309
Change-Id: Iafe91565138a5b94c482aeff7607d09c10d2aeaa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519874
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
6372a56f
|
2020-11-04T14:07:03
|
|
Gold trace tests: Add logging for filter misses.
The prior fix still didn't work. Add logging to debug why.
Bug: angleproject:5299
Change-Id: I758cfa87066e1cdf4a5d1289c030943e9bded58d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519400
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
4989667a
|
2020-11-03T16:28:37
|
|
Vulkan: Make ImageHelper::flushStagedUpdates take gl::LevelIndex
More consistent with the rest of the public functions in this class.
Bug: angleproject:4891
Change-Id: I72c7c3d21f8287cc1711772671c6e7ad524fd096
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518179
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
6ef8f848
|
2020-11-04T11:10:48
|
|
Trace Gold Tests: Fix filter name.
Was incorrectly checking the individual test name instead of the full
name including the test suite.
Bug: angleproject:5299
Change-Id: I60df15bf1a748ce24d54f56b48ffe6eaca2ba54b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519396
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
ca8b58d7
|
2020-10-25T22:32:45
|
|
Metal: Enable dEQP GLES3 tests on AMD
Bug: angleproject:2634
Bug: angleproject:4235
Change-Id: I159b635b9d02b019a2012da24801a4bdd090961e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497340
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
88b46b9f
|
2020-11-03T12:08:42
|
|
Vulkan: VVL errors once again cause dEQP tests to fail
Was previously setting the global g_debugAnnotator class to
DebugAnnoatorVk, and only when a desktop environment variable or
Android setting indicated to. Setting to DebugAnnoatorVk was equated
with a desire to generate Vulkan debug markers.
Will now set g_debugAnnotator to the generic LoggingAnnotator class
when Vulkan debug markers are not needed. That will enable VVL errors
to again cause dEQP tests to fail.
Bug: angleproject:5291
Bug: angleproject:5304
Change-Id: Ib9169037423dd9de3f799e77f7f47468eeeeac20
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518168
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
23d1f9b4
|
2020-11-02T13:00:08
|
|
Vulkan: Add support for VK_KHR_image_format_list extension
GLES sRGB extensions allows for a texture to be respecified, with say
the sRGB_override extension, which will require us to reinterpret the
data in the texture in sRGB colorspace (or linear depending on the
format of the texture).
If the underlying ICD supports VK_KHR_image_format_list extension we
create a texture's backing VkImage with the
VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT enabled since we already know the
format we might need to reinterpret the texture as.
Bug: angleproject:3609
Bug: angleproject:4561
Bug: angleproject:5281
Change-Id: Ia4bed596ed3000f8af1a8fd73fb8e6c2cb9b5d6e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2513110
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
8a275449
|
2020-10-25T03:22:10
|
|
Metal: Add ES3_METAL to ANGLE_ALL_TEST_PLATFORMS_ES3
Bug: angleproject:2634
Change-Id: Iacc3aaf17565c7b16879897db4b9dac16826d829
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2494526
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
db00732e
|
2020-11-04T10:24:39
|
|
Vulkan display mode: fix skia build failure
Separate angle_use_vulkan_display into another
declare_args() for skia build.
Bug: angleproject:5214
Change-Id: I9f829b8a8c95947832f69ca2d78e050aa60ce8ae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519171
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
9ff063e9
|
2020-10-25T03:08:25
|
|
Metal: fix max varyings, copyImage between mips, depth fmt
- GLSLTest_ES3.MaxVaryingWithFeedbackAndGLline failed before because
gl_Position takes up one slot from max varyings on Metal back-end.
FIXED
- Previously, copyImage() between mips of the same texture would fail.
Due to the read RenderTargetMtl is released before the copy happens.
FIXED
- GL_DEPTH_COMPONENT24 texture data upload didn't work due to the source
32 bit depth data wasn't handled properly. FIXED
- D24S8 format will be disabled on AMD for now, it will be converted to
D32S8 instead.
Bug: angleproject:2634
Bug: angleproject:5235
Bug: angleproject:5242
Change-Id: Ie7082f0545c0885ce5ec72df8a7ec4ee5d5de4b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2494525
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
4707feaa
|
2020-11-04T10:01:07
|
|
Roll SwiftShader from b5bf82693f85 to 19f01495a8a1 (6 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/b5bf82693f85..19f01495a8a1
2020-11-04 capn@google.com Fix LLVM alloca array size type
2020-11-04 capn@google.com Resolve MSan symbols dynamically
2020-11-04 capn@google.com Switch Chromium/Fuchsia to use the LLVM ORCv2 JIT
2020-11-03 nicolascapens@google.com Clarify the ICD/loader compatibility
2020-11-03 swiftshader.regress@gmail.com Regres: Update test lists @ b5bf8269
2020-11-03 capn@google.com Set LLVM_ENABLE_ABI_BREAKING_CHECKS for Debug builds only
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I9f78b5ccdfaa645092c5b01967d51535a6959eb5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518390
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
d896c8d3
|
2020-11-04T10:01:13
|
|
Roll Vulkan-ValidationLayers from 1b2f8307f21d to 128608f6da3a (17 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1b2f8307f21d..128608f6da3a
2020-11-03 mark@lunarg.com tests: Add 2718 security VUID tests
2020-11-03 mark@lunarg.com stateless: Fix clang-formatting issues
2020-11-03 mark@lunarg.com stateless: Comment out unused legacy vuids
2020-11-03 mark@lunarg.com stateless: Output correct VUID for validate_string_array
2020-11-03 mark@lunarg.com stateless: Remove non-VU pNext chain cycle check
2020-11-03 mark@lunarg.com stateless: Remove warnings from viewport validation
2020-11-03 mark@lunarg.com stateless: Use correct VUIDs for drawCount check
2020-11-03 jzulauf@lunarg.com syncval: Add raster order rules to load op validation
2020-11-03 jzulauf@lunarg.com syncval: Add layout transition info w/o prev access
2020-11-03 jzulauf@lunarg.com syncval: Remove unsafe/unused code path.
2020-11-03 jzulauf@lunarg.com syncval: Support range gen w/ empty subres ranges
2020-11-03 jzulauf@lunarg.com syncval: Add dst scope barriers to all ILT
2020-11-03 jzulauf@lunarg.com tests: Add multi dependency syncval test
2020-11-03 jzulauf@lunarg.com syncval: Multidep subpass layout transition rework
2020-11-03 jzulauf@lunarg.com syncval: Simplify input attachment read tracking
2020-11-03 jzulauf@lunarg.com syncval: vkCmdPipelineBarrier multidep support
2020-11-03 jzulauf@lunarg.com syncval: Cleanup input attachment read tracking
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: Ie499781f65a856f4c8c3f6010e2a022f19aec362
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519413
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
0297981c
|
2020-11-04T10:01:18
|
|
Roll SPIRV-Tools from 5735576f87be to bcf5b211db92 (4 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5735576f87be..bcf5b211db92
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: Id1a1dfa8a43cd266a1d6c5bd4b2c1f8c11bbb1b7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518391
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
cb6176f3
|
2020-09-29T01:08:00
|
|
Metal: Support tri-fan & line-loop with primitive restart
Triangle fan:
- If primitive restart is NOT enabled and there is no active render
pass, use Compute Shader to generate indices.
- If primitive restart is enabled, use CPU to generate indices.
Line loop:
- If draw non-instanced without primitive restart, generate and
draw only one additional last segment (fastest).
- If draw instanced, primitive restart is NOT enabled, and there is no
active render pass, use Compute Shader to generate indices (OK).
- Otherwise, use CPU to generate indices (slowest).
Also Disable OcclusionQueriesTest.ClearNotCounted failure on NVIDIA.
Bug: angleproject:2634
Bug: angleproject:5307
Change-Id: Ia5529825807a964f5fcb2a4af8844778896cd42a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2435859
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
945791e1
|
2020-11-04T07:00:37
|
|
Roll Chromium from ce54b897663f to 9c36b5262108 (443 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/ce54b897663f..9c36b5262108
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/af988c68a6..465d72166f
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/98881a1297..95fa84e35d
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/2c417bea4f..616adef0a3
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b8b4d61dd3
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/8cd0fc1ed5..e84c9a3fd7
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4c43492bfa..c37ae578a8
* tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
* tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
* tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ecd52ecc48..28a51d0a2e
No update to Clang.
Bug: angleproject:5124,angleproject:5273,angleproject:5297,angleproject:5298
Tbr: courtneygo@google.com
Change-Id: I402d2869b2997b144fb623d09526a27dd0ba6ad6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518941
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
265c5fa9
|
2020-11-02T21:50:25
|
|
Vulkan: Fix scissor update in FramebufferVk::syncState
A previous change [1] made FramebufferVk::syncState update scissor and
rasterization samples only when the DRAW framebuffer is synced. This is
incorrect as the READ framebuffer is synced before the DRAW framebuffer,
and if the two are the same, the latter is discarded.
Very few functions sync both READ and DRAW framebuffers when they are
identical. A test is tailored to expose this bug.
[1]: https://chromium-review.googlesource.com/c/angle/angle/+/2510013
Bug: angleproject:4988
Change-Id: I6123ac18dded938171bc90a04d4d81f1b42a1694
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2515742
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
dc1c1cb5
|
2020-08-12T13:30:26
|
|
Restrict to translate uniform block to StructuredBuffer
We had translated an uniform block only containing a large array member
into StructuredBuffer instead of cbuffer on D3D backend for slow fxc
compile performance issue with dynamic uniform indexing.
Now we add more conditions to restrict the translation. Only indexing
operator is allowed to operate on this uniform block variable. And we
also restrict the types of uniform block's member.
Bug: angleproject:3682
Change-Id: I992b7890d84fcaa6169722af6d7e14785526d48a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2351728
Commit-Queue: Xinghua Cao <xinghua.cao@intel.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
|
|
|
3980b1f8
|
2020-10-27T10:01:05
|
|
Refactor FrameCapture.cpp to use common utility
The frame-capture-specific AndroidGetEnvFromProp() function has been
ported to the general utility, GetEnvironmentVarFromAndroidProperty().
Bug: b/170249632
Change-Id: I97de8205ceef140dfd8fab8e6f2d52b90cd996cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2502772
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
8afe3f17
|
2020-11-03T10:55:31
|
|
Vulkan: Fix use of uninitialized data in staged clears
When depth/stencil data are staged, only the depthStencil field of
VkClearValue is initialized. However, when comparing staged clears,
memcmp is used which also compares the extra bytes in the aliasing color
field.
Bug: chromium:1144491
Change-Id: Ic384ba792e9fd199d8e9c3e534ccdc6ea65ee9b8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2517244
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
a51b57fa
|
2020-10-30T10:00:05
|
|
Revert "Vulkan: Add features to modify sampling parameters"
Bug: b/167404532
Change-Id: Iae19dfe165074e8c01216312bddd744c4fb504a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2510012
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
64f04516
|
2020-11-03T13:36:11
|
|
Fix presubmit failure with recent glslang update
Recent glslang update moved a #include inside a #if statement.
The scripts/export_targets.py presubmit check doesn't know how to handle
that so need to exclude the header in the script.
Bug: angleproject:5294
Change-Id: I68563d59983ce2053f9e03c84b2736721db9fe95
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518175
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
302f234d
|
2020-11-03T14:55:55
|
|
Gold Trace Tests: Handle test filter.
This will allow the Chromium recipe retry mechanism to work properly.
That in turn will let the recipe properly fail tests that pass without
the patch and fail with the patch.
Bug: angleproject:5299
Change-Id: Ic744e125779c6bc6a091e1ed89ac1be6b97fd942
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518172
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
3e5b6f81
|
2020-10-31T12:33:28
|
|
Enable writing histogram-set-json-format.
This uses the protobuf histogram functionality to build up a histogram
set. The test suites then output the histograms to JSON. This is only
implemented for angle_perftests.
Bug: angleproject:5161
Change-Id: Ia5a7868e8d8dcf4f13d83115ae622828c63ef0d9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2482295
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
39adaeb0
|
2020-11-03T13:15:41
|
|
Don't print reuse warning when forcing new displays.
Bug: angleproject:5274
Change-Id: I2c21a0f097398c508cc116217e3cb97d78a795b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2518241
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
ed90c991
|
2020-11-02T15:22:33
|
|
Fix copyright line format
Removes a double comment indicator from a copyright line. This can
break scripts that parse files to extract copyright and license
information.
Bug: None
Change-Id: I891d865020b64a4ae3dbe9dee369471e3d0368bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2516206
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
6a4c9bbd
|
2020-11-03T11:13:18
|
|
Roll SPIRV-Tools from f7da52775714 to 5735576f87be (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f7da52775714..5735576f87be
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I0601d74d3d121a076d319c044750967cfc3747e6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2516491
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
10bd755d
|
2020-11-03T10:01:27
|
|
Roll Vulkan-Tools from 3f747ee91e3b to 51c1c5ab56d5 (1 revision)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/3f747ee91e3b..51c1c5ab56d5
2020-11-02 nathaniel@lunarg.com mockicd: Remove VK_KHR_portability_subset
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I344cb4e507e9d6cb6cb71a717e4254a154d8fd2e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2516486
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
d3304848
|
2020-11-03T10:01:12
|
|
Roll Vulkan-ValidationLayers from e46399ddd2c7 to 1b2f8307f21d (7 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e46399ddd2c7..1b2f8307f21d
2020-11-02 tony@lunarg.com layers: Fix checks for 02502 and 02503
2020-11-02 tony@lunarg.com gpu: Report OpLine info even if no source
2020-11-02 tony@lunarg.com tests: Add test for variable count descriptors
2020-11-02 tony@lunarg.com layers: Add validation for variable descriptor count
2020-11-02 tony@lunarg.com layers: Fix error message
2020-11-02 jeremyg@lunarg.com syncval: Add override keyword to ValidationObject method overrides.
2020-11-02 s.fricke@samsung.com layers: Relabel vkCmdDrawIndirectByteCountEXT VUs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I90db3ff50f5f4ac44fa3d6df41eb2c8dc60719f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2516485
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
8f81aa02
|
2020-11-03T10:01:07
|
|
Roll SwiftShader from 7751fe38f474 to b5bf82693f85 (7 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/7751fe38f474..b5bf82693f85
2020-11-03 jari.komppa@siru.fi Add script to verify proper Memset template use
2020-11-02 capn@google.com Set the LLVM module's target triple
2020-11-02 sugoi@google.com Merge changes If776b87d,I27098964
2020-11-02 capn@google.com Consistently remove double colon from llvm namespace
2020-11-02 capn@google.com Emulate gather/scatter for MSan builds
2020-11-02 capn@google.com Prevent 'most vexing parse' issue
2020-11-02 amaiorano@google.com Subzero: fix Ice::BitVector::grow not copying old to new data
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: Ic7530ac4dd154ee7aa3c7221db6d34007f904996
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2516484
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
3b9b77ec
|
2020-11-03T07:01:07
|
|
Roll Chromium from a64ace71870c to ce54b897663f (254 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/a64ace71870c..ce54b897663f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/787a783b96..af988c68a6
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/289a835ec8..2c417bea4f
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..52f3a2ddb1
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/eb065289a4..4c43492bfa
No update to Clang.
Bug: None
Tbr: courtneygo@google.com
Change-Id: I3908d8f475866910bde69d21ac0b8f6932f2597c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2516205
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
019e3f77
|
2020-11-02T17:20:19
|
|
Vulkan: Use dst access masks to determine if barrier is needed
Src access mask may be 0 with WAR barriers.
Bug: angleproject:5290
Change-Id: I798d4c36aa7d3d14db333a7e86794e13c8137f96
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514841
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
61180d01
|
2020-10-12T16:40:13
|
|
Reland "Add support for Linux vulkan backend with VK_KHR_display"
This is a reland of a7bb6a9b15ddeb8497523f8871deb25de2676d9f
Original change's description:
> Add support for Linux vulkan backend with VK_KHR_display
>
> Implement Linux simple display mode with vulkan backend
> through VK_KHR_display.
>
> Added value 'EGL_PLATFORM_VULKAN_DISPLAY_MODE_SIMPLE_ANGLE' for
> attribute EGL_PLATFORM_ANGLE_NATIVE_PLATFORM_TYPE_ANGLE to identify
> the new simple display mode. Also reserved
> EGL_PLATFORM_VULKAN_DISPLAY_MODE_HEADLESS_ANGLE for headless mode.
>
> How to enable:
> Add
>
> ```
> use_x11=false
> angle_vulkan_display_mode="simple" # default value
> ```
>
> into args.gn, then compile with linux vulkan args.
>
> Bug: angleproject:5214
> Change-Id: I1247585b9de8b55df106aba99322281f1c183203
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2494320
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: angleproject:5214
Change-Id: I3921f6cb292c86658f39e739a878baad1ef64dba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2515327
Commit-Queue: Xiaoxuan Liu <xiaoxuan.liu@arm.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
6bc362c4
|
2020-10-18T19:09:47
|
|
Allow single threaded CommandProcessor
In replacing the legacy CommandQueue code with the threading
capable CommandProcessor it would be good to be able to run the
CommandProcessor in a single-thread environment. This CL changes the
meaning of the feature flags for the commandProcessor and
asynchronousCommandProcessing so that enabling commandProcess only
changes the code paths to use the command processor but work it still
done as part of the submitting thread (e.g. ContextVk).
Enabling asynchronousCommandProcessing will cause a separate worker
thread to be spawned which will asynchronously process the commands.
This allows us to switch to the CommandProcessor without threading and
then enable threading once performance issues are resolved.
Bug: b/161912801
Bug: b/170329600
Change-Id: I534862b109a7e7708108190b7c3e894071d4c2ed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2483580
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
c06a424f
|
2020-11-02T21:13:39
|
|
Test Runner: Robustly handle unexpected crashes.
This adds the ability for the test runner to parse unexpected crashes
from the stdout. It also processes the stdout to determine which tests
failed. Tests that run after the crash are re-tried in a follow-up
child process.
Will allow for the test runner to handle very crashy test suites and
also processes crashes from win-asan and other configs where it is
harder to intercept crashes.
Bug: angleproject:5251
Change-Id: Iee03130622571580cb7910f4fb097fe3659d75ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2513288
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
3fcf17e6
|
2020-11-02T12:51:35
|
|
Vulkan: Bug fix in sRGBDecode logic
When a sampler's GL_TEXTURE_SRGB_DECODE_EXT state
was toggled between GL_DECODE_EXT and GL_SKIP_DECODE_EXT
VkImageViews of the TextureVk object were not being updated.
Add sRGB_decode state as part of ImageViewSubresourceSerial
so we retrieve the correct VkImageView from the texture cache.
Bug: angleproject:3609
Tests: angle_end2end_tests
--gtest_filter=SRGBTextureTestES3.SRGBDecodeSamplerParameterToggle*Vulkan
Change-Id: I897e461957d408b5a5b4f03fefc05f2e9684c7b7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514900
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
59fbb989
|
2020-11-02T13:27:52
|
|
Test Runner: Add ability to retry flaky tests.
Bug: angleproject:5273
Change-Id: Ie89559bb0897a04213981aa8fe4e2f2bfe78959a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2513287
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
8e878d95
|
2020-11-02T19:58:37
|
|
Roll VK-GL-CTS from e69b9b7294af to 9e07e4424cd4 (5 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/e69b9b7294af..9e07e4424cd4
2020-11-02 alexander.galazin@arm.com Update Vulkan headers
2020-10-30 rgarcia@igalia.com Test invalid pInheritanceInfo for primary command buffers
2020-10-30 michal.m.pawlowski@mobica.com Add array of images copy tests
2020-10-30 rgarcia@igalia.com Test extended dynamic state vertex data offsets
2020-10-30 michal.m.pawlowski@mobica.com Add push constant lifetime tests
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC courtneygo@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com,angle-bots+autoroll-info@google.com
Change-Id: I65627838c072f3e27af0990e41d210707285a66e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514515
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
11cbd12d
|
2020-10-29T13:30:04
|
|
Remove dependency on //build/config/linux:x11
This is needed for Chromium CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2508226
BUG=chromium:1066670
Change-Id: I61aa2a21e19cb74259413631b654cb45e3e051c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2508224
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
4c91061a
|
2020-11-02T18:11:49
|
|
Roll Chromium from f2fabcd1994c to a64ace71870c (130 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/f2fabcd1994c..a64ace71870c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC courtneygo@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/01121614f1..787a783b96
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/3e2640a325..289a835ec8
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..584ab49109
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e5230a2de4..eb065289a4
No update to Clang.
Bug: None
Tbr: courtneygo@google.com,jmadill@google.com
Change-Id: I4343f24ff8458aaee0195ebd9880e0482afe99c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514581
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
924c3dab
|
2020-11-02T13:08:16
|
|
Expand suppression of new EGL test.
This test fails on the older N6P device as well as the N5X.
Bug: angleproject:5280
Change-Id: Ie1a2b3b3a296e2e4dbbed69ebff6ce325b46ce95
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514638
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|