|
6d18ed63
|
2025-07-08T16:26:53
|
|
ValidateGetTexLevelParameterBase: Remove ES 2.0 check
This CL addresses review comments in:
https://crrev.com/c/6710993
1. Remove the ES_2_0 check for GL_MEMORY_SIZE_ANGLE in
ValidateGetTexLevelParameterBase() since the GL_ANGLE_memory_size
extension already requires OpenGL ES 2.0, making the version check
redundant.
2. Update the test MemorySizeTest.BasicUsageTexture to use the function
glGetTexLevelParameterivANGLE() if the context version is below OpenGL
ES 3.1 and the extension GL_ANGLE_get_tex_level_parameter is available.
Bug: b/409384875
Change-Id: I831d4b35eec20fcb4aff331c5a642a749bd52e67
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6715885
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
|
2e9de3c7
|
2025-07-07T16:58:18
|
|
ValidateGetTexLevelParameterBase: Support GL_MEMORY_SIZE_ANGLE
ANGLE supports the extension GL_ANGLE_memory_size, which adds the new
parameter GL_MEMORY_SIZE_ANGLE. However, the parameter value is not
supported in ValidateGetTexLevelParameterBase(), so any calls using it
always fail with GL_INVALID_ENUM.
The parameter is supposed to be tested by
MemorySizeTest.BasicUsageTexture/*, but the portion of the test
validating GL_MEMORY_SIZE_ANGLE is never executed because it requires an
OpenGL ES 3.1+ context, but the test is only instantiated for GLES 2.0
and 3.0.
Based on all the above:
1. Add support for GL_MEMORY_SIZE_ANGLE to
ValidateGetTexLevelParameterBase(), requiring GLES 2.0+ and the
extension memorySizeANGLE is enabled.
2. Instantiate MemorySizeTest to run on GLES 2.0, 3.0, 3.1, and 3.2, so
the entire test is run on devices that support GLES 3.1+ contexts.
Bug: b/409384875
Test: angle_end2end_tests --gtest_filter=MemorySizeTest.*
Change-Id: I70c5721c5da18cb8edbc9a7e18038d5d9fb486da
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6710993
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
89e38b57
|
2022-06-22T15:04:08
|
|
Refactor to use ANGLETest vs ANGLETestWithParam
Bug: angleproject:6747
Change-Id: I72ad52d0268eae0e1a401f12f3e94cc5efa402f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3719002
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
af52f9c6
|
2019-12-03T14:11:17
|
|
Fix tests checking for major version > 3
The tests meant to do getClientMajorVersion() >= 3, but in a few
locations accidentally did > 3.
Bug: angleproject:3569
Change-Id: Ie69898348982c6aae7dac265a18229c257dbfbda
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947458
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
1a01b4b3
|
2019-11-11T16:41:07
|
|
Refactor end2end test macros
This is a foundational CL to enabling the end2end tests on swiftshader.
Refactored infrastructure with new ANGLE_INSTANTIATE_TEST_ES*
macros that will run tests over all various combinations of all
platforms for different ES versions.
Just skipping failing tests initially to get the refactor landed.
Bug: angleproject:4081
Bug: angleproject:4092
Change-Id: I017f6c3267179e49b6ae08cc7488096b423dcdb5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1904635
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
ddc4d33a
|
2019-05-01T15:11:46
|
|
Remove several underused platform configs.
* Removes D3D11 Warp and Reference configs from tests.
* Removes several permutations of OpenGL back-end specific configs.
* Removes FL 9_3 since it is no longer supported.
* Removes present path "Copy" since it's redundant with normal D3D11.
Reduces number of configs from over 60 to 25.
Bug: angleproject:3393
Change-Id: Ia5a23de3c4865b17ee50673a4066757b901a4b5a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1574675
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
b8149075
|
2019-04-30T16:14:44
|
|
Clean up ANGLE test extension functions.
None of these functions needed to be member functions. Also make the
naming more consistent.
Bug: angleproject:3393
Change-Id: I7aafe2269a48af703a87bd9a8cf4cfab9e177dd3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1574673
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
b980c563
|
2018-11-27T11:34:27
|
|
Reformat all cpp and h files.
This applies git cl format --full to all ANGLE sources.
Bug: angleproject:2986
Change-Id: Ib504e618c1589332a37e97696cdc3515d739308f
Reviewed-on: https://chromium-review.googlesource.com/c/1351367
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
1590fcc4
|
2018-11-01T12:44:39
|
|
Add a spec and tests for GL_ANGLE_memory_size.
Change the data type of buffer memory sizes to 64 bit integers.
BUG=892288
Change-Id: I10e07b86f2ccc0cb61c8d7ee0d439e00d5eb8d3a
Reviewed-on: https://chromium-review.googlesource.com/c/1312244
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|