|
cfffc138
|
2019-05-16T11:35:01
|
|
Add KHR-GLES dEQP tests.
This reorganizes the dEQP build targets to allow for better reuse with
the new KHR test set. It also adds a single new test target called
"angle_deqp_khr_tests" that houses all the new test sets.
The new test targets can be compiled now but cannot yet be executed.
That new functionality will follow in a subsequent CL. Along with test
expectations and integration.
Uses a new template type in the build to conslidate GN customization.
Adds the GLES 2.0 and 3.0 tests for now. We can follow up with
additional work for the GLES 3.1+ tests. Also adds test expectations.
Bug: angleproject:3353
Change-Id: Ib0673e97f679c8aa46e27dfa616845a2014a75fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1604070
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
04e389d1
|
2019-05-14T07:14:25
|
|
Vulkan: make sure default uniforms are in std140
Bug: angleproject:3199
Change-Id: I29fdf33ea5af37a66c2cfd5b3355d7ff32105d63
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1614781
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
60cc751a
|
2019-05-06T09:25:27
|
|
Use D3D11 GetDimensions driver workaround for integer cube maps
Some NVIDIA D3D11 drivers are buggy and interprets the level passed to
GetDimensions as being relative to 0, rather than the SRV's MostDetailedMip.
This affects integer cube maps because the dimensions are used for sample
position calculations, which leads to sampling outside the cube side textures
when the base level is non-zero.
Bug: angleproject:3441
Change-Id: I151f9336b9c6d8ec7012bf5010a2d45fb2951e73
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1595688
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
57da8d31
|
2019-05-16T07:01:19
|
|
Roll ./third_party/spirv-tools/src f815e6fe51af..9dfd4b835807 (6 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f815e6fe51af..9dfd4b835807
Created with:
gclient setdep -r ./third_party/spirv-tools/src@9dfd4b835807
The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=syoussefi@google.com
Change-Id: I036f558eed529ed640e0908e1fe30f50793646e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1614556
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
311e8086
|
2019-05-15T13:25:56
|
|
Do struct mapping under conditions
Struct mapping consumes lots of time when the array lengh is very large.
And it's done unconditionally. This CL does struct mapping only if it's
a struct assignment or passing the struct to a function.
In the next step, we can use a function to do struct mapping instead of
struct array initialization.
Bug: angleproject:2967
Change-Id: Ie5a74fa05dbc0255ad664d6265dbb880a624f01e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1612978
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
|
|
|
6ddb7768
|
2019-05-15T15:25:36
|
|
Remove angle:: prefix in angle_deqp_gtest.
Refactor and cleanup only.
Bug: angleproject:3353
Change-Id: I2a01ddf71ba44b8f1a1fc2c4ccbac9edc7c80174
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1613893
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
b4ca09ac
|
2019-05-15T15:23:12
|
|
Add IsDirectory helper function to system_utils.
This was previously a method in dEQP only. Cleanup change only.
Bug: angleproject:3353
Change-Id: I9ac58ab52516f75efbb08bddb39466a40c07cbb8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1613892
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
38ff3c70
|
2019-05-15T10:07:09
|
|
Vulkan:Allow same-named var in nested scope
ESSL 1.00 spec allows for variable with same name to override outer variable
inside of a nested scope. This change adds new scope to symbol table inside
of a function defintion, but after function parameters for ESSL 1.00
shaders (but not webGL). This prevents an error while parsing.
This also includes some new code in translator to rename any vars that are
redefined between the function body and the function parameters. This
prevents an error later on when the translated shader is then parsed as
a desktop GLSL version.
Bug: angleproject:3287
Change-Id: I3f025805cf8d65bf912283bb15e6dad6e5e9b967
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1601553
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
73e17bf7
|
2019-05-14T10:42:25
|
|
Android: Fix symbol compression logic
Update the logic to compress ANGLE's symbols for Android to correctly
include the necessary symbols.
Bug: angleproject:3448
Test: Build and install APK, verify symbols are present during crash
Change-Id: Ibb995aa775d47fb9921e4ab11b956c63ac474c30
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1611750
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
af6a51e0
|
2019-05-15T15:08:00
|
|
dEQP: Make deqp_path GN variable public.
This allows us to reuse it in our other BUILD.gn files.
Bug: angleproject:3353
Change-Id: Ic88f7781010d7319dfe3bb8f2f942fa08d37e4dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1614097
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
|
36f47169
|
2019-05-15T15:36:06
|
|
Suppress flaky OpenGL ES3 test.
Texture2DIntegerTestES3.IntegerTextureNonZeroBaseLevel/ES3_OpenGL
Bug: chromium:963595
Change-Id: I6cdd845a5b7bc1a4b5a16029eaf170db40f1787c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1613894
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
32a1b0f7
|
2019-05-15T15:00:20
|
|
Update dEQP build config to use GN templates.
Templates make it easier to override parts of test configs. Instead
of if statements we can use forwarded variables to override specific
settings. This refactor makes it easier to integrate the "KHR" tests.
Bug: angleproject:3353
Change-Id: Ia6e9c6d01864e5253db5d28dc087bf954aee226c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1612297
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
e77f63a2
|
2019-05-09T10:37:42
|
|
Use clamp cast for stencil mask in all versions.
dEQP only covers this behaviour in ES2.0 tests and they fail when running with
an ES3.1 context.
BUG=angleproject:3425
Change-Id: I339b83901434da92ae6dd6273460b0725644cdf5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1602177
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
eaf2d928
|
2019-04-18T16:31:25
|
|
Add support for OES_depth_texture
Note: Includes workaround for http://anglebug.com/3452 - some Android
devices do not indicate filtering support on VK_FORMAT_D16_UNORM.
Bug: angleproject:3103
Test: angle_end2end_tests --gtest_filter=DepthStencilFormatsTest.DepthTexture/*
angle_end2end_tests --gtest_filter=DepthStencilFormatsTest.PackedDepthStencil/*
angle_end2end_tests --gtest_filter=DepthStencilFormatsTest.DepthTextureRender/ES2_VULKAN
Change-Id: Ic325fb94ab0e619a17c2e149e0e0865fa4142f3a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1575426
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
a253cff3
|
2019-05-15T07:01:18
|
|
Roll ./third_party/spirv-tools/src e935dac9ef8a..f815e6fe51af (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e935dac9ef8a..f815e6fe51af
Created with:
gclient setdep -r ./third_party/spirv-tools/src@f815e6fe51af
The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=syoussefi@google.com
Change-Id: I555803c6e26d7dc9f984437e79703452bdec7b47
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1612155
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
bff32703
|
2019-05-14T18:08:50
|
|
D3D11: Disable B5G6R5 on AMD drivers.
Texture data corruption has been seen with this format, specifically
on AMD Radeon R7 240 cards with the 15.201.1301.0 driver.
BUG=941620
Change-Id: I42d0d86a8319afdfaf17b44e142c6414092c647d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610681
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
a32a0bef
|
2019-05-14T18:37:28
|
|
Add fuchsia-angle-rel to the CQ
Unlike fuchsia_x64, this trybot builds with angle_top_of_tree, and won't
cause random patch failures.
Bug: angleproject:3146
Change-Id: Iea8f93c7e3b6c4bf4514a9c0c6eacca9bd3228c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1611730
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
01cd5697
|
2019-05-14T07:01:18
|
|
Roll ./third_party/spirv-tools/src 2947e88f7938..e935dac9ef8a (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2947e88f7938..e935dac9ef8a
Created with:
gclient setdep -r ./third_party/spirv-tools/src@e935dac9ef8a
The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=syoussefi@google.com
Change-Id: I55a97cd577fd8ae45e0ba93cbf9a7dfaa6122700
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1611439
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
b783fbc7
|
2019-05-10T23:16:17
|
|
Vulkan: Fix matrix uniforms
A piece of code shared with d3d was used to implement this feature.
However, we store the uniform data transposed and row-major in d3d to
accomodate the fact that matrix indexing in HLSL is the opposite of GLSL
(mat[row][col] in HLSL as opposed to mat[col][row] in GLSL).
There were two functions that copied the source matrix fields either as
column-major or source-major (corresponding to `transpose` false or true
respectively in glUniformMatrix*) into a row-major destination. These
functions are refactored into one, which copies from any-major source to
any-major destination. The HLSL backend uses the "to row-major" variant
and the Vulkan backend uses the "to column-major" variant.
Bug: angleproject:3198
Change-Id: I7254da4fbe6916af78c5906abcb82ca01674ab9f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1607541
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
f7033c55
|
2019-05-13T09:48:06
|
|
Vulkan: Request at least 3 images for MAILBOX.
The glmark2 benchmark score went down (on Android with Pixel devices)
when ANGLE changed VkSwapchainCreateInfoKHR::minImageCount from 3 down
to 2, when using VK_PRESENT_MODE_MAILBOX_KHR. In experimenting, this
was confirmed. This CL changes minImageCount back to 3.
Vulkan spec issue #1671 was filed in order to understand whether this
is a good/bad approach for other drivers/platforms.
Test: glmark2 on Pixel2.
Bug: angleproject: 3400
Change-Id: Ia4a72733eb648e4f53feeb8833b174d653fa5766
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610242
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
7d798558
|
2019-05-13T13:40:09
|
|
Skip validating draw buffers when RASTERIZER_DISCARD is enabled.
Bug: 962555, 962636
Change-Id: I4a22f83689252b7b7e51bbb3fc80e8f0d601a43f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610701
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
|
|
|
0a1eeb80
|
2019-05-13T13:53:18
|
|
Call robust resource init before object sync.
This should let the Vulkan back-end only need to sync the Image data
once before we use them.
Bug: angleproject:3427
Change-Id: I8c6e8794e861f855bddbf651997351e8415e3479
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1602912
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
cc5199af
|
2019-05-13T09:44:40
|
|
Roll dEQP (May 2019)
Removes the EGL 1.5 overrides now that they are upstreamed.
Bug: angleproject:3446
Change-Id: I4b17354518534ea821bba83a4b1e00f83f80ac37
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1605786
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
9d519ab1
|
2019-05-09T23:09:46
|
|
Vulkan: Rework layout block storage conversion
Previously, a pass over the shader was made, converting shared and
packed interface blocks with block storage to std140. This resulted in
link success between interface blocks with different storage as they
were all translated to std140.
With this change, this pass is removed. The link step proceeds with the
block storage specifiers as seen by GLES, and only upon Vulkan GLSL
shader generation "shared" and "packed" are converted to std140.
Bug: angleproject:3199
Change-Id: I069415ab9c9b4e1034bc00f64cd2d9e2d73f5956
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1605262
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
0ae59f2a
|
2019-05-10T15:45:27
|
|
Add test to verify uniform matrix upload
Bug: angleproject:3198
Change-Id: Icb63d036a756b849c44d36342c7ba2fc2db0f910
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1604069
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
|
|
|
e1de1ab3
|
2019-05-13T10:53:47
|
|
D3D: Store error message by std::string instead of const char*.
These error strings are stored for recording later we can't depend on them
still being alive so make a copy.
BUG=962439
Change-Id: Ie9156c99b9ce79df4a11087bdcab92d980e959a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610078
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
f1e3609c
|
2019-05-13T08:55:54
|
|
angle: Stop setting secondary_source.
It's no longer needed.
Bug: chromium:947060
Change-Id: I873f17a4876b9d0fac313740853054b6867afeb9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610077
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
|
|
|
e247b5b7
|
2019-05-13T07:01:04
|
|
Roll ./third_party/spirv-headers/src c4f8f65792d4..4b0985f29277 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/c4f8f65792d4..4b0985f29277
Created with:
gclient setdep -r ./third_party/spirv-headers/src@4b0985f29277
The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jonahr@google.com
Change-Id: Iae2bdf19c951a5eaa2f53872b85c14370a5de8ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1608833
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
43f26d70
|
2019-05-13T07:01:19
|
|
Roll ./third_party/spirv-tools/src f6d9a1784313..2947e88f7938 (4 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f6d9a1784313..2947e88f7938
Created with:
gclient setdep -r ./third_party/spirv-tools/src@2947e88f7938
The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jonahr@google.com
Change-Id: I748a71d6f3593926babffeb8fa51e28c52564d20
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1608835
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
d450fab8
|
2019-05-13T07:01:08
|
|
Roll ./third_party/glslang/src 2dd4ab3a4acb..6e384fef6c0f (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2dd4ab3a4acb..6e384fef6c0f
Created with:
gclient setdep -r ./third_party/glslang/src@6e384fef6c0f
The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jonahr@google.com
Change-Id: I77af0c451be06bf5965aa44cbbb9040fac0d7742
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1608834
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
3dbe480b
|
2019-05-06T15:59:07
|
|
Validating draw buffers now also considers color mask settings
It will always return true if all 4 channels of color mask are set
to false.
This should only apply to WebGL. Will fix this in a later patch.
Bug: chromium:958374
Change-Id: I46befaf3ae1b63027dfbb309ac32724c616025d3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1594629
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
29f4ba7d
|
2019-05-10T13:12:59
|
|
generate_stats filters duplicate neighboring rows.
The charts tend to be static for many days in a row, which will now be
filtered to be more succinct.
Also fixes issue parsing when a message interrupts the formatted *RESULT
token.
Bug: angleproject:3435
Change-Id: I9ed213844de469c7a8240ee95aab82451888edf1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1606029
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
e4faae21
|
2019-05-10T08:27:00
|
|
Rename state change notification messages.
This makes the style use CamelCase instead of ALL_CAPS. It also cleans
up some of the naming. It also changes some uses of the messages in
some of the objects to hopefully be more consistent. See the comments
added to the enum SubjectMessage in Observer.h for more details.
Bug: angleproject:3427
Change-Id: I6dff4f6d335ecf1a27e48df65743b1490bd3025a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1600411
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
fdbece20
|
2019-05-09T18:06:34
|
|
Vulkan: Support unsigned int uniform types
Bug: angleproject:3198
Change-Id: Iac5d1389f4f466b7886246d8ca529e8f26a6a5bd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1603629
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
95e58587
|
2019-05-10T07:01:06
|
|
Roll ./third_party/glslang/src e291f7a09f67..2dd4ab3a4acb (4 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e291f7a09f67..2dd4ab3a4acb
Created with:
gclient setdep -r ./third_party/glslang/src@2dd4ab3a4acb
The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jonahr@google.com
Change-Id: Ic93d9def4f27b4acb8243d7bceee4ec0303173cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1604104
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
5dc689c1
|
2019-05-10T07:01:18
|
|
Roll ./third_party/spirv-tools/src 89fe836fe22c..f6d9a1784313 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/89fe836fe22c..f6d9a1784313
Created with:
gclient setdep -r ./third_party/spirv-tools/src@f6d9a1784313
The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jonahr@google.com
Change-Id: Iee30560a214dfad1adb259ec0b836be55dad62bc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1604105
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
7b08d381
|
2019-05-09T00:52:04
|
|
Vulkan: Enable EXT_frag_depth
Natively supported with GLES3 dEQP tests already enabled and passing.
Bug: angleproject:3218
Change-Id: I5ff94e3b16d2025a58d5a448383049f9330dd46f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1600864
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
7ef73a52
|
2019-05-08T10:48:15
|
|
Vulkan: Support flat and centroid qualifiers
Bug: angleproject:3219
Change-Id: I2e0b60bda9c3af2b9eadf2efd3899250925897f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1600335
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
5517ce95
|
2019-05-07T00:27:06
|
|
Vulkan: fix qualifier erase for unused vertex attributes
Bug: angleproject:3219
Change-Id: I8f8f5572eed5126ab03702953883b313f022a264
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1598548
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
9fa248e1
|
2019-05-06T14:55:18
|
|
Vulkan: Implement EXT_draw_buffers
In GLES, color attachments are referenced by their indices. These
indices match between the API and GLSL. For example, if a shader has:
layout(location=0) out color;
layout(location=3) out roughness;
Then GLES would bind and enable GL_COLOR_ATTACHMENT0 and
GL_COLOR_ATTACHMENT3.
In Vulkan, the framebuffer object and the corresponding renderpass
define the color attachments, and they don't allow gaps in color
attachments as GLES does. A render subpass creates the mapping between
the color attachments as defined in the framebuffer and the attachments
used by the shader (with possible gaps).
This change packs the enabled GL color attachments for the sake of the
framebuffer, and sets the subpass up in such a way that the shaders
continue to use the same color output indices as GLES.
In the example above, we have the attachment indices as follows:
Status | GLES | GLSL | RenderPass | Subpass
enabled 0 0 0 0
disabled 1 - VK_ATTACHMENT_UNUSED
disabled 2 - VK_ATTACHMENT_UNUSED
enabled 3 3 1 1
That is, the array of color attachments in the Vulkan
framebuffer/renderpass is:
[0] = GL color attachment 0
[1] = GL color attachment 3
And the array of color attachment references in the Vulkan render
subpass is:
[0] = 0 (index 0 of the renderpass attachment array)
[1] = VK_ATTACHMENT_UNUSED
[2] = VK_ATTACHMENT_UNUSED
[3] = 1 (index 1 of the renderpass attachment array)
Bug: angleproject:2394
Change-Id: Ib6cd2b60882643ea152986eee453270d09cd4aed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1595442
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
776694cd
|
2019-05-08T10:28:55
|
|
Change all ANGLE workarounds to use struct definition with info.
Change each workaround from a simple bool to a struct with info
including name, workaround set, description, and bug IDs. This will help
with future workaround integration with Chrome.
Bug: angleproject:1621
Change-Id: Ia27c180abaf845e280060c803e5994cc3152a057
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1593917
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
cd078c33
|
2019-05-01T10:36:11
|
|
Allow mis-matched Android Context versions
Remove the EGL validation related to context version numbers since a
backwards compatible context could be created and shared, causing a
version mis-match.
Test: angle_deqp_egl_tests
Bug: angleproject:3243
Change-Id: Iae818433fea1b230b50aa47c14f084e9079c3583
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1592133
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
85da00fd
|
2019-05-09T09:02:34
|
|
Remove dontRemoveInvariantForFragmentInput WA
Previously removed supporting code for the workaround
"dontRemoveInvariantForFragmentInput" but missed this declaration.
Bug: angleproject:3285
Change-Id: Ia23b424f2ccbdfe98b7cec79e4290b3621e44238
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1601945
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
|
cf4c6b70
|
2019-05-09T11:33:39
|
|
Print current file in ASSERT macro failures.
Bug: angleproject:3436
Change-Id: If912ae75c96c34b27967f592910c2ee3403b24cc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1602178
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
064b1625
|
2019-05-09T07:01:05
|
|
Roll ./third_party/glslang/src f88e5824d2cf..e291f7a09f67 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f88e5824d2cf..e291f7a09f67
Created with:
gclient setdep -r ./third_party/glslang/src@e291f7a09f67
The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jonahr@google.com
Change-Id: Ia86e00c357164ee9c841d25fb19cc2e6f66d7251
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1602274
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
9f7729f2
|
2019-05-09T07:01:18
|
|
Roll ./third_party/spirv-tools/src d0a1f5a05a2b..89fe836fe22c (4 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d0a1f5a05a2b..89fe836fe22c
Created with:
gclient setdep -r ./third_party/spirv-tools/src@89fe836fe22c
The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jonahr@google.com
Change-Id: I247e92a8fb80856e977a2a611609f7c259194faa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1602275
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
ebab670c
|
2019-04-19T14:36:45
|
|
Adding new extension GL_OVR_multiview
GL_OVR_multiview functions exactly the same as GL_OVR_multiview2.
All GL_OVR_multiview2 tests now also repeat the same test using GL_OVR_multiview
Bug: angleproject:3341
Change-Id: I7e5294fb6bbf7692535174a15da6a42e1b5fc4e2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1575904
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
52e0e65a
|
2019-05-08T12:54:41
|
|
Vulkan:Exclude pragma_vertex test on MAC
With recent pragma invariant(all) fix the pragma_vertex test is failing
on MAC so excluding it from testing.
Bug: angleproject:3285
Bug: angleproject:3433
Bug: angleproject:3434
Change-Id: I59079afdbef2d23a593fe0fe061997624fea5cde
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1601364
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
a10b2d07
|
2019-05-08T10:28:55
|
|
Modify 'bb ls' command for generate_stats for more precision.
We were using 'bb ls ... -A' which combines '-p' and '-steps', but we
only parse information from '-p'. Updates the script to only call what
it needs. Also works around current issue with '-A'.
Bug: angleproject:3429
Change-Id: I10d412885663feefd300eb135dae70b499fedd7f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1600334
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
5cbaa3f8
|
2019-05-07T15:49:22
|
|
Don't inherit ANGLETest SetUp and TearDown.
Instead of inheriting from testing::Test's SetUp and TearDown we add
new methods 'testSetUp' and 'testTearDown'. This helps prevent a common
error of forgetting to call the base class method.
Also add a check in the ANGLETest destructor that SetUp and TearDown
have been called.
Bug: angleproject:3393
Change-Id: Iab211305cc06ffea9ca649e864ddc9b180f2cba0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1593960
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
8fb00484
|
2019-05-08T12:24:41
|
|
fix a freeze when returning from fullscreen to maximized (nvidia only)
freeze happens after repetitive enter & exit full screen mode
Bug: angleproject:3431
Change-Id: Iea4cd75dc30cd17e53c0a7f1174e39b24d878d4b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1599617
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
0412d9e1
|
2019-05-01T12:56:40
|
|
Remove SystemInfo::primaryGPUIndex
primaryGPUIndex is being deprecated in favor of activeGPUIndex, which
represends the expected index of the GPU used for graphics.
Bug: angleproject:3383
Change-Id: I37f992adaf3716fc11e7f34b897c51c0148719cd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1592055
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
b76bf1b9
|
2019-04-18T16:00:22
|
|
Refactor in preparation of adding OES_depth_texture
Rename existing depthTexture extension flag to depthTextureANGLE to
distinguish it from OES depth texture extension to be added.
Bug: angleproject:3103
Test: angle_end2end_tests --gtest_filter=DepthStencilFormatsTest.DepthTexture
Change-Id: I44c69a69b925a84f931518e0374e662893813061
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1575425
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
f5115ed4
|
2019-05-07T14:50:50
|
|
Vulkan: Enable standard derivatives extension
Enable standard derivatives by default for Vulkan.
Bug: angleproject:2903
Test: Validate Skia doesn't generate errors.
Test: CQ Runs
Change-Id: I7f180d4ca03c154db3e9562213127eca1ce65562
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1599857
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
86819f0e
|
2019-05-06T15:34:38
|
|
Roll ./third_party/googletest/src/ 9997a830e..3f5b5b8f8 (3 commits)
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/9997a830ee55..3f5b5b8f8493
$ git log 9997a830e..3f5b5b8f8 --date=short --no-merges --format='%ad %ae %s'
2019-05-03 absl-team Googletest export
2019-04-29 misterg Googletest export
2019-05-02 daquexian566 Fix -Wsign-conversion error by adding static_cast
Created with:
roll-dep ./third_party/googletest/src
Change-Id: I41974bbd233d35b3368ffd42859a4fc8ae3220b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1594628
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
de991d4f
|
2019-05-08T08:34:05
|
|
Roll ./third_party/glslang/src c0640dabfddd..f88e5824d2cf (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c0640dabfddd..f88e5824d2cf
Created with:
gclient setdep -r ./third_party/glslang/src@f88e5824d2cf
The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jonahr@google.com
Change-Id: Ie032526d93c3e540e087994ef3ff3214bcff04ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1600705
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
c9c5c497
|
2019-05-08T07:01:19
|
|
Roll ./third_party/spirv-tools/src 63f57d95d6fa..d0a1f5a05a2b (3 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/63f57d95d6fa..d0a1f5a05a2b
Created with:
gclient setdep -r ./third_party/spirv-tools/src@d0a1f5a05a2b
The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jonahr@google.com
Change-Id: I6f4dcc82c7d3cf50b91f8255d95b7108c8f89529
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1600322
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
19905aea
|
2019-04-26T01:48:31
|
|
Vulkan: Set the Vulkan scissor to the GLES viewport
Some Vulkan drivers are not clipping rendering that is outside of the viewport,
and the Vulkan spec has some language that indicates that ANGLE should set the
scissor:
The application must ensure (using scissor if necessary) that all rendering
is contained within the render area.
In this case, ANGLE is "the application".
Bug: angleproject:3253
Bug: angleproject:3254
Change-Id: I6885a3aa6daed57f6ae1c3d974663d763cad10c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553973
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
e9421b2c
|
2019-04-08T15:16:56
|
|
Vulkan:Only apply invariant pragma to output vars
The "#pragma STDGL invariant(all)" directive should only be applied to
shader output vars. This change also removes the workaround
SH_DONT_REMOVE_INVARIANT_FOR_FRAGMENT_INPUT which is no longer needed.
This change fixes two tests that were incorrectly assuming that the
pragma would be applied to inputs: GLSLTest.InvariantAll[Both|In].
Bug: angleproject:1293
Bug: angleproject:3285
Change-Id: I4eb03fa89fbc7c560150ee0cc32382024b0cb3e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558678
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
|
e4e3b322
|
2019-05-06T15:34:38
|
|
Add using-declaration to support Googletest roll.
Without this change, rolling Googletest results in compilation errors:
https://crrev.com/c/1594628/2.
Change-Id: I85e122ad449a3d8fb155b07f64d69022294ab6cd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1598309
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
|
|
|
84e7932d
|
2019-05-07T12:52:49
|
|
Roll SPIRV Deps (May 7th, 2019)
Required to roll both SPIRV-tools and SPIRV-headers at once due to a
conflicting change.
Bug: angleproject:3422
Change-Id: I8160046899acce01a38e1ddcf43370f278349bac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1599250
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
216f73d0
|
2019-04-12T13:32:30
|
|
Vulkan: add uniform buffer object support
Support for layout qualifiers in interface blocks are added. All
interface blocks are adjusted to either be in std140 or std430.
In the Vulkan backend, a new descriptor set is added for UBOs. A dirty
bit is added for UBO updating and pipeline layouts and descriptor
bindings are updated.
Bug: angleproject:3199, angleproject:3220
Change-Id: I271fc34ac2e1e8b76dee75e54a7cff0fe15fe4ee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565061
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
e76c5c3c
|
2019-05-03T15:51:30
|
|
Vulkan: Enable drawRangeElements()
Enable drawRangeElements() for the Vulkan backend and the associated
tests.
Test: angle_deqp_gles3_tests
Bug: angleproject:3420
Change-Id: I98770631ce1387131bb45e2c1e9df24e911bc692
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1595101
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b62fce15
|
2019-05-02T14:26:02
|
|
Use VPython for dependency management of scripts/generate_stats.py
Instead of installing all dependencies manually, the script should run
with the dependencies specified by the wheels listed in the VPYTHON
section of the header comments.
Bug: angleproject:3415
Change-Id: Ie969ada3ec2550ae2a809164b01930e1590d5db1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1593736
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
f6cbe44a
|
2019-04-18T15:32:07
|
|
Use D3D11 GetDimensions driver workaround for 2D integer textures
Some NVIDIA D3D11 drivers are buggy and interprets the level passed to
GetDimensions as being relative to 0, rather than the SRV's MostDetailedMip.
A test is added which reads from non-zero base level integer texture. When the
workaround is not being used, reads outside the first quadrant return black.
Bug: chromium:679639
Change-Id: I5282a1ba207b2d553d1836f9460ec09cb5590ea6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1591594
Commit-Queue: Kimmo Kinnunen FI <kkinnunen@nvidia.com>
Reviewed-by: Kimmo Kinnunen FI <kkinnunen@nvidia.com>
|
|
|
e211740e
|
2019-05-07T07:01:18
|
|
Roll ./third_party/spirv-tools/src 5fc5303eeceb..106c98d0fa0a (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5fc5303eeceb..106c98d0fa0a
Created with:
gclient setdep -r ./third_party/spirv-tools/src@106c98d0fa0a
The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jonahr@google.com
Change-Id: I28ef8eda4d6ffd0b513150fdb6bc04b2d4a8b2b4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1598439
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
0f4d72e6
|
2019-05-06T10:27:34
|
|
Add makeCurrent and unMakeCurrent to SurfaceImpl.
SurfaceGL had these methods already so they are just moving up the inheritance
hierarchy. This ends up simplifying some state tracking we had in our surface
implementations.
BUG=angleproject:2464
Change-Id: I480588ca8470d9ef507f95e0c0297fe126b3abfb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1595434
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
e755a537
|
2019-04-10T09:58:21
|
|
Vulkan: Add a new garbage type gated by fences.
This allows Vulkan EGL objects such as EGL Syncs and EGL Images to give their
garbage to the renderer before destroying.
BUG=angleproject:2464
Change-Id: I59b8e1080e4292bd0856e59a928750c7e77a372e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1562522
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
d7d42395
|
2019-05-06T13:15:35
|
|
Format all of ANGLE's python code.
BUG=angleproject:3421
Change-Id: I1d7282ac513c046de5d8ed87f7789290780d30a6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1595440
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
8ba78da0
|
2019-04-30T23:42:31
|
|
add support for EXT_blend_func_extended to D3D11
Change-Id: Id66868851a490d0a68a7e76280720825c4844a45
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1591192
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
3e62561c
|
2019-05-06T11:48:52
|
|
Suppress test hitting Nvidia shield driver bug
The same test was hitting a bug with the Nvidia driver on windows+gles.
Bug: angleproject:3413, angleproject:3417
Change-Id: I39426291eac731bcda068829686e09cf406ff661
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1595438
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
66e4850d
|
2019-04-25T10:49:05
|
|
Use EnumAdapters to properly detect primary GPU on Win
EnumDisplayDevicesA returns the card that's connected to the display,
but EnumAdapters return the adapter which the desktop primary is
displayed at index 0. We can use this to determine the device used for
graphics.
Also cleans up the discrepancy between platforms on finding "primary" vs
"active" GPU. Asserts that the GPU expected to run ANGLE commands is the
active GPU, and deprecates the primary GPU to be equal to the active
GPU.
Bug: angleproject:3383
Change-Id: I422fba1bbe47d85b7c09e378d559eaebf89e2625
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1584360
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
c22ef61f
|
2019-04-09T09:55:14
|
|
Vulkan: Store fences instead of serials in SurfaceVK::SwapHistory
Previous swaps may not have been submitted by the same context as the current
swap and we can't safely wait on serials submitted by other contexts.
BUG=angleproject:2464
Change-Id: Ibcb23171feae038fd45abdefb80c4e8a373744e2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1562521
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
37860a70
|
2019-05-06T07:01:06
|
|
Roll ./third_party/glslang/src 86c72c9486a9..c0640dabfddd (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/86c72c9486a9..c0640dabfddd
Created with:
gclient setdep -r ./third_party/glslang/src@c0640dabfddd
The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jmadill@google.com
Change-Id: I5beb96c93380dab0fab809350ec5619b5ea938e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1596388
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
6f0c5b8d
|
2019-05-04T10:00:02
|
|
D3D11: Fix potential invalid VAO access in dispatch.
In some instances running a dispatch call could lead to accessing an
invalid VAO pointer. This seemed to be tied to switching Contexts.
Fix the bug by invalidating the cache pointers on Context switch. Note
that it seems this bug can only affect ES 3.1+ Contexts.
Bug: angleproject:3349
Change-Id: Ib712bcc29215b3fd1c8b7eb0cbd70dea649b3cfc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1594289
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
62742f9e
|
2019-05-01T16:14:50
|
|
Vulkan: Optimize shader source macro replacement
@@ LAYOUT-xx @@ and @@ QUALIFIER-xx @@ macros are generated by the
compiler when emitting Vulkan GLSL. These macros are replaced at link
time in the Vulkan backend.
Previously, this replacement was done through calls to
angle::ReplaceSubstring, reiterating over the whole source on every
replacement. This CL does a prepass on the input source and chunks it
up in blocks. Search is optimized as only blocks of a certain type are
string-compared (skipping large chunks of shader text). Replace is
optimized as the whole shader is not shifted left or right on every
replacement.
Additionally, this CL modifies the layout macro to the following format:
@@ LAYOUT-xx(extra, args) @@
This is used in a follow up CL to have the compiler provide additional
layout qualifiers.
Bug: angleproject:3220
Change-Id: I6367e781c3304d5f2e0a406e4fb4e6feb4c45f1d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1592070
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
be394bad
|
2019-05-02T13:41:19
|
|
Vulkan: Reset swap chain image dependency information when aquiring.
If an image was used by a different context previously, it's stored serial
is not relevent. We always know that any work involving the swap chain image
has been completed by the time we aquire a new one.
BUG=angleproject:2464
Change-Id: I0b12b9ff4b9a68593d661344d2d1e2c9d94e4755
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1592043
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
e25ff9d8
|
2019-05-01T00:02:05
|
|
Vulkan: Fix qualifiers for varyings
`out` variables in the vertex shader and `in` variables in the fragment
shader were not decorated with `layout(location=?)` as they should
according to the Vulkan GLSL spec. This change makes sure these
decorations are present regardless of whether the compiler sees these
variables as EvqVaryingIn/Out or EvqVertexOut/FragmentIn.
Bug: angleproject:3412
Change-Id: I66473e876cb989a60b0c6d6a5850a8b2c763d8e2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1590694
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
58957f3d
|
2019-05-03T12:52:22
|
|
Add option to run each test config in a separate process.
This CL adds a command line option to angle_end2end_tests that will
iterate over all test configs. For each config it'll fork a new child
process that will run only a single config. This will allow us to
isolate each config to a specific child process. Hopefully this will
reduce test flakiness due to driver issues with multiple configs.
The command line option is "--separate-process-per-config".
Note that there are about 25 configs right now.
Bug: angleproject:3393
Change-Id: Ia117b371bbe159c1b0d28d82befffeb0f40467a9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1591428
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
80147d11
|
2019-04-30T16:21:24
|
|
Add support for dynamically allocate initial stack for Angle
By updating YYLTYPE_IS_TRIVIAL to true, YYSTACK_RELOCATE can be enabled, so
we can dynamically allocate stack size based on needs.
BUG=angleproject:3028
Change-Id: I1b9cc0768cd0c6955589695e703595c56d43f24a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1593954
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
467f174f
|
2019-05-03T12:52:21
|
|
Remove EGLTest.
Consolidate these tests into ANGLETest. Add a new parameter to
PlatformParameters that lets us skip normal test setup.
This removes the last 'configless' tests from angle_end2end_tests.
Bug: angleproject:3393
Change-Id: I87186698ade90f95577534eb8ed1dfd4245f740e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1590467
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
97f0affb
|
2019-05-03T12:52:21
|
|
Add command line option to filter by test config.
This allows us to run angle_end2end_tests with a single config without
using gtest_filter. It will also allow us to run each test config in
a separate process.
Bug: angleproject:3393
Change-Id: I09aaf9cfe55a117b0af8d79ecfd129f3d0f1d7c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1591427
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
051b0896
|
2019-04-15T15:39:39
|
|
Vulkan: Fix layout substitution for struct varyings
If the shader contains code such as the following:
struct S {
vec4 field;
};
out S varStruct;
The layout qualifier macro is defined as @@ LAYOUT-varStruct @@.
However, the Vulkan backend was replacing @@ LAYOUT-field @@.
Bug: angleproject:3220
Change-Id: Iae15003867e0bed2cc939159a6653429c7a431e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1571389
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
989bc9a3
|
2019-05-02T13:31:24
|
|
Move ANGLE Platform Methods init to GetDisplay.
Moving the Platform Methods init to GetDisplay allows us to override
the platform methods as soon as possible. This lets Chromium override
the methods via ANGLEGetDisplayPlatform. It also lets us reset the
platform methods when making a new display. Note that because the
methods pointer is global it's a bit tricky to manage between swapping
configs in ANGLE tests. Using a separate test process for each config
should help.
Bug: angleproject:3393
Change-Id: I351f86422e53075563f6d8fce32efbd40023cd23
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1592045
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
7d36b55e
|
2019-05-03T10:29:59
|
|
Consolidate 32/64 bit dEQP results on doc.
These results are somewhat redundant. Don't need to be shown in the
public doc.
Bug: angleproject:3369
Change-Id: I4994cd5714e727afbfe63fb082dab074ed137d43
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1593959
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
3e251337
|
2019-05-02T16:12:54
|
|
Removed SizedFloat helper class from upload tests.
This helper was redundant with the image utils library. Switch the test
to use the existing methods. Doesn't affect test correctness.
This removes more 'configless' tests from angle_end2end_tests.
Bug: angleproject:3393
Change-Id: I49cfbd95c3713b2b4b25c4716a7a279d84ddf994
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1591426
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
926f1caa
|
2019-05-01T14:03:05
|
|
Add support for GCC Compilers
Add support for GCC Compilers, so it can be build on Ubuntu.
BUG=angleproject:3392
Change-Id: I2f5ac7355a40f52123bd465f86b1e966c59c943d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1592062
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
|
|
|
69f72b41
|
2019-05-02T16:12:54
|
|
Simplify ANGLE test config names.
We don't need to use upper case. Lower case can be more readable.
Skip a test on Linux/NV/Vulkan that became flaky after changing
the test order.
Bug: angleproject:3393
Change-Id: Ie027e08ddc9d47b9484cf5b1aaca72a05dd60517
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1574676
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
e421c05c
|
2019-05-03T07:01:18
|
|
Roll ./third_party/spirv-tools/src c8b09744c6a1..5fc5303eeceb (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c8b09744c6a1..5fc5303eeceb
Created with:
gclient setdep -r ./third_party/spirv-tools/src@5fc5303eeceb
The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jmadill@google.com
Change-Id: I9885ba82ef201582c2b0496ba49438d7ce12192b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1594474
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
ddc4d33a
|
2019-05-01T15:11:46
|
|
Remove several underused platform configs.
* Removes D3D11 Warp and Reference configs from tests.
* Removes several permutations of OpenGL back-end specific configs.
* Removes FL 9_3 since it is no longer supported.
* Removes present path "Copy" since it's redundant with normal D3D11.
Reduces number of configs from over 60 to 25.
Bug: angleproject:3393
Change-Id: Ia5a23de3c4865b17ee50673a4066757b901a4b5a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1574675
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
|
3928567b
|
2019-05-02T12:59:21
|
|
Remove fuchsia_x64 from CQ.
This test was failing due to patch errors. This could be because the
bot uses DEPS ANGLE instead of ToT. Removing the bot because it was
causing valid CLs to fail on the CQ.
Bug: angleproject:3146
Change-Id: I7b8b120160fe435832cba919c256ce185ade4d90
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1592602
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
565441b1
|
2019-05-02T07:01:19
|
|
Roll ./third_party/spirv-tools/src 32af42616abe..c8b09744c6a1 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/32af42616abe..c8b09744c6a1
Created with:
gclient setdep -r ./third_party/spirv-tools/src@c8b09744c6a1
The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=jmadill@google.com
Change-Id: Ibb2108c988ea4b27108da68498b5a51e72ff0f0c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1593015
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
3089f92e
|
2019-05-01T15:11:46
|
|
Move EGL Display config into EGLPlatformParameters.
This CL moves all of the EGLDisplay configuration into an EGL platform
struct. Consolidating display configuration in the struct allows us to
move configuration out of the test constructor. Then when we filter
test configs we don't need to wait for the individual test setup.
Bug: angleproject:3393
Change-Id: I5bd06dcdc9f2867ebc43c1d4984077ada35cafc8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1574674
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
ca49e6dc
|
2019-05-01T14:20:36
|
|
Reset the default framebuffer if ContextImpl::onMakeCurrent fails.
Context has the invariant that if it is not current anywhere, mCurrentSuface is
null. If makeCurrent fails in ContextImpl::onMakeCurrent, the surface is not
reset, breaking this invariant.
BUG=angleproject:3414
Change-Id: Icb13c8e2d1edd98d87a8af091a3fbacebadb395c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1592064
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
3c6a36b0
|
2019-05-01T15:02:52
|
|
Fix link to dirty bit diagram.
Also add a missing arrow from VertexArray to Context.
Bug: angleproject:3002
Change-Id: I2a30df0bb1c9681b4cf5178b75f1264ddf4ca2e2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1592065
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
2b2b4d9f
|
2019-05-01T13:05:40
|
|
Add diagram illustrating dirty bit flow.
The diagram source is available as a Google Driver document. It can be
opened with the draw.io web app.
Bug: angleproject:3002
Change-Id: Ic7885c8da1aacac5082eea05d0562d3d62f801ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1592252
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
fc0be049
|
2019-04-18T09:44:06
|
|
Fix GL_MAX_COMBINED_UNIFORM_BLOCKS query
This was previously returning maxCombinedTextureImageUnits instead of
maxCombinedUniformBlocks. Fixing that exposed a bug in the GL backend
where the combined values were sometimes capped to vertex+fragment
values and sometimes not capped at all.
The reasoning for such capping was that the combined limits as queried
from GL contains stages not available in GLES (such as tessellation).
However, the capping failed to take geometry shader limits into account.
This change adjusts such capping to vertex+fragment+geometry. It also
applies the cappping to all combined limits, rather than a select few.
Bug: angleproject:2099
Change-Id: I7231058b5d7f80b1b2452d9f87d4b0ab6e1cdb17
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1572487
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
b8149075
|
2019-04-30T16:14:44
|
|
Clean up ANGLE test extension functions.
None of these functions needed to be member functions. Also make the
naming more consistent.
Bug: angleproject:3393
Change-Id: I7aafe2269a48af703a87bd9a8cf4cfab9e177dd3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1574673
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
ed4feb35
|
2019-04-29T10:06:28
|
|
Add generated dEQP charts to the ANGLE doc.
Also clean up the comments formatting for generate_stats.py
Bug: angleproject:3369
Change-Id: Ifaa26cb898915038cf47e88341db5057b59dd937
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1588315
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
0659c991
|
2019-04-30T16:14:43
|
|
Set swap interval explicitly.
The swap interval can be changed independent of the Surface config.
Thus it makes more sense to set it explicitly in test setup. This
simplifies the test config.
Also updates some of the API for GLWindowBase. Return an explicit
error from makeCurrent.
Bug: angleproject:3393
Change-Id: Ic62b33018e872bc0e38f2848e2427ed898b60749
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1574672
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|