infra/config


Log

Author Commit Date CI Message
Shahbaz Youssefi d788c2c0 2023-12-04T22:43:39 Remove team members no longer part of the project Bug: None Change-Id: I66bf34ece50995fdecfab55a2198e9946e9be4cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5087208 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov b12d4867 2023-11-13T19:35:54 Revert "Temporarily remove trace bots from CQ" This reverts commit 0f7c39a2abbf516443d6e11ba90bc6a3d084e8ca. Reason for revert: trace bots switched to reclient Original change's description: > Temporarily remove trace bots from CQ > > Reclient doesn't work yet > Goma is slower than local today > > Bug: angleproject:8309 > Change-Id: I03c337dab5ee82adc8e03d4f5f52bf2b26aa7cad > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4818506 > Auto-Submit: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Roman Lavrov <romanl@google.com> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Roman Lavrov <romanl@google.com> Bug: angleproject:8309 Change-Id: Ia64d089b759f61570b467e44d566d56e0d0c1534 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5025974 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com>
Takuto Ikuta a46cc37f 2023-08-17T16:35:14 infra/config: remove goma property Bug: angleproject:8309 Change-Id: Ia657986ebc3bc49423736af743983bec6467775a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4787413 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov a469a5d3 2023-09-12T17:28:14 Hide mac-exp-test from LUCI console Experiments were finished Bug: chromium:1456549, chromium:1462473, chromium:1464635 Change-Id: I55f3da2578c84f3d622a5027c07aafed6d02241b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4859442 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Yuly Novikov 0f7c39a2 2023-08-28T16:14:10 Temporarily remove trace bots from CQ Reclient doesn't work yet Goma is slower than local today Bug: angleproject:8309 Change-Id: I03c337dab5ee82adc8e03d4f5f52bf2b26aa7cad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4818506 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Takuto Ikuta 3a5d67ce 2023-08-17T16:25:52 infra/config: add reclient property This CL is no-op but updated config is used in later CL. Bug: angleproject:8309 Change-Id: I49b6ae34ff9abc4eb30c864c5eac3d816b0a4298 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4787411 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Takuto Ikuta 065c93dd 2023-08-17T11:03:08 infra/config: remove unused property This is to reland https://crrev.com/c/4778427. Bug: None Change-Id: I01d9ee2e55a649a235a91f9e78698bd5803d5d7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4787408 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 648f24c9 2023-07-10T17:59:29 Start Mac AMD 13.4.1 experiment Bug: chromium:1462473 Change-Id: Ic30d5f5a0999c10949581aff813febdb83a8cef9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4675805 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Yuly Novikov f834ba7f 2023-06-23T13:48:44 Switch Linux SwANGLE testing to Ubuntu22.04 Turn off experimental builders at the same time. Bug: chromium:1380082 Change-Id: I1cf5f3efef791819ad01af63197bb931af10e019 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4639183 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Yuly Novikov df787cf0 2023-06-14T17:56:11 Add ANGLE experimental SwiftShader builders For testing Ubuntu 22.04 Recipe-side CL http://crrev.com/c/4614428 Testers: linux-exp-swiftshader linux-exp-swiftshader-asan linux-exp-swiftshader-tsan Builders: linux-exp-asan-test linux-exp-tsan-test Modify LUCI MILO console to show only the active experimental builders. Bug: chromium:1380082 Change-Id: Iac74b606fca7b1762028cebf4868e691b3ed074c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4614533 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Jamie Madill f609d294 2023-01-12T12:59:00 Infra: Re-enable TSAN on CV. The flakiness in this config is mitigated by retries now. Putting it on CV should help prevent the regressions that happen often in this config. Bug: angleproject:7944 Change-Id: Ie9d5443bda2031785a5c3d81fb45986272da8b58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4162558 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Roman Lavrov 4403abc0 2023-01-06T16:14:48 Enable merge script failure detection chromium_swarming.expose_merge_script_failures https://crbug.com/1346781#c96 Bug:chromium:1346781 Change-Id: I33c7fcbaa286f4c0401a16c0a03635054c7330f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4144179 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Yuly Novikov e7ded5d9 2023-01-06T14:06:20 Add ANGLE Pixel 6 CQ and Perf bots Keeping the experimental bot to test adding GLES backend tests. Bug: angleproject:6819 Change-Id: I869fc3fe29964756d0231b0a6fc51aa7774963f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4143159 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 64cb7bc0 2022-12-07T11:37:38 infra: Remove toolchain from CI dashboard. With the exception of MSVC and WinUWP, all of our toolchains were "clang". This change makes it so that MSVC/UWP is combined with the OS name to make the dashboard easier to read. Bug: angleproject:7871 Change-Id: I9d86b67504ff6e12b63ddb1f520b4ea6e3f56146 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086742 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 82eba6cd 2022-12-07T11:21:41 infra: Remove UBSAN-specific configs. Because the UBSAN flag is turned on in the ASAN builder, we don't need a separate UBSAN builder. Bug: angleproject:7871 Change-Id: I4f6c8d56bdd209efea381677b2972616b6a6df14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4086741 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov e4054a3f 2022-12-01T16:51:48 Add ANGLE experimental bots for Win Intel Targeting Optiplex 7080. Not running any tests for now. Bug: chromium:1349828 Change-Id: I6e3973c684cbcbefd283f314b2a48bf33f8ce6da Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4071104 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi 7013bc86 2022-11-09T21:57:51 Use Python3 for infra/config/PRESUMBIT.py Bug: chromium:1313804 Change-Id: Ie327b1bc5babd0198f06398e1390843c7e3159c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4018964 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Brian Sheedy f98eecda 2022-11-02T13:05:40 Migrate ANGLE regexp filters Migrates the ANGLE trybot location filter regular expressions to use the newer lucicfg format. The old version was automatically translated to the new version under the hood so this is functionally a no-op change, but this brings the non-generated code in line with now new filters should be added. Bug: chromium:1380568 Change-Id: I5f0c8ece5015d2fc3bdb456fbe2499a335663d79 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4000546 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill f8930fd8 2022-10-11T09:20:24 infra: Increase timeout on perf bots. This sets an explicit 3 hour timeout for all bots, and bumps the timeout for the perf bots to 5 hours. Bug: angleproject:7738 Change-Id: I2ed3ce319046ef8a9ec61128f4970c03ec1d2ecf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3945072 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill b45d3063 2022-09-16T11:56:35 infra: Update Perf bot config names. The NVIDIA bots now correctly name the GTX 1660. The Intel bots rename HD -> UHD. Bug: angleproject:7665 Change-Id: I45ac162ed01724f2cd9c12ea8eb67ebbeb1382dd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3899445 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 8d2988f7 2022-07-25T12:06:51 infra: Add sheriff_rotations to luci properties. This should allow ANGLE builders to show up in Sheriff-o-Matic. Bug: chromium:1288021 Change-Id: Ic3ab746160a2249362b64bbc063e88848a5b23c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3785285 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Quinten Yearsley c8ba755a 2022-07-14T14:27:57 Update version of lucicfg for angle repo and regen config This makes lucicfg generate the new field `location_filters` in commit-queue.cfg, which will replace `location_regexp` after verifying that behavior doesn't change. Bug: chromium:1171945 Change-Id: Id9df67bf5e24bd472e62487ca261024473532a1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3764025 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 8056a5ee 2022-07-13T17:53:17 Add Linux Intel experimental standalone bot For testing Optiplex 7080 Bug: chromium:1342945 Change-Id: I6885222190d735decc28074751c428d2dc0fe588 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3761034 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Fumitoshi Ukai 06bd0c11 2022-06-30T01:58:15 angle: set $build/goma["use_luci_auth"] = True without use_luci_auth=true, goma will use global service account, which uses exported service account key. use task service account by use_luci_auth=true instead. angle-ci-builder@chops-service-accounts.iam.gserviceaccount.com angle-try-builder@chops-service-accounts.iam.gserviceaccount.com are added to goma-rbe-chromium c-i-a group https://chrome-infra-auth.appspot.com/auth/groups/goma-rbe-chromium Bug: chromium:1105814 Change-Id: Ia31c297e77fe2451958a64f2caf2ffeb85864a26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3737242 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Fumitoshi Ukai <ukai@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov dfbdc351 2022-06-21T13:53:32 Run trace_tests on DEPS changes To catch errors when depot_tools are rolled into ANGLE. Bug: angleproject:7433 Change-Id: Ia89377c493737840b3110cd2f069e590bc190c1f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3716583 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 88de1405 2022-06-17T12:49:09 Revert "Temporarily remove win-trace from CQ" This reverts commit f427ae4167421c93544f23e74850ca75d6dba12a. Reason for revert: compile works now https://ci.chromium.org/ui/p/angle/builders/try/win-trace/2078/overview Original change's description: > Temporarily remove win-trace from CQ > > Until compile on it is fixed. > > Bug: angleproject:7433 > Change-Id: Id4fc2b5789d0883d3b74ef66d6b6e71cccb1c057 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707273 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bug: angleproject:7433 Change-Id: I09d841ad207132302b5fbfb4afe9a513fccafa2f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3711744 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuly Novikov f427ae41 2022-06-16T11:56:00 Temporarily remove win-trace from CQ Until compile on it is fixed. Bug: angleproject:7433 Change-Id: Id4fc2b5789d0883d3b74ef66d6b6e71cccb1c057 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3707273 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi f6517f30 2022-06-09T11:53:23 infra: Remove linux-tsan-test from CQ This bot is too flaky. Bug: chromium:1275223 Change-Id: I29a2d30f6d3aa58ee1380eace65df3d78df89ae0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3696829 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill cc19587e 2022-04-01T10:58:43 infra: Use logarithmic batching in LUCI config. This ensures we get more atomic testing and can more easily spot which CL regressed for perf tests or experimental bots. Bug: angleproject:7152 Change-Id: I402cf71be66c365ab509bd9e8d2a5f8c338ab1e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3563514 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 9296f389 2022-02-18T10:45:01 infra: Enable Python 3 for ANGLE recipe. Bug: chromium:1256377 Change-Id: I0c3a71b2a89fc3e271ad8d4f6c9a8cd91b339899 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3472130 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Vadim Shtayura a5badc3e 2022-02-09T11:39:36 [infra] Update active lucicfg experiments. Remove retired noop experiments and add the one needed for the ongoing luci-scheduler.cfg format migration. R: jmadill@chromium.org Bug: chromium:1182002 Change-Id: I759e03f8fd189682c282af0b8a0b108815b46329 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3449242 Auto-Submit: Vadim Shtayura <vadimsh@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Garrett Beaty 25e8f02b 2022-01-26T13:23:26 [infra] Use python3 for run_presubmit recipe. Bug: chromium:1256437 Change-Id: I6ef3d7de6818d13d3e53b0ad5c5a905a8ee62664 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3418137 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 78d482e5 2022-01-13T14:49:26 Add standalone ANGLE Pixel 6 experimental bots The bot only runs dEQP tests with Vulkan backend, not GLES. Also skipping non-Vulkan tests in angle_end2end_tests. Also no perf/trace tests, as these time out uploading to device. Adding suppressions for the failing tests at the same time. Bug: chromium:1280418, angleproject:6819 Bug: angleproject:6898, angleproject:6899, angleproject:6900 Bug: angleproject:6905, angleproject:6907, angleproject:6908 Bug: angleproject:6909, angleproject:6910, angleproject:6916 Bug: angleproject:6917, angleproject:6918, angleproject:6919 Bug: angleproject:6931 Change-Id: I3598e6ff7f458ad7ab2defb86e02a17fbf2d20ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3387108 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 4111f9ef 2022-01-05T15:08:07 Add standalone ANGLE Mac AMD experimental bot For testing Mac OS 12. Bug: chromium:1265563 Change-Id: Iacf86a4cf170c59b2856b1f68e63d2eaa90059fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3367702 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 99b021a1 2021-11-02T10:20:54 infra: Add TSAN and UBSAN tests to CQ. These tests are running with SwANGLE on Linux. Bug: angleproject:5795 Change-Id: I9e5e7ceaee6908e360456755f7fa197364ef3d88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3258004 Reviewed-by: Lingfeng Yang <lfy@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 73e764dc 2021-12-21T13:41:37 Suppress capture/replay tests. BlendIntegerTest.MRTSigned/* = NOT_RUN BlendIntegerTest.MRTUnsigned/* = NOT_RUN These tests became skipped after an expectations change. This CL also updates our luci config to run the trace bots on expectations changes to prevent this happening again. Bug: angleproject:6840 Change-Id: Id40b11995fa9be4613bdbaaa1e3e44f9edfeb464 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3352426 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Robert Iannucci 7f1a0f89 2021-12-14T16:15:32 Switch to non-deprecated bbagent, remove defunct experiments. Bug: chromium:1015181 Change-Id: I130de6cb79c343c066f182ab8f17c4a96aba9219 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3340334 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Ben Pastene fefd7ae6 2021-12-13T22:56:23 Revert "Enable the chromium recipe RDB results experiment for all builds." This reverts commit 8e4302368463012cf78894824a705e5bae57fa6e. Reason for revert: experiment is on by default after crrev.com/c/3321235 Original change's description: > Enable the chromium recipe RDB results experiment for all builds. > > This experiment has been enabled at 100% for all chromium builds > for months now. And the more builders are on it, the more we're able to > refactor the chromium recipe. This was attempted in crrev.com/c/3307244, > but had to be reverted since angle builds re-use much of chromium's > recipe code but don't have the experiment rolled out to them. > > So this rolls it out to angle builds to allow for further clean-up in > chromium's recipe code. Since all angle tests are wrapped via > result_adapter, they should already have RDB integration (meaning their > results are already uploaded to RDB). > > A LED run of a build with this experiment applied: > https://ci.chromium.org/swarming/task/578b98d07382dd10?server=chromium-swarm.appspot.com > > Another LED run with that experiment and the recipe CL relanded: > https://ci.chromium.org/swarming/task/578b9939cfccdb10?server=chromium-swarm.appspot.com > > This matches its original build: > https://ci.chromium.org/ui/p/angle/builders/try/win-test/1026/overview > > Bug: chromium:1135718 > Change-Id: Ief4993fa9c027f9c2c6c3c352eb4e65ce74b628c > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3309479 > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Bug: chromium:1135718 Change-Id: Ief89cef04ee75a8379a815b213e73c8841c9abb3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3336357 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Ben Pastene 8e430236 2021-11-30T12:43:40 Enable the chromium recipe RDB results experiment for all builds. This experiment has been enabled at 100% for all chromium builds for months now. And the more builders are on it, the more we're able to refactor the chromium recipe. This was attempted in crrev.com/c/3307244, but had to be reverted since angle builds re-use much of chromium's recipe code but don't have the experiment rolled out to them. So this rolls it out to angle builds to allow for further clean-up in chromium's recipe code. Since all angle tests are wrapped via result_adapter, they should already have RDB integration (meaning their results are already uploaded to RDB). A LED run of a build with this experiment applied: https://ci.chromium.org/swarming/task/578b98d07382dd10?server=chromium-swarm.appspot.com Another LED run with that experiment and the recipe CL relanded: https://ci.chromium.org/swarming/task/578b9939cfccdb10?server=chromium-swarm.appspot.com This matches its original build: https://ci.chromium.org/ui/p/angle/builders/try/win-test/1026/overview Bug: chromium:1135718 Change-Id: Ief4993fa9c027f9c2c6c3c352eb4e65ce74b628c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3309479 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 60e3dc12 2021-11-26T15:05:45 infra: Trigger win-trace on angle_end2end_tests changes. This should prevent a common class of unexpected CQ breakage. Bug: angleproject:6670 Change-Id: Ic5706caedcb2ca326ec87883d695574e5450083c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304555 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Vadim Shtayura bc2ca15c 2021-11-11T16:29:59 Declare "role/configs.validator" binding. It defines who is allowed to call LUCI Config validation API to validate this LUCI project's configs. This is usually done by presubmit jobs, and thus configs.validator role is assigned to try job task accounts. Previously this ACL was defined in the global "config-validation" group. It is deprecated and being replaced with per-project ACLs defined in per-project configs (like in this CL). There's still a global ACL to allow any googler to call the validation API in any LUCI project they are allowed to see. Thus the per-project binding applies only to service accounts (they are not googlers). Note that this CL was generated semi-automatically and reviewers are picked automatically based on OWNERS file. Bug: chromium:1068817 Change-Id: Iadd19a74e3b0bce330ee0d6fd29046ab03d5c2cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276460 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill bb6732a3 2021-11-02T10:10:52 infra: Add Linux UBSAN/TSAN configs. These are compile-only with this CL, and will start running tests in later CLs. Bug: angleproject:5795 Change-Id: I37b04df2bb4a97aa46545f50bf978dfde65983c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3258002 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill f7552844 2021-11-02T10:05:46 infra: Add ASAN tests to CQ. Bug: angleproject:5795 Change-Id: I316122990739053b28e205282b307a071d5997c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3258001 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 42c0207d 2021-11-11T13:01:18 infra: Remove remaining references to 'master'. These are all now replaced with 'main'. Bug: angleproject:6685 Change-Id: I36cb17625c44d06689f7debf004abd3dd016265b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276517 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill b570a844 2021-11-11T12:25:47 infra: Remove outdated "master" ref in CI config. This should let the CI console start running changes again. Bug: angleproject:6685 Change-Id: I2d172bd9a90b9772efeeaa9cadf0bc865b917e16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276516 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill a9f24fa5 2021-11-08T12:21:25 infra: Switch ASAN to 64-bit on Windows. ASAN is not supported in 32-bits on Windows. Bug: angleproject:5795 Change-Id: Icabf31b8c9ad4d371217c9f4a288f909888eae61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3265532 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill 548e7a2f 2021-11-02T08:50:30 infra: Expose ASAN configs in try. This will allow us to manually add ASAN tryjobs to test before landing. Bug: angleproject:5795 Change-Id: I1085b64f2dcf09e20f470aded0d57befbe4fb084 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3257025 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 616dc268 2021-10-12T13:15:40 infra: Add ANGLE-side configuration for ASAN tests. The ASAN builders will start by running compile-only and only in CI. A follow-up change will enable sharded tests and CQ jobs. Bug: angleproject:5795 Change-Id: I2e761b7bdd2d7215db2210c4538b6cafc4d9069a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3254430 Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 5ab95ec3 2021-10-20T10:07:10 infra: In milo, split console into 'compile' and 'test'. This will provide an easier-to-read summary for wranglers because test failures will be grouped instead of spread out in between compile builders. Bug: angleproject:6496 Change-Id: I45e2f1a868d887de22133684aa0b4821ed4c8f84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3233900 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 0fb59c09 2021-10-18T08:25:26 infra: Remove old bot configs. This can be landed after the change to switch the CQ to the new configs. Bug: angleproject:6496 Change-Id: I3b6ec4697a2fa7a279e5a761ea1717f652af84a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3231835 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill e0de97cf 2021-10-18T08:29:50 infra: Remove SwANGLE bots from CQ. These configs are now included in win-tests and linux-tests. Bug: angleproject:6496 Change-Id: I1ab3961e74bde6672617e4494027da1ff490b352 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226302 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 7fea17b9 2021-10-19T11:08:26 infra: Add new configs to CQ. This leaves the old configs in place. We can't remove them until the CQ bots switch over. Bug: angleproject:6496 Change-Id: Id9ee70cfd65cd85a7525b42f08d78873f31a7cd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226301 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Weiwei Lin aa630727 2021-10-18T00:16:51 [milo] migrate to new bug_url_template The old way of specifying bug template is deprecated. R: geofflang, jmadill Bug: chromium:1218698 Change-Id: I1b3dc9b4ebb3bdcbd6a1f574209f30a8b27f129e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3230302 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0c7018a5 2021-10-12T13:43:20 infra: Update bot naming scheme. Old names: use config pairs when they can vary, e.g. android-arm-dbg android-arm64-rel linux-clang-dbg win-clang-x64-rel win-msvc-x86-dbg win-trace-rel New names: use config names when they differ from the the default test config for a system, and suffix with -compile and -test for compile-only and compile-and-test bots. For Android configs, we keep the full target arch. e.g. android-arm-dbg-compile android-arm64-test linux-dbg-compile win-test win-msvc-x86-dbg-compile win-trace The new naming scheme prioritizes having short names to avoid redundant or implicitly understood information. This should reduce the mental load when looking at a set of test results. This also adds SwiftShader win10-x64 configs so we can add these to the CI easily. Also the plan is to turn off the GCC configs for now. If we ever support GCC properly we can re- enable them. This CL adds the new configs to CI, then a following CL will add them to CQ and remove the old configs at the same time. Bug: angleproject:6496 Change-Id: I0ecdcd392c4d7067d6b180664f160ba7c048d16d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3219590 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 4b056a17 2021-10-08T11:15:25 infra: Remove android-angle-try from CQ. The dEQP GLES / EGL tests on the Nexus 5x are not a configuration we intend to ship. The 5x is over 5 years old and has been discontinued without updates. Because it costs us resources and developer time to maintain these configs, and we still have WebGL testing of this device, remove the native dEQP tests from this config. Also includes a fix to the lucicfg presubmit on Windows. Bug: angleproject:6527 Change-Id: I70bbd3ebdafc63bfd7572b79abcedb711acb4441 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3212892 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Weiwei Lin ce63bc1f 2021-10-06T07:37:24 [milo] update test presentation config to group by test_suite R: jmadill,ynovikov Bug: chromium:1249703 Change-Id: I37ea518a61df324750c7e8d6f18f0446b6316324 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3207826 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Weiwei Lin 8d1e74ab 2021-09-30T00:53:39 [milo] update test presentation config to show GPU column So it will be easier for users to distinguish tests run on different GPUs. R: jmadill,ynovikov BUG: chromium:1249703 Change-Id: I393d305c963f5fc654c9c32fc86cda6c7f019086 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3195351 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov a58749ed 2021-09-22T22:50:10 Revert "Add standalone experimental Mac Intel and AMD bots" This reverts commit a5bbfe2afe29ec53eccf22d33cee200be25de673. Reason for revert: qualification complete Original change's description: > Add standalone experimental Mac Intel and AMD bots > > For qualifying Mac OS 11 on Mac Retina AMD and Mac Mini 8,1 > > Bug: chromium:1241597, chromium:1128540 > Change-Id: I753b504f5910541f5d3f244d117d369937a06d38 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3150752 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: chromium:1241597, chromium:1128540 Change-Id: I4eb71219783651c0e63188e2c94c6ee286625430 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3177332 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov a5bbfe2a 2021-09-03T19:24:29 Add standalone experimental Mac Intel and AMD bots For qualifying Mac OS 11 on Mac Retina AMD and Mac Mini 8,1 Bug: chromium:1241597, chromium:1128540 Change-Id: I753b504f5910541f5d3f244d117d369937a06d38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3150752 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill e1bc8de3 2021-09-08T07:59:37 Change links from 'master' to 'main' branch. Bug: chromium:1226949 Change-Id: Ie7b28b2fa094cf0c0a407968d681e580519cbb88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3148210 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill e30dd478 2021-08-20T17:10:51 infra: Update Milo perf short names. Use the name of the Android device or GPU manufacturer. Bug: angleproject:6090 Change-Id: I2e26586578c51f9a714fed23586854bb14030242 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3111028 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 6c1ad60b 2021-08-20T09:30:47 infra: Make perf builders GPU-config-specific. Separating only by OS makes the perf dashboard uploads land in the same bucket for NVIDIA and Intel results. The two are intermingled on the dashboards. Split this by separating the GPU configs into their own builders. Must land before http://crrev.com/c/3110765 Bug: angleproject:6090 Change-Id: Icee3b19d3462977b4ec86bfe08d7c44431426d24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3110745 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 2ae998ac 2021-08-12T16:24:11 Enable ResultDB on standalone Try builders Including the presubmit builder. crrev.com/c/3087640 missed Try builders and only enabled ResultDB on CI. Bug: angleproject:6275 Change-Id: Ia645205973008c535a2334b3b78b0d95a791c95d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3092465 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov ac2d1434 2021-08-11T15:48:57 Enable resultdb for ANGLE standalone builders Otherwise, they fail with https://crrev.com/c/3088213, e.g. https://ci.chromium.org/ui/p/angle/builders/try/linux-clang-rel/23678/overview Doesn't actually upload to BigQuery yet, pending declaring the tables. Bug: chromium:1135718 Change-Id: Ia429260e2f53f836279383aa84ca3e8e58c3392b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3087640 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Takuto Ikuta d91af7b8 2021-07-06T12:17:33 infra/config: remove unused isolated property angle is migrated to RBE-CAS from isolate. Bug: chromium:1224266 Change-Id: Id2ca778edf6b34f5241da0fbfcd86b43941f83b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3007600 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 8b4f6e6d 2021-06-23T09:06:59 infra: Add perf configs. Adds Win/Linux/Android configs. Bug: angleproject:6090 Change-Id: Ie80a12a16997aab08e9dbba0cc0a9b14414fc8f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988793 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov cc280ff3 2021-06-25T11:07:45 Remove obsolete Android bots from CQ android-angle-chromium-try + android-angle-try replace android_angle_deqp_rel_ng + android_angle_rel_ng Bug: angleproject:4483 Change-Id: I96d51ee610ca7b025e1976d0076409c4990836c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988792 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov c7c3cac0 2021-06-09T15:05:17 Add Android chromium.angle bots to CQ Bug: angleproject:4483 Change-Id: I5a2d76bb9f5183752cbcd6f9381c4aef83edecd7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2950267 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill cf243705 2021-05-25T09:40:39 infra: Remove Pixel 2 (android_vk) tests from CQ. These tests are now fully running on the Pixel 4. Bug: angleproject:5941 Change-Id: Ic0bb094c917226867c3b34ede19986e95ce69b7f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2915565 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill cd535d2c 2021-05-11T13:13:55 infra: Switch Android ARM64 bots to compile-and-test. This will start to trigger tests on the Pixel 4 64-bit bots. Patch Series: 1. http://crrev.com/c/2885381 2. http://crrev.com/c/2885346 3. This CL 4. http://crrev.com/c/2885384 Bug: angleproject:5941 Change-Id: Ib76fd27d0814896522aad84443f52b7f47566e85 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885383 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 91429bb1 2021-05-04T18:13:39 infra: Remove duplicated trybots from the CQ. Removes duplicate Linux, Win and Mac testing. These are superceded by the standalone bots now. Android is still entirely Chromium-based. Bug: angleproject:5114 Change-Id: I745758547b2eaa5f82779b11e7f3a8512c3cdd94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2872072 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill c75969e1 2021-05-06T13:37:54 Revert "Temporarily remove standalone tester bots from CQ." This reverts commit 8f26346b53d9f818996af8da1421af89cf69caaa. Reason for revert: Should be fixed by updated exclusion spec. Original change's description: > Temporarily remove standalone tester bots from CQ. > > Due to RECIPE CRASH, e.g. > https://ci.chromium.org/ui/p/angle/builders/try/linux-clang-rel/21245/overview > > No-try: true > Bug: angleproject:5114 > Change-Id: I42f76fb370ee5423430955643bffb8c2204fa25f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875717 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: angleproject:5114 Change-Id: I781a5a409a9ede005feaf0f3d7bcedac31eaa036 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876986 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 8f26346b 2021-05-05T22:15:34 Temporarily remove standalone tester bots from CQ. Due to RECIPE CRASH, e.g. https://ci.chromium.org/ui/p/angle/builders/try/linux-clang-rel/21245/overview No-try: true Bug: angleproject:5114 Change-Id: I42f76fb370ee5423430955643bffb8c2204fa25f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875717 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Andrii Shyshkalov ab3b50bc 2021-05-03T21:17:14 [infra][realms] upgrade to LUCI security realms in all Angle builds. To be landed after ~1 day at 25% if all is well. Change-Id: I106add7cc9103bde8d77a1c61438ad0fcb54a7b3 Bug: chromium:1204972 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867636 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Andrii Shyshkalov dd4564ca 2021-05-03T17:36:28 [infra][realms] bump usage to 25% of all builds. Change-Id: I106add7749103bde8d77a1c61438ad0fcb54a7b3 Bug: chromium:1204972 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867633 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Andrii Shyshkalov 03a9bf1e 2021-05-03T17:14:19 [infra] use realms on 5% of Angle builds. All swarming tasks triggered from realm-enabled build will be realm-enabled, too. This CL is safe to revert in case of problems. The problems, if any, should not affect CQ badly due to retries, but on CI they'd probably manifest as purple builds that won't be retried without human involvement or new Git commit. Change-Id: I106a587749103bde8d77a1c61438ad0fcb54a7b3 Bug: chromium:1204972 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867083 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Andrii Shyshkalov 32ed5069 2021-05-03T17:08:02 infra: init LUCI Realms config for Angle. This doesn't yet have any effect on Angle builds/tasks, but allows to associate Angle pools with the Realms config in https://crrev.com/i/3802849 Change-Id: Id756c14e7e181cc1820cee735668949bf9567d0c Bug: chromium:1204972 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867082 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Andrii Shyshkalov de3753d4 2021-05-03T17:05:37 infra: validate configs using lucicfg tool in PRESUBMIT.py This validates that: a) checked in generated files correspond to what lucicfg actually generates; b) lucicfg is formatted c) (same as before) configs are validated against respective LUCI services. Change-Id: I727723beb4172c3dd265c4a4edbc2ecbfb479eb9 Bug: chromium:1204972 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867081 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Andrii Shyshkalov 471e62c8 2021-05-03T12:23:17 infra: remove redundant ACL. Bug: chromium:1204972 Change-Id: If3ab89699adfc47d0a163f8b999da17b10d86ebd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867079 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill a29ab50f 2021-04-29T11:22:03 infra: Add isolate server properties. These are necessary to work correctly with swarming. Bug: angleproject:5114 Change-Id: I634e408e523284a935b77f62b95c9bc85e9e997f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859982 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill ed8755df 2021-04-27T21:33:04 Revert "infra: Add different builder group from ci/try." This reverts commit 281b12d2e54cf9526bdb6e2610f8cdc28285f2a9. Reason for revert: Broke bots. Original change's description: > infra: Add different builder group from ci/try. > > Uses the 'client.angle' and 'tryserver.angle' naming scheme that > both V8 and WebRTC use. Necessary for the scripts to work with > swarming tests. > > Bug: angleproject:5114 > Change-Id: I107cf0018e2173117e1d90e840b8e1419e69ef55 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854277 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5114 Change-Id: I2501f3ad89bc21d80ccdeabd52234a1fc5b39a49 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2855594 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 281b12d2 2021-04-27T15:23:02 infra: Add different builder group from ci/try. Uses the 'client.angle' and 'tryserver.angle' naming scheme that both V8 and WebRTC use. Necessary for the scripts to work with swarming tests. Bug: angleproject:5114 Change-Id: I107cf0018e2173117e1d90e840b8e1419e69ef55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854277 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 6505a768 2021-04-27T10:51:46 infra: Switch Android builders to compile-only. Initially testing will only be on desktop. Bug: angleproject:5114 Change-Id: I384e4f81cee3a810fad42e73711862725e786ef2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854276 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Josip Sokcevic cbfa28a0 2021-04-26T14:44:52 Add CQ for main branch Bug: 1203009 Change-Id: I3c7745531cca659901be05f7c7c3c89ba8350096 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2851902 Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 1bdd34ff 2021-04-26T09:04:59 infra: Add test specs for standalone tests. Includes test specs for Linux/Mac/Win7/Win10. Android is left out for a second pass to keep the changes a bit simpler. Bug: angleproject:5114 Change-Id: I94e7f7f273073f85488ec982e89b4b68f45627ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2805371 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 2a403f91 2021-04-23T15:29:31 infra: Set MSVC builders to compile-only. We want to preserve the current test set without accidentally enabling new testinig paths with infra changes. Current MSVC is supported as compile-only. Bug: angleproject:5114 Change-Id: Iffc4ac3f7dc3845e5d767fdcdbfa9d5fac27f371 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848646 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 7740e434 2021-04-21T13:26:54 infra: Add Android builders to CQ by default. The build is now green and we can start testing this pre-commit. Bug: angleproject:2344 Change-Id: Icfa58f02727228468e422f4f596deb5c1e2dcfe1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842356 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill d170f8e1 2021-04-20T19:17:17 infra: Add configs for Android build. Updates the configs to use the new protobuf properties. Adds support for ARM/ARM64 Android builds. Must be landed in conjunction with http://crrev.com/c/2841787 . Bug: angleproject:2344 Bug: angleproject:5114 Change-Id: I49f4f46ceaa7ce9118c9f4b4ceb06353b00429b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842306 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 3691797a 2021-04-19T16:16:59 Revert "infra: Switch to "angle_2" presubmit config." This reverts commit 5166a25b2ccf04881c3fc1cd3f19e2246b23fec0. Reason for revert: Breaks presubmit tester (again). Original change's description: > infra: Switch to "angle_2" presubmit config. > > We will revert this once we remove the depot_tools config. > > Bug: angleproject:5114 > Change-Id: If922a24c9955ba5d5d30ec634fa6c3d6db177f65 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831999 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5114 Change-Id: I7a540c728f6851151c2f708480de21ce41938111 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2836785 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 5166a25b 2021-04-16T20:07:32 infra: Switch to "angle_2" presubmit config. We will revert this once we remove the depot_tools config. Bug: angleproject:5114 Change-Id: If922a24c9955ba5d5d30ec634fa6c3d6db177f65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831999 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 12342643 2021-04-14T08:49:24 infra: Remove osx_sdk cache. This is no longer necessary now that we use mac_toolchain.py. Bug: angleproject:5114 Change-Id: I0afac641d55e9be2bd04103301aec3080d3332c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2823859 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 6faf9ef3 2021-04-13T16:11:50 infra: Remove unused debug/cpu properties from tests. These are now configured through mb_config.pyl. We still pass in the properties to the lucicfg helper function set up the waterfall UI. Bug: angleproject:5114 Change-Id: Ib46ab95f5803a166fd2342679afbfcaa6f467c45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822233 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov ad01350e 2021-04-13T16:11:13 Remove obsolete Linux, Ozone and Fuchsia bots from CQ Also removes the new linux-ozone-angle-try bot, since we are no longer interested to test on this configuration. Bug: angleproject:4483, chromium:1187259 Change-Id: Iaf50ba99905498cee5dbcac27e1cd7c936c8a975 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822234 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 77600bcb 2021-04-11T16:52:15 infra: Remove named vs_toolchain cache. This is no longer needed now that ANGLE uses the pinned depot_tools. We should land this after the recipe updates to no longer use the cache. Patch series: 1. http://crrev.com/c/2819943 2. http://crrev.com/c/2819472 3. This CL Bug: angleproject:5842 Change-Id: I5d166c7cd66a9d7f077c09b4149de08b22724af8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819945 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill f7019e45 2021-04-05T11:42:30 infra: Add builder group to CI properties. The builder group is necessary for recipe scripts. A first preliminary step towards standalone testers. Note on naming: Chromium bots use "chromium.X". WebRTC and V8 use "client.webrtc" etc. Going with just "angle" for simplicity. Bug: angleproject:5114 Change-Id: Ie0e47aa28eaeab4ebe8d13900c1b68cad8a7a1a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2805892 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov d62fc236 2021-04-01T12:25:10 Add Linux, Ozone and Fuchsia chromium.angle bots to CQ Bug: angleproject:4483 Change-Id: I8e3e415d96e267e48efc723098bd04baf9c9a321 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2800311 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 67232387 2021-03-25T16:04:07 Remove old Win x86 bots from CQ win-angle-chromium-x86-try + win-angle-x86-try replace win-angle-rel-32 + win-angle-deqp-rel-32 Bug: angleproject:4483 Change-Id: If2c6d13937d61793f8b1845dc4aec83cae43d3b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2787197 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 4d7ea943 2021-03-11T21:05:29 Remove old Mac bot from CQ mac-angle-chromium-try + mac-angle-try replace mac-angle-rel, adding dEQP testing on top of it Bug: angleproject:4483 Change-Id: I477b3ef884e4e92c9ab11a55d7a8a3f4f4e0c02b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2753491 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 25c084a7 2021-03-09T12:51:34 Update Xcode used by standalone Mac builders to 12.4 12D4e is latest Xcode 12.4 as of http://crrev.com/c/2715984 Bug: angleproject:2634 Change-Id: I0e0412c7911a109d5351b73a4676c018ee461318 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743669 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 74562a2d 2021-03-05T16:00:25 Add Win x86 chromium.angle bots to CQ Bug: angleproject:4483 Change-Id: Ib3c1dc81340ac792a2c4aa7a2473688b4a036aef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739386 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>