kc3-lang/angle

Log

Author Commit Date CI Message
Roman Lavrov d5720c86 2024-01-29T15:39:57 Reland "Add third_party/perfetto" This is a reland of commit 4b76bead8f18cccde1a6322038038d66871168d9. No additional change on top of original CL. The issue https://b.corp.google.com/issues/323199418 was caused by a mistake during manual merge between aosp ANGLE and chromium ANGLE: https://android-review.git.corp.google.com/c/platform/external/angle/+/2937802/-1..1 The third_party/perfetto was not supposed to land in aosp because Android doesn't support submodules. The third_party/perfetto is supposed to be deleted by skia auto-roller. But if it is a manual roll, we need to manually delete the submodules. Original change's description: > Add third_party/perfetto > > Conditional on checkout_angle_restricted_traces = True in .gclient > > Cloned from android, similarly to Chromium: > https://crsrc.org/c/DEPS;drc=8f0a542b7501f6c09e8c9c6e273a9bf18742faf5;l=1664 > For now not auto-rolled, will likely need to figure out a way to as > "prebuilts" are rolled around once a month, which we don't neccessarily > need but not sure how long the previous ones remain available. > Bug: b/322779830 > Change-Id: I7c763d26f8a4d446502682bbf6d39dbd5e743827 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5245648 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Roman Lavrov <romanl@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> Bug: b/322779830 Change-Id: I51d5dff753ed0b57ee91218a070bfbdeb33e9c44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5259749 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi c70c329e 2024-01-31T15:59:19 Vulkan: Fix texture copy vs pre-rotation A minor error where the destination offsets were swapped based on source rotation. Bug: b/319336510 Change-Id: I5541f8d0bf0b7306b951d2601c8c27ffedb8470e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5254238 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll ffe758b1 2024-02-02T16:44:53 Roll VK-GL-CTS from fe0d0f90469f to 1aeae2d1d57e (11 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/fe0d0f90469f..1aeae2d1d57e 2024-02-02 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.8 into vk-gl-cts/main 2024-02-02 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2024-02-02 amber@igalia.com Remove frexp/frexp_st spir-v assembly tests 2024-02-02 ziga@lunarg.com Test vkDestroyShaderEXT with NULL handle 2024-02-02 cturner@igalia.com Ensure the custom video device is setup correctly 2024-02-02 cturner@igalia.com Wait for sparse allocation signal 2024-02-02 jbolz@nvidia.com Fix object counting issue in host_visible depth test 2024-02-02 marcin.hajder@mobica.com State leak in NegativeShaderApiTests 2024-02-02 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main 2024-02-01 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2024-01-29 alexander.galazin@imgtec.com Notice of withdrawal of Vulkan SC CTS 1.0.1.x If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I06239466c569ba0d14d4a47703daeda0a0814f98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5262300 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand 82ba79ff 2024-01-08T15:22:59 OpenCL: Update CLtypes.h to cl_types.h This change/enhancement is to keep codebase more consistent since vulkan backend versions of this header use lowercase-snake_case for file name. Bug: angleproject:8501 Change-Id: I223712c72db06425d192ddfe7300e5475c341e38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5233364 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 0c3a6aa6 2024-02-02T10:01:31 Roll SwiftShader from d040a5bab638 to eb75201a4e03 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/d040a5bab638..eb75201a4e03 2024-02-01 syoussefi@google.com Revert "Default to use llvm16" 2024-02-01 yuxinhu@google.com Add llvm-16.0 required files for windows platform 2024-02-01 yuxinhu@google.com Revert^2 "LLVMReactor: Remove CreateFreeze() call" 2024-01-30 rsworktech@outlook.com Default to use llvm16 2024-01-30 syoussefi@google.com Fix MSAN complaint about uninitialized (and unused) value If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ie4f9ae186beac2d983d57e447f48baa699d398a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5261673 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll a45a6c1d 2024-02-02T07:48:23 Roll Chromium from 861058c0b131 to 37f9e1b14cf7 (513 revisions) https://chromium.googlesource.com/chromium/src.git/+log/861058c0b131..37f9e1b14cf7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a18493935f..78ad07d164 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d8688b9036..43e76969b9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/65cf295f16..32ff18c00f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c75e76358d..e8367e6d6e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/92469e017f..7142bf166c * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/28aa23ffb4..030b3ed3a4 * third_party/r8: MNhASYP6ZVlHl8MT2UzlSGnCH9LMHjUMkz49rrlsb7wC..Cwp-cRksMvELPD_6Gt9Cse08DbIIA8_am3yQuDCx_wYC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/244bd6f732..b9d6e4a6ed * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a9f8e2f885..c6dfd64fd9 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ia47b95ad267be3fb546d202fec2eb8a1a566c576 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5261719 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Austin Annestrand f8c06f10 2023-11-30T17:45:35 OpenCL: Add types to cl_mem origin and region Now using cl::MemOffset and cl::Coordinate. Bug: angleproject:8439 Change-Id: Id775fe78467d3b56d2a7cc87f793221ab5e04bc5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5078244 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi ecc35205 2024-01-25T23:58:25 Move uniform block dirty bits to State When glUniformBlockBinding changes the mapping from a program uniform block to a buffer binding, all contexts in the share group need to reprocess the affected block index. Prior to this change, the dirty bits that indicated which blocks have their mapping redefined were placed in the program executable, and were reset by the first context that processed them. As a result, the other contexts in the share group where not aware of such modifications. Similarly, when a buffer changed in one context, the mapped program blocks were marked dirty, with similar cross-context issues. In this change, the dirty bits are moved to State, so every context would react to these changes. Bug: angleproject:8493 Change-Id: I5712002224cbc4a576bf2ac46e8e75f26ebc5b2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5238991 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll ea1cea77 2024-02-01T08:34:02 Roll Chromium from d3635c12e43a to 861058c0b131 (574 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d3635c12e43a..861058c0b131 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7a16bc81a9..a18493935f * buildtools/reclient: re_client_version:0.128.1.7c74998-gomaip..re_client_version:0.130.0.546556b-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/46ea5627a5..65cf295f16 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/594e0ed1c4..d391aa34a6 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/719cd9d917..c75e76358d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/10bd39fd47..92469e017f * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f48a08be15..0c4e8fac5c * third_party/r8: -2s3swpHJcZRAGeWCKjYARXN0pneLMhyYGBkbbAqz6gC..MNhASYP6ZVlHl8MT2UzlSGnCH9LMHjUMkz49rrlsb7wC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3ccf8c4439..de6b303a89 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I012fb974f72ffb373cd7966ad60525237f5a2f94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5255839 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 1abfdc37 2024-01-31T10:24:51 Remove suppression of VVL error Remove the suppression of VVL error VUID-VkFramebufferAttachmentImageInfo-viewFormatCount-09536. This change in ANGLE https://chromium-review.googlesource.com/c/angle/angle/+/5246088 properly fixed the VVL error. Bug: angleproject:7553 Bug: angleproject:8513 Change-Id: Ic866bae689a649fdabfde8e80a882595e2e7947c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5249864 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Yuxin Hu 6340ed68 2024-01-31T19:26:10 Revert "Add third_party/perfetto" This reverts commit 4b76bead8f18cccde1a6322038038d66871168d9. Reason for revert: To unblock Android build team https://b.corp.google.com/issues/323199418 Original change's description: > Add third_party/perfetto > > Conditional on checkout_angle_restricted_traces = True in .gclient > > Cloned from android, similarly to Chromium: > https://crsrc.org/c/DEPS;drc=8f0a542b7501f6c09e8c9c6e273a9bf18742faf5;l=1664 > > For now not auto-rolled, will likely need to figure out a way to as > "prebuilts" are rolled around once a month, which we don't neccessarily > need but not sure how long the previous ones remain available. > > Bug: b/322779830 > Change-Id: I7c763d26f8a4d446502682bbf6d39dbd5e743827 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5245648 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Roman Lavrov <romanl@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> Bug: b/322779830 Change-Id: I777b06ed2732eb198785a21d04de1f63bec7cef5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5249865 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Peiyong Lin <lpy@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Liza Burakova 157088ad 2024-01-30T20:24:50 Add EGL extension for WebGPU Bug: angleproject:8476 Change-Id: Ic5aad4eb56239d9346c6ba1f812d070ce85131a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5245895 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
Matthew Leibowitz a70b6f56 2024-01-26T20:37:07 Add support for WinUI3/Windows App SDK Adds the necessary build args and code changes to support building ANGLE for WinUI 3 (aka Windows App SDK). To reduce the set of changes, and because it is functionally the same, a Windows App SDK build is basically a UWP build, but with an extra define so that the code can make a few changes to the namespaces and includes used. The main changes to the code are: - ICoreWindow is no longer used - Dispatcher has a few changes in naming and args - ISwapChainPanel is now in a different namespace Bug: angleproject:8490 Change-Id: Ibb298e3e86e8298dac12c2019eac7996a8185c51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5230637 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Bani Singh 0640f651 2024-01-30T17:42:31 USE GCE Credentials for Chrome Bot In case of bot, use GCE instead of automatic_auth which will no longer fall back to ADC (and hence GCE). Bug: b/319246651 Change-Id: I86942c30bea911b1cc89870a748bf564584af660 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5249329 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll be8d1c24 2024-01-31T07:01:37 Roll Chromium from 84709e977bd1 to d3635c12e43a (585 revisions) https://chromium.googlesource.com/chromium/src.git/+log/84709e977bd1..d3635c12e43a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/de7324e572..7a16bc81a9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ec54c350e6..46ea5627a5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/92b51e4fd5..719cd9d917 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b808b1bcdd..10bd39fd47 * third_party/r8: C9JntVaHiVuPur-3AdTgT9LdF-92xV5S53GPX-ahZsMC..-2s3swpHJcZRAGeWCKjYARXN0pneLMhyYGBkbbAqz6gC No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I2e943a9e14eee9efbf78b119e5ca8dd83c09117c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5249862 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 0ada0b7f 2024-01-29T16:36:18 Test: Add Plague Inc. trace Test: angle_trace_tests --gtest_filter="*plague_inc*" Bug: b/321562592 Change-Id: I1a68b80659517aec61315e51cacc486f44410cdf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5250428 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
angle-autoroll b514d773 2024-01-30T21:43:57 Manual roll vulkan-deps from 97f44eb2b9df to 3834da2004ec (22 revisions) Manual roll requested by yuxinhu@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/97f44eb2b9df..3834da2004ec Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/79536da264..f6f9840eab * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/ae6a8b3971..1c9115b562 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/69197ba90b..e5fcb7facf * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/ca4c1e6e42..90b990e43b * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/7c6d640a5c..5a5e17fbcc * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/822dd7f3a6..b6f52799ec * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/60dd0ad44f..6f55c100c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I7919d893c02b945d191081606e5c0fddd0213668 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5251515 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Kaiyi Li dcffb53e 2024-01-30T19:41:49 Revert "Clean up ANGLE on system build configuration." This reverts commit 98e026685123f19f01304dcdc1deb2f52cb80f67. Reason for revert: This CL breaks the build for the downstream user that is using the main branch ANGLE on some old udc branch Android tree(b/322960439): Original change's description: > Clean up ANGLE on system build configuration. > > Now that ANGLE on system is in fully released, clean up the build file > configuration and remove the flags. > > Bug: b/293503000 > Test: atest CtsAngleIntegrationHostTestCases > Change-Id: Ic31911e097b479861d380e44ec424131c928a9aa > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5234093 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Auto-Submit: Peiyong Lin <lpy@google.com> > Commit-Queue: Peiyong Lin <lpy@google.com> Bug: b/293503000 Bug: b/322960439 Change-Id: I506150d7e5802b8f6cc0fee45105a5423ab06b5d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5251056 Commit-Queue: Peiyong Lin <lpy@google.com> Auto-Submit: Kaiyi Li <kaiyili@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Peiyong Lin <lpy@google.com>
Cody Northrop 9ca81c7e 2024-01-21T13:35:06 FrameCapture: Handle zero vertex count draws Seeing the following from GLES1 (note count = 0): glDrawArrays(context = 1, mode = GL_POINTS, first = 0, count = 0) This crahes in FrameCaptureShared::captureClientArraySnapshot: 'length_error was thrown in -fno-exceptions mode with message "vector"' The function assumes vertexCount will always be greater than zero. This CL updates it to detect the empty case and simply return. Negative counts are already handled as a GL error. Test: Plague Inc MEC Bug: b/321562592 Change-Id: I3613eaac297a3471dc998b023bf2658413cb5d1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5250427 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mike Schuchardt <mikes@lunarg.com>
Geoff Lang 98846aa8 2024-01-30T10:23:48 Metal: Temporarily disable asm injection. Some Mac11 bots started to fail after the asm injection started. Disable this path to determine if it was the root cause. Bug: chromium:1522730,chromium:1513738 Change-Id: I2580f124735f576257bb46fbf47394ff845384f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5249328 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll e8498029 2024-01-30T09:08:07 Roll Chromium from 0fdef08dd9c7 to 84709e977bd1 (621 revisions) https://chromium.googlesource.com/chromium/src.git/+log/0fdef08dd9c7..84709e977bd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ddaf87b1f3..de7324e572 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/897c7702b3..ec54c350e6 * third_party/android_build_tools/lint: X7sJxpJN0p6qi1dgpI9-UFA2YDe2O2A1kF0QZjBJpmYC..KBVVjzxe9TcHEv-JSKko21bFKEolQZXJDvUREjbrrlkC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/f448d5bf8e..92b51e4fd5 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/68c511349d..b808b1bcdd * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/63c0cec034..646b7f5697 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/13de3f85f1..a9f8e2f885 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I2c0d2b951f7435157cfb3d87df31dfffafc4416c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5248566 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mohan Maiya ab4aed3f 2024-01-29T10:59:58 Bugfix in PixelLocalStorageTest Add GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST to following tests - - PixelLocalStorageValidationTest - PixelLocalStorageCompilerTest - PixelLocalStorageTestPreES3 Bug: angleproject:7279 Change-Id: Ibd2e682be195fddff1cf638e37d12bcc740cf3a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5243831 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Mohan Maiya 5c2fc02b 2024-01-29T16:49:28 Vulkan: Bugfix in ImageFormat FixedVector::operator[] does not update FixedVector::mSize. Need to call FixedVector::push_back(...) instead. Bug: angleproject:7553 Change-Id: I544a68276d1635957a27d21c222f50f71d35a609 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5246088 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu 349e75cc 2024-01-29T16:41:42 Suppress VUID-VkFramebufferAttachmentImageInfo-viewFormatCount-09536 After this VVL change: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+/40d989c436d43538be341cd614a595505ce907cc, the newly added VVL error starts to be thrown on multiple ANGLE bots. Suppress this VVL error to unblock the vulkan-deps roller first. Will investigate later how to fix the VVL error in ANGLE. Bug: angleproject:8513 Change-Id: I7d74ff762c3b78d70c3ba5139c1b6955d4cd49e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5247713 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 0c4d6446 2024-01-24T10:38:45 Rework uniform block <-> uniform buffer mapping In GLES, the shader declares which buffer binding a block (uniform, storage or atomic counter) is bound to. For example: layout(binding = 1) uniform ubo0 { ... }; layout(binding = 2) uniform ubo1 { ... }; layout(binding = 1) uniform ubo2 { ... }; In the above, ubo0 and ubo2 use data from the buffer bound to index 2 (through glBindBufferRange), while ubo1 uses data from the buffer bound to index 1. For uniform blocks in particular, omitting the binding is allowed, in which case it is implicitly bound to buffer 0. GLES allows uniform blocks (and only uniform blocks) to remap their bindings through calls to glUniformBlockBinding. This means that the mapping of uniform blocks in the program (ubo0, ubo1, ubo2) to the buffer bindings is not constant. For storage blocks and atomic counter buffers, this binding _is_ constant and is determined at link time. At link time, the mapping of blocks to buffers is determined based on values specified in the shaders. This info is stored was stored in gl::InterfaceBlock::binding (for UBOs and SSBOs), and gl::AtomicCounterBuffer::binding. For clarity, this change renames these members to ...::inShaderBinding. When glUniformBlockBinding is called, the mapping is updated. Prior to this change, gl::InterfaceBlock::binding was directly updated, trumping the mapping determined at link time. A bug here was that after a call to glProgramBinary, GL expects the mappings to reset to their original link-time values, but instead ANGLE restored the mappings to what was configured at the time the binary was retrieved. This change tracks the uniform block -> buffer binding mapping separately from the link results so that the original values can be restored during glProgramBinary. In the process, the support data structures for tracking this mapping are moved to ProgramExecutable and the algorithms are simplified. Program Pipeline Objects maintain this mapping identically to Programs and no longer require a special and more costly path when a buffer state changes. This change prepares for but does not yet fix the more fundamental bug that the dirty bits are tracked in the program executable instead of the context state, which makes changes not propagate to all contexts correctly. Bug: angleproject:8493 Change-Id: Ib0999f49be24db06ebe9a4917d06b90af899611e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5235883 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 4b76bead 2024-01-29T15:39:57 Add third_party/perfetto Conditional on checkout_angle_restricted_traces = True in .gclient Cloned from android, similarly to Chromium: https://crsrc.org/c/DEPS;drc=8f0a542b7501f6c09e8c9c6e273a9bf18742faf5;l=1664 For now not auto-rolled, will likely need to figure out a way to as "prebuilts" are rolled around once a month, which we don't neccessarily need but not sure how long the previous ones remain available. Bug: b/322779830 Change-Id: I7c763d26f8a4d446502682bbf6d39dbd5e743827 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5245648 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 4a5abf6d 2024-01-29T15:58:38 Add Dawn checkout condition to .gitmodules Following https://crrev.com/c/5229822 Need to run "gclient gitmodules" to update the file. I had to revert the "dummy_chromium" change it makes though. Bug: angleproject:8474 Change-Id: If85989baa25edc6b2686d310bfb6c378f6ed5ba8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5245649 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Peiyong Lin 98e02668 2024-01-24T23:47:11 Clean up ANGLE on system build configuration. Now that ANGLE on system is in fully released, clean up the build file configuration and remove the flags. Bug: b/293503000 Test: atest CtsAngleIntegrationHostTestCases Change-Id: Ic31911e097b479861d380e44ec424131c928a9aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5234093 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Peiyong Lin <lpy@google.com> Commit-Queue: Peiyong Lin <lpy@google.com>
Geoff Lang c6d827e4 2024-01-25T13:00:46 Disable the Context shared lock on Android for Chrome. Bug: angleproject:7537 Change-Id: I2409185058edfefb4b9a4160a0bf6475b77606b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5236723 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 3fdf576a 2024-01-26T14:37:42 Vulkan: Workaround Nvidia driver bug with OpSelect Bug: angleproject:8503 Change-Id: I4bd2580056df3d970a1316d0dbeaaad7590aa947 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5237873 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 0ea24ef2 2024-01-26T16:50:39 Unsuppress passing tests Bug: angleproject:3871 Bug: angleproject:3872 Bug: angleproject:3879 Bug: angleproject:4686 Bug: angleproject:4704 Bug: angleproject:4718 Bug: angleproject:4721 Bug: angleproject:4792 Bug: angleproject:5086 Bug: angleproject:5313 Bug: angleproject:6109 Change-Id: I0d0f88a388cd2f19da99a7defd0ab8d98db0e6e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5241306 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 863d4862 2024-01-27T17:42:19 Work around MSAN complaint with pool allocator - Part 2 Cache a member variable accessed after destructor so MSAN doesn't consider it having an uninitialized value. Bug: b/314793573 Change-Id: I7cb515205ed5bf3ba52d68220866009dd04f2d08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5243114 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Austin Annestrand 3fe42527 2024-01-29T11:00:54 OpenCL: Fix input -> inputs for clspv_c_strings Update to inputs so that we can regenerate the spirv_c_strings.hpp output here. Bug: angleproject:8369,angleproject:8510 Change-Id: I12c0d8197b883ca45b8e03e3eb5e8c6302efbb88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5243618 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 351b85f2 2024-01-29T10:01:11 Roll SwiftShader from 3bc9ccd923da to d040a5bab638 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/3bc9ccd923da..d040a5bab638 2024-01-26 thakis@chromium.org Merge two upstream LLVM commits If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ied63e403e45b5f41418980a47b20b9f70c1d26c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5244239 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9545bdbd 2024-01-29T07:01:32 Roll Chromium from 70e6bcc15839 to 0fdef08dd9c7 (58 revisions) https://chromium.googlesource.com/chromium/src.git/+log/70e6bcc15839..0fdef08dd9c7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/1fde7f2264..897c7702b3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/31bf504bc3..f448d5bf8e * third_party/siso: git_revision:c892a2c62436b0d4ffbf1e5c559c73cd0f5c7e31..git_revision:669c48208b82db909d20a0e61f33f6f0f6916e08 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I442575046720f2af861a20cb5cc88eff684c0e4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5243616 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2f4f3dcf 2024-01-28T17:49:44 Manual roll Chromium from 4d771baa2602 to 70e6bcc15839 (609 revisions) Manual roll requested by syoussefi@google.com https://chromium.googlesource.com/chromium/src.git/+log/4d771baa2602..70e6bcc15839 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7cc3e886b6..ddaf87b1f3 * buildtools/linux64: git_revision:fc722252439ea3576c241773f5ee14eb8470e2ef..git_revision:a2e2717ea670249a34b0de4b3e54f268d320bdfa * buildtools/mac: git_revision:fc722252439ea3576c241773f5ee14eb8470e2ef..git_revision:a2e2717ea670249a34b0de4b3e54f268d320bdfa * buildtools/win: git_revision:fc722252439ea3576c241773f5ee14eb8470e2ef..git_revision:a2e2717ea670249a34b0de4b3e54f268d320bdfa * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4520417968..1fde7f2264 * third_party/android_build_tools/manifest_merger: fPIg5SQ9nbj982soSMoZlTPVfZ2zVKZRusg-r0ONCxUC.._BpuezAM4mQeQj5WNI7H6zkNx4nV2d8uGzcoJOlLQJcC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/64c1253280..905de831f6 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/75329f416d..31bf504bc3 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2bc81cdf4f..68c511349d * third_party/fuchsia-sdk/sdk: version:17.20240120.1.1..version:18.20240127.1.1 * third_party/r8: K1NPmXz0aZCAGGtC5UESEmqwT5-x6QNNb0Jo0umsez4C..C9JntVaHiVuPur-3AdTgT9LdF-92xV5S53GPX-ahZsMC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d7f25fb1d4..13de3f85f1 No update to Clang. Bug: None Tbr: romanl@google.com,syoussefi@google.com Change-Id: Ic4947fc49d5b5a035c41e56b19fff84ab6072c91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5243712 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 9318a143 2024-01-11T15:58:44 Add __asm__("") statements to loop bodies in MSL. This prevents erasure of infinite loops during optimization passes. Bug: chromium:1513738 Change-Id: I84a305b5e7fd824531d9e3ebae5496ddec030bac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5191166 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Shahbaz Youssefi 0beed753 2024-01-26T12:42:28 Work around MSAN complaint with pool allocator Cache a member variable accessed after destructor so MSAN doesn't consider it having an uninitialized value. Bug: b/314793573 Change-Id: I45044e0801ae12a80301240b4de05e9cae03dcc1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5238220 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Chris Forbes 6367f541 2024-01-25T10:16:04 Vulkan: supply YcbcrConversionDesc earlier Previously, the AHB import path would allow ImageHelper to build a bogus YcbcrConversionDesc (in initExternal) and then later overwrite it with what it wanted. The intermediate state was not necessarily valid, and could cause assertion failures and VVL errors. Instead, have ImageHelper clients provide the conversion they want upfront. In the non-external case, build an appropriate conversion for formats which need them, before delegating to initExternal. Bug: b/315387961 Change-Id: Icc8f561bb2de0289ceec56d41978b8c4651a47a2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5232769 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Chris Forbes <chrisforbes@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll eaf15b35 2024-01-26T16:35:26 Manual roll VK-GL-CTS from 03517cba39ae to fe0d0f90469f (2 revisions) Manual roll requested by romanl@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/03517cba39ae..fe0d0f90469f 2024-01-26 marcin.hajder@mobica.com Fix for deqp-runmode=stdout-caselist 2024-01-26 marcin.hajder@mobica.com Fix for texture_border_clamp to check if texture format is filterable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Ia319ccfeb0b6002b92edd79791aab215716f6781 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5241043 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bani Singh 66517b0b 2024-01-26T18:18:05 Revert "Use ADC for GCE VM" This reverts commit 2dfbedee7d4f9c84f278818217a1fa0908d6cbee. Reason for revert: May be causing credentials errors Original change's description: > Use ADC for GCE VM > > In case of bot, use ADC instead of automatic_auth which will in the > future be done through credshelper and will not support ADC. > > Test: Locally ran script with no errors, and tested that running > autoninja respects environment variables > > Bug: b/319246651 > Change-Id: I58a282047d387ef54659dbb195cc117b3459d2e8 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5212967 > Reviewed-by: Roman Lavrov <romanl@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Commit-Queue: Cody Northrop <cnorthrop@google.com> Bug: b/319246651 Change-Id: I315651d99e937c331183b28ea7d7d665b43fc6d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5236466 Auto-Submit: Bani Singh <banisingh@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Geoff Lang f405b999 2024-01-19T11:18:49 Make RefCountObject use atomics for the reference count When the context share lock is disabled it is possible for races with EGL Image reference counting causing the EGL Image to be deleted. egl::Image already protects its members with a mutex but the siblings also hold a reference to the egl::Image, if siblings are added and removed at the same time, writing to the ref count races and the egl::Image can be deleted while still being referenced. Bug: angleproject:6957 Change-Id: I3da8691136b6dbcffb2094187c81cafda077e50d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5214270 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 6c23a423 2024-01-26T08:37:12 Tests: skip one of dEQP texture_border_clamp tests on SwS dEQP-GLES31.functional.texture.border_clamp.range_clamp.linear_float_color Bug: angleproject:8507 Change-Id: Ie332c086ca9b145187f4461f646a5e534d323054 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5238216 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Alexey Knyazev 02aa605a 2024-01-25T00:00:00 Metal: Include only the <metal_stdlib> header Removed the logic for generating individual include macros as <metal_stdlib> provides all functions. Fixed: angleproject:8504 Change-Id: I8c83ca8cc2443a4b64e4e022a3a694c7643be569 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5237274 Reviewed-by: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
angle-autoroll 8034d09c 2024-01-26T13:23:26 Manual roll VK-GL-CTS from 0f6fd3de8110 to 03517cba39ae (14 revisions) Manual roll requested by romanl@google.com https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/0f6fd3de8110..03517cba39ae 2024-01-26 rgarcia@igalia.com Test short lines with mesh shaders 2024-01-26 michal.jakubek@mobica.com Unify deFloat with tcu::Float16 2024-01-26 piotr.byszewski@mobica.com Improve binding model shader access tests 2024-01-26 rgarcia@igalia.com Test indirect dispatches with different alignments 2024-01-26 piotr.byszewski@mobica.com Initialize monolithic pipeline layout 2024-01-26 mnahiyan@amd.com Fix access flags for dynamic state resolve tests 2024-01-25 ivan.briano@intel.com Remove extended_usage_bit_compatibility with image_format_list tests 2024-01-25 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/vulkan-cts-1.3.8 2024-01-25 lorenzo@khronosgroup.org Update Vulkan headers to public version 1.3.276 2024-01-25 lorenzo@khronosgroup.org Allow VK_KHR_load_store_op_none 2024-01-22 lorenzo.dalcol@gmail.com Allow Vulkan CTS 1.3.8.0 2024-01-19 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_load_store_op_none' into vulkan-cts-1.3.8 2024-01-19 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_line_rasterization' into vulkan-cts-1.3.8 2024-01-19 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_KHR_index_type_uint8' into vulkan-cts-1.3.8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I8777b52f11b06a4573f8c5a5dc185b4ac78d33de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5239634 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Matthew Leibowitz 36013d99 2024-01-24T01:21:10 Improve build for UWP/Windows 10 These changes update the code for more modern compilers. The changes include: A) Not using deprecated APIs When Windows 8.1 was removed in commit 39b110184e2675afbfda1fd70b10ca112127ae74 the code was not updated to use the new APIs and still use the things that should not be used: > DisplayProperties may be altered or unavailable > for releases after Windows 8.1. Instead, use > DisplayInformation. B) Use correct casting There was also some changes in commit 5eadaf85b42ab1cbb1efcda558db58a3fe5a446a to properly cast from EGLNativeWindowType to IInspectable*, but this was not all of the cases. C) Prepare for WinUI3 There is another change that moves types into a using to reduce verbosity as well as make it easier/cleaner to build for WinUI/Windows App SDK. Bug: angleproject:8496 Change-Id: Ia11b7f92cb4abc524ab8316125e80a22898a8f6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5232157 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov cbdbe3bd 2024-01-26T10:05:41 deqp: Unused test expectations do not cause failure, only log deqp is the only suite that appears to be handling unused expectations this way. This causes an inconvenience where a test cannot be pre-emptively added to the expectations file. For example, a VK-GL-CTS roll might be adding a new test that is failing in some configurations. The expectation cannot be added to the expectations file pre-emptively because of the failure due to the unused expectation, but that is the more convenient way to solve this problem than patching the roll manually. Bug: angleproject:8507 Change-Id: If2ee65d9119043c42e8ca0705a1cc8c40827fae3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5238992 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 5fb6cfa0 2024-01-26T10:01:04 Roll vulkan-deps from 52f65da37e07 to 97f44eb2b9df (17 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/52f65da37e07..97f44eb2b9df Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/7eea61b5a3..79536da264 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/14000ad47a..69197ba90b * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/217e93c664..ea45703eff * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/e7f1b58844..ca4c1e6e42 * vulkan-utility-libraries: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries.git/+log/4cfc176e32..822dd7f3a6 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/169d618688..60dd0ad44f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: If97d891d1940a30b25641d7cab0c24dfa2aca1e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5239748 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f00263e2 2024-01-26T07:48:02 Roll Chromium from 60c7e3d68ae8 to 4d771baa2602 (575 revisions) https://chromium.googlesource.com/chromium/src.git/+log/60c7e3d68ae8..4d771baa2602 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f0e6a46076..7cc3e886b6 * buildtools/reclient: re_client_version:0.126.0.4aaef37-gomaip..re_client_version:0.128.1.7c74998-gomaip * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6bed18b881..4520417968 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/99e6b7be5f..594e0ed1c4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d1eeccf9e4..75329f416d * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a46df1f416..f48a08be15 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/42d6b854ca..3ccf8c4439 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/293a4bb7e4..d7f25fb1d4 Clang version changed llvmorg-18-init-16072-gc4146121e940:llvmorg-18-init-17730-gf670112a Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/42d6b854cac27e4a7041faf872f62be8b82c2c82..3ccf8c44397ecad1d03075abcfaed89e9dfa290a/scripts/update.py Bug: None Tbr: romanl@google.com Change-Id: I8be6bd16ce0f06edb160509e356414ed0331ff13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5239630 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Brandon Schade e9bd169c 2024-01-24T12:26:46 Vulkan: Fix nullptr in Diagnostics - VK Spec for VkDebugUtilsMessengerCallbackDataEXT says pMessageIdName may be nullptr and pMessage must not be a nullptr - This was enforced by the following change Vulkan: Don't crash on diagnostics with null pMessageIdName - But this was susequently broken by the following change Vulkan: Enable sync validation - This change adds a check to skip accessing callbackData->pMessageIdName if it is null Bug: angleproject:5290 Change-Id: I82dd225d875e233530158013efc280e979f82a5b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5238650 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Brandon Schade <b.schade@samsung.com>
Mohan Maiya d0f5a662 2024-01-25T13:01:24 Bugfix in entry points for QCOM foveated extensions Change framebuffer and texture parameter type from GLuint to FramebufferID and TextureID types respectively. Bug: angleproject:8484 Change-Id: I822897b268f2dab56cee3f5776c07ad46a6dd052 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5238212 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov d20c693a 2024-01-25T16:57:49 Android.bp: add empty lines as bpfmt wants With this, bpfmt produces the same output as what we generate. Bug: b/322387417 Change-Id: I44882d9d0906ca202bb48a8d062b17721ec93d51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5238773 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Bani Singh 2dfbedee 2024-01-18T16:52:10 Use ADC for GCE VM In case of bot, use ADC instead of automatic_auth which will in the future be done through credshelper and will not support ADC. Test: Locally ran script with no errors, and tested that running autoninja respects environment variables Bug: b/319246651 Change-Id: I58a282047d387ef54659dbb195cc117b3459d2e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5212967 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 127dabe5 2024-01-25T11:55:09 Android.bp: Move cflags repeated in each target to cc_defaults At the moment there are 24 such flags so Android.bp also gets reduced by a couple thousand lines. One of them is DCR_CLANG_REVISION which changes frequently and will now be a single-line change. Also add --output flag to the script, print() can be useful for quick debugging. Example diff (first few libs only) https://diff.googleplex.com/#key=eVUN8izqTcWe Bug: b/322338350 Change-Id: I21b987e3c7101c0bcbefa4a3b4ff30b1a4154ce4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5236720 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 6fcca069 2024-01-25T13:48:34 Add a note on why ANGLE is pinned to C++17 vulkan_memory_allocator uses std::popcount conditionally on C++20, and it's currently missing from external/libcxx as it wasn't updated yet Bug: b/311052584 Bug: b/175635923 Change-Id: I51728cfa13ccb5c24eab13baabb8c08b275e258f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5238766 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll c7ed7da6 2024-01-25T10:25:22 Roll vulkan-deps from a2b38a7bbea9 to 52f65da37e07 (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a2b38a7bbea9..52f65da37e07 Changed dependencies: * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/7b0309708d..ae6a8b3971 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7e851d0591..169d618688 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: Idaa28a5646548c1137ae1e936fe9507eb381baa4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5236058 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 7d30cf9f 2024-01-22T00:00:00 Metal: Simplify sign function translation Check whether a float or an integer variant is needed and emit only what is necessary. Fixed: angleproject:8502 Change-Id: I7061a5faa7cf09519b30e64ff90c42bbe392908a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5234350 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 52527b8f 2024-01-25T07:02:26 Roll Chromium from 5bfb2faa963e to 60c7e3d68ae8 (652 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5bfb2faa963e..60c7e3d68ae8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4c08d3176c..f0e6a46076 * buildtools/linux64: git_revision:5110a7f03e86c6077516f62bd5b77a9a672ebfa6..git_revision:fc722252439ea3576c241773f5ee14eb8470e2ef * buildtools/mac: git_revision:5110a7f03e86c6077516f62bd5b77a9a672ebfa6..git_revision:fc722252439ea3576c241773f5ee14eb8470e2ef * buildtools/win: git_revision:5110a7f03e86c6077516f62bd5b77a9a672ebfa6..git_revision:fc722252439ea3576c241773f5ee14eb8470e2ef * testing: https://chromium.googlesource.com/chromium/src/testing/+log/c1b7ed7c8c..6bed18b881 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/1cd1f16ff8..99e6b7be5f * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e0fa8c9e24..64c1253280 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/614520ed68..d1eeccf9e4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/00ae0c065c..2bc81cdf4f * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/f400fdb561..fc505746f0 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ffe7c45639..42d6b854ca * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d69c26c4cb..293a4bb7e4 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I601ef7f524c21a68787fc91ec0e7be8435f24c00 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5236057 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gowtham Tammana 8e267846 2023-12-08T14:10:25 gn: Enable clspv build on angle_enable_cl Bug: angleproject:8369 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Change-Id: I3cdea8508a38462981988f6954524c77aa2c97ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5230325 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 4761bd7c 2024-01-24T15:37:01 Manual roll vulkan-deps from 167fd9d49add to a2b38a7bbea9 (17 revisions) Manual roll requested by romanl@google.com https://chromium.googlesource.com/vulkan-deps.git/+log/167fd9d49add..a2b38a7bbea9 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/57d86ab763..7eea61b5a3 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/b82536766d..03b485dc47 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3e6bdd0f99..14000ad47a * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/0b2b71306a..e7f1b58844 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/584a5a25ec..7e851d0591 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: I4a2367d927e2486acb8475bef28bba000e1f6364 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5233363 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Mohan Maiya ac71a592 2024-01-23T11:56:42 Vulkan: updates to pipeline cache graph dumping logic 1. To dump pipeline cache graph you need to - 1. add "angle_dump_pipeline_cache_graph" compile time flag to args.gn 2. set Android property "angle.dump_pipeline_cache_graph" or envvar ANGLE_DUMP_PIPELINE_CACHE_GRAPH on non-Android platforms before app start 2. Default path for dump on Android is "/data/local/tmp/angle_dumps/" 3. "angle.pipeline_cache_graph_dump_path" Android property or envvar ANGLE_PIPELINE_CACHE_GRAPH_DUMP_PATH on non-Android platforms can be used to configure the dump path Bug: angleproject:6565 Change-Id: I38848aff58f413dd7bdffc9083116bd4b95e4960 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5226054 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Hailin Zhang 2978450a 2024-01-12T14:32:19 Vulkan: add etc to bc transcoding perf test. test case for testing etc to bc texture transcoding. Bug: b/319117463 Change-Id: If663fad689a4e6886bc76145c296e8fbfe21b354 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5194408 Commit-Queue: Hailin Zhang <hailinzhang@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Shahbaz Youssefi b007c74d 2024-01-23T14:17:54 GL: Separate dirty bits leading to glUniformBlockBinding The GL backend is special in that it needs to make actual calls (native glUniformBlockBinding) in response to (application) glUniformBlockBinding calls. The other backends just remap the bindings based on that information when creating descriptor sets. Previously, an optimization to track which bindings have changed used the same dirty bits that were used to signify when the GL backend needs to make these native calls. That ended up as a source of bugs. In a previous change [1], the context DIRTY_BIT_UNIFORM_BUFFER_BINDINGS is set when these mappings change, which fixes some of these issues. That change obviates the need for an actual backend sync of programs, except for GL programs that need to make these native calls. This change splits the dirty bits maintained for the purposes of the GL backend, moves them to that backend and removes the program backend sync. [1]: https://chromium-review.googlesource.com/c/angle/angle/+/5228599 Bug: angleproject:8493 Bug: b/318806125 Change-Id: I73c6514e88a116f1cd701cb06da0d8c38f07f7f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5230137 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 66de8492 2024-01-23T12:56:30 GL: Fix UBO binding mapping change In the absence of any other state change, the GL backend did not bind buffers (previously unused) that are used after a UBO binding mapping change. This also triggered assertion errors in the Vulkan backend. Additionally, this change improves cross-context programs, though the Vulkan backend is still affected by some bugs. A follow up change will rework the dirty bits for this change to fix that. Bug: angleproject:8493 Bug: b/318806125 Change-Id: I8f0ed4b5f666818f4fda9ec272c6b66419d64638 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5228599 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Liza Burakova 886d0260 2024-01-23T21:42:23 Don't pull Dawn in chromium builds Bug: angleproject:8474 Change-Id: If52685057fad3b3dff0db26cd0d5d69b5431f6f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5229822 Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 5857e0d6 2024-01-22T00:00:00 Metal: Adjust raster order groups AMD workaround condition Ensured that the raster order groups AMD workaround is used not only when there is no attachment on slot 0 but also when an existing attachment on slot 0 is disabled. Bug: angleproject:8263 Change-Id: I62352eb5d6fb1cce4b6a4723d41862c6c213b9d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5230638 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Roman Lavrov a76e2798 2024-01-24T09:50:32 Suppress VUID-vkCmdEndDebugUtilsLabelEXT-commandBuffer-01912 Blocking VVL roll, new check recently added in: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+/6180ce40299b1346ee2caf4aa8b1540590e197e8 Bug: angleproject:8497 Change-Id: I40d600409ad0e9900c17fac9700ab4397be6c876 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5231423 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 2c8784c9 2024-01-24T07:32:26 Roll Chromium from 2e1050880b38 to 5bfb2faa963e (609 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2e1050880b38..5bfb2faa963e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4031ab2361..4c08d3176c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6bbaddde7d..c1b7ed7c8c * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/11f99a915d..e0fa8c9e24 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1ac149069e..614520ed68 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6fc0c97ab2..00ae0c065c * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/9986707a5f..a46df1f416 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ff6539473d..ffe7c45639 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/eb7f738733..d69c26c4cb No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: Iad674e1442f625b1cbe7645a164e497e270d2a16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5233361 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 600a1a80 2024-01-22T00:00:00 Metal: Clamp vector element index references Ensured that vector elements passed by reference are within the number of vector components. Fixed: angleproject:8492 Change-Id: I2defbd8dfd418256ddb87f8ce1a74ac09a8a1b7b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5229957 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Shahbaz Youssefi 1100cc5c 2024-01-23T16:18:52 Rename ShaderVariableBuffer It was only ever aliased to AtomicCounterBuffer after refactorings that made other buffers not use this class anymore. Bug: b/275102061 Change-Id: I09079d52bd107ed656c4c59a11e8a8027554a5ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5230141 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Roman Lavrov 81a43bd7 2024-01-23T17:15:54 Tests: skip TexelFetchLodOutOfBounds on SwS Shabi says it might after SwS rolls into Chromium But SwS is currently blocked by another issue Bug: angleproject:8495 Change-Id: I2aba1d652e868de28b258e79c74d2bd252e41f86 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5230142 Commit-Queue: Roman Lavrov <romanl@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Roman Lavrov 3f568177 2024-01-23T16:31:49 Add third_party/dawn to .gitignore Bug: angleproject:8474 Bug: skia:321702655 Change-Id: Ie9b8bd8b7ee0faa08483ee755d7c36abcc70fa77 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5229821 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 4cda949b 2024-01-22T10:21:25 Trace tests: extend warmup to at least 1.5s Some traces are very short (e.g. 10 frames) finishing the first loop very quickly. There appears to be some delayed activity within ~1s after this first loop, so make this part of warmup as well. Example log after this change: Warmup: 10 steps Stopping test after 10 trial steps. Warmup: Looping for remaining warmup time (1.38 seconds). Stopping test after 1.38 seconds. Warmup took 1.50 seconds. Bug: b/308975999 Change-Id: If861f275f280fcb61d839e34d672e6c948317f4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5224902 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 755372c8 2024-01-23T13:41:01 Tests: skip UniformUsageCombinations test on SwS Failing on swangle builders: https://crrev.com/c/5228780 Bug: angleproject:5792 Change-Id: Id3cb22641b3b5a5ce1fee96f59111c6e48bc1742 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5228602 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi f794c9c2 2024-01-22T09:56:08 Tests for out-of-bounds LOD in texelFetch Bug: chromium:1504556 Change-Id: I3a92da00d9a8781122c7218f22a681839783dc7e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5225080 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 43ecc031 2024-01-23T10:01:40 Roll SwiftShader from 5ab5177fc72d to 3bc9ccd923da (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/5ab5177fc72d..3bc9ccd923da 2024-01-22 syoussefi@google.com Clamp min LOD during image Fetch for robustness If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I8e1a81779e29eca90e9ff9a5782da3d7fe5feccd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5225286 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9519348b 2024-01-23T07:00:33 Roll Chromium from 6d5cc7186844 to 2e1050880b38 (298 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6d5cc7186844..2e1050880b38 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d506fb2130..4031ab2361 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/92e4da6e69..d8688b9036 * buildtools/linux64: git_revision:f99e015ac35f689cfdbf46e4eb174e5d2da78d8e..git_revision:5110a7f03e86c6077516f62bd5b77a9a672ebfa6 * buildtools/mac: git_revision:f99e015ac35f689cfdbf46e4eb174e5d2da78d8e..git_revision:5110a7f03e86c6077516f62bd5b77a9a672ebfa6 * buildtools/win: git_revision:f99e015ac35f689cfdbf46e4eb174e5d2da78d8e..git_revision:5110a7f03e86c6077516f62bd5b77a9a672ebfa6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a37402bece..6bbaddde7d * third_party/android_build_tools/aapt2: y1G4s2RWI63L9ZLgzS3RzFdWdeblpCmYyAUzMphcQawC..G1S0vNnfv3f8FD-9mH5RFSUiK-mnSwri_IdiVQKwLP0C * third_party/android_build_tools/manifest_merger: tFbjqslkduDT_-y8WEZlsl9iulzcm3mgienslcU71poC..fPIg5SQ9nbj982soSMoZlTPVfZ2zVKZRusg-r0ONCxUC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3e413d7b62..1ac149069e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c341d58921..6fc0c97ab2 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4b56db9f6a..eb7f738733 No update to Clang. Bug: None Tbr: romanl@google.com Change-Id: I660609e80e9049fad7760234be22a6893008e7b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5225429 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 341906d5 2024-01-22T10:19:25 Vulkan: Never delay device and queue selection Previously, when multiple queue families where eligible, ANGLE delayed the decision on which queue family to use and delayed device creation until a window surface was created. This assumption was never correct. The application may start rendering to pbuffers or using EGL_KHR_surfaceless_context long before it creates a window surface. So a queue may need to be chosen regardless of its surface present capabilities. Once done, ANGLE has no mechanism to change that queue should a window surface require a different queue. This change drops the pretense to support multiple queue families properly and makes ANGLE always choose the first graphics queue family it encounters. So far, only MoltenVk seems to expose multiple graphics queue families, and choosing the first one ultimately correct for the purposes of presenting to a MacOS surface. Bug: angleproject:8478 Change-Id: I8efbfe0c8036be5f9cee01eb657f83f85a4864fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5225081 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 2431d4df 2024-01-18T00:00:00 Metal: Skip array index clamp for constant values Do not wrap constant array indices with ANGLE_int_clamp when their values could be statically validated. Fixed: angleproject:8488 Change-Id: I3ad183475e1847cb7db1a07df3598c7d39767d7e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5220233 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6975fbdf 2024-01-22T20:18:41 Manual roll Chromium from 32cda1ad29f0 to 6d5cc7186844 (1322 revisions) Manual roll requested by romanl@google.com https://chromium.googlesource.com/chromium/src.git/+log/32cda1ad29f0..6d5cc7186844 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bb8788c7ad..d506fb2130 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/16519eb3b2..92e4da6e69 * buildtools/linux64: git_revision:b5adfe5f574d7110b80feb9aae6fae97c366840b..git_revision:f99e015ac35f689cfdbf46e4eb174e5d2da78d8e * buildtools/mac: git_revision:b5adfe5f574d7110b80feb9aae6fae97c366840b..git_revision:f99e015ac35f689cfdbf46e4eb174e5d2da78d8e * buildtools/win: git_revision:b5adfe5f574d7110b80feb9aae6fae97c366840b..git_revision:f99e015ac35f689cfdbf46e4eb174e5d2da78d8e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ec7730d9a4..a37402bece * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/5ff8c1facf..1cd1f16ff8 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/48521bcc15..3e413d7b62 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5400d9ef5a..c341d58921 * third_party/fuchsia-sdk/sdk: version:17.20240113.0.1..version:17.20240120.1.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/24cb5545a9..28aa23ffb4 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/ea028d4d2b..9986707a5f * third_party/r8: wBe-A6ww1s2mKwOHoDl_5jVTfVZpA16hjz8cP9nY3oAC..K1NPmXz0aZCAGGtC5UESEmqwT5-x6QNNb0Jo0umsez4C * third_party/siso: git_revision:927b3ea4dae8cefd25154c0d060b7eee75c0c6d8..git_revision:c892a2c62436b0d4ffbf1e5c559c73cd0f5c7e31 * third_party/turbine: ABguU2WKErRBdXX1LMt0zqZListLS_05X0Rp_V7pwAYC..KfCqNpZ5XxbfuKiIsjeMWFX-6aJc5WN37x9weHyVDIkC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/1a9bebf350..ff6539473d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d05797b237..4b56db9f6a No update to Clang. Bug: angleproject:8153 Tbr: romanl@google.com Change-Id: Iaaab0d43a27a03c9b7cf1e97774e5e610f142e12 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5226043 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 2ba5bb12 2024-01-22T15:16:55 android_helper: fix corner-case byte/string mismatch When --isolated-script-test-output is provided and --list-tests is added, the string gets written to a file in binary mode raising an exception. Bug: None Change-Id: Id73ae49f849e0c1bd609d4b37ad39f5515e1f02b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5225485 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Roman Lavrov <romanl@google.com>
Shahbaz Youssefi c6fbf93d 2024-01-19T09:57:12 Vulkan: Fix input attachments leaking into uniform list To communicate the existence of input attachments added to the shader, the translator was adding `ShaderVariable`s for each to the list of uniforms exported from the shader. This was incorrect, as this list is visible to the application through `glGetActiveUniform`. Additionally, this was unnecessarily causing these uniforms to go through program link. Reserving SPIR-V ids for these uniforms, all that is needed from the translator is the mere existence of these input attachments. This change removes the addition of uniforms, and instead exports a bitset. Elsewhere, that bitset is consulted and reserved SPIR-V ids are used. Bug: b/320563594 Bug: angleproject:5792 Change-Id: Id93846cbc3996248f391fd2d5a65af1e48d6d46e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5215089 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Brandon Schade 317108d6 2024-01-18T17:59:51 Vulkan: Enable recordable bit for RGBA8 and RGB10_A2 Enable the recordable flag to be enabled for the RGBA8 and RGB10_A2 configs. Test: CtsMediaV2TestCases android.mediav2.cts.EncoderColorAspectsTest Bug: angleproject:6612 Change-Id: I2afaedde4751c5ca651d0d80ae1a8d14662c2f0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5214887 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Brandon Schade f43db42c 2024-01-17T15:18:41 Enable LogGles32Capabilities test for vulkan backend Allow for LogGles32Capabilities test to no longer be skipped for the vulkan backend. Test: angle_end2end_tests.exe --gtest_filter=*PrintGLESCapabilities* Bug: angleproject:4093 Change-Id: I1711f016f63fa58ce3521cc8d2a2e75f189fb877 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5214007 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 16a5e8f1 2024-01-22T14:22:53 Revert "Prefer linear filtering for YUV for Pixel6+" This reverts commit 0da6522524247d6a1cb88ab1b48a1801ee609991. Reason for revert: Breaks an Android test b/321251332 Original change's description: > Prefer linear filtering for YUV for Pixel6+ > > This is required to pass CtsMediaDecodeTestCases. > Narrowed to just Pixel6+ due to another issue (b/321903468) which > prevents preferring linear filtering on Pixel4. > > Bug: b/315387961 > Change-Id: I6fbbea10a3b4fd835afbcdbecf120264d0ca8605 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5207870 > Reviewed-by: Charlie Lao <cclao@google.com> > Commit-Queue: Chris Forbes <chrisforbes@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> Bug: b/315387961 Change-Id: I4b055a9ffef9ed49992ea5568f723aaff53c7f1c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5224900 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 3217caa1 2024-01-22T12:17:15 Roll SwiftShader from 328e794f0c8b to 5ab5177fc72d (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/328e794f0c8b..5ab5177fc72d 2024-01-22 syoussefi@google.com Clamp LOD during image Fetch for robustness If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: If34c348d5adaf9ea768f83a5029f73892323c59c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5223301 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e27af543 2024-01-22T10:01:14 Roll vulkan-deps from c00c99b8e979 to 167fd9d49add (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c00c99b8e979..167fd9d49add Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c96fe8b943..3e6bdd0f99 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d26b50b038..584a5a25ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: romanl@google.com Change-Id: If535129d6d03a0078aa13f3859ba9aa500553e4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5222806 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 151c1571 2024-01-12T16:40:38 Vulkan: Clean up RGB8-to-RGBA8 ubyte function Some platforms encounter issues in this function, possibly when the dest pointer is accessed directly when it is cast to uint32_t. * Coalesced the 32-bit accesses into memcpy(). * Simplified the implementation to contain less variables and indices. * The function updates the source and dest pointers directly instead of using separate indices. After this, the next pixel components would be accessible using constant offsets (0-3). * It does not seem to have an impact performance-wise. * Tested on Windows, which showed the most improvement in the first CL. Bug: b/308177124 Bug: b/319128304 Change-Id: I9807fd5331db487f9f0a03faa457ee0a8343d59c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5195125 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev fc742305 2024-01-18T00:00:00 Metal: Simplify geometry functions translation Check whether a vector or a scalar variant is needed and emit only what is necessary. Reduced the generated MSL for: - atan/atan2 - length - distance - dot - normalize - faceforward - reflect - refract Fixed: angleproject:8487 Fixed: angleproject:8489 Change-Id: I3be39e55997062136aae2782269a65c0c738d6cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5217532 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll 8a47d6b1 2024-01-19T18:09:55 Roll VK-GL-CTS from 04d7f781e691 to 0f6fd3de8110 (15 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/04d7f781e691..0f6fd3de8110 2024-01-19 aitor@lunarg.com Modify texture offset tests for smaller textures than offsets 2024-01-19 boris.zanin@amd.com Add descriptor buffer ycbcr sampler and mutable descriptor tests 2024-01-19 cturner@igalia.com Add additional coverage for transfer-only copies and blits 2024-01-19 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkansc-cts-1.0.2 into vk-gl-cts/main 2024-01-19 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main 2024-01-19 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-es-cts-3.2.9 into vk-gl-cts/main 2024-01-19 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.3.7 into vk-gl-cts/main 2024-01-18 Tyler.Schneider@amd.com Reduced workload of ray query stress tests 2024-01-18 rgarcia@igalia.com Test frag shader invocations with non-flat colors 2024-01-18 rgarcia@igalia.com Assert on null layout when linking graphics pipelines 2024-01-18 rgarcia@igalia.com Add host image copy tests for R8_UNORM and R32G32_SFLOAT 2024-01-18 boris.zanin@amd.com Fix switch vertex input binding stride without binding new buffers 2024-01-18 ziga@lunarg.com Fix enabling features in extended dynamic state tests 2024-01-18 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.3 into vk-gl-cts/main 2024-01-16 c.hambacher@samsung.com Fix missing include in merged pipeline cache tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Icbf5d82ba818789cb0caba61999d1cc17f7c2434 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5215442 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 175514c6 2024-01-12T14:43:33 Translator: Bundle metadata flags coming out of the translator In preparation for a follow up change that adds more such metadata. Bundling them together makes it convenient to retrieve, save and load all those flags. Bug: b/320563594 Change-Id: I4f95b32acfb0842cc5d9e72c1788a827bee2c760 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5209450 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 07e41ef0 2024-01-19T10:01:53 Roll vulkan-deps from 9b8079729ca3 to c00c99b8e979 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/9b8079729ca3..c00c99b8e979 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/c0f48374c7..b82536766d * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5b3b90b6a1..d26b50b038 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I18d6acf2fef3156536c32fb66ad611326f3d98c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5215440 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Forbes 0da65225 2024-01-18T10:29:23 Prefer linear filtering for YUV for Pixel6+ This is required to pass CtsMediaDecodeTestCases. Narrowed to just Pixel6+ due to another issue (b/321903468) which prevents preferring linear filtering on Pixel4. Bug: b/315387961 Change-Id: I6fbbea10a3b4fd835afbcdbecf120264d0ca8605 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5207870 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Chris Forbes <chrisforbes@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 291490e2 2024-01-18T22:03:42 Manual roll Chromium from 84fab30ecd66 to 32cda1ad29f0 (2747 revisions) Manual roll requested by yuxinhu@google.com https://chromium.googlesource.com/chromium/src.git/+log/84fab30ecd66..32cda1ad29f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/48ef4c0c29..bb8788c7ad * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4d143ade13..16519eb3b2 * buildtools/linux64: git_revision:d4be45bb28fbfc16a41a1e02c86137df6815f2dd..git_revision:b5adfe5f574d7110b80feb9aae6fae97c366840b * buildtools/mac: git_revision:d4be45bb28fbfc16a41a1e02c86137df6815f2dd..git_revision:b5adfe5f574d7110b80feb9aae6fae97c366840b * buildtools/win: git_revision:d4be45bb28fbfc16a41a1e02c86137df6815f2dd..git_revision:b5adfe5f574d7110b80feb9aae6fae97c366840b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/105d4c3f46..ec7730d9a4 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/5fe3232525..5ff8c1facf * third_party/android_build_tools/lint: cBQ1qc7aJ6gwBvrCOJNVq6Mlijj4HlNtTmzJEXpgmBQC..X7sJxpJN0p6qi1dgpI9-UFA2YDe2O2A1kF0QZjBJpmYC * third_party/android_build_tools/manifest_merger: 00I6IYO5b1mwIYv-jWPmTZvw3paoypOPHYEg9vpqFDUC..tFbjqslkduDT_-y8WEZlsl9iulzcm3mgienslcU71poC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/4037529999..11f99a915d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/73730a049e..48521bcc15 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/39bc04eb9f..5400d9ef5a * third_party/fuchsia-sdk/sdk: version:17.20240105.3.1..version:17.20240113.0.1 * third_party/kotlin_stdlib: KIU1zubKhCbwM8mZNhGe3NriMr5QZRo3mHdOu4rAYowC..7f5xFu_YQrbg_vacQ5mMcUFIkMPpvM_mQ8QERRKYBvUC * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/d1f035a3ff..24cb5545a9 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a1171ad549..ea028d4d2b * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/e09e0d462a..f400fdb561 * third_party/r8: -33V5QWJXVKP_bE-P5-BqM4rcEmndOTuK1LyWc2l3N4C..wBe-A6ww1s2mKwOHoDl_5jVTfVZpA16hjz8cP9nY3oAC * third_party/siso: git_revision:d8744c99a9e175e6c4569de0717bd8c53981ce0c..git_revision:927b3ea4dae8cefd25154c0d060b7eee75c0c6d8 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/956936c53c..63c0cec034 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/771b9c761f..244bd6f732 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/990bc36ac0..1a9bebf350 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d67de05ec4..f5c1c96a7b * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/137d838b1d..4753a8cbcd * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/a1137e89f9..d05797b237 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I5e070a0d70cd197e75d893ae10ddf15908ba171a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5214885 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Spandan Das dd936c23 2024-01-16T20:27:36 Android: Build angle libs with a shared copy of libz Soong creates two variants of angle libraries - a platform variant and an sdk variant (because it sets sdk_version in bp). This CL changes the link type of angle --> libz to a shared link dependency from a static link dependency This affects the variants in the following ways 1. Platform variant: Links against (shared,platform) variant of libz ld diff https://diff.googleplex.com/#key=pw6D7KHophSB 2. Sdk variant: Links against (shared,sdk) variant. This is really the ndk variant of libz. ld diff https://diff.googleplex.com/#key=g9ffVxxAesEk Both (1) and (2) have the incidental benefit that it decreases the size of the angle libraries since libz is no longer statically linked into angle libraires. In case of (2), we have an additional benefit of actually enforcing an api boundary between angle and libz. Before this CL, angle could access implementation of libz. After this CL, angle can only access the public apis of libz. Bug: b/281077552 Test: presubmits on https://android-review.git.corp.google.com/c/platform/external/angle/+/2907477 Test: Inspected ninja graph (ld diffs attached) Change-Id: I745abb836878a5b6e195fb9ddb359673308f9fac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5201878 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Spandan Das <spandandas@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Spandan Das <spandandas@google.com>
Liza Burakova f2c00e8c 2024-01-18T18:36:33 Adding Dawn stub backend to ANGLE Bug: angleproject:8473 Change-Id: I81ea83986e4e566169aa82250b5cfb727985ed01 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5201413 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi fad2adb2 2024-01-12T14:43:33 Vulkan: Fix importing external object and using as storage image The create flags used to create the imported object was 0. Later, when the texture was used as a storage image, TextureVk::syncState would recreate the image (losing connection to external object). This change makes sure the create flags include all the necessary create flags such that the texture can be correctly used as storage image. Bug: angleproject:8464 Change-Id: I6587b53b1c2819a11dec8f2d5a3a30c889a4c63f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5194064 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang f1150231 2024-01-16T16:28:36 Track WebGL buffer type in gl::Buffer state. WebGL has special validation that disallows buffers from changing "WebGL buffer type". Once a buffer is marked as having index data it cannot be bound as any other type of buffer except the copy binding points to copy to other index buffers. This disallows any GPU writes to buffers used for index data. Use this rule to shadow index buffer data when the driver is unable to give us robust access. Index range computation can be done much faster when the buffer does not need to be read back. Bug: angleproject:8434 Change-Id: I059eff732bb2f43234f61d9ef5528289f7698b38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5200242 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 40b67397 2024-01-18T11:04:44 Roll vulkan-deps from 5803e963cb95 to 9b8079729ca3 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5803e963cb95..9b8079729ca3 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/0f7d3a0776..57d86ab763 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/64f64c837a..c0f48374c7 * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/bdd1b2ab1f..7b0309708d * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5dbdc7b60b..c96fe8b943 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6705de9a0a..5b3b90b6a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I73ddf4997fb1ec1198138bf1d7da998fceb0216c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5211505 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 87fb3bf3 2024-01-18T10:01:44 Roll SwiftShader from f4819d2276b7 to 328e794f0c8b (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/f4819d2276b7..328e794f0c8b 2024-01-17 syoussefi@google.com Support VK_EXT_vertex_input_dynamic_state If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:7162 Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I799d77d378484e4eb78e01c3d4b454be80f390d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5208780 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
kmx.io     mail     discord kmxgit v0.4.0