kc3-lang/angle

Log

Author Commit Date CI Message
Jamie Madill d6302408 2021-04-21T17:16:34 Update standalone Android docs. Bug: angleproject:2344 Change-Id: Idea2f65fc92f2c59c5d4cd6ae01cae0b4af41905 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2845049 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill c9b8d61b 2021-04-21T21:08:44 Update Android-releated tools DEPS. Include the tools/android/errorprone_plugin mirror. This eliminates several cloned source files from ANGLE. Also include the Python tools/swarming_client for running tests. It seems like the tests depend on the logdog Python library available from this component. Bug: angleproject:2344 Change-Id: I70e011764c4443ab3904bfa0c9059f295f3817df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2845233 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 9fbe5c00 2021-04-22T07:03:10 Roll Chromium from 2e3165386670 to 953728c7e200 (354 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2e3165386670..953728c7e200 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9f81eec935..b0f84425e3 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/b8e67401d8..2f2a4e507a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f73b4bea19..00edc76626 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4b39857c2f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bc1f5c75f1..447e0b72df * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d5a5d84142..01b9d7ae3d No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I043a2ae197bc516133f747f14d33108fcb295147 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846135 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill e0e5eb84 2021-04-21T20:58:12 Fix ScanReverse on posix/32-bit. The use of the __builtin_clz intrinsic and the associated math were incorrect. Bug: angleproject:5736 Change-Id: I9627c7fc179c0e1bffeecaee39f7a88d9c62d079 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2845232 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Ian Elliott e167d453 2021-04-21T14:14:33 Vulkan: Allow logging with VVL and/or AGI debug utils to be used A recent change allowed logging API commands on Android to be used with Vulkan Validation Layers (VVL). That broke debug utils for AGI (i.e. when the ANGLE-built VVL is not being used). This allows both use cases to be supported. Bug: b/183133198 Change-Id: Ide83ed63fad99d0eca97998365276a1ef365a4e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842325 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 7740e434 2021-04-21T13:26:54 infra: Add Android builders to CQ by default. The build is now green and we can start testing this pre-commit. Bug: angleproject:2344 Change-Id: Icfa58f02727228468e422f4f596deb5c1e2dcfe1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842356 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill cfc21345 2021-04-21T09:42:51 Add first() and last() to BitSetArray. These helper functions return the bounds of the 1 bits in the array. Also required implementing ScanReverse the same way we implemented ScanForward. Bug: angleproject:5736 Change-Id: Ied945c57cd85ca7bc91dcc7a1168a74b3a59fce4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842347 Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 6297ccf3 2021-04-21T13:15:59 Replace ijar sources with Chromium subtree mirror. This will ensure a smoother update process. Bug: angleproject:2344 Change-Id: I81bf496ea013825588b1baa573855ce809a8decf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842355 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill f78927b0 2021-04-21T13:05:46 Remove libGLESv1_CM static. These entry points are already duplicated into libGLESv2. Including them in the static build causes a duplicate symbol error on Android. Bug: angleproject:2344 Change-Id: I56a2f2029e7da49215e64484c1d1316add6ff1c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842354 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 002e5622 2021-04-21T12:12:26 Android: Enable APK build. Bug: angleproject:2344 Change-Id: Iaad7199d2bcbb961d64f14eb640d472c52d7abc6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842564 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 598b6bbd 2021-04-21T14:12:48 Roll Chromium from 141612cc6143 to 2e3165386670 (489 revisions) https://chromium.googlesource.com/chromium/src.git/+log/141612cc6143..2e3165386670 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bdd4e9dcbc..9f81eec935 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d0f33885a2..b8e67401d8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d364fd2e43..f73b4bea19 * third_party/android_ndk: https://chromium.googlesource.com/android_ndk.git/+log/27c0a8d090..401019bf85 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..da84ecd433 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/93d80d8686..bc1f5c75f1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d7dd881ddc..7a6a1f2ea2 * tools/luci-go: git_revision:0f913477afc80d5c4b6609834d3bef6b44910e67..git_revision:e7e8e7aea55bc50729ec835604b2a00e6e668afe * tools/luci-go: git_revision:0f913477afc80d5c4b6609834d3bef6b44910e67..git_revision:e7e8e7aea55bc50729ec835604b2a00e6e668afe * tools/luci-go: git_revision:0f913477afc80d5c4b6609834d3bef6b44910e67..git_revision:e7e8e7aea55bc50729ec835604b2a00e6e668afe * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b0eccdd309..d5a5d84142 No update to Clang. Bug: None Tbr: ynovikov@google.com,jmadill@google.com Change-Id: I5d24a7ca9920f29f321a6333bd3bb96852570b77 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2843989 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 718022e8 2021-04-16T20:50:34 Reland "Revert "Vulkan: Suppress draw-time push constant VVL warnings. "" This is a reland of b027dfeb83d028ae72ed1957ba81e6c5dc3baffa Original change's description: > Revert "Vulkan: Suppress draw-time push constant VVL warnings. > " > > This reverts commit f34b40dab0487bbabc37645918bed87048107e14. > > Reason for revert: VVL bug is fixed. > > Original change's description: > > Vulkan: Suppress draw-time push constant VVL warnings. > > > > > > > > VUID-vkCmdDraw-None-02698 > > > > VUID-vkCmdDrawIndexed-None-02698 > > > > VUID-vkCmdDrawIndirect-None-02698 > > > > VUID-vkCmdDrawIndirectCount-None-02698 > > > > VUID-vkCmdDrawIndexedIndirect-None-02698 > > > > VUID-vkCmdDrawIndexedIndirectCount-None-02698 > > > > VUID-vkCmdDispatch-None-02698 > > > > > > > > Bug: angleproject:5821 > > Change-Id: Ic8ca6178ce50b409ac8d256848654f43f91fae8e > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808854 > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > Commit-Queue: Jamie Madill <jmadill@chromium.org> > > Bug: angleproject:5821 > Change-Id: I771e81a46893f2875605e472273f1388587e042e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831997 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:5821 Change-Id: I56ccb80eb76c3cedca2a40b8cc0223a879ab1edf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842309 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 95e75ec8 2021-04-21T09:26:57 Remove 'six' from roll_chromium_deps. This dep was causing the script to fail. It may be because the repo currently has a single commit. Work around this by removing the entry from the auto-roller for now. Bug: angleproject:2344 Change-Id: Id4f61124aae7ab43aa2343faf19416ff676314d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842224 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll ac0cd4fb 2021-04-21T10:01:48 Roll vulkan-deps from 494bfcf95bd6 to e5bb9b56c292 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/494bfcf95bd6..e5bb9b56c292 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/4b868e5e13..eb6d6f95df * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/a746136a81..eb3d67bd17 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f39a8dc664..fd0e2b53a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I0838e28b3ab413909174b2c676bb9d66b352fd13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2841735 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 18ed9e54 2021-04-21T10:01:59 Roll SwiftShader from dac99e8221a8 to c597a8af03ef (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/dac99e8221a8..c597a8af03ef 2021-04-20 capn@google.com Fix pedantic Clang warning/error 2021-04-20 capn@google.com Add IndentCaseBlocks to .clang-format If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I454deea7c3c30ec101b00773e55afcce21fbecd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2843428 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki e77e4d92 2021-04-09T16:29:36 tests: Add DepthStencilTestES3.ReadPixelsDepth24. Add a test that creates a framebuffer formatted GL_DEPTH_COMPONENT24 and read pixels from it using glReadPixels. This test uses a combination of the GL_OES_depth24 and GL_NV_read_depth extensions. This test can only run on GLES3 as the GL_DEPTH_COMPONENT24 internal format is not available on GLES2. Test: angle_end2end_tests --gtest_filter=DepthStencilTestES3.ReadPixelsDepth24/ES3_Vulkan_SwiftShader Bug: angleproject:5799 Change-Id: I4e898bf756498796df02ef41cc2b989df78f13df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2817765 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Le Hoang Quyen a878e814 2021-04-11T15:04:19 Metal: Distinguish Metal backend from OpenGL's Metal driver On macOS 11+ OpenGL is implemented on top of Metal internally. This CL changes ANGLE's Metal backend's renderer string to better differentiate it from the above OpenGL renderer. Bug: angleproject:5841 Change-Id: I0d5466594e385cb663d537db034c82b006b6e907 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2820179 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill d170f8e1 2021-04-20T19:17:17 infra: Add configs for Android build. Updates the configs to use the new protobuf properties. Adds support for ARM/ARM64 Android builds. Must be landed in conjunction with http://crrev.com/c/2841787 . Bug: angleproject:2344 Bug: angleproject:5114 Change-Id: I49f4f46ceaa7ce9118c9f4b4ceb06353b00429b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842306 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Peng Huang be2f7b1c 2021-04-20T13:54:47 Unbind fbo before context switching for PowerVR GPUs Imagination GL drivers are buggy with context switching. We need to ubind fbo to workaround a crash in the driver. Bug: chromium:1187513 Change-Id: Ie5142b5f43a3f23a9743ba7af0d90567fedd00d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2841083 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
angle-autoroll 226259e5 2021-04-20T09:04:43 Roll Chromium from cb5ad5e674fa to 141612cc6143 (482 revisions) https://chromium.googlesource.com/chromium/src.git/+log/cb5ad5e674fa..141612cc6143 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5658f225b4..bdd4e9dcbc * testing: https://chromium.googlesource.com/chromium/src/testing/+log/db4fc48f37..d364fd2e43 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..09248fe432 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/efd29f6f5c..93d80d8686 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f4ded123d0..b0eccdd309 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Id5942b5905f168e90198ec3b63ab77637f02c517 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2838870 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov a3d52a4d 2021-04-20T17:52:17 Skip dEQP-EGL.functional.resize.surface_size.stretch_width on Linix Vulkan NVIDIA Bug: angleproject:5884 Change-Id: I46c330b2dc78b2271999315aa2b28930aee490f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842305 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 7bf6e4fb 2021-04-20T18:17:29 Roll VK-GL-CTS from ededa67cb12a to 476acb91ebc2 (22 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/ededa67cb12a..476acb91ebc2 2021-04-16 alexander.galazin@arm.com Update Vulkan beta Headers 2021-04-16 piotr.byszewski@mobica.com Create chunked mustpass 2021-04-16 rgarcia@igalia.com Test non-uniform args in ray tracing operations 2021-04-16 alexander.galazin@arm.com Support GL 4.5 in the Program State Query tests 2021-04-16 tarceri@itsqueeze.com Add some simple shader tests for compatibility context 2021-04-16 tony.wasserka@gmx.de Add new tests for (u)int->float conversion 2021-04-16 rgarcia@igalia.com Test buffer copies with varying offsets and sizes 2021-04-16 pdaniell@nvidia.com Vulkan CTS coverage for VK_EXT_ycbcr_2plane_444_formats 2021-04-16 slawomir.cygan@intel.com Fix 'implicit-fallthrough' build error on GCC 9.3.0 2021-04-16 alexander.galazin@arm.com Support GL 4.5 in the tessellation and geometry shader interaction tests 2021-04-16 marcin.zajac@mobica.com Fix RT misc tests (querying shaderfloat64) 2021-04-16 lionel.g.landwerlin@intel.com Add missing rasterizationStream in pipeline creation 2021-04-16 sagar.ghuge@intel.com Drop unnecessary barrier 2021-04-16 piotr.byszewski@mobica.com Portability: fix ycbcr query tests 2021-04-16 rgarcia@igalia.com Make tcu::Exception noexcept copy-constructible 2021-04-14 toni.salmivalli@siru.fi dEQP-VK.graphicsfuzz.stable-colorgrid-modulo-true-conditional-divided-1 2021-04-14 toni.salmivalli@siru.fi Add a batch of GraphicsFuzz tests 2021-04-14 selcott@google.com Tests for VK_EXT_color_write_enable 2021-04-14 pdaniell@nvidia.com Tests for VK_EXT_vertex_input_dynamic_state 2021-04-14 dakeley@nvidia.com Add VK_NV_inherited_viewport_scissor tests 2021-04-14 alexander.galazin@arm.com Update Vulkan Headers 2021-04-14 jajones@nvidia.com Support alternate file path lists for loading libs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ynovikov@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com,angle-bots+autoroll-info@google.com Change-Id: I91da42609c1b9a065911762f966e163dbd02c90e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2840964 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 39c33f34 2021-04-19T17:53:19 Tests: Add "Command and Conquer: Rivals" trace Bug: angleproject:5830 Tests: TracePerfTest.Run/*command_and_conquer_rivals Change-Id: I0b5fedfdeab3c0729bac706ceb7ce98f66b41986 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2838231 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 50cd151c 2021-04-20T10:44:52 Roll third_party/vulkan-deps/ c18d8cd50..494bfcf95 (48 commits) https://chromium.googlesource.com/vulkan-deps/+log/c18d8cd5016c..494bfcf95bd6 $ git log c18d8cd50..494bfcf95 --date=short --no-merges --format='%ad %ae %s' 2021-04-20 chromium-autoroll Roll SPIRV-Cross from 3cb8e7c223a3 to d137abeef57b (5 revisions) 2021-04-20 chromium-autoroll Roll Vulkan-Loader from 64cc17099c41 to 4b868e5e13dc (2 revisions) 2021-04-19 chromium-autoroll Roll Vulkan-ValidationLayers from 61c2339d1547 to f39a8dc664c6 (2 revisions) 2021-04-19 chromium-autoroll Roll glslang from 842743722152 to 60ce877de03f (1 revision) 2021-04-19 chromium-autoroll Roll Vulkan-ValidationLayers from 33440cbab76c to 61c2339d1547 (2 revisions) 2021-04-19 chromium-autoroll Roll glslang from ed948c8e1226 to 842743722152 (1 revision) 2021-04-19 chromium-autoroll Roll SPIRV-Tools from 693d564db4e9 to dc72924cb31c (1 revision) 2021-04-19 chromium-autoroll Roll SPIRV-Cross from b4aa6dacfa8c to 3cb8e7c223a3 (1 revision) 2021-04-19 chromium-autoroll Roll SPIRV-Cross from 45818c14e49a to b4aa6dacfa8c (1 revision) 2021-04-19 chromium-autoroll Roll SPIRV-Cross from 582749ac68a9 to 45818c14e49a (1 revision) 2021-04-19 chromium-autoroll Roll Vulkan-Headers from f5ac258209dc to 074fa3055cfe (1 revision) 2021-04-16 chromium-autoroll Roll glslang from b3859343a2ca to ed948c8e1226 (1 revision) 2021-04-16 chromium-autoroll Roll Vulkan-ValidationLayers from 65576d6dc06a to 33440cbab76c (4 revisions) 2021-04-16 chromium-autoroll Roll Vulkan-ValidationLayers from 8035832536d2 to 65576d6dc06a (1 revision) 2021-04-16 chromium-autoroll Roll Vulkan-ValidationLayers from e7eb5ca5e6ec to 8035832536d2 (1 revision) 2021-04-16 chromium-autoroll Roll Vulkan-ValidationLayers from ee42bab38c3b to e7eb5ca5e6ec (2 revisions) 2021-04-16 chromium-autoroll Roll SPIRV-Tools from a02a9205ff49 to 693d564db4e9 (1 revision) 2021-04-15 chromium-autoroll Roll Vulkan-ValidationLayers from c8596531b3f7 to ee42bab38c3b (1 revision) 2021-04-15 chromium-autoroll Roll Vulkan-ValidationLayers from 675fbfaee4e7 to c8596531b3f7 (1 revision) 2021-04-15 chromium-autoroll Roll Vulkan-ValidationLayers from fc6291e5eded to 675fbfaee4e7 (2 revisions) 2021-04-15 chromium-autoroll Roll Vulkan-ValidationLayers from 962cad9d3a78 to fc6291e5eded (1 revision) 2021-04-14 chromium-autoroll Roll glslang from e7e4a8eecba5 to b3859343a2ca (1 revision) 2021-04-14 chromium-autoroll Roll glslang from e6a0e7fc7664 to e7e4a8eecba5 (1 revision) 2021-04-14 chromium-autoroll Roll Vulkan-ValidationLayers from 13c4877ea280 to 962cad9d3a78 (1 revision) 2021-04-14 chromium-autoroll Roll SPIRV-Cross from d2e1e7ba9891 to 582749ac68a9 (1 revision) 2021-04-13 chromium-autoroll Roll Vulkan-Headers from cd913e84a81d to f5ac258209dc (1 revision) 2021-04-13 chromium-autoroll Roll Vulkan-Headers from e01b00657664 to cd913e84a81d (1 revision) 2021-04-13 chromium-autoroll Roll Vulkan-ValidationLayers from 7699b91798eb to 13c4877ea280 (2 revisions) 2021-04-13 chromium-autoroll Roll Vulkan-ValidationLayers from 14f4f766ff89 to 7699b91798eb (1 revision) 2021-04-13 chromium-autoroll Roll Vulkan-ValidationLayers from 1e4ea30a1df3 to 14f4f766ff89 (1 revision) 2021-04-13 chromium-autoroll Roll glslang from a7f846a86cb2 to e6a0e7fc7664 (1 revision) 2021-04-13 chromium-autoroll Roll Vulkan-ValidationLayers from 884a3ecf0e11 to 1e4ea30a1df3 (1 revision) 2021-04-13 chromium-autoroll Roll Vulkan-Headers from e1d8c4931d8e to e01b00657664 (1 revision) 2021-04-13 chromium-autoroll Roll SPIRV-Tools from ae6a1e1d2f3e to a02a9205ff49 (1 revision) 2021-04-12 chromium-autoroll Roll Vulkan-ValidationLayers from d78df3497e17 to 884a3ecf0e11 (1 revision) 2021-04-12 chromium-autoroll Roll glslang from 5602195eed90 to a7f846a86cb2 (1 revision) 2021-04-12 chromium-autoroll Roll glslang from 9f76fd133063 to 5602195eed90 (1 revision) 2021-04-12 chromium-autoroll Roll SPIRV-Tools from 6210375e1399 to ae6a1e1d2f3e (1 revision) 2021-04-09 chromium-autoroll Roll SPIRV-Tools from 8da800c4cbc7 to 6210375e1399 (1 revision) 2021-04-09 chromium-autoroll Roll Vulkan-ValidationLayers from abf8d903e390 to d78df3497e17 (1 revision) 2021-04-09 chromium-autoroll Roll Vulkan-ValidationLayers from 317a46523468 to abf8d903e390 (3 revisions) 2021-04-09 chromium-autoroll Roll Vulkan-ValidationLayers from 9b36350504c7 to 317a46523468 (2 revisions) 2021-04-09 chromium-autoroll Roll SPIRV-Tools from 212895d4c2cd to 8da800c4cbc7 (1 revision) 2021-04-08 chromium-autoroll Roll Vulkan-ValidationLayers from 3986d4ffc6b1 to 9b36350504c7 (2 revisions) 2021-04-08 chromium-autoroll Roll Vulkan-ValidationLayers from eb791f3842c3 to 3986d4ffc6b1 (1 revision) 2021-04-08 chromium-autoroll Roll glslang from 4099f444484b to 9f76fd133063 (1 revision) 2021-04-08 chromium-autoroll Roll Vulkan-ValidationLayers from f563b367c72a to eb791f3842c3 (1 revision) 2021-04-08 chromium-autoroll Roll glslang from 1481399549c5 to 4099f444484b (1 revision) Created with: roll-dep third_party/vulkan-deps Bug: angleproject:5879 Change-Id: Ic36d6ded7116f8a59c9c4bcfb995dd4b870e3ecb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2837548 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov c275ce14 2021-04-19T14:06:53 Skip Texture2DBaseMaxTestES3.GenerateMipmapAfterRebase* on Mac ARM GL Bug: angleproject:5880 Change-Id: I18698e0603938c43878ad4d28379d6976952c561 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2836787 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Mohan Maiya 2d741b43 2021-04-20T07:33:02 Add KHR_blend_equation_advanced entry points Addition of the entry points for GL_KHR_blend_equation_advanced extension. Bug: angleproject:3586 Change-Id: I7a651c19a4b3d0a7cfe4af7813f1530d27704bc1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2830140 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Amy Liu 95935176 2021-03-26T17:38:21 Handle the compression of big pipeline cache. Big pipeline cache will cost much time to compress. Regarding the perfomance, handle the compression of big pipeline cache in this way: 1)Return when the pipeline cache data is larger than 10M. 2)Use worker thread to complete compression. Bug: angleproject:4722 Change-Id: I62eb69d8c46729261f0502af01450ec301c258f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2788169 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 2f808349 2021-04-16T19:21:15 Add standalone Android build. Includes necessary DEPS and GN build changes. Some folders are copied directly from Chromium because they don't exist as source mirrors or aren't available for other reasons. Bug: angleproject:2344 Change-Id: Ibb7f8a3e2288048b7aed2b0e277ca63b5a932c57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826480 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Mohan Maiya bdf5f084 2021-04-16T11:29:29 Add EXT_texture_border_clamp entry points Addition of the entry points for EXT_texture_border_clamp extension. Bug: angleproject:3586 Change-Id: I366c2748213d7fdde815543129320278937000e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2830146 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang b574643e 2021-04-19T12:47:05 D3D11: Skip blits if there is no intersection of dest areas Blit11 would clip the destination rectangle with the destination size but ignore the result. gl::ClipRectangle returns false when the rectangles do not intersect at all, indicating the blit can be skipped. This could lead to an out-of-bounds write to the GPU memory for the destination texture. Mark ClipRectangle as nodiscard to prevent future issues. Bug: chromium:1199402 Change-Id: I260e82d0917b8aa7e7887f2c9f7ed4b1a03ba785 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2836786 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Jamie Madill 3691797a 2021-04-19T16:16:59 Revert "infra: Switch to "angle_2" presubmit config." This reverts commit 5166a25b2ccf04881c3fc1cd3f19e2246b23fec0. Reason for revert: Breaks presubmit tester (again). Original change's description: > infra: Switch to "angle_2" presubmit config. > > We will revert this once we remove the depot_tools config. > > Bug: angleproject:5114 > Change-Id: If922a24c9955ba5d5d30ec634fa6c3d6db177f65 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831999 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5114 Change-Id: I7a540c728f6851151c2f708480de21ce41938111 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2836785 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 5aa5de76 2021-04-16T11:22:15 Vulkan: Keep the output variable of TCS active for barrier OpControlBarrier implicitly synchronizes 'Output' storage class. If TCS has an out varying it should be considered active because TCS invocations themselves can read each others' outputs. Bug: angleproject:5557 Tests: KHR-GLES32.core.tessellation_shader.tessellation_shader_tc_barriers.barrier_guarded_*_calls Change-Id: Ic252c0afff43a68828ee4cf5f4ba890b1b67731e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770679 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Jamie Madill 39d8dde8 2021-04-19T15:02:02 Revert "Revert "Vulkan: Suppress draw-time push constant VVL warnings." This reverts commit b027dfeb83d028ae72ed1957ba81e6c5dc3baffa. Reason for revert: Breaking win-trace-rel b/c of missing VVL roll. Original change's description: > Revert "Vulkan: Suppress draw-time push constant VVL warnings. > " > > This reverts commit f34b40dab0487bbabc37645918bed87048107e14. > > Reason for revert: VVL bug is fixed. > > Original change's description: > > Vulkan: Suppress draw-time push constant VVL warnings. > > > > > > > > VUID-vkCmdDraw-None-02698 > > > > VUID-vkCmdDrawIndexed-None-02698 > > > > VUID-vkCmdDrawIndirect-None-02698 > > > > VUID-vkCmdDrawIndirectCount-None-02698 > > > > VUID-vkCmdDrawIndexedIndirect-None-02698 > > > > VUID-vkCmdDrawIndexedIndirectCount-None-02698 > > > > VUID-vkCmdDispatch-None-02698 > > > > > > > > Bug: angleproject:5821 > > Change-Id: Ic8ca6178ce50b409ac8d256848654f43f91fae8e > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808854 > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > Commit-Queue: Jamie Madill <jmadill@chromium.org> > > Bug: angleproject:5821 > Change-Id: I771e81a46893f2875605e472273f1388587e042e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831997 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:5821 Change-Id: If9f80d052736e40c4c6d3e9a1cd629205901ba49 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2836285 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 5166a25b 2021-04-16T20:07:32 infra: Switch to "angle_2" presubmit config. We will revert this once we remove the depot_tools config. Bug: angleproject:5114 Change-Id: If922a24c9955ba5d5d30ec634fa6c3d6db177f65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831999 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 5813365f 2021-04-19T10:01:01 Roll SwiftShader from f32791f5d53b to dac99e8221a8 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/f32791f5d53b..dac99e8221a8 2021-04-16 capn@google.com Update Kokoro's clang-format to version 11.0.1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I07e7a243f65968e94b942b18d52f11ae6fcc3af3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2833601 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 24d21dce 2021-04-19T07:03:07 Roll Chromium from 11d568cbfed1 to cb5ad5e674fa (484 revisions) https://chromium.googlesource.com/chromium/src.git/+log/11d568cbfed1..cb5ad5e674fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e00ea2a33f..5658f225b4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5d440f33b4..db4fc48f37 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d6284252dc * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f959d17028..efd29f6f5c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/eefe475693..d7dd881ddc * tools/luci-go: git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0..git_revision:0f913477afc80d5c4b6609834d3bef6b44910e67 * tools/luci-go: git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0..git_revision:0f913477afc80d5c4b6609834d3bef6b44910e67 * tools/luci-go: git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0..git_revision:0f913477afc80d5c4b6609834d3bef6b44910e67 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5e7cca9ca0..f4ded123d0 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I61264c3b92501cd9b1816dee7c26cf2d32efdc31 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2834733 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi b027dfeb 2021-04-16T20:50:34 Revert "Vulkan: Suppress draw-time push constant VVL warnings. " This reverts commit f34b40dab0487bbabc37645918bed87048107e14. Reason for revert: VVL bug is fixed. Original change's description: > Vulkan: Suppress draw-time push constant VVL warnings. > > > > VUID-vkCmdDraw-None-02698 > > VUID-vkCmdDrawIndexed-None-02698 > > VUID-vkCmdDrawIndirect-None-02698 > > VUID-vkCmdDrawIndirectCount-None-02698 > > VUID-vkCmdDrawIndexedIndirect-None-02698 > > VUID-vkCmdDrawIndexedIndirectCount-None-02698 > > VUID-vkCmdDispatch-None-02698 > > > > Bug: angleproject:5821 > Change-Id: Ic8ca6178ce50b409ac8d256848654f43f91fae8e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808854 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5821 Change-Id: I771e81a46893f2875605e472273f1388587e042e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831997 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 6d8e2f87 2021-04-17T02:03:03 Suppress fifa mobile on intel/windows Flakily renders black. Bug: angleproject:5875 Change-Id: I16805278e00d431bf81e531d5b0b17868ee8f476 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2833011 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop da0a1ee9 2021-04-16T22:55:00 Tests: Add 3DMark Slingshot Test 2 trace This trace is ES 3.0 based and shader heavy. Test: angle_perftests --gtest_filter="*slingshot_test2*" Tbr: jmadill@google.com,timvp@google.com Bug: b/185595371 Bug: angleproject:5877 Change-Id: I3d66a5f818b33581b4237e8a9efc56af5666d98b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2832657 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop fc136cf8 2021-04-15T18:06:31 Tests: Add 3DMark Slingshot Test 1 trace This trace is ES 3.0 based and geometry heavy. Test: angle_perftests --gtest_filter="*slingshot_test1*" Tbr: jmadill@google.com,timvp@google.com Bug: b/185595371 Bug: angleproject:5877 Change-Id: I8528d399fedbe6ea3a07297a869f33de4605c946 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2832672 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi c750129e 2021-04-16T16:59:25 Vulkan: Remove inappropriate use of VK_NULL_HANDLE A change in Vulkan-Headers changes the value of VK_NULL_HANDLE, exposing an invalid usage in ANGLE, which is fixed in this change. Bug: angleproject:5879 Change-Id: I136fdc9e707650a060eaee062c7cf8cf24d9e8b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831998 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao a37d9748 2021-04-13T14:52:31 Vulkan: Add support for FBO with unequal sized attachments OpenGLES 3.0 allows FBO with unequal sized attachments. This CL removes assertion that all attachment must have equal size from vulkan backend, and uses common intersect area to create VkFramebuffer object. Bug: b/181800403 Change-Id: Icbb12a26784b184ebd91740855672013f64b889d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824760 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Charlie Lao aa2d400a 2021-04-12T17:21:37 Vulkan: Add test for FBO with unequal sized attachments Before OpenGLES3.0, framebuffer object with unequal sized attachment is considered incomplete. That restriction has been removed in ARB version of spec and is legit use in OpenGLES 3.0. This adds a test for this specific usage. Bug: b/181800403 Test: FramebufferTest_ES3.AttachmentWithUnequalDimensions Change-Id: I79608bfd8f10855c6fc47511e080ba3ca4e46c59 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824366 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Shahbaz Youssefi e8b18e79 2021-04-16T11:57:53 Skip failing test on AMD/Linux This test was suppressed on AMD/Windows already. Bug: angleproject:5687 Bug: angleproject:5874 Change-Id: I9b6bac81adc017f80634271063d53f3d4eebba0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831993 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Xiaoxuan Liu ed4f7cb6 2021-03-03T17:56:07 Reland "Reland "Add support for Linux GPU info with Vulkan backend"" This is a reland of 9a8397327f9aac278f4bd1f5ab9094eec7e7798b Chrome Linux crash issue could be fixed in 0615bbde39ca42e27eb764b2b4986b21ab602ce9, let's reland this now. Original change's description: > Reland "Add support for Linux GPU info with Vulkan backend" > > This is a reland of 5c09c1f882f15e1a77577f1a62d861355aac90a4 > > Extra change: Add new ANGLE_HAS_VULKAN_SYSTEM_INFO compile > variable for GetSystemInfoVulkan() in linux platform. > > Original change's description: > > Add support for Linux GPU info with Vulkan backend > > > > 1. Add support for Linux GPU info with vulkan backend: for > > dev board without PCI support, try vulkan backend to get > > GPU info. > > 2. Fix getVulkanInstance() issue when loading non-exist lib: > > return NULL instance if open lib failed. > > > > Bug: angleproject:5717 > > Change-Id: I03c11da25a8787496d098f6c9d6b4c53701383e4 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2734375 > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > Commit-Queue: Jamie Madill <jmadill@chromium.org> > > Bug: angleproject:5717 > Change-Id: Iaaab8f512b6ec1d524d7ebb3b4252fec3cfe7dc3 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739097 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5717 Change-Id: Iad6736f9137b7e9640c97fa2b9eded3fd37ac88f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821410 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 14f8918c 2021-04-16T09:17:29 Migrate more scripts to python3 Test: python3 scripts/run_code_generation.py Bug: angleproject:5707 Change-Id: I5abae69c1c6bf03cc418f10beaabc80288fa1c94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2828979 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Geoff Lang 69a26def 2021-04-15T14:14:56 Remove 3pp files in third_party/jdk. These files should not be duplicated from Chrome, they are used as part of Chrome's rolling process for these deps. Bug: angleproject:5839 Change-Id: If95b11585e5aa7d8f834412d41dca377c495b1fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2829330 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 2561c646 2021-03-19T14:09:52 Vulkan: Handle non array type varying error case in TS Tessellation control, tessellation evaluation and geometry shader per-vertex input variables and blocks are required to be declared as arrays. Ensure these variables meet the requirements and error out if they don't. Bug: angleproject:5557 Test: KHR-GLES32.core.tessellation_shader.compilation_and_linking_errors.te_non_arrayed_per_vertex_input_blocks Change-Id: I0213fcc6fab90dea7597462a65cbbb7777e67108 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774759 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll f78ec9db 2021-04-16T07:36:31 Roll Chromium from cac0b331e3fc to 11d568cbfed1 (483 revisions) https://chromium.googlesource.com/chromium/src.git/+log/cac0b331e3fc..11d568cbfed1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e966858a7e..e00ea2a33f * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4ef8239f68..5d440f33b4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c30133fce5 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b1cc5ed9e8..f959d17028 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/fae4e7d723..5e7cca9ca0 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I88c789cd45eb5dbdc4d002029d4fddade79aa06c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2830144 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Le Hoang Quyen f2aa9d5d 2021-04-11T14:55:19 Reland: Metal: Support importing external metal textures This relands I4d4a88cfbb77d8b7508b787c7fec44073d3b11b0. Fixes: - uninstantiated ImageTestMetal error - failed ImageTest.ANGLEExtensionAvailability on ARM mac. Bug: angleproject:5763 Bug: angleproject:5814 Change-Id: I906fe52baefd6be3c6e00f594795bd527df01616 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2820178 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Jamie Madill eac31b7d 2021-04-15T19:48:36 Android: Include android-deps into Android checkout. These auto-generated deps are necessary for the standalone build. Updates the roll script to start including these automatically. Bug: angleproject:2344 Change-Id: I389c203a2ddb971e3aeccb728cf37e232f32031e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826479 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 0c77f3ad 2021-03-10T15:58:00 Vulkan: Implement shader buffers descriptor cache. Implements a descriptor set cache for UBOs, SSBOs, and atomic counter buffers. Storage Images and framebuffer fetch input attachments are not yet included. Requires moving the buffer barrier handling into ContextVk, similarly to how we handle the barriers for Textures. The packed description key for the descriptors uses a "fast" vector with a basic minimum size. For most cases of a few buffers this will fit easily in stack memory, but for larger programs with many buffers we fit this into heap memory. The key has a large upper bound due to the high ES 3.2 requirements and the need to index several values such as the offset and binding size. We use dynamic offsets for uniform buffers when possible. This ensures applications like Manhattan 3.1 that use sets of common buffers with changing offsets hit the cache most of the time. Because of resource limits we pick at compilation time whether to use dynamic or static descriptor sets. Mostly this applies to tests that use a large number of uniform buffers. A future implementation could be smart and would recompile the program with heuristics to use a minimal number of dynamic indices. Reduces the number of descriptor set updates from ~300 -> ~30 per frame in Manhattan 3.1 and in Asphalt 9 from 900+ to as low as 0 per frame. Bug: angleproject:5736 Change-Id: I5c2a3881bec90d301dab15cc86c8a70e60674ad7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757515 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
John Plate 8226dc23 2021-04-15T19:25:31 Generate CL enums in libGLESv2 Bug: angleproject:5869 Change-Id: Ie547d415bed37accef6cb62d28bc6b088a1eb810 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2829370 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: John Plate <jplate@google.com>
Tim Van Patten fbfecbe2 2021-04-07T11:26:13 Capture/Replay: Add PPO/glProgramUniform support Command and Conquer: Rivals requires additional frame capture API support: - Program Pipeline Objects - glProgramUniform* Bug: angleproject:5830 Change-Id: I159086f92d2dfead0a513cd17fadeda7df92f408 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809891 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 4f68a4ee 2021-04-06T12:46:02 Remove suppression for fixed CTS tests CTS bugs are fixed in [1] and [2]. [1]: https://gerrit.khronos.org/c/vk-gl-cts/+/7062 [2]: https://gerrit.khronos.org/c/vk-gl-cts/+/7049 Bug: angleproject:5673 Change-Id: I2d86f53a6a83bab143f89896d4d5dab3cc7b2334 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808053 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao fb288312 2021-04-12T12:38:03 Vulkan: Consolidate mReadOnlyDepthStencilMode to mRenderPassUsageFlags Since now ImageHelper object has a mRenderPassUsageFlags tracking how it is been used by current RenderPassCommands, we can consolidate mReadOnlyDepthStencilMode into a bit in the mRenderPassUsageFlags. The read only mode is just a special attachment mode, so this makes code more consistent and able to get rid of the extra dword for mReadOnlyDepthStencilMode. Bug: b/181797383 Change-Id: Ie9b7be1c18c392e5b2712bdae6ab6506de8d6d34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821942 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao 5eac3169 2021-04-09T15:54:11 Vulkan: Support sample/render to depth texture with different LOD Previously we supported read only depth attachment that attachment and sample are using the same texture. It was always assuming it will be read only if the same texture is attached to FBO and same time bound to texture unit. But we never supported if it actually writing to depth texture, but at the different level with sampling. This is supported OpenGL operation as long as the levels render to is outside [base_level, max_level]. Later on, we added support of the above operation, but limited to color buffers. This CL extends the same support of render and sample to the same depth texture with non-overlapping levels. Android game black desert mobile is running into this usage case. Bug: b/181797383 Change-Id: I7ee1d52f27603f933102ad1b098684309449c406 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819487 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
Charlie Lao e55462b9 2021-04-09T18:27:16 Vulkan: Add test for render+sample depth texture with non-overlap LOD Render and sample from the same texture and then bind to another FBO without trigger texture bind should still detect the condition that it is render and sample same texture. Render to depth texture and sample form the same depth texture but with non-overlapping levels should work. Bug: b/181797383 Test: FramebufferTest_ES3.SampleFromAttachedTextureWithDifferentLODAndFBOSwitch Test: FramebufferTest_ES3.RenderSampleImmutableDepthTextureWithExcludedLevel Change-Id: I0d330d6f9530eb4fea417019a627890c4a5c1154 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819486 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
Shahbaz Youssefi 1a146f07 2021-04-06T15:40:27 Roll VK-GL-CTS from c4e6dbe68e04 to ededa67cb12a (76 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c4e6dbe68e04..ededa67cb12a 2021-04-13 timvp@google.com Always include sys/system_properties.h for Android 2021-04-09 juha.heiskanen@siru.fi Add primitive topologies for XFB query tests 2021-04-09 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master 2021-04-09 s.fricke@samsung.com Add OpImageQuerySamples with Storage Image test 2021-04-09 jdarpinian@chromium.org EXT_multisampled_render_to_texture test using ReadPixels 2021-04-08 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master 2021-04-08 alexander.galazin@arm.com Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master 2021-04-07 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master 2021-04-07 jajones@nvidia.com Add CMake detection logic for libdrm include files 2021-04-02 juha.heiskanen@siru.fi Add early fragment tests 2021-04-02 michal.jakubek@mobica.com Add tests for multisample resolve to level != 0 2021-04-02 boris.zanin@mobica.com Add coverage for 1D, 1D array and Cube array shadow images 2021-04-02 boris.zanin@mobica.com Add subgroup testing for ray tracing pipelines 2021-04-02 caio.oliveira@intel.com Test interaction between Workgroup explicit layout and zero initialization 2021-04-02 Alexander.Galazin@arm.com Merge "Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master" 2021-04-02 cheryl.wei@arm.com Add waived tests support for cts tools 2021-04-01 rgarcia@igalia.com Remove duplicate dataSafe function from deSTLUtil 2021-04-01 boris.zanin@mobica.com Add keys deqp-log-decompiled-spirv and deqp-log-empty-loginfo 2021-04-01 apinheiro@igalia.com Check for drawIndirectFirstInstance should only affect indirect draw calls 2021-03-31 alexander.galazin@arm.com Support GL 4.5 in the uniform location tests 2021-03-31 alexander.galazin@arm.com Support GL 4.5 in the multisample texture tests 2021-03-31 alexander.galazin@arm.com Support GL 4.5 in the EXT_texture_border_clamp tests 2021-03-30 alexander.galazin@arm.com Update Vulkan headers 2021-03-30 alexander.galazin@arm.com Support GL 4.5 in the geometry shading tests 2021-03-30 alexander.galazin@arm.com Support GL 4.5 in the tessellation tests 2021-03-30 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master 2021-03-30 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master 2021-03-30 alexander.galazin@arm.com Support GL 4.5 in the copy image tests 2021-03-26 michal.jakubek@mobica.com Added tests for most-negative snorm values in images 2021-03-26 alexander.galazin@arm.com Notice of withdrawal of Vulkan CTS 1.2.2.x 2021-03-25 timvp@google.com Include sys/system_properties.h in teglAndroidUtil.cpp 2021-03-25 afdx@google.com Add a batch of GraphicsFuzz tests 2021-03-25 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master 2021-03-25 rgarcia@igalia.com QPA image viewer updates 2021-03-25 boris.zanin@mobica.com Fulfill OpControlBarrier requirement 2021-03-25 slawomir.cygan@intel.com Add an option to terminate after first failure, update READMEs 2021-03-25 slawomir.cygan@intel.com Terminate with an error if unrecognized arguments are passed to dEQP executable 2021-03-25 venni.ihanakangas@siru.fi Ensure only Unix paths are added to deqp.apk 2021-03-19 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master 2021-03-19 jbolz@nvidia.com Add tests to exercise 'readonly' SSBOs 2021-03-18 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master 2021-03-18 slawomir.cygan@intel.com Fix required features checks in shaderRecordExplicitScalarOffset_6 test case 2021-03-18 tom.cooper@arm.com Add VK_EXT_headless_surface surface tests 2021-03-18 Junda.Liu@amd.com Fix robust buffer access result checking for partially out of bound cases 2021-03-18 tapani.palli@intel.com Use linear tiling with external_memory_host tests 2021-03-18 ancheng.qiao@arm.com Fix precision issue in NearestEdgeTests shaders 2021-03-17 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master 2021-03-17 gleese@broadcom.com Enable shadow filtering tests for non-filterable formats 2021-03-17 rgarcia@igalia.com Add BGR and BGRA formats to image view tests 2021-03-17 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master 2021-03-17 jari.komppa@siru.fi Add tests for standard multisample positions 2021-03-17 rgarcia@igalia.com Push constant overwrite tests 2021-03-17 rgarcia@igalia.com Test large command buffers with many draw commands 2021-03-17 rgarcia@igalia.com Test barycentric coordinates in ray tracing hits 2021-03-17 rgarcia@igalia.com Add missing mandatory features 2021-03-17 venni.ihanakangas@siru.fi Ensure WSI colorspace has no effect on image contents 2021-03-17 tapani.palli@intel.com reset minSampleShading only with OpenGL Core 4.0+ 2021-03-16 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master 2021-03-16 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master 2021-03-16 alexander.galazin@arm.com Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master 2021-03-15 rgarcia@igalia.com Enable validation for all custom devices 2021-03-15 rgarcia@igalia.com Remove multiview requirement in extended dyn state tests 2021-03-15 boris.zanin@mobica.com Fix recursion depth requirement in complexcontrolflow 2021-03-15 rgarcia@igalia.com Check image extent support in watertightness tests 2021-03-15 boris.zanin@mobica.com Read deserealization size from stream 2021-03-15 gleese@broadcom.com Fix flush/invalidate in mismatched_write_op tests 2021-03-15 gleese@broadcom.com Fix sync validation for mismatched_write_op tests 2021-03-15 tapani.palli@intel.com Check if image sample count supported by VkSampleCountFlags 2021-03-15 rgarcia@igalia.com Always accumulate errors in desc set random tests 2021-03-15 syoussefi@google.com Fix missing barrier in compute test 2021-03-15 syoussefi@google.com Fix missing barrier in texture buffer test 2021-03-15 ari.suonpaa@siru.fi Replace libUI with native Android AHB API 2021-03-10 gleese@broadcom.com Add a waiver for depth bias on some Broadcom GPUs 2021-03-10 alexander.galazin@arm.com Update Vulkan/GL Readme 2021-03-10 ari.suonpaa@siru.fi Update Amber 2021-03-08 toni.salmivalli@siru.fi Add a batch of Graphicsfuzz tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC syoussefi@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: angleproject:5816 Change-Id: I324ce9596a62771726dc4504b2341e049818f7de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2807533 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c782ef19 2021-04-15T10:08:34 Skip TracePerfTest.Run/*_idle_heroes on Pixel 2 The test crashes both with the native and Vulkan drivers. Bug: angleproject:5867 Change-Id: I6fe3acd7050b0cb2d6f735de684b897aca0a6bb8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826402 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
John Plate a2ade894 2021-04-13T21:12:26 Clear macros 'NEAR' and 'FAR' Bug: angleproject:5861 Change-Id: Id4cccf5e06dd39c37bd4fa23965edd31633b0fef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824429 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: John Plate <jplate@google.com>
Lubosz Sarnecki ea6dd8b3 2021-04-14T13:45:14 Tests: Add Idle Heroes trace. Test: angle_perftests --gtest_filter="*idle_heroes*" Bug: b/180419827 Bug: angleproject:5865 Change-Id: Ia121c9c76b67c130534a06e5dc09ac8bd7d2efe9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826125 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Gert Wollny 6f3bd395 2021-04-13T23:53:53 Capture/Replay: Enable InstancingTest.LineLoop/* tests Bug: angleproject:5853 Change-Id: Ia1a7a1cec781dca22ab49a9189dd3560ac148216 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824435 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 5186af3b 2021-04-15T07:00:17 Roll Chromium from 21426fd08f99 to cac0b331e3fc (436 revisions) https://chromium.googlesource.com/chromium/src.git/+log/21426fd08f99..cac0b331e3fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b30d9d1676..e966858a7e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5185dac7e9..4ef8239f68 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/5447d00cc9..10b50b69d8 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0fb9b3ace8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f9d141ab4d..b1cc5ed9e8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/59d5575e12..eefe475693 * tools/luci-go: git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6..git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0 * tools/luci-go: git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6..git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0 * tools/luci-go: git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6..git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/fc7a3623d6..fae4e7d723 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I8ef062cf57e98b30672d8ad397b56b303595e6ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2827775 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Gert Wollny 6362dcf1 2021-04-14T22:47:31 JsonSerializer: Add tests for sorting and non-unique keys Bug: angleproject:5853 Change-Id: I85e64900a58a2706087b71769470bb33fb4e8522 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824434 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 212849e9 2021-04-13T22:54:10 Capture: store some array values as vector This reduces the number of values that are added with the same key. Bug: angleproject:5853 Change-Id: Ie13408cc7ad419dec06746dc38b753f76292fae6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824433 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Gert Wollny 3116c91c 2021-04-13T18:02:49 JsonSerializer: Sort group members before writing them out Use a multimap to accumulate the values added to a group and then add them to the Json group when it is finished. Bug: angleproject:5853 Change-Id: Idbe82acc5f9a9671063f02bd1af039575aa52e87 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824432 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Alexis Hetu 45344f05 2021-04-14T14:51:41 Allow Chromecast tests to run on SwANGLE This cl makes 2 changes allowing Chromecast tests to use SwANGLE: 1) It sets angle_use_vulkan_display to true when using Chromecast, effectively allowing SwANGLE to be used 2) It sets angle_vulkan_display_mode to "headless", allowing it to use DisplayVkHeadless instead of DisplayVkSimple, which ends up using "VK_EXT_headless_surface" instead of "VK_KHR_display", so that it's supported by SwiftShader Vulkan on Chromecast. Bug: chromium:1060139 Change-Id: Ia521ebddac14f5e34666bb9b64603bec598c41ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826196 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Alexey Knyazev 90d18b03 2021-03-10T10:31:39 Upgrade overlay fonts generator to Python 3 Bug: angleproject:5707 Change-Id: I809669d7a7de16ed2e098f59067c8e1d9c44a75c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773292 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Jamie Madill 12342643 2021-04-14T08:49:24 infra: Remove osx_sdk cache. This is no longer necessary now that we use mac_toolchain.py. Bug: angleproject:5114 Change-Id: I0afac641d55e9be2bd04103301aec3080d3332c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2823859 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
John Plate 9e1ccb24 2021-04-14T15:02:16 Workaround for missing include in OpenCL headers Bug: angleproject:5759 Change-Id: Ieeb5a251e614a4df1b5362dee474b368f362e0fc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826121 Commit-Queue: John Plate <jplate@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 9254eb8e 2021-04-13T18:00:49 Capture: Fix storing strings instead of scalars Bug: angleproject:5853 Change-Id: Id63922d881ce7778236e4ab3417bf9414fc0e59b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824431 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi c9b33729 2021-04-14T14:52:27 Revert "Roll vulkan-deps from c18d8cd5016c to a441440ae454 (23 revisions)" This reverts commit 8105d9ea0b16a11d84bbcf660c94d298b050e123. Reason for revert: Fails compilation Original change's description: > Roll vulkan-deps from c18d8cd5016c to a441440ae454 (23 revisions) > > https://chromium.googlesource.com/vulkan-deps.git/+log/c18d8cd5016c..a441440ae454 > > Changed dependencies: > * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/1481399549..e6a0e7fc76 > * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/212895d4c2..a02a9205ff > * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/e1d8c4931d..f5ac258209 > * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f563b367c7..13c4877ea2 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/vulkan-deps-angle-autoroll > Please CC syoussefi@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: syoussefi@google.com > Change-Id: Id3c917a802469caf50238bc268a328b2455ffa24 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826008 > Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bug: angleproject:5864 Change-Id: I093218ed8324562830f83a26378d164a86d00ae0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826472 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 8105d9ea 2021-04-14T10:01:46 Roll vulkan-deps from c18d8cd5016c to a441440ae454 (23 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c18d8cd5016c..a441440ae454 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/1481399549..e6a0e7fc76 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/212895d4c2..a02a9205ff * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/e1d8c4931d..f5ac258209 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f563b367c7..13c4877ea2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Id3c917a802469caf50238bc268a328b2455ffa24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826008 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9cbb7106 2021-04-14T10:01:01 Roll SwiftShader from 77edad299907 to f32791f5d53b (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/77edad299907..f32791f5d53b 2021-04-14 swiftshader.regress@gmail.com Regres: Update test lists @ b71a5569 2021-04-13 srisser@google.com Implement depthBoundsTest 2021-04-13 capn@google.com Eliminate the OpenGL ES 1.1 implementation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ifdd5c4c0f35d46d16090f27638002338b7f8f1a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2825849 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4393c0f8 2021-04-14T07:00:31 Roll Chromium from cb430282a083 to 21426fd08f99 (209 revisions) https://chromium.googlesource.com/chromium/src.git/+log/cb430282a083..21426fd08f99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/dde8d8929d..b30d9d1676 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/edbd63483e..5185dac7e9 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b226a4b7af * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d73d069a76..f9d141ab4d * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/633b99a892..59d5575e12 * tools/luci-go: git_revision:99ac75773c6241b6ddf82ade4c54553faa084530..git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6 * tools/luci-go: git_revision:99ac75773c6241b6ddf82ade4c54553faa084530..git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6 * tools/luci-go: git_revision:99ac75773c6241b6ddf82ade4c54553faa084530..git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bfc3b95479..fc7a3623d6 * tools/skia_goldctl/linux: mAuXqU7IqMTl2o166z_OMy_IZxh0ajpEUPuXYy4_BfcC..R23Oztsyro8ca7QGaNGKjN7duf5fsN6I6Dq2Nwyh2YQC * tools/skia_goldctl/mac: TH-LRMBSdzpB3b-wmecnLTut5qaef26EM-ZbtQM2CIUC..Ipkmq4bl5d7VmPVlEonzZMPLnHxMr-LaDFi8Dz_r8-8C * tools/skia_goldctl/win: Lzfohgeqx2FAmTxtM5eYQshIXb5YBoNk73cmoh_dP3sC..QCamcihHhiASX-AasohPdhiBOtj0ikJ3fUByIMEfrEIC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I25b1ee88a463e431fbdbf5d0856d9f87d7257d0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824767 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop fdfb2b82 2021-04-09T15:42:12 Capture/Replay: Support non-binary GLboolean This CL contains two changes. One to how we print out GLboolean values, and another to how we capture GLbooleans. According to the spec, anything non-zero can be considered GL_TRUE when setting state: When the type of internal state is boolean, zero integer or floating-point values are converted to FALSE and non-zero values are converted to TRUE. Dota Underlords is using 0xFF for GL_TRUE. Before the change, this manifested as: // logcat glColorMask(context = 4, red = kUnknownGLenumString, green = kUnknownGLenumString, blue = kUnknownGLenumString, alpha = GL_FALSE) // trace glColorMask(GL_INVALID_ENUM, GL_INVALID_ENUM, GL_INVALID_ENUM, GL_FALSE); After: // logcat glColorMask(context = 4, red = 0x00FF, green = 0x00FF, blue = 0x00FF, alpha = GL_FALSE) // trace glColorMask(0xFF, 0xFF, 0xFF, GL_FALSE); Test: MEC for Dota Underlords Bug: b/185192780 Bug: angleproject:5857 Change-Id: Ie53aeba8d8a40f91ee375467b325d8e6be053a98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821947 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop 7a95a620 2021-04-09T16:00:26 Capture/Replay: Support glGetQueryiv Test: MEC for Dota Underlords Bug: b/185192780 Bug: angleproject:5857 Change-Id: I59ced20117bde50b5b734a82cb2e5966d1b27227 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821946 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Cody Northrop 4f723d2c 2021-04-09T15:42:36 Capture/Replay: Support glBufferStorageEXT Add the entrypoint, and when a buffer is immutable, recreate it with glBufferStorageEXT. Test: MEC for Dota Underlords Bug: b/185192780 Bug: angleproject:5857 Change-Id: I29b934bdff4185d19594e49e9387dd79c6031aa5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821945 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill 68f1203d 2021-04-13T21:55:07 Disable location tags in test isolates. The current setup has problems producing tags in an ANGLE checkout. Bug: angleproject:5114 Change-Id: I91864650ddb2a9df0ac533bf4c43259c476a99ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822238 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Ian Elliott 9c51f93d 2021-04-12T16:49:53 Don't call {begin|end}DebugUtilsLabelEXT() when not enabled The ContextVk::handleDirtyEventLogImpl() and ContextVk::endEventLog() methods called the {begin|end}DebugUtilsLabelEXT() methods when the VK_EXT_debug_utils extension is not enabled. This manifests when enabling/using VVL stand-alone (i.e. when the the debug-utils extension is not also present). Bug: b/183133198 Change-Id: I043b174d457a8796831184c092661f24b33c1db4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821943 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill bf6e074f 2021-04-13T13:23:26 Add gclient variable to checkout traces. 'checkout_angle_restricted_traces' controls if we should check out the trace tests. We can give restricted access to partners for these traces. Defaults to the same setting as 'checkout_angle_internal'. Bug: angleproject:5860 Change-Id: I36efffb180b35e11e104e2c99bc89fb4be4e0708 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822232 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll ae99b3d5 2021-04-13T20:52:38 Roll Chromium from ab36e1e42f00 to cb430282a083 (277 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ab36e1e42f00..cb430282a083 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/79006bea8b..dde8d8929d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e5f83f632d..edbd63483e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2b4b340c6e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/057831ef1f..d73d069a76 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7168936235..633b99a892 No update to Clang. Bug: None Tbr: syoussefi@google.com,jmadill@google.com Change-Id: I8be169064f0704707d5ae8226f7ffbfce6e9dfd1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824358 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 6faf9ef3 2021-04-13T16:11:50 infra: Remove unused debug/cpu properties from tests. These are now configured through mb_config.pyl. We still pass in the properties to the lucicfg helper function set up the waterfall UI. Bug: angleproject:5114 Change-Id: Ib46ab95f5803a166fd2342679afbfcaa6f467c45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822233 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny fb3173b9 2021-04-13T15:05:44 FrameCapture: write the float values with high precision Because values might be the result of calculations that require some accuracy, writing the float values with the default formatting may not be sufficient to replay correctly, therefore format the values so that they carry more digits. In addition, enable the test that are now passing. Bug: angleproject:5846 Bug: angleproject:5847 Change-Id: I305552a1ffa3cded6326df59883912e14c95f5f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822257 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jonah Ryan-Davis 2d873e0c 2021-03-01T14:38:39 GL: Workaround to sanitize amdgpu renderer strings. On Linux with the amdgpu driver, the GL_RENDERER string contains precise kernel and DRM version info. We should sanitize this info before using these strings for user privacy. Bug: chromium:1181193 Change-Id: I047d1abf5b51412b4258a021761cc450385ef0fe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2727658 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov ad01350e 2021-04-13T16:11:13 Remove obsolete Linux, Ozone and Fuchsia bots from CQ Also removes the new linux-ozone-angle-try bot, since we are no longer interested to test on this configuration. Bug: angleproject:4483, chromium:1187259 Change-Id: Iaf50ba99905498cee5dbcac27e1cd7c936c8a975 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822234 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
John Plate 8994fc7b 2021-04-12T19:46:11 Migrate CL entry points to libGLESv2 Bug: angleproject:5759 Change-Id: I79644e7bda3ad0a15eb041b2805b8765c0d22029 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822258 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: John Plate <jplate@google.com>
Mohan Maiya c8ee13c7 2021-04-02T12:19:33 Vulkan: Fix a validation bug in glBeginTransformFeedback Add logic to check the program or the pipeline before erroring out when validating glBeginTransformFeedeback. Bug: angleproject:5557 Test: ProgramPipelineXFBTest31.VaryingIOBlockSeparableProgramWithXFB* Change-Id: I0df8a8d87b3632745bc91dc2673f2fac31c6cdb1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743440 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Jamie Madill fe4053ba 2021-04-13T13:08:40 infra: Add angle_mb_config.pyl. This will be used to set up gn args for standalone builds. We can then set the GN args source-side instead of in the recipe directly. Bug: angleproject:5114 Change-Id: I6fac6d13903951031a7299aea203f6b3e13c72bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819461 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 29dc2b6e 2021-04-13T09:32:30 infra: Move and check gn_isolate_map. In preparation for more source-side configuration. Also adds a presubmit check and some empty files to enable the presubmit to function. Bug: angleproject:5114 Change-Id: Id9a0cbe1e78949720be39c65efab73c1345d4f39 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819942 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi cc56e1aa 2021-04-09T23:35:07 Vulkan: Remove special output of structs and keep them in AST The code that separated out declaration of nameless structs from uniform variable declarations is generalized to separate out declaration of all structs from uniform variable declarations. As a result, a pass that outputs the struct types at the top of the shader is no longer necessary. The struct declarations are kept in the AST to be output to GLSL as they normally would when not used in conjunction with uniform variables. After this change, the Vulkan and Metal translators no longer intermix transformations and code generation; transformations are done first entirely in AST, and code generation is done at the end. Bug: angleproject:2461 Bug: angleproject:4889 Change-Id: Ieb4d3f7091845e50c3dc399603ab01182692521d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818153 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Geoff Lang 18c6d628 2021-03-09T13:46:13 GL: Support VAOs without native VAOs. Share the default VAO state between all frontend VAO when there is no native VAO support. Forcefully sync state every time a new frontend VAO is bound. Bug: angleproject:5577, chromium:1167179 Change-Id: Ieaedb5108ad28fc78e7e58b74495639c5246bb05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2665266 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang fe790824 2021-04-09T11:24:07 Add the jdk dep when building standalone for Android. Chrome started requiring this dep to 'gn gen' on Android so ANGLE needs it too. Bug: angleproject:5839 Change-Id: Ia8df8520975ed426667f2c59f0fd7761652b92ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818141 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Geoff Lang 065c2329 2021-04-08T11:59:43 Reland "Vulkan: Add features to modify sampling parameters" This reverts commit a51b57fa2dc73f8bc8acdf0b818cc0315fb23d75. Original change's description: > Revert "Vulkan: Add features to modify sampling parameters" > > Bug: b/167404532 > Change-Id: Iae19dfe165074e8c01216312bddd744c4fb504a4 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2510012 > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Tim Van Patten <timvp@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: b/167404532 Change-Id: I2c756b8eb0f61701ef6e33275e557bc199a4d3b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815259 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi c2d1a464 2021-04-09T16:53:30 Translator: Track nameless interface block field indices in type Fields of nameless interface blocks are stored as TVariables and referenced through a TIntermSymbols (unlike named blocks which use EOpIndexDirectInterfaceBlock with a constant field indices). With this change, the field index is stored in the variable's type which let's the TField of the TInterfaceBlock be directly accessible (and not need a search by name). This will be helpful in translation to SPIR-V as interface block members are accessed by field index. Bug: angleproject:4889 Change-Id: If3ab45b1e5f5f9576721dc52e2bdf1161882514f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818242 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 6ec55494 2021-04-08T22:02:50 Vulkan: Use AST transformation for gathering default uniforms ... instead of generating text. This will keep the tree in a consistent state, as previously the references to uniform values where to TVariable's whose declarations were removed. Bug: angleproject:2461 Bug: angleproject:4889 Change-Id: I2ef3787dede371514a5f495f4cc8fc67ea45f451 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815564 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Gert Wollny faa86bc9 2021-04-13T14:19:59 Capture/Replay: Serialize only a hash of the shader binary It doesn't make much sense to keep the actual values and it makes the diff needlessly large when the binaries differ. Bug: angleproject:5856 Change-Id: I55664d6cb60ef680669c1243c2eabcb67cd4db23 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822256 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 6d2f9cb4 2021-04-13T13:56:13 JsonSerializer: add method to store only a hash for vectors This can be used to make the Json comaprison less noisy. Bug: angleproject:5856 Change-Id: I57df41eed3926647aaf8bcf97a7aea050e1c3d51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822255 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 58eabfd7 2021-04-08T23:57:04 Translator: Validate consistent variable references Some transformations change variable declarations. This validation ensures that all references to said variables are appropriately replaced as well. Bug: angleproject:2733 Change-Id: I6c2873968eeed4cba66e70069f84eb69a1f77074 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818140 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
kmx.io     mail     discord kmxgit v0.4.0