kc3-lang/angle/infra

infra

Log

Author Commit Date CI Message
Cody Northrop 0d67a4fa 2021-11-18T20:12:34 infra: Increase gles1_conformance_tests timeout In anticipation of GLES1 ubershader updates that result in faster frame times, but more compiles. The GLES1 conformance tests iterate through every state and render one frame, which is slower when you link a new program for each. Bug: angleproject:6644 Change-Id: I70501ea38505428569ba518710ecb03ce198db18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292511 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com>
Jamie Madill 6168e303 2021-11-18T08:55:22 infra: Enable flaky retries on Mac end2end_tests. These tests are heavily flaking and causing CQ churn. Mark them as retriable until we can root cause the flakiness. Bug: angleproject:6570 Change-Id: I9886a655b88737acbe7ce728fa32573ac4d6145f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289104 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 9a36c3b6 2021-11-15T13:46:06 infra: Update NVIDIA to 1660 testing. Bug: angleproject:6694 Change-Id: I2580b53e45e633af98be757d9bb081461c06de95 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3283163 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill de5a290d 2021-11-16T15:29:31 infra: Increase sharding on SwANGLE trace tests. These tests were timing out in test infra. Bug: angleproject:6496 Change-Id: Idd9b36051e1d0327602fa148d7a8c7b44d918b30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285807 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 316dcb56 2021-10-06T09:31:49 Add SwANGLE Skia Gold testing. Required updating our system info helper to be able to retrieve SwiftShader device information. Bug: angleproject:6496 Change-Id: Ib38ea4da65d199433e17b87df2630c3fd77cb619 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3208646 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Vadim Shtayura bc2ca15c 2021-11-11T16:29:59 Declare "role/configs.validator" binding. It defines who is allowed to call LUCI Config validation API to validate this LUCI project's configs. This is usually done by presubmit jobs, and thus configs.validator role is assigned to try job task accounts. Previously this ACL was defined in the global "config-validation" group. It is deprecated and being replaced with per-project ACLs defined in per-project configs (like in this CL). There's still a global ACL to allow any googler to call the validation API in any LUCI project they are allowed to see. Thus the per-project binding applies only to service accounts (they are not googlers). Note that this CL was generated semi-automatically and reviewers are picked automatically based on OWNERS file. Bug: chromium:1068817 Change-Id: Iadd19a74e3b0bce330ee0d6fd29046ab03d5c2cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276460 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill bb6732a3 2021-11-02T10:10:52 infra: Add Linux UBSAN/TSAN configs. These are compile-only with this CL, and will start running tests in later CLs. Bug: angleproject:5795 Change-Id: I37b04df2bb4a97aa46545f50bf978dfde65983c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3258002 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill f7552844 2021-11-02T10:05:46 infra: Add ASAN tests to CQ. Bug: angleproject:5795 Change-Id: I316122990739053b28e205282b307a071d5997c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3258001 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 42c0207d 2021-11-11T13:01:18 infra: Remove remaining references to 'master'. These are all now replaced with 'main'. Bug: angleproject:6685 Change-Id: I36cb17625c44d06689f7debf004abd3dd016265b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276517 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill b570a844 2021-11-11T12:25:47 infra: Remove outdated "master" ref in CI config. This should let the CI console start running changes again. Bug: angleproject:6685 Change-Id: I2d172bd9a90b9772efeeaa9cadf0bc865b917e16 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276516 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 2a9e6e48 2021-11-01T15:56:54 infra: Add tests to ASAN configs. These add basic ANGLE tests with SwiftShader + ASAN. Bug: angleproject:5795 Change-Id: I92a51a44214ff0f442d4a1b2a0bc6ac2b8d3f4eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3254431 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill a9f24fa5 2021-11-08T12:21:25 infra: Switch ASAN to 64-bit on Windows. ASAN is not supported in 32-bits on Windows. Bug: angleproject:5795 Change-Id: Icabf31b8c9ad4d371217c9f4a288f909888eae61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3265532 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill 548e7a2f 2021-11-02T08:50:30 infra: Expose ASAN configs in try. This will allow us to manually add ASAN tryjobs to test before landing. Bug: angleproject:5795 Change-Id: I1085b64f2dcf09e20f470aded0d57befbe4fb084 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3257025 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 616dc268 2021-10-12T13:15:40 infra: Add ANGLE-side configuration for ASAN tests. The ASAN builders will start by running compile-only and only in CI. A follow-up change will enable sharded tests and CQ jobs. Bug: angleproject:5795 Change-Id: I2e761b7bdd2d7215db2210c4538b6cafc4d9069a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3254430 Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 6e832bfe 2021-10-27T07:01:21 Roll Chromium from b7a27dd8face to 6e4379b531a3 (441 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b7a27dd8face..6e4379b531a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0afcdef8ce..4703a8520d * buildtools/linux64: git_revision:693f9fb87e4febdd4299db9f73d8d2c958e63148..git_revision:79c6c1b1a24c46df5a773cc61604bb5051ca6cf4 * buildtools/mac: git_revision:693f9fb87e4febdd4299db9f73d8d2c958e63148..git_revision:79c6c1b1a24c46df5a773cc61604bb5051ca6cf4 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/9b8228b4a9..26b101897f * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/21acd3f622..bbd954d05f * buildtools/win: git_revision:693f9fb87e4febdd4299db9f73d8d2c958e63148..git_revision:79c6c1b1a24c46df5a773cc61604bb5051ca6cf4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cf2207e083..847533d764 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/3b235c7e7c..f59fdc4257 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b10243766b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/378395bfb5..480c91d40b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e193c0af0a..819fa9604c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3b242d6f87..b3ad7f71e0 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3ac732d74b..2ff429a7b7 No update to Clang. Bug: angleproject:2551 Tbr: timvp@google.com Change-Id: I4a8cd6a0f37374313ef2fe559f8e1fb8f23a9673 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3246537 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 5ab95ec3 2021-10-20T10:07:10 infra: In milo, split console into 'compile' and 'test'. This will provide an easier-to-read summary for wranglers because test failures will be grouped instead of spread out in between compile builders. Bug: angleproject:6496 Change-Id: I45e2f1a868d887de22133684aa0b4821ed4c8f84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3233900 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 0fb59c09 2021-10-18T08:25:26 infra: Remove old bot configs. This can be landed after the change to switch the CQ to the new configs. Bug: angleproject:6496 Change-Id: I3b6ec4697a2fa7a279e5a761ea1717f652af84a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3231835 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill e0de97cf 2021-10-18T08:29:50 infra: Remove SwANGLE bots from CQ. These configs are now included in win-tests and linux-tests. Bug: angleproject:6496 Change-Id: I1ab3961e74bde6672617e4494027da1ff490b352 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226302 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 7fea17b9 2021-10-19T11:08:26 infra: Add new configs to CQ. This leaves the old configs in place. We can't remove them until the CQ bots switch over. Bug: angleproject:6496 Change-Id: Id9ee70cfd65cd85a7525b42f08d78873f31a7cd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226301 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Weiwei Lin aa630727 2021-10-18T00:16:51 [milo] migrate to new bug_url_template The old way of specifying bug template is deprecated. R: geofflang, jmadill Bug: chromium:1218698 Change-Id: I1b3dc9b4ebb3bdcbd6a1f574209f30a8b27f129e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3230302 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0c7018a5 2021-10-12T13:43:20 infra: Update bot naming scheme. Old names: use config pairs when they can vary, e.g. android-arm-dbg android-arm64-rel linux-clang-dbg win-clang-x64-rel win-msvc-x86-dbg win-trace-rel New names: use config names when they differ from the the default test config for a system, and suffix with -compile and -test for compile-only and compile-and-test bots. For Android configs, we keep the full target arch. e.g. android-arm-dbg-compile android-arm64-test linux-dbg-compile win-test win-msvc-x86-dbg-compile win-trace The new naming scheme prioritizes having short names to avoid redundant or implicitly understood information. This should reduce the mental load when looking at a set of test results. This also adds SwiftShader win10-x64 configs so we can add these to the CI easily. Also the plan is to turn off the GCC configs for now. If we ever support GCC properly we can re- enable them. This CL adds the new configs to CI, then a following CL will add them to CQ and remove the old configs at the same time. Bug: angleproject:6496 Change-Id: I0ecdcd392c4d7067d6b180664f160ba7c048d16d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3219590 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi f3d5dac3 2021-08-23T17:25:15 Vulkan: SPIR-V Gen: Drop dependency to glslang The SPIR-V gen path is now made default. Compilation through glslang is still supported for debugging, and is enabled on the GLSL* end2end tests for smoke testing. On release builds, glslang is not supported. To test with glslang, add the following gn arg (only necessary if dcheck is disabled): angle_enable_spirv_gen_through_glslang = true Then enable the generateSPIRVThroughGlslang feature. This can be done by setting an environment variable: ANGLE_FEATURE_OVERRIDES_ENABLED=generateSPIRVThroughGlslang ./angle_deqp_gles2_tests Binary size saving: - 1.3MB on Linux (SPIR-V gen itself: 240KB) - 730KB on Android (SPIR-V gen itself: 140KB) Perf tests: - LinkProgramBenchmark.Run/vulkan_compile_single_thread * Through glslang: truncated mean: 1287033.36 * Direct SPIR-V Gen: truncated mean: 244495.91 (~80% reduction) - LinkProgramBenchmark.Run/vulkan_compile_multi_thread * Through glslang: truncated mean: 4565894.83 * Direct SPIR-V Gen: truncated mean: 1158164.10 (~75% reduction) Bug: angleproject:4889 Bug: angleproject:6210 Change-Id: I486342702977c8114e90073b97183aba115a8b2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3115140 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 4b056a17 2021-10-08T11:15:25 infra: Remove android-angle-try from CQ. The dEQP GLES / EGL tests on the Nexus 5x are not a configuration we intend to ship. The 5x is over 5 years old and has been discontinued without updates. Because it costs us resources and developer time to maintain these configs, and we still have WebGL testing of this device, remove the native dEQP tests from this config. Also includes a fix to the lucicfg presubmit on Windows. Bug: angleproject:6527 Change-Id: I70bbd3ebdafc63bfd7572b79abcedb711acb4441 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3212892 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill f13731ae 2021-10-06T10:04:24 Enable dEQP EGL + GLES 2/3 tests on Pixel 4. This is in preparation for removing these tests from the N5X. Bug: angleproject:6527 Change-Id: Ib44f876db47845935efd68a1727964834a675cbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3208746 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Weiwei Lin ce63bc1f 2021-10-06T07:37:24 [milo] update test presentation config to group by test_suite R: jmadill,ynovikov Bug: chromium:1249703 Change-Id: I37ea518a61df324750c7e8d6f18f0446b6316324 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3207826 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 69a91b3d 2021-10-04T08:59:55 Add SwANGLE test configs to Linux and Win. These will be used to replace SwANGLE tests on the CQ. Bug: angleproject:6496 Change-Id: Id8d021067ec05e226daac5c1d5992977ef295efb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3199993 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Ian Elliott 7c1622ca 2021-10-01T16:42:29 Fix links with Handling Test Failures CL After landing https://chromium-review.googlesource.com/c/angle/angle/+/3192171, I clicked on all of the new links and found a few problems, which this CL fixes. Bug: angleproject:6462 Change-Id: I57a440fa8d8c3554c4ae05222e9a174c0e3a3314 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3200286 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Ian Elliott 61dc7698 2021-09-28T15:07:20 Add documentation about suppressing test failures Bug: angleproject:6462 Change-Id: Ia46f58ea66ec3e2b50fca91a645fe0e8969689d0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3192171 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0004ecc2 2021-09-22T13:39:55 Write GL info to test artifact in end2end_tests. These will show up as glinfo.json in the "cas outputs" of the shard that runs these tests. We currently have information for Pixel 4, NVIDIA and Intel Win/Linux, and SwiftShader Windows. GLES 1.x extensions are treated separately. Some WebGL/Mac-only/D3D-only extensions show as unsupported anywhere. In order to capture artifacts on Android, we use a render test output parameter. Bug: angleproject:6379 Change-Id: I560b219b5a586cdbb68d272090f38eedc76aba20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3176780 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Weiwei Lin 8d1e74ab 2021-09-30T00:53:39 [milo] update test presentation config to show GPU column So it will be easier for users to distinguish tests run on different GPUs. R: jmadill,ynovikov BUG: chromium:1249703 Change-Id: I393d305c963f5fc654c9c32fc86cda6c7f019086 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3195351 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 17b50dbc 2021-09-22T23:35:45 Roll Chromium from f50ae42daa8b to 0ca662a00a61 (158 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f50ae42daa8b..0ca662a00a61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f34057a8e4..d4c1fd4eeb * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/48418f3dd7..ba539c18fc * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..25814bb53d * third_party/turbine: n2quuVAecebwosy5EPRjDGSO5EQU94aFRBg_EdrYtpsC..EIJ2nS3aoQlV-cKpmxr4hNR4E1Qs82brcidjG4A1I5QC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/126012e8f7..2a0d7f0fb7 No update to Clang. Bug: None Tbr: geofflang@google.com,ynovikov@google.com Change-Id: Iadccb0fdf49e99b68e18977a3b3c6ae39ffe1424 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3177641 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov a58749ed 2021-09-22T22:50:10 Revert "Add standalone experimental Mac Intel and AMD bots" This reverts commit a5bbfe2afe29ec53eccf22d33cee200be25de673. Reason for revert: qualification complete Original change's description: > Add standalone experimental Mac Intel and AMD bots > > For qualifying Mac OS 11 on Mac Retina AMD and Mac Mini 8,1 > > Bug: chromium:1241597, chromium:1128540 > Change-Id: I753b504f5910541f5d3f244d117d369937a06d38 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3150752 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: chromium:1241597, chromium:1128540 Change-Id: I4eb71219783651c0e63188e2c94c6ee286625430 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3177332 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill c3e0eafa 2021-09-22T13:35:04 Revert "Perf Tests: Split samples into sub-tests on desktop." This reverts commit 90c981dafc06d6bc0696749dface1337e37784d2. Reason for revert: Causing timeouts on perf bots. Original change's description: > Perf Tests: Split samples into sub-tests on desktop. > > This adds an option to the perf test runner to split each sample of > each test into a sub-test. The sub-tests then are split among the > shards like ordinary tests, and distributed across machines. The > intent is that running on different machines will reduce inter-build > variance because of differences between test machines. > > This sampling change is only added to desktop (Linux/Win) because > Android device variance seems to be lower. > > Bug: angleproject:6090 > Change-Id: I4046a012727baa8a0f2595de2349cc34257691f9 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3152752 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Bug: angleproject:6090 Change-Id: I92bffb98999f35274ec31a3b7567d87453feff94 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3174274 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 90c981da 2021-09-10T11:04:19 Perf Tests: Split samples into sub-tests on desktop. This adds an option to the perf test runner to split each sample of each test into a sub-test. The sub-tests then are split among the shards like ordinary tests, and distributed across machines. The intent is that running on different machines will reduce inter-build variance because of differences between test machines. This sampling change is only added to desktop (Linux/Win) because Android device variance seems to be lower. Bug: angleproject:6090 Change-Id: I4046a012727baa8a0f2595de2349cc34257691f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3152752 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov a5bbfe2a 2021-09-03T19:24:29 Add standalone experimental Mac Intel and AMD bots For qualifying Mac OS 11 on Mac Retina AMD and Mac Mini 8,1 Bug: chromium:1241597, chromium:1128540 Change-Id: I753b504f5910541f5d3f244d117d369937a06d38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3150752 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill e1bc8de3 2021-09-08T07:59:37 Change links from 'master' to 'main' branch. Bug: chromium:1226949 Change-Id: Ie7b28b2fa094cf0c0a407968d681e580519cbb88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3148210 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 6370dec2 2021-09-03T19:29:57 Fix doc to refer to a standalone Mac bot Instead of a decommissioned chromium.angle Mac bot Bug: chromium:1246552 Change-Id: I84d5b35cbebbcb91218c6d2d4aa008728e7ccc0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3141682 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Kenneth Russell c90a6dca 2021-08-26T21:54:54 Deduplicate autoroller docs. Leave them centralized in ANGLEWrangling.md, link to them from BranchingAndRolling.md, and add the Chromium-into-ANGLE autoroller. Bug: angleproject:6323 Change-Id: I913954b92dbe3545320e662de122daf26140d425 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3124341 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Jamie Madill caef7c53 2021-08-26T18:24:18 infra: Disable perf tests on Win/Intel. These were killing the bots for some reason. Disable them until we can find the root cause. Bug: angleproject:6090 Bug: angleproject:6332 Change-Id: I48b633118f098570e371ea81d9e512e35ab04cd6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3123169 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill e30dd478 2021-08-20T17:10:51 infra: Update Milo perf short names. Use the name of the Android device or GPU manufacturer. Bug: angleproject:6090 Change-Id: I2e26586578c51f9a714fed23586854bb14030242 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3111028 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 6a956ef9 2021-08-20T17:04:01 infra: Update angle_mb_config.pyl with new perf names. Was missing from the prior CL. Bug: angleproject:6090 Change-Id: I454605fad48690a2d84a2fe3a436140931e2cb9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3111027 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 6c1ad60b 2021-08-20T09:30:47 infra: Make perf builders GPU-config-specific. Separating only by OS makes the perf dashboard uploads land in the same bucket for NVIDIA and Intel results. The two are intermingled on the dashboards. Split this by separating the GPU configs into their own builders. Must land before http://crrev.com/c/3110765 Bug: angleproject:6090 Change-Id: Icee3b19d3462977b4ec86bfe08d7c44431426d24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3110745 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 162847ca 2021-08-17T13:26:06 infra: Increase sharding in CI angle_perftests. The test shards right now are taking 20-30+ minutes. Sometimes they time out on the test infra. Increase sharding because the overhead from sharding is very small relative to the test time used by shards. Bug: angleproject:6090 Change-Id: I45c7bf077da7242743559d68b45d45dbea18355e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3100586 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 2ae998ac 2021-08-12T16:24:11 Enable ResultDB on standalone Try builders Including the presubmit builder. crrev.com/c/3087640 missed Try builders and only enabled ResultDB on CI. Bug: angleproject:6275 Change-Id: Ia645205973008c535a2334b3b78b0d95a791c95d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3092465 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov e6d9ef98 2021-08-12T14:53:07 Enable ResultDB adapter for standalone bots In crrev.com/c/3087640 'has_native_resultdb_integration' was erroneosly enabled on ANGLE standalone bots. Disable it, so that the Chromium recipe would enable result adapter from JSON to ResultDB format. Bug: angleproject:6275 Change-Id: I1f94a8f2cbd1159be89bc1413669ed90e249c5b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3092045 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov ac2d1434 2021-08-11T15:48:57 Enable resultdb for ANGLE standalone builders Otherwise, they fail with https://crrev.com/c/3088213, e.g. https://ci.chromium.org/ui/p/angle/builders/try/linux-clang-rel/23678/overview Doesn't actually upload to BigQuery yet, pending declaring the tables. Bug: chromium:1135718 Change-Id: Ia429260e2f53f836279383aa84ca3e8e58c3392b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3087640 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill d25c9d7f 2021-07-07T12:15:12 Add perf tests runner script. This script will be responsible for running the perf tests multiple times to try and stabilize measurements. We'll use it on the bots instead of just running the perf tests directly. Because the script invokes the binary multiple times, this slows down execution. Most significantly on Android, where we now need to use 20 shards, up from 6. Also marks one test as flaky on OpenGL. Bug: angleproject:6090 Change-Id: I5280035cb0bdb290a68dc6961a384eaf4b40dd4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3011422 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll 85e49053 2021-08-02T07:50:32 Roll Chromium from 7ad7eb435b84 to c96bed01e3be (1394 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7ad7eb435b84..c96bed01e3be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/96a4da9412..9ee6ac6515 * buildtools/linux64: git_revision:c0a2d23c21e87f27f5af3e5dc2a99f2ef3480b9e..git_revision:eea3906f0e2a8d3622080127d2005ff214d51383 * buildtools/mac: git_revision:c0a2d23c21e87f27f5af3e5dc2a99f2ef3480b9e..git_revision:eea3906f0e2a8d3622080127d2005ff214d51383 * buildtools/win: git_revision:c0a2d23c21e87f27f5af3e5dc2a99f2ef3480b9e..git_revision:eea3906f0e2a8d3622080127d2005ff214d51383 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/88e2d8b080..8872b6cf61 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/368be24f93..ae11d2854e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4505381167 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/2229323ff7..9ce4c7a678 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/dfbc590f58..6075f1fabd * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2a8bb1ca80..d0097bccba * tools/luci-go: git_revision:75ff299b9adf969190cafebe902255856a346f0b..git_revision:db421da12bad8e57f97ee45b24147e34ec882007 * tools/luci-go: git_revision:75ff299b9adf969190cafebe902255856a346f0b..git_revision:db421da12bad8e57f97ee45b24147e34ec882007 * tools/luci-go: git_revision:75ff299b9adf969190cafebe902255856a346f0b..git_revision:db421da12bad8e57f97ee45b24147e34ec882007 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ef691997d9..56a35530fc * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b210baf513..9c1129d333 Clang version changed llvmorg-13-init-16514-gb1777b04:llvmorg-13-init-15561-gf98ed74f Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/2a8bb1ca80b166cb11a81ffc35e8f374af240e04..d0097bccbaab2f439b83ba93c6634ba91ca882fb/scripts/update.py Bug: None Tbr: geofflang@google.com Change-Id: I2dd100192c502e329200d8c94bd013fecbbece05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3067054 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi b751b185 2021-07-22T22:10:22 infra: Enable gles3.2 deqp tests with direct SPIR-V generation Enabled on Linux/Nvidia, Windows/Nvidia and Pixel4. Bug: angleproject:4889 Change-Id: I3050ed53b48cc114c940486871910a3b9c5adea5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3047383 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 630077c5 2021-07-22T22:08:21 infra: Enable gles3.1 deqp tests with direct SPIR-V generation Enabled on Linux/Nvidia, Windows/Nvidia and Pixel4. Bug: angleproject:4889 Change-Id: Id82c909e368cdc189aea2e44f6371a27d8232e37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3047382 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 4ff80bb5 2021-07-22T21:52:35 infra: Enable gles3 deqp tests with direct SPIR-V generation Enabled on Linux/Nvidia, Windows/Nvidia and Pixel4. Bug: angleproject:4889 Change-Id: I2462b7fa7801b766f4359103a5253209b7fded28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3047381 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 02c5cdbd 2021-07-21T23:08:17 infra: Enable gles2 deqp tests with direct SPIR-V generation Enabled on Linux/Nvidia, Windows/Nvidia and Pixel4. Bug: angleproject:4889 Change-Id: I50c5e31097bd7e1539caf7b229a249cbfa62b93d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3042557 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 91b35c90 2021-06-30T09:28:17 infra: Add perf results processing script. This script is a modified version of the Chromium script: https://chromium.googlesource.com/chromium/src/+/main/tools/perf/process_perf_results.py The primary change is to add additional build info to the histogram set before upload. This additional info isn't available to the test harness and is required for the perf dashboard upload. We can also use this as a basis for uploading to the Skia perf dashboard. Test: led launch Bug: angleproject:6090 Change-Id: Ie439ed34a24ce66f4b60b947f221e4cb96cf7d25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2997002 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 2c60b88a 2021-07-23T09:46:37 Make the trybot exclusion filter a proper regex. Bug: angleproject:6212 Change-Id: I20ca648675a5dd4773d1c3e44b251388318197f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3048854 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill aed52e67 2021-07-23T08:43:17 Set dcheck_always_on on every ANGLE builder. This GN argument is necessary because some build components reference it directly. Letting it be specified implicitly will caused undesired side-effects. Bug: chromium:1227171 Change-Id: Ib12cc3add58ecc8ae0360f816d30587158d756c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3048850 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 2b86e2d6 2021-07-19T10:30:57 GN: Update dcheck/assert conditions. In preparation for a Chromium change that makes dchecks enabled by default in Release builds, we'll keep ASSERT disabled in Release by default. We add a new flag 'angle_assert_always_on' for controlling ANGLE ASSERT behaviour. Also slightly refactors the direct SPIR-V generation GN. Chromium CL: https://crrev.com/c/2893204 Bug: chromium:1225701 Change-Id: I01a6def28d7c21e771e9800889a6b9c274972de2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035447 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 783c2f93 2021-07-13T08:27:44 Roll Chromium from 7d1a6713a379 to 624f8c7a15ff (526 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7d1a6713a379..624f8c7a15ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/70f58488ed..9c63d2e3b0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e065358b5a..d749d1b98b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3345f09ed6 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/199485df6c..f376b41126 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3fa819890a..aca9f71bde * tools/luci-go: git_revision:2f836b4882d2fa8c7a44c8ac8881c3a17fad6a86..git_revision:2ac8bd9cbc20824bb04a39b0f1b77178ace930b3 * tools/luci-go: git_revision:2f836b4882d2fa8c7a44c8ac8881c3a17fad6a86..git_revision:2ac8bd9cbc20824bb04a39b0f1b77178ace930b3 * tools/luci-go: git_revision:2f836b4882d2fa8c7a44c8ac8881c3a17fad6a86..git_revision:2ac8bd9cbc20824bb04a39b0f1b77178ace930b3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/783612b47d..1820a3adb0 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/511dbaffd9..6dad62e2eb * tools/skia_goldctl/linux: tu1vY2W9BQ6Wx0o3zk5oqBwnr5rfFQGiaztbTpGiRNgC..R0Jd4IlcndZlI5C9Pejy7DqtmVEQT8Sc6Ye09MGyFxYC * tools/skia_goldctl/mac: DPVSayDIq4ga78XaXXcfTzeTE2v33yM8z1w-eaD-ZuQC..5NoUEq08DuYUlQWnf2yj6rQvBtlMvWiDqfuUuE5nJFIC * tools/skia_goldctl/win: HMJwTrgrkRmSqDuyQtWly6YxYSHJXsM6zQJFLkojAVwC..M2_R9AXWaN0xmm6nz_nRzKlhpzzOp3P9EUxNaLZ5owMC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ie14d842df225cfc1f60d087386147904a8120ae4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3023670 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Takuto Ikuta d91af7b8 2021-07-06T12:17:33 infra/config: remove unused isolated property angle is migrated to RBE-CAS from isolate. Bug: chromium:1224266 Change-Id: Id2ca778edf6b34f5241da0fbfcd86b43941f83b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3007600 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill ec8cdd5d 2021-06-28T15:59:38 infra: Add perf tests to Android/Linux/Mac. These use the same config as the previous perf bots. Bug: angleproject:6090 Change-Id: I0ed4bc32cdc5b27f1fbd00fded1fa8d2ccbe45d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993458 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 72c8d46d 2021-06-29T08:05:11 infra: Build traces on perf bots. This is necessary to ensure they run the trace tests in perf. Bug: angleproject:6090 Change-Id: Ib96418c4371f700dbbd54933241b1b88912f9938 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2991903 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 8b24e2a4 2021-06-25T13:51:19 infra: Add perf mb configs. This will set up the GN args for the perf builders. Bug: angleproject:6090 Change-Id: I3c00a5b78932ae41199953a46c525b435b566d12 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2989669 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 8b4f6e6d 2021-06-23T09:06:59 infra: Add perf configs. Adds Win/Linux/Android configs. Bug: angleproject:6090 Change-Id: Ie80a12a16997aab08e9dbba0cc0a9b14414fc8f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988793 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov cc280ff3 2021-06-25T11:07:45 Remove obsolete Android bots from CQ android-angle-chromium-try + android-angle-try replace android_angle_deqp_rel_ng + android_angle_rel_ng Bug: angleproject:4483 Change-Id: I96d51ee610ca7b025e1976d0076409c4990836c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2988792 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill ce22ad10 2021-06-18T15:23:11 infra: Add symbol_level=1 in Release. This should enable better crash file/line information. Bug: angleproject:6070 Change-Id: I54280461160f2ac6404dbd4b88abdcfd31f3814e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2971956 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Ian Elliott f89f244d 2021-06-16T13:03:20 Doc: Add component info for filing Chromium bugs Bug: None Change-Id: I7b8517e2312174a2e2b9221b7c99425978406024 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2966011 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
Yuly Novikov c7c3cac0 2021-06-09T15:05:17 Add Android chromium.angle bots to CQ Bug: angleproject:4483 Change-Id: I5a2d76bb9f5183752cbcd6f9381c4aef83edecd7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2950267 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 166dd0c7 2021-06-10T16:09:01 Roll chromium_revision 6c5859c895..399855f4bb (890175:891326) Manual changes: 1. Fix generate_test_spec_json.py to correctly handle ADDITIONAL_MIXINS Needed after angle_skia_gold_test mixin removed from Chromium in crrev.com/890333 2. Copy third_party/logdog from Chromium Needed after crrev.com/890539 in order to create isolates on Android and for tools/perf/process_perf_results.py Change log: https://chromium.googlesource.com/chromium/src/+log/6c5859c895..399855f4bb Full diff: https://chromium.googlesource.com/chromium/src/+/6c5859c895..399855f4bb Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8870cb4120..2192a63c23 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c793cca886..9d8449e380 * buildtools/linux64: git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810..git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa * buildtools/mac: git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810..git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/7e3b76855b..2c53623d59 * buildtools/win: git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810..git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a62f8260df..ab567bcc84 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/7949d87093..bd17c406ba * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/887e8d9009..fa47598982 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/1cfc90728e..816daa2545 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..17cf72ca75 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b508ecd932..6d099d543d * third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/19f3fad68d..e9be5fd6d7 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/82f8803671..f4241bd0f2 * third_party/turbine: _iPtB_ThhxlMOt2TsYqVppwriEEn0mp-NUNRwDwYLUAC..Om6yIEXgJxuqghErK29h9RcMH6VaymMbxwScwXmcN6EC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/09481f56be..fd14318cc9 * tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:725192cc79f07ea946e10a64baac06625c206968 * tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:725192cc79f07ea946e10a64baac06625c206968 * tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:725192cc79f07ea946e10a64baac06625c206968 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/94630dfc19..12c8fa872b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5c84710692..2e6477d751 DEPS diff: https://chromium.googlesource.com/chromium/src/+/6c5859c895..399855f4bb/DEPS Clang version changed llvmorg-13-init-11999-g50c0aaed:llvmorg-13-init-12491-g055770d5 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/09481f56be7b1bbaf5a466be5d81691902825fcf..fd14318cc948b67e5ec8a0f2f7563142ccd6dac2/scripts/update.py Bug: angleproject:4483, angleproject:6037 Change-Id: I9035126bce55642d4dfce54eeace85093bdd1782 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2954241 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill c778f93f 2021-06-07T13:10:15 infra: Reduce sharding on GLES3 GL/Metal tests. Bug: None Change-Id: I56593374d027db20a5ed0ebf09ca2210e219f244 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2945431 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 3bc28a27 2021-06-07T13:03:39 infra: Add flaky retries to Metal GLES 3 tests. These have been somewhat flaky on the waterfall. Bug: angleproject:6019 Change-Id: I4d76411ab54ad5fbfb9c49775c44a12b99def846 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2945430 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill d99864c0 2021-06-07T12:48:01 Gold Tests: Fix flaky test handling. Indead of just retrying the batch, retry individual tests. This should correctly handle the Intel flake pattern. Bug: angleproject:5415 Change-Id: I029c2514ff8e7a45184c5c105bf2d0350171da29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2940049 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill f03f7bdb 2021-06-07T12:30:29 infra: Don't run trace tests in perf smoke tests. These test were already being run more safely in the gold tests step. Bug: angleproject:5977 Change-Id: I4fb1062926fcda19384835723555d0fab0b42aae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939469 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 2917ab34 2021-06-07T11:41:54 infra: Override Gold mixin. This mixin is being removed from the Chromium version of the mixins. Therefore we have to move it into the additional mixins option of the generator. Bug: angleproject:6037 Change-Id: I605b7cbf35d6282754bf5fb26246e32b2edcea10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939466 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll a14a806c 2021-06-04T07:00:43 Roll Chromium from b078d3ef5de8 to 5ffd2ab3bece (403 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b078d3ef5de8..5ffd2ab3bece If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/20ee3d5c60..bf4ecd926c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/cd7b8c0c22..eb65cc3594 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b97a23bcf3..f39abc2692 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/bb99706b87..baaf1482ba * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..712eb08096 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c8f63d390c..9705687c25 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/19eadef5e7..af7a363dfe * tools/luci-go: git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e..git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0 * tools/luci-go: git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e..git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0 * tools/luci-go: git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e..git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0 * tools/skia_goldctl/linux: SIbSqtgKfmhBASeojfVyHGkIx2ZItagJYLeJt9yef1oC..fVbmAq5SyEKlNV_cPvOrlJbBRmDAWApv309sIMdbgq8C * tools/skia_goldctl/mac: WB42GE3e_7-dR5RnBBCICQtMkfpOoJvlT9tMG_6Fj1UC..SGAjTHEDDOpAgPQYJcSEmMh4E6afvlKQKzBjwSTf5dwC * tools/skia_goldctl/win: BL1QYX6LBgah6_XEB3KHs9jZiFQtq2z8PUZRswCFvN8C..hySBvc3hf9NRFmfS2oG52F9ZzLpvX9bFuyybtZ92CNAC Clang version changed llvmorg-13-init-10392-gd3676d4b:llvmorg-13-init-11649-g4d788fb8 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/19eadef5e7825c6a90cb19c601ca26f889502856..af7a363dfec994581ed076c5023f110e079459f9/scripts/update.py Bug: None Tbr: ynovikov@google.com Change-Id: I21b2bbea54c6f43c1c7c7ab540af8eee345d7c41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939486 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 71584e36 2021-05-27T11:50:47 Tests: Disable trace compilation for MSVC and GCC New traces are hitting string literal limits with MSVC. Since we don't use MSVC or GCC for trace development or testing, this CL disables trace compilation for non-clang setups. Bug: b/181794064 Bug: angleproject:6009 Change-Id: I0377792a049153a5505ecda4346a3cec57c12e9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2922682 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill 163f6ac0 2021-05-26T10:57:18 Gold Tests: Add batching. This should speed up test runs on Android, which are currently much slower than the other platforms. Bug: angleproject:5966 Change-Id: I57890522b64d1d195ea0be56b4f68b6d54192d64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2919888 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 17c45b65 2021-05-25T10:06:47 infra: Shard restricted_trace_gold_tests. Reduces shard time from 50+ min to <10 min per shard. Bug: angleproject:5966 Change-Id: Ia230d71a66ac9a273a10e0389cc04d8c5737bc4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2915566 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill cf243705 2021-05-25T09:40:39 infra: Remove Pixel 2 (android_vk) tests from CQ. These tests are now fully running on the Pixel 4. Bug: angleproject:5941 Change-Id: Ic0bb094c917226867c3b34ede19986e95ce69b7f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2915565 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill fad9053f 2021-05-20T15:52:38 infra: Add isolated script tests to Pixel 4. This includes angle_perftests and angle_restricted_trace_gold_tests. Bug: angleproject:5941 Change-Id: I6f24d2c2752086ae6f7abba26880070c4a4f0472 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2911034 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill c71fbc16 2021-05-19T12:47:30 infra: Add dEQP tests to the Pixel 4. Also updates expectations. For simplicity we use SKIP everywhere and specify each skipped test individually instead of using wildcards. Bug: angleproject:5941 Change-Id: If2cb85b06ecd250222dbf1376d99392ad10b71aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2896172 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 328a5c89 2021-05-18T12:13:23 infra: Add tests to Android Pixel 4 bot. Only angle_end2end_tests and angle_unittests to start. Also adds test expectations for the Pixel 4 end2end_tests. Patch Series: 1. http://crrev.com/c/2885381 2. http://crrev.com/c/2885346 3. http://crrev.com/c/2885383 4. This CL Bug: angleproject:5941 Bug: angleproject:5946 Bug: angleproject:5947 Bug: angleproject:5981 Change-Id: Iaaea0b427513804575d0ad7773a81379ea932eb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885384 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll cf1064e6 2021-05-12T07:01:02 Roll Chromium from fff9d6fb8ddf to 3fb708290557 (495 revisions) https://chromium.googlesource.com/chromium/src.git/+log/fff9d6fb8ddf..3fb708290557 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4ff4105cd8..129bd6c0c0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/504fae9f10..43828a290e * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/93eae7d9dc..371f2bea4f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..302ca09b2d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cb17bc6028..6e5b0a5c45 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/5243354177..66e0a5d62b * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/618ddecd59..c3edbeed8a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e76c8f17cf..53a9334ffe * tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1 * tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1 * tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/df10bb0bf8..ac77520e0e * tools/skia_goldctl/mac: 5o7ziB6qRrSdtYJwKop8-5OFmvVQcxuNkGY1DRYggMsC..qwctaMZfXlU0u7OsbxWgOY_sBjsUYhlqwjJRbAXX3oYC Clang version changed llvmorg-13-init-7296-ga749bd76:llvmorg-13-init-9302-g897d7bce Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/e76c8f17cf2833813d671674cd89f01f3a21e851..53a9334ffea6aa748ff6c1ce8a46e71a90e7bc9f/scripts/update.py Bug: None Tbr: timvp@google.com Change-Id: Iff9b5446b67a948eeb60e1aa7aaacf0725714c05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2891629 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill cd535d2c 2021-05-11T13:13:55 infra: Switch Android ARM64 bots to compile-and-test. This will start to trigger tests on the Pixel 4 64-bit bots. Patch Series: 1. http://crrev.com/c/2885381 2. http://crrev.com/c/2885346 3. This CL 4. http://crrev.com/c/2885384 Bug: angleproject:5941 Change-Id: Ib76fd27d0814896522aad84443f52b7f47566e85 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885383 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 6e3c5321 2021-05-11T12:17:17 infra: Remove old TODO. Bug: angleproject:5114 Change-Id: I3b7255cc06bffd177f0b5ee8cad12bf2aad3089e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885382 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 930db294 2021-05-10T19:19:31 infra: Add Android swarming spec placeholder. These will trigger tests on the Pixel 4 in standalone. For now we do not specify any tests. Patch Series: 1. This CL 2. http://crrev.com/c/2885346 3. http://crrev.com/c/2885383 4. http://crrev.com/c/2885384 Bug: angleproject:5941 Change-Id: Iad1bc27c316724b244fbfbf694f6e83fdf5c0507 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885381 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 91429bb1 2021-05-04T18:13:39 infra: Remove duplicated trybots from the CQ. Removes duplicate Linux, Win and Mac testing. These are superceded by the standalone bots now. Android is still entirely Chromium-based. Bug: angleproject:5114 Change-Id: I745758547b2eaa5f82779b11e7f3a8512c3cdd94 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2872072 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill e61909f6 2021-05-06T15:12:08 infra: Re-enable swarming tests. Changes since the revert: - Include runtime_deps: http://crrev.com/c/2878093 - Add missing perf scripts: http://crrev.com/c/2877011 - Include build_properties: http://crrev.com/c/2878373 Bug: angleproject:5114 Change-Id: If7d1e5693c4ade72d3f45f5d60635cb27de7599e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877012 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 1572c372 2021-05-06T09:55:30 infra: Temporarily disable all swarming tests. There seem to be some unusal failures on CI. Maybe Try as well. Bug: angleproject:5114 Change-Id: Ia681d6fdb8575b851dd526c1ab9463ad047735c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875767 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill c75969e1 2021-05-06T13:37:54 Revert "Temporarily remove standalone tester bots from CQ." This reverts commit 8f26346b53d9f818996af8da1421af89cf69caaa. Reason for revert: Should be fixed by updated exclusion spec. Original change's description: > Temporarily remove standalone tester bots from CQ. > > Due to RECIPE CRASH, e.g. > https://ci.chromium.org/ui/p/angle/builders/try/linux-clang-rel/21245/overview > > No-try: true > Bug: angleproject:5114 > Change-Id: I42f76fb370ee5423430955643bffb8c2204fa25f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875717 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: angleproject:5114 Change-Id: I781a5a409a9ede005feaf0f3d7bcedac31eaa036 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876986 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill aa19de17 2021-05-06T09:32:07 infra: Fix exclusion spec JSON. The extra comma caused the CQ to fail reading the file. Bug: angleproject:5114 Change-Id: I5d36f1ae7c4dc5ebcb5599d5cd37471ee4085990 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876985 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 8f26346b 2021-05-05T22:15:34 Temporarily remove standalone tester bots from CQ. Due to RECIPE CRASH, e.g. https://ci.chromium.org/ui/p/angle/builders/try/linux-clang-rel/21245/overview No-try: true Bug: angleproject:5114 Change-Id: I42f76fb370ee5423430955643bffb8c2204fa25f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875717 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 0fb204bd 2021-05-05T17:55:37 infra: Exclude infra/specs from analyze. This will force any changes to the infra/specs folder to trigger a full set of tests on a builder. Bug: angleproject:5114 Change-Id: Ie640b52dd7f12163d0c91843d80dbab7f33209d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875356 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill db670c82 2021-05-05T17:12:58 infra: Enable dcheck_always_on in Release. This will assure that ANGLE ASSERT macros work in Release. Bug: angleproject:5114 Change-Id: I0fe6b83592ac3ff3462e55b8a73a11c8f114a4a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875355 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 167480cc 2021-05-05T17:05:55 infra: Switch CI to use component builds everywhere. This makes the build the same as the Chromium-based configuration. This also works around a problem with the Mac bots where the shader cache workaround isn't operational in non-component builds. Bug: angleproject:5114 Bug: angleproject:5928 Change-Id: Ib466942f4a69e1ba3e61e078c84d74d0b54bb396 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875354 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 18c9aa0d 2021-04-29T15:25:32 Run test spec update as part of codegen. Test specs now will be updated when the Chromium build files change. It will be automatically included as part of the Chromium->ANGLE roll. Bug: angleproject:5114 Change-Id: If99c2a20033d417a5999295f425a3bb203f5da3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2860962 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 167a4b6d 2021-05-05T13:42:44 infra: Add Linux isolated scripts to specs. We were missing the perftests and Gold tests from Linux Intel/NV. Bug: angleproject:5114 Change-Id: I1cfc0963b3890c621f0646bb5879e47ea6d336a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2873457 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Andrii Shyshkalov ab3b50bc 2021-05-03T21:17:14 [infra][realms] upgrade to LUCI security realms in all Angle builds. To be landed after ~1 day at 25% if all is well. Change-Id: I106add7cc9103bde8d77a1c61438ad0fcb54a7b3 Bug: chromium:1204972 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867636 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 83a1a385 2021-05-03T12:42:05 infra: Add trybot_analyze_config. This file is used to specify ignores and excludes for analyze. Initially only contains DEPS. Whenever a file in exclusions is changed, we'll run the entire CQ instead of only the affected tests. Bug: angleproject:5114 Change-Id: Ie7328604f5ee56288f992710d5c3dbc559e6d9a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867886 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Andrii Shyshkalov dd4564ca 2021-05-03T17:36:28 [infra][realms] bump usage to 25% of all builds. Change-Id: I106add7749103bde8d77a1c61438ad0fcb54a7b3 Bug: chromium:1204972 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867633 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Andrii Shyshkalov 03a9bf1e 2021-05-03T17:14:19 [infra] use realms on 5% of Angle builds. All swarming tasks triggered from realm-enabled build will be realm-enabled, too. This CL is safe to revert in case of problems. The problems, if any, should not affect CQ badly due to retries, but on CI they'd probably manifest as purple builds that won't be retried without human involvement or new Git commit. Change-Id: I106a587749103bde8d77a1c61438ad0fcb54a7b3 Bug: chromium:1204972 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867083 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Andrii Shyshkalov 32ed5069 2021-05-03T17:08:02 infra: init LUCI Realms config for Angle. This doesn't yet have any effect on Angle builds/tasks, but allows to associate Angle pools with the Realms config in https://crrev.com/i/3802849 Change-Id: Id756c14e7e181cc1820cee735668949bf9567d0c Bug: chromium:1204972 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867082 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0