tools/ubsan


Log

Author Commit Date CI Message
Hans Wennborg 7ea03db1 2025-01-17T08:11:45 Revert "Suppress false-positive UBSan falures in rsgExpression.cpp" This reverts commit 49e7801b90f8820cc4aec188a2f001703acf2c29. Reason for revert: The UBSan false-positive was fixed by a subsequent Clang roll, see bug. Original change's description: > Suppress false-positive UBSan falures in rsgExpression.cpp > > A recent Clang roll introduced false-positives like > > runtime error: > load of address 0x7f9c4f3ae6c0 with insufficient space for an object > of type 'const IsConversionOkFunc' > (aka 'bool (*const)(ConstValueRangeAccess)') > > Suppress them until a fixed version of Clang has been rolled in. > > Bug: chromium:388039125 > Change-Id: I0823e52bb892feac519b123ae66716c3dc96f6b2 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6149452 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: chromium:388039125 Change-Id: Ib8884c9a112e454f4fbb5e964d0192501e61c239 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6179805 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Hans Wennborg 49e7801b 2025-01-07T12:55:05 Suppress false-positive UBSan falures in rsgExpression.cpp A recent Clang roll introduced false-positives like runtime error: load of address 0x7f9c4f3ae6c0 with insufficient space for an object of type 'const IsConversionOkFunc' (aka 'bool (*const)(ConstValueRangeAccess)') Suppress them until a fixed version of Clang has been rolled in. Bug: chromium:388039125 Change-Id: I0823e52bb892feac519b123ae66716c3dc96f6b2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6149452 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c486ce8c 2024-12-27T06:24:19 Manual roll Chromium from faba6412dc5c to 8bb7bbeac941 (279 revisions) https://chromium.googlesource.com/chromium/src.git/+log/faba6412dc5c..8bb7bbeac941 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/63ad9737d7..8f6742f233 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/56013b77b6..2823e220cb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/41bfee6b2b..2344736aa3 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/11c38d901d..9ba1d4922a * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/f6418697ac..2559e1ff2f * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e6eba9706f..d0c22105ed No update to Clang. Bug: None Change-Id: I6c019235e8a99d74c91496d1cdfa37b56891d65f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6121262 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 07ad37e1 2024-10-07T09:57:17 Roll Chromium from f110bcc1488e to af63b8cf2be2 (761 revisions) Add tools/ubsan/vptr_ignorelist.txt suppressing LLVM due to https://chromium-review.googlesource.com/c/chromium/src/+/5854259 https://chromium.googlesource.com/chromium/src.git/+log/f110bcc1488e..af63b8cf2be2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9b11bd3a6a..884faaff73 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/7f979120bf..c803031bdb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/445152c103..a5cf433ad7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ae4dff4412..3a61fbe304 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6af18461ad..5304f2bbb3 * third_party/fuchsia-sdk/sdk: version:24.20240927.1.1..version:24.20241004.3.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/100430be35..8c26b4bd2f * third_party/siso/cipd: git_revision:dc7a06223e4ccbde049613ed802448b0c8baf5af..git_revision:6b2665e870db2df4da1c184a2aec2f98dcb75000 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/9454d9302a..8f4868f290 * tools/luci-go: git_revision:dd13340e3303af77ba58ca4b6453ca3b610f533f..git_revision:a1a693f7ec8f9b8d29843f5a68693c43d692d941 * tools/luci-go: git_revision:dd13340e3303af77ba58ca4b6453ca3b610f533f..git_revision:a1a693f7ec8f9b8d29843f5a68693c43d692d941 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/fc8a6438be..eb9827468d * tools/skia_goldctl/linux: g3oB7WN3FMw7wV_mjPXv5MHR_Ruh1F1yUfuErTH4dPEC..-WwsoLGIeY9CdK9XppXR9Q_l6IVn4roukf6qEQv5YNwC * tools/skia_goldctl/mac_amd64: -dmq848gM8JND4yLD470jkRVPqRmN7oqhAviMidflqQC..hhcjERw_9St0a6aoG-4qcqu3as4VN_08SbDnaNcm53oC * tools/skia_goldctl/mac_arm64: V4RKA9I-Wvyg57Iei5NfgLTp2hu93q4ZO-nyvfrd7n0C..FBgwCI1fflbcYLhG8hlzODBQIBcYe9MPiFFR_tcTBJEC * tools/skia_goldctl/win: IEkpUUyFJ5mwc9yz1CuRdzTEGMzgAYuS7Pr7uegUXoQC..4nH7g70rYeJlUxm49v3invhG2FjAPPK18QlAZ6gwVVoC No update to Clang. Bug: None Change-Id: Iaf3c3a86bd566e30e472e17d17b9e5cb088b3ee0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5912236 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi dbc6bd9d 2024-02-12T14:07:49 Reland "Vulkan: Fix alignment issues with SecondaryCommandBuffer" This is a reland of commit e53270c9ca1afe393d6d7d0359e81cf6755b6ca5 Original change's description: > Vulkan: Fix alignment issues with SecondaryCommandBuffer > > This solves undefined behaviour on 64-bit systems. This inflates the > size of a few commands, but most commands either already did align to 8 > bytes or could be aligned to 8 bytes with a few tweaks. > > Bug: angleproject:7852 > Change-Id: Ie61976d5bf8df7790acd95c0e15d4c79402622a1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5288636 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7852 Change-Id: Ie206e66fc21c5db7c9e67eb478d9cddada5db8e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5296376 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 243f8ad9 2024-02-14T11:44:58 Revert "Vulkan: Fix alignment issues with SecondaryCommandBuffer" This reverts commit e53270c9ca1afe393d6d7d0359e81cf6755b6ca5. Reason for revert: breaks x86 Android build: https://chromium-review.googlesource.com/c/chromium/src/+/5293321 https://ci.chromium.org/ui/p/chromium/builders/try/android-x86-rel/144329/overview Original change's description: > Vulkan: Fix alignment issues with SecondaryCommandBuffer > > This solves undefined behaviour on 64-bit systems. This inflates the > size of a few commands, but most commands either already did align to 8 > bytes or could be aligned to 8 bytes with a few tweaks. > > Bug: angleproject:7852 > Change-Id: Ie61976d5bf8df7790acd95c0e15d4c79402622a1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5288636 > Reviewed-by: Charlie Lao <cclao@google.com> > Reviewed-by: Yuxin Hu <yuxinhu@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:7852 Change-Id: Id9c7a94ccc12816bc9e8c3803bd940550d9f7953 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5295854 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Shahbaz Youssefi e53270c9 2024-02-12T14:07:49 Vulkan: Fix alignment issues with SecondaryCommandBuffer This solves undefined behaviour on 64-bit systems. This inflates the size of a few commands, but most commands either already did align to 8 bytes or could be aligned to 8 bytes with a few tweaks. Bug: angleproject:7852 Change-Id: Ie61976d5bf8df7790acd95c0e15d4c79402622a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5288636 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 4eed6b9b 2022-12-01T16:42:54 ubsan: Ignore errors from SwiftShader More errors exposed by the bots when trying to land this roll: https://chromium-review.googlesource.com/c/angle/angle/+/4070947 Test: angle_deqp_gles31_tests --use-angle=swiftshader Bug: angleproject:7852 Change-Id: I38e669817382ee17c403fbfd54ab2282a3f78cf0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4072219 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop a58ea0ac 2022-12-01T09:32:44 ubsan: Ignore alignment errors We are using unaligned allocations in memory pools to service ANGLE's SecondaryCommandBuffer implementation. Until this is fixed, ignore the ubsan errors. We also are seeing errors from zlib, so including that in the ignore until it is fixed upstream. Test: angle_deqp_gles31_tests Bug: angleproject:7852 Change-Id: Iaa34f12b7da7fa55558ba9ab0eace8fccf081653 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4070985 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill db3b4ee6 2021-06-22T10:23:05 Add simple UBSAN ignorelist. Bug: angleproject:5795 Change-Id: Ic2aa1124ac88a5d0fe87df3d524a10fe62b00732 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2977174 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>