kc3-lang/angle

Log

Author Commit Date CI Message
Geoff Lang dd4e09ef 2020-03-20T14:54:36 Update conditions for exposing ASTC extensions. Add commenents to explain the Vulkan ASTC situation. Expose GL_KHR_texture_compression_astc_sliced_3d when the HDR profile exists. Bug: angleproject:4447 Change-Id: I00a86cb3c44873a28397aab33a47fb363d4ecfe9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112283 Reviewed-by: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 07467b4a 2020-03-20T10:40:56 Remove GL_CHROMIUM_path_rendering Bug: chromium:1063193 Bug: angleproject:4270 Change-Id: I35b24b7d8d892181955e49dd2495655bc57cb0df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112275 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 95a4ded5 2020-03-20T14:36:48 Android.bp: Ignore unknown warning flags. Clang and Chrome build with different versions of clang which support different warning flags. Ignore unknown warning flags when building in Android. Bug: b:142320172 Change-Id: I35eb424aa5a146fec7dabf9f3aa71bd6dd9d8f50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112282 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Alexis Hetu 91f44a9a 2020-03-20T12:08:24 ASTC: LDR support doesn't imply HDR support There are SwiftShader related failures related to enabling the textureCompressionASTCHDRKHR feature without properly checking if the VK_EXT_texture_compression_astc_hdr extension is available, so HDR support shouldn't be enabled only based on the LDR support being enabled. Bug: angleproject:4447 Change-Id: Icde34892c9e2efff4b71e8c4e960c2fcff786700 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2080594 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Nico Weber cd6028de 2020-03-20T14:07:44 Suppress two -Wunreachable-code warnings on Fuchsia in Angle. Bug: chromium:346399 Change-Id: Ibf9cefdee52e487d9e73b9dff98a12267ac82af6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112281 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 4fb3c28f 2020-03-19T19:10:45 Vulkan: Fix Framebuffer cache depth/stencil issue. The DrawBuffers resetting logic didn't update the depth/stencil serial. Fix this and add a regression test that would crash in this situation. Note that the Manhattan benchmark could trigger this under some cases. Bug: angleproject:4322 Bug: angleproject:4490 Change-Id: Ie4b24efeb5991ecaa85bf8f964f77476bd6f167d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2111333 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 1c88cf27 2020-03-18T18:00:01 Add optimized rendering feedback loop tracking. This can be used both for WebGL and the Vulkan back-end workaround for Manhattan. Uses the recently added tracking for Textures being bound as samplers. Then caches this information in the Framebuffer using the Subject/Observer pattern. Bug: angleproject:4490 Change-Id: I08bef0a1b95c4333da19c2dae1f02a993e5835e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109335 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop a4337121 2020-03-19T15:31:00 Perf: Limit TracePerfTest to single compressed TRex Update the TRex trace to: * Incorporate recent fixes for compressed textures * Incorporate support for compressing the trace * Simplify the tag on the trace (drop the end frame) Update TracePerfTest to: * Temporarily support only a single trace (TRex200). Test: angle_perftests --gtest_filter="*Trace*" Bug: angleproject:4484 Bug: angleproject:4488 Bug: angleproject:4496 Change-Id: Ice0c4ee9de3ad9ae4596305a93c51c6eac842123 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112629 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 62b72552 2020-03-20T07:51:26 Add support for EXT_EGL_image_external_wrap_modes Allows for more wrap modes to TEXTURE_EXTERNAL_OES textures Test: angle_end2end_tests --gtest_filter=ExternalWrapTest.* Bug: angleproject:4443 Change-Id: I37bde091b166d7471c13c14fd6b0174136b52ecf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103433 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jamie Madill 32c1bf54 2020-03-19T14:12:39 Remove util.gni. This file was no longer referenced and is dead code. Bug: None Change-Id: Id4469b9575a14e31c6f715c2d290f2f8945cd25b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2110331 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 26f8f1a9 2020-03-20T14:54:11 Revert "Refactor BitCount" This reverts commit baecb7d55c692a93a29a46939029b8262174ca62. Reason for revert: Broke Skia Win/ARM builder. See issue for details. Original change's description: > Refactor BitCount > > POPCNT intrinsics cannot be used without hardware support, so a CPUID > check and polyfills are required for some CPUs when using MSVC to > avoid runtime failure. > > Other changes include: > - Clang: use builtins on all platforms to provide exact intent to the > compiler; > - MSVC on ARM: use dedicated intrinsics; > - x86/x64 fallback is now branchless and works in constant time. > > Bug: angleproject:4462 > Change-Id: I00fcabda1c842677d8cb4bfd280d932d0d10c0a5 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102811 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> TBR=geofflang@chromium.org,jmadill@chromium.org,lexa.knyazev@gmail.com Change-Id: Ia1756abdf7da2aa9574149eb388915f97758bba0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:4462 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112276 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Xiaoxuan Liu 2709f40f 2020-03-17T14:22:42 Skip updating viewport and scissor info if the same If glViewport() or glScissor() is called with same info, skip updating viewport or scissor info and related dirty bits. Bug: angleproject:4487 Change-Id: I9a0f3eb0df789beb99447ebc98383f502fbc763d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2105528 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 12a1c373 2020-03-20T07:01:14 Roll third_party/spirv-tools/src 18d3896a15fc..60104cd97446 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/18d3896a15fc..60104cd97446 Created with: gclient setdep -r third_party/spirv-tools/src@60104cd97446 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I3dcd66069fea3caf8aca5e10bc0dad5eb9d661dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2111884 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 92941f2c 2020-03-20T07:01:03 Roll third_party/SwiftShader bc98fbeec99b..1c9f24263e6c (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/bc98fbeec99b..1c9f24263e6c git log bc98fbeec99b..1c9f24263e6c --date=short --first-parent --format='%ad %ae %s' 2020-03-19 sugoi@google.com Fix float to r11g11b10 conversion 2020-03-19 amaiorano@google.com marl: manually apply partial patch to fix x86 crashes Created with: gclient setdep -r third_party/SwiftShader@1c9f24263e6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: angleproject:4482 Tbr: courtneygo@google.com Change-Id: I6c49a595ffe084fbf6d80f57638011c96384384e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2111883 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 0e069b42 2020-03-19T21:40:51 Skip SwANGLE GLES31 tests which crash with 32-bit Subzero only on Windows Linux 32-bit crashes were fixed. Bug: angleproject:4482 Change-Id: I3efd7c760dfec1f8b909eee2ed84f5f9ebc33c3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2111970 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov ca45852d 2020-03-19T22:04:47 Skip flaky TransformFeedbackTest.MultiContext on Win Intel Vulkan Bug: angleproject:4497 Change-Id: I92e7ad9f0c34fe0b5f67318271ececc218c20757 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2111781 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill b1eb44bf 2020-03-18T15:33:13 Track if a Texture is bound as a sampler. This will more easily allow us to detect rendering feedback loops. We'll need to support feedback loops to enable Manhattan. Bug: angleproject:4490 Change-Id: I442deebd89dcf0139411688eaa204c5e5b2c2799 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109334 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Alexey Knyazev baecb7d5 2020-03-14T21:40:58 Refactor BitCount POPCNT intrinsics cannot be used without hardware support, so a CPUID check and polyfills are required for some CPUs when using MSVC to avoid runtime failure. Other changes include: - Clang: use builtins on all platforms to provide exact intent to the compiler; - MSVC on ARM: use dedicated intrinsics; - x86/x64 fallback is now branchless and works in constant time. Bug: angleproject:4462 Change-Id: I00fcabda1c842677d8cb4bfd280d932d0d10c0a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102811 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Mohan Maiya 7daf31d8 2020-03-18T09:19:52 Vulkan: Use device local memory for conversion buffers that can be converted with the GPU When converting a vertex buffer by using GPU, the conversion buffer doesn't need to be host mappable. Hence the conversion buffer can be allocated on device local memory for faster GPU access times. Bug: angleproject:3534 Change-Id: I2efabec20186992479920bddd3abd36f9c13babc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2108706 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 9d812d35 2020-03-18T15:31:14 Vulkan: Remove public FramebufferVk::getFramebuffer. Goal: enable rendering feedback loop detection for Manhattan. Making getFramebuffer private prevents direct access to the Framebuffer internals. Hiding access lets the FramebufferVk class switch up its implementation to support different VkFramebuffers for feedback loop cases. Also this is a general code cleanup. Bug: angleproject:4490 Change-Id: Ib4f5e34d476ccd8fc43a1adb031933ab347ca7b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109333 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll bff3b200 2020-03-19T07:01:16 Roll third_party/spirv-tools/src 25ede1ced679..18d3896a15fc (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/25ede1ced679..18d3896a15fc Also rolling transitive DEPS: third_party/spirv-headers/src a17e17e36da4..f8bf11a0253a Created with: gclient setdep -r third_party/spirv-tools/src@18d3896a15fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Idc630e487903f425e849f1bed5997bb88875a328 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109619 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jian Li 8aa20069 2020-03-18T17:55:06 Skip some tests on Mali because of a known issue Type decorations may be ignored when using multiple OpAccessChains. Bug: angleproject:4492 Change-Id: I2e51af600394a69cb5f7e02228ca7e4fd1c826e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2105529 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll a38e20e4 2020-03-19T07:01:04 Roll third_party/SwiftShader 440fc9959f06..bc98fbeec99b (3 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/440fc9959f06..bc98fbeec99b git log 440fc9959f06..bc98fbeec99b --date=short --first-parent --format='%ad %ae %s' 2020-03-18 amaiorano@google.com Subzero: fix external function calls on x86-32 2020-03-18 amaiorano@google.com Subzero: fix partially initialized ManagedStatic assert 2020-03-17 digit@google.com [vulkan]: Support multiple external semaphore implementations. Created with: gclient setdep -r third_party/SwiftShader@bc98fbeec99b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: angleproject:4482 Tbr: courtneygo@google.com Change-Id: I09384435c826f4dd4eb3003006da8a8315e7c959 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109617 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill dadeffa3 2020-03-18T21:56:05 Capture/Replay: Fix stride in compressed texture caching. We were saving "width" bytes instead of "width * pixelSize". This was causing incorrect rendering in T-Rex and Manhattan. Bug: angleproject:4488 Change-Id: Ib5d38aaf813fb26905aedc155cc13b9d1597ec4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109336 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill f955fb45 2020-03-16T16:36:55 Roll chromium_revision 86e00b5dd2..fa9d5805c4 (743688:750702) Change log: https://chromium.googlesource.com/chromium/src/+log/86e00b5dd2..fa9d5805c4 Full diff: https://chromium.googlesource.com/chromium/src/+/86e00b5dd2..fa9d5805c4 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5d6bdfc4f1..a1cbf6469a * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/feb2d0c562..4164a30562 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/74854b3f7b..3e21eec53c * third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/703ca235f0..c96dc32110 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c2eb8a7f7a..156be8c52f * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/eeaa53b76f..d60a6a8084 DEPS diff: https://chromium.googlesource.com/chromium/src/+/86e00b5dd2..fa9d5805c4/DEPS Clang version changed c29003813ab9bd6ea7b6de40ea8f1fe21979f13f:9284abd0040afecfd619dbcf1b244a8b533291c9 Details: https://chromium.googlesource.com/chromium/src/+/86e00b5dd2..fa9d5805c4/tools/clang/scripts/update.py TBR=jmadill@chromium.org, Bug: angleproject:4484 Change-Id: I4e7bcd3f184ad29a7d9cffc125d58387445052af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2106453 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 9817f9ad 2020-03-18T13:45:38 Roll third_party/vulkan-validation-layers/src 6cd8cbdaab99..caeb15a056a0 (15 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6cd8cbdaab99..caeb15a056a0 git log 6cd8cbdaab99..caeb15a056a0 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 s.fricke@samsung.com tests: Add support for VUID 01762 2020-03-17 s.fricke@samsung.com layers: Add support for VUID 01762 2020-03-17 s.fricke@samsung.com layers: Add support for Map Memory VUIDs 2020-03-17 s.fricke@samsung.com layers: Removed redundant looping in graphics pipeline 2020-03-17 s.fricke@samsung.com tests: Add support for VUID 02801 2020-03-17 s.fricke@samsung.com layers: Add support for VUID 02801 2020-03-17 s.fricke@samsung.com tests: Add support for VUID 01510 2020-03-17 s.fricke@samsung.com layers: Add support for VUID 01510 2020-03-17 s.fricke@samsung.com tests: Add support for VUID 01442 2020-03-17 s.fricke@samsung.com layers: Add support for VUID 01442 2020-03-17 s.fricke@samsung.com tests: Add support for VUID 01188 2020-03-17 s.fricke@samsung.com layers: Add support for VUID 01188 2020-03-17 s.fricke@samsung.com tests: Add support for VUID 00968 2020-03-17 s.fricke@samsung.com layers: Add support for VUID 00968 2020-03-17 jmadill@chromium.org Fix Chromium warning about copying iterators. Created with: gclient setdep -r third_party/vulkan-validation-layers/src@caeb15a056a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC courtneygo@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com,jmadill@google.com Change-Id: Ib1b355f9b47418f1f360d7a7bbd277a2b548893a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2108103 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Courtney Goeltzenleuchter 4422d298 2020-03-18T09:54:54 Vulkan: Must call vkFlush while memory is mapped Update to Vulkan validation layers pointed out that vkFlushMappedMemoryRanges needs to be called when the memory is mapped. Bug: b:151820847 Change-Id: I3860306080bca435c063046f9ae20943a8601d17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2108705 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Tobin Ehlis 4119f033 2020-03-17T13:34:09 Vulkan:Set one-time bit on all command buffers All Vulkan command buffers are only submitted once so we can set the VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT which may help performance. Bug: angleproject:4304 Change-Id: Ibd116dcac4e78a2c058eb3da54489057d6fa8f44 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107800 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com>
Courtney Goeltzenleuchter 4df67871 2020-03-17T16:13:23 Be sure to clear all program state at unlink At Program::unlink we clear out the program's state but forgot mBufferVariables. That was causing us to hit an assert when trying to load a shader from cache. Only see the issue on Android as that's the only platform where shader caching is supported. Test: KHR-GLES31.core.explicit_uniform_location.uniform-loc Bug: angleproject:4132 Change-Id: Iae9c26a3e3b2d11983cc7d90bcd54a10c0fa9934 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107235 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Jamie Madill 23d63fc3 2020-03-17T20:34:50 Capture/Replay: Fix MEC Query capture. In Manhattan the test generates a bunch of queries that it doesn't start until later frames. In ANGLE these queries will be stored as nullptr entries in the QueryMap. By default the QueryMap Iterator skips over nullptr entries. This manifested later as GL errors during replay. Fix this by adding a new Iterator type to ResourceMap that does not skip over nullptr values. Bug: angleproject:4489 Change-Id: If56b908fb233de0df0445f9ea19fc322f2c42976 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107762 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Jamie Madill e54f7ed7 2020-03-17T18:20:44 Capture/Replay: Fix compressed texture subImage caching. The prior code was caching the last subImage data. In fact we should be caching and updating a pixel rectangle. Multiple subImage calls will update the same rectangle until the final capture call sets up the replay with the complete initial data. This was causing an issue with Manhattan and the initial data for 3D compressed textures. Manhattan uploads these one layer at a time. So the prior code was trying to pass a single layer's data to the subImage call for the entire level. Bug: angleproject:4488 Change-Id: I76765dcea884f9d8ea07908c44e97578ddb0ff0d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107761 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Jamie Madill 7e453a25 2020-03-15T22:11:03 Capture/Replay: Use zlib to compress data files. Gives about a 2-3x reduced data file size. Should help reduce the time we spent transferring trace files on Android. This feature is implemented as a parameter to the capture/replay tool. This keeps backwards compatiblity if we ever need to integrate a cpp replay into an environment that doesn't have access to zlib for decompression. We'll need to update the traces to take advantage of the compression. Bug: angleproject:4484 Change-Id: Id7994efe3c0d529b85fa7e7f1b00444e630dd2cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2104555 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 78a85f2c 2020-03-16T10:28:59 Vulkan: Request device local memory for glBuffer with GL_STATIC* usage glBuffer objects with GL_STATIC_* usage patterns will now request the storage to be allocated in device local memory. For glBuffer objects with GL_DYNAMIC_* usage patterns we request a host cached memory. Bug: angleproject:4480 Change-Id: I7ca968f5ddfb59e4df3ecd07ae65df2bbf734190 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102958 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Amy Liu f98084ed 2020-03-12T10:06:26 Fix ShaderStorageBufferReadWriteOffset end2end test Test: ShaderStorageBufferTest31.ShaderStorageBufferReadWriteOffset. Align kBufferOffset to bufferAlignOffset correctly. Bug: angleproject:4471 Change-Id: I71084839a845138b32d58d8bd2cf6fed2633a9be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2100047 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 273f9c7c 2020-03-17T07:01:41 Roll third_party/SwiftShader 3a50a43df988..440fc9959f06 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/3a50a43df988..440fc9959f06 git log 3a50a43df988..440fc9959f06 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 swiftshader.regress@gmail.com Regres: Update test lists @ 3a50a43d Created with: gclient setdep -r third_party/SwiftShader@440fc9959f06 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I95262d4bfe2eafab7865082de2d7d0fd6a60a69c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107107 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll af0891b5 2020-03-17T07:01:47 Roll third_party/glslang/src 9b620aa0c12d..4b2483ee88ab (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9b620aa0c12d..4b2483ee88ab Created with: gclient setdep -r third_party/glslang/src@4b2483ee88ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Ic397f97c031c67c88ddbf2be63ae1f4dbea05401 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107108 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f748ee6c 2020-03-17T07:01:34 Roll third_party/vulkan-validation-layers/src be663d752e45..6cd8cbdaab99 (7 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/be663d752e45..6cd8cbdaab99 git log be663d752e45..6cd8cbdaab99 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 jbolz@nvidia.com scripts: Add aliased types to handle_types 2020-03-16 jbolz@nvidia.com layers: Fix RayTracing VUIDs to use buffer->createInfo.size 2020-03-16 jbolz@nvidia.com tests: Disable a test case in VkLayerTest.ValidateGeometryNV 2020-03-16 s.fricke@samsung.com tests: Extra test to check multi-planar copies 2020-03-16 s.fricke@samsung.com layers: Add support for 01548 2020-03-16 mark@lunarg.com docs: Update layer config and overview doc 2020-03-16 jakub@okonski.org tracker: Fix work retiring for queue submissions Created with: gclient setdep -r third_party/vulkan-validation-layers/src@6cd8cbdaab99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Id80bddb98cd6236ed7d7d29e96d03c307726bda7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107106 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8bc374dd 2020-03-17T07:01:14 Roll third_party/vulkan-loader/src f1d9f12a19de..64c36933d4f2 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f1d9f12a19de..64c36933d4f2 git log f1d9f12a19de..64c36933d4f2 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 joshua@froggi.es loader: Handle no surface for surface caps 2 funcs 2020-03-16 joshua@froggi.es loader: Migrate get surface caps 2 funcs to wsi Created with: gclient setdep -r third_party/vulkan-loader/src@64c36933d4f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I9a716acb93ba63d7a7b3c2898dd7896b53a4dc14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107105 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill a8acd779 2020-03-16T22:28:50 Roll third_party/zlib/ c2eb8a7f7..156be8c52 (1 commit) https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c2eb8a7f7a0f..156be8c52f80 $ git log c2eb8a7f7..156be8c52 --date=short --no-merges --format='%ad %ae %s' 2020-03-16 jmadill Fix zlib build on UWP. Created with: roll-dep third_party/zlib Bug: angleproject:4484 Change-Id: I182ff15c092ed1b327f9622429aa97bdebe45c84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2106795 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill d24752e6 2020-03-15T21:34:10 Capture/Replay: Write to single binary data file. Previously the tool would save to a separate file for every frame and one additional file for the setup function. Frames without binary data would not get an "angledata" binary file. Using a single file has a few advantages: - makes it simpler to track the data dependencies in GN - should be easier to compress and decompress for speed up transfers - no need to wonder if we have frames with missing data files - less overhead reading from the HDD since the whole trace is buffered We might need to worry about extemely huge memory use cases. For now buffering the whole file into memory on startup is simple and fast. Also makes the binary data loader function more robust. Bug: angleproject:4484 Change-Id: Ia74fb0bc65200adf7a21c3143f98aa4da86457b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2104554 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 7c334c56 2020-03-15T17:37:15 Re-enable optimization for angle_perftests. This CL restricts the workaround to the trace perf tests. These trace tests are too big to optimize. Also includes a fix for a 32-bit Windows warnings. We'll need to update the build file to remove a suppression once the traces are updated. Bug: angleproject:3630 Change-Id: Id13a0050fc2a645aa572b8c9079908023b232f28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103084 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 42c453fe 2020-03-15T18:23:15 Move perf test common files to a source set. Similarly to a prior patch this organizes the common perf test sources into a single target. This will allow us to more easily support setting compiler flags on particular perf test sources. This also fixes some build errors that popped up when new warnings were enabled. Bug: angleproject:3630 Change-Id: I866885199f93a5055e8d160e39f72d1f8209bc75 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103086 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 5df2c9ea 2020-03-15T17:28:43 Refactor ANGLE common test utils. This reduces code duplication by including a common set of sources in a single place. New test sets will be a bit easier to add. It also encapsulates the dependencies a bit better when we pull the test utils out of the test targets. Unblocks a follow-up CL that moves the trace perf test sources into their own file so we can re-enable optimizations in the main perf test target. New warnings popped up in a few of the files because of the new source set enabling more warnings. This CL also fixes all of those. Bug: angleproject:3630 Change-Id: Ic30cb30fb4288c4dbbbd29f9bdf04be51e8a6b30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103083 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 41b4ab19 2020-03-16T19:18:56 Roll third_party/spirv-tools/src dd3d91691f1e..25ede1ced679 (5 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/dd3d91691f1e..25ede1ced679 Also rolling transitive DEPS: third_party/spirv-headers/src dc77030acc9c..a17e17e36da4 Created with: gclient setdep -r third_party/spirv-tools/src@25ede1ced679 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC courtneygo@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com,ynovikov@google.com Change-Id: Ief155818d9aa7a143d36cb05bce5b761b6983d13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2106235 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 113b9d42 2020-03-16T16:46:18 Fix documentation typo. "Montitor" Bug: angleproject:1944 Change-Id: I4321265e22d7e878ff1f3223a7d8a00959c1db39 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2106454 Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 457588ef 2020-03-16T14:11:33 Add more documentation on testing infrastructure. Adds more info on the amount of testing ANGLE runs and our various configs. Adds a few other notes and cross-links. Bug: angleproject:1944 Change-Id: I76e46783bd6a3f84d3e170bd30ea2e6d57911143 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2105715 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Xiaoxuan Liu f1eb10ef 2020-03-10T16:40:53 GLES: Skip tests if vertex SSBO were not supported Skip tests if GPU doesn't support vertex shader storage buffer object. Bug: angleproject:4466 Change-Id: Icc7b6e686d7b4d5ecd2e05f6f09551f839f5302d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096740 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill a8631f68 2020-03-15T20:38:20 Fix running trace tests in non-standard directories. The change to make the trace tests load the data files using a relative path only worked when running the tests from the "standard" out path. By setting the CWD to the executable dir in test setup we are able to run the tests from any local dir when testing. Also cleans up some repeated code in the test init switch statement. Bug: angleproject:3630 Change-Id: I8e9e5e6e1e9cd31c5b3c7b2f52420d0ba75cf76b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2104548 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll d1d96d73 2020-03-16T07:01:41 Roll third_party/SwiftShader 18daa81e3d3d..3a50a43df988 (14 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/18daa81e3d3d..3a50a43df988 git log 18daa81e3d3d..3a50a43df988 --date=short --first-parent --format='%ad %ae %s' 2020-03-14 bclayton@google.com SpirvShaderDebugger: Implement scope nesting 2020-03-13 sugoi@google.com Compile Vulkan library with Subzero in Chromium 2020-03-13 bclayton@google.com SpirvShader: Silence warnings of unexpected opcodes 2020-03-13 amaiorano@google.com Subzero: hide dependency on Marl 2020-03-13 amaiorano@google.com BUILD.gn: add missing dependency onto marl for SubzeroReactor 2020-03-13 capn@google.com Consistently use TRUE/FALSE in CMakeLists.txt 2020-03-13 capn@google.com Exclude all static libraries from "all" build target 2020-03-13 amaiorano@google.com Subzero: replace Win32 fibers with Marl for couroutines 2020-03-13 bclayton@google.com SpirvShaderDebugger: Add flag for printing opcodes as they're executed 2020-03-13 bclayton@google.com SpirvShaderDebugger: Make Function extend Scope 2020-03-13 bclayton@google.com SpirvShaderDebugger: Add string helper for debug kinds 2020-03-13 bclayton@google.com SpirvShader: Implement OpenCLDebugInfo100DebugInfoNone 2020-03-13 bclayton@google.com SpirvShaderDebugger: Stub UNIMPLEMENTED() opcodes 2020-03-13 bclayton@google.com SpirvShader: Implement OpenCLDebugInfo100DebugInlinedAt Created with: gclient setdep -r third_party/SwiftShader@3a50a43df988 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ia1c5ef7d6f8c9cd9991c71f0aa8aeb2fc0f6ff3c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2104696 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov cb9a86a9 2020-03-15T14:24:32 Skip SwANGLE GLES31 tests which crash with 32-bit Subzero. Started with https://swiftshader-review.googlesource.com/c/SwiftShader/+/42108 Bug: angleproject:4482 Change-Id: I48effe26aa7ce1b574f9df8ad9c3f560cb599cf3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2104406 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill a4a42e6d 2020-03-15T18:25:21 Format perf_test.cc. This was missed when our git cl format protection was temporarily broken. A subsequent change caused the file to get fully formatted so this CL pulls that diff into a split change. Bug: angleproject:3630 Change-Id: I14ed53708783b38039e8fa64cb38837e25911893 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103085 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 869e901a 2020-03-14T20:27:09 Temporarily disable optimizations in angle_perftests. The optimization for the large trace perf tests was so costly that in some configs it would fail to build at all. This could cause build failures in the ANGLE CQ. Disable optimization to work around this until we can isolate the compiler flags to just the trace perf tests. Note: this only applies to the test harness. ANGLE itself is still optimized in release builds by default. Trace trimming would also help alleviate this problem. We could also consider removing a few traces temporarily. Bug: angleproject:3630 Change-Id: I2bd8fb76f330692aa715249ca8656965b5a29d8c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103674 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill db3f042b 2020-03-14T17:55:39 Trace Tests: Rebase path to relative dir. We were encoding an absolute path into our binaries. This works locally and breaks horribly when run on the bots. Fix this by rebasing the path to the root_out_dir. Bug: angleproject:3630 Change-Id: I4044d1228ee951f2192e83167deb92a0ffe92a52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103672 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Mohan Maiya a3cf06ac 2020-03-12T13:15:48 EGL: populate EGL_NATIVE_VISUAL_ID values for Android When generating the default EGL configs, populate EGL_NATIVE_VISUAL_ID with AHARDWAREBUFFER formats. Bug: angleproject:4469 Change-Id: Ifde9df0497cbd4e01219ab6067acd8d97f8460e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2101577 Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Yuly Novikov 57fa7c6c 2020-03-13T22:33:16 Revert "Skip crashing dEQP-GLES3.functional.samplers.*_tex_3d.* on SwANGLE" This reverts commit 9e9493f29dbf3afcd962c56f66cb752efe3c7ee8. Reason for revert: fix in https://swiftshader-review.googlesource.com/c/SwiftShader/+/42208 Original change's description: > Skip crashing dEQP-GLES3.functional.samplers.*_tex_3d.* on SwANGLE > > Started after > https://chromium-review.googlesource.com/c/angle/angle/+/2076740 > > Bug: angleproject:3983 > Change-Id: I4073baa36aebd4bbd210bb0a0f46959b9ef66450 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2086695 > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> TBR=ynovikov@chromium.org,cnorthrop@google.com,jmadill@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:3983, b:150155499 Change-Id: If5cacbeba43ce331382c0aaf814684ee1fcdaab0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103435 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Alexey Knyazev e6519445 2020-03-12T19:02:03 Implement ScanForward64 on 32-bit platforms This unlocks opt-in usage of BitSet64 on 32-bit platforms. It is slightly faster than IterableBitSet when the amount of bits is greater than 32. Bug: angleproject:4473 Change-Id: I230784acc871e13b1f94c87503f6bb869dcd3a68 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2100969 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 03de11ac 2020-03-13T13:25:24 Add ANGLE_FOR_ANDROID_TOAST_MESSAGE to AndroidManifest.xml The AndroidManifest.xml is missing the intent android.app.action.ANGLE_FOR_ANDROID_TOAST_MESSAGE which causes a crash when enabling the Toast message when an app uses ANGLE. Bug: b:142320172 Change-Id: Iac69136fbf9ff753a3bad9e393ad62b0bf0918b5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103173 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Jamie Madill 1393bf9e 2020-02-28T22:03:27 Vulkan: Timestamp internal RenderPasses in perf tests. This change book-ends RenderPasses in the Vulkan back-end with timestamp queries. This allows us to write out a trace of GPU/CPU that we can inspect in Chrome. To enable the GPU trace you can define ANGLE_ENABLE_VULKAN_GPU_TRACE_EVENTS in ContextVk.cpp and run the angle_perftests suite with --enable-trace. Note that we ran into some issues with the implementation not returning monotonic timestamps. This may be a driver bug but bears more investigation. Bug: angleproject:4433 Change-Id: I0e6a364367f15183068e55686549cb418aa94c2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2081380 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill a8c95f74 2020-03-13T13:41:57 Update export_targets to fix presubmit on Windows. We don't have Windows presubmit coverage so this slipped through with the change to add DisplayEGL. See: "Reland "Instantiate rx::DisplayEGL when device type EGL is selected" Bug: angleproject:4328 Change-Id: I68f9e77b7b38fca86cf30a247f33543e4157e73f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102952 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Julien Isorce <julien.isorce@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Courtney Goeltzenleuchter b1b6a171 2020-03-10T14:20:36 Vulkan: Disable robustness support Swiftshader does not currently have the ability to behave in a way for ANGLE to support KHR_robustness. Disable for now until that functionality is available. Bug: angleproject:3058 Bug: swiftshader:145 Change-Id: I1c1b8147f6b9cf6f8d0da633dfe0f61ebfab5175 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2097053 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com>
angle-autoroll c5ee8e03 2020-03-13T07:01:41 Roll third_party/SwiftShader 16ae92a4ee52..18daa81e3d3d (15 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/16ae92a4ee52..18daa81e3d3d git log 16ae92a4ee52..18daa81e3d3d --date=short --first-parent --format='%ad %ae %s' 2020-03-12 sugoi@google.com Allow 3D filtering in the Blitter 2020-03-12 capn@google.com Fix building with latest LLVM 2020-03-12 capn@google.com Document single-level YCbCr image assumption 2020-03-12 capn@google.com Clarify the PointCoord calculation 2020-03-12 capn@google.com Remove unnecessary point setup calculations 2020-03-12 capn@google.com Don't needlessly build LLVM 2020-03-12 bclayton@google.com Update Marl to 64d123947 2020-03-12 bclayton@google.com VkImage: Implement BC7 texture format 2020-03-11 bclayton@google.com Update Marl to 94a361cf0 2020-03-11 capn@google.com Support running PowerVR samples using SwiftShader on Linux 2020-03-11 bclayton@google.com Regres: Roll dEQP to 1.2.1 2020-03-11 capn@google.com Regres: support testlist creation from specified hash 2020-03-11 capn@google.com Suppress warnings in Subzero dependencies 2020-03-11 bclayton@google.com Regres: Simplify running of local tests 2020-03-11 bclayton@google.com Kokoro: Update clang-8 URL Created with: gclient setdep -r third_party/SwiftShader@18daa81e3d3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: angleproject:4474 Tbr: jmadill@google.com Change-Id: I5d0f416817692b8f69be97d8fe54334655cf8a66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102176 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 2950d334 2020-03-13T07:01:14 Roll third_party/vulkan-loader/src 29adf277cb19..f1d9f12a19de (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/29adf277cb19..f1d9f12a19de git log 29adf277cb19..f1d9f12a19de --date=short --first-parent --format='%ad %ae %s' 2020-03-12 charles@lunarg.com loader: Fix skipping all layers if one bad is found 2020-03-12 charles@lunarg.com loader: fix crash when json doesn't contain an object Created with: gclient setdep -r third_party/vulkan-loader/src@f1d9f12a19de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I1a7ca91cb3e57fa398a206328743ecb5701cd514 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102175 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 6963f58c 2020-03-05T15:45:35 Capture/Replay: Update TRex captures Test: angle_perftests.exe --gtest_filter="*Trace*" Bug: angleproject:4091 Change-Id: I1ec0a58f156eee0c36fdb38ec44eb486f974b731 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2090664 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Julien Isorce 07044c65 2020-03-03T00:13:03 Reland "Instantiate rx::DisplayEGL when device type EGL is selected" This is a reland of 7455b54401dd55833944b5ad857ccd9852ef6a79 Original change's description: > Instantiate rx::DisplayEGL when device type EGL is selected > > Define EGL_PLATFORM_ANGLE_DEVICE_TYPE_EGL_ANGLE that should be > used to request a driver egl-backed implementation with ANGLE. > > Bug: angleproject:4328 > Change-Id: I6871d3a27e2bfc02af9815dcf86ae1cb6524f0cc > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2030038 > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: angleproject:4328 Change-Id: I4e997c4fa1b5b59f081436f05bd208303ffe38e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2093412 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
Ian Elliott 33bdab77 2020-03-12T11:42:13 Vulkan: Handle VK image being both a GL texture and GL image Address a shader that uses the same texture as both a GL texture (e.g. using a sampler) AND as a GL image (e.g. using imageLoad or imageStore). The barrier and descriptor set created by ContextVk::handleDirtyTexturesImpl() are wrong (read-only). This is fixed by having ContextVk::handleDirtyTexturesImpl() look up if the image is also being used as an image texture, and if so, use the layout that should be used in that case. Bug: angleproject:4413 Change-Id: I75684e1cfc7ed74296802ab6e31468d81625d4a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2099311 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 391f38c9 2020-03-05T12:18:34 Capture/Replay: Add Manhattan to TracePerfTest This CL also adds the ability for a perf test to elect to ignore GL errors during replay. Otherwise, errors will cause the test to fail. We have known failures with Manhattan that don't affect replay. Test: angle_perftests.exe --gtest_filter="*Trace*" Bug: angleproject:4091 Change-Id: I36268a9f80754f338e52208273e889d2404b7eed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2090663 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Frank Liberato dcf20853 2020-02-27T13:11:44 Add fp16 support to KHR streams for DX11. This CL exposes DXGI_FORMAT_R16G16B16A16_FLOAT as GL_RGBA16F. Bug: angleproject:4440 Change-Id: Icbc7b2d10a4c02946fb01711c01cc8c9b01e8f54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2079197 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 6ab0dbdf 2020-03-12T13:51:07 Rename ANGLE_defaults to ANGLE_java_defaults. This target already exists in internal master, avoid the name conflict until there is only one set of build files. BUG=b:142320172 Change-Id: Ida176f39422c1c57cc2936a06e61b7e86bf2cc90 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2101367 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Amy Liu 5bb36cc0 2020-02-21T18:25:54 Passing covgl/covgl Fix the following gles1-API implementation codes and some validation functions: glClearColorx glClearDepthx glDepthRangex glGetFixedv glGetTexParameterxv glLineWidthx glPolygonOffsetx glSampleCoveragex glTexParameterx glTexParameterxv ValidateMaterialCommon ValidateFogx ValidateFogxv ValidatePointSizex ValidateRotatex ValidateTexEnvx ValidateTexEnvxv Bug: angleproject:4281 Change-Id: Ia1d9e53c3ffde2bc77b7ca7eaa0d790e8ca43f10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2075341 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tobin Ehlis 175227ba 2020-03-06T14:30:06 Vulkan:FramebufferVk cache draw buffer handling Dirty draw buffers are causing cache clears on Manhattan. Instead of clearing out the entire FramebufferVk cache when draw buffers are dirty, reset the cache signature and regenerate it. This change also contains a fix to make sure that we're not generating serials for a draw buffer that's disabled. Thanks Jamie Madill! Bug: angleproject:4442 Change-Id: I0d48a2d6d95e74898a11bdde0fedbce77c82a3a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2091862 Reviewed-by: Tobin Ehlis <tobine@google.com> Commit-Queue: Tobin Ehlis <tobine@google.com>
Cody Northrop a2f9ad39 2020-03-09T14:28:39 Vulkan: Remove unused atomic counter builtins Atomic counters are not supported by Vulkan. Most are already converted by the RewriteAtomicCounters traversal, but that is only invoked when atomic counters are active. This CL introduces another pass that removes any atomic counter builtin that was not handled by the previous pass. It also will assert if it sees any atomic counters active, thus ensuring it is only used when needed. Test: KHR-GLES31.core.compute_shader.shared-struct Test: angle_end2end_tests.exe --gtest_filter="*AtomicCounter*" Bug: angleproject:4189 Bug: b:150310216 Change-Id: I61d10e954886dc94fede8b344f5a0ede3b689adb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2095688 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang cf80f252 2020-03-12T11:33:10 Remove android:forceQueryable from the ANGLE.apk manifest This property is not part of AOSP yet. BUG=b:142320172 Change-Id: I73b0481872096053c6b4b709d15376d82a1a7b02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2099421 Commit-Queue: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll 40c7a20f 2020-03-12T07:01:34 Roll third_party/vulkan-validation-layers/src 2ff8b6a6f4d5..be663d752e45 (8 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2ff8b6a6f4d5..be663d752e45 git log 2ff8b6a6f4d5..be663d752e45 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 mark@lunarg.com stateless: Removed suboptimal swapchain performance warning 2020-03-11 mark@lunarg.com practices: Add perf warning for suboptimal swapchains 2020-03-11 mark@lunarg.com tests: Added verification for subpass index OOB checks 2020-03-11 mark@lunarg.com stateless: Added checks for OOB subpass indices 2020-03-11 mark@lunarg.com chassis: Remove SetAll function for enables 2020-03-11 attilio.provenzano@arm.com tests: Add BP tests for Arm-specific checks 2020-03-11 attilio.provenzano@arm.com practices: Add a set of Arm-specific checks 2020-03-11 attilio.provenzano@arm.com layers: Add support for vendor-specific checks Created with: gclient setdep -r third_party/vulkan-validation-layers/src@be663d752e45 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ie362875ba46134697d9a5a29bbfbaf4b66b2219a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2100145 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f51dbc28 2020-03-12T07:01:46 Roll third_party/glslang/src e2176c91b23c..9b620aa0c12d (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e2176c91b23c..9b620aa0c12d Created with: gclient setdep -r third_party/glslang/src@9b620aa0c12d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ic3355464a505cbc1e04da1dfbfd2bb2ce2afa761 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2100227 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll afa2f827 2020-03-12T07:01:14 Roll third_party/vulkan-loader/src 136207a63495..29adf277cb19 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/136207a63495..29adf277cb19 git log 136207a63495..29adf277cb19 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 shannon@lunarg.com build: Update known-good for 1.2.134 header Created with: gclient setdep -r third_party/vulkan-loader/src@29adf277cb19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I6af6fae3a96abe2629510ebe5d4fcc57b26133d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2100144 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
shrekshao 84780f7d 2020-03-11T10:58:09 Speculative fix: getProgramiv always returns a valid program The only possibility with program being nullptr here in the case of GL_LINK_STATUS seems to be if the context gets lost between the validation and usage of `Context::getProgramiv`. Bug: chromium:991020 Change-Id: I50a77ca4a841dea7324344a71e46d4e0bf72858d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096176 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com>
Yuly Novikov 2e5bd9b1 2020-03-11T17:46:06 Update SimpleStateChangeTest.DrawRepeatUnalignedVboChange suppression Also flaky on Linux (already suppressed on Windows). Bug: angleproject:4470 Change-Id: I032241a4201dc7883d6107c643cf88c92fb01ba3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2099402 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Tim Van Patten 27f310da 2020-03-11T16:07:18 Fix SearchProvider The SearchProvider was attempting to launch ANGLE's MainActivity class with the wrong fully qualified class name when Google's version (com.google.android.angle) was installed on the device: com.google.android.angle/.MainActivity Instead, the AndroidManifest.xml and SearchProvider need to use the fully qualified class name for com.android.angle.MainActivity since the package name will differ between the AOSP (com.android.angle) and Google (com.google.android.angle) versions. Bug: b:142320172 Change-Id: Iab6883736be2a21dff64993bcaedbcc4c0cfecf8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2099443 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Geoff Lang 14aaa1eb 2020-03-11T17:40:35 Refactor ANGLE target to allow GoogleANGLE to override it. GoogleANGLE will be signed in a different part of Android so it needs to be able to reference ANGLE's target and defaults to override certain properties. Update the manifests to request the needed permissions to use the developer options. Bug: b:142320172 Change-Id: Ia47815ab53f8de66332412efa2cc0fca3175e2cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096815 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 9e5bbb38 2020-03-06T16:15:11 Use ANGLE's vulkan-headers dep when rolling ANGLE into Android. We previously used the existing Android target for vulkan headers but it does not roll as fast as ANGLE's, possibly causing divergence in test results. BUG=angleproject:2344 BUG=b:150892231 Change-Id: Ibef33b266943c040219529f64ea8cd29c8c9bf83 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2090394 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Jonah Ryan-Davis 90a8af38 2020-03-05T13:48:47 Add -rpath entries for non-component builds on Mac Mac was unable to find libvulkan.dylib because non-component builds do not contain these rpath entries. Bug: angleproject:4455 Change-Id: I7a3c452bd3b32c34b33c75b1456f9efa0d77a4ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2090331 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Jonah Ryan-Davis d6448538 2020-03-09T12:49:32 Relax GL_DEPTH_COMPONENT32_OES format support rules On iOS, GL_OES_depth_texture is supported, which includes the format GL_DEPTH_COMPONENT32_OES. However, GL_OES_depth32 is not always exposed. This is causing ANGLE to not expose GL_OES_depth_texture, and GL_ANGLE_depth_texture. Bug: angleproject:4451 Change-Id: If9cd782e851e040b1cf24a763dd93e063ebffbc7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2095361 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll d0748eb0 2020-03-11T07:01:34 Roll third_party/vulkan-validation-layers/src 014968c3b6b3..2ff8b6a6f4d5 (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/014968c3b6b3..2ff8b6a6f4d5 git log 014968c3b6b3..2ff8b6a6f4d5 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 s.fricke@samsung.com layers: Add VUID for 01759 01760 01761 2020-03-10 s.fricke@samsung.com tests: Add VkMemoryDedicatedAllocateInfo VUIDs 2020-03-10 s.fricke@samsung.com layers: Add VkMemoryDedicatedAllocateInfo VUIDs 2020-03-10 petr_kraus@email.cz tests: Update VkResult strings Created with: gclient setdep -r third_party/vulkan-validation-layers/src@2ff8b6a6f4d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I87f8a04e5531c572a35be00deb5a6f119d4ecbf3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2097915 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 45c53980 2020-03-11T07:01:41 Roll third_party/SwiftShader 8be72df60462..16ae92a4ee52 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/8be72df60462..16ae92a4ee52 git log 8be72df60462..16ae92a4ee52 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 amaiorano@google.com Subzero: fix Call on bool-returning functions Created with: gclient setdep -r third_party/SwiftShader@16ae92a4ee52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I816d440e9d5aa464efc39f6b4f240f99d1d2db1b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2097916 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0a4b0da5 2020-03-11T07:01:47 Roll third_party/glslang/src 343d4f6f1870..e2176c91b23c (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/343d4f6f1870..e2176c91b23c Created with: gclient setdep -r third_party/glslang/src@e2176c91b23c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I66fdbbd0052ca4893eab0d5e99c1da094fe0a12c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2097917 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
jchen10 1b12f6e5 2020-03-10T14:26:49 Remove MultisampleCompatibilityTest suppression The failed DrawCoverageAndResolve can pass on 26.20.100.7323 now. Bug: angleproject:3855 Change-Id: Ia6eb9fef2a57f0bdf52cb2e45c138457f5de88aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096230 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
Charlie Lao c5b3cbdb 2020-03-09T16:58:37 Vulkan: Use VK_FORMAT_D24_UNORM_S8_UINT for 24 bit depth if available And if the format we picked has extra bits, try to clear it instead of load the value. Don't store these extra bits as values as well. Bug: angleproject:4459 Change-Id: If5d0e31aca1453deab970d0dbcf8886a5e6ed51c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2095850 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Tobin Ehlis <tobine@google.com>
Takuto Ikuta 05710d54 2020-03-11T07:08:35 use go swarming client in trigger.py python client is being deprecated. Tested by $ python third_party/angle/scripts/trigger.py --shards=2 -p chromium.tests out/Release base_unittests Ubuntu none Fixed: chromium:1047115 Change-Id: Id653e2b29e8bf02ab86eaa4c5c767d081fa29dbd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2095654 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Rafael Cintron 9e263aa8 2020-03-06T17:41:30 Enable allowClearForRobustResourceInit for NVidia hardware Intel and AMD drivers have trouble clearing textures without causing corruption. NVidia, on the other hand, can handle. Bug: angleproject:1074 Change-Id: Id9d293eba92f80e2af3a0d2e40cbeccb127763b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2092838 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
angle-autoroll 4f10b113 2020-03-10T07:01:46 Roll third_party/glslang/src 6861ea4e10a1..343d4f6f1870 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6861ea4e10a1..343d4f6f1870 Created with: gclient setdep -r third_party/glslang/src@343d4f6f1870 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I625957e125e9bc45a44a0fd95a86efceaa134e25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096202 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 03b6ca69 2020-03-10T07:01:34 Roll third_party/vulkan-validation-layers/src 97484d689869..014968c3b6b3 (11 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/97484d689869..014968c3b6b3 git log 97484d689869..014968c3b6b3 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 mark@lunarg.com tests: Rename debug report callback function 2020-03-09 mark@lunarg.com tests: Remove old InitFramework function 2020-03-09 mark@lunarg.com tests: Use newer InitFramework function 2020-03-09 mark@lunarg.com tests: Add structure to use platform-specific debug callbacks 2020-03-09 mark@lunarg.com tests: Skip checking debugutils ext in framework 2020-03-09 mark@lunarg.com tests: Add utils messenger callback function 2020-03-09 mark@lunarg.com tests: Renable tests needing layer-only extensions 2020-03-09 mark@lunarg.com tests: Fix VUID typo in CreatePipelineAttribBindingConflict 2020-03-09 mark@lunarg.com layers: Add utils message type helper 2020-03-09 mark@lunarg.com tests: Use correct VUID for deprecated device exts 2020-03-09 jeremy@lunarg.com tests: Test array dynamic indexing features Created with: gclient setdep -r third_party/vulkan-validation-layers/src@014968c3b6b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I9e8339088ba26c9ecd382b3a44185c463e014c58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096200 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll e18f749d 2020-03-10T07:01:41 Roll third_party/SwiftShader b44162fdbb25..8be72df60462 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/b44162fdbb25..8be72df60462 git log b44162fdbb25..8be72df60462 --date=short --first-parent --format='%ad %ae %s' 2020-03-09 swiftshader.regress@gmail.com Regres: Update test lists @ b44162fd Created with: gclient setdep -r third_party/SwiftShader@8be72df60462 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I00ff324d0ca1307fb7de60259dbc10fc5a3b2186 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096201 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 25ccd786 2020-03-10T07:01:56 Roll third_party/spirv-tools/src 4c027048d88b..dd3d91691f1e (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4c027048d88b..dd3d91691f1e Created with: gclient setdep -r third_party/spirv-tools/src@dd3d91691f1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I2b789076094a718893e88de8b773e43ccb06470b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2096203 Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
shrekshao abcc536b 2020-03-09T13:20:53 Speculative fix for nullptr program in QueryProgramiv It is reported that an increase crash rate is seen on M81. This is a speculative fix based on that most crashes have calls from GrGLProgramBuilder::checkLinkStatus. Bug: chromium:991020 Change-Id: I549de9e0a0cccde8b9c68d706828963fe3f9bdf2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2095596 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com>
Jamie Madill 5d7ccc30 2020-03-09T14:24:30 Revert "Vulkan: Fix store ops with linear command recording." This reverts commit a61e273ac3ca88cb95b7bebac0d31a62644049a0. Reason for revert: Causes rendering artifacts in "Aztec Ruins". Bug: angleproject:4444 Original change's description: > Vulkan: Fix store ops with linear command recording. > > DiscardFramebuffer was being ignored in the new linear path. Fix this > by using the correct APIs. Also cleans up some of the access to the > "RenderPassCommandBuffer" struct in ContextVk. Add a new accessor that > returns the RenderPass without a flush that ensures it is only called > when a RenderPass is already started. > > Bug: angleproject:4029 > Change-Id: Ibd199f3a371c0f91b448a0b34c8752dc8b76c284 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057329 > Reviewed-by: Charlie Lao <cclao@google.com> > Commit-Queue: Jamie Madill <jmadill@chromium.org> TBR=tobine@google.com,jmadill@chromium.org,cclao@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:4029 Change-Id: I7d925b88c438a20ebe4a48634568addda7a64d60 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2093157 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tobin Ehlis <tobine@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Brandon Schade a8c947c7 2020-02-06T08:53:16 Enabled GL_KHR_no_error Enabled GL_KHR_no_error added end2end tests for it Note that GL_KHR_no_error can only be enabled by setting the EGL attribute currently. Context flags are not currently supported. Bug: angleproject:1280 Test: angle_end2end_tests --gtest_filter=ContextNoErrorTest.* Change-Id: Ib5c73b8e284e3e4e5f800750ad6fcbef77be4285 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068899 Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Takuto Ikuta 0837bf75 2020-03-09T18:56:19 use go isolate client in trigger.py python client is being deprecated. I will switch swarming client later. Tested by ~/chromium/src$ python third_party/angle/scripts/trigger.py -p chromium.tests out/Release base_unittests Ubuntu none Bug: chromium:1047115 Change-Id: Ibad2bf5ab80b09aadfcd0431fea8c5e97d38655d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2095035 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Geoff Lang c2d81731 2020-03-09T15:14:23 Allow referencing buganizer issues with ANGLE CLs. Based on http://google3/experimental/users/jsharkey/gitwatcher2/configs.py?l=42&rcl=299145346, chromium CLs with b: should be found by buganizer. BUG=b:151095080 Change-Id: Iaf4def18dbe52fe87c9e4655f114fac225d429ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2095595 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Geoff Lang 71903912 2020-03-06T16:12:17 Generate arch-specific defines in Android.bp ANGLE has a ANGLE_IS_32/64_BIT_CPU define that is based on the gn arg for "target_cpu". Don't emit this define as is from the gn desc, move it to an architecture-specific section of the generated blueprint. BUG=angleproject:2344 Change-Id: Ib6387d5f31b30900b5d3195da6d9b21c48e1e2a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2090393 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Geoff Lang 8414d962 2020-03-06T13:17:19 Improve GN args for generating Android rolls. - Disable unused backends and shader compilation targets. - Build for "arm64" to make sure ANGLE_64_BIT_CPU is defined. - Use a better merge command now that the branch histories are related BUG=angleproject:2344 Change-Id: I33949e701379caacf6a392a3bb0eb3523627be14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2090685 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0