kc3-lang/angle

Log

Author Commit Date CI Message
John Plate df657c96 2021-04-29T11:22:03 Disable OpenCL support for Windows UWP CI builds Bug: angleproject:5908 Change-Id: I451e232e545248ff9755cc3f2a4907b8af2fdc2c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859742 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: John Plate <jplate@google.com>
Jamie Madill a29ab50f 2021-04-29T11:22:03 infra: Add isolate server properties. These are necessary to work correctly with swarming. Bug: angleproject:5114 Change-Id: I634e408e523284a935b77f62b95c9bc85e9e997f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859982 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill a8d98f7a 2021-04-29T11:32:37 infra: Update mixins. The Mac mixins were updated. Ideally we could do this automatically on Chromium rolls. Bug: angleproject:5114 Change-Id: I412e227193e7a6503c04dee5df6bb2a4cf1cc1f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2857597 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny 422ec18a 2021-04-26T10:40:04 tests: Move DrawAfterFlushWithNoStateChange to ES3 The test uses Vertex Array Objects, and these are only supported from GLES 3.0 on, or by using the extension OES_vertex_array_object, so make it part of the StateChangeTestES3 set. With that we also enable the test. Bug: angleproject:5855 Change-Id: I0cfb5d23d19e3db8eefffd9d52b744d068666606 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2850642 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny 078a2ba6 2021-04-19T11:52:38 Capture/Replay: Print capture and replay exe in verbose mode When running the test script to capture and replay it is helpful to know the locations of the executables that are run to make it simpler to locate them for debugging. Bug: None Change-Id: Ia43bd9863e94058515d9023981863ad6c711285e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2850640 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 1da30524 2021-04-29T10:01:41 Roll SwiftShader from 112faf441539 to 484a3e15893c (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/112faf441539..484a3e15893c 2021-04-28 sugoi@google.com Silence warning for MacOS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ic9f3324373ebb26930fce0a70eab176aae09adbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859305 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 201f161b 2021-04-29T07:00:21 Roll Chromium from 06f7f05a5f4a to 5feb27ec9892 (428 revisions) https://chromium.googlesource.com/chromium/src.git/+log/06f7f05a5f4a..5feb27ec9892 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/94367a1d14..32281a3e42 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f6a8e55d6e..5f51521620 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5f9242e282..a660a95e6f * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/a26b882fc4..09a1a83d2f * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/a27b4d3b82..c3565d6e1f * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d738a9c39a..db2bba848d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..70ce64f463 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b3c9edb4af..3a56ba9d9c * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/7b4981b650..24e310554f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/91e097a7c7..7247aa6f40 * tools/skia_goldctl/linux: E6CrCAKZ_DKxclAqgBcEt4adU3HaviUwN42S1t3rW5QC..tB-aCGPgfoZoJkUY-FwC5e0McBlS1VYtKsDpf5G42GUC * tools/skia_goldctl/mac: RTGs3s-N45d3AzDXnEKw3kbI0qf8xyS_JYMHo4iRCMIC..010YBDimThQHTBULjf4bYMXghL37h6xogw08_Ij5RrMC * tools/skia_goldctl/win: XXJR8g1yaihqXsw7WodVpgLtZsimS7Cc3yLJI9sJssgC..PtSSNrSR0okAf8Q4RMYxK1dSmKxaw9jqoyxdNvNzOqwC No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: Ic6f6d13e33d9d70ba856b8444a3107a1d00ebdfb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2858285 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Charlie Lao a766ab14 2021-04-20T09:29:29 Vulkan: minimize-gpu-work: Use 1x1 offscreen When minimize-gpu-work is requested, the idea is to have GPU work reduced to minimum. Without shrink the offscreen window to 1x1, the driver load/store op may still have to load entire surface which could be costly. This CL reduces the offscreen surface size to 1x1 when --minimize-gpu-work is specified. Bug: b/184766477 Change-Id: Ic8d9d4c2fe8295a0a5808dcee35120fdd20e0f56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2840963 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill ccc0fbaa 2021-03-24T17:56:38 Vulkan: Related fixes for buffer descriptor set cache. Includes some stats counter gathering and a few related refactors and cleanups. Also includes a new overlay widget. Bug: angleproject:5736 Change-Id: Ida8d2cd815c5b598c6a442dd9bbfdf51e9c05180 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785431 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Jonah Ryan-Davis d7859d98 2021-04-28T14:43:16 Remove -raw-cmd from scripts/trigger.py swarming call It looks like this argument doesn't exist anymore. Removing it from the swarming call works fine. Bug: angleproject:5915 Change-Id: I510ef79ae5a540742c3f08c8daa0a14d59d2e60d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2855040 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Alexey Knyazev 53b89b83 2021-04-24T13:26:02 Metal: Add ASTC HDR support ASTC HDR is a superset of ASTC LDR, so always use HDR enums on supported platforms because there is no such difference in OpenGL ES. Bug: angleproject:2634, angleproject:5672 Change-Id: I19a3212bcb949aa9cdeb682ab000aa03125f04a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848509 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Jamie Madill 3b2ef1cd 2021-04-07T20:17:53 Change perf_test_runner to accept extra args. Bug: angleproject:5736 Change-Id: Ic6046c0b8c5ba9bc2f3bffda2c36eaceb24491ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2855601 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop 61288549 2021-04-27T17:42:21 Vulkan: Turn on cubemap arrays for Qualcomm The feature works on Pixel 3 and later, so only disable it on Pixel 2. Bug: angleproject:5143 Change-Id: I824fc9ea71cb612fd99e23b7f37a1a3c278d92aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2855218 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Charlie Lao 939dc8d9 2021-04-21T18:33:00 Vulkan: minimize-gpu-work: Skip synchronization for glMapBufferRange glMapBufferRange call requires CPU and GPU synchronization. Different drivers implement this differently. Some may choose to keep multiple copies of data to reduce the synchronization overhead while others may choose to wait for GPU access to finish to save memory. While this behavior is important, it should be looked under the scope of overall game performance and we can write a standalone test for this. When --minimize-gpu-work is specified, we mainly care about CPU overhead of driver logic of state tracking. For this purpose, we should get this out of picture in order to expose the true picture of what we intended to see. This CL always adds GL_MAP_UNSYNCHRONIZED_BIT to the access bit to avoid driver to do synchronization or make COW. Bug: b/184766477 Change-Id: I36228a4ed9913e26aa9ad4e8446fb42ee0182c18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2847101 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Tim Van Patten 7444466c 2021-04-19T18:44:13 Reland "Capture/Replay: Reset GL Fence Sync objects" This is a reland of 9b4fd5456e3cc8c5412af96212d2840b422208b5 This fixes the original CL by moving where setCaptureActive() is called to allow the first replay source file to be written. Original change's description: > Capture/Replay: Reset GL Fence Sync objects > > Asphalt 9 uses GL Fence Sync objects during rendering, which results in > Fence Sync objects being created during setup and deleted while > replaying frames. When the replay is restarted, the Fence Sync objects > that were created during setup and deleted during the replay need to be > recreated during the reset phase. > > Bug: angleproject:5883 > Bug: angleproject:4599 > Change-Id: I118f2b7208c4d512ab646b10f52b3a0936895089 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2838237 > Commit-Queue: Tim Van Patten <timvp@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5883 Bug: angleproject:4599 Bug: angleproject:5900 Change-Id: I5e1d901d8875007691699b7b973f3fb7db027337 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2850758 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
angle-autoroll dcfd5526 2021-04-28T07:01:11 Roll Chromium from 398f0c392ac5 to 06f7f05a5f4a (465 revisions) https://chromium.googlesource.com/chromium/src.git/+log/398f0c392ac5..06f7f05a5f4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6273d81b0c..94367a1d14 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f71816594a..5f9242e282 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/79b2765902..d738a9c39a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c5554ea0ab * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c91f5f62e2..b3c9edb4af * tools/luci-go: git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155 * tools/luci-go: git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155 * tools/luci-go: git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3e7b3b8ccc..91e097a7c7 * tools/skia_goldctl/linux: bNvl5eveNZJzFEWnXEt_ohXLbBA8BSt78S5aHS7rNYMC..E6CrCAKZ_DKxclAqgBcEt4adU3HaviUwN42S1t3rW5QC * tools/skia_goldctl/mac: jWn1_ogilSNdcmHMkXsZTdw5bQ-IDoQ3IifWt1TDv6sC..RTGs3s-N45d3AzDXnEKw3kbI0qf8xyS_JYMHo4iRCMIC * tools/skia_goldctl/win: dP2sgrA7eRtFoLWGRjvQQ4YXhGlwKqsCiqPqPQuY1OgC..XXJR8g1yaihqXsw7WodVpgLtZsimS7Cc3yLJI9sJssgC No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: I315893b34682bf861573d2d3e6378004b29342af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2856314 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill ed8755df 2021-04-27T21:33:04 Revert "infra: Add different builder group from ci/try." This reverts commit 281b12d2e54cf9526bdb6e2610f8cdc28285f2a9. Reason for revert: Broke bots. Original change's description: > infra: Add different builder group from ci/try. > > Uses the 'client.angle' and 'tryserver.angle' naming scheme that > both V8 and WebRTC use. Necessary for the scripts to work with > swarming tests. > > Bug: angleproject:5114 > Change-Id: I107cf0018e2173117e1d90e840b8e1419e69ef55 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854277 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5114 Change-Id: I2501f3ad89bc21d80ccdeabd52234a1fc5b39a49 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2855594 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 281b12d2 2021-04-27T15:23:02 infra: Add different builder group from ci/try. Uses the 'client.angle' and 'tryserver.angle' naming scheme that both V8 and WebRTC use. Necessary for the scripts to work with swarming tests. Bug: angleproject:5114 Change-Id: I107cf0018e2173117e1d90e840b8e1419e69ef55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854277 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Alexis Hetu c02d5f12 2021-04-27T13:45:05 Fix using VK_EXT_provoking_vertex with VVL Vulkan Validation Layers (VVL) automatically rejects and removes any unknown pNext pointer in an pNext chain submitted to the driver. For this purpose, a mechanism was introduced by VVL in order to allow ANGLE to allow some of our custom pNext entries to go through VVL without being removed. This had been used for only 1 of the 3 entries in the VK_EXT_provoking_vertex extension, causing it to be properly exposed, but impossible to use. This CL corrects this by adding the missing entries. Bug: angleproject:5902 Change-Id: If6478b3aa776513b92420736fa1216b014320b02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854815 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Jamie Madill 6505a768 2021-04-27T10:51:46 infra: Switch Android builders to compile-only. Initially testing will only be on desktop. Bug: angleproject:5114 Change-Id: I384e4f81cee3a810fad42e73711862725e786ef2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854276 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Charlie Lao 7b77dc5b 2021-04-22T09:58:33 Vulkan: minimize-gpu-work: Skip data copy when possible When --minimize-gpu-work is specified while replaying app traces, the goal is to avoid any GPU work when possible and focus on driver cpu logic overhead. Data copy can be lengthy and each driver optimize it differently for some real world usage scenario. This should be looked along with normal app trace playback performance. When --minimize-gpu-work is specified, we want to leave this out of picture. Previously I have fixed TexImage2D by overwriting pixel pointer with null. But there is a hole here when PBO is used. This CL fix the case that when data is sourced from PBO, we ensure to skip data copy as well. This CL also noops TexSubImage call instead of doing 1x1 copy. Again depends on driver implementation, some may use CPU others use GPU which will have different overhead. We can easily write a test to cover these performance optimizations. By skipping the subImage call here we will have less noise to deal with for CPU overhead investigation. Bug: b/184766477 Change-Id: I84a5d26d2f25f8f0a6c5c9da72737906d6356a53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2847100 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
John Plate 16a919b1 2021-04-27T11:36:11 Add stubs for CL platform layer back ends Bug: angleproject:5904 Change-Id: If23c7f76013a17c3c67c13194566438035beb3d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2853582 Commit-Queue: John Plate <jplate@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill be7049d7 2021-04-20T10:03:33 Vulkan: Redesign buffer descriptor set cache key. Instead of writing the bitset masks, iterate up until the last active buffer. Write zeros instead of skipping spaces. This is a bit simpler to implement and also fixes a bug where empty buffers could cause us to write invalid handles. Bug: angleproject:5736 Change-Id: I785ef18ef5ae45109ec7d6e0b079b79a9984a1f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2837848 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
John Plate cddb2003 2021-04-23T18:26:51 Stubs for CL validation entry points Bug: angleproject:5775 Change-Id: Ic3b15efdf602bad8f5f170f03ba24b421a398ca8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848504 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: John Plate <jplate@google.com>
angle-autoroll e1201106 2021-04-27T14:38:26 Roll vulkan-deps from 68b78a05fea2 to 42d8716d0294 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/68b78a05fea2..42d8716d0294 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/bbcef69a45..c624d5387c * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f3c1d9e78e..d0f1abe22e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d15a2436f6..f6b4a3dea4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com,ynovikov@google.com Change-Id: I9e9915f535df93ef0428d63d301225982c29b55c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854414 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Peng Huang 19f24ede 2021-04-26T18:05:31 Disable workderContext on Android Bug: chromium:1202928 Change-Id: I54c4c28c30714fea60b4b6f3dd3ec49101341602 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2851362 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Jamie Madill 7c53d6af 2021-04-26T15:20:27 infra: Auto-generate mixins.pyl. The generate_test_spec_json.py file now reads ANGLE's waterfalls.pyl and Chromium's mixins.pyl to find the referenced mixins and copy them into ANGLE's mixins.pyl. This way we can update ANGLE's mixins easily without needing to manually copy them from Chromium's. In a follow-up we could make this run on the Chromium auto-roller. Bug: angleproject:5114 Change-Id: I332b3182732985b261e107dfe9a5c7c413c410a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2849184 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 904ac340 2021-04-26T15:54:25 Bug fix for WaitClient, WaitGL and WaitNative It is valid to call eglWaitClient, eglWaitGL and eglWaitNative when there is no active context in the current thread. Update code to account for that possibility. Bug: angleproject:5898 Test: EGLSyncTest.WaitClient* EGLSyncTest.WaitGL* EGLSyncTest.WaitNative* Change-Id: I81f05a27f1f641cf8986e2e6c05c183ea8471889 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2849587 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
angle-autoroll 8abb778c 2021-04-27T07:05:49 Roll Chromium from cf8ffbca555e to 398f0c392ac5 (758 revisions) https://chromium.googlesource.com/chromium/src.git/+log/cf8ffbca555e..398f0c392ac5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/eae219f9f1..6273d81b0c * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/2f2a4e507a..f6a8e55d6e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cbf481cd42..f71816594a * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e0c163da44..79b2765902 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..00b0b51faf * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/61bf6e8d69..c91f5f62e2 * third_party/r8: h1H8tuKYpnoPW2uwLMSaHgD_vVy9_8E6n4UZ5nwbMRkC..9JovxpDv8ZqFl60_eHo4hT-Ez0CelcMCoM9Cv5UJMz4C * tools/luci-go: git_revision:7ad561e001cdb13c858e065ef0bb3019aae49601..git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f * tools/luci-go: git_revision:7ad561e001cdb13c858e065ef0bb3019aae49601..git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f * tools/luci-go: git_revision:7ad561e001cdb13c858e065ef0bb3019aae49601..git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/65be412188..3e7b3b8ccc * tools/skia_goldctl/linux: wdKjv3Lrszkb_s1AF7ZwLf9Og7Y8qk_EIZ6aoNICu0YC..bNvl5eveNZJzFEWnXEt_ohXLbBA8BSt78S5aHS7rNYMC * tools/skia_goldctl/mac: oMHIiIQ0wBDzq1EgmQYV6nFbvCXgLdD0Qyxv_zFy1OsC..jWn1_ogilSNdcmHMkXsZTdw5bQ-IDoQ3IifWt1TDv6sC * tools/skia_goldctl/win: NA-h9VX5yFfBNYZKxKG479VVjEz3iJQ9jhSXBG0Lk1gC..dP2sgrA7eRtFoLWGRjvQQ4YXhGlwKqsCiqPqPQuY1OgC No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: Id865d18480e8c8cc40176cd0f734c745c92a5a8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2853275 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Stephen White d6a91dab 2021-04-26T10:44:09 D3D11: update docs (remove SSBO limitation). Bug: angleproject:5734 Change-Id: Ia1af247b45ad51072296f8d197dd4b49526417ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2851177 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
Josip Sokcevic cbfa28a0 2021-04-26T14:44:52 Add CQ for main branch Bug: 1203009 Change-Id: I3c7745531cca659901be05f7c7c3c89ba8350096 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2851902 Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi cd4a63f5 2021-04-26T11:52:02 Vulkan: Fix ASSERT in CreateRenderPass2 RenderPass2 was used for when a depth/stencil attachment is needed, or the VK_EXT_multisampled_render_to_single_sampled extension. The logic that decided this was "has D/S resolve || has MSRTSS extension", but the function itself asserted that the render pass is using MSRTSS if not D/S resolve. This caused an assertion failure on platforms where MSRTSS is present, but a non-MSRTSS render pass is used. Bug: chromium:1201455 Change-Id: Iefd26a071303c703a322d946f82474f85f5bf767 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2849180 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 1bdd34ff 2021-04-26T09:04:59 infra: Add test specs for standalone tests. Includes test specs for Linux/Mac/Win7/Win10. Android is left out for a second pass to keep the changes a bit simpler. Bug: angleproject:5114 Change-Id: I94e7f7f273073f85488ec982e89b4b68f45627ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2805371 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Mohan Maiya 61167d52 2021-04-24T09:50:31 Add EXT_primitive_bounding_box entry points Addition of the entry points for GL_EXT_primitive_bounding_box extension. Bug: angleproject:5896 Change-Id: I0dce407d2826ce3f730125d7c03f1233420f6780 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2849615 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Mohan Maiya 84b31c03 2021-04-25T08:30:14 Vulkan: Fix bug in VkImageFormatListCreateInfoKHR On some vendors VVL throws the following error, snippet only - [ VUID-VkImageViewCreateInfo-pNext-01585 ] Validation Error ... image was created with a VkImageFormatListCreateInfo in pNext of vkImageCreateInfo, but none of the formats match the VkImageViewCreateInfo::format ... The Vulkan spec states: If a VkImageFormatListCreateInfo structure was included in the pNext chain of the VkImageCreateInfo structure used when creating image and VkImageFormatListCreateInfo::viewFormatCount is not zero then format must be one of the formats in VkImageFormatListCreateInfo::pViewFormats. It looks like VkImageFormatListCreateInfoKHR::pViewFormats needs to contain all formats including the format of the VkImage itself. Bug: angleproject:5281 Change-Id: I93c6900d99791ef4f9f116cb114f068e0a318bf4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2849566 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Jamie Madill 3839fa5b 2021-04-26T13:08:15 Revert "Capture/Replay: Reset GL Fence Sync objects" This reverts commit 9b4fd5456e3cc8c5412af96212d2840b422208b5. Reason for revert: Breaks capture: INFO:root:Passed: 0, Comparison Failed: 0, Crashed: 0, CompileFailed 0, Skipped: 745, Timeout: 0 Bug: angleproject:5900 Original change's description: > Capture/Replay: Reset GL Fence Sync objects > > Asphalt 9 uses GL Fence Sync objects during rendering, which results in > Fence Sync objects being created during setup and deleted while > replaying frames. When the replay is restarted, the Fence Sync objects > that were created during setup and deleted during the replay need to be > recreated during the reset phase. > > Bug: angleproject:5883 > Bug: angleproject:4599 > Change-Id: I118f2b7208c4d512ab646b10f52b3a0936895089 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2838237 > Commit-Queue: Tim Van Patten <timvp@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5883 Bug: angleproject:4599 Change-Id: I56c682e1d90dcdde7b18c941aad976825de3af42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2851057 Reviewed-by: Jamie Madill <jmadill@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop a25f21ee 2021-04-25T19:54:32 Tests: Add Candy Crush Soda Saga trace Test: angle_perftests --gtest_filter="*candy_crush_soda_saga*" Tbr: jmadill@google.com,timvp@google.com Bug: b/186362192 Change-Id: I9a1f9663541e3b97d437a1803e8fe079a5dbd2b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846187 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 3182095f 2021-04-23T17:51:23 Tests: Add Higgs Domino Island trace Test: angle_perftests --gtest_filter="*higgs_domino_island*" Tbr: jmadill@google.com,timvp@google.com Bug: b/186267543 Change-Id: Ic7154337724b075bcad1367a24ae7ebeaf65ce6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848133 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Alexey Knyazev 8df3e5f2 2021-04-23T12:39:06 Metal: update format caps Added MTLGPUFamilyApple6 and MTLGPUFamilyApple7 caps. Bug: angleproject:2634, angleproject:5672 Change-Id: Icc35f823cdd018246a8ac3b1179adc81584fb204 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846832 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Tim Van Patten 9b4fd545 2021-04-19T18:44:13 Capture/Replay: Reset GL Fence Sync objects Asphalt 9 uses GL Fence Sync objects during rendering, which results in Fence Sync objects being created during setup and deleted while replaying frames. When the replay is restarted, the Fence Sync objects that were created during setup and deleted during the replay need to be recreated during the reset phase. Bug: angleproject:5883 Bug: angleproject:4599 Change-Id: I118f2b7208c4d512ab646b10f52b3a0936895089 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2838237 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
John Plate 9acfccbd 2021-04-23T21:59:57 Disable OpenCL support by default Bug: angleproject:5892 Change-Id: I99d4c0e450e469f911abc05fbe1e714190e16900 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848508 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: John Plate <jplate@google.com>
John Plate ea76c5ad 2021-04-23T13:37:20 Add scrict type checking for reinterpret_cast Bug: angleproject:5891 Change-Id: I4077fea7fde91465fa71df843c313c4dd8e31e0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846835 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: John Plate <jplate@google.com>
Cody Northrop 7a161a56 2021-04-23T13:54:18 Tests: Add Gardenscapes trace Test: angle_perftests --gtest_filter="*gardenscapes*" Tbr: jmadill@google.com,timvp@google.com Bug: b/186246356 Change-Id: Ie9395080ce1947b633b16c807aecbd52cb31c990 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2847984 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuly Novikov d824908f 2021-04-23T16:31:44 Increase kMaxExtensionNames https://github.com/KhronosGroup/Vulkan-Tools/pull/502 adds new extensions, so 200 is no longer enough. Bumping up to 400. Bug: chromium:1201987 Change-Id: Icbad7637649c2236a8c46e577c1c0bd0dbccd633 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848487 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 2a403f91 2021-04-23T15:29:31 infra: Set MSVC builders to compile-only. We want to preserve the current test set without accidentally enabling new testinig paths with infra changes. Current MSVC is supported as compile-only. Bug: angleproject:5114 Change-Id: Iffc4ac3f7dc3845e5d767fdcdbfa9d5fac27f371 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848646 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop 7caff9d8 2021-04-23T09:05:34 Tests: Add Homescapes trace Test: angle_perftests --gtest_filter="*homescapes*" Tbr: timvp@google.com,jmadill@google.com Bug: b/186215022 Change-Id: I83949d4a5450d512d010b2d91c45da618fae0aac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848127 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill 9d202af0 2021-04-23T18:24:46 Revert "Remove 'six' from roll_chromium_deps." This reverts commit 95e75ec86ff3b84751b201dabb1362be68bac798. Reason for revert: Tree is fixed upstream. Original change's description: > Remove 'six' from roll_chromium_deps. > > This dep was causing the script to fail. It may be because the repo > currently has a single commit. Work around this by removing the > entry from the auto-roller for now. > > Bug: angleproject:2344 > Change-Id: Id4f61124aae7ab43aa2343faf19416ff676314d7 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842224 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:2344 Change-Id: I0b41b2821a19c8dfc1f248ea61db866934af27e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848643 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 53a0cedf 2021-04-23T17:25:26 Roll Chromium from 953728c7e200 to cf8ffbca555e (681 revisions) https://chromium.googlesource.com/chromium/src.git/+log/953728c7e200..cf8ffbca555e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b0f84425e3..eae219f9f1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/00edc76626..cbf481cd42 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/10b50b69d8..a26b882fc4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9cf09f1e1b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/447e0b72df..61bf6e8d69 * third_party/r8: wupRO-hEg2hxgKU9FC5HKY88dMpfEpdimjxcgekXH8oC..h1H8tuKYpnoPW2uwLMSaHgD_vVy9_8E6n4UZ5nwbMRkC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7a6a1f2ea2..ba668f13d1 * tools/luci-go: git_revision:e7e8e7aea55bc50729ec835604b2a00e6e668afe..git_revision:7ad561e001cdb13c858e065ef0bb3019aae49601 * tools/luci-go: git_revision:e7e8e7aea55bc50729ec835604b2a00e6e668afe..git_revision:7ad561e001cdb13c858e065ef0bb3019aae49601 * tools/luci-go: git_revision:e7e8e7aea55bc50729ec835604b2a00e6e668afe..git_revision:7ad561e001cdb13c858e065ef0bb3019aae49601 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/01b9d7ae3d..65be412188 * tools/skia_goldctl/linux: R23Oztsyro8ca7QGaNGKjN7duf5fsN6I6Dq2Nwyh2YQC..wdKjv3Lrszkb_s1AF7ZwLf9Og7Y8qk_EIZ6aoNICu0YC * tools/skia_goldctl/mac: Ipkmq4bl5d7VmPVlEonzZMPLnHxMr-LaDFi8Dz_r8-8C..oMHIiIQ0wBDzq1EgmQYV6nFbvCXgLdD0Qyxv_zFy1OsC * tools/skia_goldctl/win: QCamcihHhiASX-AasohPdhiBOtj0ikJ3fUByIMEfrEIC..NA-h9VX5yFfBNYZKxKG479VVjEz3iJQ9jhSXBG0Lk1gC No update to Clang. Bug: angleproject:5841 Tbr: ynovikov@google.com Change-Id: If264d13dcb1e43adc7e6c2d44b8ebc90fca712f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848112 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 403119c6 2021-04-23T18:24:03 Revert "Temporarily remove 'errorprone_plugin' from roll_chromium_deps." This reverts commit 96df9aba3387373002814103b798aa22a6f4c51a. Reason for revert: Upstream fix landed. Original change's description: > Temporarily remove 'errorprone_plugin' from roll_chromium_deps. > > This dep was causing the script to fail because it doesn't have HEAD. > > Bug: angleproject:5887 > Change-Id: Ib6daabfe2e0b105137784ceb80d4147f0eb71f41 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848640 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: angleproject:5887 Change-Id: Ie31e4c998ce15937086ba9c4d589e0995232ab79 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848642 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 2aa68eba 2021-04-20T10:37:45 Vulkan: Update unsized array error Update the error condition to reflect actual usecase - an unsized array is declared in a shader other than tessellation shader. Bug: angleproject:5557 Test: KHR-GLES32.core.texture_cube_map_array.texture_size_tesselation_con_sh Change-Id: I3547f52a26a5c450ac7b6df65d026c3c38f7c71d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2823576 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 96df9aba 2021-04-23T12:52:30 Temporarily remove 'errorprone_plugin' from roll_chromium_deps. This dep was causing the script to fail because it doesn't have HEAD. Bug: angleproject:5887 Change-Id: Ib6daabfe2e0b105137784ceb80d4147f0eb71f41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848640 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Hans Wennborg 9064bdf7 2021-04-23T15:19:42 [build] Turn off -Wdeprecated-copy warnings It fires with newer versions of Clang (see bug). Bug: chromium:1201858 Change-Id: Ie55b39a0422a5f45b4eb6bdfcc77114e1ef554bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846836 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
Gert Wollny 3e1af85a 2021-04-19T18:12:30 Capture/Replay: Handle bindGeneratesResource in trace meta data Bug: angleproject:5844 Change-Id: I0243cab70b5833efd83b0d75a1801f68025ee291 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2835889 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Gert Wollny c1da2794 2021-04-19T11:49:41 Capture/Replay: Handle ClientArraysEnabled in trace meta data Bug: angleproject:5848 Change-Id: Ieba325e2b5efa3242b24cafa8363e562c258546c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2835888 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll fa269790 2021-04-23T10:01:36 Roll vulkan-deps from 706897cbbf31 to 68b78a05fea2 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/706897cbbf31..68b78a05fea2 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/25dd807c3a..18eef33bd7 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/94e19fe3d2..f3c1d9e78e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I59bbdd67010b5c7844b6088f6b8bf79319f6676c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848104 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d4c9e01c 2021-04-23T10:01:32 Roll SwiftShader from c597a8af03ef to 112faf441539 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/c597a8af03ef..112faf441539 2021-04-22 capn@google.com Format switch statements consistently If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ia37950e6d2e1ced57d70f8f94bdc642b5b866237 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848073 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 1800d1d9 2021-04-22T12:09:31 Tests: Add Ludo King trace Test: angle_perftests --gtest_filter="*ludo_king*" Tbr: jmadill@google.com,timvp@google.com Bug: b/186121782 Bug: angleproject:5888 Change-Id: I41cd5924c109e4d9448227c535a9fb92a5b52cb3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2845374 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 7b108b3d 2021-04-22T20:47:36 Roll vulkan-deps from e5bb9b56c292 to 706897cbbf31 (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e5bb9b56c292..706897cbbf31 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/60ce877de0..25dd807c3a * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/d137abeef5..bbcef69a45 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/dc72924cb3..22b82872b4 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/eb6d6f95df..94e19fe3d2 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/fd0e2b53a8..d15a2436f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I2dd09b7fe83193a03de8fded03c65eb759e3763b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2845377 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang da791e3e 2021-04-22T09:46:49 D3D11: Disable CompositorNativeWindow11 in Chromium builds. CompositorNativeWindow11's IsValidNativeWindow can only return true or crash. If a user passes in an invalid window handle, ANGLE's D3D11 backend will always crash. Ideally this window type would be exposed through an extension and the user passes in an enum telling ANGLE that the window is an ISpriteVisual instead of ANGLE trying to detect it from a void pointer. Bug: chromium:1176118 Change-Id: Ia7568adcd929dcd9200c7da2d0a991da55e1e89a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846800 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
John Plate 908ead38 2021-04-17T19:43:09 Updated OpenCL headers Bug: angleproject:5761 Change-Id: I45e0f9a422a0dd94fec854d3387f676192e020eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831303 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: John Plate <jplate@google.com>
John Plate e25f3b10 2021-04-21T21:43:46 Generate empty CL object classes Bug: angleproject:5886 Change-Id: I01566f40e85bd7f5531536fdc1df42965622a939 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2844969 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: John Plate <jplate@google.com>
Alexey Knyazev f2b47418 2021-04-22T18:32:37 Align BPTC format names in angle::FormatID Use the same naming convention as other similar formats. Bug: angleproject:5731 Change-Id: I187881f4bc4691a0963502ed41f42ab0ebf4171c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846824 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Geoff Lang ccd984ff 2021-04-08T12:06:57 Reland "Add a Vulkan feature to compress float32 vertex formats." This reverts commit 8ace36f8c15877264fb58af7b54baad635899dca. Original change's description: > Revert "Add a Vulkan feature to compress float32 vertex formats." > > Bug: b/167404532 > Bug: b/161716126 > Change-Id: I95157a006d5c1fd2d3c0c2c2be37fa0403c07f93 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2510011 > Reviewed-by: Tim Van Patten <timvp@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> Bug: b/167404532 Bug: b/161716126 Change-Id: Ic6811fe3a7124e6eb1efe7c72a1a03a120217753 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815260 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Jamie Madill d6302408 2021-04-21T17:16:34 Update standalone Android docs. Bug: angleproject:2344 Change-Id: Idea2f65fc92f2c59c5d4cd6ae01cae0b4af41905 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2845049 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill c9b8d61b 2021-04-21T21:08:44 Update Android-releated tools DEPS. Include the tools/android/errorprone_plugin mirror. This eliminates several cloned source files from ANGLE. Also include the Python tools/swarming_client for running tests. It seems like the tests depend on the logdog Python library available from this component. Bug: angleproject:2344 Change-Id: I70e011764c4443ab3904bfa0c9059f295f3817df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2845233 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 9fbe5c00 2021-04-22T07:03:10 Roll Chromium from 2e3165386670 to 953728c7e200 (354 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2e3165386670..953728c7e200 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9f81eec935..b0f84425e3 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/b8e67401d8..2f2a4e507a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f73b4bea19..00edc76626 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4b39857c2f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bc1f5c75f1..447e0b72df * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d5a5d84142..01b9d7ae3d No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I043a2ae197bc516133f747f14d33108fcb295147 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846135 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill e0e5eb84 2021-04-21T20:58:12 Fix ScanReverse on posix/32-bit. The use of the __builtin_clz intrinsic and the associated math were incorrect. Bug: angleproject:5736 Change-Id: I9627c7fc179c0e1bffeecaee39f7a88d9c62d079 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2845232 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Ian Elliott e167d453 2021-04-21T14:14:33 Vulkan: Allow logging with VVL and/or AGI debug utils to be used A recent change allowed logging API commands on Android to be used with Vulkan Validation Layers (VVL). That broke debug utils for AGI (i.e. when the ANGLE-built VVL is not being used). This allows both use cases to be supported. Bug: b/183133198 Change-Id: Ide83ed63fad99d0eca97998365276a1ef365a4e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842325 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 7740e434 2021-04-21T13:26:54 infra: Add Android builders to CQ by default. The build is now green and we can start testing this pre-commit. Bug: angleproject:2344 Change-Id: Icfa58f02727228468e422f4f596deb5c1e2dcfe1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842356 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill cfc21345 2021-04-21T09:42:51 Add first() and last() to BitSetArray. These helper functions return the bounds of the 1 bits in the array. Also required implementing ScanReverse the same way we implemented ScanForward. Bug: angleproject:5736 Change-Id: Ied945c57cd85ca7bc91dcc7a1168a74b3a59fce4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842347 Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 6297ccf3 2021-04-21T13:15:59 Replace ijar sources with Chromium subtree mirror. This will ensure a smoother update process. Bug: angleproject:2344 Change-Id: I81bf496ea013825588b1baa573855ce809a8decf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842355 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill f78927b0 2021-04-21T13:05:46 Remove libGLESv1_CM static. These entry points are already duplicated into libGLESv2. Including them in the static build causes a duplicate symbol error on Android. Bug: angleproject:2344 Change-Id: I56a2f2029e7da49215e64484c1d1316add6ff1c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842354 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 002e5622 2021-04-21T12:12:26 Android: Enable APK build. Bug: angleproject:2344 Change-Id: Iaad7199d2bcbb961d64f14eb640d472c52d7abc6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842564 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 598b6bbd 2021-04-21T14:12:48 Roll Chromium from 141612cc6143 to 2e3165386670 (489 revisions) https://chromium.googlesource.com/chromium/src.git/+log/141612cc6143..2e3165386670 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/bdd4e9dcbc..9f81eec935 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d0f33885a2..b8e67401d8 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d364fd2e43..f73b4bea19 * third_party/android_ndk: https://chromium.googlesource.com/android_ndk.git/+log/27c0a8d090..401019bf85 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..da84ecd433 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/93d80d8686..bc1f5c75f1 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d7dd881ddc..7a6a1f2ea2 * tools/luci-go: git_revision:0f913477afc80d5c4b6609834d3bef6b44910e67..git_revision:e7e8e7aea55bc50729ec835604b2a00e6e668afe * tools/luci-go: git_revision:0f913477afc80d5c4b6609834d3bef6b44910e67..git_revision:e7e8e7aea55bc50729ec835604b2a00e6e668afe * tools/luci-go: git_revision:0f913477afc80d5c4b6609834d3bef6b44910e67..git_revision:e7e8e7aea55bc50729ec835604b2a00e6e668afe * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b0eccdd309..d5a5d84142 No update to Clang. Bug: None Tbr: ynovikov@google.com,jmadill@google.com Change-Id: I5d24a7ca9920f29f321a6333bd3bb96852570b77 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2843989 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 718022e8 2021-04-16T20:50:34 Reland "Revert "Vulkan: Suppress draw-time push constant VVL warnings. "" This is a reland of b027dfeb83d028ae72ed1957ba81e6c5dc3baffa Original change's description: > Revert "Vulkan: Suppress draw-time push constant VVL warnings. > " > > This reverts commit f34b40dab0487bbabc37645918bed87048107e14. > > Reason for revert: VVL bug is fixed. > > Original change's description: > > Vulkan: Suppress draw-time push constant VVL warnings. > > > > > > > > VUID-vkCmdDraw-None-02698 > > > > VUID-vkCmdDrawIndexed-None-02698 > > > > VUID-vkCmdDrawIndirect-None-02698 > > > > VUID-vkCmdDrawIndirectCount-None-02698 > > > > VUID-vkCmdDrawIndexedIndirect-None-02698 > > > > VUID-vkCmdDrawIndexedIndirectCount-None-02698 > > > > VUID-vkCmdDispatch-None-02698 > > > > > > > > Bug: angleproject:5821 > > Change-Id: Ic8ca6178ce50b409ac8d256848654f43f91fae8e > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808854 > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > Commit-Queue: Jamie Madill <jmadill@chromium.org> > > Bug: angleproject:5821 > Change-Id: I771e81a46893f2875605e472273f1388587e042e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831997 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:5821 Change-Id: I56ccb80eb76c3cedca2a40b8cc0223a879ab1edf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842309 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 95e75ec8 2021-04-21T09:26:57 Remove 'six' from roll_chromium_deps. This dep was causing the script to fail. It may be because the repo currently has a single commit. Work around this by removing the entry from the auto-roller for now. Bug: angleproject:2344 Change-Id: Id4f61124aae7ab43aa2343faf19416ff676314d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842224 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll ac0cd4fb 2021-04-21T10:01:48 Roll vulkan-deps from 494bfcf95bd6 to e5bb9b56c292 (4 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/494bfcf95bd6..e5bb9b56c292 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/4b868e5e13..eb6d6f95df * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/a746136a81..eb3d67bd17 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f39a8dc664..fd0e2b53a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I0838e28b3ab413909174b2c676bb9d66b352fd13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2841735 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 18ed9e54 2021-04-21T10:01:59 Roll SwiftShader from dac99e8221a8 to c597a8af03ef (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/dac99e8221a8..c597a8af03ef 2021-04-20 capn@google.com Fix pedantic Clang warning/error 2021-04-20 capn@google.com Add IndentCaseBlocks to .clang-format If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I454deea7c3c30ec101b00773e55afcce21fbecd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2843428 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki e77e4d92 2021-04-09T16:29:36 tests: Add DepthStencilTestES3.ReadPixelsDepth24. Add a test that creates a framebuffer formatted GL_DEPTH_COMPONENT24 and read pixels from it using glReadPixels. This test uses a combination of the GL_OES_depth24 and GL_NV_read_depth extensions. This test can only run on GLES3 as the GL_DEPTH_COMPONENT24 internal format is not available on GLES2. Test: angle_end2end_tests --gtest_filter=DepthStencilTestES3.ReadPixelsDepth24/ES3_Vulkan_SwiftShader Bug: angleproject:5799 Change-Id: I4e898bf756498796df02ef41cc2b989df78f13df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2817765 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Le Hoang Quyen a878e814 2021-04-11T15:04:19 Metal: Distinguish Metal backend from OpenGL's Metal driver On macOS 11+ OpenGL is implemented on top of Metal internally. This CL changes ANGLE's Metal backend's renderer string to better differentiate it from the above OpenGL renderer. Bug: angleproject:5841 Change-Id: I0d5466594e385cb663d537db034c82b006b6e907 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2820179 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill d170f8e1 2021-04-20T19:17:17 infra: Add configs for Android build. Updates the configs to use the new protobuf properties. Adds support for ARM/ARM64 Android builds. Must be landed in conjunction with http://crrev.com/c/2841787 . Bug: angleproject:2344 Bug: angleproject:5114 Change-Id: I49f4f46ceaa7ce9118c9f4b4ceb06353b00429b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842306 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Peng Huang be2f7b1c 2021-04-20T13:54:47 Unbind fbo before context switching for PowerVR GPUs Imagination GL drivers are buggy with context switching. We need to ubind fbo to workaround a crash in the driver. Bug: chromium:1187513 Change-Id: Ie5142b5f43a3f23a9743ba7af0d90567fedd00d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2841083 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
angle-autoroll 226259e5 2021-04-20T09:04:43 Roll Chromium from cb5ad5e674fa to 141612cc6143 (482 revisions) https://chromium.googlesource.com/chromium/src.git/+log/cb5ad5e674fa..141612cc6143 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5658f225b4..bdd4e9dcbc * testing: https://chromium.googlesource.com/chromium/src/testing/+log/db4fc48f37..d364fd2e43 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..09248fe432 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/efd29f6f5c..93d80d8686 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f4ded123d0..b0eccdd309 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Id5942b5905f168e90198ec3b63ab77637f02c517 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2838870 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov a3d52a4d 2021-04-20T17:52:17 Skip dEQP-EGL.functional.resize.surface_size.stretch_width on Linix Vulkan NVIDIA Bug: angleproject:5884 Change-Id: I46c330b2dc78b2271999315aa2b28930aee490f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842305 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 7bf6e4fb 2021-04-20T18:17:29 Roll VK-GL-CTS from ededa67cb12a to 476acb91ebc2 (22 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/ededa67cb12a..476acb91ebc2 2021-04-16 alexander.galazin@arm.com Update Vulkan beta Headers 2021-04-16 piotr.byszewski@mobica.com Create chunked mustpass 2021-04-16 rgarcia@igalia.com Test non-uniform args in ray tracing operations 2021-04-16 alexander.galazin@arm.com Support GL 4.5 in the Program State Query tests 2021-04-16 tarceri@itsqueeze.com Add some simple shader tests for compatibility context 2021-04-16 tony.wasserka@gmx.de Add new tests for (u)int->float conversion 2021-04-16 rgarcia@igalia.com Test buffer copies with varying offsets and sizes 2021-04-16 pdaniell@nvidia.com Vulkan CTS coverage for VK_EXT_ycbcr_2plane_444_formats 2021-04-16 slawomir.cygan@intel.com Fix 'implicit-fallthrough' build error on GCC 9.3.0 2021-04-16 alexander.galazin@arm.com Support GL 4.5 in the tessellation and geometry shader interaction tests 2021-04-16 marcin.zajac@mobica.com Fix RT misc tests (querying shaderfloat64) 2021-04-16 lionel.g.landwerlin@intel.com Add missing rasterizationStream in pipeline creation 2021-04-16 sagar.ghuge@intel.com Drop unnecessary barrier 2021-04-16 piotr.byszewski@mobica.com Portability: fix ycbcr query tests 2021-04-16 rgarcia@igalia.com Make tcu::Exception noexcept copy-constructible 2021-04-14 toni.salmivalli@siru.fi dEQP-VK.graphicsfuzz.stable-colorgrid-modulo-true-conditional-divided-1 2021-04-14 toni.salmivalli@siru.fi Add a batch of GraphicsFuzz tests 2021-04-14 selcott@google.com Tests for VK_EXT_color_write_enable 2021-04-14 pdaniell@nvidia.com Tests for VK_EXT_vertex_input_dynamic_state 2021-04-14 dakeley@nvidia.com Add VK_NV_inherited_viewport_scissor tests 2021-04-14 alexander.galazin@arm.com Update Vulkan Headers 2021-04-14 jajones@nvidia.com Support alternate file path lists for loading libs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ynovikov@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com,angle-bots+autoroll-info@google.com Change-Id: I91da42609c1b9a065911762f966e163dbd02c90e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2840964 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 39c33f34 2021-04-19T17:53:19 Tests: Add "Command and Conquer: Rivals" trace Bug: angleproject:5830 Tests: TracePerfTest.Run/*command_and_conquer_rivals Change-Id: I0b5fedfdeab3c0729bac706ceb7ce98f66b41986 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2838231 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Shahbaz Youssefi 50cd151c 2021-04-20T10:44:52 Roll third_party/vulkan-deps/ c18d8cd50..494bfcf95 (48 commits) https://chromium.googlesource.com/vulkan-deps/+log/c18d8cd5016c..494bfcf95bd6 $ git log c18d8cd50..494bfcf95 --date=short --no-merges --format='%ad %ae %s' 2021-04-20 chromium-autoroll Roll SPIRV-Cross from 3cb8e7c223a3 to d137abeef57b (5 revisions) 2021-04-20 chromium-autoroll Roll Vulkan-Loader from 64cc17099c41 to 4b868e5e13dc (2 revisions) 2021-04-19 chromium-autoroll Roll Vulkan-ValidationLayers from 61c2339d1547 to f39a8dc664c6 (2 revisions) 2021-04-19 chromium-autoroll Roll glslang from 842743722152 to 60ce877de03f (1 revision) 2021-04-19 chromium-autoroll Roll Vulkan-ValidationLayers from 33440cbab76c to 61c2339d1547 (2 revisions) 2021-04-19 chromium-autoroll Roll glslang from ed948c8e1226 to 842743722152 (1 revision) 2021-04-19 chromium-autoroll Roll SPIRV-Tools from 693d564db4e9 to dc72924cb31c (1 revision) 2021-04-19 chromium-autoroll Roll SPIRV-Cross from b4aa6dacfa8c to 3cb8e7c223a3 (1 revision) 2021-04-19 chromium-autoroll Roll SPIRV-Cross from 45818c14e49a to b4aa6dacfa8c (1 revision) 2021-04-19 chromium-autoroll Roll SPIRV-Cross from 582749ac68a9 to 45818c14e49a (1 revision) 2021-04-19 chromium-autoroll Roll Vulkan-Headers from f5ac258209dc to 074fa3055cfe (1 revision) 2021-04-16 chromium-autoroll Roll glslang from b3859343a2ca to ed948c8e1226 (1 revision) 2021-04-16 chromium-autoroll Roll Vulkan-ValidationLayers from 65576d6dc06a to 33440cbab76c (4 revisions) 2021-04-16 chromium-autoroll Roll Vulkan-ValidationLayers from 8035832536d2 to 65576d6dc06a (1 revision) 2021-04-16 chromium-autoroll Roll Vulkan-ValidationLayers from e7eb5ca5e6ec to 8035832536d2 (1 revision) 2021-04-16 chromium-autoroll Roll Vulkan-ValidationLayers from ee42bab38c3b to e7eb5ca5e6ec (2 revisions) 2021-04-16 chromium-autoroll Roll SPIRV-Tools from a02a9205ff49 to 693d564db4e9 (1 revision) 2021-04-15 chromium-autoroll Roll Vulkan-ValidationLayers from c8596531b3f7 to ee42bab38c3b (1 revision) 2021-04-15 chromium-autoroll Roll Vulkan-ValidationLayers from 675fbfaee4e7 to c8596531b3f7 (1 revision) 2021-04-15 chromium-autoroll Roll Vulkan-ValidationLayers from fc6291e5eded to 675fbfaee4e7 (2 revisions) 2021-04-15 chromium-autoroll Roll Vulkan-ValidationLayers from 962cad9d3a78 to fc6291e5eded (1 revision) 2021-04-14 chromium-autoroll Roll glslang from e7e4a8eecba5 to b3859343a2ca (1 revision) 2021-04-14 chromium-autoroll Roll glslang from e6a0e7fc7664 to e7e4a8eecba5 (1 revision) 2021-04-14 chromium-autoroll Roll Vulkan-ValidationLayers from 13c4877ea280 to 962cad9d3a78 (1 revision) 2021-04-14 chromium-autoroll Roll SPIRV-Cross from d2e1e7ba9891 to 582749ac68a9 (1 revision) 2021-04-13 chromium-autoroll Roll Vulkan-Headers from cd913e84a81d to f5ac258209dc (1 revision) 2021-04-13 chromium-autoroll Roll Vulkan-Headers from e01b00657664 to cd913e84a81d (1 revision) 2021-04-13 chromium-autoroll Roll Vulkan-ValidationLayers from 7699b91798eb to 13c4877ea280 (2 revisions) 2021-04-13 chromium-autoroll Roll Vulkan-ValidationLayers from 14f4f766ff89 to 7699b91798eb (1 revision) 2021-04-13 chromium-autoroll Roll Vulkan-ValidationLayers from 1e4ea30a1df3 to 14f4f766ff89 (1 revision) 2021-04-13 chromium-autoroll Roll glslang from a7f846a86cb2 to e6a0e7fc7664 (1 revision) 2021-04-13 chromium-autoroll Roll Vulkan-ValidationLayers from 884a3ecf0e11 to 1e4ea30a1df3 (1 revision) 2021-04-13 chromium-autoroll Roll Vulkan-Headers from e1d8c4931d8e to e01b00657664 (1 revision) 2021-04-13 chromium-autoroll Roll SPIRV-Tools from ae6a1e1d2f3e to a02a9205ff49 (1 revision) 2021-04-12 chromium-autoroll Roll Vulkan-ValidationLayers from d78df3497e17 to 884a3ecf0e11 (1 revision) 2021-04-12 chromium-autoroll Roll glslang from 5602195eed90 to a7f846a86cb2 (1 revision) 2021-04-12 chromium-autoroll Roll glslang from 9f76fd133063 to 5602195eed90 (1 revision) 2021-04-12 chromium-autoroll Roll SPIRV-Tools from 6210375e1399 to ae6a1e1d2f3e (1 revision) 2021-04-09 chromium-autoroll Roll SPIRV-Tools from 8da800c4cbc7 to 6210375e1399 (1 revision) 2021-04-09 chromium-autoroll Roll Vulkan-ValidationLayers from abf8d903e390 to d78df3497e17 (1 revision) 2021-04-09 chromium-autoroll Roll Vulkan-ValidationLayers from 317a46523468 to abf8d903e390 (3 revisions) 2021-04-09 chromium-autoroll Roll Vulkan-ValidationLayers from 9b36350504c7 to 317a46523468 (2 revisions) 2021-04-09 chromium-autoroll Roll SPIRV-Tools from 212895d4c2cd to 8da800c4cbc7 (1 revision) 2021-04-08 chromium-autoroll Roll Vulkan-ValidationLayers from 3986d4ffc6b1 to 9b36350504c7 (2 revisions) 2021-04-08 chromium-autoroll Roll Vulkan-ValidationLayers from eb791f3842c3 to 3986d4ffc6b1 (1 revision) 2021-04-08 chromium-autoroll Roll glslang from 4099f444484b to 9f76fd133063 (1 revision) 2021-04-08 chromium-autoroll Roll Vulkan-ValidationLayers from f563b367c72a to eb791f3842c3 (1 revision) 2021-04-08 chromium-autoroll Roll glslang from 1481399549c5 to 4099f444484b (1 revision) Created with: roll-dep third_party/vulkan-deps Bug: angleproject:5879 Change-Id: Ic36d6ded7116f8a59c9c4bcfb995dd4b870e3ecb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2837548 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov c275ce14 2021-04-19T14:06:53 Skip Texture2DBaseMaxTestES3.GenerateMipmapAfterRebase* on Mac ARM GL Bug: angleproject:5880 Change-Id: I18698e0603938c43878ad4d28379d6976952c561 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2836787 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Mohan Maiya 2d741b43 2021-04-20T07:33:02 Add KHR_blend_equation_advanced entry points Addition of the entry points for GL_KHR_blend_equation_advanced extension. Bug: angleproject:3586 Change-Id: I7a651c19a4b3d0a7cfe4af7813f1530d27704bc1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2830140 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Amy Liu 95935176 2021-03-26T17:38:21 Handle the compression of big pipeline cache. Big pipeline cache will cost much time to compress. Regarding the perfomance, handle the compression of big pipeline cache in this way: 1)Return when the pipeline cache data is larger than 10M. 2)Use worker thread to complete compression. Bug: angleproject:4722 Change-Id: I62eb69d8c46729261f0502af01450ec301c258f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2788169 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 2f808349 2021-04-16T19:21:15 Add standalone Android build. Includes necessary DEPS and GN build changes. Some folders are copied directly from Chromium because they don't exist as source mirrors or aren't available for other reasons. Bug: angleproject:2344 Change-Id: Ibb7f8a3e2288048b7aed2b0e277ca63b5a932c57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826480 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Mohan Maiya bdf5f084 2021-04-16T11:29:29 Add EXT_texture_border_clamp entry points Addition of the entry points for EXT_texture_border_clamp extension. Bug: angleproject:3586 Change-Id: I366c2748213d7fdde815543129320278937000e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2830146 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang b574643e 2021-04-19T12:47:05 D3D11: Skip blits if there is no intersection of dest areas Blit11 would clip the destination rectangle with the destination size but ignore the result. gl::ClipRectangle returns false when the rectangles do not intersect at all, indicating the blit can be skipped. This could lead to an out-of-bounds write to the GPU memory for the destination texture. Mark ClipRectangle as nodiscard to prevent future issues. Bug: chromium:1199402 Change-Id: I260e82d0917b8aa7e7887f2c9f7ed4b1a03ba785 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2836786 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Jamie Madill 3691797a 2021-04-19T16:16:59 Revert "infra: Switch to "angle_2" presubmit config." This reverts commit 5166a25b2ccf04881c3fc1cd3f19e2246b23fec0. Reason for revert: Breaks presubmit tester (again). Original change's description: > infra: Switch to "angle_2" presubmit config. > > We will revert this once we remove the depot_tools config. > > Bug: angleproject:5114 > Change-Id: If922a24c9955ba5d5d30ec634fa6c3d6db177f65 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831999 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5114 Change-Id: I7a540c728f6851151c2f708480de21ce41938111 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2836785 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 5aa5de76 2021-04-16T11:22:15 Vulkan: Keep the output variable of TCS active for barrier OpControlBarrier implicitly synchronizes 'Output' storage class. If TCS has an out varying it should be considered active because TCS invocations themselves can read each others' outputs. Bug: angleproject:5557 Tests: KHR-GLES32.core.tessellation_shader.tessellation_shader_tc_barriers.barrier_guarded_*_calls Change-Id: Ic252c0afff43a68828ee4cf5f4ba890b1b67731e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770679 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Jamie Madill 39d8dde8 2021-04-19T15:02:02 Revert "Revert "Vulkan: Suppress draw-time push constant VVL warnings." This reverts commit b027dfeb83d028ae72ed1957ba81e6c5dc3baffa. Reason for revert: Breaking win-trace-rel b/c of missing VVL roll. Original change's description: > Revert "Vulkan: Suppress draw-time push constant VVL warnings. > " > > This reverts commit f34b40dab0487bbabc37645918bed87048107e14. > > Reason for revert: VVL bug is fixed. > > Original change's description: > > Vulkan: Suppress draw-time push constant VVL warnings. > > > > > > > > VUID-vkCmdDraw-None-02698 > > > > VUID-vkCmdDrawIndexed-None-02698 > > > > VUID-vkCmdDrawIndirect-None-02698 > > > > VUID-vkCmdDrawIndirectCount-None-02698 > > > > VUID-vkCmdDrawIndexedIndirect-None-02698 > > > > VUID-vkCmdDrawIndexedIndirectCount-None-02698 > > > > VUID-vkCmdDispatch-None-02698 > > > > > > > > Bug: angleproject:5821 > > Change-Id: Ic8ca6178ce50b409ac8d256848654f43f91fae8e > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808854 > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > Commit-Queue: Jamie Madill <jmadill@chromium.org> > > Bug: angleproject:5821 > Change-Id: I771e81a46893f2875605e472273f1388587e042e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831997 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:5821 Change-Id: If9f80d052736e40c4c6d3e9a1cd629205901ba49 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2836285 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 5166a25b 2021-04-16T20:07:32 infra: Switch to "angle_2" presubmit config. We will revert this once we remove the depot_tools config. Bug: angleproject:5114 Change-Id: If922a24c9955ba5d5d30ec634fa6c3d6db177f65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831999 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 5813365f 2021-04-19T10:01:01 Roll SwiftShader from f32791f5d53b to dac99e8221a8 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/f32791f5d53b..dac99e8221a8 2021-04-16 capn@google.com Update Kokoro's clang-format to version 11.0.1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I07e7a243f65968e94b942b18d52f11ae6fcc3af3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2833601 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 24d21dce 2021-04-19T07:03:07 Roll Chromium from 11d568cbfed1 to cb5ad5e674fa (484 revisions) https://chromium.googlesource.com/chromium/src.git/+log/11d568cbfed1..cb5ad5e674fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e00ea2a33f..5658f225b4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5d440f33b4..db4fc48f37 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d6284252dc * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f959d17028..efd29f6f5c * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/eefe475693..d7dd881ddc * tools/luci-go: git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0..git_revision:0f913477afc80d5c4b6609834d3bef6b44910e67 * tools/luci-go: git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0..git_revision:0f913477afc80d5c4b6609834d3bef6b44910e67 * tools/luci-go: git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0..git_revision:0f913477afc80d5c4b6609834d3bef6b44910e67 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5e7cca9ca0..f4ded123d0 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I61264c3b92501cd9b1816dee7c26cf2d32efdc31 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2834733 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi b027dfeb 2021-04-16T20:50:34 Revert "Vulkan: Suppress draw-time push constant VVL warnings. " This reverts commit f34b40dab0487bbabc37645918bed87048107e14. Reason for revert: VVL bug is fixed. Original change's description: > Vulkan: Suppress draw-time push constant VVL warnings. > > > > VUID-vkCmdDraw-None-02698 > > VUID-vkCmdDrawIndexed-None-02698 > > VUID-vkCmdDrawIndirect-None-02698 > > VUID-vkCmdDrawIndirectCount-None-02698 > > VUID-vkCmdDrawIndexedIndirect-None-02698 > > VUID-vkCmdDrawIndexedIndirectCount-None-02698 > > VUID-vkCmdDispatch-None-02698 > > > > Bug: angleproject:5821 > Change-Id: Ic8ca6178ce50b409ac8d256848654f43f91fae8e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808854 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5821 Change-Id: I771e81a46893f2875605e472273f1388587e042e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831997 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
kmx.io     mail     discord kmxgit v0.4.0