|
afd32d8e
|
2021-03-30T15:50:57
|
|
Vulkan: Remove mMaxLevel from ImageHelper class
This CL removes mMaxLevel from ImageHelper class. Instead, it now uses
front end's max level information when possible.
Bug: b/181800403
Change-Id: Ie0f6bd11e3ca0d4ddfc98f21261396c4d71b7140
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2796153
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
|
|
4756d5e6
|
2021-03-22T17:28:30
|
|
Mark most draw modes valid when no program is bound
gpu_angle_passthrough_fuzzer discovered a crash when glDrawArrays() is
called without a program bound. This was caused by assuming it's an
error to draw certain primitive types without a program bound, which is
incorrect. This fix is to mark all draw modes except Patches valid when
there is no program bound. Patches is handled separately by TS
validation.
Bug: chromium:1185267
Bug: angleproject:5483
Test: gpu_angle_passthrough_fuzzer
Test: SimpleOperationTest31.DrawWithoutProgramBound
Test: KHR-GLES31.core.draw_indirect.basic-mode-*adjacency
Change-Id: I294078b8695e0b8f36d3b7ad3c1aa71d2a275038
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780971
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
08b7c55c
|
2021-03-30T13:51:04
|
|
Vulkan: Remove mBaseLevel from ImageHelper class
This removes mBaseLevel from ImageHelper class. With the
mFirstAllocatedLevel tracking exactly which GL level has been allocated,
this cached mBaseLevel is no longer needed.
Bug: b/181800403
Change-Id: I99d66c93b0c8f1bd20a5811b51f512a27927201e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2795275
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
b5a71140
|
2020-08-20T17:24:21
|
|
Vulkan: Make storage actually immutable for immutable textures
The immutable textures are intended to be "immutable". Right now we are
still re-allocating VkImage object based on base_level and max_level.
This causes a problem for rendering to a level that is beyond
[base_level, max_level], which is totally within OpenGL spec. This CL
makes an immutable texture always allocate from 0 to max levels that are
specified by a glTexStorage call. Changing base_level will not trigger
re-allocation of VkImage object.
Bug: b/181800403
Change-Id: I4b4ddea17b7f6f7bfd8f36bfe8bb3a35b5c180b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2368038
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
969b8f31
|
2021-03-25T12:40:47
|
|
Vulkan: Fix geometry shader validation with vertex shaders
Added validation to disallow usage of geometry shaders
without a vertex shader
Bug: angleproject:5579
Test: KHR-GLES32.core.geometry_shader.api.fs_gs_draw_call
Test: KHR-GLES32.core.geometry_shader.api.pipeline_program_without_active_vs
Change-Id: Ieeec544d514ac772416ab0427c1c1c5058276f98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2796151
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
4cdbdf90
|
2021-03-25T18:54:50
|
|
Vulkan: Assign XFB location first then assign varying location
Varying location is determined based on XFB location. If the transform
feedback stage is Vertex, there is no problem. But if the transform
feedback stage is GS or TES, previous implementation can cause shader
interface mismatch.
Bug: angleproject:5557
Test: KHR-GLES32.core.tessellation_shader.tessellation_control_to_tessellation_evaluation.gl_in
Change-Id: I1ecc7913a178c9e674307c528d1bdf13aabcb665
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2784713
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
|
2f22157a
|
2021-04-05T18:19:51
|
|
Fix Restricted Traces README.md jq command
The restricted traces README.md has some errors in the shell commands
related to using `jq`.
Bug: angleproject:5811
Change-Id: Id105d83ee041e236c3b14cd83500f08a1deb56b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2806551
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
78dde332
|
2021-03-29T17:31:52
|
|
Move restricted traces to CIPD.
All traces are now stored as DEPS entries in CIPD. The auto-generation
script generates the DEPS entries. Note that we don't include DEPS in
the list of generated outputs to simplify other rollers. Also we update
auto-generation to include full sources list to allow 'gn analyze' to
work successfully.
Usees a trace fixture for common code. This will enable a more compact
trace without as much repeated code. We must land a set of re-trace
traces to avoid breakage.
Also includes a python script for uploading new traces to CIPD. The
script first checks if traces are already present in the cloud, and if
so it skips the upload. It will take a while to complete as the number
of traces grows larger as it takes a few seconds per trace.
The traces in this patch are also re-traced to use the common fixture
code instead of including duplicated code in each trace. They now form
a simple common interface and the autogenerated cpp is now simply a list
of properties.
I've also updated the capture/replay tests to use the simpler common
entry point integration. There is less auto-generated glue code now.
We now use a new serialized string query extension instead of calling
directly into ANGLE's internals.
Also includes a docs update. The capture/replay sample is broken and
we'll need to update it in a follow-up CL. Also includes a few necessary
fixes to the retracing script.
Bug: angleproject:5811
Change-Id: I977bc6dc56843c8966377fc445ae97e91e17319a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2797833
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
323c5f24
|
2021-03-29T17:47:53
|
|
Validate PPO sampler uniforms
"Command & Conquer: Rivals" uses PPOs and was hitting the following
assert:
angle::Result ContextVk::updateActiveTextures(const gl::Context *context)
{
...
for (size_t textureUnit : activeTextures)
{
gl::Texture *texture = textures[textureUnit];
gl::TextureType textureType = textureTypes[textureUnit];
ASSERT(textureType != gl::TextureType::InvalidEnum);
This is the same assert that is generated by the test
ProgramPipelineTest31.DifferentTextureTypes which is currently being
skipped since it's known to fail.
This CL refactors sampler validation into the ProgramExecutable to allow
PPOs to take advantage of the shared code and behave correctly, since
the necessary data is already copied into the PPO's ProgramExecutable
via ProgramExecutable::updateActiveSamplers(). This also takes advantage
of the subject/observer pattern that's already established between
programs and PPOs to ensure only the PPOs that the program is a part of
are updated when a program's sampler uniforms are updated.
Bug: angleproject:3570
Bug: b/182409935
Test: ProgramPipelineTest31.DifferentTextureTypes
Change-Id: I3d34efd66dc85e7ff23a8422cb14d5f90a5f7085
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2792862
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
7a699140
|
2021-03-30T08:49:41
|
|
Tests: Add Dragon Raja trace
Bug: b/184105957
Bug: angleproject:5807
Change-Id: I2a6d20a872311fb8b2c601c9a796b4f582ba5144
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2796403
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
67e4aff5
|
2021-04-02T13:17:00
|
|
Fix rapidjson build error in Skia.
Instead of using defines in the header, use the same approach as we do
with frame capture by defining a stub "mock" cpp file.
Bug: angleproject:5805
Change-Id: Ief1cb6497ddafc9656bb0e7d6a921eff3610a7fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2801695
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
88b91df1
|
2021-03-29T23:01:01
|
|
Capture/Replay: Support multi-digit context
The code is designed for single digit contexts, i.e 1-9.
We've hit our first app that uses context 10, so update the logic.
Bug: b/184105957
Bug: angleproject:5807
Change-Id: Ice5facad8a86f009c0a85d184db4a20e48eff248
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2796402
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
fe6b4269
|
2021-03-25T14:04:41
|
|
Vulkan: Add baseLevel and generateMipmap test for immutable texture
Immutable texture may implemented slightly differently in driver. This
CL adds a new test that calls glGenerateMipmap after changing
GL_BASE_LEVEL and GL_MAX_LEVEL. It also expands PingPongBaseLevel to
test immutable texture as well.
Bug: b/181800403
Test: Texture2DBaseMaxTestES3.PingPongBaseLevelImmutable
Test: Texture2DBaseMaxTestES3.GenerateMipmapAfterRebaseImmutable
Test: Texture2DBaseMaxTestES3.GenerateMipmapAfterRebase
Change-Id: I4ccf58f588bfd5e02a6fc7439b6fe535fca8dd7c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2787253
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
a9bcbac3
|
2021-03-31T15:30:42
|
|
Vulkan: Add test render to immutable texture will flush
There was a bug that if there is a pending update in the immutable
texture's level that is outside of [base, max], and then when you render
to that level, the pending update will not get flushed. This test verify
this bug.
Bug: b/181800403
Test: FramebufferTest_ES3.RenderImmutableTextureWithSubImageWithBeyondMaxLevel
Change-Id: Id9a5a141d26d45a3a154c331086bb64b0b094cdf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2797724
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
b3a8033d
|
2021-03-31T09:34:00
|
|
JsonSerializer: use stubs when building without rapidjson
Bug: angleproject:5805
Change-Id: Ibf51b8b75c3feb6efdef969effb3f50e2474c6b3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2795772
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
811568a9
|
2021-04-01T21:29:17
|
|
Tests: Add Aztec Ruins trace
Test: angle_perftests --gtest_filter="*aztec_ruins*"
Tbr: jmadill@google.com,timvp@google.com
Bug: b/160808198
Bug: angleproject:5553
Change-Id: I24e3ae44698c5347fa5b9412d6a3ab16fb4f5c08
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2634206
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
2a0f4251
|
2021-04-01T15:12:55
|
|
Tests: Add League of Legends: Wild Rift trace
Test: angle_perftests --gtest_filter=*league_of_legends_wild_rift*
Tbr: jmadill@google.com,timvp@google.com
Bug: b/184290779
Bug: angleproject:5813
Bug: angleproject:5815
Change-Id: I0e3754c88ded31234658af373449e4a90a51c2a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2800426
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
256100b2
|
2021-04-02T01:45:14
|
|
Revert "Metal: Support importing external metal textures"
This reverts commit 2ec3e0a1e6890da56de9dfd3da5c9f31a3f7fbb7.
Reason for revert: Test suite ImageTestMetal never instantiated https://anglebug.com/5814
Original change's description:
> Metal: Support importing external metal textures
>
> via KHR_image_base and ANGLE_metal_texture_client_buffer
>
> Bug: angleproject:5763
> Change-Id: I4d4a88cfbb77d8b7508b787c7fec44073d3b11b0
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757811
> Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Bug: angleproject:5763, angleproject:5814
Change-Id: Ia862aa37a6c914f6e21f9b3121c7c36d449475ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2801155
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
80305ca4
|
2021-03-29T17:18:52
|
|
D3D: fix uniform block alignment error
If the uniform block will be translated to HLSL StructuredBuffer,
in order to follow the std140 rules, we should add padding between
the members if necessary.
Bug: chromium:1193170
Change-Id: I75bc3538a66fc0c2a9c9ebf15fddeaab94d7a949
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2790518
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Xinghua Cao <xinghua.cao@intel.com>
|
|
2ec3e0a1
|
2021-03-13T22:17:49
|
|
Metal: Support importing external metal textures
via KHR_image_base and ANGLE_metal_texture_client_buffer
Bug: angleproject:5763
Change-Id: I4d4a88cfbb77d8b7508b787c7fec44073d3b11b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757811
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
3c98bb6a
|
2021-03-31T21:32:42
|
|
Reland "Link angle_util statically into angle_system_info_test"
This reverts commit 91b6c3b1a2b12f6c834238ed680d82c3de741cd0.
Reason for revert: fixing compilation on android-archive-dbg
Original change's description:
> Revert "Link angle_util statically into angle_system_info_test"
>
> This reverts commit 804226dffd9b35f88c4a64672fea2cd29c2bc6e8.
>
> Reason for revert: breaks compilation on android-archive-dbg.
> See https://ci.chromium.org/ui/p/chromium/builders/ci/android-archive-dbg/7802/overview (seems the egl symbols can't be found?)
>
> Original change's description:
> > Link angle_util statically into angle_system_info_test
> >
> > Otherwise ANativeActivity_onCreate is not found in component build.
> >
> > Bug: angleproject:4483
> > Change-Id: Ic4a9f66e5b7d150a3740529f866de9995550ea68
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689370
> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
> > Reviewed-by: Jamie Madill <jmadill@chromium.org>
>
> TBR=ynovikov@chromium.org,jmadill@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> TBR=ynovikov@chromium.org
> Bug: angleproject:4483
> Change-Id: I7f16f77979f7d8b1e5e5f61e48b379b910f3a743
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2697067
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bug: angleproject:4483
Change-Id: I9e6621a2f10041cc8f191d877e48710d977e8237
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2798399
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
259ead0d
|
2021-03-30T19:41:33
|
|
Enable messenger_lite trace on SwiftShader.
For re-tracing.
Bug: angleproject:5811
Change-Id: I1b58b33e0641cbd6a6aba10f936b76b5a9eca589
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2797831
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
be52ca8a
|
2021-03-31T01:52:56
|
|
[Fuchsia] Use manifest fragments for Cr-Fuchsia binaries
Bug: chromium:1180168
Change-Id: Ie3f2bd6bb79d971549b0422a9f1da7e713a54cc2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2796542
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
ae937aae
|
2021-03-19T20:10:42
|
|
Detach separable shaders
This effectively reverts the following CL:
Vulkan: Don't detach separable shaders in Program::detachShader()
https://chromium-review.googlesource.com/c/angle/angle/+/2084399
Bug: angleproject:3570
Bug: b/182409935
Test: ProgramPipelineTest31.DetachAndModifyShader
Change-Id: Id69f732d1d4f3eea70b2de8c008452878eaf1682
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776267
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
fe3a9ffb
|
2021-03-17T18:05:40
|
|
Support linking PPOs without attached Shaders
The application "Command & Conquer: Rivals" uses the following pattern:
// Create and link VS, save binary data
glCreateProgram()
glAttachShader()
glLinkProgram()
glGetProgramBinary()
// Create and link FS, save binary data
glCreateProgram()
glAttachShader()
glLinkProgram()
glGetProgramBinary()
...
// Create VS, load binary data
glCreateProgram()
glProgramBinary()
// Create FS, load binary data
glCreateProgram()
glProgramBinary()
...
glUseProgramStages(GL_VERTEX_SHADER_BIT)
glUseProgramStages(GL_FRAGMENT_SHADER_BIT)
glBindProgramPipeline()
Later, when issuing the draw command that uses the PPO, the PPO must be
linked with the Programs that were loaded via binary data. Those
Programs don't have any Shaders attached, just linked. This CL adds
support for linking Programs without attached Shaders.
Bug: b/182409935
Test: ProgramPipelineTest31.ProgramBinary
Change-Id: Ic5a4776e1374322665f45fbbcbf955838d093d02
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770685
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
e3b9dbef
|
2021-03-17T18:01:02
|
|
Update PPO's executable when attached program is re-linked
When a program that's being used by a PPO is successfully re-linked, the
PPO's ProgramExecutable needs to be updated. This takes advantage of the
subject/observer pattern that's already established between programs and
PPOs to ensure only the PPOs that the program is a part of are updated.
Bug: b/182409935
Test: ProgramPipelineTest31.ModifyAndRelinkShader
Change-Id: Idcc11e7e819b4a9bef02bdd71afc8ea58111acc6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770684
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
cee0bfd6
|
2021-03-15T14:39:30
|
|
Capture/Replay: serialize context to JSON
Bug: angleproject:5715
Change-Id: Ibc6897d7567fedab4a2ba7bf8d2bd5a7e496bd4b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2760325
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
d00bd105
|
2021-03-15T11:13:34
|
|
Capture/Replay: Enable GetTexImage tests
Bug: angleproject:5646
Change-Id: Ic3ffc08edb2504b3f5cf6913e3995f8da8b7a94a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2791443
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
9a025fd4
|
2021-03-13T22:48:13
|
|
Capture/Replay: add frontend feature to force capture limits
Some of the limits set when FrameCapture is enabled are reflected in
the serialized context. In order for capture/replay tests to pass
these limits may also be needed to be enforced when replaying. Add a
fronten feature enable_capture_limits for this and use it in the
capture replay test script.
Patch authored by gert.wollny@collabora.com.
Bug: angleproject:5750
Change-Id: I3d333d22fe65c12dd5aa5f263d19a2c1568541c2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2790301
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
e0b9d4f7
|
2021-03-15T11:25:39
|
|
libAngle: Add Json context serializer library
Bug: angleproject:5715
Change-Id: I42319fe30e42d49d7e817b14c211b5ba82a94a42
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2760324
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
8d110222
|
2021-03-05T18:13:40
|
|
capture_replay_expectations: Don't skip passing.
Several tests now pass the comparision and do not need to be skipped.
Replace the wildcard with specific tests if only one test is failing.
Bug: angleproject:5721
Change-Id: I70172965d6e0df9d2c3ac43c391c377f7da12a6e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739727
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
776c6015
|
2021-02-26T00:00:57
|
|
Vulkan: Call glslang at compile time
With this change, the ANGLE translator immediately compiles the
generated GLSL into SPIR-V with glslang and discards the source. This
is in preparation for generating SPIR-V directly, by making the frontend
and backend already able to digest it.
This change also allows the expensive glslang calls to be parallelized,
improving the following perf test by about 20%:
LinkProgramBenchmark.Run/vulkan_compile_and_link_multi_thread
Previously, the test was run as such in the Vulkan backend:
Main Thread 1 Thread 2
Compile1 --->
Compile2 --------------------->
Translator Translator
<---
<---------------------
Link
glslang
for
shader1
glslang
for
shader2
Done
With this change, it is run as such:
Main Thread 1 Thread 2
Compile1 --->
Compile2 --------------------->
Translator Translator
glslang glslang
<---
<---------------------
Link
Done
glslang_wrapper_utils no longer interacts with glslang! A rename will
follow.
Bug: angleproject:4889
Change-Id: If4303e8ba0ba43b1a2f47f8c0a9133d0bee1a19a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2721195
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
eac2397b
|
2021-03-25T13:36:50
|
|
Trace Tests: Work around autoninja.bat change on Win.
A breaking change to autoninja.bat was causing the script to fail to
find 'python3.bat' in this configuration. Work around the issue by
instead invoking 'ninja.exe' directly with the correct '-j' argument.
Bug: angleproject:5766
Change-Id: Ie01d7e8c4caf80661f420ccfc55a8d951a4e1b4f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2787186
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
f28d63e9
|
2021-03-24T11:14:24
|
|
Vulkan: Enable glBlitFramebuffer for EXT_sRGB_write_control
Implements support for the glBlitFramebuffer edge case in the
EXT_sRGB_write_control spec, and fully exposes this extension.
Bug: angleproject:5075
Test: SRGBFramebufferTest*.*Vulkan*
Change-Id: I05f044abbc5cb272825d1fc4b9028217f18e63c2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785641
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
|
3d6cedb1
|
2021-03-24T18:29:02
|
|
Leave Android devices in portrait orientation after test
EGLPreRotationSurfaceTest.ChangeRotationWithDraw
alternates between landscape and portrait orientations.
The last one needs to be portrait, since this is the default state
that other tests expect.
Since changing orientation takes 1 second, it's more efficient to do it
in this one place instead of before every test.
Bug: angleproject:5781
Change-Id: I63c2eeb77663ea7de6679385c9deb089b16e74f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785433
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
525fde75
|
2021-03-22T14:55:21
|
|
Fix potential mod by 0 with invalid formats.
If the format passed to MakeValidSize is invalid, there
is potential for a mod by 0 which can result in a crash.
Test: Verify no crash when format is invalid.
Bug: b/182823289
Change-Id: I7f538be5d984070984f5581a5cc7ea47264109f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780557
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Doug Horn <doughorn@google.com>
|
|
|
010d61f2
|
2021-03-24T13:08:38
|
|
Disable Framebuffer Fetch test.
See issue for more details.
Bug: angleproject:5792
Change-Id: I7a72dfe75a85f2bf69e3528f35c01ca69c67f8f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785420
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
dd5705e7
|
2021-03-24T08:18:24
|
|
Add missing qualifier type handling in translator
Translator checks tessellation shader unsized array type qualifier.
sample in/sample out were missing in handling qualifier type.
Bug: angleproject:5557
Test: GLSLTest_ES31.VaryingTessellationSampleInAndOut*
Change-Id: I8a2f2c4c4fcc9cc88000d3b2d448ab51fb9e5d38
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776263
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
|
48560f67
|
2021-03-19T16:56:44
|
|
Tests: Add Real Cricket 20 trace
Test: angle_perftests --gtest_filter="*real_cricket_20*"
Bug: b/183165790
Bug: angleproject:5777
Change-Id: I1f350e3ea458a599396412e2c5ca80d6c7887d73
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776554
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
c4b1f366
|
2021-03-22T17:56:54
|
|
Fix copyright dates of new test files per Shabi
Bug: b/181711029
Change-Id: Ie619ba90f699dd8234cf185198cb6eeac9142758
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780560
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
ef17c650
|
2021-03-08T18:50:53
|
|
Vulkan: Add test for filament gltf usage case
filament gltf sample code is rendering to a level that is excluded from
[base_level, max_level]. This is allowed by OpenGL spec. We are crashing
right not. This CL adds tests for the exact usage pattern for filament.
Bug: b/181800403
Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithBeyondMaxLevel
Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithSubImageWithBeyondMaxLevel
Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithBellowBaseLevelLOD
Change-Id: I69bab8bc3961bbc2dcc78ba2db3c8759f277416b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752897
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
4386840c
|
2021-03-19T16:54:41
|
|
Tests: Add android log library to traces
This is required in order to call __android_log_print, which can
be sprinkled into the trace for debugging.
Bug: b/183165790
Change-Id: I717f2ac7809172f22b7badee6f1096394a02bc14
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776553
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
2be71410
|
2021-03-19T14:07:02
|
|
Handle inactive structure type varyings correctly
Correctly handle inactive varyings of structure type when collecting
transform feedback varyings. Previously, all varyings of structure type
were marked as active by mistake.
Bug: angleproject:5557
Test: TransformFeedbackTest.InactiveStructureVarying*
Change-Id: Ica1cbce5c551cdbb97999eeac59d09a961937615
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770680
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
570970f9
|
2021-03-19T13:43:35
|
|
Vulkan: Handle compilation error involving gl_InvocationID
We need to generate a compiler error only when the vertex index
of an output variable as an l-value, in a tessellation control shader,
is not the indentifier gl_InvocationID.
Bug: angleproject:5557
Tests: dEQP-GLES31.functional.tessellation.shader_input_output.barrier
Change-Id: Ica075b8d85916caa228f057b203ae81b27f65e2d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2758915
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
|
02acc5ee
|
2021-03-18T16:08:59
|
|
Vulkan: More cleanups to perf counters.
This refactors the pipeline type in the ContextVk class to also use
a packed enum map. It also expands the object perf counters to store
both a specific and cumulative version for use in different cases.
Bug: angleproject:5736
Change-Id: I6ff78e38065eb577f2b95b1d9c4f9cc31d7f325f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774184
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
ecbd870f
|
2021-03-21T22:54:24
|
|
Tests: Add Avakin Life - 3D Virtual World trace
Test: angle_perftest --gtest_filter="*avakin_life*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/183344915
Bug: angleproject:5779
Change-Id: Iaf2d8341055d5b7c6f3c8a7a7a1fb3d1399fabc5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776746
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
0380f115
|
2021-03-18T09:56:14
|
|
Skip ResizeWindow test on Linux.
ARM Linux doesn't support window surface resize.
Bug: angleproject:4453
Change-Id: Ia8631f5191c2b3ebd822766cc7f92275aa62dff3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2777578
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
7fe44a53
|
2021-03-20T09:39:09
|
|
Vulkan: Don't acquire new BufferHelper for external buffers
EXT_external_buffer spec -
This extension allows the data store for an immutable buffer to be
sourced from an external EGLClientBuffer, allowing sharing of EGL
client buffers across APIs, across processes, and across different
processing cores such as the GPU, CPU, and DSP.
The intent is for a single backing memory to be reused across various
processes and processors. Ensure that a glBuffer backed by external
memory does not orphan the memory when glBuffer APIs like
glBufferSubData or glMapBufferRangeEXT modify the glBuffer.
Bug: angleproject:4380
Bug: angleproject:5073
Tests: ExternalBufferTestES31.*DoesNotCauseOrphaning*Vulkan
Change-Id: I4e88f80d93ee1ba1208378121412926351d10af8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776192
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
90cf278c
|
2021-03-19T16:17:43
|
|
Add multi-thread/context test for compute shaders
The "Ragnarok M: Eternal Love" game uncovered a bug where 2 contexts
shared a VkCommandBuffer. The one context was used by one thread for
rendering, and the other context/thread dispatched compute shaders.
When the rendering thread destroyed a VkCommandBuffer, future compute
dispatches crashed because the new VkCommandBuffer didn't have a
compute pipeline bound.
Bug: b/181711029
Change-Id: I8bc85150c1c6202e02feb84a7ccc0ad7b9c39258
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770681
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d5bc8a27
|
2021-03-17T18:21:35
|
|
Vulkan: Add VUID-vkCmdDraw-None-04584 validation error to ignore list
Aztec ruins is using the same texture (but different level controlled by
a uniform variable) for textureLod and rendering. This triggers vulkan
validation error. This CL put it in the ignore list so that it can pass.
Bug: b/175584609
Change-Id: I7623e7b448514b3c12268aa5fe154f4c2f59b059
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770686
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
867411a4
|
2021-03-08T19:08:14
|
|
Vulkan: Track images used for both attachment and sampler
This CL adds a new layout ImageLayout::ColorAttachmentAndShaderRead. We
detect that the same ImageHelper object is used for both sampler and
attachment and will pick this new layout instead of ColorAttachment.
Bug: b/175584609
Change-Id: I2089f59d4dc1ad4de7edab0e067797adcfa9b020
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2749479
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
0a80f2e1
|
2021-03-15T16:56:08
|
|
D3D: Mark images dirty after recovering from storage
When images are recovered from storage due to resizing storage, they
were marked as clean and not always re-copied to the new storage.
Bug: angleproject:5757
Bug: chromium:1188854
Change-Id: Idd11025820433ab74ff769cd9508efcec4575c32
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2763282
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
9b3b5733
|
2021-03-17T15:38:42
|
|
Tests: Add Ragnarok M: Eternal Love trace
Test: angle_perftests --gtest_filter="*ragnarok_m_eternal_love*"
TBR: timvp@google.com,jmadill@google.com
Bug: b/181800519
Bug: angleproject:5772
Change-Id: I1dcde486e909f7c2b5d59132e5f673c7e8ab1d01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774264
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
ba0bd785
|
2021-03-15T16:00:33
|
|
Fix the assert error and inbalence parens for SSBO
This PR strengthens below two cases:
1. Support calculate unsized array size for any type. Previously,
it reported error when the type was a structure.
2. Correctly add the right paren for store function when any
load/length functions are nested in it.
Bug: angleproject:5734
Change-Id: I3428fa35f1481275e1d193094ceddb011f747cf1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2762655
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
|
|
|
1f1b4ffe
|
2021-03-08T11:44:28
|
|
Vulkan: Test render and sample the same texture but with different LOD
This simulates aztec ruin's usage. This works properly on native OpenGL
but generates validation error on vulkan backend and renders incorrect
as well.
Bug: b/175584609
Test: FramebufferTest_ES3.SampleFromAttachedTextureWithDifferentLOD
Change-Id: I402c205a1b625669cae29ee201dddd144e0dfbde
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743797
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
bb7c1442
|
2021-03-17T10:17:31
|
|
Fix immutable texture base level validation
Jeff's new rendering feedback loop test
(https://github.com/KhronosGroup/WebGL/pull/3221) found a couple of
issues with texture base level validation. For immutable textures the
base level is clamped to the valid range, so setting an out of range
base level does not make an immutable texture sampler incomplete, and
we need to use the clamped value when checking for rendering feedback
loops.
Bug: angleproject:5768
Change-Id: Ie065709efd736f2cf75d4f980e8ac27999f80142
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2767901
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
|
f6eccc20
|
2021-03-12T09:17:27
|
|
Tests: Add June's Journey trace
Test: angle_perftests --gtest_filter="*junes_journey*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/182566407
Bug: angleproject:5752
Change-Id: I083507949c9bc16bf701028a678540df9a3531dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2755840
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
81dcf078
|
2021-03-08T11:21:31
|
|
Reland "Vulkan: Support EXT_sRGB_write_control"
This is a reland of 6073af536cf627742696823edc82c9b0a481a8bc
with 2 changes -
1. Don't enable the extension even in nonConformant mode
2. Don't enable VK_KHR_image_format_list for swiftshader
Original change's description:
> Vulkan: Support EXT_sRGB_write_control
>
> Implement support for EXT_sRGB_write_control. This extension
> requires VK_KHR_image_format_list to be supported.
>
> The spec requires this functionality to work with glBlitFramebuffer
> as well but support for that will be added in a follow up change.
> As such, this extension is only exposed in non-conformant mode.
>
> Bug: angleproject:5075
> Tests: SRGBFramebufferTest.*Vulkan*
> Change-Id: I59b38f6cd810a3d0d67ec29f4f19c25f65f70862
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617243
> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: angleproject:5075
Change-Id: I8e149d196a39c3c4769bfa8690792f3c53831299
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2762647
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
|
522d609b
|
2021-03-16T11:30:32
|
|
Fix download_restricted_traces.py :: run_command()
run_command() was using the undefined variable 'cmd', rather than the
pass in parameter 'command'.
Bug: angleproject:5210
Change-Id: I5e80869b18b717835217ad14a562bb4d223d52c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2765005
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
c99e405c
|
2021-03-12T12:39:27
|
|
Disable timestamp queries for some GPUs on Android
Copy some workaround from chromium.
Bug: chromium:702980,chromium:477514,chromium:462553,chromium:1178333
Change-Id: I9acb6ef49c91193a9e6bb03c6fc5eabf336cba9a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2756728
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
687d3153
|
2021-03-15T16:55:26
|
|
Skip plants_vs_zombies_2 on Windows+AMD
Step "angle_restricted_trace_gold_tests on ATI GPU on Windows on
Windows-10" failing on builder "Win10 FYI x64 Release (AMD RX 5500 XT)"
Bug: chromium:1187752
Change-Id: Ia48dd06c3e3aca66ff3194fc945e3c235fde85df
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2762645
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
cd881848
|
2021-03-12T15:26:36
|
|
Actually skip a flaky/timeout test
Also, create SwANGLE KHR 3.1 expectations section
Bug: angleproject:5755
Change-Id: I902b3d3de0c3c4dd190d36c6b5f2def33420efc7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757125
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
191bee56
|
2021-03-12T13:44:19
|
|
Suppress flaky test on win-swangle
This test times out. It takes a while on my underpowered Windows
laptop.
Bug: angleproject:5755
Change-Id: Id112c170a5e57c8e765dd94277ce0cf2801fae6d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757118
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
4f6d4d6f
|
2021-03-12T10:32:57
|
|
Suppress flaky EGL resize failure on Linux
Bug: angleproject:5753
Change-Id: I0bf716b09d329e9881bf5ca146ef6839d898a1b4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757107
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
89d2a96a
|
2021-03-09T18:37:57
|
|
Vulkan: Add test for UBO descriptor allocations.
This performance counter test verifies that re-binding the same
two buffers repeatedly doesn't allocate new descriptor sets. Currently
the test fails because we don't cache descriptor sets for UBOs.
Covers equivalent code patterns in Asphalt 9.
Reorganizes the perf counters collected for the program objects. Now
they are per-frame reset instead of cumulative. This tracking is now
consistent for the different counter types. In the future we can add
cumulative tracking for all per-object and global perf counters.
Bug: angleproject:5736
Change-Id: I23d04b6453e38af1cf4af7274d24382d136efad3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2746176
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
cef5b717
|
2021-03-11T09:22:33
|
|
EGL: Add attribute check in ValidateQueryContext
Implementation of EGL_IMG_context_priority was
missing attribute check in ValidateQueryContext
Add test case.
Test: angle_end2end_test --gtest_filter=EGLCreateContextAttribsTest
Bug: angleproject:5746
Change-Id: Idf5df29fcb343d969a031675b6c5985a9be0a705
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752891
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
225e1952
|
2021-03-11T17:05:43
|
|
Tests: Add Plants vs. Zombies 2 trace
Test: angle_perftests --gtest_filter="*plants_vs_zombies_2*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/182512556
Bug: angleproject:5749
Change-Id: Ib6c279f49ac95964f34e430d311a49600928166b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752898
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
d98e436a
|
2021-03-11T13:32:07
|
|
Tests: Add Lineage M trace
Test: angle_perftests --gtest_filter="*lineage_m*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/182491024
Bug: angleproject:5748
Change-Id: I901b68eef1ddac98ce6e1a4640e2b034d1027a45
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752894
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
c5a7da47
|
2021-03-11T13:12:04
|
|
Suppress flaky MultithreadingTest on Win/Swangle
MultithreadingTest.MultiContextDrawWithSwapBuffers/ES3_Vulkan_SwiftShader_NoVirtual
Bug: angleproject:5099
Change-Id: I12ab4a6fb7fff8d6bc7358e6017cb10e46362b88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752893
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>
|
|
|
7c7cf3e5
|
2021-03-11T14:27:51
|
|
Skip dEQP tests flakily timing out on SwANGLE
Bug: chromium:1173237
Change-Id: I93810cb7cbaae847848eae0dc050c2c00df956af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2753144
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
7c02cfee
|
2021-03-11T19:01:13
|
|
Avoid undefined behavior in BPTCCompressedTextureTest
Bug: angleproject:5360, angleproject:5731
Change-Id: Ia883d2d319d7ce4659f4e1e99b5eccf0e01a45e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752747
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
36770173
|
2021-03-10T15:23:03
|
|
capture_replay_tests: Don't shadow subprocess import.
Rename local variable, so using subprocess.Timeout does not result in
an exception.
This patch fixes the test timeout counter.
Bug: angleproject:5742
Change-Id: Ib6991bc58df6ea653f765dfe9f6117add75b85db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2748339
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
9265d1e2
|
2021-03-05T17:54:59
|
|
frame_capture_utils: Do not serialize 0 bindings.
Since we are only interested in the difference to non-default states,
bindings with a zero ID should not be serialized.
This resolves the comparision error in the GetTexLevelParameterTest.*
tests. The test now do not need to be skipped.
Bug: angleproject:5645
Change-Id: I887bc22b52a201c467c00c42f6ddb3b38895a7c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739726
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
|
44b9579c
|
2021-03-10T08:10:33
|
|
Vulkan: Treat varyings in a separable program as active
When separable programs are linked, varyings at the separable program's
boundary need to be treated as active.
Bug: angleproject:5557
Test: ProgramPipelineTest31.VaryingIOBlockSeparableProgram*
Change-Id: I28af2bdf6478a408b3a7155ab4376ed6a19192f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2742659
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
04a641ac
|
2021-03-04T10:57:37
|
|
capture_replay_tests: Change status to crashing.
Move both SemaphoreTests to crashing.
Don't skip passing VulkanExternalImageTest.*.
Explicitly list VulkanExternalImageTest.* tests that still crash.
All these tests compile now.
Bug: angleproject:5721
Change-Id: Ib529dff8895496925001e4649aabcae78ce77236
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739725
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
c9c75b99
|
2021-03-04T10:21:03
|
|
capture_gles_ext_params: Implement glGetIntegervRobustANGLE.
Move RobustClientMemoryTest.* to crashed tests, as it builds now.
Bug: angleproject:5721
Change-Id: I590f4bd679374ee3302fc985a53747ddd60dd429
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739724
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
14152cf4
|
2021-03-09T11:53:41
|
|
Tests: Add Extreme Car Driving Simulator trace
Test: angle_perftests --gtest_filter="*extreme_car_driving_simulator*"
TBR: jmadill@google.com, timvp@google.com
Bug: b/180419767
Bug: angleproject:5735
Change-Id: I5c197a71354a0cb3b907718b7ae7161037f7266f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743806
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
c935ba5b
|
2021-03-09T08:40:22
|
|
Vulkan: Collect inactive varyings by block name for I/O blocks
ANGLE only collects inactive varyings by instance name. The SPIR-V
transformer expects I/O blocks to be identified by block name. If an I/O
block is inactive, an assertion would fire because the block name is not
in the shader variable info map.
Bug: angleproject:5676
Test: GLSLTest_ES31.VaryingIOBlockNotDeclaredIn*Shader*
Change-Id: I40e51c9770b03457e3896dcb2afa4e9525b098d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2742658
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
|
7f1c0c3b
|
2021-03-09T08:09:55
|
|
Call resolveLink in Program::attachShader and Program::detachShader
Previously glAttachShader and glDetachShader would only call
resolveLink during validation.
Adding the resolveLink in attachShader/detachShader handles the case
where glAttachShader and glDetachShader is called with
EGL_CONTEXT_OPENGL_NO_ERROR_KHR to skip validation.
Tests: angle_end2end_tests --gtest_filter=ContextNoErrorTest.DetachAfterLink*
Bug: angleproject:2868
Change-Id: I1e01cf8e6f8a382333226bdef037c46f4c62a119
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745654
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
|
ac382039
|
2021-03-08T16:02:18
|
|
Allow graceful no-error failure in CastStateValues.
Bug: angleproject:5738
Change-Id: Iecc498b35281b8fd676f1168c3a4ed6b407d18a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743668
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
b27740f3
|
2021-03-09T16:15:15
|
|
Revert "Vulkan: Support EXT_sRGB_write_control"
This reverts commit 6073af536cf627742696823edc82c9b0a481a8bc.
Reason for revert: crbug.com/1186140
Original change's description:
> Vulkan: Support EXT_sRGB_write_control
>
> Implement support for EXT_sRGB_write_control. This extension
> requires VK_KHR_image_format_list to be supported.
>
> The spec requires this functionality to work with glBlitFramebuffer
> as well but support for that will be added in a follow up change.
> As such, this extension is only exposed in non-conformant mode.
>
> Bug: angleproject:5075
> Tests: SRGBFramebufferTest.*Vulkan*
> Change-Id: I59b38f6cd810a3d0d67ec29f4f19c25f65f70862
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617243
> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: angleproject:5075,chromium:1186140
Change-Id: Ib0d4d60fe7434fb950f99db2c210aab9af7d2d0e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743663
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Peng Huang <penghuang@chromium.org>
|
|
|
57727c4e
|
2021-03-08T17:32:25
|
|
Further suppress tests failing on Ozone.
Since MipmapTest and Texture3DTestES2 fail in testSetUp(),
it also needs to be skipped, in addition to the failing tests.
Also suppress instantiation error for ES3-only QueryObjectTest
Bug: angleproject:5725, angleproject:5728, angleproject:5704
Change-Id: Iac6549afd7609a2aee78bcfdb7c3de41886f3505
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743920
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
6073af53
|
2021-03-08T11:21:31
|
|
Vulkan: Support EXT_sRGB_write_control
Implement support for EXT_sRGB_write_control. This extension
requires VK_KHR_image_format_list to be supported.
The spec requires this functionality to work with glBlitFramebuffer
as well but support for that will be added in a follow up change.
As such, this extension is only exposed in non-conformant mode.
Bug: angleproject:5075
Tests: SRGBFramebufferTest.*Vulkan*
Change-Id: I59b38f6cd810a3d0d67ec29f4f19c25f65f70862
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617243
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
92b5fccd
|
2021-03-02T08:43:18
|
|
Handle nullptr in GetQueryObjectParameter()
There are applications that disable validation using
EGL_CONTEXT_OPENGL_NO_ERROR_KHR extension. In such usecases
the GetQueryObjectParameter() method needs to account for the
possibility that the query object has not yet been created.
Bug: angleproject:5704
Tests: angle_end2end_tests --gtest_filter=QueryObjectTest*
Change-Id: Ib9e1cb32a6d64f2772124178223cf07cbb84691b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729298
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
|
a0bc2589
|
2021-03-05T19:27:04
|
|
Skip tests failing on Ozone.
MipmapTest.DefineValidExtraLevelAndUseItLater
MipmapTest.GenerateMipmapAfterModifyingBaseLevel
MipmapTest.GenerateMipmapAfterSingleLevelDraw
MipmapTest.GenerateMipmapFromInitDataThenRender
MipmapTest.GenerateMipmapFromRenderedImage
MipmapTest.MipMapGenerationD3D9Bug
MipmapTest.MipmapsForTexture3DOES
MipmapTest.RenderOntoLevelZeroAfterGenerateMipmap
MipmapTest.TextureCubeGeneralLevelZero
MipmapTest.TextureCubeRenderToLevelZero
MultisampleTest.AlphaToSampleCoverage
MultisampleTest.ContentPresevedAfterInterruption
MultisampleTest.Line
MultisampleTest.Point
MultisampleTest.Triangle
Texture3DTestES2.CopySubImageAlpha
Texture3DTestES2.CopySubImageLuminance
Texture3DTestES2.CopySubImageRGBA
Texture3DTestES2.Luminance
Texture3DTestES2.RGBA
Bug: angleproject:5725, angleproject:5727, angleproject:5728
Change-Id: Ibe7d7e44e01ce430e381edd0c83c3e24069b35aa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2738718
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
a318b3d6
|
2021-03-05T16:38:47
|
|
Roll VK-GL-CTS from 9cdde06fb38a to 9be79728eafb (18 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9cdde06fb38a..9be79728eafb
2021-03-02 ynovikov@google.com Fix Windows build
2021-03-01 alexander.galazin@arm.com Update Vulkan headers
2021-02-25 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master
2021-02-25 rgarcia@igalia.com Pipeline bind point tests
2021-02-25 rgarcia@igalia.com Add tests for sparseImageFloat32Atomics
2021-02-25 anholt@google.com Fix more spurious failures in KHR-GL*.transform_feedback.api_errors_test
2021-02-25 anholt@google.com Fix spurious failures on KHR-GL30.transform_feedback.api_errors_test
2021-02-25 tapani.palli@intel.com Print ints for pixel values instead of chars in error message
2021-02-25 thomas.spurden@broadcom.com Fix exit code for cts-runner
2021-02-25 mikko.tiusanen@siru.fi Tests for GLES3 framebuffer completeness
2021-02-25 alexander.galazin@arm.com Support GL 4.5 in the Program interface query tests
2021-02-25 lionel.g.landwerlin@intel.com Silence validation layers warning on missing sType
2021-02-25 mika.vainola@siru.fi Allow wildcards in waiver vendor strings
2021-02-25 boris.zanin@mobica.com Add a list of unused shaders into log
2021-02-25 boris.zanin@mobica.com Add concurrent transform feedback streams query tests
2021-02-24 gleese@broadcom.com Remove a waiver for a non-existant device
2021-02-23 mika.vainola@siru.fi Add tests for implicit unmap on free
2021-02-23 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC jonahr@google.com,angle-bots+autoroll-info@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: angleproject:5684, angleproject:5722
Tbr: jonahr@google.com,angle-bots+autoroll-info@google.com,ynovikov@google.com
Change-Id: Ibd432a2135665ed89f93549e24923c108a08f97b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739041
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
a1f86b4d
|
2021-03-05T16:55:47
|
|
Skip vulkan_car_parking_multiplayer on Win Intel
Internal Vulkan error (-4):
The logical or physical device has been lost.
Bug: angleproject:5724
Change-Id: I80eb21d087341fac23393d7365bd5ea4c5ac6e05
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739387
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
8a48f4de
|
2021-03-05T14:33:16
|
|
Skip CopyTextureVariationsTest failing on Ozone
CopyTextureVariationsTest.CopyTexture
CopyTextureVariationsTest.CopySubTexture
Bug: angleproject:5723
Change-Id: Iad62344b9bc503a2553647877c5975b03bb6829d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2738602
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
d96b9ffa
|
2021-03-04T09:57:53
|
|
capture_replay_tests: Don't skip tests that pass.
These tests were skipped due to compilation problems, but do now fully
pass on SwiftShader ES2.
Remove PointSpritesTest.PointWithoutAttributesCompliance/*
Remove ExplicitContextTest.GetProcAddress/*
Remove RobustBufferAccessBehaviorTest.EmptyBuffer/*
Remove EGLSyncTest.AndroidNativeFence_WaitSync/*
Bug: angleproject:5721
Change-Id: I3f50272c69ba78e2432f4278753e5d48d8601910
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739723
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
fe2efefa
|
2021-02-27T08:28:03
|
|
Add FramebufferAttachmentPerfTest
Two tests are added to measure the overhead involved in the
Observer/Subject interface -
1. FramebufferAttachmentBenchmark - stresses repeated attach/detach
of observers to subjects.
2. FramebufferAttachmentStateUpdateBenchmark - stresses state updates
to subjects and their propagation to observers.
Bug: angleproject:5692
Change-Id: I6e573f3a948ef2b20c56091e549eb871051e0103
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2725740
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
2f737c25
|
2021-02-25T16:55:14
|
|
Translator: Rename GLSL to SPIR-V in Vulkan and Metal output
Preparation for actual SPIR-V output instead of GLSL.
Bug: angleproject:4889
Change-Id: Ic279b23d3a817bd5dca66a844905378207afdbac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2721194
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
a6b16d29
|
2021-03-02T19:04:57
|
|
Suppress UNINSTANTIATED_PARAMETERIZED_TEST failures on Ozone
We only support ES2 on Ozone, so tests that depend on ES3 or ES31
support are not instantiated there.
Bug: chromium:1183147
Change-Id: Id58bcd9b44a5b9a70b5ae8115e27c44f5dc81226
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2726550
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
54294c9a
|
2021-03-02T22:15:05
|
|
Partially upgrade codegen to Python 3
Bug: angleproject:5707
Change-Id: I4e26c2c7ba4a36185b28ecd6e87be1161b60431a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729567
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
d8557cc8
|
2021-03-03T10:17:46
|
|
Fix for readPixels() to PBO fast path.
Include the "pixels" (data) pointer as offset.
Bug: angleproject:5702
Change-Id: Idc9f3ee4c0dbb1cc9308393bbf877d6137598486
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2732789
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
|
|
|
71c7e346
|
2021-03-02T21:52:35
|
|
Tests: Add Rope Hero: Vice Town trace
Test: angle_perftests --gtest_filter="*rope_hero_vice_town*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/181727986
Bug: angleproject:5711
Change-Id: I11021ae91f968bd453b98a35c60cab90d71e5ed6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2731288
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
18314bce
|
2021-03-03T10:28:07
|
|
Tests: Skip car_parking_multiplayer on Nvidia
The trace doesn't cause any errors, which would have blocked
landing it. But it does spew undefined behavior warnings which
fills the log. See the bug for details, skipping for now.
Test: angle_perftests --gtest_filter="*car_parking_multiplayer*"
Bug: angleproject:5613
Change-Id: I54bf63eeb7c5212b6ce40cf2b45354822e8456e7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2733089
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
cdef22a5
|
2021-03-03T10:19:31
|
|
Skip TransformFeedbackTest.MultiContext on Metal
This test is flaky on the metal backend.
Bug: angleproject:5713
Change-Id: I1d789825e0322f00b017a60f8fd1cef02b5b3088
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2732787
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
fbbd143b
|
2021-02-27T17:42:05
|
|
Tests: Add Talking Tom Hero Dash trace
Test: angle_perftests --gtest_filter="*talking_tom_hero_dash*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/181415750
Bug: angleproject:5614
Change-Id: I6110f5e3e6bbc60706c448ad3643de73b3c2eca2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2726134
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
1de8b5a6
|
2021-03-02T14:42:22
|
|
Tests: Add Car Parking Multiplayer trace
Test: angle_perftests --gtest_filter="*car_parking_multiplayer*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/181696940
Bug: angleproject:5710
Change-Id: I50366e0bb993c1f19906aa5d96f47a00247a24f6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2729605
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
210a464e
|
2021-03-02T12:05:08
|
|
Test: Add Standoff 2 trace
Test: angle_perftests --gtest_filter="*standoff_2*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/181681788
Bug: angleproject:5708
Change-Id: I36314d1addc880cc4fb0dc321cda4ba3eabab000
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2728662
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|