kc3-lang/angle

Log

Author Commit Date CI Message
Yiwei Zhang df946856 2022-08-22T20:36:52 Map RGBX AHB to GL_RGBX8_ANGLE and fix the load function AHARDWAREBUFFER_FORMAT_R8G8B8X8_UNORM was false mapped to GL_RGB8, which will write back to the backing exteranl storage with 3 channel layout. Angle actually has ANGLE_rgbx_internal_format to fix the mapping with GL_RGBX8_ANGLE. However, the load function must align with GL_RGB8 if the actual storage is 4 channel. This change also fixes that to use LoadToNative3To4<GLubyte, 0xFF>. Bug: b/238460927 Test: CtsNativeHardwareTestCases#SingleLayer_ColorTest_*_R8G8B8X8_* Test: ImageTestES3.RGBXAHB* pass without VVL error Change-Id: Ic5db4cb4adba252949d64e560ff32e492a045912 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3846413 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com>
angle-autoroll eab2d546 2022-08-23T10:14:33 Roll vulkan-deps from 186a4d4b9dea to 1b46e43d5ccc (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/186a4d4b9dea..1b46e43d5ccc Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/40315fa5c0..55f77c5de1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I3d925dd82f280ca7b69d71c544e8aa3a425dfb19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3849474 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 7131475e 2022-08-23T08:37:28 Roll Chromium from e1b4daf2a3e7 to 02dbf021e1a1 (568 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e1b4daf2a3e7..02dbf021e1a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/facb235241..ba78bc1980 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a30c0d90b3..d315e68997 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9bfc1aede5 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/44b73307ee..19b3eb5adb * third_party/fuchsia-sdk/sdk: version:9.20220821.3.1..version:9.20220822.3.1 * third_party/turbine: RxaW8ZVJZ7rF3dbAGbL1OV6f9ZELjVeiiQbpkDsuxA4C..cMFT-KTiKSkVefC3nASLc0KQv9JrVmwmFUgJlo6jOosC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/bd2da0345a..5f3c54dbcc * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/398778992d..62249027a7 * tools/skia_goldctl/linux: eVmrBHTaHLBRrBHBIagAjRi84M8Pih7goWAjl0ZL9H0C..BcL4zQgD0tZoFzhWm37NnERAPLdbeERfbY_SSBQ3ba4C * tools/skia_goldctl/mac_amd64: 3fnB8n0m7xQ9X4SWg4rYgZksJ4YFew0fj6ftsyHzbSwC..8DiQ6WFPrEn56-jwyQmU4EMXFvf7_-8SYjVD2hHHmZMC * tools/skia_goldctl/mac_arm64: J_MizgwQbTOCG1ZKfGQJRXm-F2Ey8P3M7Dl5WxYKEwwC..lJ8l4RCPxwrg_f-Z9Lnu3Ma3uRlbRbAcdQA7xwpIzNUC * tools/skia_goldctl/win: aYli_YA93vex9TPItiLM1AcLs64FzefvhXxh2aHEvJsC..1l0XEVvr2qVUdGYrjLN9Gkt6qfv8KsXM52B8MKDShmEC No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I3f559e4bc087b0a90f31e6b8b9a655e7cf9adc27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3849466 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Chris Dalton 6fde3568 2022-08-09T16:42:17 Spec out the PLS client API Drafts the additions to the OpenGL ES 3.0 spec for pixel local storage. Bug: angleproject:7279 Change-Id: Ibc0d227142ac51f5d3820f27c9114779d846ffc2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3824171 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Mohan Maiya b32091b4 2022-08-17T16:00:02 Vulkan: Bug fix related to pre-rotation code Account for possiblity that the draw and read surfaces are different when querying pre-rotation information. When updating mCurrentRotationDrawFramebuffer and mCurrentRotationReadFramebuffer, make sure to query pre-rotation information from current draw and read surfaces. Bug: angleproject:7581 Test: FramebufferTest_ES3.BlitWithDifferentPreRotations* Change-Id: Ibe7a2450907e53aa5c33e13cff00059ab2f6602e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3836491 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Shahbaz Youssefi 952d6e8f 2022-08-21T21:51:03 Vulkan: Workaround ARM driver bug with dynamic vertex strides According to ARM, vkCmdBindVertexBuffers2EXT is broken when more than one attribute binding is involved. In this change, the vertex strides dynamic state is avoided altogether on ARM. Bug: fuchsia:107106 Change-Id: Ie41fc07037083214d2dc99e4ed062485384911c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3844640 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Eddie Hatfield bd1484f3 2022-08-22T13:53:35 Temporarily disable shader caching feature This will be re-enabled when the BlobCache test flakes are resolved. Bug: angleproject:7036 Change-Id: I38829ffcd5869679bf65017475e8a10d165f369b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3846403 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Eddie Hatfield <eddiehatfield@google.com> Reviewed-by: Lingfeng Yang <lfy@google.com>
angle-autoroll 86a35a4b 2022-08-22T19:09:40 Roll vulkan-deps from d53c356ad7d9 to 186a4d4b9dea (48 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d53c356ad7d9..186a4d4b9dea Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/adf7bf0113..10423ec659 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0a43a84e02..3c1a14b2b6 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/c896e2f920..715673702f * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a0ab2f162e..40faec799c * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/497f232680..439026106a * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/529a4320d3..40315fa5c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:7593 Change-Id: I9bfc09ca04025829881af9d03b2073a6f24234c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3846057 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Kimmo Kinnunen e22eb503 2022-08-22T11:46:53 Metal: Report Metal being available on iOS simulator Make Metal backend always available on iOS simulator. Currently the GPU family query is not useful as it does not return anything that would enable Metal ANGLE to be used. However, testing on iOS simulator is still useful. Bug: angleproject:7591 Change-Id: I0aa881bb7482fc63bbaa08d5efc10920b3c1af43 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3845154 Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
angle-autoroll a8ffbef8 2022-08-19T21:02:14 Roll VK-GL-CTS from 5a93cd60f33b to 435ebaff9214 (5 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/5a93cd60f33b..435ebaff9214 2022-08-19 quic_mnetsch@quicinc.com Merge vk-gl-cts/opengl-cts-4.6.2 into vk-gl-cts/main 2022-08-18 piotr.byszewski@mobica.com Add coverage for MaxAtomicCounterBufferSize 2022-08-18 piotr.byszewski@mobica.com Check that image*Shadow are not reserved keywords 2022-08-18 piotr.byszewski@mobica.com Fix vkGetPhysicalDeviceProperties2 query 2022-08-18 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:7592 Change-Id: I87bd89dd6ad63e2fa28ae87cdd4a91555d56e203 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3842857 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Lingfeng Yang caf2b427 2022-07-01T18:17:30 Vulkan: Add feature to use PASS_THROUGH for EGL_NONE color spaces This is a temporary solution to fix media tests until ANGLE also has the ability to query the "preferred color space" from Surfaces. Bug: b/235995022 Test: Launch Cuttlefish with this change and the feature enabled with aosp/2167231 Test: cts -m CtsMediaCodecTestCases -t android.media.codec.cts.EncodeDecodeTest Test: cts -m CtsMediaCodecTestCases -t android.media.codec.cts.DecodeEditEncodeTest Change-Id: I17d1a2c1701cd1707b34f5bf2f222e9ad57c7a61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3770291 Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Commit-Queue: Jason Macnak <natsu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com>
Roman Lavrov f30cfd18 2022-08-16T16:50:33 Perf and gold tests detect test SKIPs from json results. Make angle_test_util.RunTestSuite() gets and returns json results (using --isolated-script-test-output). perf tests has an additional special case (filed https://anglebug.com/7578): Previously when metrics were missing it was assumed that this was due to tests being skipped - which seems to currently be the case except for the special case of GLMark2Benchmark* tests. Those produce .fps/.score metrics instead of the metrics expected by this script. This CL keeps those tests running (once) but then marks them as SKIP in test results when no metrics are found (which is the behavior before this CL; it might actually make more sense to count this as PASS because everything matches our expectations). We're still running them once, so if they FAIL we'll get notified. gold tests: Use json results file instead of checking for '[ SKIPPED ]' in stdout. Bug: angleproject:7299 Bug: angleproject:7578 Change-Id: Ia751784ad1aa94dc855c8b58ebfe5ba3e06e462f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3826167 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 4b4c90ef 2022-08-22T10:01:27 Roll SwiftShader from 1c3dfde53353 to c21aa26e0256 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/1c3dfde53353..c21aa26e0256 2022-08-19 nicolas.capens@gmail.com Simplify clipping of complex polygons 2022-08-19 nicolas.capens@gmail.com Update Vulkan headers to version 1.3.225 2022-08-19 swiftshader.regress@gmail.com Regres: Update test lists @ 1c3dfde5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I1c34d56ba212e1ce8f5632cb88474e6d5feeba70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3842446 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 676bc8ed 2022-08-22T07:00:03 Roll Chromium from 336269709208 to e1b4daf2a3e7 (602 revisions) https://chromium.googlesource.com/chromium/src.git/+log/336269709208..e1b4daf2a3e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ca7f2297ff..facb235241 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/3a4c85002c..6f3cc96d10 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/db72216693..c58c612d74 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d2e4dc7655..6c17e7c636 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/f87795ea5b..42aa6de554 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/8fade393ad..a30c0d90b3 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..9bfc1aede5 * third_party/fuchsia-sdk/sdk: version:9.20220817.2.1..version:9.20220821.3.1 * third_party/r8: qvL35O3yU1ZbOWHVZBedmVtdaav1qKquii4RJyUh-PgC..2P7CTTsDUzoP3f8LtGNRdtwC48KAMmV-hPoNhGAwiKMC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a56fd8b0a2..bd2da0345a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d2cfb95d99..398778992d * tools/skia_goldctl/linux: vguZysogLzkycKzCMUUxjQNXAY4wQigIBE83puLd_8YC..eVmrBHTaHLBRrBHBIagAjRi84M8Pih7goWAjl0ZL9H0C * tools/skia_goldctl/mac_amd64: nmPC1ukuYnMcvcfOIlAG5AbUIL_J9LSUaFkegd6BPF0C..3fnB8n0m7xQ9X4SWg4rYgZksJ4YFew0fj6ftsyHzbSwC * tools/skia_goldctl/mac_arm64: B2gt4DQ8QHw4DRrXPgm6d05bbWE5-6hNolIlFc8WECIC..J_MizgwQbTOCG1ZKfGQJRXm-F2Ey8P3M7Dl5WxYKEwwC * tools/skia_goldctl/win: nOvtL4uNJDJw0xbMHz5X0t6RPhp-WQ7eFnxDpCkrmlEC..aYli_YA93vex9TPItiLM1AcLs64FzefvhXxh2aHEvJsC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Iedba1328a8534d03ee0154a1a8ac0b4b7c2d6895 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3844859 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 31ac3fef 2022-08-21T21:30:53 Lift suppression of passing test Bug fixed in https://chromium-review.googlesource.com/c/angle/angle/+/3835168, but a suppression for the test landed in the meantime Bug: angleproject:7583 Change-Id: I14a3e59a6270bfee8288dd733938a18cbf491c20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3844638 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Kimmo Kinnunen b9c3c5d6 2022-08-18T13:38:49 Metal: Fix MTLArgumentEncoder leak in InitArgumentBufferEncoder Patch by David Kilzer <ddkilzer@apple.com> Metal functions with "new" prefix return objects with refcount +1. Adopt the ref to the ObjCObj smart pointer. Bug: angleproject:7577 Change-Id: I57b1ac031aa9cf179288879359d3c88dbd168caa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3834820 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com>
Shahbaz Youssefi 9a258281 2022-08-17T17:47:22 Fix submit-count perf counter test on ARM On ARM, the preferSubmitAtFBOBoundary feature causes extra submissions that need to be taken into account. Bug: chromium:1337538 Change-Id: Id545ee3e65fc943aff51ea3721e9c19bc0afd4a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3835168 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 4330a827 2022-08-19T02:59:26 Reland "Vulkan: Use VK_EXT_primitive_topology_list_restart" This reverts commit 29d18b303189bf31b3af3a85c3df6013114eebc8. Reason for revert: Fixed VVL suppressions not working Original change's description: > Revert "Vulkan: Use VK_EXT_primitive_topology_list_restart" > > This reverts commit e79c9cd63053b6cb7c33235f3a0a0310255df073. > > Reason for revert: Causing timeouts on some headless tests: anglebug.com/7579 > > Original change's description: > > Vulkan: Use VK_EXT_primitive_topology_list_restart > > > > From ANGLE's point of view, there is nothing to do with this extension > > other than enable a feature that silences a validation error. > > > > Bug: angleproject:3832 > > Change-Id: I094343d09c322e2848a65a5bc775d0f21388fb46 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3562380 > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: mohan maiya <m.maiya@samsung.com> > > Bug: angleproject:3832 > Change-Id: Ifec7c9eaea1d3a949f15e0b6d868742f53cf8377 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3838391 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:3832 Change-Id: Ia79b1f3b716f0df1991f605704135b4af48fb639 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3841366 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll b8b44fc8 2022-08-19T10:01:27 Roll SwiftShader from ab4bf6ad00d4 to 1c3dfde53353 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/ab4bf6ad00d4..1c3dfde53353 2022-08-18 sugoi@google.com Added missing null pointer check on pDepthStencilResolveAttachment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: If137f8a9d890bbcd76f4ff3446c78bf7a5bd1fe4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3841615 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 8ef496b1 2022-08-19T07:59:29 Roll Chromium from 7f3befa9aba1 to 336269709208 (495 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7f3befa9aba1..336269709208 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/138d9667f4..ca7f2297ff * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2c110db042..3a4c85002c * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/9de2fe0403..db72216693 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/039323b945..d2e4dc7655 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/12726c93aa..f87795ea5b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b1f7ac5d7d..8fade393ad * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..72946313ec * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d14f65eba9..44b73307ee * third_party/fuchsia-sdk/sdk: version:9.20220817.1.1..version:9.20220817.2.1 * third_party/r8: lAcTGSK3VDSH4DI3H3q0XIg8y0wBVz7IS1Fk_Zbd3iYC..qvL35O3yU1ZbOWHVZBedmVtdaav1qKquii4RJyUh-PgC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/1d2e3651d3..ad8b831158 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/660d26d81a..d2cfb95d99 * tools/skia_goldctl/linux: ebDbf3X2jdAICDlXMXUr7yp4muhSvYoREDLdZZoJzuAC..vguZysogLzkycKzCMUUxjQNXAY4wQigIBE83puLd_8YC * tools/skia_goldctl/mac_amd64: yE_XL6pbQ8M0WuI236ObRlkSxu0XMdWs_AnUeo21wa8C..nmPC1ukuYnMcvcfOIlAG5AbUIL_J9LSUaFkegd6BPF0C * tools/skia_goldctl/mac_arm64: l46gUmkc-2-OsEMo-oEbpXiBAYg48KtXbtF1lyBh0u8C..B2gt4DQ8QHw4DRrXPgm6d05bbWE5-6hNolIlFc8WECIC * tools/skia_goldctl/win: 58nNno6pNLLSJaZknYmuijuo5gy2tfRBKNI1iCldDlcC..nOvtL4uNJDJw0xbMHz5X0t6RPhp-WQ7eFnxDpCkrmlEC No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Id2363d794151456c9b3b83165d8a95ed54ad903f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3840202 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Faye Zhang 6d153b7d 2022-07-06T12:34:22 Implement BaseInstanceEXT Capture Entry Points In order to support Capture/Replay of apps that use GL_EXT_base_instance functions, their GLES EXT Capture functions should be implemented. Bug: angleproject:7477 Change-Id: Idb96b66ca5a7c96f1883402e62934acc33bd24c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3749796 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 29d18b30 2022-08-18T18:18:04 Revert "Vulkan: Use VK_EXT_primitive_topology_list_restart" This reverts commit e79c9cd63053b6cb7c33235f3a0a0310255df073. Reason for revert: Causing timeouts on some headless tests: anglebug.com/7579 Original change's description: > Vulkan: Use VK_EXT_primitive_topology_list_restart > > From ANGLE's point of view, there is nothing to do with this extension > other than enable a feature that silences a validation error. > > Bug: angleproject:3832 > Change-Id: I094343d09c322e2848a65a5bc775d0f21388fb46 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3562380 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: mohan maiya <m.maiya@samsung.com> Bug: angleproject:3832 Change-Id: Ifec7c9eaea1d3a949f15e0b6d868742f53cf8377 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3838391 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov eb8488e1 2022-08-18T15:43:49 Skip end2end failures on Pixel 6 Android 13 TP1A.220624.021 Bug: angleproject:7583 Change-Id: Ib9a44c222207b6f2c70733738f1c440c6d6a7ce8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3838857 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
angle-autoroll c6c7ff3c 2022-08-18T10:01:26 Roll SwiftShader from 5ac9bd16c803 to ab4bf6ad00d4 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/5ac9bd16c803..ab4bf6ad00d4 2022-08-17 nicolas.capens@gmail.com Ignore VK_INSTANCE_CREATE_ENUMERATE_PORTABILITY_BIT_KHR If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: Ia5c92f8c541078355f87ae19fc68f88af76f3cdd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3837349 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f5698a8f 2022-08-18T07:00:18 Roll Chromium from 754ede9fc072 to 7f3befa9aba1 (1095 revisions) https://chromium.googlesource.com/chromium/src.git/+log/754ede9fc072..7f3befa9aba1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8bf02cb228..138d9667f4 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/431d9c2d82..2c110db042 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/5df82514bc..9de2fe0403 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/030b4ebf32..12726c93aa * testing: https://chromium.googlesource.com/chromium/src/testing/+log/dbe2ab9dc9..b1f7ac5d7d * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/d22f28635a..4ef58b7319 * third_party/android_build_tools/manifest_merger: 0WkAedh1tJB8lzisWJRT80UjpacKLltuV7NqP-0tx9gC..CvokX4c6dx7DwQ8VVMQ70CROzyJWg13oOq3feeuTzg8C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e12cc61cfa * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/268d645853..d14f65eba9 * third_party/fuchsia-sdk/sdk: version:9.20220812.1.1..version:9.20220817.1.1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/cca1e66cd5..dd32a150e7 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/22963c3e1f..a56fd8b0a2 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/752991ad1e..1d2e3651d3 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/ca2df581e4..660d26d81a No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I51e4e377c35968da25f1300194c51a224eee507a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3837158 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Eddie Hatfield 955adb77 2022-08-12T10:14:48 Cache compiled shader By storing the compiled shader in the blob cache, the time to recompile the same shader is reduced. Based on work by <hckim.kim@samsung.com> Bug: angleproject:7036 Change-Id: I884ae40e715c49a9ccd12903012e8327811e3557 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3808235 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 2965f81b 2022-08-16T15:26:22 Remove suppression of previously crashed deqp test dEQP-GLES31.functional.shaders.linkage.es31.tessellation.varying.rules#internal_different_precision was fixed in a recent check-in at https://crrev.com/c/3780874. Remove the suppression in the test expectation file. Bug: angleproject:6908 Change-Id: I41025c2555e0c21ff8faaa888842201d26499205 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3828139 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Sean Risser 266d0a83 2022-08-09T22:08:03 Skip glObjectLabel in replay capture Similar entry points are also skipped, so it's likely the list was just missing this one. Bug: angleproject:7567 Change-Id: I1d7e37b35960fd71fdec9143d9193dee6f97e1f1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3824777 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Geoff Lang eb535deb 2022-08-17T16:59:57 Don't set the framebuffer read buffer dirty bit on ES2. glReadBuffer is not added until ES3. Make sure we don't tell the backend to synchronize the read buffer state unless it's supported. Bug: chromium:1346132 Change-Id: I9836d6baac5a250c1fddf5d3ec6d395228e118db Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3835167 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com>
Mohan Maiya 7a87e90d 2022-07-16T11:39:08 An inactive but alive thread shouldn't prevent cleanup 1. Acquire EGL global lock before thread cleanup and remove all clean up related mutexes 2. Mark contexts that are not current as invalid during terminate 3. During thread exit, if there are other active threads, terminate with TerminateReason::InternalCleanup. This gives an opportunity for well behaved threads to cleanup up invalid objects. Bug: angleproject:6723 Bug: angleproject:6798 Test: EGLContextSharingTestNoFixture.InactiveThreadDoesntPreventCleanup* Change-Id: I418e5f8b486d3d309bd58c4cfb04b7dc1149ffc1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3768667 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: mohan maiya <m.maiya@samsung.com>
Roman Lavrov 8fe5fd57 2022-08-17T14:44:21 Reland Copy .vpython3 from chromium/src/+/main:.vpython3 As is; looks like failure was caused by just a bad bot. After https://crrev.com/c/3835165 now tests actually run on this cl, rather than being no-op. (except for verify_pep425_tag which doesn't look like something we want) As Jamie noted on https://crrev.com/c/2408717 it can't be easily auto-rolled from the Chromium src/ repo Swarming switched to vpython3 and can't be hacked back easily (https://crbug.com/1346781#c24) so it's probably a good time to just go for this and figure out what is missing or broken (if anything) Bug: chromium:1346781 Bug: angleproject:7576 Change-Id: Iab6643612d254f9b26e2e935d6b5c96fada895e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3835166 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov 0951686d 2022-08-17T14:28:01 Add .vpython .vpython3 to trigger all tests on changes there. Bug: chromium:1346781 Bug: angleproject:7576 Change-Id: Ic238a95c68cefb5f83b6a8db2ab009ef94ea80c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3835165 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Brian Sheedy 24012abc 2022-08-17T18:06:13 Revert "Copy .vpython3 from chromium/src/+/main:.vpython3" This reverts commit 3b91270fbbf40ad49dca56d440962149da03750c. Reason for revert: Seems to break things. Original change's description: > Copy .vpython3 from chromium/src/+/main:.vpython3 > > (except for verify_pep425_tag which doesn't look like something we > want) > > As Jamie noted on https://crrev.com/c/2408717 it can't be easily > auto-rolled from the Chromium src/ repo > > Swarming switched to vpython3 and can't be hacked back easily > (https://crbug.com/1346781#c24) so it's probably a good time to just > go for this and figure out what is missing or broken (if anything) > > Bug: chromium:1346781 > Bug: angleproject:7576 > Change-Id: Icf574084b036570412e5c6df2b1f9d19ae35d079 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3835164 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Roman Lavrov <romanl@google.com> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Bug: chromium:1346781 Bug: angleproject:7576 Change-Id: Ie5ba7090f4bcbc8f9fd8ec2d80057b371810c403 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3835334 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Roman Lavrov 3b91270f 2022-08-17T12:37:09 Copy .vpython3 from chromium/src/+/main:.vpython3 (except for verify_pep425_tag which doesn't look like something we want) As Jamie noted on https://crrev.com/c/2408717 it can't be easily auto-rolled from the Chromium src/ repo Swarming switched to vpython3 and can't be hacked back easily (https://crbug.com/1346781#c24) so it's probably a good time to just go for this and figure out what is missing or broken (if anything) Bug: chromium:1346781 Bug: angleproject:7576 Change-Id: Icf574084b036570412e5c6df2b1f9d19ae35d079 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3835164 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov 6a8bd801 2022-08-17T11:18:31 Add process_angle_perf_results.py to perf tests data. analyze step doesn't currently trigger angle_perftests on changes to process_angle_perf_results.py Example: https://crrev.com/c/3835162/2 https://ci.chromium.org/ui/p/angle/builders/try/linux-test/7791/overview (so I had to https://crrev.com/c/3835162/3) Bug: chromium:1346781 Change-Id: Id991facedd48036a5c072d910aeb8488712516f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3835163 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 92e4cd75 2022-08-17T10:01:27 Roll SwiftShader from c61fc9aec162 to 5ac9bd16c803 (3 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/c61fc9aec162..5ac9bd16c803 2022-08-17 swiftshader.regress@gmail.com Regres: Update test lists @ a6c3e363 2022-08-16 sugoi@google.com Update Marl to 2f129cf1b 2022-08-16 sugoi@google.com update-marl: run Gerrit hook on generated CLs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: If8613966bb3c427e29898cfda4fb315ac9eea5cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3834831 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 213a1ee6 2022-08-16T12:44:35 Vulkan: Enable VK_EXT_primitives_generated_query Added a test to make sure PGQ works with indirect draws too. Bug: angleproject:5430 Change-Id: Ic91e11906ca34c4f9a50f3442709e544f7f6744c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3826165 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Solti a216cfe8 2022-08-08T21:05:00 Adding angle_perftests test case names in logcat Overview: In logcat, we want to know which test is being executed. The CL 1. makes *ANGLEPerfTest* print the test name 2. wire the trace names in *TracePerfTest* as test names to *ANGLEPerfTest* Local Test: ==== Test 1 ==== - use this build args: http://go/paste/5111738277036032 - ```autoninja -C out/Android && ./out/Android/angle_perftests --gtest_filter="*angry_birds*" --verbose``` - Wait for the test to complete, then run ```adb logcat -d | grep running``` - 4 tests were executed: ``` solti@solti:~/angle$ adb logcat -d | grep running 08-11 18:13:49.757 7690 7721 I ANGLE : running test: TracePerf_Run/vulkan_angry_birds_2_1500 08-11 18:13:59.914 7690 7721 I ANGLE : running test: TracePerf_Run/native_angry_birds_2_1500 08-11 18:14:21.265 7690 7721 I ANGLE : running test: TracePerf_Run/vulkan_angry_birds_2_launch 08-11 18:14:48.030 7690 7721 I ANGLE : running test: TracePerf_Run/native_angry_birds_2_launch 08-11 18:14:58.296 1525 1525 E JobScheduler.Quota: <0>com.google.android.apps.docs has 0 EJ quota without running anything 08-11 18:14:58.296 1525 1525 E JobScheduler.Quota: <0>com.google.android.apps.docs has 0 EJ quota without running anything 08-11 18:14:58.297 1525 1635 E JobScheduler.Quota: <0>com.google.android.apps.docs has 0 EJ quota without running anything solti@solti:~/angle$ ``` ==== Test 2 ==== - follow http://docs/document/d/1W3E7e-YcR5noim_poM0f7Dc0W8AdQDbJ2tFSPXgjpH0? resourcekey=0-VmGDLI3x0q4-sdpQ0n8GSA - setup out/AndroidPerformance - run cmd: ./out/AndroidPerformance/angle_perftests --gtest_filter="*angry_birds*" --verbose --local-output --verbose-output --shard-timeout 100000 --max-steps-performed 1 - then, run cmd: ```adb logcat -d | grep running``` - confirmed the test names are printed ``` solti@solti:~/angle$ adb logcat -d | grep running 08-11 18:22:50.698 8496 8525 I ANGLE : running test: TracePerf_Run/vulkan_angry_birds_2_1500 08-11 18:22:51.599 8496 8525 I ANGLE : running test: TracePerf_Run/native_angry_birds_2_1500 08-11 18:22:51.917 8496 8525 I ANGLE : running test: TracePerf_Run/vulkan_angry_birds_2_launch 08-11 18:22:52.362 8496 8525 I ANGLE : running test: TracePerf_Run/native_angry_birds_2_launch solti@solti:~/angle$ ``` ==== Test 3 ==== - build a Linux build, using the args: http://go/paste/5953043785842688 - run the same test with cmd: xvfb-run ./out/Debug/angle_perftests --gtest_filter="*angry_birds*" --verbose | grep "running test" - confirmed the message is printed: http://go/paste/5800151735074816 Bug: angleproject:6353 Change-Id: I6118a75f54b1648923cb5fe541633d7dd52b20bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3817409 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com>
Roman Lavrov 7c66d77d 2022-08-16T15:06:29 Avoid logging None introduced in https://crrev.com/c/3831885 Currently prints: Test 5/97: DrawCallPerfBenchmark.Run/gles_null_uniform: None Wasn't printing anything before, so this CL goes back to that. Bug: angleproject:7299 Change-Id: I8270129958a93e5c3fbb6cac321fe7e2396a6376 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3834068 Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Roman Lavrov <romanl@google.com>
Roman Lavrov c5efd2b5 2022-08-15T16:20:25 Improve Ctrl-c handling. 1. Restore original handlers after subprocess terminates. Otherwise the installed handlers persist and will swallow sigint outside of subprocess invocations. 2. Raise KeyboardInterrupt when subprocesses terminate to interrupt the script itself. run_perf_tests.py allows for some subprocess failures (--max-errors, with non-zero default). This results in ctrl-c interrupting subprocesses but the script just marks the test as FAIL and keeps running. Bug: angleproject:7299 Change-Id: I2917008baa389491c7591596fc14ee139fa6417e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3831887 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Shahbaz Youssefi e79c9cd6 2022-03-30T23:06:54 Vulkan: Use VK_EXT_primitive_topology_list_restart From ANGLE's point of view, there is nothing to do with this extension other than enable a feature that silences a validation error. Bug: angleproject:3832 Change-Id: I094343d09c322e2848a65a5bc775d0f21388fb46 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3562380 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: mohan maiya <m.maiya@samsung.com>
Solti 428b6788 2022-08-15T17:54:27 Update CHROMIUM_copy_texture.txt to match the code [Overview] The internal format list in the code mismatches the one in the spec txt. see the link below for the missing formats in the spec txt: - http://screen/vDkHo3MFXpE3eQF.png Therefore the CL is matching the spec txt to the code. [Test] CQ DRY RUN completed and passed Bug: angleproject:4228 Change-Id: Ib66fb00b65ce2164779ca7649ec0652910a8e467 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3830892 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 6ee6fac9 2022-08-16T15:02:26 Roll SwiftShader from a6c3e363b7a9 to c61fc9aec162 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/a6c3e363b7a9..c61fc9aec162 2022-08-16 syoussefi@google.com Implement VK_EXT_primitive_topology_list_restart If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: syoussefi@google.com Change-Id: I474d18909df96de1936c77411f9d33d237b0f74a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3834265 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 8878366f 2022-08-15T11:51:00 Refactor to reduce main loop complexity. Bug: angleproject:7299 Change-Id: I157e84b7a6718d59eecb00471d4ec7ae5b3317cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3831885 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Nicolas Capens ad6513fe 2022-08-16T16:06:19 Unconditionally enable EGL_ANGLE_iosurface_client_buffer on macOS EGL_ANGLE_iosurface_client_buffer does not depend on VK_EXT_external_memory_host. Locked IOSurface memory gets copied to/from staging images instead of being imported as device visible host memory. Bug: chromium:1352481 Change-Id: I904e6af53e169ef04446181de91db6f3cdc31530 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3826164 Auto-Submit: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 19eb658f 2022-08-09T10:56:15 Reland "Infra: Enable Skia Gold tests on Pixel 6" Reverted due to timeouts https://crrev.com/c/3594112 which shouldn't be happening now. Bug: angleproject:7216 Change-Id: I9a4b0f9d8e315a103dbdbe3f5e3e7219ae4815d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3819844 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 0f5770de 2022-08-16T07:01:26 Roll Chromium from 16d8164e92a5 to 754ede9fc072 (380 revisions) https://chromium.googlesource.com/chromium/src.git/+log/16d8164e92a5..754ede9fc072 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/89cc6c63d9..8bf02cb228 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/98014eb61a..431d9c2d82 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6cc58d640c..5df82514bc * testing: https://chromium.googlesource.com/chromium/src/testing/+log/95324abbb0..dbe2ab9dc9 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b3421074fa * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/647cfe6bf1..268d645853 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d2890e490f..752991ad1e No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: Ib8adeb3e811f7aa7a937973fcae3a4aac9d9388c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3833276 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 2089943b 2022-08-13T21:48:33 Tests: Add Lumino City trace Test: angle_perftests --gtest_filter="*lumino_city*" Bug: angleproject:7571 Change-Id: I206b965712b8f833874069bbcec0c93fc7ee5087 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3829135 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Peng Huang b9fd47b8 2022-08-12T10:55:49 Not use Android TLS slot for chromium In the profile, GetGlobalContext() & GetValidGlobalContext() have extra overhead for checking angle::gUseAndroidOpenGLTlsSlot. Since angle::gUseAndroidOpenGLTlsSlot is always false for now, so add a build flag to disable it for chromium build. In the profile, with angle_use_android_tls_slot = false, GetValidGlobalContext() is reduced from 0.153% to 0.044%. Bug: chromium:1336126 Change-Id: Id5e1752b0a03289fb299e8de2ed6e962e35291c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3827955 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Roman Lavrov 64c652d7 2022-08-12T18:14:39 Use stdout instead of (default) stderr in logging.StreamHandler Currently logging output appears before stdout on bots, makes logs so confusing as subprocess logs get out of order with logs from python. Using StreamHandler(stdout) seems to be the common practice in other python scripts in code search. Note: subprocess's stderr is redirected to stdout: https://crsrc.org/c/third_party/angle/src/tests/py_utils/angle_test_util.py;drc=2de8bb42a9ef93dfafe476e7dc81643285fa7ef1;l=92 Bug: angleproject:7299 Change-Id: I825f16d9c479f33a280d8fdbafb8297cda0c18b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3827957 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
angle-autoroll 72f03f79 2022-08-15T10:01:27 Roll SwiftShader from 2438c1b18a5e to a6c3e363b7a9 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/2438c1b18a5e..a6c3e363b7a9 2022-08-12 capn@google.com Regres: Roll dEQP to main revision eaf78cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I928855b305f0ad58652c4890aeac0cfb4db3f456 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3827679 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 042fda3c 2022-08-15T09:19:13 Roll Chromium from f904dc881cb8 to 16d8164e92a5 (630 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f904dc881cb8..16d8164e92a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/36b3854b7e..89cc6c63d9 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/47ec3a84c6..98014eb61a * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/9f503bebdb..6cc58d640c * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/a097a1ada6..030b4ebf32 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/4802c02064..95324abbb0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6dbdca4bea * third_party/fuchsia-sdk/sdk: version:9.20220811.2.1..version:9.20220812.1.1 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/37eadcf61d..cca1e66cd5 * third_party/r8: DZRgtLW0NflugdN9UMc7OsJqux69vI-6BxCNcTJaRTwC..lAcTGSK3VDSH4DI3H3q0XIg8y0wBVz7IS1Fk_Zbd3iYC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7fbcd9170e..d2890e490f No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I402f97b2e23a8ae6390358676cd7dcf3255dd5ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3831161 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Faye Zhang 4c941149 2022-08-12T11:42:07 External Texture Support In MEC Bug: angleproject:4964 Change-Id: I5cfbadf515a30fb20d75b2d745fdecdafa12268f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812378 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Faye Zhang <ffz@google.com> Commit-Queue: Faye Zhang <ffz@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi 02d79c32 2022-08-12T11:21:04 Skip kotor trace on Swiftshader due to flakiness After changing the driver uniforms to push constants, the kotor trace became flaky on Linux/Swiftshader. In this CL, the flaky test is skipped. Bug: angleproject:7565 Change-Id: Ia3deb1344ce2dfb8cec443d197b0f95788a12599 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3829907 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Peng Huang 44791792 2022-08-12T00:13:45 Use angle::FlatUnorderedSet for ImageSibling::mSourcesOf As my test with Chromium on Android, ImageSibling::mSourcesOf only contains one item, so change it to angle::FlatUnorderedSet with default size 2. Bug: chromium:1336126 Change-Id: Ie1ba3ebb195170ad5c9f4713b599a91de5052702 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3828444 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 4cdabfb1 2022-08-12T17:15:39 Roll VK-GL-CTS from eaf78cbfdaed to 5a93cd60f33b (4 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/eaf78cbfdaed..5a93cd60f33b 2022-08-12 ziga@lunarg.com Add tests making sure dynamic states are not overwritten 2022-08-12 rgarcia@igalia.com Test interaction of image_view_min_lod, robustness2 and gather 2022-08-12 piotr.byszewski@mobica.com Interaction between FDM and imageless framebuffer 2022-08-11 quic_mnetsch@quicinc.com Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/main If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,geofflang@google.com Change-Id: I58dcd6e603d2ea8cbd1e6fff9eb39f7d41fabba0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3829728 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Peng Huang a9fac249 2022-08-12T07:01:42 Use FixedVector for Framebuffer::mDirtyColorAttachmentBindings Bug: chromium:1336126 Change-Id: Ie997af106de09468c8520187190a857db099dff9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3829144 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org>
Shahbaz Youssefi 67e0c6fc 2022-08-11T22:10:36 PRESUBMIT: Remove unnecessary escape of forward slash Bug: angleproject:7279 Change-Id: Icf9482fb83c60640d5af6380674b9d857aa9ff0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3828443 Reviewed-by: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 1ca94448 2022-08-12T10:01:03 Roll SwiftShader from 708ca9579181 to 2438c1b18a5e (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/708ca9579181..2438c1b18a5e 2022-08-11 capn@google.com Ignore feature structs of partially promoted extensions 2022-08-11 capn@google.com Don't expose VK_EXT_external_memory_host on macOS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: angleproject:7538 Tbr: geofflang@google.com Change-Id: I0939eca4928df293c655a8e56808266f0d97312b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3827648 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 002b9544 2022-08-12T07:54:47 Roll Chromium from e4653aba963d to f904dc881cb8 (487 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e4653aba963d..f904dc881cb8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/9497cae3d0..36b3854b7e * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/11459ac227..47ec3a84c6 * buildtools/linux64: git_revision:c8c63300ac8ecb66d8126af5407257209ae59044..git_revision:0bcd37bd2b83f1a9ee17088037ebdfe6eab6d31a * buildtools/mac: git_revision:c8c63300ac8ecb66d8126af5407257209ae59044..git_revision:0bcd37bd2b83f1a9ee17088037ebdfe6eab6d31a * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/55e0c49d14..9f503bebdb * buildtools/win: git_revision:c8c63300ac8ecb66d8126af5407257209ae59044..git_revision:0bcd37bd2b83f1a9ee17088037ebdfe6eab6d31a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/6250261533..4802c02064 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b2cd6477b9 * third_party/fuchsia-sdk/sdk: version:9.20220810.1.1..version:9.20220811.2.1 * third_party/r8: YywdNQUrAK_HHH829t_MPLvTyjmQW-dWAsB7k-8gpNkC..DZRgtLW0NflugdN9UMc7OsJqux69vI-6BxCNcTJaRTwC * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/7d9556cfda..e5f1a8a766 * tools/skia_goldctl/linux: 9fyLI7UE2vwgyQweLyqyh193CzDMxbUr0xRuqtcCLAgC..ebDbf3X2jdAICDlXMXUr7yp4muhSvYoREDLdZZoJzuAC * tools/skia_goldctl/mac_amd64: Gd1BbosIHwOaX5zOlcEpL3_dE4fNnH3ZavJaYPSbIaEC..yE_XL6pbQ8M0WuI236ObRlkSxu0XMdWs_AnUeo21wa8C * tools/skia_goldctl/mac_arm64: xjfviFgm_MjrBG13x_JywIF9-wkn8wCyBm7yZVx-V10C..l46gUmkc-2-OsEMo-oEbpXiBAYg48KtXbtF1lyBh0u8C * tools/skia_goldctl/win: rV5hj2Xykfze-wY9ozIelEOoVLxjUV7rPUMxnRrlh80C..58nNno6pNLLSJaZknYmuijuo5gy2tfRBKNI1iCldDlcC No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ia3761305f18225d92685073e031fabf127a59829 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3828537 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Peng Huang afdd5106 2022-08-11T21:14:23 Use angle::FlatUnorderedMap in Display.cpp Bug: chromium:1336126 Change-Id: I57d97d37749de2abbba88b6558bde31fa8346764 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3828442 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Eddie Hatfield 2ebd5100 2022-08-11T10:43:32 Add gl::Context as a parameter to Shader::resolveCompile This prepares us to access the Context's shader cache in resolveCompile in the next commit. Bug: angleproject:7036 Change-Id: I7995c54b290a5a48f0c8985cb56ea0048598ab2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3827642 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Peng Huang 61a17ba9 2022-08-11T11:23:10 Use angle::FlatUnorderedSet for ImageState::targets In mose cases, chrome only needs 1 or 2 targets for an EGLImage, so using angle::FlatUnorderedSet with 2 default size instead of the std::set for targets. Bug: chromium:1336126 Change-Id: Ieff3cfbd5d020fda3aaecb162ddb354def14d962 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3827681 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Kyle Piddington 58392791 2022-04-07T16:14:12 Translator: Fix crashes with monomorphizing loops Monomorphize functions crashes when trying to deep-copy a while loop, and a continue statement. Null check these values before performing a copy, as this is still valid AST syntax. Bug: angleproject:7190 Change-Id: I822c0aa062ed844f86aa2b603899d73cbd48255e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3573079 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Charlie Lao 4c6f7d8e 2022-08-10T15:21:57 Vulkan: Never stage update for EGLImage EGLImage could be shared between contexts in different share groups. If we stage any update in the ImageHelper for such EGLImage, then you may run into threading bugs when two textures are trying to flush out the staged update at the same time. There is no evidence showing we are running into this issue, but this CL forces this requirement. Bug: b/169868803 Change-Id: Ie26542225705ee4638ca1b3cf3cc5af499685137 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3824159 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Rafael Cintron c9360ccb 2022-08-10T16:05:49 Reflect TextureD3D label updates with storage object When developers change a label with the KHR_debug extension, TextureD3D calls TextureStorage::onLabelUpdate. However, onLableUpdate was still using the out of date member variable (mTextureLabel) that was set in the constructor. This change adds a setLabel method to the TextureStorage class which properly updates the texture label member variable. Calls to onLabelUpdate now retrieve the most up-to-date label. This change also renames TextureStorage::mTextureLabel to mKHRDebugLabel to make it more clear which label was being stored. Bug: angleproject:7569 Change-Id: I6bc65c35dfb2237b5da88a6ed0e2d872a14857ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3825357 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Chris Dalton 4a636cdd 2022-07-20T22:44:30 Require all PLS formats to consume exactly 4 bytes of storage D3D 11.0 UAVs only support R32_FLOAT, R32_UINT, R32_SINT formats. EXT_shader_pixel_local_storage explicitly states that all PLS variables consume exactly 4 bytes. ESSL images can only have both read and write access if their format is r32f, r32i, r32ui. (We were able to circumvent this via aliasing, but it was a huge source of bugs.) There is a large precedent for only supporting 4 bytes of storage in the capabilities we use for PLS, so this CL removes support for all PLS storage formats that are not 4 bytes. It also implements an "R32" mode for PLS, that does manual packing and unpacking of r32* image formats. If the application wants larger formats, it can always define multiple PLS planes and piece them together. Next up we ought to be able to support rg16* types with more packing/unpacking. With aliasing gone, and with a bit of tweaking, the PLS tests now pass on the Pixel 4 GLES bot. Bug: angleproject:7279 Bug: angleproject:7388 Bug: angleproject:7524 Bug: angleproject:7527 Change-Id: I6b8f62c2428ade6cb5413e33360d734e55dda0eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3782579 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app>
Charlie Lao badfeecd 2022-08-10T14:38:43 Vulkan: Destroy fb1 should not affect fb2 with same attachments If two FBOs has the same attachments. they will share the same VkFramebuffers. Destroy one fbo should not cause trouble for the other fbo. Bug: chromium:1351170 Change-Id: I032da8cc12eb8556c3e325c8fd7a3de9974ae909 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3824302 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Chris Dalton fa3d7d5c 2022-08-05T00:57:40 Make PLS coherent on Vulkan Uses the VK_EXT_fragment_shader_interlock extension to make the shader image implementation of PLS coherent on Vulkan. This extension is supported on AMD, Apple, NVIDIA, and Intel. Bug: angleproject:7279 Change-Id: Ic0253eb20932eb6be0b1f433ba454e48b57be2f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3813816 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Kyle Piddington aef9603f 2022-08-02T18:30:08 Separate Struct declarations earlier Metal translator backend asserts with compound struct definitions. Move SeparateCompoundStructDeclarations before SeparateCompoundExpressions. This change does revert some changes for angleproject:6386, but the tests fixed there continue to pass. Bug: angleproject:6489 Change-Id: I6adc606ac0b14453eb5e3e90f6501bf02c2d2768 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3806616 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Gregg Tavares <gman@chromium.org> Commit-Queue: Kyle Piddington <kpiddington@apple.com>
Shahbaz Youssefi 47d2df0e 2022-08-10T15:15:18 Presubmit: Verify ANGLE_SH_VERSION update ... when ShaderLang.h or ShaderVars.h change. Bug: angleproject:7279 Change-Id: I01f6035ad41a4d92cc9e5d1e509731bb2ff29047 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3823619 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Peng Huang 4cab7f38 2022-08-10T20:33:07 Fix EGL_ANGLE_program_cache_control for eglCreateContext EGL_CONTEXT_PROGRAM_BINARY_CACHE_ENABLED_ANGLE is an attribute for creating EGL context, but ANGLE reads it from mAttributeMap which is not the attribs passed to eglCreateContext(). Bug: chromium:1336126 Change-Id: Id3ea1955f927a7e051285c79b590dcf1f11f22ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3823621 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 87ed2c9d 2022-08-11T11:19:17 TestSuiteTest: Generate more unique result file names. Speculative fix for flaky runs of TestSuiteTest. Flakes appear to read the results of other tests suggesting rand is not unique enough to protect against tests generating the same results file. Bug: chromium:1352134 Change-Id: Icadf64c557e23e6d87fd18aa60aa48373ecec9fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3827144 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll 26bb1d6e 2022-08-11T10:01:49 Roll vulkan-deps from c728ed48ce2f to d53c356ad7d9 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c728ed48ce2f..d53c356ad7d9 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0ebcdc4d19..0a43a84e02 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6ace8025bb..529a4320d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Id58daaaf51e79b6c3e43618ce4bd13961f56f19d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3824173 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 58b4dbd8 2022-08-11T10:01:45 Roll SwiftShader from aafa10869568 to 708ca9579181 (4 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/aafa10869568..708ca9579181 2022-08-11 capn@google.com Eliminate unscale constants 2022-08-11 nicolas.capens@gmail.com Make maskAny() SIMD width agnostic. 2022-08-11 capn@google.com Support constructing a SIMD constant from a lambda expression 2022-08-10 capn@google.com Fix printing SIMD::Pointer offsets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ia6527a5f182e3d46322bc7e6872d885bcebdb10e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3825163 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 6c953069 2022-08-11T08:49:49 Roll Chromium from d830698e47ae to e4653aba963d (476 revisions) https://chromium.googlesource.com/chromium/src.git/+log/d830698e47ae..e4653aba963d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/93068bfb00..9497cae3d0 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b11e87a879..11459ac227 * buildtools/linux64: git_revision:3d773bba0927e67eae8fdaee5e28b0f6203d3bee..git_revision:c8c63300ac8ecb66d8126af5407257209ae59044 * buildtools/mac: git_revision:3d773bba0927e67eae8fdaee5e28b0f6203d3bee..git_revision:c8c63300ac8ecb66d8126af5407257209ae59044 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/fe1bc75a46..55e0c49d14 * buildtools/win: git_revision:3d773bba0927e67eae8fdaee5e28b0f6203d3bee..git_revision:c8c63300ac8ecb66d8126af5407257209ae59044 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2988eb6ecf..6250261533 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/f35edd63ba..d22f28635a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..268569634e * third_party/fuchsia-sdk/sdk: version:9.20220809.1.1..version:9.20220810.1.1 * third_party/r8: ncOWcGcIDVi8ufTgdNYbCX5-V_uiCMJ1doSNFemyu1wC..YywdNQUrAK_HHH829t_MPLvTyjmQW-dWAsB7k-8gpNkC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d42a2d064a..7fbcd9170e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/0d9f47b867..ca2df581e4 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I15f973628babf7efc3fbc2aaec8b2db522ccde2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3824172 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Roman Lavrov 3d0faa02 2022-08-09T16:48:06 Remove workaround affecting --list-tests --gtest_filter=X. One of the multiple workarounds added in https://crrev.com/c/3062240. It makes `--list-tests --gtest_filter=X` behave as if it was just `--list-tests`. Not sure why this was necessary, bots appear to work without it?.. Could be something that changed since that CL? Bug: angleproject:7508 Change-Id: I9988add40ddf3168e00cea2739e5a9209f633161 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3821374 Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi 876da4ae 2022-08-09T22:30:24 Vulkan: Query support for VK_KHR_imageless_framebuffer In preparation for using it. Bug: angleproject:7553 Change-Id: I579af8ce2c0dd1d58bf750ee494e06a071b798fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3823620 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi f7d4c614 2022-03-30T23:33:27 Vulkan: Use VK_EXT_primitives_generated_query This Vulkan extension implements OpenGL's primitives generated query. The heavy lifting in ANGLE's implementation was done when this query was emulated with pipeline statistics query. This change simply switches pipeline statistics query usage to this dedicated query when available. Bug: angleproject:5430 Change-Id: I5d2c7d64e4627bcbd33d428d6a7c836b1129e5fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3813815 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Roman Lavrov 6d0452b7 2022-08-10T13:34:29 Fix ANGLE_HAS_HISTOGRAMS following crrev.com/c/3817602 Bug: angleproject:7299 Change-Id: I1d6f97e61dfdbea04009cc08a17344a59e438e51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3823618 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Chris Dalton 7c6a5459 2022-08-10T10:09:18 Rename ShFragmentSynchronizationType::None -> NoSynchronization Use a less generic name. X11.h contains: #define None 0L /* universal null resource or null atom */ Bug: angleproject:7279 Change-Id: I7d245b9f771211dea151bfc12363a03374264ac4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3824717 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 493b5aff 2022-08-09T14:57:24 Vulkan: Workaround ARM bug with stencil write mask Bug: angleproject:7556 Change-Id: I0aa17c178071cc15d8ee15f700b0c4932819c72a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3821367 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov dc82ff15 2022-08-08T16:06:13 Add config angle_maybe_has_histograms to angle_perftests_common. ANGLE_HAS_HISTOGRAMS wasn't consistently defined in compilation targets. I was working on a prototype and ran into crashes due to an inline function in TestSuite (where this class is used) getting invalid offsets in some cases due to this :-O Shabi: """ angle_source_set makes something the equivalent of a temporary .a, so objects are not recompiled for every target that links to it """ Also change ANGLE_HAS_HISTOGRAMS to =1 or =0 as Yuly suggested so that we can check if it's defined in the header to avoid inconsistency. Bug: angleproject:7299 Change-Id: I907184a6ca2bc673f5bffc473b584d78625a11c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3817602 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
angle-autoroll 17df2fd3 2022-08-10T10:01:49 Roll vulkan-deps from fe14e7954b25 to c728ed48ce2f (8 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/fe14e7954b25..c728ed48ce2f Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/a725d8fad1..61c603f3ba * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f20e8d05f5..0ebcdc4d19 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/becf07286e..6ace8025bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ia63b311a356cbfdebe330da7b7e6e69b55e889b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3821648 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Geoff Lang 408c5a56 2022-08-09T09:07:41 Mark FormatPrintTest as potentially uninstantiated. Vulkan is not an available backend on iOS. Bug: angleproject:5417 Change-Id: I92afff13bc10a1b6a3faa51a1620fd250972cab0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3819902 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Geoff Lang <geofflang@chromium.org>
angle-autoroll ee093838 2022-08-10T09:09:49 Roll Chromium from 6306836d087b to d830698e47ae (506 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6306836d087b..d830698e47ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/91cf468257..93068bfb00 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/c38cbd4028..a097a1ada6 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3da59a3d51..2988eb6ecf * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..743fa6c597 * third_party/fuchsia-sdk/sdk: version:9.20220808.3.1..version:9.20220809.1.1 * third_party/r8: zwDsb_S9yBEwDeg6obeP11vhi8U_Hg82v-Fsv-90ifMC..ncOWcGcIDVi8ufTgdNYbCX5-V_uiCMJ1doSNFemyu1wC * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7995d10b85..d42a2d064a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4819558a6e..0d9f47b867 No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: I331747dc891d29acdacbe0296c2f6173767b4ffd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3821647 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 2c351351 2022-08-07T22:31:40 Vulkan: Don't break render pass on read-only buffer updates When uploading to a buffer that is in use by the GPU, we either acquire a new buffer and copy the contents over, or stage the update and do a GPU copy. Ignoring all other conditions, this decision was made based on whether a small or large part of the buffer is being updated; small updates where staged. However, if the current render pass uses the buffer in read-only mode, the staged update would break it (to apply the update). In this change, this situation is detected and the acquire-and-update path is chosen even for small updates. Bug: angleproject:7534 Change-Id: Ie2c0989449dcc7d03695a003cf6f353920f8fb65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812566 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 1bb3685d 2022-08-10T00:35:43 Roll SwiftShader from 678ffefb1b3b to aafa10869568 (9 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/678ffefb1b3b..aafa10869568 2022-08-09 capn@google.com Disable AddressSanitizer JIT instrumentation support on Windows 2022-08-05 sugoi@google.com Temporarily allow unsupported structures in PhysicalDevice::getFeatures2() 2022-08-05 sugoi@google.com Workaround for dEQP-VK.info.device_mandatory_features failure 2022-08-05 sugoi@google.com Workaround vkGetPhysicalDeviceProperties2() issue 2022-08-04 sugoi@google.com Update Vulkan headers to version 1.3.224 2022-08-04 sugoi@google.com Fix VulkanWrapper compilation 2022-08-02 capn@google.com Support AddressSanitizer instrumentation of LLVM JIT routines 2022-08-02 capn@google.com Strip only the leading underscore from Mach-O symbols 2022-08-02 swiftshader.regress@gmail.com Regres: Update test lists @ 678ffefb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com,nicolascapens@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com,nicolascapens@google.com Change-Id: Ia6d4f981a19988bd9dbc390075ed673751013171 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3821356 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amirali Abdolrashidi 8050079c 2022-08-08T16:35:10 Vulkan: Remove basicGLLineRasterization * Removed basicGLLineRasterization from the ANGLE features. * Removed "viewport" from the extended driver uniform classes. Bug: angleproject:2830 Bug: angleproject:7558 Change-Id: I289b1e2b536a6bd0c1ab24844835221e617a296d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3818165 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Greg Thompson 52719c9f 2022-08-05T14:23:24 [fuchsia] Migrate angle_end2end_tests to component framework v2. Bug: chromium:1256503 Change-Id: I28d76dfa721fd6a65e029833050140c487e8006d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812043 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Juan Muraira <jpmuraira@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org>
angle-autoroll d8c6a235 2022-08-09T10:51:49 Roll vulkan-deps from 4b211a6a98e6 to fe14e7954b25 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4b211a6a98e6..fe14e7954b25 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/0cccd0a65a..a725d8fad1 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b362d2b7d4..f20e8d05f5 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/eb7156a963..becf07286e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I376fd01e4a96c7a97f061a71474744a5b369008c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3818496 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 97b16799 2022-08-09T07:44:49 Roll Chromium from 199441d23d93 to 6306836d087b (461 revisions) https://chromium.googlesource.com/chromium/src.git/+log/199441d23d93..6306836d087b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b1868b3db9..91cf468257 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/416d16f002..b11e87a879 * buildtools/linux64: git_revision:c8c63300ac8ecb66d8126af5407257209ae59044..git_revision:3d773bba0927e67eae8fdaee5e28b0f6203d3bee * buildtools/mac: git_revision:c8c63300ac8ecb66d8126af5407257209ae59044..git_revision:3d773bba0927e67eae8fdaee5e28b0f6203d3bee * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/75bbec9f6d..fe1bc75a46 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/47974e9376..c38cbd4028 * buildtools/win: git_revision:c8c63300ac8ecb66d8126af5407257209ae59044..git_revision:3d773bba0927e67eae8fdaee5e28b0f6203d3bee * testing: https://chromium.googlesource.com/chromium/src/testing/+log/9598217953..3da59a3d51 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4755386202 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2cd48234f1..647cfe6bf1 * third_party/fuchsia-sdk/sdk: version:9.20220806.1.1..version:9.20220808.3.1 * third_party/r8: IBW3UYermEa3GRA8TK8U8l7zQEPKBCQOt8d4K4QAHtsC..zwDsb_S9yBEwDeg6obeP11vhi8U_Hg82v-Fsv-90ifMC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/27842bf472..4819558a6e No update to Clang. Bug: None Tbr: geofflang@google.com Change-Id: Ia87f9cfcd941b0016c2299cc4a6681f64d3cd878 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3819073 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 6f80f0f0 2022-08-06T02:29:19 Translator: Clean up the compile flag passing interface Historically, compile flags were sent to the translator as a bitmask. Recently, we were getting close to running out of bits. Additionally, direct-to-metal work had started to introduce constants to be passed to the translator, which were misplaced in ShBuiltInResources and Caps. Recent work on Pixel Local Storage adds even more constants, aggravating the situation. In this change, the interface to passing compile flags is reworked. A struct is passed (instead of a bitmask) that has one bit for each flag. This can be indefinitely extended. Additionally, the constants needed by metal and PLS are also placed in this struct. In turn, the backends can set these options directly, and don't have to hack them into Caps to further get hacked into ShBuiltInResources. Bug: angleproject:7559 Change-Id: If93f1e1b8818ad3a0ac708ab04ab93b4b397d114 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812562 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 8474a95e 2022-08-05T22:15:04 Translator: Don't validate structs on non-root nodes Struct validation needs to know about structs that may have been defined outside the scope of the node, so this validation (similar to variable and function call validation) is disabled when validation a subtree of the AST. Bug: angleproject:7531 Bug: b/239207278 Change-Id: Id6dcee041a40f09f0c36a9ef3bfc238433b69c58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812047 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Amirali Abdolrashidi 7fe0694c 2022-07-14T16:42:30 Vulkan: Use push constants for driver uniforms * Updated the driver uniforms so they would be defined as push constants in SPIR-V. Their data would be updated via pushConstants() when handling the driver uniform dirty bits. * Updated TOutputVulkanGLSL to be able to generate the push constants as required. * When handling the driver uniform dirty bits, we no longer allocate a buffer. * Removed the driver uniform descriptor set from the pipeline layout. * Removed the binding-related functions and flags for the driver uniforms. * In invalidateGraphicsDescriptorSet(), DIRTY_BIT_DESCRIPTOR_SETS is used instead of DIRTY_BIT_DRIVER_UNIFORMS_BINDING. (Same for invalidateComputeDescriptorSet()) * DIRTY_BIT_DRIVER_UNIFORMS_BINDING is replaced with DIRTY_BIT_DRIVER_UNIFORMS in other places. * Removed mDriverUniform and DriverUniformsDescriptorSet from ContextVk. * Added mSupportedVulkanShaderStageMask to RendererVk, which is used in creating the pipeline layout and updating the push constants. * Added a TODO note for driverUniformsDescriptorSetIndex. Bug: angleproject:6858 Change-Id: I91037d378528962a816b12ff3f21249ee17b7652 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3782570 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Chris Dalton c554b92b 2022-08-08T10:08:33 Apply memory qualifier decorations in SPIR-V Bug: angleproject:7279 Change-Id: I9390261aa572fe4b39152a6f7bdd2b100b34f616 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3818162 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi 2cf9b1d6 2022-08-05T10:25:27 Encapsulate prevTexture pointer in a class * Encapsulated mPrevUploadedMutableTexture from ShareGroupVk into the new TextureUpload class. Bug: chromium:1346808 Change-Id: Ied52071d4e7f624fc2c497c4086b2589b840561d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3813032 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Peng Huang 52b18311 2022-08-08T07:51:21 Use angle::HashSet to replace std::set in Display.h The std::set uses heap allocation for each item, so change it to angle::HashSet for ContextSet, SurfaceSet, ThreadSet, ImageSet, StreamSet, SyncSet and EglDisplaySet. angle::HashSet is a flat set, all items are in one memory allocation. It should has better performance for small size set container. Ideally, it is better to use angle::FlatUnorderedSet which doesn't need heap allocation at all in most cases. However FlatUnorderedSet doesn't support common std container methods. So we can only use angle::HashSet for now. Maybe improve angle::FlatUnorderedSet in follow CLs. Bug: chromium:1336126 Change-Id: I18b3afd8722d222183c88f876b792c1af23bc195 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3816401 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Amirali Abdolrashidi f5de8e01 2022-08-05T10:23:37 Vulkan: Disable texture upload if texture sharing * Disabled mutable texture upload in cases of display-level texture sharing. Bug: chromium:1346808 Change-Id: Ia54496521d151ca7f273845fb40c56b5322470af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3812386 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Ian Elliott 5b7b7f9b 2022-08-04T12:18:12 Document how to roll VMA for ANGLE This CL contains learnings from a recent roll of which Chromium-local version of VMA is used for ANGLE, and how it rolls into Android. Bug: b/238213234 Change-Id: I50b98e984e68ee0f2ff06fc24847d4a4a2c8fb1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3811861 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
kmx.io     mail     discord kmxgit v0.4.0