infra/specs


Log

Author Commit Date CI Message
Yuly Novikov d7346867 2022-05-04T16:58:17 Decommission win7-x86-amd and win7-x64-nvidia Bug: chromium:1322538 Change-Id: I36a46eb8351a151b46e860c7c1c3311f0843e067 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3628110 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 064fc64a 2022-05-03T13:49:50 infra: Remove some slow *SAN tests. This removes GLES-CTS 3.1 tests from TSAN/ASAN/UBSAN, and also removes some of the rotation-specific tests. We're running out of capacity on these configs. We can always add them back to ASAN and UBSAN as we see fit. Bug: angleproject:7264 Change-Id: Ic60df1ba36811b69c20f23e180485d932ae93ea2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3623864 Auto-Submit: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Roman Lavrov c6e6e284 2022-05-02T11:16:19 Update Android deqp and end2end sharding end2end now the bottleneck, taking a tad too long so bump up Some of the deqp suites running way too fast so bump down end2end on trybot after this change (before: ~9m/shard): Max shard runtime (4m 38s) + overhead (10s): 4m 49s (shard #0) Min shard runtime (4m 18s) + overhead (10s): 4m 29s (shard #2) Bug: angleproject:7242 Change-Id: Ie75afba6c920da3602fb82c69ed90efef4197ead Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3621393 Auto-Submit: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov 237479a2 2022-05-02T14:22:11 Fix presubmit following https://crrev.com/c/3611486 Switch to python3 for to get expected dict.keys() ordering python behavior/spec changed around ~3.6-3.7 https://stackoverflow.com/a/40007169 Reorder mixins that got out of order. Bug: angleproject:7242 Change-Id: I5fbc973ccc52b11f7db55c50e2ae7af54361dd40 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3622053 Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Roman Lavrov c402f002 2022-04-26T12:31:06 Android perf tests shards 20->6 (only --smoke-test-mode) try 4470: Max shard runtime (5m 14s) + overhead (19s): 5m 34s (shard #2) Min shard runtime (4m 41s) + overhead (10s): 4m 51s (shard #1) Total shard runtime (29m 21s) + overhead(1m 37s): 30m 58s Bug: angleproject:6854 Change-Id: Ia1664bd56f502a81eaa4b2f0e35722b2ff5bea3b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3605765 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cody Northrop 242f0d81 2022-04-19T10:40:50 Revert "Infra: Enable Skia Gold tests on Pixel 6" This reverts commit 3636d129ee9c6c970e9b31883fcc88c539382434. Reason for revert: Causing test timeouts on Pixel 6: https://bugs.chromium.org/p/angleproject/issues/detail?id=7216 Original change's description: > Infra: Enable Skia Gold tests on Pixel 6 > > We have our first trace that can't run on any existing > bots, so we need to expand to Pixel 6. > > Test: TracePerfTest.Run/vulkan_car_chase > Bug: angleproject:7125 > Bug: chromium:1280418 > Change-Id: I7a81d42bc336c7df398b1d1712cf25c0eb9d72d3 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3561490 > Auto-Submit: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Cody Northrop <cnorthrop@google.com> Bug: angleproject:7216 Bug: angleproject:7125 Bug: chromium:1280418 Change-Id: Ieca910fa11f81a3f526e9ccff49fa636fd3b7d13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3594112 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
Cody Northrop 3636d129 2022-03-30T15:23:18 Infra: Enable Skia Gold tests on Pixel 6 We have our first trace that can't run on any existing bots, so we need to expand to Pixel 6. Test: TracePerfTest.Run/vulkan_car_chase Bug: angleproject:7125 Bug: chromium:1280418 Change-Id: I7a81d42bc336c7df398b1d1712cf25c0eb9d72d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3561490 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Yuly Novikov ea86cfd2 2022-04-12T09:06:17 Roll chromium_revision f89964bd5b..f961a0d473 (990903:991486) Switch Pixel 6 from Android 12 (S) to Android 13 (T). Change log: https://chromium.googlesource.com/chromium/src/+log/f89964bd5b..f961a0d473 Full diff: https://chromium.googlesource.com/chromium/src/+/f89964bd5b..f961a0d473 Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2c3758a417..8ad9c1c830 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/75cd8f7f15..936a348f0a * third_party/android_ndk: https://chromium.googlesource.com/android_ndk.git/+log/9644104c8c..8388a2be54 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0e3c38595b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e222245128..3b97fa826e * third_party/turbine: CJm6IViplElcjFYLJc0XtAjZ97BOVjQIwigcJN6C9gsC..y4x80kUnDOxC5QyG48MlVoiRIEn09eaHcIJQFavlqgMC * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c61f267866..a6d209ab93 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3eacd6cee1..b5e2f7c16b * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/6de0b20e70..78263e3102 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6abc0266d4..b92a448a92 DEPS diff: https://chromium.googlesource.com/chromium/src/+/f89964bd5b..f961a0d473/DEPS No update to Clang. Bug: angleproject:6819 Change-Id: I93514068385887ad2bfc63184474fa9bc7a0d060 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3583150 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 1cfbe863 2022-03-09T13:35:44 perf tests: Report multiple time metrics. We can now report cpu/wall/gpu time instead of just a single timing metric. This is in preparation for reporting other types of metric including counters. Also includes some other minor script improvements. Bug: angleproject:4918 Change-Id: I52a3241893c56a1bfe982990ebac0fa168dbac51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3516969 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0b5485c5 2022-03-04T08:26:06 Call generate_test_spec_json with vpython3. Bug: chromium:1302648 Change-Id: If071d8f98b28b0dc3d279d35abd2cecde0976a58 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3503688 Reviewed-by: Jamie Madill <jmadill@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Amirali Abdolrashidi 9050cd64 2022-03-01T10:36:19 Add angle_white_box_tests to SwANGLE tests * Added angle_white_box_tests to the following: * swangle_gtests * swangle_non_deqp_slow_gtests * swangle_slow_gtests Bug: angleproject:7074 Change-Id: I703655d1901a6dc660d5e6b5c4044baf0994205d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3499200 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 6cb08a22 2022-03-03T01:33:00 Revert "Increase end2end timeout and sharding on Pixel 6" This reverts commit 3154b00bab776e366538e712558a7f8c2967d4ca. Reason for revert: perf regression worked around Original change's description: > Increase end2end timeout and sharding on Pixel 6 > > Bug: angleproject:7050 > Change-Id: I3402a9f930f47a32537afd13674a3d6bc514f606 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3481302 > Auto-Submit: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bug: angleproject:7050 Change-Id: I74eafcdef4edd256145ff4938a58f9dfffbbe063 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3501203 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 3154b00b 2022-02-22T16:34:29 Increase end2end timeout and sharding on Pixel 6 Bug: angleproject:7050 Change-Id: I3402a9f930f47a32537afd13674a3d6bc514f606 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3481302 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Cody Northrop 00c4dc93 2022-02-18T09:10:34 Python3: Update generate_test_spec_json.py Bug: angleproject:5707 Change-Id: Ifa84ecfc4f718f2798b232da30613b8af4940a7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3475171 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 3b891062 2022-02-16T11:38:31 Roll Chromium DEPS manually. Includes a fix for the removed Gold service account mixin. Also upgrades roll_chromium_deps to Python 3. Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/021b19e04d..47f630a2c5 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/01efcb5d51..738dc100c6 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/b323ac8f4c..1e0047c09e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2062399745..e5e34cbf4b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/47dfacfcce..ad002f6051 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/86630a4fe3..00852ba1c5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6fbe58035d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f72361d313..d6a3040bfd * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/4e87a80d55..901a5d97c2 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ad74e59c0f..0a9dd7740c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/aa8103bd9b..25c9dfaa86 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/6d4e79909d..715f5e95c1 No update to Clang. Bug: angleproject:5707 Change-Id: I781dc018443fab6bbde1351c6c0ab426338be4d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3469215 Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov f63d5f1c 2022-02-09T21:32:18 Revert "Don't build dEQP tests on MSVC temporarily" This reverts commit d7b3c6d109f3b9cd6ba855343fc011c3e93c24f3. Reason for revert: VK-GL-CTS fix in https://github.com/KhronosGroup/VK-GL-CTS/commit/438d92079b85a9d2b32420f319e0ad1d7efacf17 Original change's description: > Don't build dEQP tests on MSVC temporarily > > dEQP fails compile on MSVC Due to build switching to C++17. > Temporarily stop building them while VK-GL-CTS is being fixed upstream. > > Bug: angleproject:6737 > Change-Id: I288aab95cb76104fde7635eafb37d56b4ed0a600 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308820 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: angleproject:6737 Change-Id: Ic690e7379674fc1c929eb0213d521845df5a6636 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3450863 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll b934fad9 2022-01-31T07:02:28 Roll Chromium from 4d71de73b37d to 97a33ab1a078 (625 revisions) https://chromium.googlesource.com/chromium/src.git/+log/4d71de73b37d..97a33ab1a078 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c033fc477f..251d3d7d45 * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/7246413309..d0ad43c5e1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/df87133fcb..91b483090a * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/09aa08e993..3d6486f686 * third_party/android_ndk: https://chromium.googlesource.com/android_ndk.git/+log/401019bf85..9644104c8c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6b30850934 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/289dedd36b..8dd74d4f85 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e9331be2f4..4ccc066727 * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/ff9c7dc63d..92807057e1 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I3620eb6bb4d8bbf2ead0dabd518cb03cea21b7ae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3426821 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 78d482e5 2022-01-13T14:49:26 Add standalone ANGLE Pixel 6 experimental bots The bot only runs dEQP tests with Vulkan backend, not GLES. Also skipping non-Vulkan tests in angle_end2end_tests. Also no perf/trace tests, as these time out uploading to device. Adding suppressions for the failing tests at the same time. Bug: chromium:1280418, angleproject:6819 Bug: angleproject:6898, angleproject:6899, angleproject:6900 Bug: angleproject:6905, angleproject:6907, angleproject:6908 Bug: angleproject:6909, angleproject:6910, angleproject:6916 Bug: angleproject:6917, angleproject:6918, angleproject:6919 Bug: angleproject:6931 Change-Id: I3598e6ff7f458ad7ab2defb86e02a17fbf2d20ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3387108 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 17f912bd 2022-01-19T07:01:37 Roll Chromium from 8cf5fa683fa3 to b24759852b71 (537 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8cf5fa683fa3..b24759852b71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4730425268..7fe67152ba * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/d78d7bf604..94855f7b7c * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/c27c97a625..57e4aff4a1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/469fa94ee5..476fe6fd8d * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/e3a86ade34..914c1d8c62 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..f92a0a2305 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fd7427ccf6..cb340f5b7b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3da260b0f2..df50898d39 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b96ec062b2..f500acb211 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e5b892c59d..160d34ae85 No update to Clang. Bug: None Tbr: syoussefi@google.com Change-Id: I6f1b45549c77ac8291adb05ba213c46eb066ecd6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3400817 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d4412d0a 2022-01-13T00:21:47 Roll Chromium from 3d4921afbcfd to 3668290e6162 (378 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3d4921afbcfd..3668290e6162 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e73fdb69e8..21d8bd5b30 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d97420b2b6..4547d2f4d5 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/9ef57f6031..096eb5b5c7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..17bc902374 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/efd9399ae0..fc5cfd78a3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ad0c23f6d2..00a18c9625 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/178ab2e018..981ff984d3 No update to Clang. Bug: angleproject:6430 Tbr: geofflang@google.com,ynovikov@google.com Change-Id: Ib78663bf66304617c0ce791aaf08cd6f0e46be7b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3385195 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 4111f9ef 2022-01-05T15:08:07 Add standalone ANGLE Mac AMD experimental bot For testing Mac OS 12. Bug: chromium:1265563 Change-Id: Iacf86a4cf170c59b2856b1f68e63d2eaa90059fa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3367702 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill d6b9a259 2021-12-14T16:32:14 end2end_tests: Add SwS + AsyncQueue testing. This covers a hole in sanitizer testing. Bug: angleproject:6746 Change-Id: I3c9569f94f0d51f771c57d1d72743849a1cbba33 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3337984 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov d7b3c6d1 2021-11-30T15:25:36 Don't build dEQP tests on MSVC temporarily dEQP fails compile on MSVC Due to build switching to C++17. Temporarily stop building them while VK-GL-CTS is being fixed upstream. Bug: angleproject:6737 Change-Id: I288aab95cb76104fde7635eafb37d56b4ed0a600 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308820 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 14f55a7f 2021-11-02T10:16:58 infra: Enable TSAN and UBSAN tests. These tests are not yet enabled on the CQ. Bug: angleproject:5795 Change-Id: I3fc58ab800ebbc0840da8221b03b4ab145d28028 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3258003 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill e0b4cf6c 2021-11-26T10:23:24 Fix Python3 usage with perf tests/gold tests. Bug: angleproject:6733 Change-Id: I9d1baf78ed182db77c6a6d8e896737413ca417f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304012 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 6eb3f661 2021-11-25T20:11:23 Roll Chromium from ad511b3c5051 to 1f986773b3b2 (589 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ad511b3c5051..1f986773b3b2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/493ce927d2..209a6891b4 * buildtools/linux64: git_revision:4aa9bdfa05b688c58d3d7d3e496f3f18cbb3d89e..git_revision:b79031308cc878488202beb99883ec1f2efd9a6d * buildtools/mac: git_revision:4aa9bdfa05b688c58d3d7d3e496f3f18cbb3d89e..git_revision:b79031308cc878488202beb99883ec1f2efd9a6d * buildtools/win: git_revision:4aa9bdfa05b688c58d3d7d3e496f3f18cbb3d89e..git_revision:b79031308cc878488202beb99883ec1f2efd9a6d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/16f9b84af1..af043a3d65 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/13257ba994..8b7dd344d7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..75423c310e * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/646c3cd4d6..2ffa1bde79 * third_party/r8: nqWomZTwNDoogX26WeCSoFGg6aQN1FrwzoU4hCS0duEC..CokGsfuGfcV-GjGwN98h28Phet4ai_xhPGZkGCqotWMC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/994ccaf614..ace657580d * tools/luci-go: git_revision:2dfe2f218f0395673f336d17b841edf629907ae3..git_revision:03f7c59feeac59c211e5b06fbbbc7405861b482e * tools/luci-go: git_revision:2dfe2f218f0395673f336d17b841edf629907ae3..git_revision:03f7c59feeac59c211e5b06fbbbc7405861b482e * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/25bed66ea8..5d2edce177 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b841fa72c2..d04fad9221 * tools/valgrind: https://chromium.googlesource.com/chromium/src/tools/valgrind/+log/daf835c78a..79ec84517e No update to Clang. Bug: chromium:1273901 Tbr: syoussefi@google.com,ynovikov@google.com Change-Id: Ie372f87f4e06e1f7425b9744137efc494b7605f0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3301911 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop 0d67a4fa 2021-11-18T20:12:34 infra: Increase gles1_conformance_tests timeout In anticipation of GLES1 ubershader updates that result in faster frame times, but more compiles. The GLES1 conformance tests iterate through every state and render one frame, which is slower when you link a new program for each. Bug: angleproject:6644 Change-Id: I70501ea38505428569ba518710ecb03ce198db18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292511 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Lingfeng Yang <lfy@google.com>
Jamie Madill 6168e303 2021-11-18T08:55:22 infra: Enable flaky retries on Mac end2end_tests. These tests are heavily flaking and causing CQ churn. Mark them as retriable until we can root cause the flakiness. Bug: angleproject:6570 Change-Id: I9886a655b88737acbe7ce728fa32573ac4d6145f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289104 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 9a36c3b6 2021-11-15T13:46:06 infra: Update NVIDIA to 1660 testing. Bug: angleproject:6694 Change-Id: I2580b53e45e633af98be757d9bb081461c06de95 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3283163 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill de5a290d 2021-11-16T15:29:31 infra: Increase sharding on SwANGLE trace tests. These tests were timing out in test infra. Bug: angleproject:6496 Change-Id: Idd9b36051e1d0327602fa148d7a8c7b44d918b30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3285807 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 316dcb56 2021-10-06T09:31:49 Add SwANGLE Skia Gold testing. Required updating our system info helper to be able to retrieve SwiftShader device information. Bug: angleproject:6496 Change-Id: Ib38ea4da65d199433e17b87df2630c3fd77cb619 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3208646 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill bb6732a3 2021-11-02T10:10:52 infra: Add Linux UBSAN/TSAN configs. These are compile-only with this CL, and will start running tests in later CLs. Bug: angleproject:5795 Change-Id: I37b04df2bb4a97aa46545f50bf978dfde65983c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3258002 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill 2a9e6e48 2021-11-01T15:56:54 infra: Add tests to ASAN configs. These add basic ANGLE tests with SwiftShader + ASAN. Bug: angleproject:5795 Change-Id: I92a51a44214ff0f442d4a1b2a0bc6ac2b8d3f4eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3254431 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill a9f24fa5 2021-11-08T12:21:25 infra: Switch ASAN to 64-bit on Windows. ASAN is not supported in 32-bits on Windows. Bug: angleproject:5795 Change-Id: Icabf31b8c9ad4d371217c9f4a288f909888eae61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3265532 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Jamie Madill 616dc268 2021-10-12T13:15:40 infra: Add ANGLE-side configuration for ASAN tests. The ASAN builders will start by running compile-only and only in CI. A follow-up change will enable sharded tests and CQ jobs. Bug: angleproject:5795 Change-Id: I2e761b7bdd2d7215db2210c4538b6cafc4d9069a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3254430 Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 6e832bfe 2021-10-27T07:01:21 Roll Chromium from b7a27dd8face to 6e4379b531a3 (441 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b7a27dd8face..6e4379b531a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/0afcdef8ce..4703a8520d * buildtools/linux64: git_revision:693f9fb87e4febdd4299db9f73d8d2c958e63148..git_revision:79c6c1b1a24c46df5a773cc61604bb5051ca6cf4 * buildtools/mac: git_revision:693f9fb87e4febdd4299db9f73d8d2c958e63148..git_revision:79c6c1b1a24c46df5a773cc61604bb5051ca6cf4 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/9b8228b4a9..26b101897f * buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/21acd3f622..bbd954d05f * buildtools/win: git_revision:693f9fb87e4febdd4299db9f73d8d2c958e63148..git_revision:79c6c1b1a24c46df5a773cc61604bb5051ca6cf4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cf2207e083..847533d764 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/3b235c7e7c..f59fdc4257 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b10243766b * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/378395bfb5..480c91d40b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e193c0af0a..819fa9604c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3b242d6f87..b3ad7f71e0 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3ac732d74b..2ff429a7b7 No update to Clang. Bug: angleproject:2551 Tbr: timvp@google.com Change-Id: I4a8cd6a0f37374313ef2fe559f8e1fb8f23a9673 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3246537 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 0fb59c09 2021-10-18T08:25:26 infra: Remove old bot configs. This can be landed after the change to switch the CQ to the new configs. Bug: angleproject:6496 Change-Id: I3b6ec4697a2fa7a279e5a761ea1717f652af84a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3231835 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0c7018a5 2021-10-12T13:43:20 infra: Update bot naming scheme. Old names: use config pairs when they can vary, e.g. android-arm-dbg android-arm64-rel linux-clang-dbg win-clang-x64-rel win-msvc-x86-dbg win-trace-rel New names: use config names when they differ from the the default test config for a system, and suffix with -compile and -test for compile-only and compile-and-test bots. For Android configs, we keep the full target arch. e.g. android-arm-dbg-compile android-arm64-test linux-dbg-compile win-test win-msvc-x86-dbg-compile win-trace The new naming scheme prioritizes having short names to avoid redundant or implicitly understood information. This should reduce the mental load when looking at a set of test results. This also adds SwiftShader win10-x64 configs so we can add these to the CI easily. Also the plan is to turn off the GCC configs for now. If we ever support GCC properly we can re- enable them. This CL adds the new configs to CI, then a following CL will add them to CQ and remove the old configs at the same time. Bug: angleproject:6496 Change-Id: I0ecdcd392c4d7067d6b180664f160ba7c048d16d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3219590 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi f3d5dac3 2021-08-23T17:25:15 Vulkan: SPIR-V Gen: Drop dependency to glslang The SPIR-V gen path is now made default. Compilation through glslang is still supported for debugging, and is enabled on the GLSL* end2end tests for smoke testing. On release builds, glslang is not supported. To test with glslang, add the following gn arg (only necessary if dcheck is disabled): angle_enable_spirv_gen_through_glslang = true Then enable the generateSPIRVThroughGlslang feature. This can be done by setting an environment variable: ANGLE_FEATURE_OVERRIDES_ENABLED=generateSPIRVThroughGlslang ./angle_deqp_gles2_tests Binary size saving: - 1.3MB on Linux (SPIR-V gen itself: 240KB) - 730KB on Android (SPIR-V gen itself: 140KB) Perf tests: - LinkProgramBenchmark.Run/vulkan_compile_single_thread * Through glslang: truncated mean: 1287033.36 * Direct SPIR-V Gen: truncated mean: 244495.91 (~80% reduction) - LinkProgramBenchmark.Run/vulkan_compile_multi_thread * Through glslang: truncated mean: 4565894.83 * Direct SPIR-V Gen: truncated mean: 1158164.10 (~75% reduction) Bug: angleproject:4889 Bug: angleproject:6210 Change-Id: I486342702977c8114e90073b97183aba115a8b2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3115140 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill f13731ae 2021-10-06T10:04:24 Enable dEQP EGL + GLES 2/3 tests on Pixel 4. This is in preparation for removing these tests from the N5X. Bug: angleproject:6527 Change-Id: Ib44f876db47845935efd68a1727964834a675cbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3208746 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 69a91b3d 2021-10-04T08:59:55 Add SwANGLE test configs to Linux and Win. These will be used to replace SwANGLE tests on the CQ. Bug: angleproject:6496 Change-Id: Id8d021067ec05e226daac5c1d5992977ef295efb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3199993 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0004ecc2 2021-09-22T13:39:55 Write GL info to test artifact in end2end_tests. These will show up as glinfo.json in the "cas outputs" of the shard that runs these tests. We currently have information for Pixel 4, NVIDIA and Intel Win/Linux, and SwiftShader Windows. GLES 1.x extensions are treated separately. Some WebGL/Mac-only/D3D-only extensions show as unsupported anywhere. In order to capture artifacts on Android, we use a render test output parameter. Bug: angleproject:6379 Change-Id: I560b219b5a586cdbb68d272090f38eedc76aba20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3176780 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
angle-autoroll 17b50dbc 2021-09-22T23:35:45 Roll Chromium from f50ae42daa8b to 0ca662a00a61 (158 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f50ae42daa8b..0ca662a00a61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f34057a8e4..d4c1fd4eeb * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/48418f3dd7..ba539c18fc * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..25814bb53d * third_party/turbine: n2quuVAecebwosy5EPRjDGSO5EQU94aFRBg_EdrYtpsC..EIJ2nS3aoQlV-cKpmxr4hNR4E1Qs82brcidjG4A1I5QC * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/126012e8f7..2a0d7f0fb7 No update to Clang. Bug: None Tbr: geofflang@google.com,ynovikov@google.com Change-Id: Iadccb0fdf49e99b68e18977a3b3c6ae39ffe1424 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3177641 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov a58749ed 2021-09-22T22:50:10 Revert "Add standalone experimental Mac Intel and AMD bots" This reverts commit a5bbfe2afe29ec53eccf22d33cee200be25de673. Reason for revert: qualification complete Original change's description: > Add standalone experimental Mac Intel and AMD bots > > For qualifying Mac OS 11 on Mac Retina AMD and Mac Mini 8,1 > > Bug: chromium:1241597, chromium:1128540 > Change-Id: I753b504f5910541f5d3f244d117d369937a06d38 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3150752 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: chromium:1241597, chromium:1128540 Change-Id: I4eb71219783651c0e63188e2c94c6ee286625430 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3177332 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill c3e0eafa 2021-09-22T13:35:04 Revert "Perf Tests: Split samples into sub-tests on desktop." This reverts commit 90c981dafc06d6bc0696749dface1337e37784d2. Reason for revert: Causing timeouts on perf bots. Original change's description: > Perf Tests: Split samples into sub-tests on desktop. > > This adds an option to the perf test runner to split each sample of > each test into a sub-test. The sub-tests then are split among the > shards like ordinary tests, and distributed across machines. The > intent is that running on different machines will reduce inter-build > variance because of differences between test machines. > > This sampling change is only added to desktop (Linux/Win) because > Android device variance seems to be lower. > > Bug: angleproject:6090 > Change-Id: I4046a012727baa8a0f2595de2349cc34257691f9 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3152752 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Bug: angleproject:6090 Change-Id: I92bffb98999f35274ec31a3b7567d87453feff94 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3174274 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 90c981da 2021-09-10T11:04:19 Perf Tests: Split samples into sub-tests on desktop. This adds an option to the perf test runner to split each sample of each test into a sub-test. The sub-tests then are split among the shards like ordinary tests, and distributed across machines. The intent is that running on different machines will reduce inter-build variance because of differences between test machines. This sampling change is only added to desktop (Linux/Win) because Android device variance seems to be lower. Bug: angleproject:6090 Change-Id: I4046a012727baa8a0f2595de2349cc34257691f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3152752 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov a5bbfe2a 2021-09-03T19:24:29 Add standalone experimental Mac Intel and AMD bots For qualifying Mac OS 11 on Mac Retina AMD and Mac Mini 8,1 Bug: chromium:1241597, chromium:1128540 Change-Id: I753b504f5910541f5d3f244d117d369937a06d38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3150752 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill e1bc8de3 2021-09-08T07:59:37 Change links from 'master' to 'main' branch. Bug: chromium:1226949 Change-Id: Ie7b28b2fa094cf0c0a407968d681e580519cbb88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3148210 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill caef7c53 2021-08-26T18:24:18 infra: Disable perf tests on Win/Intel. These were killing the bots for some reason. Disable them until we can find the root cause. Bug: angleproject:6090 Bug: angleproject:6332 Change-Id: I48b633118f098570e371ea81d9e512e35ab04cd6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3123169 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 6a956ef9 2021-08-20T17:04:01 infra: Update angle_mb_config.pyl with new perf names. Was missing from the prior CL. Bug: angleproject:6090 Change-Id: I454605fad48690a2d84a2fe3a436140931e2cb9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3111027 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 162847ca 2021-08-17T13:26:06 infra: Increase sharding in CI angle_perftests. The test shards right now are taking 20-30+ minutes. Sometimes they time out on the test infra. Increase sharding because the overhead from sharding is very small relative to the test time used by shards. Bug: angleproject:6090 Change-Id: I45c7bf077da7242743559d68b45d45dbea18355e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3100586 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov e6d9ef98 2021-08-12T14:53:07 Enable ResultDB adapter for standalone bots In crrev.com/c/3087640 'has_native_resultdb_integration' was erroneosly enabled on ANGLE standalone bots. Disable it, so that the Chromium recipe would enable result adapter from JSON to ResultDB format. Bug: angleproject:6275 Change-Id: I1f94a8f2cbd1159be89bc1413669ed90e249c5b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3092045 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov ac2d1434 2021-08-11T15:48:57 Enable resultdb for ANGLE standalone builders Otherwise, they fail with https://crrev.com/c/3088213, e.g. https://ci.chromium.org/ui/p/angle/builders/try/linux-clang-rel/23678/overview Doesn't actually upload to BigQuery yet, pending declaring the tables. Bug: chromium:1135718 Change-Id: Ia429260e2f53f836279383aa84ca3e8e58c3392b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3087640 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill d25c9d7f 2021-07-07T12:15:12 Add perf tests runner script. This script will be responsible for running the perf tests multiple times to try and stabilize measurements. We'll use it on the bots instead of just running the perf tests directly. Because the script invokes the binary multiple times, this slows down execution. Most significantly on Android, where we now need to use 20 shards, up from 6. Also marks one test as flaky on OpenGL. Bug: angleproject:6090 Change-Id: I5280035cb0bdb290a68dc6961a384eaf4b40dd4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3011422 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
angle-autoroll 85e49053 2021-08-02T07:50:32 Roll Chromium from 7ad7eb435b84 to c96bed01e3be (1394 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7ad7eb435b84..c96bed01e3be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/96a4da9412..9ee6ac6515 * buildtools/linux64: git_revision:c0a2d23c21e87f27f5af3e5dc2a99f2ef3480b9e..git_revision:eea3906f0e2a8d3622080127d2005ff214d51383 * buildtools/mac: git_revision:c0a2d23c21e87f27f5af3e5dc2a99f2ef3480b9e..git_revision:eea3906f0e2a8d3622080127d2005ff214d51383 * buildtools/win: git_revision:c0a2d23c21e87f27f5af3e5dc2a99f2ef3480b9e..git_revision:eea3906f0e2a8d3622080127d2005ff214d51383 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/88e2d8b080..8872b6cf61 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/368be24f93..ae11d2854e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4505381167 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/2229323ff7..9ce4c7a678 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/dfbc590f58..6075f1fabd * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2a8bb1ca80..d0097bccba * tools/luci-go: git_revision:75ff299b9adf969190cafebe902255856a346f0b..git_revision:db421da12bad8e57f97ee45b24147e34ec882007 * tools/luci-go: git_revision:75ff299b9adf969190cafebe902255856a346f0b..git_revision:db421da12bad8e57f97ee45b24147e34ec882007 * tools/luci-go: git_revision:75ff299b9adf969190cafebe902255856a346f0b..git_revision:db421da12bad8e57f97ee45b24147e34ec882007 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ef691997d9..56a35530fc * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b210baf513..9c1129d333 Clang version changed llvmorg-13-init-16514-gb1777b04:llvmorg-13-init-15561-gf98ed74f Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/2a8bb1ca80b166cb11a81ffc35e8f374af240e04..d0097bccbaab2f439b83ba93c6634ba91ca882fb/scripts/update.py Bug: None Tbr: geofflang@google.com Change-Id: I2dd100192c502e329200d8c94bd013fecbbece05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3067054 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi b751b185 2021-07-22T22:10:22 infra: Enable gles3.2 deqp tests with direct SPIR-V generation Enabled on Linux/Nvidia, Windows/Nvidia and Pixel4. Bug: angleproject:4889 Change-Id: I3050ed53b48cc114c940486871910a3b9c5adea5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3047383 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 630077c5 2021-07-22T22:08:21 infra: Enable gles3.1 deqp tests with direct SPIR-V generation Enabled on Linux/Nvidia, Windows/Nvidia and Pixel4. Bug: angleproject:4889 Change-Id: Id82c909e368cdc189aea2e44f6371a27d8232e37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3047382 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 4ff80bb5 2021-07-22T21:52:35 infra: Enable gles3 deqp tests with direct SPIR-V generation Enabled on Linux/Nvidia, Windows/Nvidia and Pixel4. Bug: angleproject:4889 Change-Id: I2462b7fa7801b766f4359103a5253209b7fded28 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3047381 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 02c5cdbd 2021-07-21T23:08:17 infra: Enable gles2 deqp tests with direct SPIR-V generation Enabled on Linux/Nvidia, Windows/Nvidia and Pixel4. Bug: angleproject:4889 Change-Id: I50c5e31097bd7e1539caf7b229a249cbfa62b93d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3042557 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 91b35c90 2021-06-30T09:28:17 infra: Add perf results processing script. This script is a modified version of the Chromium script: https://chromium.googlesource.com/chromium/src/+/main/tools/perf/process_perf_results.py The primary change is to add additional build info to the histogram set before upload. This additional info isn't available to the test harness and is required for the perf dashboard upload. We can also use this as a basis for uploading to the Skia perf dashboard. Test: led launch Bug: angleproject:6090 Change-Id: Ie439ed34a24ce66f4b60b947f221e4cb96cf7d25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2997002 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 2c60b88a 2021-07-23T09:46:37 Make the trybot exclusion filter a proper regex. Bug: angleproject:6212 Change-Id: I20ca648675a5dd4773d1c3e44b251388318197f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3048854 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill aed52e67 2021-07-23T08:43:17 Set dcheck_always_on on every ANGLE builder. This GN argument is necessary because some build components reference it directly. Letting it be specified implicitly will caused undesired side-effects. Bug: chromium:1227171 Change-Id: Ib12cc3add58ecc8ae0360f816d30587158d756c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3048850 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 2b86e2d6 2021-07-19T10:30:57 GN: Update dcheck/assert conditions. In preparation for a Chromium change that makes dchecks enabled by default in Release builds, we'll keep ASSERT disabled in Release by default. We add a new flag 'angle_assert_always_on' for controlling ANGLE ASSERT behaviour. Also slightly refactors the direct SPIR-V generation GN. Chromium CL: https://crrev.com/c/2893204 Bug: chromium:1225701 Change-Id: I01a6def28d7c21e771e9800889a6b9c274972de2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035447 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll 783c2f93 2021-07-13T08:27:44 Roll Chromium from 7d1a6713a379 to 624f8c7a15ff (526 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7d1a6713a379..624f8c7a15ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/70f58488ed..9c63d2e3b0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e065358b5a..d749d1b98b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3345f09ed6 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/199485df6c..f376b41126 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3fa819890a..aca9f71bde * tools/luci-go: git_revision:2f836b4882d2fa8c7a44c8ac8881c3a17fad6a86..git_revision:2ac8bd9cbc20824bb04a39b0f1b77178ace930b3 * tools/luci-go: git_revision:2f836b4882d2fa8c7a44c8ac8881c3a17fad6a86..git_revision:2ac8bd9cbc20824bb04a39b0f1b77178ace930b3 * tools/luci-go: git_revision:2f836b4882d2fa8c7a44c8ac8881c3a17fad6a86..git_revision:2ac8bd9cbc20824bb04a39b0f1b77178ace930b3 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/783612b47d..1820a3adb0 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/511dbaffd9..6dad62e2eb * tools/skia_goldctl/linux: tu1vY2W9BQ6Wx0o3zk5oqBwnr5rfFQGiaztbTpGiRNgC..R0Jd4IlcndZlI5C9Pejy7DqtmVEQT8Sc6Ye09MGyFxYC * tools/skia_goldctl/mac: DPVSayDIq4ga78XaXXcfTzeTE2v33yM8z1w-eaD-ZuQC..5NoUEq08DuYUlQWnf2yj6rQvBtlMvWiDqfuUuE5nJFIC * tools/skia_goldctl/win: HMJwTrgrkRmSqDuyQtWly6YxYSHJXsM6zQJFLkojAVwC..M2_R9AXWaN0xmm6nz_nRzKlhpzzOp3P9EUxNaLZ5owMC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ie14d842df225cfc1f60d087386147904a8120ae4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3023670 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill ec8cdd5d 2021-06-28T15:59:38 infra: Add perf tests to Android/Linux/Mac. These use the same config as the previous perf bots. Bug: angleproject:6090 Change-Id: I0ed4bc32cdc5b27f1fbd00fded1fa8d2ccbe45d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993458 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 72c8d46d 2021-06-29T08:05:11 infra: Build traces on perf bots. This is necessary to ensure they run the trace tests in perf. Bug: angleproject:6090 Change-Id: Ib96418c4371f700dbbd54933241b1b88912f9938 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2991903 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 8b24e2a4 2021-06-25T13:51:19 infra: Add perf mb configs. This will set up the GN args for the perf builders. Bug: angleproject:6090 Change-Id: I3c00a5b78932ae41199953a46c525b435b566d12 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2989669 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill ce22ad10 2021-06-18T15:23:11 infra: Add symbol_level=1 in Release. This should enable better crash file/line information. Bug: angleproject:6070 Change-Id: I54280461160f2ac6404dbd4b88abdcfd31f3814e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2971956 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 166dd0c7 2021-06-10T16:09:01 Roll chromium_revision 6c5859c895..399855f4bb (890175:891326) Manual changes: 1. Fix generate_test_spec_json.py to correctly handle ADDITIONAL_MIXINS Needed after angle_skia_gold_test mixin removed from Chromium in crrev.com/890333 2. Copy third_party/logdog from Chromium Needed after crrev.com/890539 in order to create isolates on Android and for tools/perf/process_perf_results.py Change log: https://chromium.googlesource.com/chromium/src/+log/6c5859c895..399855f4bb Full diff: https://chromium.googlesource.com/chromium/src/+/6c5859c895..399855f4bb Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8870cb4120..2192a63c23 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c793cca886..9d8449e380 * buildtools/linux64: git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810..git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa * buildtools/mac: git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810..git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/7e3b76855b..2c53623d59 * buildtools/win: git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810..git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a62f8260df..ab567bcc84 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/7949d87093..bd17c406ba * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/887e8d9009..fa47598982 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/1cfc90728e..816daa2545 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..17cf72ca75 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b508ecd932..6d099d543d * third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/19f3fad68d..e9be5fd6d7 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/82f8803671..f4241bd0f2 * third_party/turbine: _iPtB_ThhxlMOt2TsYqVppwriEEn0mp-NUNRwDwYLUAC..Om6yIEXgJxuqghErK29h9RcMH6VaymMbxwScwXmcN6EC * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/09481f56be..fd14318cc9 * tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:725192cc79f07ea946e10a64baac06625c206968 * tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:725192cc79f07ea946e10a64baac06625c206968 * tools/luci-go: git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418..git_revision:725192cc79f07ea946e10a64baac06625c206968 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/94630dfc19..12c8fa872b * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/5c84710692..2e6477d751 DEPS diff: https://chromium.googlesource.com/chromium/src/+/6c5859c895..399855f4bb/DEPS Clang version changed llvmorg-13-init-11999-g50c0aaed:llvmorg-13-init-12491-g055770d5 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/09481f56be7b1bbaf5a466be5d81691902825fcf..fd14318cc948b67e5ec8a0f2f7563142ccd6dac2/scripts/update.py Bug: angleproject:4483, angleproject:6037 Change-Id: I9035126bce55642d4dfce54eeace85093bdd1782 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2954241 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill c778f93f 2021-06-07T13:10:15 infra: Reduce sharding on GLES3 GL/Metal tests. Bug: None Change-Id: I56593374d027db20a5ed0ebf09ca2210e219f244 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2945431 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 3bc28a27 2021-06-07T13:03:39 infra: Add flaky retries to Metal GLES 3 tests. These have been somewhat flaky on the waterfall. Bug: angleproject:6019 Change-Id: I4d76411ab54ad5fbfb9c49775c44a12b99def846 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2945430 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill d99864c0 2021-06-07T12:48:01 Gold Tests: Fix flaky test handling. Indead of just retrying the batch, retry individual tests. This should correctly handle the Intel flake pattern. Bug: angleproject:5415 Change-Id: I029c2514ff8e7a45184c5c105bf2d0350171da29 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2940049 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill f03f7bdb 2021-06-07T12:30:29 infra: Don't run trace tests in perf smoke tests. These test were already being run more safely in the gold tests step. Bug: angleproject:5977 Change-Id: I4fb1062926fcda19384835723555d0fab0b42aae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939469 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 2917ab34 2021-06-07T11:41:54 infra: Override Gold mixin. This mixin is being removed from the Chromium version of the mixins. Therefore we have to move it into the additional mixins option of the generator. Bug: angleproject:6037 Change-Id: I605b7cbf35d6282754bf5fb26246e32b2edcea10 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939466 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll a14a806c 2021-06-04T07:00:43 Roll Chromium from b078d3ef5de8 to 5ffd2ab3bece (403 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b078d3ef5de8..5ffd2ab3bece If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/20ee3d5c60..bf4ecd926c * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/cd7b8c0c22..eb65cc3594 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b97a23bcf3..f39abc2692 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/bb99706b87..baaf1482ba * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..712eb08096 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c8f63d390c..9705687c25 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/19eadef5e7..af7a363dfe * tools/luci-go: git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e..git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0 * tools/luci-go: git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e..git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0 * tools/luci-go: git_revision:3e796d36914b6ddf5311374284e3ffa06c24fc7e..git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0 * tools/skia_goldctl/linux: SIbSqtgKfmhBASeojfVyHGkIx2ZItagJYLeJt9yef1oC..fVbmAq5SyEKlNV_cPvOrlJbBRmDAWApv309sIMdbgq8C * tools/skia_goldctl/mac: WB42GE3e_7-dR5RnBBCICQtMkfpOoJvlT9tMG_6Fj1UC..SGAjTHEDDOpAgPQYJcSEmMh4E6afvlKQKzBjwSTf5dwC * tools/skia_goldctl/win: BL1QYX6LBgah6_XEB3KHs9jZiFQtq2z8PUZRswCFvN8C..hySBvc3hf9NRFmfS2oG52F9ZzLpvX9bFuyybtZ92CNAC Clang version changed llvmorg-13-init-10392-gd3676d4b:llvmorg-13-init-11649-g4d788fb8 Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/19eadef5e7825c6a90cb19c601ca26f889502856..af7a363dfec994581ed076c5023f110e079459f9/scripts/update.py Bug: None Tbr: ynovikov@google.com Change-Id: I21b2bbea54c6f43c1c7c7ab540af8eee345d7c41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939486 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 71584e36 2021-05-27T11:50:47 Tests: Disable trace compilation for MSVC and GCC New traces are hitting string literal limits with MSVC. Since we don't use MSVC or GCC for trace development or testing, this CL disables trace compilation for non-clang setups. Bug: b/181794064 Bug: angleproject:6009 Change-Id: I0377792a049153a5505ecda4346a3cec57c12e9e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2922682 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill 163f6ac0 2021-05-26T10:57:18 Gold Tests: Add batching. This should speed up test runs on Android, which are currently much slower than the other platforms. Bug: angleproject:5966 Change-Id: I57890522b64d1d195ea0be56b4f68b6d54192d64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2919888 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 17c45b65 2021-05-25T10:06:47 infra: Shard restricted_trace_gold_tests. Reduces shard time from 50+ min to <10 min per shard. Bug: angleproject:5966 Change-Id: Ia230d71a66ac9a273a10e0389cc04d8c5737bc4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2915566 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill fad9053f 2021-05-20T15:52:38 infra: Add isolated script tests to Pixel 4. This includes angle_perftests and angle_restricted_trace_gold_tests. Bug: angleproject:5941 Change-Id: I6f24d2c2752086ae6f7abba26880070c4a4f0472 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2911034 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Jamie Madill c71fbc16 2021-05-19T12:47:30 infra: Add dEQP tests to the Pixel 4. Also updates expectations. For simplicity we use SKIP everywhere and specify each skipped test individually instead of using wildcards. Bug: angleproject:5941 Change-Id: If2cb85b06ecd250222dbf1376d99392ad10b71aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2896172 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 328a5c89 2021-05-18T12:13:23 infra: Add tests to Android Pixel 4 bot. Only angle_end2end_tests and angle_unittests to start. Also adds test expectations for the Pixel 4 end2end_tests. Patch Series: 1. http://crrev.com/c/2885381 2. http://crrev.com/c/2885346 3. http://crrev.com/c/2885383 4. This CL Bug: angleproject:5941 Bug: angleproject:5946 Bug: angleproject:5947 Bug: angleproject:5981 Change-Id: Iaaea0b427513804575d0ad7773a81379ea932eb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885384 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll cf1064e6 2021-05-12T07:01:02 Roll Chromium from fff9d6fb8ddf to 3fb708290557 (495 revisions) https://chromium.googlesource.com/chromium/src.git/+log/fff9d6fb8ddf..3fb708290557 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/4ff4105cd8..129bd6c0c0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/504fae9f10..43828a290e * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/93eae7d9dc..371f2bea4f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..302ca09b2d * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cb17bc6028..6e5b0a5c45 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/5243354177..66e0a5d62b * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/618ddecd59..c3edbeed8a * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e76c8f17cf..53a9334ffe * tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1 * tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1 * tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/df10bb0bf8..ac77520e0e * tools/skia_goldctl/mac: 5o7ziB6qRrSdtYJwKop8-5OFmvVQcxuNkGY1DRYggMsC..qwctaMZfXlU0u7OsbxWgOY_sBjsUYhlqwjJRbAXX3oYC Clang version changed llvmorg-13-init-7296-ga749bd76:llvmorg-13-init-9302-g897d7bce Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/e76c8f17cf2833813d671674cd89f01f3a21e851..53a9334ffea6aa748ff6c1ce8a46e71a90e7bc9f/scripts/update.py Bug: None Tbr: timvp@google.com Change-Id: Iff9b5446b67a948eeb60e1aa7aaacf0725714c05 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2891629 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 6e3c5321 2021-05-11T12:17:17 infra: Remove old TODO. Bug: angleproject:5114 Change-Id: I3b7255cc06bffd177f0b5ee8cad12bf2aad3089e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885382 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 930db294 2021-05-10T19:19:31 infra: Add Android swarming spec placeholder. These will trigger tests on the Pixel 4 in standalone. For now we do not specify any tests. Patch Series: 1. This CL 2. http://crrev.com/c/2885346 3. http://crrev.com/c/2885383 4. http://crrev.com/c/2885384 Bug: angleproject:5941 Change-Id: Iad1bc27c316724b244fbfbf694f6e83fdf5c0507 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885381 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill e61909f6 2021-05-06T15:12:08 infra: Re-enable swarming tests. Changes since the revert: - Include runtime_deps: http://crrev.com/c/2878093 - Add missing perf scripts: http://crrev.com/c/2877011 - Include build_properties: http://crrev.com/c/2878373 Bug: angleproject:5114 Change-Id: If7d1e5693c4ade72d3f45f5d60635cb27de7599e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877012 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 1572c372 2021-05-06T09:55:30 infra: Temporarily disable all swarming tests. There seem to be some unusal failures on CI. Maybe Try as well. Bug: angleproject:5114 Change-Id: Ia681d6fdb8575b851dd526c1ab9463ad047735c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875767 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill aa19de17 2021-05-06T09:32:07 infra: Fix exclusion spec JSON. The extra comma caused the CQ to fail reading the file. Bug: angleproject:5114 Change-Id: I5d36f1ae7c4dc5ebcb5599d5cd37471ee4085990 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876985 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 0fb204bd 2021-05-05T17:55:37 infra: Exclude infra/specs from analyze. This will force any changes to the infra/specs folder to trigger a full set of tests on a builder. Bug: angleproject:5114 Change-Id: Ie640b52dd7f12163d0c91843d80dbab7f33209d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875356 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill db670c82 2021-05-05T17:12:58 infra: Enable dcheck_always_on in Release. This will assure that ANGLE ASSERT macros work in Release. Bug: angleproject:5114 Change-Id: I0fe6b83592ac3ff3462e55b8a73a11c8f114a4a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875355 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 167480cc 2021-05-05T17:05:55 infra: Switch CI to use component builds everywhere. This makes the build the same as the Chromium-based configuration. This also works around a problem with the Mac bots where the shader cache workaround isn't operational in non-component builds. Bug: angleproject:5114 Bug: angleproject:5928 Change-Id: Ib466942f4a69e1ba3e61e078c84d74d0b54bb396 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875354 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 18c9aa0d 2021-04-29T15:25:32 Run test spec update as part of codegen. Test specs now will be updated when the Chromium build files change. It will be automatically included as part of the Chromium->ANGLE roll. Bug: angleproject:5114 Change-Id: If99c2a20033d417a5999295f425a3bb203f5da3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2860962 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 167a4b6d 2021-05-05T13:42:44 infra: Add Linux isolated scripts to specs. We were missing the perftests and Gold tests from Linux Intel/NV. Bug: angleproject:5114 Change-Id: I1cfc0963b3890c621f0646bb5879e47ea6d336a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2873457 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 83a1a385 2021-05-03T12:42:05 infra: Add trybot_analyze_config. This file is used to specify ignores and excludes for analyze. Initially only contains DEPS. Whenever a file in exclusions is changed, we'll run the entire CQ instead of only the affected tests. Bug: angleproject:5114 Change-Id: Ie7328604f5ee56288f992710d5c3dbc559e6d9a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867886 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
John Plate df657c96 2021-04-29T11:22:03 Disable OpenCL support for Windows UWP CI builds Bug: angleproject:5908 Change-Id: I451e232e545248ff9755cc3f2a4907b8af2fdc2c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859742 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: John Plate <jplate@google.com>
Jamie Madill a8d98f7a 2021-04-29T11:32:37 infra: Update mixins. The Mac mixins were updated. Ideally we could do this automatically on Chromium rolls. Bug: angleproject:5114 Change-Id: I412e227193e7a6503c04dee5df6bb2a4cf1cc1f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2857597 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 7c53d6af 2021-04-26T15:20:27 infra: Auto-generate mixins.pyl. The generate_test_spec_json.py file now reads ANGLE's waterfalls.pyl and Chromium's mixins.pyl to find the referenced mixins and copy them into ANGLE's mixins.pyl. This way we can update ANGLE's mixins easily without needing to manually copy them from Chromium's. In a follow-up we could make this run on the Chromium auto-roller. Bug: angleproject:5114 Change-Id: I332b3182732985b261e107dfe9a5c7c413c410a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2849184 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 1bdd34ff 2021-04-26T09:04:59 infra: Add test specs for standalone tests. Includes test specs for Linux/Mac/Win7/Win10. Android is left out for a second pass to keep the changes a bit simpler. Bug: angleproject:5114 Change-Id: I94e7f7f273073f85488ec982e89b4b68f45627ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2805371 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
John Plate 9acfccbd 2021-04-23T21:59:57 Disable OpenCL support by default Bug: angleproject:5892 Change-Id: I99d4c0e450e469f911abc05fbe1e714190e16900 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848508 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: John Plate <jplate@google.com>
Jamie Madill d170f8e1 2021-04-20T19:17:17 infra: Add configs for Android build. Updates the configs to use the new protobuf properties. Adds support for ARM/ARM64 Android builds. Must be landed in conjunction with http://crrev.com/c/2841787 . Bug: angleproject:2344 Bug: angleproject:5114 Change-Id: I49f4f46ceaa7ce9118c9f4b4ceb06353b00429b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842306 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill fe4053ba 2021-04-13T13:08:40 infra: Add angle_mb_config.pyl. This will be used to set up gn args for standalone builds. We can then set the GN args source-side instead of in the recipe directly. Bug: angleproject:5114 Change-Id: I6fac6d13903951031a7299aea203f6b3e13c72bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819461 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>