|
e5b82697
|
2020-04-28T07:01:20
|
|
Roll third_party/SwiftShader 60aa34a990fa..2717702e9a1f (6 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/60aa34a990fa..2717702e9a1f
git log 60aa34a990fa..2717702e9a1f --date=short --first-parent --format='%ad %ae %s'
2020-04-28 capn@google.com Eliminate the ABORT() macro
2020-04-27 capn@google.com Record vkCmdBindDescriptorSets() as a single command
2020-04-27 capn@google.com Store binding information in the pipeline layout
2020-04-27 capn@google.com Don't expose individual descriptor set layouts to SPIR-V compilation
2020-04-27 capn@google.com Fix ordering of descriptor set bindings
2020-04-27 bclayton@google.com SpirvShader: Document activeLaneMask() and storesAndAtomicsMask()
Created with:
gclient setdep -r third_party/SwiftShader@2717702e9a1f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I1e6de4a3f586a4f06925138499142efeb91bed58
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2169968
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
2597459f
|
2020-04-28T07:01:07
|
|
Roll third_party/spirv-tools/src 5547553a0c7b..23d68608b007 (7 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5547553a0c7b..23d68608b007
Created with:
gclient setdep -r third_party/spirv-tools/src@23d68608b007
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ie81ef413c12cd1e8744c6e7f28adb378db79bc07
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2169966
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
7c83a445
|
2020-04-28T07:01:25
|
|
Roll third_party/glslang/src bcf6a2430e99..f03cb290ac10 (3 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/bcf6a2430e99..f03cb290ac10
Created with:
gclient setdep -r third_party/glslang/src@f03cb290ac10
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I4a270118c0d579d2125478dc44512cc98e708338
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2169969
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
4395170e
|
2020-04-27T16:57:46
|
|
Roll chromium_revision fa9d5805c4..b0410bba02 (750702:763000)
Includes a change from yasm to nasm.
Change log: https://chromium.googlesource.com/chromium/src/+log/fa9d5805c4..b0410bba02
Full diff: https://chromium.googlesource.com/chromium/src/+/fa9d5805c4..b0410bba02
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/a1cbf6469a..45ab3c89af
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4164a30562..204a35a2a6
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/3e21eec53c..3993ef1f52
* third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/c96dc32110..217407c478
* third_party/jsoncpp: https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/493c9385c9..ec647b85b6
* third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/ce0e57e8e6..7e3ad79800
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/156be8c52f..ae385786ed
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d60a6a8084..04b99e7bf9
* tools/md_browser: https://chromium.googlesource.com/chromium/src/tools/md_browser/+log/0bfd826f85..aae45d8d82
DEPS diff: https://chromium.googlesource.com/chromium/src/+/fa9d5805c4..b0410bba02/DEPS
Clang version changed 9284abd0040afecfd619dbcf1b244a8b533291c9:4e0d9925d6a3561449bdd8def27fd3f3f1b3fb9f
Details: https://chromium.googlesource.com/chromium/src/+/fa9d5805c4..b0410bba02/tools/clang/scripts/update.py
Tbr: jmadill@chromium.org
Bug: chromium:1070043
Change-Id: I8f2cd61950b1a94b946eace49a7f1da3447522ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2168533
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
4262ea04
|
2020-01-31T22:59:13
|
|
Vulkan: Add gles1 conformance support.
For Khnoros CTS1 support, ANGLE needs to add conformant and
rendererType for OpenGL ES1 version.
Bug: angleproject:4457
Change-Id: I58ac4672352d3d42e4b8403b80f86154b6a76edc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160515
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
fbc2f063
|
2020-04-24T13:00:11
|
|
Vulkan: Refactor AttachmentOpsArray.
Will allow for more flexibly setting ops when we defer clears.
Bug: angleproject:4517
Change-Id: I7d9116bc92e90eb41a1030fea242eadf1cc74562
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2165629
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
6193fd69
|
2020-03-07T21:19:05
|
|
OpenGL: Implement OES_draw_buffers_indexed
OpenGL state sync issues as few GL commands as possible to update the
blend state regardless of an application input.
Enhanced ClearTestES3.MaskedIndexedClearMultipleAttachments
regression test.
Disabled OES_draw_buffers_indexed on Windows/AMD/OpenGL.
Bug: angleproject:4394
Change-Id: I244ac2975678bc559634152cf4eb997d9dbe83d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2145874
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
6e7d7296
|
2020-04-24T15:40:57
|
|
Fix clearing compressed textures with Vulkan backend
When making sure a texture's data is initialized in ANGLE, it
is illegal to attempt to clear it when using the Vulkan backend.
The Vulkan spec, regarding vkCmdClearColorImage, mentions that:
"image must not have a compressed or depth/stencil format"
The proper way of initializing the memory of a compressed image
in Vulkan is to do a buffer to image copy instead. This was added
to ImageHelper::stageRobustResourceClear() so that it may now
handle compressed textures properly.
Bug: angleproject:4092
Change-Id: I073ed0603d9e92e787b9be8992751dbc0c8978db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2165636
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
|
|
d6c7bac9
|
2020-04-18T01:41:14
|
|
Add BlendStateExt helper structure
It provides compact storage and comparison operations for
per-drawbuffer blend states.
Added BitSetT::Zero() static constexpr.
Bug: angleproject:4394
Change-Id: I66d6275facb7b28022fc24ff9cc0d8c3c976c99d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2154669
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
226bba3c
|
2020-04-24T09:57:10
|
|
Add -Wno-pointer-to-int-cast
This is the last remaining instance of the warning across Chromium. It's
fixed upstream but I can't seem to figure out how to successfully roll
deqp. So suppressing it here for now.
This can be removed once the deqp in Angle has
https://github.com/KhronosGroup/VK-GL-CTS/pull/199.
Change-Id: Ie954bb2a3d86ea0de644e2a78051531b396e88a8
Bug: chromium:1054220
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2165365
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
821726de
|
2020-04-27T07:01:18
|
|
Roll third_party/vulkan-loader/src 4fb0e0374a39..3336e65e8801 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/4fb0e0374a39..3336e65e8801
git log 4fb0e0374a39..3336e65e8801 --date=short --first-parent --format='%ad %ae %s'
2020-04-24 lenny@lunarg.com loader: Check for null when creating a queue
Created with:
gclient setdep -r third_party/vulkan-loader/src@3336e65e8801
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I6ba1a7862b89939aa652ce5c6eeb95376f1dfb5d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2167771
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
2a37fab2
|
2020-04-27T08:27:25
|
|
Roll third_party/glslang/src 7d65f09b8311..bcf6a2430e99 (3 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7d65f09b8311..bcf6a2430e99
Created with:
gclient setdep -r third_party/glslang/src@bcf6a2430e99
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cnorthrop@google.com
Change-Id: I973b0f74a757339badbc21555940bd04a45365bc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2167780
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
55b639e6
|
2020-04-27T07:01:26
|
|
Roll third_party/vulkan-validation-layers/src bb0380e3932a..1512acdf047f (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/bb0380e3932a..1512acdf047f
git log bb0380e3932a..1512acdf047f --date=short --first-parent --format='%ad %ae %s'
2020-04-24 karen@lunarg.com docs: update khronos_validation_layer.md
2020-04-24 lionel.g.landwerlin@intel.com Fix validation of blended attachments on imageless framebuffers
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@1512acdf047f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: Ib8cd5bbc69271183bf3dc2b9f391dab045db9d81
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2167774
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
a67630cd
|
2020-04-27T07:01:20
|
|
Roll third_party/SwiftShader f42c698d784a..60aa34a990fa (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/f42c698d784a..60aa34a990fa
git log f42c698d784a..60aa34a990fa --date=short --first-parent --format='%ad %ae %s'
2020-04-24 capn@google.com Omit ASSERT() expression evaluation in Release builds
Created with:
gclient setdep -r third_party/SwiftShader@60aa34a990fa
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: Ia3d9e7ad2459696eff50e5666099c69ef1f5cd58
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2167772
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
3cb9c4be
|
2020-03-13T13:56:47
|
|
Statically link vulkan-loader on Mac
Disable angle_shared_libvulkan on Mac since we are the only client.
Re-add codepaths to support this.
Bug: angleproject:4477
Change-Id: Ie128c83adaae741636541bbfd6105d160d874a8d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102954
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>
|
|
0f2747e9
|
2020-04-24T13:10:14
|
|
Vulkan: Clean up ClipRectToScissor.
Refactoring change only. Split off to make the main CL for deferring
clears simpler.
Bug: angleproject:4517
Change-Id: I5728a7dcf09de8952d5810061d1d8b135b625339
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2165630
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
35e389cc
|
2020-04-24T13:33:36
|
|
Vulkan: Remove unicode character from error string.
Will fix presubmit checks on Windows.
Bug: angleproject:4586
Change-Id: I36cec3e850c88a015f33d8a0bb7cc8f8c26402d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2165628
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
ab1a2f62
|
2020-04-24T14:40:24
|
|
Roll third_party/SwiftShader 5ab1f36a38aa..f42c698d784a (8 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/5ab1f36a38aa..f42c698d784a
git log 5ab1f36a38aa..f42c698d784a --date=short --first-parent --format='%ad %ae %s'
2020-04-24 bclayton@google.com SpirvShaderDebugger: Ensure frames are fully popped
2020-04-24 bclayton@google.com SpirvShaderDebugger: Implement globals, stub array types
2020-04-24 bclayton@google.com SpirvShader: Add WriteCFGGraphVizDotFile debug function
2020-04-24 pcc@google.com Don't unlock Android buffers immediately after locking them.
2020-04-23 digit@google.com LLVM: Do not map read-only data sections as executable.
2020-04-23 digit@google.com Vulkan: Add vk_icdInitializeConnectToServiceCallback()
2020-04-23 amaiorano@google.com Kokoro: fix SWIFTSHADER_LESS_DEBUG_INFO not being set
2020-04-23 digit@google.com Update tests/presubmit.sh to accept Fuchsia bugs as fxb/#
Created with:
gclient setdep -r third_party/SwiftShader@f42c698d784a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I40a8d09e11114449134a00d855d0708b5644b965
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2164871
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
5a86ca60
|
2020-04-24T07:01:32
|
|
Roll third_party/spirv-tools/src 67f4838659f4..5547553a0c7b (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/67f4838659f4..5547553a0c7b
Created with:
gclient setdep -r third_party/spirv-tools/src@5547553a0c7b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I9b1ae40819a0ab494d7d542abc6901aea1a3ef0a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2164311
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
d7f94536
|
2020-04-24T07:01:22
|
|
Roll third_party/vulkan-validation-layers/src 260a7c82e988..bb0380e3932a (3 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/260a7c82e988..bb0380e3932a
git log 260a7c82e988..bb0380e3932a --date=short --first-parent --format='%ad %ae %s'
2020-04-23 s.fricke@samsung.com tests: Add YCbCr Format Feature VUIDs
2020-04-23 s.fricke@samsung.com layers: Add YCbCr Format Feature VUIDs
2020-04-23 tony@lunarg.com gpu: Fix promoted buffer device address
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@bb0380e3932a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I3a3be970a68ae50dd95ea612aafc51e4516e4fdd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2164309
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
504ec9a1
|
2020-04-24T07:04:25
|
|
Roll third_party/vulkan-headers/src 382bf3de06fc..62becc509a88 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/382bf3de06fc..62becc509a88
git log 382bf3de06fc..62becc509a88 --date=short --first-parent --format='%ad %ae %s'
2020-04-23 mikew@lunarg.com Revert "Export versioned targets for CMake"
Created with:
gclient setdep -r third_party/vulkan-headers/src@62becc509a88
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
TBR=tobine@google.com
Bug: None
Change-Id: I016705256e4cfea044b9482975e1c2373e5846bb
Tbr: tobine@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2163918
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
21c5af31
|
2020-04-20T10:29:13
|
|
Vulkan:Migrate events and queries to secondary Cmd Buffer
Replace flushAndGetPrimaryCommandBuffer() function with
endRenderPassAndGetCommandBuffer() for events and queries. The end
result should be the same, but this allows a number of places that were
putting commands directly into the primary to put the commands into
ANGLE's custom SecondaryCommandBuffer (SCB) instead.
This also fixes a couple of minor bugs related to command buffer
ordering. flushAndBeginRenderPass() now flushes any outside
RenderPass (RP) commands first. Also, when insideRP commands are
flushed to the primary, set "mHasPrimaryCommands = true;"
Bug: b/153666475
Change-Id: I68413f25d27175afed0a20bc49f22f4c8d01e4fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2156932
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
5578fc84
|
2020-04-22T09:34:30
|
|
Vulkan: Disable EXT_texture_sRGB_R8
Due to a dEQP bug, EXT_texture_sRGB_R8 cannot be exposed before
EXT_texture_sRGB_decode is available. This change disables
EXT_texture_sRGB_R8 on the vulkan backend.
Bug: angleproject:3609
Test: dEQP-GLES31.functional.srgb_texture_decode.skip_decode.sr8.*
Change-Id: I261c80986484e489f6903eb54ac6865433050bfa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2161985
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
|
|
23621826
|
2020-04-23T10:09:03
|
|
Vulkan: Manual Validation Layer Roll
Latest Vulkan validation layer roll is hitting new error so added
exception and rolling manually.
Bug: angleproject:4583
Change-Id: Id9f8be7d2e20156ad8397ee0ba7ea5fcc12f6d28
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2163133
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
e20f36f4
|
2020-04-21T15:45:44
|
|
EGL: Implement EGL_ANDROID_native_fence_sync on vulkan
Check the following -
1. Vulkan ICD supports VK_KHR_external_fence_fd
2. ExternalFenceProperties and ExternalSemaphoreProperties
support Android FD.
eglCreateSync - if FD was provided import to VkFence,
else create VkFence with new FD and then
flush and submit VkFence on next vkQueueSubmit.
eglGetSyncAttrib - for status call vkGetFenceStatus.
eglDupNativeFenceFdANDROID - return FD from vkGetFenceFD call.
eglClientWaitSync - call vkWaitForFences.
eglWaitSync - dup FD, create VkSemaphore and import FD, then
flush() and add VkSemaphore to next vkQueueSubmit
as a waiting semaphore.
Extended end2end test suite with nativefence test cases.
Bug: angleproject:2517
Test: angle_end2end_tests --gtest_filter=EGLSyncTest.AndroidNativeFence_*
Change-Id: I8f6a6f4c3d71d83007f662b78377aa015a740035
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2026177
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
963759a3
|
2020-04-21T15:14:56
|
|
Vulkan: Mask out implementation dirty bit in sync.
This would needlessly create many redundant sampler objects.
Bug: angleproject:4517
Change-Id: Ib8ef28b9bcbbeec804c493fbe677cbee7d9a750d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2159296
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
492ec932
|
2020-04-21T13:38:41
|
|
Vulkan: Track allocated sampler counts.
Helps to diagnose perf bugs where resources are over-allocated. Also
can be useful to evaluate caching strategies.
Bug: angleproject:4517
Change-Id: I48df5a09fbc394fa0b1712fa8cf28a179665e6e7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2159293
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
|
|
6fc0066a
|
2020-04-21T17:40:54
|
|
Vulkan: Add a sampler cache.
This uses a packed sampler description to re-use samplers for multliple
VkImages. The samplers will persist for the lifetime of RendererVk. In
the future we could look at doing cache eviction for large object
counts.
Reduces the active VkSampler cache in Manhattan from over 1200 to 9.
Also should reduce the number of VkSamplers used with Chrome.
Bug: angleproject:4491
Change-Id: Idca00e4ed8cb660a0865281544aaa57cf884bbdb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160771
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
e58df20c
|
2020-04-23T07:01:22
|
|
Roll third_party/vulkan-tools/src 84463fe2902f..7774c964d3df (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/84463fe2902f..7774c964d3df
git log 84463fe2902f..7774c964d3df --date=short --first-parent --format='%ad %ae %s'
2020-04-22 mikes@lunarg.com scripts: Sync GN json script with ValidationLayers
Created with:
gclient setdep -r third_party/vulkan-tools/src@7774c964d3df
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: Idcad5ab15239e4f08089a4778d8513568e21aada
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2162330
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
17698998
|
2020-04-23T07:01:24
|
|
Roll third_party/SwiftShader ceb6258ae101..5ab1f36a38aa (12 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/ceb6258ae101..5ab1f36a38aa
git log ceb6258ae101..5ab1f36a38aa --date=short --first-parent --format='%ad %ae %s'
2020-04-22 capn@google.com Fix specializing graphics routines for the pipeline layout
2020-04-22 bclayton@google.com SpirvShader: Add a flag for printing SPIRV execution
2020-04-22 bclayton@google.com Regres: Write logs to /dev/null
2020-04-22 amaiorano@google.com CMake: use target_compile_options/definitions for llvm
2020-04-22 amaiorano@google.com CMake: use target_link_options
2020-04-22 amaiorano@google.com CMake: require version 3.13
2020-04-22 amaiorano@google.com Kokoro: update CMake to latest version
2020-04-22 bclayton@google.com Regres: Limit the default number of threads to 100
2020-04-22 capn@google.com Pass only descriptor data to shader execution
2020-04-22 capn@google.com Reduce descriptor binding info exposure
2020-04-22 bclayton@google.com Kokoro: Fix ubuntu bots.
2020-04-22 digit@google.com Vulkan: Fix Fuchsia external semaphore fix tryWait().
Created with:
gclient setdep -r third_party/SwiftShader@5ab1f36a38aa
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: Iaecb86196fbe0915facf2e921b816699cb582bc4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2162331
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
583b7c74
|
2020-04-23T07:01:31
|
|
Roll third_party/glslang/src c9b28b9f3388..7d65f09b8311 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c9b28b9f3388..7d65f09b8311
Created with:
gclient setdep -r third_party/glslang/src@7d65f09b8311
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I11fb156b2d400a53fa57cf80f669b692de44ecfd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2162332
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
4671bcf0
|
2020-04-21T18:12:46
|
|
Fix program interface queries for arrays and built-ins
Program interface queries for arrays should return an invalid index
value for indices with leading zeroes.
Program interface queries should return invalid locations for built-in
variables.
Bug: angleproject:3596
Test: KHR-GLES31.core.program_interface_query.*
Change-Id: I484ab6e21dbe0c8a984e135ac947c4583a3fbfa2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2159646
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
913f4f42
|
2020-04-15T00:54:37
|
|
Vulkan: Support VS, FS, and CS in the same PPO
This CL adds support for a Program Pipeline Object to have a VS, FS,
and CS attached to the same PPO and then using that PPO for both draw
and dispatch calls.
Bug: angleproject:3570
Test: KHR-GLES31.core.compute_shader.sso*
Change-Id: I262cdbdfd442f6db5ba2b45d1308003102b237cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2150078
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
78dcba58
|
2020-04-21T15:20:13
|
|
Refactor SyncHelper with vk::Resource
Set SyncVk's SyncHelper to inherit from vk::Resource.
Bug: angleproject:2517
Change-Id: I499414d97e611d029abc12622f19436cbdb3e1f5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160126
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
1fc354fa
|
2020-04-22T11:49:00
|
|
Re-land: "Vulkan: Forward RenderBuffer/Surface dirty messages."
Re-land fixes ASSERT on Android GLES.
Previously we were only forwarding Texture staging changes to the
Framebuffer for re-sync. We could miss out on clears that were staged
in Surfaces and Renderbuffer attachments. Complete the chain by making
the SurfaceVk and RenderbufferVk forward notifications from the
VkImage.
Bug: angleproject:4517
Change-Id: I91d31213b115a58546b574caa574eebbb098266c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2159294
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
0e1798d6
|
2020-04-20T11:25:32
|
|
Vulkan: PPO: Allocate uniform descriptor set if list is empty
When a Program is used to draw, the buffers to hold uniforms are
allocated as part of updateUniforms(), and then if a buffer is
allocated, a corresponding descriptor set is allocated for each shader
stage with uniforms. However, if that Program is later bound to a PPO,
the PPO's descriptor set list is cleared as part of creating the
pipeline layout. This means the uniform descriptor sets need to be
re-allocated but using the previously allocated buffers so the
'anyNewBufferAllocated' flag isn't enough - we also need to check if
the PPO's list of descriptor sets is empty.
Bug: angleproject:3570
Test: KHR-GLES31.core.sepshaderobjs.StateInteraction
Change-Id: Id8df587b4f5552012590a29d120b6899bbdf677b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2156936
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
dadd1986
|
2020-04-21T01:50:00
|
|
Implement GL_APPLE_clip_distance
- Built-in variable gl_ClipDistance has been added to compiler.
- Desktop GL: gl_ClipDistance is supported since GL 3.0. Enable/Disable
each gl_ClipDistances[i] works out of the box via glEnable().
- Vulkan/Metal: Use uniform variable to control writing to each
gl_ClipDistance. One bit flag controls one element in the gl_ClipDistance
array. The writing to the disabled element in vertex shader will be
ignored, and turned into zero assignment instead.
- Direct3D/Mobile GL: Not implemented yet.
- Added ClipDistanceTest to gl_tests and compiler unittests.
- GL_APPLE_clip_distance is a subset of GL_EXT_clip_cull_distance, so
GL_EXT_clip_cull_distance could be implemented in future if needed.
Bug: angleproject:4452
Change-Id: I571ac8b56826989808a680226a04bec4cf59988e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2084324
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
927ea225
|
2020-04-21T19:42:18
|
|
Vulkan: add vulkan error code in the error message
If driver returns error code that we do not know, we simply output
"unknown vulkan error code". Instead we should at least include the
actual errorCode here so that people can search up to see what it is.
Also remove the double period at the end of string and added a few other
vulkan error strings.
Bug: b/154665382
Change-Id: Ic4138e90534b4e7d97520fe10ac1477d2930d9c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160130
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
b5992a55
|
2020-04-21T07:58:47
|
|
Add capture support for FenceSync
This allows us to capture Angry Birds 2 traces.
Bug: b/153652100
Change-Id: I99a47f9e41a84218b3bb3d9740df4bb7fc2a01fa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2144763
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
183c5557
|
2020-04-22T07:01:21
|
|
Roll third_party/vulkan-validation-layers/src 09f4b08483bb..36d7cca6fdc9 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/09f4b08483bb..36d7cca6fdc9
git log 09f4b08483bb..36d7cca6fdc9 --date=short --first-parent --format='%ad %ae %s'
2020-04-21 tony@lunarg.com layers: Fix renderpass2 tracking
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@36d7cca6fdc9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: Iddad6155212d216fb1bcee45006707a0ffc2d451
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160273
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
2694e7e0
|
2020-04-22T07:01:24
|
|
Roll third_party/SwiftShader ff772a7bcc98..ceb6258ae101 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/ff772a7bcc98..ceb6258ae101
git log ff772a7bcc98..ceb6258ae101 --date=short --first-parent --format='%ad %ae %s'
2020-04-21 amaiorano@google.com CMake: fix astc code not being enabled correctly
Created with:
gclient setdep -r third_party/SwiftShader@ceb6258ae101
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I469606bfc8fd7433d14770f2158954ea8d78458a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160274
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
46daa966
|
2020-04-22T07:01:31
|
|
Roll third_party/glslang/src 3f4e5c456306..c9b28b9f3388 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3f4e5c456306..c9b28b9f3388
Created with:
gclient setdep -r third_party/glslang/src@c9b28b9f3388
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I82d61d8560b2d48d54f405d879aa20f5e8197f16
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160275
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
b7d6949b
|
2020-04-17T13:36:14
|
|
Vulkan: Enable persistently mapped buffer objects
The VMA allocator has a handy feature where during memory
allocation we can request persistently mapped memory.
This saves IOCTL overhead for apps that update buffers
frequently.
Bug: angleproject:2162
Change-Id: I870d880033beec343efae6de06f1c5935de4c2c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2155131
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
fe60973b
|
2020-04-21T11:21:03
|
|
Vulkan: Allow commands to completely fill allocation
If the remaining allocation size for commands in the
SecondaryCommandBuffer class is equal to the command allocation
size and the follow-on header, then we can fill the allocation.
Previously we were conservative and if the size needed exactly
equals the size remaining, we would allocate a new block.
Bug: b/154030403
Change-Id: Ie31f0f5d33782d12adbaea9e3b02598a004d7643
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158817
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
9dc322d7
|
2020-04-21T11:41:43
|
|
GL: Make sure primitive restart emulation is disabled below GL 3.1
If the GL driver version is below 3.1, we cannot set the primitive
restart fixed index (ES3 wont be supported anyway). Make sure the
feature is disabled.
Speculative fix for crbug.com/1073020
BUG=chromium:1073020
BUG=angleproject:3997
Change-Id: I67756b377aa951da2e70c26f7db978ede9010586
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2159289
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
03c18fbd
|
2020-04-13T16:01:01
|
|
Vulkan: Skip load if depth/stencil value are undefined
EGL1.5 spec says depth/stencil data are undefined after swap. This CL
will track the depth/stencil data and mark it as undefined and skip the
load if it is undefined.
Bug: b/153885625
Change-Id: Ifb3d88d442da547fa78c1eae091cbae08a20d0ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2148179
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
764d572b
|
2020-04-21T11:15:41
|
|
Vulkan: Refactor SecondaryCommandBuffers class
A strictly cosmetic change to move code into alphabetical order.
In working with SecondaryCommandBuffer commands in separate CLs,
it can be difficult/annoying to track which commands are already
in place as some of them are out-of-order. This change puts the
command enums, functions, and processing in alphabetical order
to simplify searching and adding new commands.
Bug: b/154030403
Change-Id: I6dba4cf48d6f27c056585ac633c694e083b1a263
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158816
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
e5491253
|
2020-04-17T12:37:00
|
|
Don't redefine VMA_IMPLEMENTATION in build files and source
VMA_IMPLEMENTATION is defined in the build files, it doesn't need
to be redefined in vk_mem_alloc_wrapper.cpp.
BUG=angleproject:2162
Change-Id: Ie4eceedd2dd3051f8431c7c8c86403250e93f98b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2154538
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
623d0443
|
2020-04-21T15:15:03
|
|
Revert "Vulkan: Forward RenderBuffer/Surface dirty messages."
This reverts commit 3fb33ade6ec8f286797bff5645304df580b1a963.
Reason for revert: Causing WebGL test failures on GLES/ANGLE/Android.
Bug: chromium:1072739
Original change's description:
> Vulkan: Forward RenderBuffer/Surface dirty messages.
>
> Previously we were only forwarding Texture staging changes to the
> Framebuffer for re-sync. We could miss out on clears that were staged
> in Surfaces and Renderbuffer attachments. Complete the chain by making
> the SurfaceVk and RenderbufferVk forward notifications from the
> VkImage.
>
> Bug: angleproject:4517
> Change-Id: I15f36c225517e915f656d0c2464a99631ef9f945
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2150699
> Reviewed-by: Cody Northrop <cnorthrop@google.com>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
TBR=cnorthrop@google.com,timvp@google.com,jmadill@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: angleproject:4517
Change-Id: I4fd4d79dc11da0ba86065d3a80975de4c791a2a0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2159288
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
293c36c0
|
2020-04-20T17:35:19
|
|
Vulkan: Manual validation roll
Manually roll validation layers to latest and ignore two more VUIDs that
are being flagged with latest layers.
Bug: angleproject:4578
Bug: angleproject:4579
Bug: angleproject:4580
Change-Id: I4fc46d9df3fa3be4be1f8b773eb2d63e6f4bbd92
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158265
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
ad85cd00
|
2020-04-21T11:47:50
|
|
Fix quotes around emails in WATCHLISTS
Quotes were around the entire list of emails instead of around
individual ones.
Change-Id: Ice783622eb31981f606f49f57984a15771ace995
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2159290
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
902b5587
|
2020-04-19T13:54:48
|
|
CGL/EAGL: Fix default FBO size on Retina displays
This was found while trying to fix
https://github.com/glfw/glfw/issues/1169
VulkanSurfaceMtl and metal/SurfaceMtl already handle contentsScale
correctly.
Change-Id: I234d7b0901dd7c075cf1e9d58466f52140ab1e2b
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2154670
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
|
|
4a1d9226
|
2020-04-21T07:01:30
|
|
Roll third_party/vulkan-loader/src 50eaecd721a2..4fb0e0374a39 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/50eaecd721a2..4fb0e0374a39
git log 50eaecd721a2..4fb0e0374a39 --date=short --first-parent --format='%ad %ae %s'
2020-04-20 petr_kraus@email.cz docs: Fix link in interface docs
Created with:
gclient setdep -r third_party/vulkan-loader/src@4fb0e0374a39
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I663809ab903c97827ccca4c8b9f290e59a0a1ffd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158781
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
898c214c
|
2020-04-21T07:01:37
|
|
Roll third_party/spirv-tools/src 61b7de3c39f0..67f4838659f4 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/61b7de3c39f0..67f4838659f4
Created with:
gclient setdep -r third_party/spirv-tools/src@67f4838659f4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: I55e966b6836899c1fc656620c271b0f8d8db0b0a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158783
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
27a80a55
|
2020-04-21T07:01:38
|
|
Roll third_party/SwiftShader 068611f07d28..ff772a7bcc98 (1 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/068611f07d28..ff772a7bcc98
git log 068611f07d28..ff772a7bcc98 --date=short --first-parent --format='%ad %ae %s'
2020-04-20 capn@google.com Don't use deprecated llvm::Type::getVectorNumElements()
Created with:
gclient setdep -r third_party/SwiftShader@ff772a7bcc98
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: Icb8097e2c135d1dbb7dc3cd3258f65b28066cda3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158784
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
a6aad7f8
|
2020-04-21T07:01:30
|
|
Roll third_party/vulkan-tools/src 8824107d57d3..84463fe2902f (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/8824107d57d3..84463fe2902f
git log 8824107d57d3..84463fe2902f --date=short --first-parent --format='%ad %ae %s'
2020-04-20 petr_kraus@email.cz repo: Update the clang style from VVL
Created with:
gclient setdep -r third_party/vulkan-tools/src@84463fe2902f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: tobine@google.com
Change-Id: Ic492d090c5c2e1b5e75ed9ed5f586b23f4f13942
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158779
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
cff64a83
|
2020-04-16T17:32:40
|
|
Capture/Replay: More mid-execution capture support
Test: Temple Run MEC capture and replay
Bug: b/152512564
Bug: angleproject:3662
Change-Id: I31be6e7ad9d290c2077f2f4d975c2d66779eb558
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2155490
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
edc7614c
|
2020-04-17T17:20:08
|
|
Capture/Replay: Handle default uniforms during MEC
During mid-execution capture, when processing uniforms for a program,
capture their values and repopulate during replay.
Test: Temple Run MEC capture and replay
Bug: b/152512564
Bug: angleproject:3662
Change-Id: If84711ead144b7c88710e6b12d0968e80e263c69
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2155489
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
8f48ba9f
|
2020-04-16T17:30:45
|
|
Capture/Replay: Use TexStorage for immutable images
When we detect a texture is immutable, create it with TexStorage
and populate with TexSubImage.
Test: Temple Run MEC capture and replay
Bug: b/152512564
Bug: angleproject:3662
Change-Id: I1948a0376d2634957329d1da35d60ded3608479a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2155488
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
|
|
139f8149
|
2020-04-20T14:04:25
|
|
Vulkan: Suppress VUID-vkCmdClearColorImage-image-01993
The latest VVL roll is generating many new errors for
VUID-vkCmdClearColorImage-image-01993. This CL will suppress the
error messages to prevent the test failures until they can be fixed.
Bug: angleproject:4577
Change-Id: I3ea4986c1f43c7d7921761e537d6d51cac3327e5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2157853
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
54a3d7cb
|
2020-04-20T12:02:02
|
|
Vulkan: Use DontCare for the presentable surface's last renderpass depth/stencil storeOp
The EGL spec says depth/stencil value are undefined after swap. We dont
need to store depth/stencil value if this is the very last renderpass of
a presentable surface and the endRenderpass call is from swap call.
Bug: b/153885625
Change-Id: Ie853d2686c8eb15a4fa9dbdd80eb66e9fc037d24
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2157886
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
39efa4df
|
2020-04-20T14:20:12
|
|
doc: Update ANGLE Try Waterfall links
Bug: angleproject:1944
Change-Id: I200ee1bbd2c1e856e97db24dff2ab550292ba248
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2157888
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
f13689b6
|
2020-04-17T14:43:28
|
|
Vulkan: Use renderpass' finalLayout to transit to ImageLayout::Present
This detects the last renderpass is actually rendering to the image we
are going to present and this is the very last renderpass to that image.
We use finalLayout of the renderpass to do layout transition to
VK_IMAGE_LAYOUT_PRESENT_SRC_KHR instead of a standalone barrier call.
Bug: b/153885625
Change-Id: Ifc17c77a1ba12f22c9d6038775f3e254c35655ca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2155250
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
ebc4846d
|
2020-04-17T10:42:02
|
|
Vulkan: Suppress VUID-vkCmdCopyImageToBuffer-srcImage-01998
The latest VVL roll is generating many new errors for
VUID-vkCmdCopyImageToBuffer-srcImage-01998. This CL will suppress the
error messages to prevent the test failures until they can be fixed.
Bug: angleproject:4572
Test: BindUniformLocationES31Test.ArrayOfArrays/ES3_1_Vulkan_SwiftShader
Change-Id: I6b36ab64cea8490e577f9077bb44fc7e5023fbda
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2154833
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
e8ecd19a
|
2020-04-16T10:18:19
|
|
Add cclao@ and timvp@ to watch for vulkan CLs
This CL adds cclao@ and timvp@ to watch for vulkan CLs so they can be
notified for reviews.
Bug: None
Change-Id: Iea55a95aa2037ae5c141665dfa494c809a5befa2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152946
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
8cae5e19
|
2020-04-08T12:28:03
|
|
GL: Re-enable emulatePrimitiveRestartFixedIndex
This workaround is needed when the GL driver is less than 4.3 (all
MacOS). The driver will generate many errors during execution without
this enabled which blocks GL driver error checking.
Add additional workarounds for Intel drivers that need a sufficiently
large primitive restart index when doing DrawArrays calls.
BUG=angleproject:3997
Change-Id: Idd293ff1dbc0a3609b11ea1d6b30da0a99e8f5c5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2141714
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
|
|
a5e46552
|
2020-04-20T09:33:21
|
|
Vulkan: glDrawElements used old offset into index buffer
When the vertex array binding is changed, the value of
ContextVk::mLastIndexBufferOffset must be reset so that an
old/cached offset (from a previous draw call) is not used for a
new draw call.
This addresses rendering artifacts and Vulkan validation errors
seen with running NBA 2K20 on Android (or the ANGLE trace on
Windows).
Bug: b/153682968
Bug: angleproject:4575
Bug: angleproject:4576
Change-Id: I69089964b8d278c7fc8610ab003548864a215dab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152850
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
de2935dd
|
2020-04-14T21:18:43
|
|
Add PackedEnums for blend state parameters
Bug: angleproject:4394, angleproject:2169
Change-Id: I6c218af3871a1215c2b103847250bbc782159cb3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2149645
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
4d10efbc
|
2020-04-15T15:14:11
|
|
Vulkan: Store ImageType in ImageHelper.
We ended up needing this to recover the image type in the RenderTarget.
Otherwise we don't have direct access to this information in the
FramebufferVk sync state code.
Bug: angleproject:4517
Change-Id: I387947e0b7394e1f63f313dd4792bb042b8da73a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2151170
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
8c693ae8
|
2020-04-20T07:01:30
|
|
Roll third_party/vulkan-tools/src 454ab259c1b8..8824107d57d3 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/454ab259c1b8..8824107d57d3
git log 454ab259c1b8..8824107d57d3 --date=short --first-parent --format='%ad %ae %s'
2020-04-17 locke@lunarg.com icd: Set texel size is 32
Created with:
gclient setdep -r third_party/vulkan-tools/src@8824107d57d3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I5b93c96db1e0a2cdd4fbf83bbbda85bf741c3083
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2156119
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
c3080648
|
2020-04-20T07:01:38
|
|
Roll third_party/SwiftShader d25ce8725224..068611f07d28 (8 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/d25ce8725224..068611f07d28
git log d25ce8725224..068611f07d28 --date=short --first-parent --format='%ad %ae %s'
2020-04-17 capn@google.com Fix JIT on separate thread
2020-04-17 bclayton@google.com Use Thread Safety Analysis annotations throughout SwiftShader.
2020-04-17 digit@google.com CMakeLists: Fix Fuchsia build.
2020-04-17 bclayton@google.com Merge changes Ia8226c11,If413b9d6
2020-04-17 bclayton@google.com LLVMReactor: Drop codegenMutex, now thread safe.
2020-04-17 bclayton@google.com LLVMJIT: Remove the TargetMachine cache.
2020-04-17 bclayton@google.com LLVM 7: Set LLVM_ENABLE_THREADS to 1
2020-04-17 bclayton@google.com SpirvShader: Fix ASSERT firing in debugger
Created with:
gclient setdep -r third_party/SwiftShader@068611f07d28
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I186bb705c9af7638abb1e20edb0bc0011de6cc95
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2156120
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
6b265ec1
|
2020-04-20T07:01:30
|
|
Roll third_party/glslang/src 4d2298bfd78a..3f4e5c456306 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4d2298bfd78a..3f4e5c456306
Created with:
gclient setdep -r third_party/glslang/src@3f4e5c456306
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I4e94af432409212f47a17bbd9d2d54126d6f3134
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2156118
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
33b58ebb
|
2019-11-25T16:31:43
|
|
Vulkan: Give unsized arrays at least 1 entry
The function ShaderVariable::getNestedArraySize needs to return at least
1 entry for unsized arrays to ensure the shader buffer sizes are
reported correctly.
This also allows ANGLE to treat unsized arrays of structs and basic
types the same way, allowing for the special treatment of unsized arrays
in TraverseStructArrayVariable() to be removed.
Bug: angleproject:3596
Test: dEQP-GLES31.functional.program_interface_query.shader_storage_block.buffer_data_size.*
Change-Id: I3b2a3a68c25e0913b79e989d7c719b34ce9b75fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1934952
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
2d5da029
|
2020-04-15T17:15:37
|
|
Minor angle_end2end_tests cleanups.
Minor refactoring and call consolidation. Was done while working on
deferring clears in the Vulkan back-end.
Bug: angleproject:4517
Change-Id: I60d80d4f9646c990c4cb8bbc349fc0051389bf02
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2151171
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
dc3477f3
|
2020-03-14T17:22:41
|
|
Separate GLES1's state enum switch code from GLES2+
Some enum values such as GLES1's GL_CLIP_PLANE0 and GLES2+'s
GL_CLIP_DISTANCE0_EXT have the same value.
Thus, the enum switch code has to be separated for GLES1 & GLES2+
Bug: angleproject:4481
Change-Id: I2fcb95f3f75f1fe683a072bee02e797a95686480
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2145284
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
|
|
8c67c079
|
2020-04-16T14:42:15
|
|
Vulkan: store ImageLayout in PackedAttachmentOpsDesc
The layout in the PackedAttachmentOpsDesc only have 5 bits, not enough
for raw VKImageLayout enums. This change will store vk::ImageLayout
which are ANGLE defined and packed for 5 bits and able to handle the
extension bits of VKImageLayout.
Bug: b/153885625
Change-Id: Ida268a974094188d8aeee39c61019eef30a60507
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2153845
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
6cea4405
|
2020-04-17T12:29:07
|
|
Remove more bad files before rolling into AOSP.
third_party/VulkanMemoryAllocator/OWNERS also includes owners that block
uploading.
Move the deletion of the bad files earlier in the script and rm them
instead of git rm. They may or may not be committed git files but rm
always works.
BUG=b/150892231
Change-Id: Iee60fba504ed1c16e994ed1ba83d2b7c58c0a01c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2154537
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
13e4cdb2
|
2020-04-16T14:35:54
|
|
Accept b/ for bug IDs in ANGLE CLs.
Bug: b/151095080
Change-Id: Ic9da14a1476958eb00d4499dacdaa9c529b0626c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152849
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
c090ea78
|
2020-04-17T07:01:30
|
|
Roll third_party/vulkan-loader/src 3682237cb326..50eaecd721a2 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3682237cb326..50eaecd721a2
git log 3682237cb326..50eaecd721a2 --date=short --first-parent --format='%ad %ae %s'
2020-04-16 cwallez@google.com BUILD.gn: Generate libvulkan.so.1 on Linux
Created with:
gclient setdep -r third_party/vulkan-loader/src@50eaecd721a2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: Ib4212a491cc1f1082616d06588c23673f1a4b0e5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2153674
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
94b50338
|
2020-04-17T07:02:12
|
|
Roll third_party/vulkan-headers/src e01f13e1f777..382bf3de06fc (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/e01f13e1f777..382bf3de06fc
git log e01f13e1f777..382bf3de06fc --date=short --first-parent --format='%ad %ae %s'
2020-04-16 rahul@snap.com Export versioned targets for CMake
Created with:
gclient setdep -r third_party/vulkan-headers/src@382bf3de06fc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
TBR=timvp@google.com
Bug: None
Change-Id: I3b713e1072e293f558db7413b7d70b83f8435275
Tbr: timvp@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2154334
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
aa954cc5
|
2020-04-17T07:01:38
|
|
Roll third_party/SwiftShader 2430d665d3f2..d25ce8725224 (18 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/2430d665d3f2..d25ce8725224
git log 2430d665d3f2..d25ce8725224 --date=short --first-parent --format='%ad %ae %s'
2020-04-17 digit@google.com Fix LLVM-based Arm64 build.
2020-04-16 bclayton@google.com CMakeLists: Enabled more clang warnings.
2020-04-16 bclayton@google.com Device/Blitter: Initialize filter3D fields
2020-04-16 digit@google.com Fuchsia: Add LLVM 10.0 configuration headers.
2020-04-16 amaiorano@google.com CMake: fix PowerVR_Examples build
2020-04-16 amaiorano@google.com Don't fail build if Vulkan headers are different
2020-04-16 amaiorano@google.com CMake: fix add_subdirectory(SwiftShader) when CMAKE_BUILD_TYPE is set in parent project
2020-04-16 amaiorano@google.com CMake: make submodule initialization work for add_subdirectory(SwiftShader)
2020-04-16 amaiorano@google.com CMake: fix add_subdirectory(SwiftShader)
2020-04-16 amaiorano@google.com CMake: use directory variables consistently
2020-04-16 amaiorano@google.com CMake: make root compile options and link libraries private
2020-04-16 bclayton@google.com VkSemaphore: Unlock/Lock the mutex outside the blocking_call.
2020-04-16 bclayton@google.com Regres: Include a better error message when git add fails.
2020-04-16 bclayton@google.com Regres: Avoid dereferencing a nil on process timeout.
2020-04-16 bclayton@google.com Make memoryPageSize() functions thread-safe.
2020-04-16 bclayton@google.com Vulkan: Move SpecializationInfo to own file.
2020-04-16 bclayton@google.com Fix chrome autorollers
2020-04-16 bclayton@google.com Reimplement LRUCache, fold away LRUSnapshotCache, add tests.
Created with:
gclient setdep -r third_party/SwiftShader@d25ce8725224
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I2ffd43f61a7258e9bc677ceb99789daea811bdda
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2153675
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
eda526d3
|
2020-04-17T07:01:30
|
|
Roll third_party/vulkan-tools/src 0d4857ea576a..454ab259c1b8 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/0d4857ea576a..454ab259c1b8
git log 0d4857ea576a..454ab259c1b8 --date=short --first-parent --format='%ad %ae %s'
2020-04-16 locke@lunarg.com icd: Image memory size
Created with:
gclient setdep -r third_party/vulkan-tools/src@454ab259c1b8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: Ia25a9e8ad7814f5ed38f3363963664350f4baa47
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2153673
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
f93cc8bd
|
2020-04-16T10:29:16
|
|
Vulkan: Skip failing BlendIntegerTest tests
Several BlendIntegerTest tests are failing due to an update to the
Vulkan Validation Layers that are now checking if formats support
VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BIT and generating an error
if not while pipeline.pColorBlendState.pAttachments[0].blendEnable
is VK_TRUE.
Bug: angleproject:4571
Test: BlendIntegerTest*
Change-Id: Ibbfe415af3d6d6a879a502adb6541a5bfe8cd13a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152947
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
aefa3aa9
|
2020-04-15T14:27:12
|
|
Vulkan: Make staged clears store aspect mask.
This will allow us to store depth- or stencil-only clear when we defer
clears in FramebufferVk syncing. Currently a refactoring change only.
Bug: angleproject:4517
Change-Id: Ifc9bf8f9ebab993509155cf6cf66db5b11f35163
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2151169
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
3fb33ade
|
2020-04-09T15:27:12
|
|
Vulkan: Forward RenderBuffer/Surface dirty messages.
Previously we were only forwarding Texture staging changes to the
Framebuffer for re-sync. We could miss out on clears that were staged
in Surfaces and Renderbuffer attachments. Complete the chain by making
the SurfaceVk and RenderbufferVk forward notifications from the
VkImage.
Bug: angleproject:4517
Change-Id: I15f36c225517e915f656d0c2464a99631ef9f945
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2150699
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
1033d55d
|
2020-04-07T14:01:24
|
|
Pass binding enum to Framebuffer::syncState.
Will allow us to determine if we're clearing the read or draw FBO. Then
we can stash clears for the draw FBO only and issue them immediately
for the read FBO in the Vulkan back-end.
Bug: angleproject:4517
Change-Id: Ifc043317d6156a75749b13f9d2c44a17e14ee378
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139997
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
8116c488
|
2020-04-09T12:18:02
|
|
Remove the merge command from roll_aosp.sh
There are two issues doing the merge in the script:
- This command makes the merge specific to an AOSP branch
- It uses the version of roll_aosp that is from the previous roll
instead of the ToT version.
BUG=b:150892231
Change-Id: I579484092ca3d8c5e0e2d4d4bd1272eaeccc9da3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152667
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
1589de9e
|
2020-04-09T14:08:09
|
|
Remove some bad files when generating an ANGLE roll into Android
Add a list of files that should be removed when rolling ANGLE into
Android. The jsoncpp OWNERS file fails to upload to the Android gerrit
because it contains owners that have never signed into the Android
gerrit.
BUG=b:150892231
Change-Id: I699dada53cdda2fbd012733a7a91eb8b5fb79d35
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152668
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
943c3bc1
|
2020-04-16T11:25:02
|
|
Vulkan: Fix transform feedback on AMD platform
Make sure pCounterBufferOffsets is never a null pointer when
counterBufferCount is greater than zero.
Bug: angleproject:3206
Change-Id: If161473239b53d2a65b1cccaaf1426a4fefd243a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152030
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
005793e4
|
2020-04-09T12:16:20
|
|
Remove --preserve-root from roll_aosp.sh
This flag is not supported on mac and generates errors when trying to
roll.
BUG=b:150892231
Change-Id: I22d10a2b9b37610d409df4d72e0aba2672f7b192
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152666
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
6b705ae7
|
2020-04-09T12:15:48
|
|
Roll VulkanMemoryAllocator into Android
Bug: angleproject:2162
Change-Id: I0b1fc1ba1a3de8c4c00c5f6d26f8451e3ba8627e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152665
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
cbdc14be
|
2020-04-14T16:44:32
|
|
doc: Discuss manual roll in note on Vulkan-Headers repo
Fix the formatting of the note on the Vulkan-Headers auto-roll failing.
Also add information about performing a manual roll when multiple
dependent repos have to be rolled in unison.
Bug: angleproject:1944
Change-Id: I0acee1531f46e8dec67666de5eb18715dc012fe9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2148493
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>
|
|
d113c17a
|
2020-04-16T07:01:30
|
|
Roll third_party/vulkan-tools/src 1be434141625..0d4857ea576a (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/1be434141625..0d4857ea576a
git log 1be434141625..0d4857ea576a --date=short --first-parent --format='%ad %ae %s'
2020-04-15 petr_kraus@email.cz icd: Make VkPhysicalDevice unique
Created with:
gclient setdep -r third_party/vulkan-tools/src@0d4857ea576a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I9652559df93b6e9fa74da16a55bae5edbe94da06
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152353
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
bdd985d3
|
2020-04-16T07:01:38
|
|
Roll third_party/SwiftShader 81e08df29531..2430d665d3f2 (4 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/81e08df29531..2430d665d3f2
git log 81e08df29531..2430d665d3f2 --date=short --first-parent --format='%ad %ae %s'
2020-04-15 amaiorano@google.com CMake: split out turbo-cov target
2020-04-15 amaiorano@google.com CMake: split out test and benchmark targets
2020-04-15 bclayton@google.com VkPipelineCache: Do not publically expose internal mutexes
2020-04-15 bclayton@google.com CMake: Fix build when building with `SWIFTSHADER_ENABLE_VULKAN_DEBUGGER`
Created with:
gclient setdep -r third_party/SwiftShader@2430d665d3f2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I32f760225bb100968b82921889d5838f6d341106
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152357
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
6eb2f118
|
2020-04-16T07:01:30
|
|
Roll third_party/vulkan-loader/src 3f7e3cbf33a7..3682237cb326 (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3f7e3cbf33a7..3682237cb326
git log 3f7e3cbf33a7..3682237cb326 --date=short --first-parent --format='%ad %ae %s'
2020-04-15 charles@lunarg.com tests: fix non-msvc windows test building
Created with:
gclient setdep -r third_party/vulkan-loader/src@3682237cb326
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: Ia126ec6080a64bfb2b98d5cd5765fce2854b378c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152355
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
5f3889a6
|
2020-04-16T07:01:37
|
|
Roll third_party/spirv-tools/src c018fc6ae667..61b7de3c39f0 (2 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c018fc6ae667..61b7de3c39f0
Created with:
gclient setdep -r third_party/spirv-tools/src@61b7de3c39f0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: timvp@google.com
Change-Id: I9bbe69b1e77df3759c904d6248ac11714a86b1f7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152356
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
49ad8eaa
|
2020-04-13T17:55:25
|
|
Enable allowClearForRobustResourceInit for Intel drivers
NVidia drivers have no trouble clearing textures without showing
corruption. AMD ones do.
Intel drivers that have trouble have been relegated to the DX9 runtime
by Chromium.
Bug: angleproject:4460
Change-Id: I9ffbfa041e0f7ef8e05edcc14274bf9530eafae3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2147821
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
|
|
1478ec3c
|
2020-03-18T09:42:37
|
|
Add gles1 primtest tests
Bug: angleproject:2303
Change-Id: Idece2eb2fb291799c9aae811ce63dafdd9333887
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2143029
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
868122c2
|
2020-04-10T13:17:44
|
|
Add 'java_api_finder' to Android.bp
Per the Mainline requirement to setup coverage for APIs used by
modules, we need to add the plugin 'java_api_finder' to ANGLE's
Android.bp to enable the instrumentation.
Bug: b:148987998
Test: Generate Android.bp, verify GoogleANGLE can build in goog/master
Change-Id: Id3d82f18ecb9ff6a57cda4a60f14cd2464dff234
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2145236
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
d5ba916d
|
2020-04-07T17:59:08
|
|
Vulkan: Change to record transform feedback related APIs per spec
Fix not to record vkCmdBindPipeline and vkCmdBindTransformFeedbackBuffers
during transform feedback is active.
Initiated by Hyunchang Kim hckim.kim@samsung.com
https://chromium-review.googlesource.com/c/angle/angle/+/1971953
Pause Transform feedback on binding graphics pipeline and
end of render pass. Set a new dirty bit to indicate transform
feedback may need resume when invalidate graphics pipeline.
Test: dEQP-GLES3.functional.transform_feedback.*
Test: angle_end2end_tests --gtest_filter=TransformFeedbackTest*
Bug: angleproject:3206
Change-Id: I6c70ef461a31dcd618058b167835ac278a21d04a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2139474
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|