kc3-lang/angle

Branch :


Log

Author Commit Date CI Message
e61909f6 2021-05-06 15:12:08 infra: Re-enable swarming tests. Changes since the revert: - Include runtime_deps: http://crrev.com/c/2878093 - Add missing perf scripts: http://crrev.com/c/2877011 - Include build_properties: http://crrev.com/c/2878373 Bug: angleproject:5114 Change-Id: If7d1e5693c4ade72d3f45f5d60635cb27de7599e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877012 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
39ba247d 2021-05-06 18:06:01 Remove redundant OpenCL ICD library Removed redundant OpenCL ICD library, using regular OpenCL library instead. Bug: angleproject:5908 Change-Id: I1ecf5347557106511aed3c5c4a4bfa35590a559a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877240 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: John Plate <jplate@google.com>
abab4739 2021-04-28 12:30:12 capture_gles_1_0: Implement ES1 capture functions. Capture glLight, glLightModel and glMaterial and adjust size by enum. Bug: angleproject:5751 Change-Id: I2fcf35575e344703033bf426c3ed0046dfe93337 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859825 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
cc3e7b5d 2021-04-26 14:26:29 Vulkan: Handle GL_MAP_PERSISTENT_BIT_EXT for external buffer When user specifies GL_MAP_PERSISTENT_BIT_EXT bit for an external buffer but we are unable to import it into a memoryType that supports host visibility, error out with GL_INVALID_OPERATION error. Bug: angleproject:5073 Bug: angleproject:5909 Change-Id: I03e5477266dfb705bfb0a1bce5ca003049ef4c7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862560 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
eb6548bb 2021-05-06 15:12:07 Add missing perf results merger scripts. While waiting for the git mirror to become available we need to clone these scripts into ANGLE. These scripts are required for the merge step to work properly. Bug: angleproject:5114 Change-Id: Ie917149972c8339419b1e3a6d0cf6712fb9888d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877011 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
81f03cc0 2021-04-07 15:23:32 Allow translator to use headers from common/spirv Bug: angleproject:4889 Change-Id: Ia297888a97c0ba9cec1283db7f94f2e5b362c27e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815179 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
08805e35 2021-05-06 15:12:37 Explicitly include "runtime_deps" on Windows. For applications and tests, we need the runtime deps for component builds. It still like this omission was causing test failures on Intel in standalone. Bug: angleproject:5114 Change-Id: Ifd9e90b28f985e4d2d1392a97ecb75907290f5ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2878093 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
fc0c8d18 2021-04-27 16:58:50 Vulkan: Honor mapRangeImpl and unmapImpl abstraction All BufferVk methods need to honor the abstraction provided by mapRangeImpl and unmapImpl. Do not map BufferVk::mBuffer directly, this is needed for when we support device local buffers that cannot be CPU mapped. Bug: angleproject:5909 Change-Id: I520e5cc0994560a3784b8978e349550211dc2cde Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862559 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
cffd5d87 2021-05-06 16:14:15 Roll VK-GL-CTS from 9698f0db4cd5 to dab93ea8f88c (1 revision) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9698f0db4cd5..dab93ea8f88c 2021-05-06 alexander.galazin@arm.com Merge pull request #261 from Joshua-Ashton/mingw-support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ianelliott@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com,angle-bots+autoroll-info@google.com Change-Id: I51fd5c99bf9ae6e0c4542543137c020b8c6cef2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876681 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
c59b9a33 2021-05-05 16:05:06 [Fuchsia] Disable Vulkan validation Vulkan is being updated on Fuchsia. Disable validation to unblock it. Bug: fuchsia:73208 Change-Id: I8a6eecc16ef021d379cfcca8795896a6e6dae11c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876070 Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
dc92d881 2021-05-04 09:56:50 Add warning messages for not (yet) supported CL commands Bug: angleproject:5904 Change-Id: I24e6a4d5cf4cc824751ff45e962bee16489fdbdd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2871450 Commit-Queue: John Plate <jplate@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
1572c372 2021-05-06 09:55:30 infra: Temporarily disable all swarming tests. There seem to be some unusal failures on CI. Maybe Try as well. Bug: angleproject:5114 Change-Id: Ia681d6fdb8575b851dd526c1ab9463ad047735c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875767 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
c75969e1 2021-05-06 13:37:54 Revert "Temporarily remove standalone tester bots from CQ." This reverts commit 8f26346b53d9f818996af8da1421af89cf69caaa. Reason for revert: Should be fixed by updated exclusion spec. Original change's description: > Temporarily remove standalone tester bots from CQ. > > Due to RECIPE CRASH, e.g. > https://ci.chromium.org/ui/p/angle/builders/try/linux-clang-rel/21245/overview > > No-try: true > Bug: angleproject:5114 > Change-Id: I42f76fb370ee5423430955643bffb8c2204fa25f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875717 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: angleproject:5114 Change-Id: I781a5a409a9ede005feaf0f3d7bcedac31eaa036 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876986 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
aa19de17 2021-05-06 09:32:07 infra: Fix exclusion spec JSON. The extra comma caused the CQ to fail reading the file. Bug: angleproject:5114 Change-Id: I5d36f1ae7c4dc5ebcb5599d5cd37471ee4085990 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876985 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
dfe208f1 2021-04-28 18:26:00 Add loader for CL pass-through back end Bug: angleproject:5904 Change-Id: If4960f3150f6bbc85a30f0f6ac5c9e668e6ff756 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2864022 Commit-Queue: John Plate <jplate@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
1f8ba8d3 2021-05-06 09:15:15 Roll VK-GL-CTS from 476acb91ebc2 to 9698f0db4cd5 (14 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/476acb91ebc2..9698f0db4cd5 2021-05-05 alexander.galazin@arm.com Re-apply CL 7106 2021-05-05 siglesias@igalia.com Fix fallthrough compiler warning 2021-05-05 mika.vainola@siru.fi GCC 11 build fixes 2021-04-23 boris.zanin@mobica.com Augment binding tests to test acceleration structure descriptors 2021-04-23 tapani.palli@intel.com Fix to GL 4.5 geometry shading point size tests 2021-04-23 ari.suonpaa@siru.fi Added tests for OES_EGL_image_external 2021-04-23 ari.suonpaa@siru.fi Fix EGL AHB util build issue 2021-04-23 tapani.palli@intel.com Choose linear tiling when dmabuf is used in synchronization tests. 2021-04-23 venni.ihanakangas@siru.fi Update a batch of graphicsfuzz tests to include SPIR-V TARGET_ENV 2021-04-23 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-glk-cts/master 2021-04-22 michal.jakubek@mobica.com Tests for image OpImageWrite on mismatched signedness and type 2021-04-22 piotr.byszewski@mobica.com Fix linking on MacOS 2021-04-21 alexander.galazin@arm.com Update glslang, SPIR-V Tools/Headers 2021-04-19 alexander.galazin@arm.com Update Vulkan headers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ianelliott@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com,angle-bots+autoroll-info@google.com Change-Id: I2d0d8c43add5c8a9bf593353a4a1c9a341fcbbec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876733 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
3ae848ec 2021-05-06 10:01:16 Roll SwiftShader from 484a3e15893c to e839645bb9a6 (5 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/484a3e15893c..e839645bb9a6 2021-05-06 sugoi@google.com Revert "Obtain all sampler parameters through SamplingRoutineCache::Key" 2021-05-05 srisser@google.com Implement depthClamp 2021-05-05 srisser@google.com Implement VK_EXT_depth_clip_enable 2021-05-05 sugoi@google.com Obtain all sampler parameters through SamplingRoutineCache::Key 2021-05-05 sugoi@google.com Obtain ImageView state uniquely from its identifier If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I8d185e83749524e9d2710fc6ecd7a3db9524ea30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875860 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
01b05333 2021-05-04 18:12:25 queryutils: Handle AmbientAndDiffuse param count. Add AmbientAndDiffuse cases for determining light and material parameter count. Define default cases as UNREACHABLE for GetLightModelParameterCount, GetLightParameterCount and GetMaterialParameterCount. Bug: angleproject:5751 Change-Id: I58acb62e66cea71277654313800dafa57c42b17e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2871794 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
c034d045 2021-05-06 10:01:18 Roll vulkan-deps from bc5a26253bb7 to 13d25088cdc6 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/bc5a26253bb7..13d25088cdc6 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/5dcea8a449..039cea5353 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0e7f7a9e10..157c4bfe15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I6f8ee92822ad794f23b922acd71dc83d6462a8e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876737 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
66585b82 2021-05-06 07:40:54 Roll Chromium from 2270e13321c2 to f4228a4b663d (543 revisions) https://chromium.googlesource.com/chromium/src.git/+log/2270e13321c2..f4228a4b663d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/85859d61bc..a5d4757ed0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/069528e565..7359f2c06d * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/adc89c7364..93eae7d9dc * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..5185110bf9 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6b022d1efb..5009fd68ac * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ae0aa94845..9c6e20569c No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: If77a49b5830c9346369e9e179b8a1c20ea6791a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876602 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
69d593b5 2021-05-05 14:21:22 Docs: Update RenderDoc for Android launch command Bug: angleproject:1944 Change-Id: I72535c45ea2a67f2fe6953d4b9fa5e60deaa050b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875164 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
8f26346b 2021-05-05 22:15:34 Temporarily remove standalone tester bots from CQ. Due to RECIPE CRASH, e.g. https://ci.chromium.org/ui/p/angle/builders/try/linux-clang-rel/21245/overview No-try: true Bug: angleproject:5114 Change-Id: I42f76fb370ee5423430955643bffb8c2204fa25f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875717 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
bcf9ffa5 2021-05-05 19:11:04 Revert "Use ANGLE GL for Lacros Chrome" This reverts commit b62f8dd1164a7486646ad9281ffd6f02aa926e1c. Reason for revert: Breaks skia roll. See https://ci.chromium.org/raw/build/logs.chromium.org/skia/535503ce58f24311/+/annotations Original change's description: > Use ANGLE GL for Lacros Chrome > > Currently, no ANGLE platform flag is enabled for Lacros Chrome. > GL is selected as default by this change. > > Bug: chromium:1203176 > Change-Id: I7f810c496dc1806c030e7292a319624d45c33fa1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2851829 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: chromium:1203176 Change-Id: I82b50a9fb57ffb9a6d9112d1a07f3b03775c5bcc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875350 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
0fb204bd 2021-05-05 17:55:37 infra: Exclude infra/specs from analyze. This will force any changes to the infra/specs folder to trigger a full set of tests on a builder. Bug: angleproject:5114 Change-Id: Ie640b52dd7f12163d0c91843d80dbab7f33209d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875356 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
db670c82 2021-05-05 17:12:58 infra: Enable dcheck_always_on in Release. This will assure that ANGLE ASSERT macros work in Release. Bug: angleproject:5114 Change-Id: I0fe6b83592ac3ff3462e55b8a73a11c8f114a4a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875355 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
167480cc 2021-05-05 17:05:55 infra: Switch CI to use component builds everywhere. This makes the build the same as the Chromium-based configuration. This also works around a problem with the Mac bots where the shader cache workaround isn't operational in non-component builds. Bug: angleproject:5114 Bug: angleproject:5928 Change-Id: Ib466942f4a69e1ba3e61e078c84d74d0b54bb396 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875354 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
18c9aa0d 2021-04-29 15:25:32 Run test spec update as part of codegen. Test specs now will be updated when the Chromium build files change. It will be automatically included as part of the Chromium->ANGLE roll. Bug: angleproject:5114 Change-Id: If99c2a20033d417a5999295f425a3bb203f5da3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2860962 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
a16aea95 2021-05-05 14:05:34 Fixes to roll_chromium_deps.py. Includes the new sheriff email alias, and also fixes to the Clang version detection. The new version checks the CopyBara mirror to find the real clang rev ANGLE ends up with. Bug: angleproject:5926 Change-Id: Ie70319feeb5eefbfba8a6b6d2d57110273d6c3e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2872070 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
167a4b6d 2021-05-05 13:42:44 infra: Add Linux isolated scripts to specs. We were missing the perftests and Gold tests from Linux Intel/NV. Bug: angleproject:5114 Change-Id: I1cfc0963b3890c621f0646bb5879e47ea6d336a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2873457 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
e2c87b4f 2021-05-04 11:46:36 Fix Vulkan-only build The translator_gl_d3d_only target cannot build if neither of the gl or d3d backends are built. This target is used by Chrome's validating command decoder only. Bug: angleproject:5922 Change-Id: Ibebae6d6aa78ad88498a727d3b0e1695bb110535 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2871969 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
adc9033b 2021-05-05 02:13:10 Roll Chromium from e9e6d55fed07 to 2270e13321c2 (399 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e9e6d55fed07..2270e13321c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/153efb2bc3..85859d61bc * testing: https://chromium.googlesource.com/chromium/src/testing/+log/db10e8b046..069528e565 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d4ee032a15 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/029279376e..6b022d1efb * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/84ada2da16..dbcffda598 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c08b1fc7ae..ae0aa94845 No update to Clang. No-try: true Bug: chromium:1199451 Tbr: ianelliott@google.com,ynovikov@google.com Change-Id: I307bdafb592fac023dcac181e525f354b1574990 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2873070 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
ab3b50bc 2021-05-03 21:17:14 [infra][realms] upgrade to LUCI security realms in all Angle builds. To be landed after ~1 day at 25% if all is well. Change-Id: I106add7cc9103bde8d77a1c61438ad0fcb54a7b3 Bug: chromium:1204972 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867636 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
fdb376ea 2021-05-03 14:58:09 Vulkan: minimize-gpu-work: Skip blit from offscreen fbo Since we only care about driver state tracking logic, blit is unrelated here. This further reduce the noise of test result. Instead of blit and swap every N frame, we will issue glFlush for offscreen rendering. The onscreen will still issue swap every frame. Bug: b/186881553 Change-Id: Id048eaafa6dcef26d851fd19f069331d240e1bf5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846527 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
3fc83291 2021-04-29 19:03:27 Vulkan: offscreen perftests: use two FBOs and call glFlush every frame For offscreen variant of perf tests, we blit from offscreen to onscreen for every frame and then every N frames we call swap. Right now we never call glFlush. This causes test accumulate many frames rendering without a flush, which changes the behavior. For example, gfxbench does issue glFlush for every frame. This CL adds glFlush call for every frame when swap is not called. Also ARM native GLES driver and ANGLE skip glFlush call if it is issued within the same FBO. For some traces that does not use any FBO, there is no frame boundary for drivers to detect, versus for onscreen there is actual frame boundary. To solve this mismatch problem, this CL also uses two offscreen FBOs and ping pong between them so that it will still have the frame boundary but not goes to screen. This allows drivers that try to detect frame boundary still function properly. Bug: b/184766477 Change-Id: I23edda66fdf391930afd3f6b1d955b41ec6ad019 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2861844 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
b62f8dd1 2021-04-27 06:22:57 Use ANGLE GL for Lacros Chrome Currently, no ANGLE platform flag is enabled for Lacros Chrome. GL is selected as default by this change. Bug: chromium:1203176 Change-Id: I7f810c496dc1806c030e7292a319624d45c33fa1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2851829 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
5d5e4bb9 2021-05-04 10:01:04 Roll vulkan-deps from 4676514cf188 to bc5a26253bb7 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4676514cf188..bc5a26253bb7 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/56b17b2f2d..41e39c615b * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8ec9f456e6..1020e394cb * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/884579ec29..0e7f7a9e10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I32a50e5b5dd8083bb9c3d7d243b425cabe40ceda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2871391 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
99beb97a 2021-05-03 16:54:11 Vulkan: Fix MAX_VERTEX_OUTPUT_COMPONENTS limit gl_Position is excepted from contributing to MAX_VARYING_VECTORS, which is taken into account when calculating this limit based on Vulkan limits (which don't have such an exception). This exception was mistakenly also being applied to other limits such as MAX_VERTEX_OUTPUT_COMPONENTS. Bug: angleproject:5916 Change-Id: I394761efa02d3093741d2bff21023daf997e5e69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2869145 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
9655de62 2021-05-04 08:29:43 Roll Chromium from 34166dd37ed5 to e9e6d55fed07 (345 revisions) https://chromium.googlesource.com/chromium/src.git/+log/34166dd37ed5..e9e6d55fed07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c0a55af977..153efb2bc3 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5da6005cc9..e72cd4587a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cdfd5533e4..db10e8b046 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..785c56fc0f * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f663e54338..029279376e * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e8da4daa81..eb9ce8c993 No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: I0809d05fb2c6331054d3f9167675ecb0154317fb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2871390 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
f45dad5e 2021-05-03 11:05:23 Capture/Replay: Enable test for CopyTextureTestWebGL.NPOT Bug: angleproject:5850 Change-Id: I5a8e3ebf6d220251a76f8a428b959b226dca2ca0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867077 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
39cef942 2021-04-27 08:28:13 Capture/Replay: capture WebGL compatibility With that we can also enable the tests DifferentStencilMasksTest.* Bug: angleproject:5851 Change-Id: If2c992e456716f606320e3992f389823d0af050f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2853584 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
c6fb0e5a 2021-05-03 16:29:17 Roll Chromium from ae499a6ea7cf to 34166dd37ed5 (607 revisions) https://chromium.googlesource.com/chromium/src.git/+log/ae499a6ea7cf..34166dd37ed5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/f105bbfeaa..c0a55af977 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/791177086b..cdfd5533e4 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/a81066b46b..2000d0a880 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a934af8883 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0d1afc9729..f663e54338 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ba668f13d1..84ada2da16 * tools/luci-go: git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155..git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273 * tools/luci-go: git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155..git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273 * tools/luci-go: git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155..git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4dbf0676ae..c08b1fc7ae * tools/skia_goldctl/linux: tB-aCGPgfoZoJkUY-FwC5e0McBlS1VYtKsDpf5G42GUC..qFSgTPN6Qn1vdxIOe4gDnS7rsfvJpQ63e0fEOHdwwK8C * tools/skia_goldctl/mac: 010YBDimThQHTBULjf4bYMXghL37h6xogw08_Ij5RrMC..wEpZZg5Ap8EImS0KyVLAaILjjArMqHjI4T4y2MKKd5MC * tools/skia_goldctl/win: PtSSNrSR0okAf8Q4RMYxK1dSmKxaw9jqoyxdNvNzOqwC..kT3OqAqb0i8bSfls2rf77GfIiw0YSfqm97knAwMxkCcC No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: I6c0a38409309e816102631d755ad5341400a0ff7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867487 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
83a1a385 2021-05-03 12:42:05 infra: Add trybot_analyze_config. This file is used to specify ignores and excludes for analyze. Initially only contains DEPS. Whenever a file in exclusions is changed, we'll run the entire CQ instead of only the affected tests. Bug: angleproject:5114 Change-Id: Ie7328604f5ee56288f992710d5c3dbc559e6d9a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867886 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
dd4564ca 2021-05-03 17:36:28 [infra][realms] bump usage to 25% of all builds. Change-Id: I106add7749103bde8d77a1c61438ad0fcb54a7b3 Bug: chromium:1204972 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867633 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
57202fb0 2021-04-30 13:56:11 Fix Rolling ANGLE into AOSP Rolling ANGLE into AOSP currently generates several build errors. This CL fixes them. Bug: angleproject:5919 Bug: angleproject:5873 Change-Id: Ic24c3c27a2dd3a1db4d6d2e3642eb1b16148569a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2863883 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
05fb2272 2021-04-27 19:31:31 Add support for OpenCL ICD Loader Bug: angleproject:5908 Change-Id: Idafc0d15b69f9a21f2ab5e48c4c34f0dc0e0ee96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854598 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: John Plate <jplate@google.com>
bcae4fe1 2021-05-03 15:07:05 Roll vulkan-deps from c5559fe406e3 to 4676514cf188 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c5559fe406e3..4676514cf188 Changed dependencies: * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7ab4afe505..884579ec29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ianelliott@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com,syoussefi@google.com Change-Id: If43cecb9faae73c1ce83a9b5b4205fda03efd1bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867786 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
03a9bf1e 2021-05-03 17:14:19 [infra] use realms on 5% of Angle builds. All swarming tasks triggered from realm-enabled build will be realm-enabled, too. This CL is safe to revert in case of problems. The problems, if any, should not affect CQ badly due to retries, but on CI they'd probably manifest as purple builds that won't be retried without human involvement or new Git commit. Change-Id: I106a587749103bde8d77a1c61438ad0fcb54a7b3 Bug: chromium:1204972 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867083 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
32ed5069 2021-05-03 17:08:02 infra: init LUCI Realms config for Angle. This doesn't yet have any effect on Angle builds/tasks, but allows to associate Angle pools with the Realms config in https://crrev.com/i/3802849 Change-Id: Id756c14e7e181cc1820cee735668949bf9567d0c Bug: chromium:1204972 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867082 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
de3753d4 2021-05-03 17:05:37 infra: validate configs using lucicfg tool in PRESUBMIT.py This validates that: a) checked in generated files correspond to what lucicfg actually generates; b) lucicfg is formatted c) (same as before) configs are validated against respective LUCI services. Change-Id: I727723beb4172c3dd265c4a4edbc2ecbfb479eb9 Bug: chromium:1204972 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867081 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
471e62c8 2021-05-03 12:23:17 infra: remove redundant ACL. Bug: chromium:1204972 Change-Id: If3ab89699adfc47d0a163f8b999da17b10d86ebd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867079 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
4ab224f7 2021-04-30 15:07:44 infra: Always checkout swarming_client in standalone. This repo is needed to trigger and wait for swarming tests. Bug: angleproject:5114 Change-Id: I02b5da49cb0f12e1189ddf56c8f1b7348bb9bd45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862927 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
23ff18f9 2021-04-30 16:45:04 Roll vulkan-deps from 42d8716d0294 to c5559fe406e3 (24 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/42d8716d0294..c5559fe406e3 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/18eef33bd7..56b17b2f2d * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/c624d5387c..72a2ec4c1b * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/22b82872b4..8ec9f456e6 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/074fa3055c..3f437c4a94 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/d0f1abe22e..5dcea8a449 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/eb3d67bd17..4ee5f2a8be * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f6b4a3dea4..7ab4afe505 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: angleproject:5905 Tbr: jonahr@google.com,ynovikov@google.com Change-Id: I462413910900b8dc38b3e88b78d9ff2e10b103b0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2863562 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
a4588e33 2021-04-29 14:24:20 Vulkan: Disable logMemoryReportStats if driver extension not exist logMemoryReportCallbacks and logMemoryReportCallbacks features are useful for memory debugging. But they rely on VK_EXT_device_memory_report extension. Right now if this extension is not there and you enable the log, you still see the logs but everything is all zero. This CL will disable the feature and print out warning message if the extension is not supported. Bug: None Change-Id: I478ae0ac7ba1ee43245a9fd8a3f1d9907f5d833c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2861310 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Ian Elliott <ianelliott@google.com>
e210287b 2021-04-30 09:56:11 Add tools/perf essential Python files. While waiting for the full mirror we can simply duplicate the minimal necessary files for angle_perftests to run. Test: mb.py zip Bug: angleproject:5114 Change-Id: I1847909cb78b32efed26a284fdfcd40ed31d7b4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862922 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
a7d53cb1 2021-03-30 13:05:43 formatutils: Add 8 unused bits to 24 bit depth formats. Add 8 unused bits to unsized GL_DEPTH_COMPONENT and sized GL_DEPTH_COMPONENT24. This results in the corresponding gl::InternalFormat exposing 4 bytes per pixel and fixes a crash when serializing frame buffer depth attachements in FrameCapture for GLES1 on Vulkan. This patch fixes all comparisions crashing in the capture/replay GLES1 tests on SwiftShader. Bug: angleproject:5799 Change-Id: I39c4309d5c7a1740dfd21c53f116b7e175b64847 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2794381 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
19b7815d 2021-04-27 13:10:36 Angle: drop ANGLE_serialized_context_string from requestable This extension is always needed for replay, and it should always be enabled. By adding the extension using esOnlyExtension it is no longer marked as requestable and WebGL compatibility will no longer disable the extension. Bug: angleproject:5851 Change-Id: I11c8f684b3bfe76c219a9210df0a2c5cccb706f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2853583 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
06567870 2021-04-30 08:20:35 Roll Chromium from 5feb27ec9892 to ae499a6ea7cf (462 revisions) https://chromium.googlesource.com/chromium/src.git/+log/5feb27ec9892..ae499a6ea7cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/32281a3e42..f105bbfeaa * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5dbd89c9d9..5da6005cc9 * buildtools/linux64: git_revision:dba01723a441c358d843a575cb7720d54ddcdf92..git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e * buildtools/mac: git_revision:dba01723a441c358d843a575cb7720d54ddcdf92..git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e * buildtools/win: git_revision:dba01723a441c358d843a575cb7720d54ddcdf92..git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a660a95e6f..791177086b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/09a1a83d2f..adc89c7364 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/db2bba848d..a81066b46b * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ed0183e21a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3a56ba9d9c..0d1afc9729 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/09490503d0..e8da4daa81 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7247aa6f40..4dbf0676ae No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: I444c9cbda115fee32715c430af6a0338832109c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862550 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
257b29ef 2021-04-29 10:58:40 Add instruction on how to debug angle on android This explains how I am using lldbclient.py to debug angle on android. Bug: None Change-Id: I9c0a55ab3e2272fbd74905a7ac390d987c78d550 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2860396 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
54e99d36 2021-04-23 13:02:43 Vulkan: Cleanup garbage when destroying EGL images SurfaceFlinger will optimistically create EGL images just in case it does need them in the future, since creating them can be slow and waiting until they're necessary can cause jank on 90hz+ devices. However, since the images are never actually used, ANGLE's garbage is never cleaned up so vkDestroyImage() and the memory is never freed. This can lead to exhausting the device's memory when many EGL images are allocated. For example, when running the CTS test CtsBiometricsTestCases. This CL adds a call to always cleanup the renderer's garbage when an EGL image is destroyed via eglDestroyImageKHR(), since we can't know if a draw will ever be performed in the future (which would normally cleanup the garbage). Bug: b/184388756 Test: atest CtsBiometricsTestCases Change-Id: I104c05c7be44f1e57123ac7eed23effaa982837a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848131 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jason Macnak <natsu@google.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
ce89d99f 2021-04-29 12:03:30 GL: Flush after framebuffer change on Mac 9th gen Intel GPUs Speculative fix for crashes during flush on Mac. Mirrors the flush_on_framebuffer_change workaround in Chrome from http://crbug.com/783979 Bug: chromium:1181068 Change-Id: Ic84b1bfc44babf27016b306393da308d504d7fd9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859984 Reviewed-by: Peng Huang <penghuang@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
9c66461c 2021-04-29 11:47:16 Suppress VUID-VkImageViewCreateInfo-pNext-01585 temporarily Vulkan validation failures are happening on ComputeShaderTest on Linux and Windows with AMD. Suppress for now while the issue is investigated Bug: angleproject:5912 Change-Id: If89f7c85bb311a68d6cab85e397112b4178e34d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2860044 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
df657c96 2021-04-29 11:22:03 Disable OpenCL support for Windows UWP CI builds Bug: angleproject:5908 Change-Id: I451e232e545248ff9755cc3f2a4907b8af2fdc2c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859742 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: John Plate <jplate@google.com>
a29ab50f 2021-04-29 11:22:03 infra: Add isolate server properties. These are necessary to work correctly with swarming. Bug: angleproject:5114 Change-Id: I634e408e523284a935b77f62b95c9bc85e9e997f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859982 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
a8d98f7a 2021-04-29 11:32:37 infra: Update mixins. The Mac mixins were updated. Ideally we could do this automatically on Chromium rolls. Bug: angleproject:5114 Change-Id: I412e227193e7a6503c04dee5df6bb2a4cf1cc1f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2857597 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
422ec18a 2021-04-26 10:40:04 tests: Move DrawAfterFlushWithNoStateChange to ES3 The test uses Vertex Array Objects, and these are only supported from GLES 3.0 on, or by using the extension OES_vertex_array_object, so make it part of the StateChangeTestES3 set. With that we also enable the test. Bug: angleproject:5855 Change-Id: I0cfb5d23d19e3db8eefffd9d52b744d068666606 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2850642 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
078a2ba6 2021-04-19 11:52:38 Capture/Replay: Print capture and replay exe in verbose mode When running the test script to capture and replay it is helpful to know the locations of the executables that are run to make it simpler to locate them for debugging. Bug: None Change-Id: Ia43bd9863e94058515d9023981863ad6c711285e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2850640 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
1da30524 2021-04-29 10:01:41 Roll SwiftShader from 112faf441539 to 484a3e15893c (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/112faf441539..484a3e15893c 2021-04-28 sugoi@google.com Silence warning for MacOS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com Change-Id: Ic9f3324373ebb26930fce0a70eab176aae09adbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859305 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
201f161b 2021-04-29 07:00:21 Roll Chromium from 06f7f05a5f4a to 5feb27ec9892 (428 revisions) https://chromium.googlesource.com/chromium/src.git/+log/06f7f05a5f4a..5feb27ec9892 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/94367a1d14..32281a3e42 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f6a8e55d6e..5f51521620 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/5f9242e282..a660a95e6f * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/a26b882fc4..09a1a83d2f * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/a27b4d3b82..c3565d6e1f * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d738a9c39a..db2bba848d * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..70ce64f463 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b3c9edb4af..3a56ba9d9c * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/7b4981b650..24e310554f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/91e097a7c7..7247aa6f40 * tools/skia_goldctl/linux: E6CrCAKZ_DKxclAqgBcEt4adU3HaviUwN42S1t3rW5QC..tB-aCGPgfoZoJkUY-FwC5e0McBlS1VYtKsDpf5G42GUC * tools/skia_goldctl/mac: RTGs3s-N45d3AzDXnEKw3kbI0qf8xyS_JYMHo4iRCMIC..010YBDimThQHTBULjf4bYMXghL37h6xogw08_Ij5RrMC * tools/skia_goldctl/win: XXJR8g1yaihqXsw7WodVpgLtZsimS7Cc3yLJI9sJssgC..PtSSNrSR0okAf8Q4RMYxK1dSmKxaw9jqoyxdNvNzOqwC No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: Ic6f6d13e33d9d70ba856b8444a3107a1d00ebdfb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2858285 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
a766ab14 2021-04-20 09:29:29 Vulkan: minimize-gpu-work: Use 1x1 offscreen When minimize-gpu-work is requested, the idea is to have GPU work reduced to minimum. Without shrink the offscreen window to 1x1, the driver load/store op may still have to load entire surface which could be costly. This CL reduces the offscreen surface size to 1x1 when --minimize-gpu-work is specified. Bug: b/184766477 Change-Id: Ic8d9d4c2fe8295a0a5808dcee35120fdd20e0f56 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2840963 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
ccc0fbaa 2021-03-24 17:56:38 Vulkan: Related fixes for buffer descriptor set cache. Includes some stats counter gathering and a few related refactors and cleanups. Also includes a new overlay widget. Bug: angleproject:5736 Change-Id: Ida8d2cd815c5b598c6a442dd9bbfdf51e9c05180 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785431 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
d7859d98 2021-04-28 14:43:16 Remove -raw-cmd from scripts/trigger.py swarming call It looks like this argument doesn't exist anymore. Removing it from the swarming call works fine. Bug: angleproject:5915 Change-Id: I510ef79ae5a540742c3f08c8daa0a14d59d2e60d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2855040 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
53b89b83 2021-04-24 13:26:02 Metal: Add ASTC HDR support ASTC HDR is a superset of ASTC LDR, so always use HDR enums on supported platforms because there is no such difference in OpenGL ES. Bug: angleproject:2634, angleproject:5672 Change-Id: I19a3212bcb949aa9cdeb682ab000aa03125f04a9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848509 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
3b2ef1cd 2021-04-07 20:17:53 Change perf_test_runner to accept extra args. Bug: angleproject:5736 Change-Id: Ic6046c0b8c5ba9bc2f3bffda2c36eaceb24491ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2855601 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
61288549 2021-04-27 17:42:21 Vulkan: Turn on cubemap arrays for Qualcomm The feature works on Pixel 3 and later, so only disable it on Pixel 2. Bug: angleproject:5143 Change-Id: I824fc9ea71cb612fd99e23b7f37a1a3c278d92aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2855218 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
939dc8d9 2021-04-21 18:33:00 Vulkan: minimize-gpu-work: Skip synchronization for glMapBufferRange glMapBufferRange call requires CPU and GPU synchronization. Different drivers implement this differently. Some may choose to keep multiple copies of data to reduce the synchronization overhead while others may choose to wait for GPU access to finish to save memory. While this behavior is important, it should be looked under the scope of overall game performance and we can write a standalone test for this. When --minimize-gpu-work is specified, we mainly care about CPU overhead of driver logic of state tracking. For this purpose, we should get this out of picture in order to expose the true picture of what we intended to see. This CL always adds GL_MAP_UNSYNCHRONIZED_BIT to the access bit to avoid driver to do synchronization or make COW. Bug: b/184766477 Change-Id: I36228a4ed9913e26aa9ad4e8446fb42ee0182c18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2847101 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
7444466c 2021-04-19 18:44:13 Reland "Capture/Replay: Reset GL Fence Sync objects" This is a reland of 9b4fd5456e3cc8c5412af96212d2840b422208b5 This fixes the original CL by moving where setCaptureActive() is called to allow the first replay source file to be written. Original change's description: > Capture/Replay: Reset GL Fence Sync objects > > Asphalt 9 uses GL Fence Sync objects during rendering, which results in > Fence Sync objects being created during setup and deleted while > replaying frames. When the replay is restarted, the Fence Sync objects > that were created during setup and deleted during the replay need to be > recreated during the reset phase. > > Bug: angleproject:5883 > Bug: angleproject:4599 > Change-Id: I118f2b7208c4d512ab646b10f52b3a0936895089 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2838237 > Commit-Queue: Tim Van Patten <timvp@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5883 Bug: angleproject:4599 Bug: angleproject:5900 Change-Id: I5e1d901d8875007691699b7b973f3fb7db027337 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2850758 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
dcfd5526 2021-04-28 07:01:11 Roll Chromium from 398f0c392ac5 to 06f7f05a5f4a (465 revisions) https://chromium.googlesource.com/chromium/src.git/+log/398f0c392ac5..06f7f05a5f4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/6273d81b0c..94367a1d14 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f71816594a..5f9242e282 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/79b2765902..d738a9c39a * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c5554ea0ab * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c91f5f62e2..b3c9edb4af * tools/luci-go: git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155 * tools/luci-go: git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155 * tools/luci-go: git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3e7b3b8ccc..91e097a7c7 * tools/skia_goldctl/linux: bNvl5eveNZJzFEWnXEt_ohXLbBA8BSt78S5aHS7rNYMC..E6CrCAKZ_DKxclAqgBcEt4adU3HaviUwN42S1t3rW5QC * tools/skia_goldctl/mac: jWn1_ogilSNdcmHMkXsZTdw5bQ-IDoQ3IifWt1TDv6sC..RTGs3s-N45d3AzDXnEKw3kbI0qf8xyS_JYMHo4iRCMIC * tools/skia_goldctl/win: dP2sgrA7eRtFoLWGRjvQQ4YXhGlwKqsCiqPqPQuY1OgC..XXJR8g1yaihqXsw7WodVpgLtZsimS7Cc3yLJI9sJssgC No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: I315893b34682bf861573d2d3e6378004b29342af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2856314 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
ed8755df 2021-04-27 21:33:04 Revert "infra: Add different builder group from ci/try." This reverts commit 281b12d2e54cf9526bdb6e2610f8cdc28285f2a9. Reason for revert: Broke bots. Original change's description: > infra: Add different builder group from ci/try. > > Uses the 'client.angle' and 'tryserver.angle' naming scheme that > both V8 and WebRTC use. Necessary for the scripts to work with > swarming tests. > > Bug: angleproject:5114 > Change-Id: I107cf0018e2173117e1d90e840b8e1419e69ef55 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854277 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5114 Change-Id: I2501f3ad89bc21d80ccdeabd52234a1fc5b39a49 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2855594 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
281b12d2 2021-04-27 15:23:02 infra: Add different builder group from ci/try. Uses the 'client.angle' and 'tryserver.angle' naming scheme that both V8 and WebRTC use. Necessary for the scripts to work with swarming tests. Bug: angleproject:5114 Change-Id: I107cf0018e2173117e1d90e840b8e1419e69ef55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854277 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
c02d5f12 2021-04-27 13:45:05 Fix using VK_EXT_provoking_vertex with VVL Vulkan Validation Layers (VVL) automatically rejects and removes any unknown pNext pointer in an pNext chain submitted to the driver. For this purpose, a mechanism was introduced by VVL in order to allow ANGLE to allow some of our custom pNext entries to go through VVL without being removed. This had been used for only 1 of the 3 entries in the VK_EXT_provoking_vertex extension, causing it to be properly exposed, but impossible to use. This CL corrects this by adding the missing entries. Bug: angleproject:5902 Change-Id: If6478b3aa776513b92420736fa1216b014320b02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854815 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Alexis Hétu <sugoi@chromium.org>
6505a768 2021-04-27 10:51:46 infra: Switch Android builders to compile-only. Initially testing will only be on desktop. Bug: angleproject:5114 Change-Id: I384e4f81cee3a810fad42e73711862725e786ef2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854276 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
7b77dc5b 2021-04-22 09:58:33 Vulkan: minimize-gpu-work: Skip data copy when possible When --minimize-gpu-work is specified while replaying app traces, the goal is to avoid any GPU work when possible and focus on driver cpu logic overhead. Data copy can be lengthy and each driver optimize it differently for some real world usage scenario. This should be looked along with normal app trace playback performance. When --minimize-gpu-work is specified, we want to leave this out of picture. Previously I have fixed TexImage2D by overwriting pixel pointer with null. But there is a hole here when PBO is used. This CL fix the case that when data is sourced from PBO, we ensure to skip data copy as well. This CL also noops TexSubImage call instead of doing 1x1 copy. Again depends on driver implementation, some may use CPU others use GPU which will have different overhead. We can easily write a test to cover these performance optimizations. By skipping the subImage call here we will have less noise to deal with for CPU overhead investigation. Bug: b/184766477 Change-Id: I84a5d26d2f25f8f0a6c5c9da72737906d6356a53 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2847100 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
16a919b1 2021-04-27 11:36:11 Add stubs for CL platform layer back ends Bug: angleproject:5904 Change-Id: If23c7f76013a17c3c67c13194566438035beb3d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2853582 Commit-Queue: John Plate <jplate@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
be7049d7 2021-04-20 10:03:33 Vulkan: Redesign buffer descriptor set cache key. Instead of writing the bitset masks, iterate up until the last active buffer. Write zeros instead of skipping spaces. This is a bit simpler to implement and also fixes a bug where empty buffers could cause us to write invalid handles. Bug: angleproject:5736 Change-Id: I785ef18ef5ae45109ec7d6e0b079b79a9984a1f8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2837848 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>
cddb2003 2021-04-23 18:26:51 Stubs for CL validation entry points Bug: angleproject:5775 Change-Id: Ic3b15efdf602bad8f5f170f03ba24b421a398ca8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848504 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: John Plate <jplate@google.com>
e1201106 2021-04-27 14:38:26 Roll vulkan-deps from 68b78a05fea2 to 42d8716d0294 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/68b78a05fea2..42d8716d0294 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/bbcef69a45..c624d5387c * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f3c1d9e78e..d0f1abe22e * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d15a2436f6..f6b4a3dea4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jonahr@google.com,ynovikov@google.com Change-Id: I9e9915f535df93ef0428d63d301225982c29b55c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854414 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
19f24ede 2021-04-26 18:05:31 Disable workderContext on Android Bug: chromium:1202928 Change-Id: I54c4c28c30714fea60b4b6f3dd3ec49101341602 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2851362 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
7c53d6af 2021-04-26 15:20:27 infra: Auto-generate mixins.pyl. The generate_test_spec_json.py file now reads ANGLE's waterfalls.pyl and Chromium's mixins.pyl to find the referenced mixins and copy them into ANGLE's mixins.pyl. This way we can update ANGLE's mixins easily without needing to manually copy them from Chromium's. In a follow-up we could make this run on the Chromium auto-roller. Bug: angleproject:5114 Change-Id: I332b3182732985b261e107dfe9a5c7c413c410a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2849184 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
904ac340 2021-04-26 15:54:25 Bug fix for WaitClient, WaitGL and WaitNative It is valid to call eglWaitClient, eglWaitGL and eglWaitNative when there is no active context in the current thread. Update code to account for that possibility. Bug: angleproject:5898 Test: EGLSyncTest.WaitClient* EGLSyncTest.WaitGL* EGLSyncTest.WaitNative* Change-Id: I81f05a27f1f641cf8986e2e6c05c183ea8471889 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2849587 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
8abb778c 2021-04-27 07:05:49 Roll Chromium from cf8ffbca555e to 398f0c392ac5 (758 revisions) https://chromium.googlesource.com/chromium/src.git/+log/cf8ffbca555e..398f0c392ac5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/eae219f9f1..6273d81b0c * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/2f2a4e507a..f6a8e55d6e * testing: https://chromium.googlesource.com/chromium/src/testing/+log/cbf481cd42..f71816594a * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/e0c163da44..79b2765902 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..00b0b51faf * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/61bf6e8d69..c91f5f62e2 * third_party/r8: h1H8tuKYpnoPW2uwLMSaHgD_vVy9_8E6n4UZ5nwbMRkC..9JovxpDv8ZqFl60_eHo4hT-Ez0CelcMCoM9Cv5UJMz4C * tools/luci-go: git_revision:7ad561e001cdb13c858e065ef0bb3019aae49601..git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f * tools/luci-go: git_revision:7ad561e001cdb13c858e065ef0bb3019aae49601..git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f * tools/luci-go: git_revision:7ad561e001cdb13c858e065ef0bb3019aae49601..git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/65be412188..3e7b3b8ccc * tools/skia_goldctl/linux: wdKjv3Lrszkb_s1AF7ZwLf9Og7Y8qk_EIZ6aoNICu0YC..bNvl5eveNZJzFEWnXEt_ohXLbBA8BSt78S5aHS7rNYMC * tools/skia_goldctl/mac: oMHIiIQ0wBDzq1EgmQYV6nFbvCXgLdD0Qyxv_zFy1OsC..jWn1_ogilSNdcmHMkXsZTdw5bQ-IDoQ3IifWt1TDv6sC * tools/skia_goldctl/win: NA-h9VX5yFfBNYZKxKG479VVjEz3iJQ9jhSXBG0Lk1gC..dP2sgrA7eRtFoLWGRjvQQ4YXhGlwKqsCiqPqPQuY1OgC No update to Clang. Bug: None Tbr: jonahr@google.com Change-Id: Id865d18480e8c8cc40176cd0f734c745c92a5a8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2853275 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
d6a91dab 2021-04-26 10:44:09 D3D11: update docs (remove SSBO limitation). Bug: angleproject:5734 Change-Id: Ia1af247b45ad51072296f8d197dd4b49526417ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2851177 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
cbfa28a0 2021-04-26 14:44:52 Add CQ for main branch Bug: 1203009 Change-Id: I3c7745531cca659901be05f7c7c3c89ba8350096 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2851902 Reviewed-by: Jamie Madill <jmadill@chromium.org>
cd4a63f5 2021-04-26 11:52:02 Vulkan: Fix ASSERT in CreateRenderPass2 RenderPass2 was used for when a depth/stencil attachment is needed, or the VK_EXT_multisampled_render_to_single_sampled extension. The logic that decided this was "has D/S resolve || has MSRTSS extension", but the function itself asserted that the render pass is using MSRTSS if not D/S resolve. This caused an assertion failure on platforms where MSRTSS is present, but a non-MSRTSS render pass is used. Bug: chromium:1201455 Change-Id: Iefd26a071303c703a322d946f82474f85f5bf767 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2849180 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
1bdd34ff 2021-04-26 09:04:59 infra: Add test specs for standalone tests. Includes test specs for Linux/Mac/Win7/Win10. Android is left out for a second pass to keep the changes a bit simpler. Bug: angleproject:5114 Change-Id: I94e7f7f273073f85488ec982e89b4b68f45627ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2805371 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
61167d52 2021-04-24 09:50:31 Add EXT_primitive_bounding_box entry points Addition of the entry points for GL_EXT_primitive_bounding_box extension. Bug: angleproject:5896 Change-Id: I0dce407d2826ce3f730125d7c03f1233420f6780 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2849615 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
84b31c03 2021-04-25 08:30:14 Vulkan: Fix bug in VkImageFormatListCreateInfoKHR On some vendors VVL throws the following error, snippet only - [ VUID-VkImageViewCreateInfo-pNext-01585 ] Validation Error ... image was created with a VkImageFormatListCreateInfo in pNext of vkImageCreateInfo, but none of the formats match the VkImageViewCreateInfo::format ... The Vulkan spec states: If a VkImageFormatListCreateInfo structure was included in the pNext chain of the VkImageCreateInfo structure used when creating image and VkImageFormatListCreateInfo::viewFormatCount is not zero then format must be one of the formats in VkImageFormatListCreateInfo::pViewFormats. It looks like VkImageFormatListCreateInfoKHR::pViewFormats needs to contain all formats including the format of the VkImage itself. Bug: angleproject:5281 Change-Id: I93c6900d99791ef4f9f116cb114f068e0a318bf4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2849566 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
3839fa5b 2021-04-26 13:08:15 Revert "Capture/Replay: Reset GL Fence Sync objects" This reverts commit 9b4fd5456e3cc8c5412af96212d2840b422208b5. Reason for revert: Breaks capture: INFO:root:Passed: 0, Comparison Failed: 0, Crashed: 0, CompileFailed 0, Skipped: 745, Timeout: 0 Bug: angleproject:5900 Original change's description: > Capture/Replay: Reset GL Fence Sync objects > > Asphalt 9 uses GL Fence Sync objects during rendering, which results in > Fence Sync objects being created during setup and deleted while > replaying frames. When the replay is restarted, the Fence Sync objects > that were created during setup and deleted during the replay need to be > recreated during the reset phase. > > Bug: angleproject:5883 > Bug: angleproject:4599 > Change-Id: I118f2b7208c4d512ab646b10f52b3a0936895089 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2838237 > Commit-Queue: Tim Van Patten <timvp@google.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5883 Bug: angleproject:4599 Change-Id: I56c682e1d90dcdde7b18c941aad976825de3af42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2851057 Reviewed-by: Jamie Madill <jmadill@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
a25f21ee 2021-04-25 19:54:32 Tests: Add Candy Crush Soda Saga trace Test: angle_perftests --gtest_filter="*candy_crush_soda_saga*" Tbr: jmadill@google.com,timvp@google.com Bug: b/186362192 Change-Id: I9a1f9663541e3b97d437a1803e8fe079a5dbd2b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846187 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
3182095f 2021-04-23 17:51:23 Tests: Add Higgs Domino Island trace Test: angle_perftests --gtest_filter="*higgs_domino_island*" Tbr: jmadill@google.com,timvp@google.com Bug: b/186267543 Change-Id: Ic7154337724b075bcad1367a24ae7ebeaf65ce6c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848133 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
8df3e5f2 2021-04-23 12:39:06 Metal: update format caps Added MTLGPUFamilyApple6 and MTLGPUFamilyApple7 caps. Bug: angleproject:2634, angleproject:5672 Change-Id: Icc35f823cdd018246a8ac3b1179adc81584fb204 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846832 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>