kc3-lang/angle

Log

Author Commit Date CI Message
angle-autoroll f23d0a75 2021-04-01T07:16:01 Roll Chromium from e4067deef470 to cc20ce29e7a7 (104 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e4067deef470..cc20ce29e7a7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/286eb2bfd3..b962cf8184 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/90497de79f..7cf4a65f3f * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/2c998f1fd7..3cd3442b05 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..da171bf95e No update to Clang. Bug: angleproject:5810 Tbr: jmadill@google.com Change-Id: I35227d93a2c0b08fdd974282491e07b8fc3442cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2799035 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jonah Ryan-Davis e981675a 2021-03-31T21:03:24 Revert "Reland "Add support for Linux GPU info with Vulkan backend"" This reverts commit 9a8397327f9aac278f4bd1f5ab9094eec7e7798b. Reason for revert: Crashes when libpci path fails on some desktop platforms and the fallback path to Vulkan is taken. Original change's description: > Reland "Add support for Linux GPU info with Vulkan backend" > > This is a reland of 5c09c1f882f15e1a77577f1a62d861355aac90a4 > > Extra change: Add new ANGLE_HAS_VULKAN_SYSTEM_INFO compile > variable for GetSystemInfoVulkan() in linux platform. > > Original change's description: > > Add support for Linux GPU info with Vulkan backend > > > > 1. Add support for Linux GPU info with vulkan backend: for > > dev board without PCI support, try vulkan backend to get > > GPU info. > > 2. Fix getVulkanInstance() issue when loading non-exist lib: > > return NULL instance if open lib failed. > > > > Bug: angleproject:5717 > > Change-Id: I03c11da25a8787496d098f6c9d6b4c53701383e4 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2734375 > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > Commit-Queue: Jamie Madill <jmadill@chromium.org> > > Bug: angleproject:5717 > Change-Id: Iaaab8f512b6ec1d524d7ebb3b4252fec3cfe7dc3 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739097 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5717 Bug: chromium:1192586 Change-Id: I04f13fd4bf1d57a3ed510cd3bdf743066de96523 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2798394 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 7a88117f 2021-04-01T00:05:22 Roll Chromium from c181ac047c8b to e4067deef470 (350 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c181ac047c8b..e4067deef470 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5cfbfa7a2f..286eb2bfd3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3f8eac94d9..90497de79f * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/74cb518d98..2c998f1fd7 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..da171bf95e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ddfad9cce3..15a4172c51 * tools/luci-go: git_revision:84c2e8c00bcf3bcea776a4b4a62134921d8a177a..git_revision:34ae8f13bb2156451655ec53b360942a502469df * tools/luci-go: git_revision:84c2e8c00bcf3bcea776a4b4a62134921d8a177a..git_revision:34ae8f13bb2156451655ec53b360942a502469df * tools/luci-go: git_revision:84c2e8c00bcf3bcea776a4b4a62134921d8a177a..git_revision:34ae8f13bb2156451655ec53b360942a502469df * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c41470fd4c..88f0c977ae No update to Clang. Bug: angleproject:4483 Tbr: jmadill@google.com,ynovikov@google.com Change-Id: I1e91b4a1e9053507f153bf61d2e9f2007b1083c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2798593 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Le Hoang Quyen 4ac6ea2a 2020-07-18T21:05:37 Metal: implement ANGLE_device_metal extension. Allow user to query internal MTLDevice used by Metal back-end. Bug: angleproject:2634 Change-Id: I9b0a6eaad8c634069f43e47d5f4f88f61da35f74 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757810 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 3c98bb6a 2021-03-31T21:32:42 Reland "Link angle_util statically into angle_system_info_test" This reverts commit 91b6c3b1a2b12f6c834238ed680d82c3de741cd0. Reason for revert: fixing compilation on android-archive-dbg Original change's description: > Revert "Link angle_util statically into angle_system_info_test" > > This reverts commit 804226dffd9b35f88c4a64672fea2cd29c2bc6e8. > > Reason for revert: breaks compilation on android-archive-dbg. > See https://ci.chromium.org/ui/p/chromium/builders/ci/android-archive-dbg/7802/overview (seems the egl symbols can't be found?) > > Original change's description: > > Link angle_util statically into angle_system_info_test > > > > Otherwise ANativeActivity_onCreate is not found in component build. > > > > Bug: angleproject:4483 > > Change-Id: Ic4a9f66e5b7d150a3740529f866de9995550ea68 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2689370 > > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > TBR=ynovikov@chromium.org,jmadill@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > TBR=ynovikov@chromium.org > Bug: angleproject:4483 > Change-Id: I7f16f77979f7d8b1e5e5f61e48b379b910f3a743 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2697067 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bug: angleproject:4483 Change-Id: I9e6621a2f10041cc8f191d877e48710d977e8237 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2798399 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jonah Ryan-Davis e1ff28d4 2021-03-12T13:35:42 GLX: Always call XSync on creation/destruction of WindowSurfaces ANGLE was checking that it had opened the connection before calling XSync upon initialization. However, clients may pass in a connection and ANGLE must sync after creating a GLXWindow with the connection. This wasn't happening and was causing issues in Chrome. Bug: chromium:1172803 Change-Id: Ieb2cbfaa226f6d066030f42d8e25b1d9c34779f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757507 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 0973dd68 2021-03-31T11:11:26 Add a gl-d3d-only target for the translator Chrome's validating command decoder links statically with the ANGLE translator. This change adds a target that builds the translator with only gl and d3d support for this purpose. This will prevent chrome from linking against glslang because of the Vulkan backend. As a bonus, it will reduce the binary size of Chrome by stipping the Vulkan and Metal translation and transformation codes. Bug: angleproject:5810 Change-Id: I5673bad53817ff2aa8486622ff2c64b44c77240f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2797511 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Charlie Lao fd3b8faf 2021-03-30T11:55:49 Vulkan: Split fragment shader from ColorAttachmentAndAllShadersRead Even though it is not common usage case that the same texture is used as attachment and texture, but aztec ruins is using it. And earlier version of gfxbench's T-Rex also running into this. So performance is still important. This CL splits the texture from fragment shader usage case out so we can have lighter barrier. Bug: angleproject:5780 Change-Id: Ifdcbfe24488fdac62826c5af6ecfbb05f87c0499 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2795269 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 259ead0d 2021-03-30T19:41:33 Enable messenger_lite trace on SwiftShader. For re-tracing. Bug: angleproject:5811 Change-Id: I1b58b33e0641cbd6a6aba10f936b76b5a9eca589 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2797831 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi aac1b494 2021-03-26T21:52:30 Vulkan: Remove spam output regarding pipeline cache The warning regarding pipeline cache not having been found in the blob cache is of little utility. Between emitting it once and not at all, concensus was on the latter. Bug: angleproject:4722 Change-Id: I6d6b2758035e8c5e880b77c5f5be84772cb58a18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2788812 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Chong Gu be52ca8a 2021-03-31T01:52:56 [Fuchsia] Use manifest fragments for Cr-Fuchsia binaries Bug: chromium:1180168 Change-Id: Ie3f2bd6bb79d971549b0422a9f1da7e713a54cc2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2796542 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll aba7b67b 2021-03-31T10:01:46 Roll vulkan-deps from 4b3769b941e6 to 0a4b29c05e71 (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/4b3769b941e6..0a4b29c05e71 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/2c7c84c8ac..6dc24ffa47 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0014e23fbc..4e0a32a456 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ic40769c554d95ca04319de3a4a1774350c4582c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2796543 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f1a60745 2021-03-31T07:00:02 Roll Chromium from 8599134e632f to c181ac047c8b (466 revisions) https://chromium.googlesource.com/chromium/src.git/+log/8599134e632f..c181ac047c8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8d5bcfe61d..5cfbfa7a2f * buildtools/linux64: git_revision:b2e3d8622c1ce1bd853c7a11f62a739946669cdd..git_revision:5667cc61018864b17542e0baff8b790f245583b0 * buildtools/mac: git_revision:b2e3d8622c1ce1bd853c7a11f62a739946669cdd..git_revision:5667cc61018864b17542e0baff8b790f245583b0 * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/cbf9455e83..77b3c6ba9b * buildtools/win: git_revision:b2e3d8622c1ce1bd853c7a11f62a739946669cdd..git_revision:5667cc61018864b17542e0baff8b790f245583b0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/901c2aa8dc..3f8eac94d9 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1178627278 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3bf4cc37a8..ddfad9cce3 * tools/luci-go: git_revision:62439191b003e76fb15094bd142ba9b80387ba85..git_revision:84c2e8c00bcf3bcea776a4b4a62134921d8a177a * tools/luci-go: git_revision:62439191b003e76fb15094bd142ba9b80387ba85..git_revision:84c2e8c00bcf3bcea776a4b4a62134921d8a177a * tools/luci-go: git_revision:62439191b003e76fb15094bd142ba9b80387ba85..git_revision:84c2e8c00bcf3bcea776a4b4a62134921d8a177a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/fd8d4ca066..c41470fd4c No update to Clang. Bug: angleproject:4483 Tbr: jmadill@google.com Change-Id: I0c78e583299b63690d410f1cdb904306e4e47196 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2796538 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten ae937aae 2021-03-19T20:10:42 Detach separable shaders This effectively reverts the following CL: Vulkan: Don't detach separable shaders in Program::detachShader() https://chromium-review.googlesource.com/c/angle/angle/+/2084399 Bug: angleproject:3570 Bug: b/182409935 Test: ProgramPipelineTest31.DetachAndModifyShader Change-Id: Id69f732d1d4f3eea70b2de8c008452878eaf1682 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776267 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tim Van Patten fe3a9ffb 2021-03-17T18:05:40 Support linking PPOs without attached Shaders The application "Command & Conquer: Rivals" uses the following pattern: // Create and link VS, save binary data glCreateProgram() glAttachShader() glLinkProgram() glGetProgramBinary() // Create and link FS, save binary data glCreateProgram() glAttachShader() glLinkProgram() glGetProgramBinary() ... // Create VS, load binary data glCreateProgram() glProgramBinary() // Create FS, load binary data glCreateProgram() glProgramBinary() ... glUseProgramStages(GL_VERTEX_SHADER_BIT) glUseProgramStages(GL_FRAGMENT_SHADER_BIT) glBindProgramPipeline() Later, when issuing the draw command that uses the PPO, the PPO must be linked with the Programs that were loaded via binary data. Those Programs don't have any Shaders attached, just linked. This CL adds support for linking Programs without attached Shaders. Bug: b/182409935 Test: ProgramPipelineTest31.ProgramBinary Change-Id: Ic5a4776e1374322665f45fbbcbf955838d093d02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770685 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 86a86a7d 2021-03-30T11:57:44 Vulkan: Temporarily use GOOGLEX instead of EXT for MSRTSS Until the driver implementation completes, use a different name for the unreleased extension (tagged with GOOGLEX instead of EXT). Bug: chromium:1088005 Change-Id: I0b948c9c82825681ab130ae3dd91026ea6cb57cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2795041 Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Rafael Cintron 416eb8a3 2021-03-25T13:27:33 Check return value of allocateResource instead of asserting allocateResource can fail if the device has been removed or there is no more video memory. Hence, the return value needs to checked for errors instead of simply asserting that the result doesn't equal angle::Result::Stop. Bug: chromium:1192771 Change-Id: I794f288f16917ef50e45f6f3ab60ee3ebc5941d9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2787249 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Tim Van Patten e3b9dbef 2021-03-17T18:01:02 Update PPO's executable when attached program is re-linked When a program that's being used by a PPO is successfully re-linked, the PPO's ProgramExecutable needs to be updated. This takes advantage of the subject/observer pattern that's already established between programs and PPOs to ensure only the PPOs that the program is a part of are updated. Bug: b/182409935 Test: ProgramPipelineTest31.ModifyAndRelinkShader Change-Id: Idcc11e7e819b4a9bef02bdd71afc8ea58111acc6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770684 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 00d872d0 2021-03-30T16:08:00 Replace Win x86 dEQP GPU.FYI bot with chromium.angle bot Bug: angleproject:4483 Change-Id: Ibc240cc239f3c769df300b8bd07b0ca6687e943b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2795165 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 13957182 2021-03-30T10:02:48 Roll vulkan-deps from e0d8a486f6d5 to 4b3769b941e6 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/e0d8a486f6d5..4b3769b941e6 Changed dependencies: * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/5180defc01..7ea01c139f * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/1d3ce716df..f07dcebf17 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0cee3a4e50..0014e23fbc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: Ibe7485db741df4d8d8f3ab90ca274344e183433d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2793733 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 9a81af9a 2021-03-30T10:01:01 Roll SwiftShader from fb53aa2bb7da to 4c0f888d7ef8 (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/fb53aa2bb7da..4c0f888d7ef8 2021-03-29 capn@google.com Automate installing the API library for testing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I0840ae40479a46a18ad8a34a23ca91bcad8d852b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2794130 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f9cff914 2021-03-30T08:26:01 Roll Chromium from 26bf9bb622f1 to 8599134e632f (396 revisions) https://chromium.googlesource.com/chromium/src.git/+log/26bf9bb622f1..8599134e632f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c835251514..8d5bcfe61d * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/99a2527e91..5dbd89c9d9 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/d292cb9ff0..901c2aa8dc * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c8248182db * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fc39a84984..3bf4cc37a8 * tools/luci-go: git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b..git_revision:62439191b003e76fb15094bd142ba9b80387ba85 * tools/luci-go: git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b..git_revision:62439191b003e76fb15094bd142ba9b80387ba85 * tools/luci-go: git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b..git_revision:62439191b003e76fb15094bd142ba9b80387ba85 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7bd470ee98..fd8d4ca066 * tools/skia_goldctl/linux: siMs1o8b-ON1wWPwvSA4NKhGMBXPWhkMQ3HHr7-yDqQC..0ov3TUTdHjrpXdmomZUYhtozjUPAOWj5pFnLb_wSN3cC * tools/skia_goldctl/mac: 77UQ9Zx-irz8MxBwN3CtYielGQtPthCIaWzlOONC8_MC..4WMws6v5khG2LeD4ZoItrfEnqBtVRK9Y-f6bMccgS8wC * tools/skia_goldctl/win: rLRz9NhcZkVWiGMr_kp9C1L_1QOynKyxdh-eu6REt4MC..zp5Z6O5rpqU_hMlh5I1ScNM4EDY8nMpwX0uaMUAVPxcC No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: I7346d0403b1d33cf68e9bb6ee565f251d089aebd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2794101 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Tim Van Patten 0af8cfa7 2021-03-17T17:43:03 Reland "Save/Load missing members" This is a reland of b2e76cf58fc012b068aab4716a432bb8951e93e3 Always call saveLinkedStateInfo() so we fill in the necessary values with valid data for monolithic programs also. Original change's description: > Save/Load missing members > > There are several class/struct members that are missing when a program > is serialized/deserialized. This leads to errors when attempting to link > programs that have been deserialized. For example, when drawing with a > PPO that contains programs which were created with glProgramBinary(). > > This CL adds saving/loading the missing members. > > Bug: b/182409935 > Change-Id: I637c6cd8c174acd6da8d51433893323a32e5d7c0 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770683 > Commit-Queue: Tim Van Patten <timvp@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Cody Northrop <cnorthrop@google.com> Bug: b/182409935 Bug: angleproject:5793 Change-Id: I07ca8f5dfed8c0a9eac3a0defb1602d2ba021c5f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2782189 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi 3e887665 2021-03-29T12:17:27 Don't link with SPIR-V repos if !vulkan && !metal Bug: angleproject:5803 Change-Id: Ic2c940a725886dcd7ca46f99975251f7fef38757 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2791922 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Gert Wollny cee0bfd6 2021-03-15T14:39:30 Capture/Replay: serialize context to JSON Bug: angleproject:5715 Change-Id: Ibc6897d7567fedab4a2ba7bf8d2bd5a7e496bd4b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2760325 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny d00bd105 2021-03-15T11:13:34 Capture/Replay: Enable GetTexImage tests Bug: angleproject:5646 Change-Id: Ic3ffc08edb2504b3f5cf6913e3995f8da8b7a94a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2791443 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Gert Wollny b88fade2 2021-02-23T22:10:55 capture/replay: impl CaptureGetRenderbufferImageANGLE_pixels Bug: angleproject:5646 Change-Id: I378a72dc944f8b8ef3d61a724eedecdbb725ee2e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2718173 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Peng Huang f16fd9ea 2021-03-25T21:33:31 Only enable framebufferMultisample with framebufferBlitANGLE Based on [1], GL_ANGLE_framebuffer_multisample requires GL_ANGLE_framebuffer_blit, so only enable framebufferMultisample with framebufferBlitANGLE. [1] https://www.khronos.org/registry/OpenGL/extensions/ANGLE/ANGLE_framebuffer_multisample.txt Bug: chromium:1192060 Change-Id: I44e8310d5a94578c0bb7e1d30a7276657965366c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785394 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Gert Wollny 37d9a2f4 2021-02-23T21:08:01 capture/replay: implement CaptureGetTexImageANGLE_pixels Bug: angleproject:5646 Change-Id: Ia4ae0fc76eae4f9c8c133b0501eb792e794c4cfc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2718172 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll c234a36a 2021-03-29T10:01:33 Roll vulkan-deps from 7079d8df17da to e0d8a486f6d5 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/7079d8df17da..e0d8a486f6d5 Changed dependencies: * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/84d1f8aa2a..d2e1e7ba98 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f227930153..61e256c9c4 * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/a8d6ab19d1..e1d8c4931d * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5c65b37c60..0cee3a4e50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I5a1d5d22edc2476d0d6d4a1227c932fcbcb015f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2790802 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 25c3c624 2021-03-29T07:01:11 Roll Chromium from e0abc3035c46 to 26bf9bb622f1 (218 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e0abc3035c46..26bf9bb622f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/5b847b7f2c..c835251514 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/69cc9b8a3a..99a2527e91 * buildtools/linux64: git_revision:64b3b9401c1c3ed5f3c43c1cac00b91f83597ab8..git_revision:b2e3d8622c1ce1bd853c7a11f62a739946669cdd * buildtools/mac: git_revision:64b3b9401c1c3ed5f3c43c1cac00b91f83597ab8..git_revision:b2e3d8622c1ce1bd853c7a11f62a739946669cdd * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/9bb07683fb..cbf9455e83 * buildtools/win: git_revision:64b3b9401c1c3ed5f3c43c1cac00b91f83597ab8..git_revision:b2e3d8622c1ce1bd853c7a11f62a739946669cdd * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e50b540620..d292cb9ff0 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..36e45025a8 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/fc72712d33..7bd470ee98 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ib7b307248aa05136075be4cc0bdb401ab3d974af Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2790801 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Jamie Madill 9a025fd4 2021-03-13T22:48:13 Capture/Replay: add frontend feature to force capture limits Some of the limits set when FrameCapture is enabled are reflected in the serialized context. In order for capture/replay tests to pass these limits may also be needed to be enforced when replaying. Add a fronten feature enable_capture_limits for this and use it in the capture replay test script. Patch authored by gert.wollny@collabora.com. Bug: angleproject:5750 Change-Id: I3d333d22fe65c12dd5aa5f263d19a2c1568541c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2790301 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Gert Wollny e0b9d4f7 2021-03-15T11:25:39 libAngle: Add Json context serializer library Bug: angleproject:5715 Change-Id: I42319fe30e42d49d7e817b14c211b5ba82a94a42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2760324 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki 51886f57 2021-03-17T12:41:10 context: Remove endl, since INFO already adds them. Removes redundant std::endl. Bug: angleproject:5751 Change-Id: Ia7e0d7c4550c2565a3787d433ea245db95856b30 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773291 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Lubosz Sarnecki 8d110222 2021-03-05T18:13:40 capture_replay_expectations: Don't skip passing. Several tests now pass the comparision and do not need to be skipped. Replace the wildcard with specific tests if only one test is failing. Bug: angleproject:5721 Change-Id: I70172965d6e0df9d2c3ac43c391c377f7da12a6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739727 Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 92fb500a 2021-03-26T10:39:27 Roll SwiftShader from 8969f861fc24 to fb53aa2bb7da (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/8969f861fc24..fb53aa2bb7da 2021-03-26 swiftshader.regress@gmail.com Regres: Update test lists @ d4550ab8 2021-03-25 jmadill@chromium.org Increase render target limit to 8. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I0aa28da019817b9b44d2a3ccc3138e540ad09a92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2788116 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki 8114ca19 2021-03-09T15:50:22 capture_gles_3_2: Set read buffer for glGetPointerv. As required by the GLES1 VertexPointerTest. Bug: angleproject:5751 Change-Id: I889d136a2f76b0b9c256ffc9176c08a8c2b03a08 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2756534 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
angle-autoroll 4f626f72 2021-03-26T10:01:33 Roll vulkan-deps from 3f4383f1d450 to 7079d8df17da (2 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/3f4383f1d450..7079d8df17da Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ecc840d30b..f227930153 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b1a10a4bc6..5c65b37c60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ia6d2d62523d482f69a5b5ebfa2c4d3677d6d5b69 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2786168 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll d41cec67 2021-03-26T07:01:25 Roll Chromium from 7a30f2f0e630 to e0abc3035c46 (431 revisions) https://chromium.googlesource.com/chromium/src.git/+log/7a30f2f0e630..e0abc3035c46 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/7b935ebade..5b847b7f2c * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f50df92a29..9bb07683fb * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3977fbe3b4..e50b540620 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..36e45025a8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a2d934b248..fc39a84984 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f5499b6afa..fc72712d33 No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: Ie0442b56785f1b203ce86ad8a78f181206e8c0ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2786167 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Lubosz Sarnecki 58502aa5 2021-03-04T20:31:31 capture_gles_1_0: Implement capture functions. Implement various capture functions as required by the GLES1 tests and GLES1 applications like Dr. Driving. Implements glMultMatrixf, glTexEnvxv, glLightxv, glLoadMatrixf and glGetFixedv. Bug: angleproject:5751 Change-Id: Id22899d755a9126f91b37eeea4619d6a03636f8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2756533 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Yuly Novikov 67232387 2021-03-25T16:04:07 Remove old Win x86 bots from CQ win-angle-chromium-x86-try + win-angle-x86-try replace win-angle-rel-32 + win-angle-deqp-rel-32 Bug: angleproject:4483 Change-Id: If2c6d13937d61793f8b1845dc4aec83cae43d3b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2787197 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Shahbaz Youssefi 776c6015 2021-02-26T00:00:57 Vulkan: Call glslang at compile time With this change, the ANGLE translator immediately compiles the generated GLSL into SPIR-V with glslang and discards the source. This is in preparation for generating SPIR-V directly, by making the frontend and backend already able to digest it. This change also allows the expensive glslang calls to be parallelized, improving the following perf test by about 20%: LinkProgramBenchmark.Run/vulkan_compile_and_link_multi_thread Previously, the test was run as such in the Vulkan backend: Main Thread 1 Thread 2 Compile1 ---> Compile2 ---------------------> Translator Translator <--- <--------------------- Link glslang for shader1 glslang for shader2 Done With this change, it is run as such: Main Thread 1 Thread 2 Compile1 ---> Compile2 ---------------------> Translator Translator glslang glslang <--- <--------------------- Link Done glslang_wrapper_utils no longer interacts with glslang! A rename will follow. Bug: angleproject:4889 Change-Id: If4303e8ba0ba43b1a2f47f8c0a9133d0bee1a19a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2721195 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill eac2397b 2021-03-25T13:36:50 Trace Tests: Work around autoninja.bat change on Win. A breaking change to autoninja.bat was causing the script to fail to find 'python3.bat' in this configuration. Work around the issue by instead invoking 'ninja.exe' directly with the correct '-j' argument. Bug: angleproject:5766 Change-Id: Ie01d7e8c4caf80661f420ccfc55a8d951a4e1b4f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2787186 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Mohan Maiya f28d63e9 2021-03-24T11:14:24 Vulkan: Enable glBlitFramebuffer for EXT_sRGB_write_control Implements support for the glBlitFramebuffer edge case in the EXT_sRGB_write_control spec, and fully exposes this extension. Bug: angleproject:5075 Test: SRGBFramebufferTest*.*Vulkan* Change-Id: I05f044abbc5cb272825d1fc4b9028217f18e63c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785641 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
angle-autoroll 5dad9d8a 2021-03-25T10:01:33 Roll vulkan-deps from 91a2a0b15f23 to 3f4383f1d450 (26 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/91a2a0b15f23..3f4383f1d450 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/979319b9b1..2c7c84c8ac * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a732e4c03c..ecc840d30b * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/89d366355e..a8d6ab19d1 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/1353e80d87..5180defc01 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/27c2124822..1d3ce716df * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/309d9bea09..b1a10a4bc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I730b4b918d2b2ca94a96caf4df7986be09d2fe8c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2786594 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll b1896811 2021-03-25T10:01:28 Roll SwiftShader from a98fb3f8380a to 8969f861fc24 (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/a98fb3f8380a..8969f861fc24 2021-03-25 swiftshader.regress@gmail.com Regres: Update test lists @ 2eed61ff 2021-03-24 capn@google.com Ensure compressed image copy is height compliant If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ie6157852af2cb1cccc412e30fd6d3b64aa8b0104 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785477 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 12bdb7f0 2021-03-25T07:00:39 Roll Chromium from bda1e3894abc to 7a30f2f0e630 (468 revisions) https://chromium.googlesource.com/chromium/src.git/+log/bda1e3894abc..7a30f2f0e630 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cb055e229d..7b935ebade * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/731dd85349..f50df92a29 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/ada28b558f..3977fbe3b4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..36e45025a8 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/24cecabb89..a2d934b248 * tools/luci-go: git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b * tools/luci-go: git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b * tools/luci-go: git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/772ad67f2e..f5499b6afa No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: I7b8471ce869387cd4d6708717b990238cc303d8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785254 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuly Novikov 3d6cedb1 2021-03-24T18:29:02 Leave Android devices in portrait orientation after test EGLPreRotationSurfaceTest.ChangeRotationWithDraw alternates between landscape and portrait orientations. The last one needs to be portrait, since this is the default state that other tests expect. Since changing orientation takes 1 second, it's more efficient to do it in this one place instead of before every test. Bug: angleproject:5781 Change-Id: I63c2eeb77663ea7de6679385c9deb089b16e74f3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785433 Reviewed-by: Ian Elliott <ianelliott@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Charlie Lao 9a79ee78 2021-03-22T17:56:28 Vulkan: Add A few other *-None-04584 VVL error to skip list If app uses textureLoad to fetch a texture level and mean time renders to the same texture but with different level, this will generate vulkan validation errors. Previously we are only skipping VUID-vkCmdDraw-None-04584, but it is necessary to skip all other-04584 VVL error that stem from other draw calls as well. Aztec ruins can run into VUID-vkCmdDrawIndexed-None-04584 on QComm GPU, for example. Bug: b/175584609 Change-Id: I2da6945415975350e36f533f007ae1e2a5feddfd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780563 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Stephen White ac8e1196 2021-03-20T11:29:50 SSBO handling rewrite. The basic idea is to replace the current SSBO output traversal by build a new AST for the Load and Store subtrees, then traverse that AST with the regular OutputHLSL traversal. This way, all the paren balancing and state management can go away. BUG: angleproject:5734 Change-Id: I14d2fecd724d7419fbc9315fad4e9202a741b03f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773401 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Doug Horn 525fde75 2021-03-22T14:55:21 Fix potential mod by 0 with invalid formats. If the format passed to MakeValidSize is invalid, there is potential for a mod by 0 which can result in a crash. Test: Verify no crash when format is invalid. Bug: b/182823289 Change-Id: I7f538be5d984070984f5581a5cc7ea47264109f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780557 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Doug Horn <doughorn@google.com>
Jamie Madill 010d61f2 2021-03-24T13:08:38 Disable Framebuffer Fetch test. See issue for more details. Bug: angleproject:5792 Change-Id: I7a72dfe75a85f2bf69e3528f35c01ca69c67f8f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785420 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Mohan Maiya dd5705e7 2021-03-24T08:18:24 Add missing qualifier type handling in translator Translator checks tessellation shader unsized array type qualifier. sample in/sample out were missing in handling qualifier type. Bug: angleproject:5557 Test: GLSLTest_ES31.VaryingTessellationSampleInAndOut* Change-Id: I8a2f2c4c4fcc9cc88000d3b2d448ab51fb9e5d38 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776263 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Cody Northrop 775caee1 2021-03-24T08:42:54 Scripts: Ignore robin_hood headers in VVL Needed to unblock vulkan-deps roll. Example bad roll: https://chromium-review.googlesource.com/c/angle/angle/+/2784701 Fallout from upstream changes: https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/2639 TBR: jmadill@google.com Bug: angleproject:5791 Change-Id: Idf4a0f6b4a7ef04e48d84110cd9d30887ebff9cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2784712 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 0c9f22d3 2021-03-24T07:01:56 Roll Chromium from f1617b736428 to bda1e3894abc (469 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f1617b736428..bda1e3894abc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b43166a3d1..cb055e229d * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/4e078437d0..731dd85349 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a9cb74b2b5..ada28b558f * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..25699ba498 * tools/luci-go: git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e..git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2 * tools/luci-go: git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e..git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2 * tools/luci-go: git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e..git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c94714a14b..772ad67f2e * tools/skia_goldctl/linux: PgXVrZeDk45E9Zzaj8KYvPhJb728_zgB29afUe44XnUC..siMs1o8b-ON1wWPwvSA4NKhGMBXPWhkMQ3HHr7-yDqQC * tools/skia_goldctl/mac: rhgkxpA8BkPWwXXCTUidbcE5xtFpN2UVjTfya2r4YJAC..77UQ9Zx-irz8MxBwN3CtYielGQtPthCIaWzlOONC8_MC * tools/skia_goldctl/win: bMHjBq4De--lL7_Tr4K31mN6LR7hkSStHG_W34ogifYC..rLRz9NhcZkVWiGMr_kp9C1L_1QOynKyxdh-eu6REt4MC No update to Clang. Bug: None Tbr: cnorthrop@google.com Change-Id: If48fd51ba96e71909d3be086667bfc73fdd32a0c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2782377 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Amy Liu 1fb7f648 2021-03-18T16:17:25 Compression of the data from vkGetPipelineCacheData. The size of pipelineCacheData sometimes is greater than 64k which cannot be saved because of the Android blob cache limitation (single cache data size should be < 64k). Implement the compression to store more cache data. Re-land this patch before fixing the performance regression of big pipeline cache. Bug: angleproject:4722 Change-Id: I4bc05a88334c3e7e9e945d1a0877429db1750422 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2771840 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Xiaoxuan Liu 9f796506 2021-03-23T10:58:12 Vulkan: Fix gl_SamplePosition XY-flip and rotation. In multi sample scenario, gl_SamplePosition is not handled with XY-flip and rotation, add codes for flip and rotation. Bug: angleproject:5637 Test: dEQP-GLES31.functional.shaders.multisample_interpolation. interpolate_at_offset.at_sample_position.default_framebuffer --deqp-gl-config-name=rgba8888d24s8ms4 Test: dEQP-GLES31.functional.shaders.sample_variables.sample_pos. correctness.default_framebuffer --deqp-gl-config-name=rgba8888d24s8ms4 Change-Id: I7ba2227e85c62d2ca7bf534a841a1c3a5c9beb5e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2781124 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Mohan Maiya <m.maiya@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
David Reveman 3fd439c2 2021-03-23T21:40:11 [Fuchsia] Add ifndefs to vulkan_fuchsia_ext.h This allows chromium to build with upstream headers that include these extension. The old TEMP enums and structure types are used until drivers have been updated to support upstream header values. Bug: chromium:1191605 Change-Id: I25d2991204ca34956298013138af8f48e0aaefaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2782765 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi d1462228 2021-03-09T11:25:36 Vulkan: Use VK_EXT_multisampled_render_to_single_sampled Additionally, makes the emulation path not require independentResolveNone. This was only used to select the NONE resolve mode when the attachment format doesn't have either of depth or stencil aspects, but it's ok to specify the same resolve mode for both aspects even if one aspect is missing. Bug: chromium:1088005 Change-Id: Ifc37cbf5331145179c5927853b996a0d62b871ee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743666 Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Ian Elliott c4da42e1 2021-03-22T12:29:34 Update ANGLEWrangling.md with Hotlist-Wrangler Bug: angleproject:5782 Change-Id: I6f808e6ece97dbc0166ba8f60b0cc31e783165a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779393 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Rafael Cintron d809147f 2021-03-22T18:00:00 Enable D3D11 debug names in ANGLE release builds Previously, D3D11 debug names were only output in debug builds. This change enables them in release builds so we can debug GPU memory consumption given traces or full memory dumps. Where it made sense, existing names were shortened for brevity. A future CL can shorten the names further by removing the words texture, SRV, DSV, etc since D3D already outputs this type information. Bug: chromium:1164111 Change-Id: Iadd6222c29dd945115e844ec28ee395ce16c139f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780564 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Peng Huang 90e3d86c 2021-03-22T12:49:26 Disable timestamp queries for Mali-G31 and older GPUs Bug: chromium:1178333 Change-Id: I8f21cd1c8f815a5cd7344778d2d1b28710dc6763 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779211 Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
Jamie Madill 2a43f43a 2021-03-23T15:35:30 Revert "Save/Load missing members" This reverts commit b2e76cf58fc012b068aab4716a432bb8951e93e3. Reason for revert: Causing MSan failures on Linux. See bug. Bug: chromium:1191344 Original change's description: > Save/Load missing members > > There are several class/struct members that are missing when a program > is serialized/deserialized. This leads to errors when attempting to link > programs that have been deserialized. For example, when drawing with a > PPO that contains programs which were created with glProgramBinary(). > > This CL adds saving/loading the missing members. > > Bug: b/182409935 > Change-Id: I637c6cd8c174acd6da8d51433893323a32e5d7c0 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770683 > Commit-Queue: Tim Van Patten <timvp@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Cody Northrop <cnorthrop@google.com> Bug: b/182409935 Change-Id: I1209257ed6bb55ba2d01d92bd3305d5e3ad6ee28 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780015 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill 572fd801 2021-03-22T16:14:34 Vulkan: Rename Uniforms/XFB descriptor desc. The new name is more consistent with the other names. Refactoring change only. Bug: angleproject:5736 Change-Id: Idc47fef29040e3a422267795c4536163a6f8eb4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779953 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
angle-autoroll e6ca472b 2021-03-23T07:01:03 Roll Chromium from 3eced2421f5a to f1617b736428 (473 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3eced2421f5a..f1617b736428 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/120a8d610c..b43166a3d1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f13f2e366c..a9cb74b2b5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..de74236cf7 * tools/luci-go: git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb..git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e * tools/luci-go: git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb..git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e * tools/luci-go: git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb..git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e * tools/skia_goldctl/linux: PFAC9ipfkYe6ZljRb8758leyPy7Jw6Dhl2dtHp0IsMYC..PgXVrZeDk45E9Zzaj8KYvPhJb728_zgB29afUe44XnUC * tools/skia_goldctl/mac: Ht0L_bool7JJxm1K8Y4MzgKRlPhoIYiVaHruwzqROMEC..rhgkxpA8BkPWwXXCTUidbcE5xtFpN2UVjTfya2r4YJAC * tools/skia_goldctl/win: 3Z3zEAwtATXaw6OCunrkLRtBDiMoKW34b_yeMZ82eocC..bMHjBq4De--lL7_Tr4K31mN6LR7hkSStHG_W34ogifYC No update to Clang. Bug: angleproject:5768 Tbr: cnorthrop@google.com Change-Id: I82f74de7812ba075f6c3cd9fa0b4d724df876669 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779806 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 48560f67 2021-03-19T16:56:44 Tests: Add Real Cricket 20 trace Test: angle_perftests --gtest_filter="*real_cricket_20*" Bug: b/183165790 Bug: angleproject:5777 Change-Id: I1f350e3ea458a599396412e2c5ca80d6c7887d73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776554 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Ian Elliott c4b1f366 2021-03-22T17:56:54 Fix copyright dates of new test files per Shabi Bug: b/181711029 Change-Id: Ie619ba90f699dd8234cf185198cb6eeac9142758 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780560 Reviewed-by: Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
Charlie Lao ef17c650 2021-03-08T18:50:53 Vulkan: Add test for filament gltf usage case filament gltf sample code is rendering to a level that is excluded from [base_level, max_level]. This is allowed by OpenGL spec. We are crashing right not. This CL adds tests for the exact usage pattern for filament. Bug: b/181800403 Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithBeyondMaxLevel Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithSubImageWithBeyondMaxLevel Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithBellowBaseLevelLOD Change-Id: I69bab8bc3961bbc2dcc78ba2db3c8759f277416b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752897 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Tim Van Patten b2e76cf5 2021-03-17T17:43:03 Save/Load missing members There are several class/struct members that are missing when a program is serialized/deserialized. This leads to errors when attempting to link programs that have been deserialized. For example, when drawing with a PPO that contains programs which were created with glProgramBinary(). This CL adds saving/loading the missing members. Bug: b/182409935 Change-Id: I637c6cd8c174acd6da8d51433893323a32e5d7c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770683 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 4386840c 2021-03-19T16:54:41 Tests: Add android log library to traces This is required in order to call __android_log_print, which can be sprinkled into the trace for debugging. Bug: b/183165790 Change-Id: I717f2ac7809172f22b7badee6f1096394a02bc14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776553 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Tim Van Patten 34e28778 2021-03-17T17:38:19 Reorder ShaderVariable functions and members ShaderVariable's functions and members are all mixed up. This CL reorders things to move the functions before the members, to better match ANGLE's coding style. This also adds a note that any new members that are added need to be added to gl::WriteShaderVar() and gl::LoadShaderVar(), which are actually implemented in Program.cpp, since ShaderVars.h/cpp can't include libANGLE/BinaryStream.h. There are currently several members that are missing, leading to save/load errors, which are fixed in a follow-on CL in this chain. Bug: b/182409935 Change-Id: I1381a5efffb56c0989961bbcfd405b95d59d6396 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770682 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mohan Maiya 2be71410 2021-03-19T14:07:02 Handle inactive structure type varyings correctly Correctly handle inactive varyings of structure type when collecting transform feedback varyings. Previously, all varyings of structure type were marked as active by mistake. Bug: angleproject:5557 Test: TransformFeedbackTest.InactiveStructureVarying* Change-Id: Ica1cbce5c551cdbb97999eeac59d09a961937615 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770680 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 570970f9 2021-03-19T13:43:35 Vulkan: Handle compilation error involving gl_InvocationID We need to generate a compiler error only when the vertex index of an output variable as an l-value, in a tessellation control shader, is not the indentifier gl_InvocationID. Bug: angleproject:5557 Tests: dEQP-GLES31.functional.tessellation.shader_input_output.barrier Change-Id: Ica075b8d85916caa228f057b203ae81b27f65e2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2758915 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Charlie Lao 81432c24 2021-03-19T14:03:02 Vulkan: Rename onImageHelperRelease to finalizeImageLayout Make the API name reflect what it does. With recent changes, this get called from places that are not releasing ImageHelper object, but is try to reference the current layout. This new name makes more sense than onImageHelperRelease (at that time when this API was introduced, it was only called when ImageHelper is being released). Bug: b/175584609 Change-Id: Ie5f5fcdbd97436724d7eb016374d8b4178e7ba1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776261 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Jamie Madill 02acc5ee 2021-03-18T16:08:59 Vulkan: More cleanups to perf counters. This refactors the pipeline type in the ContextVk class to also use a packed enum map. It also expands the object perf counters to store both a specific and cumulative version for use in different cases. Bug: angleproject:5736 Change-Id: I6ff78e38065eb577f2b95b1d9c4f9cc31d7f325f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774184 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cody Northrop ecbd870f 2021-03-21T22:54:24 Tests: Add Avakin Life - 3D Virtual World trace Test: angle_perftest --gtest_filter="*avakin_life*" TBR: jmadill@google.com,timvp@google.com Bug: b/183344915 Bug: angleproject:5779 Change-Id: Iaf2d8341055d5b7c6f3c8a7a7a1fb3d1399fabc5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776746 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cheryl Wei 0380f115 2021-03-18T09:56:14 Skip ResizeWindow test on Linux. ARM Linux doesn't support window surface resize. Bug: angleproject:4453 Change-Id: Ia8631f5191c2b3ebd822766cc7f92275aa62dff3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2777578 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya 7fe44a53 2021-03-20T09:39:09 Vulkan: Don't acquire new BufferHelper for external buffers EXT_external_buffer spec - This extension allows the data store for an immutable buffer to be sourced from an external EGLClientBuffer, allowing sharing of EGL client buffers across APIs, across processes, and across different processing cores such as the GPU, CPU, and DSP. The intent is for a single backing memory to be reused across various processes and processors. Ensure that a glBuffer backed by external memory does not orphan the memory when glBuffer APIs like glBufferSubData or glMapBufferRangeEXT modify the glBuffer. Bug: angleproject:4380 Bug: angleproject:5073 Tests: ExternalBufferTestES31.*DoesNotCauseOrphaning*Vulkan Change-Id: I4e88f80d93ee1ba1208378121412926351d10af8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776192 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
angle-autoroll 7e9b497c 2021-03-22T08:19:11 Roll Chromium from c33e21cce932 to 3eced2421f5a (477 revisions) https://chromium.googlesource.com/chromium/src.git/+log/c33e21cce932..3eced2421f5a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ba8be7fd2f..120a8d610c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/55b74c093b..f13f2e366c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..999f35f30e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9629038820..24cecabb89 * tools/luci-go: git_revision:4eef77dde582d6065203e3249dd80477391a7dd6..git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb * tools/luci-go: git_revision:4eef77dde582d6065203e3249dd80477391a7dd6..git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb * tools/luci-go: git_revision:4eef77dde582d6065203e3249dd80477391a7dd6..git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/df4e23350e..c94714a14b * tools/skia_goldctl/linux: GNchtrcB6qbKJwI4p-GTx1VGkCUsAWxKyn2kIXkyMZcC..PFAC9ipfkYe6ZljRb8758leyPy7Jw6Dhl2dtHp0IsMYC * tools/skia_goldctl/mac: 0r4l0jSQ08UrxS6-MUtgrn6DegnbVTPg-1I_HWxO3JsC..Ht0L_bool7JJxm1K8Y4MzgKRlPhoIYiVaHruwzqROMEC * tools/skia_goldctl/win: _LtAsLqSVwpOUShHDIbQWgtPXUO4xbpf1MDMcloIAdQC..3Z3zEAwtATXaw6OCunrkLRtBDiMoKW34b_yeMZ82eocC No update to Clang. Bug: None Tbr: timvp@google.com Change-Id: Ia49b1a9a909ceea201b65fd2f8d823e967a90ffa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776747 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Ian Elliott 90cf278c 2021-03-19T16:17:43 Add multi-thread/context test for compute shaders The "Ragnarok M: Eternal Love" game uncovered a bug where 2 contexts shared a VkCommandBuffer. The one context was used by one thread for rendering, and the other context/thread dispatched compute shaders. When the rendering thread destroyed a VkCommandBuffer, future compute dispatches crashed because the new VkCommandBuffer didn't have a compute pipeline bound. Bug: b/181711029 Change-Id: I8bc85150c1c6202e02feb84a7ccc0ad7b9c39258 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770681 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Nicolas Capens 135385a1 2021-03-19T00:09:31 Disable EGL_EXT_buffer_age for SwiftShader Vulkan Cuttlefish with SwANGLE failed to pass the android.graphics.cts. BitmapTest#testDrawingHardwareBitmapNotLeaking test, due to a timeout in dequeueBuffer (error = -110) during an EGL_BUFFER_AGE_EXT surface query. This change conservatively works around the issue by leaving EGL_EXT_buffer_age support disabled for SwiftShader. Further investigation is required to check whether this timeout can also occur with other Vulkan drivers, and if it can be addressed robustly. Bug: b/182521420 Bug: angleproject:3529 Change-Id: I54e3767e74bf922f273d8860f9f4cfc8b6589536 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774030 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Nicolas Capens <nicolascapens@google.com>
Charlie Lao d5bc8a27 2021-03-17T18:21:35 Vulkan: Add VUID-vkCmdDraw-None-04584 validation error to ignore list Aztec ruins is using the same texture (but different level controlled by a uniform variable) for textureLod and rendering. This triggers vulkan validation error. This CL put it in the ignore list so that it can pass. Bug: b/175584609 Change-Id: I7623e7b448514b3c12268aa5fe154f4c2f59b059 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770686 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Charlie Lao 867411a4 2021-03-08T19:08:14 Vulkan: Track images used for both attachment and sampler This CL adds a new layout ImageLayout::ColorAttachmentAndShaderRead. We detect that the same ImageHelper object is used for both sampler and attachment and will pick this new layout instead of ColorAttachment. Bug: b/175584609 Change-Id: I2089f59d4dc1ad4de7edab0e067797adcfa9b020 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2749479 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Mohan Maiya 5163cd0c 2021-03-18T18:17:11 Add isYUV to angle::Format In preparation for adding support for more YUV formats add an 'isYUV' field that tracks whether a format is a YUV format. For now it is set if the format string contains the substring 'PLANE'. This is not the case for all known YUV formats but the condition can be expanded when required. Bug: angleproject:5773 Change-Id: Icb574037dc8105584931835dab0b60e8bafa3262 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774762 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Charlie Lao da437f26 2021-03-08T19:08:14 Vulkan: Defer color image layout changes at endRenderPass time Right now color render target's image's layout change are done at beginRenderPass time. The problem is that the layout also depends on whether texture is also being used as a sampler or not. That information is not known when renderpass starts. We did some special treatment for depth stencil attachment so that its layout determination is deferred until endRenderPass time. This CL expands that same mechanism to color attachment as well. Right now the color attachment will still pick the same ImageLayout::ColorAttachment layout since the logic to detect it is also used for texture sampling is not there yet. Bug: b/175584609 Change-Id: Id7486174d475f894461578b31d0d40fdd90e808a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2744121 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
Geoff Lang 0a80f2e1 2021-03-15T16:56:08 D3D: Mark images dirty after recovering from storage When images are recovered from storage due to resizing storage, they were marked as clean and not always re-copied to the new storage. Bug: angleproject:5757 Bug: chromium:1188854 Change-Id: Idd11025820433ab74ff769cd9508efcec4575c32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2763282 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 5067fccf 2021-03-19T10:02:33 Roll vulkan-deps from 6ea3512e6349 to 91a2a0b15f23 (6 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/6ea3512e6349..91a2a0b15f23 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/d18bcd64fa..979319b9b1 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4f498774db..a732e4c03c * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d5bf0be344..309d9bea09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ifb1845a82a8ae3c3cd19e7023bb20048a6486ff3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774761 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 15a1e735 2021-03-19T07:00:28 Roll Chromium from e7ef5f7d0368 to c33e21cce932 (451 revisions) https://chromium.googlesource.com/chromium/src.git/+log/e7ef5f7d0368..c33e21cce932 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/17a38f4bb2..ba8be7fd2f * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c93be42a40..4e078437d0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3b69bfd940..55b74c093b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8e820e32d0..74cb518d98 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c730daef75 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/168ccba7af..9629038820 * tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:4eef77dde582d6065203e3249dd80477391a7dd6 * tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:4eef77dde582d6065203e3249dd80477391a7dd6 * tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:4eef77dde582d6065203e3249dd80477391a7dd6 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c98db359fc..df4e23350e * tools/skia_goldctl/linux: NQmBkXHpEXJthTy0c6iuXDk1UgYDyQ7Fm649E7P38bAC..GNchtrcB6qbKJwI4p-GTx1VGkCUsAWxKyn2kIXkyMZcC * tools/skia_goldctl/mac: Rbel_7KQuxv_-SIkB3oT43MBYgKlr3AUwFystGNHKJ8C..0r4l0jSQ08UrxS6-MUtgrn6DegnbVTPg-1I_HWxO3JsC * tools/skia_goldctl/win: 3sDKbIeT1dc4BYnE_uMfW71xbKa-b75KWLUwVEIJF-QC.._LtAsLqSVwpOUShHDIbQWgtPXUO4xbpf1MDMcloIAdQC No update to Clang. Bug: None Tbr: timvp@google.com Change-Id: I36906d996c7474ebf61c329ad7622f32c00ec960 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774452 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 9b3b5733 2021-03-17T15:38:42 Tests: Add Ragnarok M: Eternal Love trace Test: angle_perftests --gtest_filter="*ragnarok_m_eternal_love*" TBR: timvp@google.com,jmadill@google.com Bug: b/181800519 Bug: angleproject:5772 Change-Id: I1dcde486e909f7c2b5d59132e5f673c7e8ab1d01 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774264 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Qin Jiajia ba0bd785 2021-03-15T16:00:33 Fix the assert error and inbalence parens for SSBO This PR strengthens below two cases: 1. Support calculate unsized array size for any type. Previously, it reported error when the type was a structure. 2. Correctly add the right paren for store function when any load/length functions are nested in it. Bug: angleproject:5734 Change-Id: I3428fa35f1481275e1d193094ceddb011f747cf1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2762655 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
Jamie Madill b717952e 2021-03-18T10:39:34 Vulkan: Use packed enum map for descriptor set index. This simplifies a lot of the data structure indexing in the program executable class. Also renames the "DriverUniforms" and "InternalShader" index into a single "Internal" index. Bug: angleproject:5736 Change-Id: I2a51d8b14d5b16b438dbe636f77b11bbc045ba9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773321 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
Jamie Madill 1b08cfcb 2021-03-18T10:01:54 Vulkan: Clean up shader buffer DS allocation. We were using repeated code patterns in several places. Bug: angleproject:5736 Change-Id: I206783dd792c3b0f9d38027235445ec600a60d88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773320 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Charlie Lao 378b3261 2021-03-08T18:50:53 Vulkan: Move CommandBufferHelper::reset() closer to constructor This is a mechanical change. Similar to constructor, the reset() function is doing initialization of data members. Move them next to each other helps adding a new data members which requires modifications to both functions. Bug: b/175584609 Change-Id: I11386677bc5c9838104025d6a4ecf6f2b58fa92c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745842 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Charlie Lao 1f1b4ffe 2021-03-08T11:44:28 Vulkan: Test render and sample the same texture but with different LOD This simulates aztec ruin's usage. This works properly on native OpenGL but generates validation error on vulkan backend and renders incorrect as well. Bug: b/175584609 Test: FramebufferTest_ES3.SampleFromAttachedTextureWithDifferentLOD Change-Id: I402c205a1b625669cae29ee201dddd144e0dfbde Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743797 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
Gert Wollny f201c9d2 2021-03-17T13:48:16 scripts: Ignore "rapidsjon/..." when checking includes These include stubs are given in the comments within rapidjson.h and are preported as error by the presubmission check. Bug: angleproject:5765 Change-Id: Ic200a860de7337aefcd3bb0f82686d62a1349d89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2765648 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
angle-autoroll 57d8b3e1 2021-03-18T07:01:20 Roll Chromium from 60fea25f23e6 to e7ef5f7d0368 (472 revisions) https://chromium.googlesource.com/chromium/src.git/+log/60fea25f23e6..e7ef5f7d0368 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/37b76d6fba..17a38f4bb2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2408fca90b..3b69bfd940 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c730daef75 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/752611e5f2..168ccba7af * tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d * tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d * tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/67f01522b1..c98db359fc * tools/skia_goldctl/linux: 3T-SUsozYAVsudk5nd48kjHvfpos6egORLB8s7ElE8oC..NQmBkXHpEXJthTy0c6iuXDk1UgYDyQ7Fm649E7P38bAC * tools/skia_goldctl/mac: TPtcrf_XH3mB9pdK4W3N0QPZunsqJ08T7U7fWPvMnRAC..Rbel_7KQuxv_-SIkB3oT43MBYgKlr3AUwFystGNHKJ8C * tools/skia_goldctl/win: wr5p_MyXcHVxA-eHznijCeFaqR2HUo02Hw70e0CWCIoC..3sDKbIeT1dc4BYnE_uMfW71xbKa-b75KWLUwVEIJF-QC No update to Clang. Bug: angleproject:2424,angleproject:2880,angleproject:2994,angleproject:3033,angleproject:3753,angleproject:4377,angleproject:5014 Tbr: timvp@google.com Change-Id: Ib964474c19e613fedb9ab3ac0d474fc1829289ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770687 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 39296f39 2021-03-18T00:47:34 Roll vulkan-deps from 105af117f053 to 6ea3512e6349 (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/105af117f053..6ea3512e6349 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b2e5b5c559..d18bcd64fa * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/faa570afbc..bcf55210f1 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/478754c005..4f498774db * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/053e2bf22d..d5bf0be344 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I190a577538fb3a2178c1e82f1c9fc4e52749a322 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770144 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
James Darpinian bb7c1442 2021-03-17T10:17:31 Fix immutable texture base level validation Jeff's new rendering feedback loop test (https://github.com/KhronosGroup/WebGL/pull/3221) found a couple of issues with texture base level validation. For immutable textures the base level is clamped to the valid range, so setting an out of range base level does not make an immutable texture sampler incomplete, and we need to use the clamped value when checking for rendering feedback loops. Bug: angleproject:5768 Change-Id: Ie065709efd736f2cf75d4f980e8ac27999f80142 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2767901 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cody Northrop f6eccc20 2021-03-12T09:17:27 Tests: Add June's Journey trace Test: angle_perftests --gtest_filter="*junes_journey*" TBR: jmadill@google.com,timvp@google.com Bug: b/182566407 Bug: angleproject:5752 Change-Id: I083507949c9bc16bf701028a678540df9a3531dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2755840 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Jamie Madill 716b2cba 2021-03-12T14:46:53 Use bitset masks for active shader buffers. This switches the tracking for the uniform, shader storage, and atomic counter buffers to use bitset masks to determine where there are active buffers. This will make iterating these buffer sets faster. Also renames the limit for atomic counter buffers to be consistent with the other buffer types. Also applies the implementation limit to atomic counter buffer bindings. This fixes out-of-bounds access on some Linux platforms that expose a large number of bindings. Bug: angleproject:5736 Change-Id: Ice801645697592d1dda6aebf0cb69767594cc0c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757509 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
kmx.io     mail     discord kmxgit v0.4.0