kc3-lang/angle

Log

Author Commit Date CI Message
Shahbaz Youssefi f355e2b3 2025-04-15T18:58:25 Vulkan: Remove preferDriverUniformOverSpecConst This was practically true for every vendor on Android (where rotation matters). For Qualcomm, it was also true due to a bug in version checking and didn't seem to be causing any concerns. Where pre-rotation is supported, it is better to enable this feature to avoid excessive pipeline creation. This change removes the feature and makes sure ANGLE always uses uniforms for rotation instead of spec consts. While technically this may have an adverse effect on platforms that never need pre-rotation, the ability is retained for all vendors since pre-rotation is finding its way into more platforms and would likely eventually be needed everywhere anyway. Bug: angleproject:42265878 Bug: angleproject:42262166 Change-Id: I4b64c04da46db08cfdd44b60789b66d93d8e8b17 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6459025 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: mohan maiya <m.maiya@samsung.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Le Hoang Quyen 07eeca12 2025-04-17T20:58:19 Metal: prevent padding in state cache's structs. Fixed: angleproject:411845677 Change-Id: I8a9635634e66f86c132205f75825a916481f7ad0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6468239 Commit-Queue: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Le Hoang Quyen f6a350de 2025-04-17T20:43:08 Metal: fix rasterSamplecount not used in comparing render passes. RenderPassDesc's rasterSamplecount was not used to comparing two render passes' descriptors. Note: no reported bug found related to this missing comparison yet. This bug most likely affects render passes without any attachment (PLS?). Because if the 2 render passes have the same attachments, their rasterSamplecount values must also be equal. There was also a missing rasterSamplecount comparison in RenderPipelineOutputDesc::operator==. However, this function is not used. When comparing two render pipelines, RenderPipelineDesc::operator== is used instead, which is currently implemented using memcmp. So removing the former to avoid confusions. Bug: angleproject:411845677 Change-Id: Ic9b1867226561d096c1fb8ca2194b657d29daa18 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6468238 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
angle-autoroll d4336f18 2025-04-18T21:11:15 Manual roll Chromium from 5d2f55eb5444 to a3c80076ee75 (831 revisions) Manual roll requested by yuxinhu@google.com https://chromium.googlesource.com/chromium/src.git/+log/5d2f55eb5444..a3c80076ee75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/01dc1e19fb..40000cd9de * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/015ef44748..be957e3dcf * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a5ca4e9e71..bcb6f5005f * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/0c43a32e20..236644f7ef * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/cd3ef01e66..37963b19ef * third_party/android_build_tools/manifest_merger/cipd: V6nA9cUoZlv01Hj7gY0rG-mLJ80GjclSrqcjE2vjamUC..YZTHR6AILB1hD0-rYZg-7nxgKXyF3D2jOXsHl2VHS68C * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/00813b8839..cb314c218c * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4c05962192..5803cf1918 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f833dca6f0..8c7a5ae5a8 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/1b77fbeb05..b3dba614ba * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/0234f44c5f..1a4051088b * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/fead5a71b0..c17f4e2d0d * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/4abaa1429e..f2f11f2ee5 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f549458617..a52aa43e84 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/05e0bc764a..4bbc1c3d28 * tools/skia_goldctl/linux: Ygv7ZB2vTXUWbXtH1I2DNMSB1D7GkvpabMuyVEJpINAC..t1Emdw6PaIKIs6zuhT4Jv1SVmIPsiB-_OGkwIzc0BtoC * tools/skia_goldctl/mac_amd64: yNIr-9hJd-v5rwyRRQk5z9eBz_Ru52p8YTOc-WHIoBgC..6v2TEuvoNIrNOIR3dEzYsXzvNdjmIam5F5qHkGC5g-cC * tools/skia_goldctl/mac_arm64: zQOaSHuVEWVro28b0D6FdKiq5f8KhkMG_XOFqAdgoIUC..ZeclbMtb_nac9gGzvgJV0l1UiqLbHCf8r6beXS_CHQEC * tools/skia_goldctl/win: DWI5tbnr7u5QE7UFkrzeJI3hqZyLqA8E_xOqOpNU0vgC..8u2EjPLoMc270uyI6PDDJp7-7MZmdS9dFJWNYnu8XC8C No update to Clang. Bug: angleproject:411721483 Tbr: yuxinhu@google.com Change-Id: I812fc9cbdf684bfcb1ab9f23e92a3cdad4566f21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6472633 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi f8a8adf6 2025-04-16T14:45:33 Vulkan: Prune superseded updates during host-image-copy Bug: angleproject:42266771 Change-Id: I7aa8e85720a54537389df615b575ddfa9951770d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6462475 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Amirali Abdolrashidi a9f2f87f 2025-04-15T13:46:34 Vulkan: Update version macros * Updated the deprecated version macros * VK_VERSION_MAJOR -> VK_API_VERSION_MAJOR * VK_VERSION_MINOR -> VK_API_VERSION_MINOR * VK_VERSION_PATCH -> VK_API_VERSION_PATCH * VK_MAKE_VERSION -> VK_MAKE_API_VERSION * Added a separate case for QCOM drivers in getVersionString(). * The major version is now OR-ed with 512. * (New drivers seems to have a major version of 512, which falls not within the major field, but the variant field, when using the VK_API_VERSION_x macros.) Bug: angleproject:42267006 Change-Id: Ic9b761d182ff49c3ede43c7bd14f366f945fbf36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6460682 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 151a9ed2 2025-04-18T03:01:08 Roll SwiftShader from 2d70dae3d0ca to 0e75e7030ccb (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/2d70dae3d0ca..0e75e7030ccb 2025-04-17 cwallez@chromium.org Add -Wno-unknown-warnings in llvm-10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I32a3d9679c3f05ac10a29c0aba5bc176d6ebe935 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6470944 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 4928b7f7 2025-04-18T10:01:01 Roll vulkan-deps from b552240b4d50 to 5880b384399b (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/b552240b4d50..5880b384399b Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/096bb07f71d33111f9748816cd986e616ec10776..ca63ea568b41d461dd25fa588350008b5ab00c89 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/110b6c989ccb4e874089db777e2b54eb9abb5670..409c16be502e39fe70dd6fe2d9ad4842ef2c9a53 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/eb3cb1d71f5b548bc3cd54af98dd2092d2269b62..b8771d6a9b7f9ed2c0f42e33fef2c8edbf2e73cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Iec6e41c0c966a8fbb4759356f9729766832f707a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6472625 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 4b9525b2 2025-04-04T00:00:00 Remove all getClientMajorVersion helpers Client version checks should use proper struct compare operations. Bug: angleproject:408843436 Change-Id: I92cd91d1e7e6daa761f79060835aa534c5671264 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6467460 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 9db4bf6e 2025-04-04T00:00:00 Autogen context version checks for 3.1 & 3.2 entry points As a side effect, added missing version checks for the following OpenGL ES 3.2 entry points: * BlendEquationi * BlendEquationSeparatei * BlendFunci * BlendFuncSeparatei * ColorMaski * Disablei * DrawElementsBaseVertex * DrawElementsInstancedBaseVertex * DrawRangeElementsBaseVertex * Enablei * GetDebugMessageLog * GetPointerv * IsEnabledi * MinSampleShading * PopDebugGroup * PrimitiveBoundingBox * PushDebugGroup Bug: angleproject:409484297 Change-Id: I6be7e3a4a8ba9b99595f4930d9c3a1fa1b4c6154 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6441552 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu b86d7d8f 2025-04-14T15:37:47 Android: Add Galaxy S24 support (Xclipse) Bug: b/410630704 Change-Id: I97fd649de4278f447893a01fbe5ceeee02dd100e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6456664 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 760562b5 2025-04-17T10:01:43 Roll vulkan-deps from f286d9d385ce to b552240b4d50 (7 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f286d9d385ce..b552240b4d50 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/7c2f5333e9c662620581361dffc327a99800bb52..aa6cef192b8e693916eb713e7a9ccadf06062ceb https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/2550869855fcef23a96f67e8a9af9571c8fa1ac7..096bb07f71d33111f9748816cd986e616ec10776 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/a8f207875c97169e8b7c0a62b25d9a1bc4724432..50ace769d381f746d7d6cb75db982fa4d94a112f https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/5d1b3be8ba186d039dcb609f0aa13e320cab6561..eb3cb1d71f5b548bc3cd54af98dd2092d2269b62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: Id6f4a1b801dcb6167b13b2f371d53b32173733e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6467899 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 65011819 2025-04-17T07:02:08 Roll Chromium from f2e4beff997e to 5d2f55eb5444 (608 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f2e4beff997e..5d2f55eb5444 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/47d15836bf..01dc1e19fb * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/97bef621df..015ef44748 * buildtools/linux64: git_revision:887935b6e76f2397b6c0fc048bf2958190e696a4..git_revision:10a27145cd0770b78745ff536e343bf12c70f6c3 * buildtools/mac: git_revision:887935b6e76f2397b6c0fc048bf2958190e696a4..git_revision:10a27145cd0770b78745ff536e343bf12c70f6c3 * buildtools/win: git_revision:887935b6e76f2397b6c0fc048bf2958190e696a4..git_revision:10a27145cd0770b78745ff536e343bf12c70f6c3 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/27cd4ad8a7..a5ca4e9e71 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/d3d8cbda8c..0c43a32e20 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/0e40571bdf..00813b8839 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/326015d079..323c3f8758 * third_party/fuchsia-sdk/sdk: version:27.20250409.6.1..version:27.20250417.1.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/b2be7b0b0b..4c05962192 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/0940075729..1b77fbeb05 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/643d33bdbf..fead5a71b0 * third_party/siso/cipd: git_revision:7462aaffc7da5c672efbac0f39e14d3a41862799..git_revision:55fb4e14c1c6ab0f170fe3cc145c7469c5f2e919 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/8856b44d47..4abaa1429e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/09f38f3e7a..f549458617 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/eaaba9898e..05e0bc764a No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ic0f005d99f07f0adfd267c5a28b80e6e3ba6ef02 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6466370 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Cody Northrop 53279e92 2025-04-16T16:04:55 Traces: Update traces that need ES 3.2 With Alexey's change to autogen ES version checks, he found that some traces required 3.2 without requesting it: http://crrev/c/6441552 This likely happened due to a combination of apps assuming it is supported, and get_min_reqs reliance on errors thrown to detect when an ES version is needed. This CL updates the traces identified to properly request ES 3.2 and any extensions. It also removes redundant extension requests from TracePerfTest.cpp now that they show up in JSON. Test: Trace tests with autogen fixes Test: retrace_restricted_traces.py get_min_reqs Bug: angleproject:409484297 Change-Id: Ia19d70316f5e6422d027c1ce135593391abce378 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6465695 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Shahbaz Youssefi ccabbbca 2025-04-16T23:52:32 Suppress flaky test on Nvidia/D3D Bug: angleproject:411157348 Change-Id: I08542c9ca0d332ab2f88a3174ab42e08d9a21f31 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6466885 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Mohan Maiya a6a7de5a 2025-04-16T14:28:13 Vulkan: Sync perf counters in finishImpl(...) .. instead of finish(...) so other code paths like onDestroy(...) have a chance to update perf counters before decoupling from the sharegroup Bug: angleproject:386749841 Change-Id: Ib0f847dda2274686ed9e5d3c8211ee5a364e4b65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6463366 Commit-Queue: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 408f5853 2025-04-04T00:00:00 Make gl::Version data members private * Further simplified gl::Version implementation by making data members private and merging them. * Used proper version struct comparisons instead of accessing individual version components. * Moved known version constants to Version.h for broader availability. * Removed no longer used helpers: * PrivateState::getClientMinorVersion() * State::getClientMinorVersion() * Context::getClientMinorVersion() Bug: angleproject:408843436 Change-Id: I3ae8f495269d649253fa2381ecbfc018a184fa20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6460787 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Shahbaz Youssefi b64d380e 2025-04-15T00:54:22 Vulkan: Ghost texture's image backing if overwritten If the texture's image is in use by the GPU but is overwritten completely, this change releases the old image and creates a fresh one. If the texture was used in a render pass, this avoids breaking the render pass. Otherwise, it allows the new image to be initialized with VK_EXT_host_image_copy functionality. In the very least, an unnecessary barrier is avoided. As a targeted optimization, this functionality is limited to non-array 2D color textures which are known to benefit from this ghosting in applications. Other texture types can be easily added, but need lots of tests to be added. Bug: angleproject:42265356 Change-Id: I18a7587599e36f9f70109264ddc1003b24b8b2df Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6456345 Reviewed-by: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 09a81a68 2025-04-16T12:11:25 Roll third_party/libpng/src/ d2ece84bd..8cc222cd3 (277 commits) https://android.googlesource.com/platform/external/libpng/+log/d2ece84bd73a..8cc222cd3e79 $ git log d2ece84bd..8cc222cd3 --date=short --no-merges --format='%ad %ae %s' 2024-11-20 enh Make bpfmt happy. 2024-10-02 sadafebrahimi Edit OWNERS file 2024-09-12 ctruta Release libpng version 1.6.44 2024-09-12 ctruta chore: Rerun `./autogen.sh --maintainer` 2024-09-12 ctruta oss-fuzz: Update the README file, the Docker file and the build script 2024-09-11 jbowler fix: Prevent overflow in chromaticity calculations 2024-04-17 green cmake: Fix an error in the declaration of target include directories 2024-09-10 ctruta Revert "cmake: Fix an error in the declaration of target include directories" 2024-04-17 green cmake: Fix an error in the declaration of target include directories 2024-09-10 ctruta Deprecate PNGARG and remove all of its remaining uses 2024-07-02 mkhachaiants oss-fuzz: Add fuzzing targets for simplified READ API 2024-03-01 benni.buch build: Add a CMake config file compatible with the FindPNG module 2024-09-08 ctruta ci: Simplify the Travis CI configuration matrix 2024-09-08 ctruta chore: Delete contrib/tools/chkfmt.sh 2024-09-08 ctruta chore: Pacify editorconfig-checker version 3.0 2024-04-26 bungeman fix: Restore STDERR in pngtest.c 2024-09-03 jbowler fix: Remove cHRM check to accomodate ACES AP1 2024-09-05 ctruta ci: Add the targets/ subdirectory to facilitate cross-platform testing 2024-09-04 eriff cmake: Honor CMAKE_SYSROOT if set 2024-09-04 ctruta cmake: Fix the handling of PNG_HARDWARE_OPTIMIZATIONS on FreeBSD/amd64 2024-09-03 ctruta ci: Fix the verification of the msys2 toolchain on AppVeyor CI 2024-06-17 ctruta arm: Add a placeholder file in lieu of the former `filter_neon.S` 2023-12-14 ross.burton arm: Remove obsolete assembler implementation filter_neon.S 2024-05-30 jbowler SECURITY: disable build of filter_neon.S on arm 2024-03-11 kiyoungkim Remove VNDK definition(s) 2024-02-24 ctruta Bump version to 1.6.44.git 2024-02-23 ctruta Release libpng version 1.6.43 2024-02-23 ctruta ci: Add the libpng release tags to the list of exclusions 2024-02-23 ctruta test: Fix a compiler warning in pngtest.c 2024-02-22 ctruta chore: Delete comments and config settings and stuff from here and there 2024-02-22 ctruta doc: Review the libpng history and update scripts/cmake/AUTHORS.md 2024-02-22 ctruta doc: Update the README file 2024-02-22 ctruta pngexif: Import pngexifinfo as an externally-contributed project 2024-02-21 benni.buch build: Mark the installed libpng headers as system headers in CMake 2024-02-20 ctruta build: Checking for compiler support of LoongArch LSX should be guarded 2024-02-20 ctruta build: Add an explicit declaration of the AWK variable to configure.ac 2024-02-19 ctruta build: Improve the search for an AWK processor in the CMake build 2024-02-19 ctruta build: Update the CMake build options PNG_TOOLS and PNG_FRAMEWORK 2024-02-19 danoli3 build: Fix a CMake build regression introduced in version 1.6.41 2024-02-17 ctruta Fix "ci: Fix the reporting in ci_lint.sh" 2024-02-17 ctruta ci: Fix the reporting in ci_lint.sh 2024-02-17 ctruta ci: Allow the user to force an in-tree cleanup before verification 2024-02-15 ctruta chore: Clean up the spurious uses of `sizeof(png_byte)`; fix the manual 2024-02-15 ctruta chore: Update the .editorconfig files and pacify editorconfig-checker 2024-02-15 ctruta Add a GitHub Action for linting 2024-02-15 ctruta ci: Pacify shellcheck version 0.8 and apply other linting improvements 2024-02-12 ctruta ci: Fix the check of `PNG_LIBPNG_VER_BUILD` in ci_verify_version.sh 2024-02-11 ctruta ci: Remove the workaround for CI_AR from ci_verify_makefiles.sh 2024-02-11 ctruta build: Update the makefiles for the benefit of cross-compilation 2024-02-11 ctruta ci: Update (again) the ci_verify_*.sh scripts; update .shellcheckrc (...) 2020-12-14 owen cmake: Fix cross-compilation on macOS 2022-09-10 ctruta cmake: Rename the target "symbol-check" to "scripts_symbols_chk" 2021-12-04 glex.spb cmake: Correctly handle generated files 2022-09-05 ctruta configure: Initialize PNG_ARM_NEON_OPT and PNG_MIPS_MSA_OPT correctly 2022-09-05 ctruta Rerun "./autogen.sh --maintainer" 2022-09-05 ctruta Clean up configure.ac 2021-06-02 dnfield Remove obsolete/incorrect __LLVM,__asm section 2022-09-04 ctruta Update the configuration for Travis CI and AppVeyor CI 2022-09-04 ctruta ci: Update the CI scripts 2022-08-26 ctruta cmake: Set PNG_ARM_NEON to "on" by default on ARM64 2022-08-26 ctruta Update the copyright year 2021-12-06 mariaur Add updated cpe for vulnerability scanners 2021-03-15 ctruta Update the copyright year 2021-03-15 ctruta ci: Update the CI scripts 2020-12-15 benkasminbullock Eliminate spaces between function name and ( 2020-12-11 benkasminbullock Remove duplicate line 2020-12-11 benkasminbullock Fix typo in README 2020-12-11 benkasminbullock Remove second call to write_eXIf 2019-12-19 nju04zq Fix decode fail on image with invalid eXIf chunk 2020-07-28 klebertarcisio Add a check to pngimage.c 2021-03-12 ctruta contrib: Apply various fixes to libtests 2020-12-31 ctruta .gitignore: Add 2020-12-31 ctruta ci: Fix the Visual Studio verification on AppVeyor CI 2020-12-31 ctruta ci: Recognize more CI_ variables for better cross-platform verification 2018-03-19 crrodriguez libpng.pc.in: zlib dependency is private 2020-05-24 ctruta ci: Verify the install target 2020-05-24 ctruta cmake: Refactor the install target; reformat 2020-05-18 ctruta ci: Add a new top-level directory, dedicated for CI verification 2018-05-20 alex.gaynor cmake: Add an option to enable/disable building of executables 2020-05-17 ctruta mips: Remove "last changed" version information from source comment 2020-03-06 guxiwei-hf mips: Fix initialization: always close "/proc/cpuinfo" 2019-08-30 simon.hausmann Fix CMake build with Emscripten 2019-08-26 dnfield Add an __LLVM,__asm section for clang builds on ARM 2019-08-24 ssrobins cmake: Fix a build error on iOS 2019-08-02 zack Fix example.c 2019-07-30 willson.chenwx Fix a warning on Linux caused by _BSD_SOURCE 2019-07-29 pascal.massimino Fix memory leak if eXIf has incorrect crc 2019-07-04 callu.david cmake: Use the correct ZLIB_* variable names 2020-03-29 ctruta scripts: Clean up the makefiles 2020-03-29 ctruta scripts: Fix makefile.std and include it in the CI verification 2020-03-29 ctruta Update configuration for Travis CI; add configuration for AppVeyor CI 2020-03-29 ctruta scripts: Add general-purpose utilities for continuous integration 2020-02-02 ctruta Update the copyright year 2018-11-12 cthomp oss-fuzz: Add custom malloc with max limit to prevent OOM 2019-04-16 rvandermeulen arm: Use <arm_neon.h> when compiling aarch64 intrinsics with clang-cl 2019-04-22 ctruta arm: Move a png_debug statement to its correct place 2019-04-22 ctruta scripts: Delete makefile.clang-asan and makefile.gcc-asan 2019-04-22 ctruta Add support for Travis CI 2019-04-21 ctruta Avoid random test failures by running pngtest sequentially only 2019-04-14 ctruta Bump version to 1.6.38.git Created with: roll-dep third_party/libpng/src Bug: angleproject:42266949 Change-Id: I91c75da049550af1348a01a66a0c68c0848c79ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6460785 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll dbfbec00 2025-04-16T10:01:41 Roll vulkan-deps from 72ecfe9950d2 to f286d9d385ce (9 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/72ecfe9950d2..f286d9d385ce Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/93e93fb61fa672dc6b2f5c4448d4a4ba81c626b9..1104d6ad976fa118b41b6312521488efad3f004d https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/3f7cbaf327681af51ba65bc83bd1e42ddb9681b2..2550869855fcef23a96f67e8a9af9571c8fa1ac7 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/a82b34fb6224e1e5021ddbe56d6d805280e0c740..a8513ac9d0e367c5914095d0b7f09a081a14b4b5 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/390ecbcc4591f0c0c3c03930a3d7eb7f8d67108c..5d1b3be8ba186d039dcb609f0aa13e320cab6561 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: If6ca26724183f74896d2f39e25acc1818bece108 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6461780 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll f2a7b276 2025-04-16T07:01:53 Roll Chromium from f054743ee574 to f2e4beff997e (597 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f054743ee574..f2e4beff997e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/a6401fbdc4..47d15836bf * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/23792edc1b..97bef621df * buildtools/linux64: git_revision:3468d4868725e310eff5f5cd9b6655110883f55b..git_revision:887935b6e76f2397b6c0fc048bf2958190e696a4 * buildtools/mac: git_revision:3468d4868725e310eff5f5cd9b6655110883f55b..git_revision:887935b6e76f2397b6c0fc048bf2958190e696a4 * buildtools/win: git_revision:3468d4868725e310eff5f5cd9b6655110883f55b..git_revision:887935b6e76f2397b6c0fc048bf2958190e696a4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2ec8722b8c..27cd4ad8a7 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/df03b99ce9..0e40571bdf * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/9b76875fb4..f1b90bf3ad * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7648ea1609..326015d079 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/bf30ab1b37..b2be7b0b0b * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e01dce316d..f833dca6f0 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/bb79ac8530..0940075729 * third_party/nasm: https://chromium.googlesource.com/chromium/deps/nasm.git/+log/767a169c88..a708003188 * third_party/r8/cipd: S1YW2OlP8ThsNUXDptm52Ouvnwp9t9xpTy5LECvEOw4C..6qLey8EBp9ivhThnqVPWy2ZDGpsf5Y29EsTbi_rZ1pMC * third_party/r8/d8/cipd: wvbyt_Mr06Bl4Rcv4zoX-sTk_keiEYxfspOMUufh5nIC..6qLey8EBp9ivhThnqVPWy2ZDGpsf5Y29EsTbi_rZ1pMC * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/6d5ee25a0b..8856b44d47 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/45d52d65b4..eaaba9898e No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: Ic9db8f6e20eaf809d786d6dfe60e58c7f066940a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6461509 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi 0ed51ec7 2025-04-10T22:41:22 Vulkan: Disable color attachment usage for LUMA formats Bug: angleproject:42265356 Change-Id: If97fd59e85febfdf345a36097901a2015aa4183b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6447236 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi ca0457f6 2025-04-15T13:10:58 Vulkan: Fix parsed QCOM major version When running tests on QCOM, the major driver version in the renderer string is shown as 512 (e.g, 512.777.0). However, the parsed driver version from the device shows it as 0 (i.e., 0.777.0). Since the features limited on QCOM use 512 as the driver version cap, they would be initialized incorrectly, as they would always be seen as smaller than the cap. This change will remedy this. * Updated ParseQualcommVulkanDriverVersion() to set the major version for the new QCOM drivers as 512 after parsing. Bug: chromium:371512561 Change-Id: I9cd5cf6d3dec50eb900429e4fdda6c563f670f7f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6460066 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
Amirali Abdolrashidi 49d0a332 2025-04-08T16:07:17 Vulkan: Remove ring buffer allocators * Removed the ring buffer allocator functionality from ANGLE: angle::RingBufferAllocator * Also removed the related common files. * (Pool allocators will be used at all times.) * Removed the placeholder functions from the pool allocator. * Removed the following BUILD flag: angle_enable_vulkan_shared_ring_buffer_cmd_alloc * Removed redundant line from ContextVk. Bug: b/410036490 Change-Id: I368fb93a66ddfd192018b09f65004a32339abd5a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6442640 Reviewed-by: Igor Nazarov <i.nazarov@samsung.com> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev cf7eeec2 2025-04-04T00:00:00 Simplify client version compare operations Packed client context version struct into two bytes and defined specialized compare operations instead of using std::tie. Bug: angleproject:408843436 Change-Id: Ic7d91f171a3bce40d46b9cfd3c65d1fc3d3f568c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6432439 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi 838c6596 2025-04-14T16:46:42 Add EGL image tests where source texture is modified Covering the following cases: * The source texture is changed with glTexImage2D. In this case, the image is orphaned and the siblings point to the old image. * The source texture is used in a compute shader. In Vulkan, the internal image backing is recreated, and siblings should continue to track the new image (which they don't, due to a bug). * The source texture is completely overwritten. This is in anticipation of a follow up change in the Vulkan backend that similarly may recreate the backing image of the texture (and should not be affected by the same bug). * The source texture's base level is completely overwritten while the image is in use, and glGenerateMipmap is called. This is also in anticipation of another follow up change in the Vulkan backend that may recreate the backing image. Bug: angleproject:42265356 Bug: angleproject:410584007 Change-Id: I2d5f7f668d77ec6940d34bdf80eb7c885fc6a59d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6454132 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yuly Novikov 45969492 2025-04-15T15:23:50 Add Mac ARM64 builders Not running any tests for now and not on CQ. Bug: angleproject:42266214 Change-Id: Ibd7ada2a61cfba043944bc89b210db7a5ff1255d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6458759 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Alexey Knyazev 33e035f9 2025-04-04T00:00:00 Enforce correct usage of gl::Version In preparation for the implementation update, ensured that gl::Version struct is always initialized with 8-bit values. Bug: angleproject:408843436 Change-Id: Idcc925b49cadc7fdc4f05ff2acaed8020e72a32e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6458758 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxiang Qian e39bcdc3 2025-04-09T17:26:34 Support GLES query counter bits ANGLE only support query GL_QUERY_COUNTER_BITS_EXT with TIME_ELAPSED_EXT or TIMESTAMP_EXT, but other targets should also be supported. Since the values are stored in 32 bits, we just return 32 for other target. An end2end test is added. Bug: angleproject:409674598 Change-Id: I98941f4dd36ef62c57bcb87475ebb9f626c1bbf9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6437686 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
angle-autoroll cee22c43 2025-04-15T10:01:42 Roll vulkan-deps from a24af46b3d3b to 72ecfe9950d2 (10 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/a24af46b3d3b..72ecfe9950d2 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/5af16f4e8ffb7b72807ead08f995c33933e20d61..93e93fb61fa672dc6b2f5c4448d4a4ba81c626b9 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/5ceb9ed481e58e705d0d9b5326537daedd06b97d..110b6c989ccb4e874089db777e2b54eb9abb5670 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/3c26a6a93749a6d1290f1c3d08c278ad8910fb8a..390ecbcc4591f0c0c3c03930a3d7eb7f8d67108c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I83f4ddea70982a3b90f03a5b227aa57f738e8451 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6457431 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Mavis Deng 4be3143c 2025-04-10T15:18:52 Vulkan: Vertex attribute hole crash workaround When the start vertex index of glDrawArrays is not 0, this hole case will crash again. * Added a condition to bypass the attribute update if the attribute pointer is null. * Added a glDrawArrays(GL_TRIANGLES, 3, 3) in unit test VertexAttribPointerCopyBufferFromInvalidAddress Bug: angleproject:359729255 Change-Id: I1d7f50dc56080ef0b4e48c4c3c983189a26171c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6445172 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Mavis Deng <mavis.deng@arm.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shelly Wang ac8607a9 2025-03-27T16:46:21 Vulkan: Disable graphics pipeline on ARM due to performance loss ARM is investigating on Graphics Pipeline Library(GPL) on contents whose performance loss is unacceptable. Therefore, it's recommended to disable GPL until the problematic area gets fixed and the final performance data is acceptable. Bug: angleproject:404581992 Change-Id: I2bcb5f8bca3d64be0e947d7262a615ef867532ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6400174 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
angle-autoroll 08e7dfff 2025-04-15T03:01:40 Roll SwiftShader from 2b323370501c to 2d70dae3d0ca (2 revisions) https://swiftshader.googlesource.com/SwiftShader.git/+log/2b323370501c..2d70dae3d0ca 2025-04-14 dloehr@google.com Disable new clang warnings in llvm-10.0 2025-04-14 swiftshader.regress@gmail.com Regres: Update test lists @ 2b323370 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: I0bfafffb331aed5defeb303348677b2da751ccb1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6457348 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll dbb0eb69 2025-04-15T08:39:57 Roll Chromium from 95d3d27a122a to f054743ee574 (545 revisions) https://chromium.googlesource.com/chromium/src.git/+log/95d3d27a122a..f054743ee574 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/22ae602f01..a6401fbdc4 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4f86145940..23792edc1b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e7c83274e2..2ec8722b8c * third_party/android_build_tools/error_prone/cipd: ZK9e0tqXwlyM9VSS1O09u8kkCtk-SfKOTtSXyAq22-UC..S4diQnIcVdK3MuTHyXN2i5kG0uVfHGyPMBWoY1E6HqcC * third_party/android_build_tools/manifest_merger/cipd: w1Huot__EcTrBmzEJxI19VH5MTAP3uJJekb1hR_gL-MC..V6nA9cUoZlv01Hj7gY0rG-mLJ80GjclSrqcjE2vjamUC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/323c3f8758..7648ea1609 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/98409c6c09..bf30ab1b37 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/f86693f91c..bb79ac8530 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/d93a5a8790..0234f44c5f * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/7dabaa2489..643d33bdbf * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/40226a7819..6d5ee25a0b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a7f7a7df1c..09f38f3e7a * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9cf85a5c01..45d52d65b4 No update to Clang. Bug: None Tbr: yuxinhu@google.com Change-Id: I091e29e5799097b20da9318cb5c536020d2271fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6457429 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Shahbaz Youssefi a3f2545f 2025-04-11T14:03:08 Tests that exercise overwriting textures while in use The first three tests are credit Cheryl Wei <@arm.com>, adopted from https://chromium-review.googlesource.com/c/angle/angle/+/3366193 The change also exposed the fact that the force_fallback_format with ASTC leads to assertion failure if ASTC emulation is not built. This change adjusts the format table to fix that as well. Bug: angleproject:42265356 Change-Id: Ib68355f317472d8cc3f035b492b273ac452a8217 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6447202 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Igor Nazarov d32c6c03 2025-04-11T15:12:24 Vulkan: Treat present SURFACE_LOST_KHR as OUT_OF_DATE ... when in shared present mode. Handle `VK_ERROR_SURFACE_LOST_KHR` the same way as `VK_ERROR_OUT_OF_DATE_KHR`, because on some platforms (observed on Android) swapchain recreate still succeeds making this error behave the same as OUT_OF_DATE. In case of a real surface lost, following swapchain recreate will also fail, effectively deferring the failure. This will avoid generating swap buffers failure unnecessarily, which may cause abortion of the application. Bug: angleproject:409809766 Change-Id: Ie8abd6b10f160254c94abc0f799195d7414681e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6450580 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Yuxiang Qian a5d750fb 2025-03-25T14:24:19 Add test to check EGL_KHR_platform_android Add an end2end test to check that eglGetPlatformDisplayEXT can use EGL_PLATFORM_ANDROID_KHR to get display. Also, to follow the spec, ValidateGetPlatformDisplayCommon should set EGL_BAD_PARAMETER for unsupported platform. Bug: angleproject:404581995 Change-Id: I20a962adb2dab4434141417b11c959924aff1597 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6369995 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 5dd05578 2025-04-14T07:34:57 Revert "GL: Allow untranslated shaders to pass through on GLES" This reverts commit 4e77552b86a89b449ada6d6c18f84285f5812b1d. Reason for revert: breaks ChromeOS and fuzzers Bug: angleproject:398857482 Original change's description: > GL: Allow untranslated shaders to pass through on GLES > > Add an EGL extension EGL_ANGLE_create_context_passthrough_shaders which > uses the NULL translator and passes the original shader to the driver. > The parser is still used for shader reflection. > > Bug: angleproject:398857482 > Change-Id: I7c5fcc318c7e11931f78c08dcbf4764bf77d397d > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6297527 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Geoff Lang <geofflang@chromium.org> Bug: angleproject:398857482, angleproject:410423936 Bug: chromium:410114655, chromium:410100607, chromium:410121218 Bug: chromium:410052365, chromium:410290507, chromium:410178288 No-Presubmit: true Change-Id: I45b01960637a1cda05d21a7df6d07465f6a8f5e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6448984 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 9554950c 2025-04-14T09:48:39 Roll Chromium from 75621a1b9953 to 95d3d27a122a (1865 revisions) https://chromium.googlesource.com/chromium/src.git/+log/75621a1b9953..95d3d27a122a Set `use_llvm_libatomic = false` per https://chromium-review.googlesource.com/c/chromium/src/+/6402716 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d580cf25e8..22ae602f01 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/dc03d452a6..4f86145940 * buildtools/linux64: git_revision:c0a46c5e8c316010baf1a0eb2d2ee5a86f73e4c2..git_revision:3468d4868725e310eff5f5cd9b6655110883f55b * buildtools/mac: git_revision:c0a46c5e8c316010baf1a0eb2d2ee5a86f73e4c2..git_revision:3468d4868725e310eff5f5cd9b6655110883f55b * buildtools/win: git_revision:c0a46c5e8c316010baf1a0eb2d2ee5a86f73e4c2..git_revision:3468d4868725e310eff5f5cd9b6655110883f55b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b5aac41fd7..e7c83274e2 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/1e8b41f1ec..d3d8cbda8c * third_party/android_build_tools/manifest_merger/cipd: as9uz7sX05xpw-A5S-NU9MbMzlggbUhOfJdarGxMJ84C..w1Huot__EcTrBmzEJxI19VH5MTAP3uJJekb1hR_gL-MC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d4a30bd2e4..df03b99ce9 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3ea4639ac5..323c3f8758 * third_party/fuchsia-sdk/sdk: version:27.20250402.5.1..version:27.20250409.6.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6f6dc922b8..98409c6c09 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/78140a7276..e01dce316d * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/e2e6f2a67e..81e2cb40a7 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/7f56bd496d..f86693f91c * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/de1750a8ce..d93a5a8790 * third_party/r8/cipd: zwFzxlsxS07IH4Ed1SfJTUKKoelP1ZliLtFWZqW0OioC..S1YW2OlP8ThsNUXDptm52Ouvnwp9t9xpTy5LECvEOw4C * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/79d087e955..7dabaa2489 * third_party/siso/cipd: git_revision:0dd559fac7db9d72c9cbee525ab596b8a10b79d0..git_revision:7462aaffc7da5c672efbac0f39e14d3a41862799 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/ce5a169f50..780819f635 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/9b28bb6693..40226a7819 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/374799d778..a7f7a7df1c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/2aa6f329bf..3b0c718c2d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b1212bb2fd..9cf85a5c01 * tools/protoc_wrapper: https://chromium.googlesource.com/chromium/src/tools/protoc_wrapper/+log/dbcbea90c2..8ad6d21544 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/b549758ca9..185329703b No update to Clang. Bug: angleproject:389733590, angleproject:410044007 Change-Id: I5eacd110f477717cd19a87fd287810a9726e373f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6453950 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll e868696a 2025-04-14T10:01:48 Roll vulkan-deps from 5ec40ef70a52 to a24af46b3d3b (14 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/5ec40ef70a52..a24af46b3d3b Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4a038eafdf9e9f3e0ac2e200127df969f3a51ddb..ba1640446f3826a518721d1f083f3a8cca1120c3 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/a871fc43e29038d96109a64a64219eacefdf0634..3f7cbaf327681af51ba65bc83bd1e42ddb9681b2 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/7b6539f24633096c25631bab9fd572bd1ad9b27b..a82b34fb6224e1e5021ddbe56d6d805280e0c740 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/555dca10345cc87918876ff8c55805e54014b6ac..a8f207875c97169e8b7c0a62b25d9a1bc4724432 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/ad2ffcba7b2b3f327dcbcb1f825450d49181b46d..4ee0833a3cdb834aa71c2b77ce5b01235b7b7170 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/4f1db623a61322f5e5c599a09007d855e11a2ef9..3c26a6a93749a6d1290f1c3d08c278ad8910fb8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I3e8bb4ac4572a918ba35bd495c8b2fa01703505b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6454010 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 1664d990 2025-04-14T08:01:43 Roll VK-GL-CTS from ad6225aacbc5 to 76c1572eaba4 (12 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/ad6225aacbc5..76c1572eaba4 2025-04-11 piotr.byszewski@mobica.com Fix Vulkan-Video-Samples build on MSVC 2025-04-10 ziga@lunarg.com Fix uploading images in copies and blitting tests 2025-04-10 rgarcia@igalia.com Make it possible to indicate host intention for allocations 2025-04-10 scerveau@igalia.com VideoDecodeTests: remove video clips from repo 2025-04-10 rgarcia@igalia.com Test multisample layout transition on the compute queue 2025-04-10 joe.withers@imgtec.com Reduce iterations in graphics subgroup tests 2025-04-10 rgarcia@igalia.com Add more commands to conditional rendering ignore tests 2025-04-10 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2 into vk-gl-cts/main 2025-04-10 scerveau@igalia.com video: vvs update revision to main 2025-04-09 lorenzo@khronosgroup.org Merge vk-gl-cts/opengl-cts-4.6.6 into vk-gl-cts/main 2025-04-09 scerveau@igalia.com video: update revision to support CMake 4.0.0 2025-04-08 rgarcia@igalia.com Fix compiler warning on Windows If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: yuxinhu@google.com Change-Id: I7783f3c7e195e63ca23c309a3b51fe69037c5e41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6452972 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 96628296 2025-04-04T00:00:00 Fix GL_OES_texture_3D entry points validation * Added missing checks to the extension entry points to generate proper error messages. * Ensured that the extension entry points are invalid on unextended OpenGL ES 3.x contexts. * Fixed invalid usage of the extension entry points in PLS tests. Fixed: angleproject:409959473 Change-Id: If579e6171751dea1049e1ed85020f485d1e9deb2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6449807 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Geoff Lang 4e77552b 2025-02-24T18:04:32 GL: Allow untranslated shaders to pass through on GLES Add an EGL extension EGL_ANGLE_create_context_passthrough_shaders which uses the NULL translator and passes the original shader to the driver. The parser is still used for shader reflection. Bug: angleproject:398857482 Change-Id: I7c5fcc318c7e11931f78c08dcbf4764bf77d397d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6297527 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Yuxin Hu d5ab1331 2025-04-09T20:26:47 Reland^2 "Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD" This is a reland of 16c852917d0e384fdba780ee6239ab40c3652a7a vkGetPhysicalDeviceProperties2 can be null on devices where VkPhysicalDeviceProperties.apiVersion < VK_API_VERSION_1_1. Even the vkEnumerateInstanceVersion returns VK_API_VERSION_1_1, it doesn't mean the actual device supports VK_API_VERSION_1_1. It only means the loader can handle vulkan instance creaion requests up to VK_API_VERSION_1_1, so we shouldn't assume the device also supports VK_API_VERSION_1_1 and fail vulkan instance creation if vkGetPhysicalDeviceProperties2 is null. Instead, we should proceed with instance creation, and only check vkGetPhysicalDeviceProperties2 is not null when the actual device supports VK_API_VERSION_1_1. Original change's description > On Fuchsia, it is possible that there is no vulkan driver and > vkCreateInstance() triggered VVLDebugUtilsMessenger. > "vkCreateInstance: Found no drivers" is a > VK_DEBUG_UTILS_MESSAGE_TYPE_GENERAL_BIT_EXT message. We should only > care about VK_DEBUG_UTILS_MESSAGE_TYPE_VALIDATION_BIT_EXT message > type. Remove VK_DEBUG_UTILS_MESSAGE_TYPE_GENERAL_BIT_EXT and > VK_DEBUG_UTILS_MESSAGE_TYPE_PERFORMANCE_BIT_EXT from the > VkDebugUtilsMessengerCreateInfoEXT. > Add code to print the VVL message in the log so we know what's wrong. > Add a condition to only assert when the VVL message severity is > VK_DEBUG_UTILS_MESSAGE_SEVERITY_ERROR_BIT_EXT. > Bug: angleproject:407116232 > Change-Id: I1ffc4041368782641fc605366ff7cf03e43eb53f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6435033 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:407116232 Change-Id: I138933a235c4e638fac73559903cf77ecef9159a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6444660 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com>
angle-autoroll 0353ed2e 2025-04-11T10:01:29 Roll vulkan-deps from 792a8d875adc to 5ec40ef70a52 (3 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/792a8d875adc..5ec40ef70a52 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/39f958bcda8ac0cf40fb6924ed34783f5166949d..4f1db623a61322f5e5c599a09007d855e11a2ef9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I4754d4b2101aba61719972673bc9f75e8eab6c0b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6450861 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Kimmo Kinnunen 78048112 2025-01-15T15:13:14 Fix IndexRange::vertexIndexCount calculation Use only one loop. Avoid redundant primitive restart index parameter. Avoid calling GetPrimitiveRestartIndexFromType() because the algorithm relies on the value being numeric_limits<T>::max(). Fixes a bug where primitive restart case would process the value after first primitive restart twice, once in both for loops. This would result in incorrect vertexIndexCount. Fix by removing IndexRange::vertexIndexCount, and instead using IndexRange::mCount == 0 to signify empty range. Bug: angleproject:401284933 Change-Id: Ifaeb9949f2e852fb7c5ef80bc47f72bfabba21a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6333541 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> Commit-Queue: Kimmo Kinnunen <kkinnunen@apple.com>
Yuxin Hu 1c0bcb06 2025-04-08T18:42:43 Reformat VVL error angleproject:42265363: dead_by_daylight hits the VVL error covered by another entry in the skip list. Move the dead_by_daylight comment above the other entry. angleproject:42265427: VVL error added to the skip list in this bug still occurs on blade_and_soul_revolution and FramebufferFetch* tests. Change the VVL error message to use the new formats: remove the messageContents1 and messageContents2, and add more extraProperties. Bug: angleproject:42265363 Bug: angleproject:42265427 Change-Id: Ie913a7345b9f16580507894edd4a2befa29e9418 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6442305 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Liza Burakova 3dcf109d 2025-04-10T17:19:09 WebGPU: Refactor syncClientArrays. This change adds a few helper methods for syncClientArrays to improve readability Bug: angleproject:401499251 Change-Id: Ida427f80e07f469b83ff12850169b2110e65743c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6441946 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev 595d79e4 2025-04-04T00:00:00 Do not expose GL_ARB_sync That extension does not exist in OpenGL ES. Fixed: angleproject:409717088 Change-Id: I82234f0051c2c646ef15c22e1a0da1704ef3a35b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6448233 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Alexey Knyazev b81b7115 2025-04-04T00:00:00 Fix entry point replacements in TracePerfTest The same entry point name, including its suffix, must be used when replacing command arguments for perf testing to avoid validation errors. Fixed: angleproject:409576882 Change-Id: I076f476a7fec3fcd6a6d5e59016a67bf2cdc1aa5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6446633 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Alexey Knyazev cb60429d 2025-04-04T00:00:00 Fix BlitFramebuffer entry point validation * Fixed validation for BlitFramebufferNV and BlitFramebuffer (ES 3.0). * Updated tests. Fixed: angleproject:409579363 Change-Id: I11ef69433a5ae947c0deb069bd0abfa0144e9661 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6444471 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Igor Nazarov ce394c49 2025-04-10T10:33:57 Vulkan: Fix undefined behavior accessing empty vertex buffer This fixes undefined behavior detected by VVL: [ SYNC-HAZARD-READ-AFTER-WRITE ] vkCmdDraw(): READ_AFTER_WRITE hazard detected. vkCmdDraw reads vertex VkBuffer 0xe000000000e, which was previously written by vkCmdBeginRenderingKHR. No sufficient synchronization is present to ensure that a read (VK_ACCESS_2_VERTEX_ATTRIBUTE_READ_BIT) at VK_PIPELINE_STAGE_2_VERTEX_ATTRIBUTE_INPUT_BIT does not conflict with a prior write (VK_ACCESS_2_COLOR_ATTACHMENT_WRITE_BIT) at VK_PIPELINE_STAGE_2_COLOR_ATTACHMENT_OUTPUT_BIT. This is regression from the old CL: https://crrev.com/c/angle/angle/+/3297026 Vulkan: Don't attempt to convert vertices in empty buffers Above change made `if (bufferVk->getSize() == 0)` branch a dead code. In the current code this branch is `if (numVertices == 0)` and is no longer a dead code. It sets zero stride to prevent reading beyond the empty buffer (which is only 16 bytes). This fix also sets `mCurrentArrayBufferStrides[attribIndex]` to zero when it is not a streaming attribute (in case of zero sized buffer). Bug: chromium:1271671 Change-Id: I3460201ae7366b8de1089efef6fbefe359d28460 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6440439 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
angle-autoroll 3e189bda 2025-04-10T11:30:19 Roll vulkan-deps from c8554b0ea83f to 792a8d875adc (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/c8554b0ea83f..792a8d875adc Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/8a466340c0b1477cb5413c3665172fd3b9da2f1f..5af16f4e8ffb7b72807ead08f995c33933e20d61 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/8e82b7cfeca98baae9a01a53511483da7194f854..7c2f5333e9c662620581361dffc327a99800bb52 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/e940239220e38bd5179c26bf43092cc807dfe6fe..a871fc43e29038d96109a64a64219eacefdf0634 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/2b23c202d275793f067b1e3821f42eb24edeaa5c..39f958bcda8ac0cf40fb6924ed34783f5166949d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I7fa7498608976977864181abec10d03c05c27417 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6444996 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu 02fb04a8 2025-04-09T18:36:35 Revert "Reland "Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD"" This reverts commit 16c852917d0e384fdba780ee6239ab40c3652a7a. Reason for revert: causes Chromium Android FYI Release (Nexus 5X) tests failures: https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20FYI%20Release%20(Nexus%205X)/77632/overview Original change's description: > Reland "Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD" > > This is a reland of 3f028fc158fac948723e8d535463eb80d0a85fed. > > On Fuchsia, it is possible that there is no vulkan driver and > vkCreateInstance() triggered VVLDebugUtilsMessenger. > "vkCreateInstance: Found no drivers" is a > VK_DEBUG_UTILS_MESSAGE_TYPE_GENERAL_BIT_EXT message. We should only > care about VK_DEBUG_UTILS_MESSAGE_TYPE_VALIDATION_BIT_EXT message > type. Remove VK_DEBUG_UTILS_MESSAGE_TYPE_GENERAL_BIT_EXT and > VK_DEBUG_UTILS_MESSAGE_TYPE_PERFORMANCE_BIT_EXT from the > VkDebugUtilsMessengerCreateInfoEXT. > > Add code to print the VVL message in the log so we know what's wrong. > > Add a condition to only assert when the VVL message severity is > VK_DEBUG_UTILS_MESSAGE_SEVERITY_ERROR_BIT_EXT. > > Original change's description: > > Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD > > > > This helps catching bugs for vulkan calls issued > > during GetSystemInfoVulkanWithICD(). > > > > Also changed getProc() function to get vulkan function pointers by > > calling vkGetInstanceProcAddr(), instead of calling dlsym(). Only use > > dlsym() to get vkGetInstanceProcAddr() function pointer. > > > Bug: angleproject:407116232 > > Change-Id: I14dce3453c76a084db63fdb45a3db07b7b4d5294 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6374305 > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: Charlie Lao <cclao@google.com> > > Commit-Queue: Yuxin Hu <yuxinhu@google.com> > > Bug: angleproject:407116232 > Change-Id: I1ffc4041368782641fc605366ff7cf03e43eb53f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6435033 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:407116232 Bug: chromium:409350833 Change-Id: I29aa9e450180857a993459da8f210df7aad9afaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6444658 Auto-Submit: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuxin Hu 01c5100a 2025-04-09T18:34:22 Revert "Change the VVL missing log from WARN() to INFO()" This reverts commit f680e1074ba5713d79affe6f69640e531a6f13a3. Reason for revert: this is part of the cl chain that causes chromium CI to fail: https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20FYI%20Release%20(Nexus%205X)/77632/overview Original change's description: > Change the VVL missing log from WARN() to INFO() > > On certain chromium Android CI, VK_LAYER_KHRONOS_validation layer > is missing, and WARN() message causes tests to fail: > https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20FYI%20Release%20(Nexus%205X)/77567/infra > > Bug: chromium:409350833 > Change-Id: I16f85d73ad41f81a40cc25b1a80ee14fd772a78e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6442304 > Auto-Submit: Yuxin Hu <yuxinhu@google.com> > Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bug: chromium:409350833 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ie3d38a9532d49cf9e9c006cf933d42e68356a4b3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6444751 Auto-Submit: Yuxin Hu <yuxinhu@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Yuxin Hu 33105b96 2025-04-09T18:31:59 Revert "Limit use of vkEnumerateInstanceVersion to VK_VERSION_1_1" This reverts commit a6b915706ad9cd65192e0ca78f14bd6593f9789d. Reason for revert: still causing chromium Android CI failures: https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20FYI%20Release%20(Nexus%205X)/77632/overview Original change's description: > Limit use of vkEnumerateInstanceVersion to VK_VERSION_1_1 > > On devices where vulkan 1.1 is not supported, calling > vkGetInstanceProcAddr(VK_NULL_HANDLE, "vkEnumerateInstanceVersion") > results in error: > > invalid vkGetInstanceProcAddr(VK_NULL_HANDLE, > "vkEnumerateInstanceVersion") call. > > Limit > vkGetInstanceProcAddr(VK_NULL_HANDLE, "vkEnumerateInstanceVersion") > to VK_VERSION_1_1. > > Bug: chromium:409350833 > Change-Id: I313585b133967d32fba597013dcfa846609b0f74 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6443937 > Commit-Queue: Yuxin Hu <yuxinhu@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Auto-Submit: Yuxin Hu <yuxinhu@google.com> Bug: chromium:409350833 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I28f4f70638c1a92fbc139f8436e995e27aa9a7c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6444657 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Amirali Abdolrashidi 4f450985 2025-04-09T14:34:01 Skip 3D texture unpack test on Mac * Skipped the following test on the Mac bots (for AMD): Texture3DTestES3.PixelUnpackParamsChangeTexImage/ES3_OpenGL * Example of error on the bots: https://ci.chromium.org/ui/p/angle/builders/ci/mac-exp-test/2475 Bug: angleproject:406566447 Change-Id: Iea584dd8526ac1773c6a0bd22ea8ad3e1ef05b14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6444358 Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Matthew Denton f4ff9241 2025-04-08T14:37:08 WGPU: add utils for converting between GLSL and WGSL types ...specifically those related to textures and samplers. Bug: angleproject:389145696 Change-Id: If3bec56b70c04443928ef0d4e1e1a40b5c578cc0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6441818 Reviewed-by: Liza Burakova <liza@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Shahbaz Youssefi f7d58b0c 2025-04-09T15:38:52 Vulkan: Report deviceName in GPU properties Bug: chromium:371512561 Change-Id: Ifd52acf2a5e550b9d2f2222e5e986e6df66611c3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6440095 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuxin Hu a6b91570 2025-04-09T10:36:23 Limit use of vkEnumerateInstanceVersion to VK_VERSION_1_1 On devices where vulkan 1.1 is not supported, calling vkGetInstanceProcAddr(VK_NULL_HANDLE, "vkEnumerateInstanceVersion") results in error: invalid vkGetInstanceProcAddr(VK_NULL_HANDLE, "vkEnumerateInstanceVersion") call. Limit vkGetInstanceProcAddr(VK_NULL_HANDLE, "vkEnumerateInstanceVersion") to VK_VERSION_1_1. Bug: chromium:409350833 Change-Id: I313585b133967d32fba597013dcfa846609b0f74 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6443937 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Auto-Submit: Yuxin Hu <yuxinhu@google.com>
Alexey Knyazev 76561acc 2025-04-04T00:00:00 Fix use of OpenGL ES 3.2 commands in tests Fixed tests that used OpenGL ES 3.2 commands instead of extensions when running on lower context versions. Bug: angleproject:409484297 Change-Id: I1d032a8ed4df429e564c24321101b4dfcd5d1ba8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6441554 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Shahbaz Youssefi 02ae054c 2025-04-07T13:48:29 Translator: Fix init of inactive output variables Bug: chromium:398401939 Change-Id: I0df494b945b8d0e805a62cf7645d06bf233f36ca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6438495 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Jiaqi Li a6f44806 2025-04-01T17:30:53 Wrong condition to call copyBufferDataToImage In function copyBufferDataToImage, it call vulkan vkCopyBufferToImage directly. To call copyBufferDataToImage directly, it needs that there's no overlap when copy. If mImage is not valid, it will assert in mImage->getActualFormatID(). Need to check its validation at beginning. Bug: angleproject:406566447 Change-Id: I875c2a97bec52251b9c5b3d196466e8bf5ce662d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6400313 Auto-Submit: Jiaqi Li <Jiaqi.Li@arm.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Yuly Novikov 1ee585fd 2025-04-09T10:03:26 Rename ANGLE S22 builders to S24 Also start targeting S24 phones on the new builders. Bug: angleproject:394893136 Change-Id: I50496a5a5b114034bccf326001aa8ebc8a601398 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6439516 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 1cc059ef 2025-04-09T10:01:56 Roll vulkan-deps from d04dafb08ac6 to c8554b0ea83f (13 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/d04dafb08ac6..c8554b0ea83f Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/938eedb181975417efef1657784b4e15092de9f0..8a466340c0b1477cb5413c3665172fd3b9da2f1f https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/1a811fd69871da36d9cca84586d8a7799be893ec..e940239220e38bd5179c26bf43092cc807dfe6fe https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/59dc56aa3023434317a5197d77be51855b5fd2fb..555dca10345cc87918876ff8c55805e54014b6ac https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/abc2498bde8d65841f463431a6220701fad44c64..ad2ffcba7b2b3f327dcbcb1f825450d49181b46d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6ebe2666e8d9ec374657066d0834560ed8551acc..2b23c202d275793f067b1e3821f42eb24edeaa5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I5d56e8d3c8cf5aa3eeac7f7738b9ccf78df85211 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6443130 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 3a12660e 2025-04-09T07:00:22 Roll Chromium from b61baca1a417 to 75621a1b9953 (584 revisions) https://chromium.googlesource.com/chromium/src.git/+log/b61baca1a417..75621a1b9953 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/95794d6fdc..d580cf25e8 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9f61cc436c..dc03d452a6 * buildtools/linux64: git_revision:6e8e0d6d4a151ab2ed9b4a35366e630c55888444..git_revision:c0a46c5e8c316010baf1a0eb2d2ee5a86f73e4c2 * buildtools/mac: git_revision:6e8e0d6d4a151ab2ed9b4a35366e630c55888444..git_revision:c0a46c5e8c316010baf1a0eb2d2ee5a86f73e4c2 * buildtools/win: git_revision:6e8e0d6d4a151ab2ed9b4a35366e630c55888444..git_revision:c0a46c5e8c316010baf1a0eb2d2ee5a86f73e4c2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/803e127f59..b5aac41fd7 * third_party/android_build_tools/manifest_merger/cipd: MBIQRTQ6FavhzrjRrKgZHXpedUncW5cLxVQjYvkSnHgC..as9uz7sX05xpw-A5S-NU9MbMzlggbUhOfJdarGxMJ84C * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/afb0c8b908..3ea4639ac5 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/c79b6718f6..6f6dc922b8 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/94c5d7a8ed..78140a7276 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/6df4308a5d..7f56bd496d * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/d05fde5052..79d087e955 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/57194cae87..9b28bb6693 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/d1eb0d45b5..b1212bb2fd No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: Ie36bb5ac111ed27c047f514e27806564d4b522a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6442785 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Yuxin Hu f680e107 2025-04-08T16:22:29 Change the VVL missing log from WARN() to INFO() On certain chromium Android CI, VK_LAYER_KHRONOS_validation layer is missing, and WARN() message causes tests to fail: https://ci.chromium.org/ui/p/chromium/builders/ci/Android%20FYI%20Release%20(Nexus%205X)/77567/infra Bug: chromium:409350833 Change-Id: I16f85d73ad41f81a40cc25b1a80ee14fd772a78e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6442304 Auto-Submit: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Yuxin Hu a0a5c565 2025-04-07T15:05:11 Vulkan: Add assert to check only clear is staged on swapchain image The swap after clear optimizations on swapchain image multisampled image https://chromium-review.googlesource.com/c/angle/angle/+/6072416 works with the assumption that the only staged updates on swapchain multisampled image is clear. This change adds an assert to validate the assumption holds true before applying the optimization. If the assert is ever triggered, we will know the assumption is violated, and we need to look into how to tweak the optimization or add other optimizations to solve the violated case. Bug: angleproject:382006939 Change-Id: I7ce23dd7767b7730f1fa3ec89cb6616689339602 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6437217 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Cody Northrop 3207b535 2025-04-08T12:50:19 Tests: Skip new denorm test on Pixel 6 Test: GLSLTest_ES3.DenormFloatsToIntValues Bug: b/406827038 Change-Id: I9202e750dc5f80f1ed0d9c2153cdc2c73b72c1d2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6441469 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Dirk Pranke 3d3188e0 2025-04-08T10:11:17 Remove exec_script_whitelist from dotfile_settings.gni. All of the clients of this file have been updated to use exec_script_allowlist, so we no longer need to set exec_script_whitelist as well. Bug: chromium:389986807 Change-Id: Ifb5ce794e4329b54e5a91ca658c41ce9ba038c4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6441919 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
Roman Lavrov 2fcd88e1 2025-04-08T09:30:59 Tests: order bot mode batch configs alphabetically Currently ordered by hashmap key ordering which shuffles the order even with --max-processes=1. Adding a sort to make this deterministic. Bug: angleproject:408276172 Change-Id: Ice96e350ba4247a1f40870e275d04d2f654bc4f5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6438024 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Yuly Novikov 8424dd22 2025-04-08T13:39:59 Suppress end2end test on iOS Metal PixelLocalStorageTest.FlushFinishSync added in https://chromium-review.googlesource.com/c/angle/angle/+/6427324 Bug: angleproject:40096838 Change-Id: Ibd357a357823e757c71c0d4527db774f721b28f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6440285 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov 1a1978fd 2025-04-08T13:29:12 Suppress dEQP-GLES2.functional.debug_marker.random on Linux SwANGLE Bug: angleproject:42266920 Change-Id: Ib45f9c6f5c64c6fab5310f8ea24b5da308097c66 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6439421 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop d27a1fd0 2025-04-03T19:59:20 Compiler: Allow denorm float values in the lexer This adds an option to preserve denorm values in the lexer, skipping the explicit zero conversions for below range floats. There are applications in the wild that expect to be able to use denorm float values. They are typically immediately converted to integer values, not used in floating point operations. The option is only enabled for Vulkan backends. Test: FloatLexTest, DenormFloatsToIntValues, app traces Bug: b/406827038 Change-Id: Iab5a1a69a540b78ccbce8ea90b532d2d4976e29e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6432237 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll c0f30251 2025-04-08T10:01:12 Roll vulkan-deps from fb4fe29989cb to d04dafb08ac6 (11 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/fb4fe29989cb..d04dafb08ac6 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/LunarG/VulkanTools/+log/54eddbe9fcf33a6b5e77b8044f332cea872fc704..938eedb181975417efef1657784b4e15092de9f0 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/b8eb2b901835497b91db7bd7005f4d6ddba2bf1e..7b6539f24633096c25631bab9fd572bd1ad9b27b https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/289efccc7560f2b970e2b4e0f50349da87669311..59dc56aa3023434317a5197d77be51855b5fd2fb https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/01851ecae564f8d3da0123659c26a2f5bbfc0228..abc2498bde8d65841f463431a6220701fad44c64 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/6f9d2d358f9585bbd302106e7b5b8135cb19f716..6ebe2666e8d9ec374657066d0834560ed8551acc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I22133cbf1c9d17c59ba3eef0a841bf0633788da8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6441103 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 998ed587 2025-04-08T03:01:13 Roll SwiftShader from 4982425ff1bd to 2b323370501c (1 revision) https://swiftshader.googlesource.com/SwiftShader.git/+log/4982425ff1bd..2b323370501c 2025-04-07 swiftshader.regress@gmail.com Regres: Update test lists @ 4982425f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Use-Permissive-Angle-Pixel-Comparison: True Change-Id: Ic305fb6c9183e445b91c8c099475585870d7483f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6440521 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 48b7d12e 2025-04-08T07:58:50 Roll Chromium from 6a2660221a4c to b61baca1a417 (683 revisions) https://chromium.googlesource.com/chromium/src.git/+log/6a2660221a4c..b61baca1a417 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/38290a4010..95794d6fdc * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5ed32accde..9f61cc436c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/df390a2691..803e127f59 * third_party/android_build_tools/error_prone/cipd: muHOjW6H-gb8j6gY4sUylWC1paxyWPRMAeYZ1Ok8KkwC..ZK9e0tqXwlyM9VSS1O09u8kkCtk-SfKOTtSXyAq22-UC * third_party/android_build_tools/lint/cipd: cpi5krkjlhoCfjDOZ3fIdPXDOqnCGMBVzm_yHg1WnWUC..vBqKHQdjLFM5l79fpi3L9l7kD9b1FfeyfWbIFjXShSgC * third_party/android_build_tools/manifest_merger/cipd: vHfVYpJ8u72iZgoN6s-BvRweZgVkKP-j_QbT8eSgc3gC..MBIQRTQ6FavhzrjRrKgZHXpedUncW5cLxVQjYvkSnHgC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/f14985b465..d4a30bd2e4 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c8d1e18466..afb0c8b908 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/4e8b01e3c1..c79b6718f6 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/aa5c758d87..6df4308a5d * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/f2622a898c..de1750a8ce * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/09ef5722d8..d05fde5052 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/de3df440c0..57194cae87 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/951584ca07..374799d778 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4f2c56de67..d1eb0d45b5 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/7cdd3d9540..b549758ca9 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: If2dbea035f1d435e3200025b67c5661af42763bd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6440806 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev cbd6cdc9 2025-03-28T00:00:00 Ensure CopyTexImageParameters validation consistency * Validation must succeed for no-op commands. * Moved no-op conditions handling to the Context. Bug: angleproject:406922380 Change-Id: I9102955198b755844d05c0c4f07832664ff24100 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6439412 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 6e992fa2 2025-03-28T00:00:00 Ensure consistency of context lost aware validation Some commands must generate CONTEXT_LOST but still return a value. Moved error generation to the Context to ensure validation consistency. Bug: angleproject:406922380 Change-Id: Ie5dae39bada951366afb86cab4324f2247c84ab7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6433684 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Yuxin Hu 16c85291 2025-03-19T18:15:43 Reland "Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD" This is a reland of 3f028fc158fac948723e8d535463eb80d0a85fed. On Fuchsia, it is possible that there is no vulkan driver and vkCreateInstance() triggered VVLDebugUtilsMessenger. "vkCreateInstance: Found no drivers" is a VK_DEBUG_UTILS_MESSAGE_TYPE_GENERAL_BIT_EXT message. We should only care about VK_DEBUG_UTILS_MESSAGE_TYPE_VALIDATION_BIT_EXT message type. Remove VK_DEBUG_UTILS_MESSAGE_TYPE_GENERAL_BIT_EXT and VK_DEBUG_UTILS_MESSAGE_TYPE_PERFORMANCE_BIT_EXT from the VkDebugUtilsMessengerCreateInfoEXT. Add code to print the VVL message in the log so we know what's wrong. Add a condition to only assert when the VVL message severity is VK_DEBUG_UTILS_MESSAGE_SEVERITY_ERROR_BIT_EXT. Original change's description: > Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD > > This helps catching bugs for vulkan calls issued > during GetSystemInfoVulkanWithICD(). > > Also changed getProc() function to get vulkan function pointers by > calling vkGetInstanceProcAddr(), instead of calling dlsym(). Only use > dlsym() to get vkGetInstanceProcAddr() function pointer. > Bug: angleproject:407116232 > Change-Id: I14dce3453c76a084db63fdb45a3db07b7b4d5294 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6374305 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Charlie Lao <cclao@google.com> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bug: angleproject:407116232 Change-Id: I1ffc4041368782641fc605366ff7cf03e43eb53f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6435033 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 79832ea3 2025-04-07T10:33:17 Revert "Suppress 5 dEQP EGL tests on Pixel 6 Vulkan" This reverts commit 87950668c45a0b5df6045d750afd4fd3c0502be2. Reason for revert: should be fixed by https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/9860 Original change's description: > Suppress 5 dEQP EGL tests on Pixel 6 Vulkan > > Report VUID-vkGetDeviceFaultInfoEXT-device-07336 after VVL roll > https://chromium-review.googlesource.com/c/angle/angle/+/6430461 > > Bug: angleproject:408225528 > Change-Id: I5208e5b4a8eea598feb0a155a6dadb3e1e722143 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6432451 > Auto-Submit: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bug: angleproject:408225528 Change-Id: Ie832e7cb6856184e51a26d27c372753e2e597137 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6439031 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Geoff Lang 0e28c030 2025-04-02T17:26:28 ScalarizeVecAndMatConstructorArgs on WGSL shaders. WGSL does not support mixing types in the constructors of vectors and matrices. Use the ScalarizeVecAndMatConstructorArgs traverser to scalarize these constructors and update it to cast to the destination type if the inputs are not in that type already. Bug: angleproject:395659799 Change-Id: I4c270f2b18e79393e3c187916f33ad719bc88a63 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6427067 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Chris Dalton 0f356a34 2025-04-02T14:14:43 Update invalidation commands to disable PLS Previously, commands that flush or invalidate tiled memory were specified to generate an error if issued while PLS was active. Remove all provisions around Flush(), Finish() and ClientWaitSync(), and add a test to ensure these commands have no effect on PLS. The reason we can make this change now is because we no longer support EXT_shader_pixel_local_storage, which previously prevented us from allowing these 3 commands. Update the invalidation commands to disable PLS instead. This is more in line with the general design pattern of PLS. Update the wording of the spec to reflect this better organization. Also clean up some legacy code that was no longer used. Bug: angleproject:40096838 Change-Id: I9687deaf17a583f8757ffcd050eda154b4e7a949 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6427324 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Chris Dalton <chris@rive.app> Reviewed-by: Kenneth Russell <kbr@chromium.org>
Roman Lavrov 1593390b 2025-04-07T11:22:21 Increase ANGLE_LIKELY/UNLIKELY probability to 99.99% I can't find the exact value for clang, but according to GCC docs __builtin_expect probability is assumed to be only 90%. When we actually bother to use ANGLE_LIKELY we mean "almost always", so this value can be much higher. Setting to 99.99% because lower values don't seem to trigger the optimization below (at least 99.9% doesn't) __builtin_expect already enables some optimizations such as moving unlikely branches (e.g. cold function calls) out of the primary flow. Increasing the probability enables more aggressive optimizations such as making those function calls store/load registers only in the rare cases when this call is made - which allows the rest of the caller to be made more efficient by not having to handle these register changes. Example: stur w4, [x29, #-0xc] stur x8, [x29, #-0x8] str x3, [sp, #0x8] stp w2, w1, [x29, #0x18] bl 0x356fdc <_ZNK2gl7Context25getActiveLinkedProgramPPOEv> ldp w2, w1, [x29, #0x18] ldr x3, [sp, #0x8] ldur w4, [x29, #-0xc] ldur x8, [x29, #-0x8] Bug: b/383305597 Change-Id: I077f4f2cb90cfb8282409d12adcb02c3302e7761 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6437572 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Dave Tapuska 1b92a973 2025-04-04T11:20:02 [ios blink] Add arm64e cpu target Add arm64e cpu target to angle. Bug: chromium:40254930 Change-Id: Iae9418c7e068fecde08ff6e93ed0c7e2ae65da97 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6431489 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
angle-autoroll 768c1744 2025-04-07T10:01:11 Roll vulkan-deps from f8cc64f338fb to fb4fe29989cb (15 revisions) https://chromium.googlesource.com/vulkan-deps.git/+log/f8cc64f338fb..fb4fe29989cb Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c3d39de93955f884e443c39e9ffecf86e4aac883..4a038eafdf9e9f3e0ac2e200127df969f3a51ddb https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/4bd1536ed79003a5194a4bd8c9aa2fa17a84c15b..1a811fd69871da36d9cca84586d8a7799be893ec https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/2ac81691baf291e7f4aad07596d7073974dbc4dd..5ceb9ed481e58e705d0d9b5326537daedd06b97d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader/+log/723d6b4aa35853315c6e021ec86388b3a2559fae..b8eb2b901835497b91db7bd7005f4d6ddba2bf1e https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/551221d913cc56218fcaddce086ae293d375ac28..01851ecae564f8d3da0123659c26a2f5bbfc0228 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers/+log/5c62066bdf33a51ba8481ff16270f543c1f10076..6f9d2d358f9585bbd302106e7b5b8135cb19f716 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: Ia2fff692792aaf37e390a6f558c4bdb7e95ae85e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6437469 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll c59c745a 2025-04-07T08:01:03 Roll VK-GL-CTS from b6bb4bab7b4a to ad6225aacbc5 (12 revisions) https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/b6bb4bab7b4a..ad6225aacbc5 2025-04-04 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2 into vk-gl-cts/main 2025-04-04 ziga@lunarg.com Add tests using VK_IMAGE_LAYOUT_GENERAL and global memory barriers 2025-04-03 rgarcia@igalia.com Test counterOffset in vkCmdDrawIndirectByteCountEXT 2025-04-03 jasuarez@igalia.com Reduce mismatch reporting on failing tests 2025-04-03 piotr.byszewski@mobica.com Add two tests for partially-resident sparse buffers 2025-04-03 rgarcia@igalia.com Fix duplicate structures in pNext chain 2025-04-03 zzoon@igalia.com Fix validation errors in dEQP-VK.video.decode.av1.allintra_nosetup_8_separated_dpb 2025-04-03 mateusz.bahyrycz@mobica.com Replace vkCmdBlitImage() with vkCmdCopyImage() 2025-04-03 lorenzo@khronosgroup.org Merge vk-gl-cts/vulkan-cts-1.4.2 into vk-gl-cts/main 2025-04-03 lorenzo@khronosgroup.org Merge remote-tracking branch 'vk-gl-cts/dev/VK_EXT_present_mode_fifo_latest_ready' into main 2025-04-01 zzoon@igalia.com Fix a crash in Vulkan Video encoding tests. 2025-04-01 ziga@lunarg.com Fix lambda captures in pipeline depth tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: abdolrashidi@google.com Change-Id: I365d2fe0bac134857ff56c81b912851ca6f5d041 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6437073 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
angle-autoroll 0feb9ed6 2025-04-07T07:02:39 Roll Chromium from f748acbd614f to 6a2660221a4c (648 revisions) https://chromium.googlesource.com/chromium/src.git/+log/f748acbd614f..6a2660221a4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC abdolrashidi@google.com,angle-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/303d67a359..38290a4010 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/f2adf9050d..5ed32accde * testing: https://chromium.googlesource.com/chromium/src/testing/+log/67e802f7d1..df390a2691 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/df9b88b552..c8d1e18466 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/7f8f85ae73..4e8b01e3c1 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/16e46844a2..aa5c758d87 * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/acc2c0d4d0..09ef5722d8 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/d42377337b..de3df440c0 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/eda5b50d9f..951584ca07 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/7a5268f3f2..4f2c56de67 No update to Clang. Bug: None Tbr: abdolrashidi@google.com Change-Id: I686e458d71d0352c9c1d18550d577ec7af2a1828 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6435966 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Alexey Knyazev 84056594 2025-03-28T00:00:00 Ensure ValidateCopyTextureCHROMIUM consistency Moved ValidImageSizeParameters out of IsValidCopyTextureDestinationLevel to not generate two errors for a single command call. Bug: angleproject:406922380 Change-Id: Ie96e1c51743d5973f258a49aa2613d72b47e1bfb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6433915 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alexey Knyazev 01d1c7b4 2025-03-28T00:00:00 Ensure EXT_debug_marker validation consistency * Moved no-op conditions handling to the Context. * Removed redundant comments. Bug: angleproject:406922380 Change-Id: I1064312b2e5940d6b97c95f22544bbc9749fc1ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6433224 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Alex Dean 3818d37d 2025-04-04T15:07:59 CL: Add end_capture to capture/replay tool Many different applications don't explicitly make it clear the ending frame of what's being run. With the end_capture utility, when the user sets end_capture to 0, the application automatically finishes the capture immediately. Example OpenCL applications where this is useful: AI-Benchmark, Geekbench Compute, Geekbench AI Bug: angleproject:402174922 Change-Id: I1710ae1b1703f710865a9862c4cf3de753c2ccbd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6339791 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Alexey Knyazev 2a4ea88e 2025-03-28T00:00:00 Simplify CopyImageSubData validation * Removed duplicated switch cases. * Reduced the number of enum conversions. * Used correct error message. Bug: angleproject:42262256 Change-Id: If686b5a0a0b29884b6b5c655df130f6ad918a61a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6433680 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Roman Lavrov 5462a528 2025-04-04T15:12:01 Add "likely" hints to glDrawElements validation ValidateDrawStates in particular is large (almost 3KB assembly), this appears to make a difference in synthetic benchmarks on Android. Bug: b/383305597 Change-Id: I4fd07d7080da70e370947b971e61f6d36c293c42 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6431272 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Shahbaz Youssefi c9e90490 2025-03-27T18:26:19 Capture: Keep binary data in memory in chunks This is needed for taking large captures out of Chromium, because its memory allocator refuses to allocate objects bigger than 1~2GB. Incidentally, it also optimizes taking large captures by avoiding frequent calls to `vector::resize` while the vector is very large. Bug: b/381284577 Change-Id: I4ccd3c8ea50df59520334f70e99083847da20c9f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6406214 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Yuxin Hu 7d4c77b9 2025-04-04T11:15:51 Revert "Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD" This reverts commit 3f028fc158fac948723e8d535463eb80d0a85fed. Reason for revert: triggering asserts in fuchsia tests: https://crrev.com/c/6431747 Original change's description: > Enable VVL on vulkan instance created in GetSystemInfoVulkanWithICD > > This helps catching bugs for vulkan calls issued > during GetSystemInfoVulkanWithICD(). > > Also changed getProc() function to get vulkan function pointers by > calling vkGetInstanceProcAddr(), instead of calling dlsym(). Only use > dlsym() to get vkGetInstanceProcAddr() function pointer. > > Bug: angleproject:407116232 > Change-Id: I14dce3453c76a084db63fdb45a3db07b7b4d5294 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6374305 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Charlie Lao <cclao@google.com> > Commit-Queue: Yuxin Hu <yuxinhu@google.com> Bug: angleproject:407116232 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic81ebf77f3519cb6a4365dc57ea7753867ae086c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6433022 Auto-Submit: Yuxin Hu <yuxinhu@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
Igor Nazarov f798b0d2 2025-04-04T08:17:57 Vulkan: Remove enablePreRotateSurfaces feature Removed to simplify the code and to avoid the problem for which `presentSubOptimalReturnedOnTransformChange` feature was added. Platforms without the per-rotation support always have `VK_SURFACE_TRANSFORM_IDENTITY_BIT_KHR` as the `currentTransform`, so the code will perform the same as when the feature was disabled. Add `warmUpPreRotatePipelineVariations` to explicitly control per-rotation pipeline warm up. Bug: angleproject:42262166 Change-Id: I44f6c221c11105f01f62f62622987b1955bc58aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6433586 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
Igor Nazarov b77f8af7 2025-04-02T19:01:48 Vulkan: Ignore SUBOPTIMAL on Android without pre-rotate Android returns `VK_SUBOPTIMAL_KHR` when window orientation changes, while ignores size changes. When "enablePreRotateSurfaces" is disabled, each present will return `VK_SUBOPTIMAL_KHR` if `currentTransform` is not `VK_SURFACE_TRANSFORM_IDENTITY_BIT_KHR`, causing swapchain recreate on each swap. This behavior makes disabling "enablePreRotateSurfaces" on Android worse than suboptimal. New "presentSubOptimalReturnedOnTransformChange" feature is currently enabled only on Android for the reason described above. It may be enabled for other platforms in the future if required. Change also improves error handling, by moving `deferAcquireNextImage()` call right after the `queuePresent()`, before any other call that may fail. This will avoid repeated present of the same image if something fails after successful `queuePresent()` call. The `checkForOutOfDateSwapchain()` and `computePresentOutOfDate()` was combined into a single method to improve error handling and to simplify the code. Bug: angleproject:397848903 Bug: angleproject:42266082 Bug: angleproject:42262166 Change-Id: I7ba2389ad2ddafc0c77c3068cd85ac9b9251ccdd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6424753 Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com>
Roman Lavrov 12dd42b8 2025-04-04T09:54:12 Reduce number of function calls in glVertexAttribPointer Small but noticeable improvement in a synthetic test on Android Bug: b/383305597 Change-Id: I6e88a06f4d3bf2e0b51ee1fd3f4f26bf55d9364e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6432611 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Yuly Novikov 9e3467c8 2025-04-04T09:58:05 Run end2end tests single process on Linux Intel Multi-process suspected for flaky WebGPU backend test failures. Bug: angleproject:408276172 Change-Id: I2813d49f1263eeefea7db6999b5452d4cf61db92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6432449 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
angle-autoroll 0a61aa4a 2025-04-04T09:50:59 Roll Chromium from 7d6c9811c3ae to f748acbd614f (650 revisions) Set 'android_static_analysis = "on"' GN args explicitly on Android bots (this was the default before). https://chromium.googlesource.com/chromium/src.git/+log/7d6c9811c3ae..f748acbd614f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,romanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/26ff83f048..303d67a359 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4b3b2242db..f2adf9050d * testing: https://chromium.googlesource.com/chromium/src/testing/+log/576e7554b9..67e802f7d1 * third_party/android_build_tools/manifest_merger/cipd: CsU9U9KptiCc6Y9kUTfQfM4CWrRw4W_SxhOt6SNdf7MC..vHfVYpJ8u72iZgoN6s-BvRweZgVkKP-j_QbT8eSgc3gC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d69d75e4f8..f14985b465 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8010a1b2f5..df9b88b552 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/723abbda20..7f8f85ae73 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/4b760d9a76..16e46844a2 * third_party/r8/cipd: lg4ep5S4K6V2zni9jgt42ga6U-8AR6aAWNSqbe2VdmoC..zwFzxlsxS07IH4Ed1SfJTUKKoelP1ZliLtFWZqW0OioC * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/76986168fd..acc2c0d4d0 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/788cb3c270..ce5a169f50 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/a1531f6aae..d42377337b * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d05ab7b5b9..eda5b50d9f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/98c476af7d..2aa6f329bf * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/4faaa52ad8..7a5268f3f2 * tools/skia_goldctl/mac_amd64: Ody7aR8OnFLweRhMIL774WL6ph95_ZTz9It5m9bzo8sC..yNIr-9hJd-v5rwyRRQk5z9eBz_Ru52p8YTOc-WHIoBgC Clang version changed llvmorg-21-init-5118-g52cd27e6:llvmorg-21-init-6681-g5b36835d Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/d05ab7b5b9eccb00b2a73a1d2d19c1b0594f762e..eda5b50d9f0af91694d27361cbdd9f3357878f04/scripts/update.py Bug: angleproject:342096132, chromium:404503040 Change-Id: I1c09b6b376caf6428616d16db12a026663b68d7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6433018 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
kmx.io     mail     discord kmxgit v0.4.0