kc3-lang/angle/src/tests/restricted_traces

src/tests/restricted_traces

Log

Author Commit Date CI Message
Cody Northrop 2657dba2 2025-03-17T10:07:52 restricted_trace_perf: Use run-as when needed On non-rooted devices, commands that access storage need to use run-as. Test: restricted_trace_perf.py Bug: b/404239853 Change-Id: I38bc54c4f4eb9c986106e1773cb1e0796577eaeb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6361299 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Mark Lobodzinski f86d0711 2025-03-07T13:30:58 Tests: Add My Talking Angela 2 Trace Test: angle_trace_tests --gtest_filter=*my_talking_angela_2 Bug: b/401473491 Change-Id: Ic0416ba7c6ab3db82865e9da01a69802590f33c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6352326 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski bace6371 2025-02-17T15:14:37 Tests: Add Brotato ANGLE trace Test: angle_trace_tests --gtest_filter=*brotato Bug: b/397185288 Change-Id: I3d89d4b073b56efeede42abf5b0f44f8e9bd221a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6277708 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski 367541f5 2025-02-05T16:45:13 Capture/Replay: Add multi-capture support to tracer Multiple captures can now be grabbed by setting the trigger value to the desired framecount and then resetting it to zero to trigger a new capture. Captures will be saved in the current capture.out_dir directory and this should be changed between captures to keep traces separate. Note that this feature will not work with apps using persistent coherent memory, and in these cases the tracer will exit, preserving the initial, valid trace. Bug: b/394107532, angleproject:42263521 Change-Id: I9d31d19ec6c3736dbda356405eb91fba2dd5a8d7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6258503 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop c8049a47 2025-02-12T13:21:56 Tests: Add Tower of Fantasy trace Test: angle_trace_tests --gtest_filter="*tower_of_fantasy" Bug: b/389808881 Change-Id: I16a4ab0c12c18d2feb9df41cb0ba5667adb1f161 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6258901 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Alex Dean c0d806b4 2025-02-10T23:01:33 CL: OpenCL support for ANGLE Capture/Replay Implementation of OpenCL Capture/Replay tool in ANGLE. Brief notes about the change: - Most meaningful changes for the capture process are made in src/libANGLE/capture/ - Most meaningful changes for replay are made in util/capture/ and src/tests/perf_tests/ - Many autogenerated files are changed/added to allow the capture of OpenCL objects & calls - The following applications were captured/replayed: benchmark_model, GeekBench Compute, GeekBench ML, AI-Benchmark, various OCL CTS tests - End2end test added to capture_tests. CapturedTestCL.MultiFrameCL/ES3_Vulkan Bug: angleproject:383841335 Change-Id: I55fdaa6cd6c7ba740aaa2351e4d29050059d6d1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6102105 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop fa0de0dd 2025-01-27T17:32:49 restricted_trace_perf: Support --fps-limit Simply passes the flag and value through. Test: restricted_trace_perf.py --fps-limit 30 ... Bug: b/376300037 Change-Id: I344492944babed33edcbdae6b2906795d31715e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6204802 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop 28fbe4a5 2025-01-15T10:12:05 Docs: Fix CIPD link For whatever reason, markdown wasn't resolving the link. Bug: None Change-Id: I27848b0ddbd579c7faf5832119d6521113dfea13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6172575 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop f094a81e 2025-01-07T14:08:11 restricted_trace_perf: Add screenshot support This update allows users to capture screenshots when using restricted_trace_perf.py. * Two new optional arguments are added. If either is set, a screenshot will be captured. --screenshot-dir (host directory to write screenshots, default CWD) --screenshot-frame (specify desired frame, default is 1 or KeyFrame) * If screenshots are requested, we create a temp dir on the device, pull the screenshot, then delete the dir * The screenshot is renamed during pull to reflect the renderer that created it. Otherwise they are all named "native" since we convince the platform to use its default driver, allowing calls to go through the EGL loader. Test: restricted_trace_perf.py --screenshot-dir ~/Screenshots --screenshot-frame 2 Bug: b/377325803 Change-Id: I5be7a1e2f9f557668bff51349654c8c4e093b47a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6154857 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Mark Lobodzinski 491335c4 2024-12-26T10:25:32 Tests: Add Bullet Echo ANGLE trace Test: angle_trace_tests --gtest_filter=*bullet_echo Bug: b/387973432 Change-Id: Ib5694f53dd2f5a2b0d8a417582e4ff8054565461 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6149436 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Mark Lobodzinski 0dabe316 2024-12-18T09:35:35 Tests: Add Monopoly Go trace Test: angle_trace_tests --gtest_filter=*monopoly_go Bug: b/384879555 Change-Id: I64ab6efb23745ab9e099c1243d4f09cee0f311d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6106530 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cody Northrop 0f0d2cc7 2024-12-17T09:50:56 Tests: Add Riptide GP2 trace Test: angle_trace_tests --gtest_filter="*riptide_gp2*" Bug: b/384714388 Change-Id: I09984201c2c96797dcc867ef818aa18684561275 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6101168 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Cody Northrop 645c192a 2024-12-17T09:45:41 retrace: Fix assumption in get_min_reqs Only try to remove implied extension if it is present. Test: retrace_restricted_traces.py get_min_reqs --traces riptide_gp2 Bug: b/384714388 Change-Id: Ic0240c387012923e1918fccd2ea6c341d9a84609 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6101167 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Mark Lobodzinski e9b33f04 2024-12-11T15:17:51 Tests: Add Don't Starve Pocket Edition trace Test: angle_trace_tests --gtest_filter=*dont_starve Bug: b/383500194 Change-Id: I924436d5bb2b166dac5798feff1d614ce1453adb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6090033 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski 09f3bc3a 2024-12-10T15:57:49 Tests: Add Loop Hero trace Test: angle_trace_tests --gtest_filter=*loop_hero Bug: b/383282700 Change-Id: Iff3b5a37b3dfea898344007f544ec25c8b6fa0be Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6085489 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop eee895e1 2024-12-09T08:32:34 Tests: Add Return to Monkey Island trace Test: angle_trace_tests --gtest_filter="*return_to_monkey_island*" Bug: b/383027719 Change-Id: Idc31426199888e7645c2c644bea611f3cc98f202 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6080212 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop 244c0514 2024-12-07T23:06:03 Tests: Add Balatro trace Test: angle_trace_tests --gtest_filter="*balatro*" Bug: b/382914040 Bug: b/382960265 Change-Id: Iebebae9dc2da1b1f20f6e9c184130ebfd544ae52 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6077333 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 75a64561 2024-12-02T20:06:29 restricted_trace_perf: Windows fixes * Drops some unavailable (and unused) imports * Allows specifying --angle-version to avoid git failures Flag created by solti@google.com in http://crrev/c/6037489 Bug: b/376300037 Change-Id: I0c63e966c60998848cdbc8f7a9c414adc0e00d14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6067184 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 11495e55 2024-11-15T18:46:17 Perf tests: restricted_trace_perf.py uses android_helper helpers Bug: b/376300037 Change-Id: Ie4fba3d9300fa3b96f269303f06dee3630f068c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6022181 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
Cody Northrop 594a11ac 2024-11-20T16:55:06 Tests: Add Need For Speed: No Limits trace Test: angle_trace_tests --gtest_filter="*need_for_speed_no_limits" Bug: b/380107298 Change-Id: I216574367e8e495a69c63de2ec04a6c9e3c73ff4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6037637 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Mark Lobodzinski 99aac4b9 2024-11-20T09:24:07 Capture/Replay: Remove implied exts from RequiredExtensions Support for the EXT_compressed_ETC1_RGB8_sub_texture extension can be implied from the presence of OES_cmpressed_ETC1_RGB8_texture, so remove it from the trace's RequiredExtensions entry in its json file. Test: angle_trace_tests --gtest_filter=*need_for_speed_no_limits* Bug: b/380026310 Change-Id: Ia80ae4d78c1f7f7f246ce7a5cfd00bfc0e9734a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6037487 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Cody Northrop 828e2d19 2024-11-16T14:41:10 Tests: Add Block Blast trace Test: angle_trace_tests --gtest_filter="*block_blast*" Bug: b/379456572 Change-Id: I751b69320f68dc4afaa6fdd29e054fb543c43d22 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6026306 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Cody Northrop 33c86fde 2024-11-14T14:33:21 Tests: Add SimCity BuildIt trace Test: angle_trace_tests --gtest_filter="*simcity_buildit*" Bug: b/379097986 Change-Id: I8753014ebcf6ab1ea55868141a527429e8fb4f8c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6021680 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 54e8e665 2024-11-12T12:53:54 Trace tests: generate and use trace list according to gn args Generates out/<config>/gen/trace_list.json which contains the list of traces included in the build according to the angle_restricted_traces gn arg (or all traces if not set). Test runner uses that file instead of the full restricted_traces.json. Android runner pushes that file to the device to the usual location (e.g. /sdcard/chroimum_tests_root/gen/trace_list.json) This also fixes the issue where `angle_trace_tests --list-tests` lists all traces, not just those that were selected with the gn arg. Similarly, running all traces without a filter would be limited to the same list. This transitively applies to trace bundles. Bug: b/376923930 Change-Id: I63506a074d766a51b860472f7211842f8a080ecd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6011956 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 2c7e9830 2024-11-04T10:05:25 restricted_trace_perf: Setup and wrapper support This CL adds support for installing and setting up traces. Also allows running via the wrapper in http://crrev/c/5985570 With this change, if you run without using the wrapper, you must provide the --build-dir flag. It allows running the script from any directory: --build-dir ../../../out/Android Bug: b/376300037 Change-Id: I2259ee120b2af5e1917a2a57a27fa3dcfca761e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5983806 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 7bb1e0f6 2024-10-29T13:18:49 restricted_trace_perf: Allow use of system ANGLE libs This change allows the perf script to use built in ANGLE libs, including from the system partition, instead of requiring a separate package. By default, the script will now use the ANGLE libs packaged in the test APK (com.android.angle.test). OpenGL/EGL calls will still go though the platform EGL loader, but you no longer need to install a separate ANGLE APK containing libs. To use the system libs, add the following flag: --angle-package system You can use it to point to *any* package that is queryable and contains ANGLE libraries. To get the previous behavior, you'd use: --angle-package org.chromium.angle Also two small unrelated fixes: * Fix typo when clearing shader cache * Broaden the 'MODEL' skip in thermal throttling Bug: b/376300037 Change-Id: I762cfd7516026e903a6a5de2949d50e96e766d48 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5976899 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 0f2ce2cd 2024-10-11T12:58:53 Tests: Add Supreme Duelist trace Test: angle_trace_tests --gtest_filter="*supreme_duelist*" Bug: b/372883450 Change-Id: I87931895ea67b437c36bb99e8ab4fa8e1dae3a3e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5926174 Commit-Queue: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Cody Northrop 9e9cbd97 2024-10-10T14:49:00 Tests: Add Antistress Relaxation Toys trace Test: angle_trace_tests --gtest_filter="*antistress*" Bug: b/372644017 Change-Id: Ic9bff87955e25fb6d6a6d787ae012740f4158a7b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5924477 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Cody Northrop e6130b90 2024-10-09T13:14:10 Tests: Add Car Race 3D trace Test: angle_trace_tests --gtest_filter="*car_race_3d*" Bug: b/372282084 Change-Id: Icad78909e68eec6790844c75c6103219ba15299a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5922075 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Cody Northrop 98b5cf46 2024-10-08T19:50:18 Tests: Add Piano Fire trace Test: angle_trace_tests --gtest_filter="*piano_fire*" Bug: b/372291936 Change-Id: Ia3ad52781e251c01246fb01fd800112b0d0f82d5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5918738 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 2bb5b443 2024-10-08T19:39:30 Tests: Add Billiards City trace Test: angle_trace_tests --gtest_filter="*billiards_city* Bug: b/372288799 Change-Id: I2e23d648d8fe27807ccbab26c28ad509349d2a01 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5917649 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Solti f0a66ba2 2024-10-09T00:26:15 remove angle_gl_driver_all_angle when resetting Test: presubmit Bug: b/367348883 Change-Id: Ief115403cd2a908873750c97f416255e61410893 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5918343 Commit-Queue: Solti Ho <solti@google.com> Auto-Submit: Solti Ho <solti@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Roman Lavrov dd66a284 2024-10-04T13:10:14 Perf tests: custom throttling excludes VIRTUAL-SKIN*-MODEL-* These seems to be using different units and get stuck in throttling. Also ignore VIRTUAL-SKIN*-CHARGE-* which I think was the intent but the check ended up in the wrong place. Bug: b/371573999 Change-Id: I2a9e6fbbb41bebfc5d9d85ee187f4f0918dd5e61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5905236 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 0b78963d 2024-06-18T12:38:38 Perf tests: add thermalservice custom temp throttling E.g. --custom-throttling-thermalservice-temp=36 IThermal interface isn't available on all devices. thermalservice is another way to get similar data, but with its own limitations (for example, on Pixel we don't see CPU ODPM temps there while we do get them with IThermal). Unlike --custom-throttling-temp that we use on Pixel, this flag does not attempt to disable vendor throttling (not sure there is even a way to do that outside of Pixel). Vendor throttling can affect perf results, higher custom temps increase odds of that happening mid-way during a trial. Bug: b/347956784 Change-Id: I1166e07e4a5c88417eb379d5cb6a7440b169d073 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5639336 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 770dc68f 2024-10-04T13:05:24 Tests: Add Thief Puzzle trace Test: angle_trace_tests --gtest_filter="*thief_puzzle*" Bug: b/371518149 Change-Id: I593964bdf4a39edf2445a54a400f5faddd4fcaff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5909872 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 37c69bd6 2024-10-07T11:00:14 Tests: gold tests assert that filter matches a test As described on the bug, test retries result in an unexpected value passed to --isolated-script-test-filter, which doesn't match any traces. Assert that there is a match as a (permanent) workaround. Bug: chromium:371977204 Change-Id: I415507ea999005a9ac04489582cf77b7d3e29e2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5912615 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop f1458429 2024-10-04T09:50:38 Tests: Add Going Balls trace Test: angle_trace_tests --gtest_filter="*going_balls*" Bug: b/371526637 Change-Id: I4fad1ef0e7ec450b22f86767398d3283e2c89427 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5908703 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Cody Northrop 3f132f0c 2024-10-03T19:36:20 Tests: Add Woodoku trace Test: angle_trace_tests --gtest_filter="*woodoku*" Bug: b/371501416 Change-Id: I766aac5f0409ab65264955685ac2267c2de457eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5908693 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Mark Lobodzinski 9edd74e2 2024-10-02T09:31:31 Tests: Add Traffic Rider trace Test: angle_trace_tests --gtest_filter="*traffic_rider*" Bug: b/370733451 Change-Id: I35703fcbc350fbbcaf3544ba6143d5bbb1966483 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5902662 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop f680925b 2024-10-01T14:07:03 Tests: Add Warhammer 40000 Freeblade trace Test: angle_trace_tests --gtest_filter="*warhammer_40000_freeblade*" Bug: b/370798324 Change-Id: I77b95721363f3d2cc97a52b2e83ffe5d92e40305 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5902286 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski 7b0212b3 2024-09-27T10:02:58 Retrace cod_mobile for minimum requirements Test: angle_trace_tests --gtest_filter=*cod_mobile Bug: b/369984808 Change-Id: Ibf3b5c446311d27b0a78867cbd8cc523f76adcbc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5895156 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski 0ec8a7f1 2024-09-26T11:06:25 Prevent multiple solutions when retracing with get_min_reqs Skip extensions that implicitly enable other extensions in the retracer script when running to determine minimum requirements. Test: Retrace cod_mobile with get_min_reqs Bug: b/42266279 Change-Id: Iee6f629d1b338362809ff8880d8a5d9ed7c574de Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5893959 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Cody Northrop ff5dfad5 2024-09-20T11:23:07 restricted_trace_perf: Change loop order Before this CL we are doing: For each renderer For each loopcount For each trace Do the test Write out summary of all results We don't get useful data unless the entire script completes. We are seeing some devices disconnect more often, so let's change the order to preserve data. The loop becomes: For each trace For each iteration For each renderer Do the test Write out summary for the trace Output becomes: native_1945_air_force vulkan_1945_air_force native_1945_air_force vulkan_1945_air_force etc. The final output is unchanged. Raw data will be in a different order. Bug: b/369203495 Change-Id: I09b189b5c578dd520123e4ac850018e75b219aa8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5884633 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Mark Lobodzinski 04c2879e 2024-09-18T11:30:07 Modify retracer script to output min requirements json diff After the ANGLE retracer script runs with the get_min_reqs option, ouptut the json file diff. Bug: b/42266279 Change-Id: Ia744e4e36fb9f8b7e8d498d44412af733c7ed9b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5874161 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski a98f83bc 2024-09-13T10:49:08 Add pre-upload Required Extensions check to trace sync script Add a check to make sure that a new ANGLE trace has been run through the retracer with the 'get_min_reqs` argument before uploading to CIPD. Bug: b/42266279 Change-Id: Id6f847faf22a42062ab189ea9bc7fb9c3506e66b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5860299 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 1a97e039 2024-09-17T11:40:29 restricted_trace_perf: Support multiple users This CL adds some tracking data for the current user and storage locations. It moves away from using sdcard at all. Test: restricted_trace_perf.py with non-default user Bug: b/361388557 Change-Id: Ifff9b5e4ba9b184cc5a4339417723ecb7d35a4a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5869168 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 0f4c807a 2024-09-16T12:55:40 Tests: disable batching in gold tests on Android setRequestedOrientation from a previous trace appears to affect pixels. We often see this on CI when a new trace is added which reshuffles traces. For example, in this sequence the first trace sets landscape orientation and the second one goes back to portrait: angle_trace_tests --gtest_filter=TraceTest.dota_underlords:TraceTest.dragon_raja \ --run-to-key-frame --save-screenshots --verbose \ --render-test-output-dir=/tmp/g When the second trace is run independently, the resulting pixels are slightly different. This CL disables batching tests on Android so each trace runs as a new instrumentation/activity. This way the previous trace orientation does not seem to matter. The impact on shard runtime seems minor. Bug: b/367401313 Change-Id: If1c41e45d063d434f92d46be8dd381e645a3ff0a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5866850 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop 5e45d53f 2024-09-15T11:12:01 Tests: Add Downwell trace Test: angle_trace_tests --gtest_filter="*downwell*" Bug: b/367019385 Change-Id: Iad12378a0d770e24b5a74db9eee78b0d8cbaa094 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5863490 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski 27738fe4 2024-09-04T19:53:01 Fix retracer script error due to blank argument Traces fail when running the retracer script if the --request-extensions argument is passed with a blank value. Bug: b/42266279 Change-Id: I1e465caaaa7a5f8d8048c09890b5d01eeb2d0df1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5860298 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 3c93f29b 2024-09-10T20:27:16 Test: Add Chrono Trigger trace Test: angle_trace_tests --gtest_filter="*chrono_trigger*" Bug: b/365875548 Change-Id: Ifd9f2c09f93716341fb36b79e7c7ae5291fa9ed2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5852912 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Cody Northrop 8a8ca298 2024-09-10T14:34:11 Tests: Add Brawlhalla trace Test: angle_trace_tests --gtest_filter="*brawlhalla*" Bug: b/365824633 Change-Id: If3a5213661ffb041903a84a12713e04588b516e6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5851640 Reviewed-by: Mark Łobodziński <mark@lunarg.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop bda33598 2024-09-08T16:08:04 Test: Add Critical Ops trace Test: angle_trace_tests --gtest_filter="*critical_ops*" Bug: b/365417418 Bug: b/365524876 Change-Id: I3e6f3278a9c6ea819d61a0136986631b19170018 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5843583 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski 61c26fd6 2024-08-29T10:11:00 Tests: Add Passmark benchmark Unity trace Add trace of the 'OpenGL ES using Unity ' benchmark case of the Passmark performance test suite. Test: angle_trace_tests --gtest_filter=*passmark_unity* Bug: b/362801313 Change-Id: I15a57fefdb4959e60196646aa5053b6fa5960bcb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5825785 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 56ea2edc 2024-08-30T11:01:48 Traces: Update regex for power rails Bug: b/354006406 Change-Id: If014c49ccdbb6e0a57c0dc88833511049c3578ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5828131 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski 28d82804 2024-08-29T10:05:09 Tests: Add Passmark benchmark Complex trace Add trace of the 'Complex' benchmark test of the Passmark perofrmance test suite. Test: angle_trace_tests --gtest_filter=*passmark_complex* Bug: b/362801312 Change-Id: Ic85874140fa22f97c13b1be043120e8ccc428c96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5826921 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski c3309dbd 2024-08-23T15:47:27 Tests: Add Passmark benchmark Simple trace Add trace of the 'Simple' benchmark case of the Passmark performance test suite. Test: angle_trace_tests --gtest_filter=*passmark_simple* Bug: b/362784518 Change-Id: I387efb5cc0d7b1ee8c731f2fdedc56806701169c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5824181 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 2f28264e 2024-08-15T18:05:43 Trace perf: add origin/main revision to summary if != HEAD Bug: None Change-Id: Iacacd98993d7dc5fbea8489b46236e939f465689 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5792199 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski 77616aa3 2024-08-14T13:22:32 Tests: Add Gwent Witcher Card Game trace Test: angle_trace_tests --gtest_filter="*gwent_witcher_card_game*" Bug: b/359910003 Change-Id: I6b93d36ac58df7639f07b7f21107f4d4522f6cee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5789276 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 681b681b 2024-08-10T14:03:28 Tests: Add Grand Mountain Adventure trace Test: angle_trace_tests --gtest_filter="*grand_mountain_adventure*" Bug: b/358846996 Change-Id: If6815705b357eb69a777156d840be17fbe362938 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5779619 Commit-Queue: Roman Lavrov <romanl@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Mark Lobodzinski d306e048 2024-07-24T15:03:04 Tests: Add Shovel Knight Pocket Dungeon trace Tests: angle_trace_tests --gtest_filter=*shovel_knight_pocket_dungeon bug: b/355399059 Change-Id: I5b2193db9814d0867ab95efab7588540fca6198d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5742394 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop a5db20f7 2024-02-21T10:48:26 Traces: Switch to regex for power rails The rails have been rearranged on some devices. Update the way we scan for output to find them in either case. Bug: angleproject:354006406 Change-Id: Ia3999fc2c07a726f4832e451af93a40949f87335 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5722949 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Shahbaz Youssefi d193d51b 2024-06-17T22:46:08 Replace issue ids post migration to new issue tracker This change replaces anglebug.com/NNNN links. Bug: None Change-Id: I8ac3aec8d2a8a844b3d7b99fc0a6b2be8da31761 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5637912 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bruno BELANYI be78da6e 2024-05-22T15:33:46 FrameCapture: log end of trace capture This makes it easy to spot when the capture is done through logcat. Bug: angleproject:343190307 Change-Id: Idf174cbf256242e32cda3c781c8b1092123254bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5557966 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Commit-Queue: Bruno BELANYI <ambroisie@google.com>
Cody Northrop 44bdc2af 2024-04-23T19:43:29 restricted_trace_perf: Write summary for single renderer For use when generating spreadsheets focused on Vulkan. Previously the script would exit without generating a CSV file unless there were two renderers to compare. Test: restricted_trace_perf --renderer vulkan Bug: b/317411251 Change-Id: Ic9872599edb38c738112265b1ce7f252cf3f966a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5508315 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski 6658d5e8 2024-04-25T13:51:43 Tests: Add Modern Combat 5 trace Test: angle_trace_tests --gtest_filter=*modern_combat_5 Bug: b/330861486 Change-Id: I54b22010fdb5be6d1113f4dd6561848b44a413cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5501770 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Mark Lobodzinski 2d4a027d 2024-03-20T12:07:45 Tests: Add Poppy Playtime Trace Test: angle_trace_tests --gtest_filter=TraceTest.poppy_playtime Bug: b/330861486 Change-Id: Ifd18ec32bce1db585bb4d284a39ed78a94932d8f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5387536 Commit-Queue: Mark Łobodziński <mark@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mike Schuchardt f7cd1c56 2024-02-28T12:04:22 Tests: Add Toca Life World trace Test: angle_trace_tests --gtest_filter=TraceTest.toca_life_world Bug: b/327354357 Change-Id: I5dc900532dc8b5db516c8c2fbab63462fa7c20ea Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5333438 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski 8142dde7 2024-02-27T15:08:57 Tests: Add Pokemon Masters Ex trace Test: angle_trace_tests --gtest_filter=TraceTest.pokemon_masters_ex Bug: b/326199738 Change-Id: Ie0c4c4072865783b8f43332f9e4463a79acf3c35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5328735 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Mark Łobodziński <mark@lunarg.com>
Roman Lavrov 6d589ff6 2024-02-12T15:26:54 Trace perf: support custom thermal throttling for tests Vendor throttling kicks in rather quickly and starts affecting e.g. cpu/gpu freqs, which can be hard to predict and increases variance in our tests. This change implements support for disabling vendor throttling (re-enabled at the end, including ctrl-C) and using a custom temperature threshold for VIRTUAL-SKIN sensors, which are checked after each test runs. This allows to set the threshold to higher values and run the device hotter without touching cpu/gpu freqs while running tests, and then dissipate heat (if necessary) by sleeps between tests. This also allows to reduce fixed-time sleeps between tests as we're monitoring the temperatures. Only some of our trace tests heat up the device sufficiently to actually require throttling, and with active cooling I was able to avoid sleeps almost through the entire run. However, sleeps might also be needed to prevent battery from discharging, so also add a flag to sleep until a given battery level is reached after each test. Example usage, sleeping between tests until all sensors are below 39C but also battery level is at least 30%: --custom-throttling-temp=39 --min-battery-level=30 Bug: b/315042901 Change-Id: I7660fc36b1103e20e4cc97312d396f3667739481 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5288455 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov 11eb5eb7 2024-01-30T10:59:45 Traces: support checkout of individual traces Example .gclient to checkout a couple traces only: 'checkout_angle_restricted_trace_antutu_refinery': True, 'checkout_angle_restricted_trace_bubble_shooter': True, To be used in conjuction with gn args, e.g.: angle_restricted_traces=["antutu_refinery", "bubble_shooter"] Note: when need perfetto, we'd also need to add: 'checkout_angle_perfetto': True, because it defaults to checkout_angle_restricted_traces which is not being set to True in this case. Bug: b/322507257 Bug: b/322779830 Change-Id: I404e26919899c8874b570d6ffa80c86fabfd3348 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5249196 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop 0ada0b7f 2024-01-29T16:36:18 Test: Add Plague Inc. trace Test: angle_trace_tests --gtest_filter="*plague_inc*" Bug: b/321562592 Change-Id: I1a68b80659517aec61315e51cacc486f44410cdf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5250428 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Mark Lobodzinski 05cd0b4c 2024-01-12T15:45:27 Tests: Add Asphalt 9 2024 trace Test: angle_trace_tests --gtest_filter=TraceTest.asphalt_9_2024 Bug: b/320248297 Change-Id: I5c27ea47118bf5cbe09b41ef02b6efe1a23d581f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5201444 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 80fca933 2023-12-08T18:30:01 Tests: Add Thimbleweed Park trace Test: angle_trace_tests --gtest_filter="*thimbleweed_park*" Bug: b/315540661 Change-Id: I78d45d51531b81dbe05427db0dff4dc685b98cbc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106864 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mark Łobodziński <mark@lunarg.com>
Shahbaz Youssefi d788c2c0 2023-12-04T22:43:39 Remove team members no longer part of the project Bug: None Change-Id: I66bf34ece50995fdecfab55a2198e9946e9be4cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5087208 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Cody Northrop f58ba088 2023-11-05T16:40:37 Tests: Add Warcraft Rumble trace Test: angle_trace_tests --gtest_filter="*warcraft_rumble*" Bug: b/309345647 Change-Id: I6e78fb0465edcfa97943ff8374c568dcd9b8eba7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5007173 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 18d51f01 2023-12-03T18:26:12 Tests: Add Black Clover M trace Test: angle_trace_tests --gtest_filter="*black_clover_m*" Bug: b/314683298 Change-Id: Icee6102aa5161f2054134831e00eb99b8048c448 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5082209 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 554d761a 2023-12-01T15:14:22 Tests: Add AFK Arena trace Test: angle_trace_tests --gtest_filter="*afk_arena*" Bug: b/314365671 Change-Id: Id0213199b0e75919701be8ec9e216a224a6725d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5078682 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Mark Lobodzinski 25f448f4 2023-12-01T12:33:27 Tests: Add Walking Dead Survivors trace Test: angle_trace_tests --gtest_filter=TraceTest.walking_dead_survivors Bug: b/314311102 Change-Id: Icf104613b59a8de0f89fc5fa3dd6db4ad9a3dc2b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5080498 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 989b1143 2023-11-28T14:06:06 Trace perf: logcat output captured line-buffered I've seen warmup detection getting stuck intermittently not seeing the log line despite the line being there. Hopefully this fixes. Bug: b/291604008 Change-Id: I10da772c485f7b1badd34efc00c20fc6d55139cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5067855 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Cody Northrop ee4b7a27 2023-11-03T09:06:50 Add --memory to restricted_trace_perf.py Detailed analysis of our power results showed that even checking memory can impact power. This CL makes memory measurement optional (like power) to enhance power measurements. Test: restricted_trace_perf.py --memory --power Bug: b/292249127 Change-Id: I69b34d378ca923de42af59fc1b532a1d766b4391 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5066797 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Mark Lobodzinski 068a0ee8 2023-11-28T08:43:45 Tests: Add Retro Bowl trace Test: angle_trace_tests --gtest_filter=TraceTest.retro_bowl Bug: b/313610392 Change-Id: Iec30c95fd46a75c6995d968dfac5652a89209bc3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5066795 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop 108bd958 2023-11-10T17:30:43 Tests: Add Slay the Spire trace Test: angle_trace_tests --gtest_filter="*slay_the_spire*" Bug: b/310281616 Change-Id: I6c94b0e3c72be1ad3cb2897981febd3f67722a20 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5021241 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Mike Schuchardt 221117ab 2023-11-02T08:48:51 Tests: Add The Sims Mobile trace Test: angle_trace_tests --gtest_filter=TraceTest.the_sims_mobile Bug: b/308927628 Change-Id: I5de44b7eedb904c318168fbc7e308af218dc5ab1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5002145 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop e519da9a 2023-10-29T14:33:06 Tests: Add Streets of Rage 4 trace Test: angle_trace_tests --gtest_filter="*streets_of_rage_4*" Bug: b/308334509 Change-Id: I3cc2d41c83bfcc6a32e6d1aec5e306cefb15afdc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4988132 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Mike Schuchardt <mikes@lunarg.com>
Cody Northrop 7f5b5f74 2023-09-19T07:35:16 Tests: Add Batman: The Telltale Series trace Test: angle_trace_tests --gtest_filter="*batman_telltale*" Bug: b/301024256 Change-Id: Ice5aa3ed093901c04486fca64121592eb8805f93 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4883428 Auto-Submit: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Mark Lobodzinski 2fe7bbae 2023-09-07T13:21:29 Tests: Add Oxenfree trace Test: angle_trace_tests --gtest_filter=TraceTest.oxenfree Bug: b/298613720 Change-Id: Ie577dff75faf58ee97c0898a28766e9ed7c87459 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4851250 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Cody Northrop eb5acc3e 2023-09-08T15:34:44 Tests: Add ONE PIECE TREASURE CRUISE trace Test: angle_trace_tests --gtest_filter="*one_piece_treasure_cruise*" Bug: b/299681746 Change-Id: I3b5a9de18613df37181feb3c207105dba411d2a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4854449 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Roman Lavrov dcd62fc4 2023-08-31T15:35:39 Trace perf: clear blob cache before each test Cache eviction can happen during warmup causing cache misses while testing. Significant cycles are being spent evicting cache entries and throwing off power measurement. Since this is already a synthetic environment where we're lumping in a bunch of caches together, clear it between tests so that warmup correctly populates and no cache misses occur within the test run. If we clear the cache before warmup and everything fits, no eviction happens and we hit the cache every time post-warmup. This also improves reproducibility of perf results as they no longer depend on the specific cache state before running a particular test, the order in which tests are run etc. Also fixes acessing unset var when running without --power. Bug: b/298028816 Change-Id: I704073f70d8859e19a78b23d397e68f5836f3bb2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4834073 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov 18e2038e 2023-09-01T12:59:51 Revert "Gold tests: add temporary logging of angledata hashes" This reverts commit 4fffc9938375f2b84632eb661fc175457fb2ee77. Reason for revert: Hashes are ok - http://b/296921272#comment3 Original change's description: > Gold tests: add temporary logging of angledata hashes > > Should allow us to determine whether corruption happens between CAS and > local files on bots or something's wrong with the test harness. > > Bug: angleproject:8307 > Change-Id: I8a599777a38d7a1b5c56143eb8d02829895175a7 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4777836 > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Auto-Submit: Roman Lavrov <romanl@google.com> Bug: angleproject:8307 Change-Id: Idae3bf3bac810af63e44c0c7553e0c6e9bb6af5b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4834062 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Roman Lavrov ed7e05be 2023-08-31T10:44:05 Cleanup: remove tests.csv Looks like it was added accidentally in https://crrev.com/c/4189028 Bug: b/242419750 Bug: angleproject:7882 Change-Id: I1d92b4a7001a1418bfea77e2b0945ee7a070dad5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4832095 Auto-Submit: Roman Lavrov <romanl@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Cody Northrop 98e351cf 2023-08-16T15:22:37 Traces: Update steps for upgrading traces We've settled on a streamlined method of upgrading traces. We consider the upgraded trace good if: - gets the same pixels for all frames, including after Reset - gets the same frame time and memory usage (or better) This moves away from using serialization, which is useful, but has become too heavyweight. We've preserved the steps as they are still useful in some scenarios. Also formalize a couple of scripts we've been using to compare trace screenshots. It supports two scenarios: - comparing screenshots between ANGLE and native - verifying screenshots after an upgrade Example usages: compare_trace_screenshots.py versus_upgrade \ --before <path> --after <path> --outdir <path> compare_trace_screenshots.py versus_native \ --screenshot-dir /tmp/screenshots --trace-list-path src/tests/restricted_traces Bug: b/294882956 Change-Id: Ifc59d8b31648abb3614da2d8919a1f90a0b6b68f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4791916 Auto-Submit: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Roman Lavrov <romanl@google.com>
Cody Northrop b0777def 2023-08-21T13:54:08 Traces: Upgrade octopath_traveler Test: angle_trace_tests --gtest_filter=TraceTest.octopath_traveler Bug: b/294882956 Change-Id: I690f4f6ad65542cd015ce61ee246f009f0907740 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4794728 Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Auto-Submit: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 865eceaa 2023-08-21T15:17:02 Trace perf: power metric uWs/frame -> W, exclude startup&teard Switching from uWs/frame to W, which is easier to measure as we don't need to know how many frames were rendered between the measurements and just need to avoid warmup, turndown. Also, W is a more "natural" metric as it reports actual power usage that can be reasoned about in terms of device thermals etc. Changing starting point to post-warmup by waiting for test message in logcat. The logcat -> script delay seems very small in my tests. Turndown also shows spikes in some traces so avoiding that by shifting the time for end point collection to 1s before the test is expected to finish (which makes this only compatible with --fixedtime) Also made device selection set env var instead of a global variable and passing via args it slighlty simplifies subprocess(adb) handling. Bug: b/291604008 Change-Id: I2109da0d75eba167eec939df88a34d9a9b7f330b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4799391 Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov d41ac4da 2023-08-18T11:25:05 Cleanup: 'am instrument' readability and consistency Reconcile android_helper and restricted_trace_perf formatting of 'am instrument' command. The only real difference is that restricted_trace_perf uses 'shell=True' in subprocess which requires escaping spaces inside "" Bug: b/292249127 Change-Id: I002e49ae5b2913db46b92a7b643bc12d21abce1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4794430 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Roman Lavrov 84576a5b 2023-08-18T12:08:04 Trace perf: log script args in the spreadsheet Excludes the --output-tag flag Example: ... Source: raw_data.android.20230818.csv Args: -f *blade_and_soul_revolution --fixedtime 1 --power --loop-count 2 --sleep 1 Bug: b/292249127 Change-Id: Ic40666921fe49845032d47f32ecda9609ba7b044 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4794431 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 9e2d4c0b 2023-08-18T10:25:48 Trace perf: add test crash handling When missing time and no '[ PASSED ]' tag in stdout, assume test crashed. Example stdout: trace wall_time gpu_time ... Starting run 1 with native at 2023-08-18 10:23:17 native_blade_and_soul_revolution crashed 0 ... raw_data: trace,wall_time(ms),gpu_time(ms),... native_blade_and_soul_revolution,crashed,0,... summary: 1,blade_and_soul_revolution,-1.000,-0.00%,-1.000,... Set cpu_time to 0 on a crash for consistency with other metrics. Bug: b/292249127 Change-Id: I9533c0ee7aa9a3b45f360ad1618984eb620d657f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4794428 Reviewed-by: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 864de574 2023-08-18T09:49:30 Trace perf: subprocess.wait() -> subprocess.communicate() subprocess.wait() deadlocks when enough output is produced by the command to fill the stdout/stderr buffers. https://docs.python.org/3/library/subprocess.html#subprocess.Popen.wait recommends .communicate() instead. Replaced result.process.stdout with result.stdout which is a string rather than a stream. Bug: b/292249127 Change-Id: I172ac058ebc6aafda82edab7c45787252d612013 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4794288 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Roman Lavrov <romanl@google.com>
Mark Lobodzinski 823de3a3 2023-08-22T07:40:39 Tests: Add Injustice 2 trace Test: angle_trace_tests --gtest_filter=TraceTest.injustice_2 Bug: b/296913308 Change-Id: I35f1e17767f924c4f31d4e00a2c9f737c6c4822b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4802266 Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov 2c624a5e 2023-08-17T15:36:37 android_helper cleanup: remove smoke test and timeout This was added to help debug cases of stuck tests on bots, but this doesn't seem to have happened in over a year and the code (and timeout) keeps getting in the way. Bug: angleproject:7242 Change-Id: Ic30d976408bd32a745d830921f6e4d98d17e863c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4789845 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
Mike Schuchardt 8f5a6124 2023-08-18T17:13:18 Tests: Add Stumble Guys trace Test: angle_trace_tests --gtest_filter=TraceTest.stumble_guys Bug: b/296557360 Change-Id: Iebf81920eaaf8a3b52a3ffed0027aeb01ebed16b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4794756 Commit-Queue: Mike Schuchardt <mikes@lunarg.com> Reviewed-by: Cody Northrop <cnorthrop@google.com>
kmx.io     mail     discord kmxgit v0.4.0