|
fa74421d
|
2021-08-06T18:30:57
|
|
Capture/Replay: Add LoadEGL()
Add LoadEGL() to gen_restricted_traces.py. This is a pre-requisite to
frame capture being able to generate EGL calls, which is required for
multi-context support.
Bug: angleproject:5878
Change-Id: I210035aecad42173626834588bae51019deaa076
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3078994
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
62cac8b5
|
2021-08-06T18:24:52
|
|
Capture/Replay: Add EGL support to generate_entry_points.py
Add EGL support to generate_entry_points.py. This is a pre-requisite to
frame capture being able to generate EGL calls, which is required for
multi-context support.
Bug: angleproject:5878
Bug: angleproject:4035
Change-Id: I3b8e9c91f9e2820b5207fc02d858e8109921f581
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3078993
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
ce6b0cd7
|
2021-08-12T16:15:11
|
|
Roll vulkan-deps from 95cbcd95b33b to 20a966e2b2fd (8 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/95cbcd95b33b..20a966e2b2fd
Changed dependencies:
* spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/e7b49d7fb5..e71feddb3f
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/de69f32e89..54524ffa6a
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/fbb56aacce..de99f8f6be
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2fe826b04c..76a2e6cc59
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ynovikov@google.com
Change-Id: I3eb2bbedb4915f399ab6e6a87770bfa15922bd07
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3090816
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
ac2d1434
|
2021-08-11T15:48:57
|
|
Enable resultdb for ANGLE standalone builders
Otherwise, they fail with https://crrev.com/c/3088213, e.g.
https://ci.chromium.org/ui/p/angle/builders/try/linux-clang-rel/23678/overview
Doesn't actually upload to BigQuery yet, pending declaring the tables.
Bug: chromium:1135718
Change-Id: Ia429260e2f53f836279383aa84ca3e8e58c3392b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3087640
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
bfad749c
|
2021-08-12T07:01:05
|
|
Roll Chromium from 176cfbd86223 to 00e190ef4059 (514 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/176cfbd86223..00e190ef4059
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/bbf7f0ed65..ee35ebe42c
* buildtools/linux64: git_revision:eea3906f0e2a8d3622080127d2005ff214d51383..git_revision:69ec4fca1fa69ddadae13f9e6b7507efa0675263
* buildtools/mac: git_revision:eea3906f0e2a8d3622080127d2005ff214d51383..git_revision:69ec4fca1fa69ddadae13f9e6b7507efa0675263
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/24e92c2bee..eed07007f8
* buildtools/win: git_revision:eea3906f0e2a8d3622080127d2005ff214d51383..git_revision:69ec4fca1fa69ddadae13f9e6b7507efa0675263
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/30fcc783eb..44c5a11573
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/32263815a7..5d3907f90f
* third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/5be11071ec..380b3ce66e
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3ef3f2c876
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/49a703f3d9..4b973b6e6e
* third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/7c54c1f227..6ac5f7effd
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6a8e571efd..f1ab49ba22
* tools/luci-go: git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe..git_revision:a5735121c6339dee9b1b3644535e230744daaac9
* tools/luci-go: git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe..git_revision:a5735121c6339dee9b1b3644535e230744daaac9
* tools/luci-go: git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe..git_revision:a5735121c6339dee9b1b3644535e230744daaac9
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/836d7670f0..541f598e64
* tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/7235d59a2b..494ba2a758
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/8552b7ec98..f7a26285a7
Clang version changed llvmorg-14-init-591-g7d9d926a:llvmorg-14-init-1002-gb5e470aa
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/6a8e571efd68de48d226950d1e10cb8982e71496..f1ab49ba228127b73e1e590a9687d7edfdc65151/scripts/update.py
Bug: None
Tbr: ynovikov@google.com
Change-Id: I0e8d45c81fdc66b37c9fea29c8be703fadb638b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3089661
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
ff64d2c7
|
2021-08-06T21:24:09
|
|
Choose direct-to-Metal translator through a feature.
Define directMetalGeneration in FeaturesMtl.h. If
ANGLE_ENABLE_METAL_SPIRV is defined to 1 (still the default),
directMetalGeneration defaults to false. It can be overridden via the
standard ANGLE mechanism:
ANGLE_FEATURE_OVERRIDES_ENABLED=directMetalGeneration
It can also be overridden by instantiating angle_end2end_tests with
the directives:
WithDirectMetalGeneration(ES2_METAL())
WithDirectMetalGeneration(ES3_METAL())
These directives aren't working properly yet though. The
direct-to-Metal compiler is instantiated, but the _DirectMetalGen
versions of the tests fail. They pass when switching the Metal
backend's default behavior using the above environment variable. This
will be debugged in follow-on CLs.
Thanks to syoussefi@ for the prototype of this CL:
https://chromium-review.googlesource.com/3076129
Bug: angleproject:5505
Change-Id: I188ab89abc75bf89c5ed2d90102af311feaa1960
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3079083
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
331be08f
|
2021-08-11T11:28:29
|
|
Tests: Add Sonic The Hedgehog trace.
Test: angle_perftests --gtest_filter="*sonic_the_hedgehog*"
Bug: angleproject:6181
Change-Id: I40a5affe804a747445ef620c4f78e842c1eed1ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3087444
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
d3031c65
|
2021-08-11T12:30:01
|
|
Capture/Replay: Update expectations with bug IDs
In addition, update two tests that are just failing and no longer
crashing.
Bug: angleproject:6166
Change-Id: I9f19bf411c79c39f4f1f3156a9f8682609d6b3d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3087445
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
29270a63
|
2021-08-11T10:01:12
|
|
Roll vulkan-deps from 902c4504128f to 95cbcd95b33b (8 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/902c4504128f..95cbcd95b33b
Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c4c6f2ba5c..de69f32e89
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/9fe958cdab..521f91d793
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a2edd93673..fbb56aacce
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/8dca1fa770..415320f80f
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/bc1468932d..2fe826b04c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ynovikov@google.com
Change-Id: I231ec887713f25bc84328640a07cb70526f481e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3087841
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
88725917
|
2021-08-11T07:00:58
|
|
Roll Chromium from 6db26672c5bd to 176cfbd86223 (476 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/6db26672c5bd..176cfbd86223
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/8e6db3edf0..bbf7f0ed65
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/c54c079bce..30fcc783eb
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/09da6e47b4..32263815a7
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..abc7ba7d87
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/24dc2c7823..49a703f3d9
* third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/ad8b3b0f84..ff19e5b2e1
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/77b4e6e8d4..f2eeaf2ef3
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/79ff382907..836d7670f0
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/e4df839dbe..8552b7ec98
No update to Clang.
Bug: None
Tbr: ynovikov@google.com
Change-Id: Ibed6651e595c5cfa7fa5a01b016c7346411e4760
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3088002
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
392ba63f
|
2021-08-10T19:20:47
|
|
Suppress 2 dEQP GLES3 tests on Win SwANGLE
functional.shaders.operator.unary_operator.minus.lowp_uvec3_vertex
functional.shaders.operator.unary_operator.minus.mediump_uvec3_vertex
Fails on x86 when llvmorg-13-init-15561-gf98ed74f Clang rolled.
Unfortunately, expectation file doesn't support architecture,
so suppressing on both x86 and x64 Windows, keeping the test running on
x64 Linux.
Bug: angleproject:6265
Change-Id: I15f8955eaf38c95d0d3036378d97afdb1871d44e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3088016
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
6136620b
|
2021-03-25T15:43:06
|
|
Reland "EGL: GLES: Implement GL_EXT_protected_textures"
This is a reland of 6210a9b34a721df2c84cf69170ad9bf7ba40e4aa
This removes changes in gl backend.
Original change's description:
> EGL: GLES: Implement GL_EXT_protected_textures
>
> Implement EGL_EXT_protected_content Images
> Add protected member to Images and Textures
> Add error when creating objects if not supported or
> does't match native buffer
> When creating siblings pass protected state
> Add extension caps
> Add Validation
> Add GetTexParameter and SetTextparameter
> Add protected to Texture and state
> Expand tests for images and textures
>
> Test: angle_end2end_test --gtest_filter=EGLProtectedContentTest
>
> Bug: angleproject:3965
> Change-Id: I35a89b4e80bba6d9b6831c68e71630eef304dacb
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2802852
> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Test: angle_end2end_test --gtest_filter=EGLProtectedContentTest
Bug: angleproject:3965
Change-Id: Id36d697c53afc0f0dadf92bda4565f9157f4fc2a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076825
Commit-Queue: Brandon Schade <b.schade@samsung.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
0bd5cac2
|
2021-08-06T17:56:58
|
|
Allow BufferSubData with persistently mapped buffers
Per the GL_EXT_buffer_storage extension:
What commands are affected by the relaxed errors for persistently
mapped buffers?
RESOLVED: In GL 4.5 the following commands have the relaxed
language BufferSubData, ClearBufferSubData, CopyBufferSubData,
GetBufferSubData and InvalidateBufferSubData. Of these commands
the only ones that apply to ES 3.1 are BufferSubData and
CopyBufferSubData. However, if additional extensions add any of
the other commands and EXT_buffer_storage is supported, they
would have the same behavior in ES.
Therefore we need to allow BufferSubData and CopyBufferSubData on
persistently mapped buffers.
Current we fail these scenarios in validation. This was detected when
running Fortnite on Android using the game's GLES backend.
Also added two tests:
- StorageCopyBufferSubDataMapped to recreate the exact Fortnite
scenario using glCopyBufferSubData.
- StorageBufferSubDataMapped is a contrived case to cover
glBufferSubData
Test: BufferStorageTestES3.StorageCopyBufferSubDataMapped/*
Test: BufferStorageTestES3.StorageBufferSubDataMapped/*
Bug: b/180418810
Bug: angleproject:5658
Change-Id: Ib678e84f367934656ec10f0f4ad0d35ac687f0b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3078316
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
8f214193
|
2021-08-10T20:40:36
|
|
Revert "Properly report xcb_connect failures in DisplayVkXcb"
This reverts commit 81bee2e7f6deeda15691dd0b7fca90626b66bfb8.
Reason for revert: fails on
https://ci.chromium.org/ui/p/chromium/builders/try/linux-ozone-rel/918054/overview
Original change's description:
> Properly report xcb_connect failures in DisplayVkXcb
>
> Bug: chromium:1223431
> Change-Id: Iaefddbda3fef283eed365fe010ee003a3b3beca8
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3083383
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Bug: chromium:1223431
Change-Id: I1da24861375a29f448e61771a609396e777c2e29
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3087555
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
0b651e42
|
2021-07-20T11:48:38
|
|
Vulkan/D3D11/Metal: Expose GL_NV_framebuffer_blit
GL_NV_framebuffer_blit is equivalent to ES3 blit which these backends
support.
Bug: chromium:1220246
Change-Id: I6ef0b80f9e9ba7828d6720cdbe19c83c4abdc4cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3041878
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
81bee2e7
|
2021-08-04T19:31:54
|
|
Properly report xcb_connect failures in DisplayVkXcb
Bug: chromium:1223431
Change-Id: Iaefddbda3fef283eed365fe010ee003a3b3beca8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3083383
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
97c21277
|
2021-08-03T15:06:37
|
|
FrameCapture: Don't capture default drawbuffers state.
When capturing framebuffers during mid-execution-capture the
drawbuffers state is now compared with the default one and skipped
when equal.
This prevents capturing the unavailable glDrawBuffers call when using
OES_framebuffer_object on GLES 1 contexts.
Bug: angleproject:6181
Change-Id: Id2076223067dc5f89df88fe6a3a48b09fa9a3f5d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3068957
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
856228b0
|
2021-08-05T23:10:25
|
|
D3D9: Expose EXT_sRGB and EXT_texture_compression_s3tc_srgb
sRGB reads are supported on D3D9 via SetSamplerState.
sRGB writes are supported on D3D9 via SetRenderState.
Bug: angleproject:6258
Change-Id: I841c25ce66486e93ae2122b370e910f383fed774
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076359
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
|
|
|
595ce2b8
|
2021-08-03T15:06:14
|
|
FrameCapture: Use OES suffixes for framebuffer functions on ES1.
Functions using the GL_OES_framebuffer_object extension on GLES 1.1
require the OES suffix or will otherwise crash on certain native OpenGL
drivers.
The framebuffer capture functions are stored in a struct.
This patch makes replay of Sonic The Hedgehog possible on Pixel 4 XL
native GL.
Bug: angleproject:6181
Change-Id: I689267b024824818bfcf28e652b835e075208415
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3068956
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
d25c9d7f
|
2021-07-07T12:15:12
|
|
Add perf tests runner script.
This script will be responsible for running the perf tests
multiple times to try and stabilize measurements. We'll use it on
the bots instead of just running the perf tests directly.
Because the script invokes the binary multiple times, this slows
down execution. Most significantly on Android, where we now need
to use 20 shards, up from 6.
Also marks one test as flaky on OpenGL.
Bug: angleproject:6090
Change-Id: I5280035cb0bdb290a68dc6961a384eaf4b40dd4b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3011422
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
4eac0bf1
|
2021-08-10T10:01:12
|
|
Roll vulkan-deps from 8e25231b71ac to 902c4504128f (7 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/8e25231b71ac..902c4504128f
Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/e0f3fdf433..aa2d4bd2f4
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/706dc27a62..c4c6f2ba5c
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9db21837b8..bc1468932d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ynovikov@google.com
Change-Id: I790425565050497ad4a4632a4283afa9b021d5ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3085081
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
17d4ff96
|
2021-08-10T07:13:16
|
|
Roll Chromium from bfd7c5a55cd0 to 6db26672c5bd (464 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/bfd7c5a55cd0..6db26672c5bd
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/1b131580ae..8e6db3edf0
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/97a17ccfc8..c54c079bce
* third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/d5413f72f6..5be11071ec
* third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/b291e88d8e..e98c753917
* third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/ff9352c23f..37226d67bc
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b35ee4986e
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e989bf92db..24dc2c7823
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/9ce4c7a678..77b4e6e8d4
* tools/luci-go: git_revision:e7749d37e8e52fd6eb9c79266a17d7fcb6f6ec04..git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe
* tools/luci-go: git_revision:e7749d37e8e52fd6eb9c79266a17d7fcb6f6ec04..git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe
* tools/luci-go: git_revision:e7749d37e8e52fd6eb9c79266a17d7fcb6f6ec04..git_revision:1120f810b7ab7eb71bd618c4c57fe82a60d4f2fe
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/55fedb1a47..79ff382907
* tools/protoc_wrapper: https://chromium.googlesource.com/chromium/src/tools/protoc_wrapper/+log/57697a9873..c16b0dc8db
* tools/skia_goldctl/linux: H5Ax0_QmNml9Df-r61hCscndRQDsCim7j6-ST_Bqc7QC..jQH5G1XR31QSX-Y7BEw3-HCqj-rqMbmFt8ia4QT9X_IC
* tools/skia_goldctl/mac: VP9yR_72z50Efyz4lp6uXyLhZowfvEScnoGf8RMWlHAC..rBeQmF5YzW5gOYg2G0CKoVli5wQ536stUnVW9UXdTagC
* tools/skia_goldctl/win: P8MltnujOo50R-Kl3rxhuKLOYs02wz_YJUkzOruEDYwC..XTbWn-rB8RlBWCMTnyklV8yZV_fBb4VoUNOZ9dgtQJgC
No update to Clang.
Bug: None
Tbr: ynovikov@google.com
Change-Id: I71abad2ab63c443a3cc09364a24745d722f3d426
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3084071
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
1d49cb66
|
2021-08-09T10:01:13
|
|
Roll vulkan-deps from ad1ae9d489da to 8e25231b71ac (9 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/ad1ae9d489da..8e25231b71ac
Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/175ecd49ed..706dc27a62
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/4c901a731a..a2edd93673
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/28bd6d60be..9db21837b8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: syoussefi@google.com
Change-Id: I5b2573412586f8460f4ab802e59adcdfea2ea7d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3080663
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
b1b760e7
|
2021-08-09T13:37:10
|
|
Ignore VUID-vkCmdClearAttachments-baseArrayLayer-00018
New message added in
https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/3133
Blocks vulkan-deps rolls.
Bug: angleproject:6262
Change-Id: Iaaafe7539092cbe7eadd01e47b67071d60779929
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3081376
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
23a50a7c
|
2021-08-06T18:15:30
|
|
Serialization: Fix groups & ensure compile resolution.
This change has two fixes:
1) Some texture groups had multiple duplicate keys. Namely image
descs and image contents.
2) Programs and Shaders would serialize non-deterministically
because we would not ensure the compile/link was resolved. Fix
this by explicitly ensuring the shaders/programs are done.
Bug: angleproject:5133
Change-Id: I2f7f7768c76f90275f81e032ac08e3f2bc828ea2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076134
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
06b19ed8
|
2021-08-06T17:02:36
|
|
Framecapture: Update file naming
Update the file naming to add "shared" and remove the unnecessary frame
numbering:
angle.angledata.gz
angle_capture_context1.cpp
angle_capture_context1.h
angle_capture_context1_files.txt
angle_capture_context1_frame001.cpp
angle_capture_shared.cpp
angle_capture_shared.h
Bug: angleproject:6256
Change-Id: I6454a3dc412896557f29faee1269dfa55146d43b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3078908
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
4686da27
|
2021-08-06T18:13:14
|
|
Add GetImage test with RGB.
This test covers a case in T-Rex with an unused RGB texture that
was tripping up serialization. It isn't currently possible to make
the test fail but it does cover some new code paths.
Bug: angleproject:5133
Change-Id: I87c066779f270752bed3c1c1882951c71f16d378
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076133
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
0e88f240
|
2021-08-06T18:20:05
|
|
EGLWindow: Add option to force robust init.
Not currently used but may be useful in the future.
Bug: angleproject:5133
Change-Id: I11c082a3285587217d5b955048547b0617b8c51b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076132
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
7ed0729d
|
2021-08-06T15:10:58
|
|
EGLWindow: Add option to enable capture limits.
This will be useful for the replay serialization validation.
Bug: angleproject:5133
Change-Id: Ib5bb2a9522b0e35e47bdf2b1321fe6a18dcdb897
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076131
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
fd4590a6
|
2021-08-09T07:01:03
|
|
Roll Chromium from 29702b8b93b0 to bfd7c5a55cd0 (62 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/29702b8b93b0..bfd7c5a55cd0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/8388d56981..1b131580ae
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/4d423d82f5..97a17ccfc8
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c71b1c718d
No update to Clang.
Bug: None
Tbr: syoussefi@google.com
Change-Id: I4919c503ec72b7325511a3901abb873779845f19
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3080699
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
6c415487
|
2021-07-26T13:08:46
|
|
Capture/Replay: Add option to override test disabling
In order to be able to easily run disabled tests, add a flag
--force-run-capture
that makes it possible to ignore the SKIP_FOR_CAPTURE designation.
Bug: angleproject:6166
Change-Id: I195248045d5c928d965f16b5ae17681d78686374
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3053363
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
af35fd22
|
2021-07-12T14:58:01
|
|
Capture/Replay: rework test runner to use expectations
This CL changes the test runner to use a expectation
file for all the tests including failing tests.
The expectation file is also used to disable running certain
tests. e.g. because they are known to crash or result in
compilation failures, which then take down all the test
in the corresponding batch.
The capture_replay_tests.py script will report failure if the
test result doesn't meet the expectation. In order to keep
the current behaviour to run subsets of tests in tact, the
test filter is also applied to the expectation.
In addition to the "normal" expectations, FLAKY was added to
tag tests that can be captured and compiled correctly but have
unstable results.
This CL also adds the expectation for ES2_Vulkan_SwiftShader
and ES2_Vulkan
Bug: angleproject:6166
Change-Id: Ica05303e6ae3b7c6d2b6749c2c9c6593b659cc1a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3024209
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
7f38e289
|
2021-08-08T01:17:25
|
|
Roll Chromium from 54236e566eab to 29702b8b93b0 (355 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/54236e566eab..29702b8b93b0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/1398273c28..8388d56981
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/90f7ea6722..4d423d82f5
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c71b1c718d
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5339c686ff..e989bf92db
* tools/luci-go: git_revision:467ab48f5ed9f3ef32ae17f5b73a117e0c86566b..git_revision:e7749d37e8e52fd6eb9c79266a17d7fcb6f6ec04
* tools/luci-go: git_revision:467ab48f5ed9f3ef32ae17f5b73a117e0c86566b..git_revision:e7749d37e8e52fd6eb9c79266a17d7fcb6f6ec04
* tools/luci-go: git_revision:467ab48f5ed9f3ef32ae17f5b73a117e0c86566b..git_revision:e7749d37e8e52fd6eb9c79266a17d7fcb6f6ec04
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/da62336ef6..55fedb1a47
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/22df772766..e4df839dbe
No update to Clang.
Bug: angleproject:6158,angleproject:6228
Tbr: syoussefi@google.com
Change-Id: Iec4d0184871e7eaf74d4acd49d1f822451603e01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3079560
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
1654537d
|
2021-08-06T17:49:52
|
|
Fix default and driver uniforms' binding indices.
These abstractions were introduced in the SymbolTable during
upstreaming of the direct-to-Metal compiler and were accidentally
swapped, leading to widespread test failures.
Fix the comment reference in ContextMtl's DriverUniforms struct. Add
missing emulatedInstance field, and add a TODO about its missing
support in direct-to-Metal translator. Define it in SPIR-V Metal
translator; the driver uniforms for the two must match.
Bug: angleproject:6259
Change-Id: I0330ab4efca5b64a749b9cca90564fdbc84d7a80
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3078998
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
e70a1444
|
2021-08-05T12:49:21
|
|
Vulkan: Fix draw FBO1 followed by resolve FBO2
When syncing the framebuffer for blit/resolve, the render pass was not
closed. This would be done later when necessary, except that
onFramebufferChange called from FramebufferVk::syncState attempted to
adjust the render area of the render pass (as it considered it open). If
FBO2 is larger than FBO1, this would cause the render area of the
previous render pass to become larger than the framebuffer size.
This change makes sure that onFramebufferChange considers the render
pass closed no matter what.
Test is based on patch from steven@valvesoftware.com
Bug: angleproject:6244
Change-Id: Iaec04232cfd2af04ba2564fd2de1dd5f08a40df6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076620
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
c664601d
|
2021-04-26T17:08:06
|
|
Allow drawing if a fragment shader isn't present
According to the OpenGL ES 3.1 spec:
7.3 PROGRAM OBJECTS
If there is no active program for the vertex or fragment shader
stages, the results of vertex and fragment shader execution will
respectively be undefined.
If there isn't an active program for only one of these shader
stages, the results of the other shader stage are still defined.
To handle this, we no longer no-op the draw call if one of these
is missing. We only no-op the draw if there's no vs.
This allows for transform feedback to be captured when there's only
a geometry and vertex shader.
Tests: KHR-GLES32.core.geometry_shader.api.program_pipeline_vs_gs_capture
Tests: KHR-GLES32.core.separable_programs_tf.geometry_active
Tests: ProgramPipelineTest31.PipelineWithoutVertexShader*
Tests: ProgramPipelineTest31.PipelineWithoutShaders*
Bug: angleproject:5579
Change-Id: If9849cc398c307232435b167ab12431fa4258201
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2906723
Commit-Queue: Brandon Schade <b.schade@samsung.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
cf090996
|
2021-08-05T16:20:39
|
|
Vulkan: Call onFramebufferChange from a single place
When sRGB control mode was dirty, onFramebufferChange was called which
may not have been necessary if the actualy state hadn't changed. This
removes a call to onFramebufferChange() in this path, and leaves it to
be naturally called if the framebuffer desc actually changes.
Bug: angleproject:5075
Change-Id: I177572a3cb819d7e1ecd589f46e03da4b967529e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076619
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d191bc32
|
2021-08-06T12:59:39
|
|
Reintroduce TType::isRank0.
This concept was used in the direct-to-Metal compiler, and its
replacement with isScalar wasn't completely correct. Fixes several
assertion failures in tests.
Bug: angleproject:4889
Bug: angleproject:5505
Change-Id: I9b8800ed50591560c8e53faa81eca581c4f07a02
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3078474
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
934ffac6
|
2021-08-05T15:43:32
|
|
Vulkan: Propagate BufferData changes to shader storage buffer binding
This CL adds context to the observer list of shader storage buffer. When
BufferData is called on the current bound shader storage buffer, context
gets notified and DIRTY_BIT_SHADER_STORAGE_BUFFER_BINDING gets set.
Bug: b/195678877
Change-Id: Id8a5266942e33f0a834d7c57fdde75f57e93d347
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076177
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
63248e7f
|
2021-08-05T23:49:23
|
|
Translator: Fix dead-code-elimination corner case
The DCE code had a corner case bug where a switch case containing
multiple DCE'ed `break`s followed by another case would cause some of
the DCE'ed statements in the first case to be doubly pruned, failing on
an assertion.
This was due to the fact that visitBlock() was asking traversal to
continue if a new case was visited while pruning nodes, but the
traversal does not take into account that some statements need to be
skipped and so would also visit the pruned statements. If the pruned
statements contain a branch instruction, they get re-pruned.
The visitBlock() function that does the pruning is reworked so that it
more clearly traverses the statements.
Bug: chromium:1237200
Change-Id: Ib078c2ea73ade756c7d7ef5a5c489fa53c39f352
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3077659
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
07c21bcc
|
2021-08-06T01:54:58
|
|
Add run-time switch for direct-to-Metal compiler.
Setting the environment variable:
ANGLE_USE_MSL_COMPILER=1
will switch from the SPIR-V Metal to the direct-to-Metal compiler.
This makes it easier to diagnose regressions as the direct-to-Metal
compiler is upstreamed.
Bug: angleproject:5505
Change-Id: I78593e8ddc4e483bb0795960c432bcfa17e0a5b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076332
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
|
0cd99779
|
2021-08-05T10:35:10
|
|
Translator: Propagate precision to children nodes
Similarly to glslang, when the precision of a node is determined,
propagate that precision to any of its children that doesn't already
have a precision. Ultimately these should only include
TIntermConstantUnion nodes.
Bug: angleproject:4889
Bug: angleproject:6132
Change-Id: I121231d04c7cf92fc3f07716019ffe88eca48b88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3075126
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
c6f5b67e
|
2021-08-05T08:09:24
|
|
Give auto-roller ownership over ANGLE.
This will allow the auto-roller to both update DEPS and the auto-
generated sources.
Bug: angleproject:6247
Change-Id: Ib142ea94e34889ff4662b3c19420497c449c8789
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3075121
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
8387f10f
|
2021-08-06T21:46:02
|
|
D3D9: Mark destination images dirty after CPU-copy path
Fixes WebGL CTS failures for L and LA formats in:
conformance/textures/image_bitmap_from_canvas
conformance/textures/webgl_canvas
Bug: angleproject:2192
Change-Id: If3a9bd81298c76320ed029617fd4965efe4e8ef0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076720
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
16a61bbb
|
2021-08-05T23:06:22
|
|
D3D: Fix not notifying RenderTarget release in TextureD3D
This could lead to use-after-free for the RenderTarget object.
Bug: chromium:1234829
Change-Id: I73d4547b8f09f2f2cf3f7f8394f7f573fe5a4ef5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3063858
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
c5fa9a44
|
2021-08-05T15:27:47
|
|
Vulkan: Add test for BufferData change is propagated to SSBO properly
When BufferData is called while previous reference is still pending,
ANGLE may allocate a new storage. When this happened, we need to ensure
context gets notified so that it can pick up new buffer storage.
Bug: b/195678877
Change-Id: Idb591ed49e7d2c9e2dc5803f65d00894687ae1d3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076820
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
e28fb127
|
2021-08-05T14:32:16
|
|
Vulkan: Propagate BufferData changes to atomic counter binding
This CL adds context to the observer list of atomic counter buffer
so that it gets notified when BufferData is called on atomic counter
buffer and set dirty bit accordingly.
Bug: b/195678877
Change-Id: I924cf12ef54b5986d5c56b9e3b71584039490206
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076170
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9acae0d5
|
2021-08-06T15:03:18
|
|
Roll Chromium from 3d40e0a2ae46 to 54236e566eab (96 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/3d40e0a2ae46..54236e566eab
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/3ad4b0999c..1398273c28
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/8b9e975e71..90f7ea6722
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2e0d77d800
No update to Clang.
Bug: angleproject:6090
Tbr: syoussefi@google.com,jmadill@google.com
Change-Id: Id60635cd7fdfb8ca79f1a187c9be7d68d9ced469
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3078204
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
52aae056
|
2021-08-05T14:22:26
|
|
Vulkan: Test for buffer storage propagate to AtomicCounter properly
When BufferData call result in storage change, it should propagate the
change to atomic counter buffer binding properly. This CL adds a test to
call BufferData on the same buffer while the previous usage of buffer is
still pending (thus may trigger reallocation of buffer storage) and see
if shader reads correct atomic counter buffer data.
Bug: b/195678877
Change-Id: Iac94c3bd0a73573da0bfc814d33b5cd43475772d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076819
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
4a841e6a
|
2021-07-27T13:30:26
|
|
PerfTests: Replay EGL color spaces.
Add EGL_GL_COLORSPACE_KHR to the EGLWindow's surface attributes if
EGL_KHR_gl_colorspace is available.
Require the extension to be available if the color space differs from
the default EGL_COLORSPACE_LINEAR value.
Bug: angleproject:5857
Change-Id: Ib33cbed7d4b115979bd847418cb5cd2b96f4f173
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3056374
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
89dbbb2a
|
2021-08-05T13:14:12
|
|
Skip validation of stderr in TestSuiteTest.RunFlakyTests
There is a bug (crbug.com/1234124) causing the profile runtime to print
errors about failing to write the profraw file. Don't validate stderr in
these builds until that is fixed.
Bug: chromium:1234124
Change-Id: Ie1e3a3eaf7dc0e2c20064822f774cc85fe79d3bc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076479
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
6520b6c3
|
2021-08-06T10:01:36
|
|
Roll SwiftShader from e4b7794ddbee to b2af6a85583d (3 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e4b7794ddbee..b2af6a85583d
2021-08-06 swiftshader.regress@gmail.com Regres: Update test lists @ 8532b0f2
2021-08-05 capn@google.com Implement VK_EXT_custom_border_color
2021-08-05 swiftshader.regress@gmail.com Regres: Update test lists @ e4b7794d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: angleproject:6200
Tbr: syoussefi@google.com
Change-Id: I6589300f60d944fb32479102efad7bf4d093d0ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3077722
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
12ddb007
|
2021-08-06T10:01:16
|
|
Roll vulkan-deps from 5a3686a46647 to ad1ae9d489da (5 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/5a3686a46647..ad1ae9d489da
Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/366d1be5e8..175ecd49ed
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/27a13fa6a1..28bd6d60be
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: syoussefi@google.com
Change-Id: I917dcb4b03a4248015755eca5c8dd568bbb99e35
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076333
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
25d60305
|
2021-08-06T08:52:24
|
|
Roll Chromium from 4867b99b3f43 to 3d40e0a2ae46 (416 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/4867b99b3f43..3d40e0a2ae46
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/8607487b3e..3ad4b0999c
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/36299f559a..8b9e975e71
* third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/c3565d6e1f..d5413f72f6
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2e0d77d800
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0a4dd4181a..5339c686ff
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a6e918faf0..6a8e571efd
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0026263559..da62336ef6
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/42dc1265c0..22df772766
No update to Clang.
Bug: angleproject:6230
Tbr: syoussefi@google.com
Change-Id: Icec5796cbfbeeebdddc975e0fbc6e80524cca8c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3076331
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
9b646c13
|
2021-08-04T17:24:18
|
|
Tests: Add Final Fantasy trace
Test: angle_perftests --gtest_filter="*final_fantasy*"
Bug: b/195607411
Bug: angleproject:6246
Change-Id: Ie0f02d082d408a6eb18555741ab01cccc446d01f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3073380
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
ab19e742
|
2021-08-04T18:41:51
|
|
Match DebugAnnotator::{begin|end}Event() calls
The tests for whether ScopedPerfEventHelper::~ScopedPerfEventHelper()
should call DebugAnnotator::endEvent() were not valid:
- The test in ScopedPerfEventHelper::begin() simply checks whether a
DebugAnnotator has been initialized.
- In addition, ScopedPerfEventHelper::~ScopedPerfEventHelper() also
checks whether DebugAnnotator::getStatus() returns true, which will
always be false when the generic LoggingAnnotator is pluged in.
- The check in ScopedPerfEventHelper::~ScopedPerfEventHelper() must
take into account whether EGL_Initialize() or EGL_Terminate()
changed g_debugAnnotator, and whether ScopedPerfEventHelper::begin()
called DebugAnnotator::beginEvent(), and so a matching endEvent()
should be called.
The check in ScopedPerfEventHelper::~ScopedPerfEventHelper() is now
simplified.
Bug: angleproject:6158
Change-Id: I7fbd19cd0a372ef3ce3600c5d3fc50234b53ca38
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3072564
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
2e8a2d3c
|
2021-08-04T11:04:44
|
|
Translator: Helpers to derive precision
Bug: angleproject:4889
Bug: angleproject:6132
Change-Id: I75e2084c76139ccb24b266f262d5e5597d8aa4ca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3071599
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
3fd572c4
|
2021-08-04T12:45:09
|
|
FrameCapture: Fix setCaptureActive() and MEC timing
Frame capture is currently off by one when calling setCaptureActive()
and collecting the mid-execution capture state. The MEC state is
collected at frame N, but setCaptureActive() isn't called until frame
N+1, meaning all of the maybeCapturePreCallUpdates() and
maybeCapturePostCallUpdates() calls are not tracking resources correctly
for frame N.
This CL fixes when setCaptureActive() is called relative to when
setupSharedAndAuxReplay() is called, so the trace is active for the
first frame and all of the resources are correctly tracked.
Additionally, setCaptureActive() during the FrameCaptureShared() ctor if
frame capture starts with the first frame.
Bug: angleproject:6225
Change-Id: Id07e78b2da9c9d33779e20ab6a42f63cd103a6a6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3071940
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
061188a7
|
2021-08-04T10:07:47
|
|
Translator: General clean up
General clean up done as part of other changes, split to simplify
review.
Bug: angleproject:4889
Bug: angleproject:6132
Change-Id: Iade9954d187a759be9edd0e3754be007f4133c56
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3071598
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
f9c287f0
|
2021-08-04T17:24:02
|
|
Capture/Replay: Fix reset for immutable textures
Before this CL, we were including TexStorage in the calls to reset an
immutable texture. This throws an error in GL, as you can only call
TexStorage once on a texture.
Example from ResetReplay():
glBindTexture(GL_TEXTURE_2D, gTextureMap[52]);
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, 9729);
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_SWIZZLE_R, 0);
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_SWIZZLE_G, 0);
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_SWIZZLE_B, 0);
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_SWIZZLE_A, 6403);
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAX_LEVEL, 0);
glTexStorage2D(GL_TEXTURE_2D, 1, GL_R8, 256, 512); // <== ERROR
glTexSubImage2D(GL_TEXTURE_2D, 0, 0, 0, 256, 512,
GL_RED, GL_UNSIGNED_BYTE, ...);
To fix this, move TexStorage into the calls used to regen the
texture rather than restore its contents. This means ResetReplay will
only call TexStorage again if the texture was actually deleted.
Example new regen sequence, if the texture had been deleted:
const GLuint deleteTexturesPacked[] = { gTextureMap[52] };
glDeleteTextures(1, deleteTexturesPacked);
glGenTextures(1, reinterpret_cast<GLuint *>(gReadBuffer));
UpdateTextureID(52, 0);
glBindTexture(GL_TEXTURE_2D, gTextureMap[52]);
glTexStorage2D(GL_TEXTURE_2D, 1, GL_R8, 256, 512);
Also rename texCalls to texSetupCalls to more easily distinguish
from texGenCalls, now that they intermingle.
Test: Final Fantasy MEC
Bug: b/195607411
Bug: angleproject:6246
Change-Id: I37daaeb6ea4337969cb241a20256fec07dce514e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3073379
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
6fe91881
|
2021-08-02T11:13:13
|
|
Translator: Simplify RecordConstantPrecision
Just before ESSL output, this transformation made some constants
specified through temp variables such that their precision can be
specified. This was done in cases where the precision actually affected
the expression being evaluated.
This transformation is simplified by declaring constants more
conservatively as variables, and not stringently attempting to identify
whether that's necessary. This is still not done in trivial cases.
This change is in preparation for another change that overhauls
precision propagation through the nodes. This change removes all
references to TIntermTyped::getPrecision() outside the precision
promotion code itself.
Bug: angleproject:4889
Change-Id: I135b2b3241aa2f76219b209241c3844f1d09ccd2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3067948
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9926ed76
|
2021-08-05T13:12:02
|
|
Roll VK-GL-CTS from 0eb84cfc3d3f to bf3d63599bad (5 revisions)
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/0eb84cfc3d3f..bf3d63599bad
2021-08-05 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/master
2021-08-05 rgarcia@igalia.com Test multiview with VK_EXT_multi_draw
2021-08-05 piotr.byszewski@mobica.com Add sample mask test for FSR
2021-08-05 venni.ihanakangas@siru.fi Remove fallback and unify testing for image clearing tests
2021-08-04 piotr.byszewski@mobica.com Portability: fix osx target
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC syoussefi@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: syoussefi@google.com,angle-bots+autoroll-info@google.com
Change-Id: I0953e406bbeafdbcb6c01eeae463e5897545ecc4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3074825
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
798c5200
|
2021-07-31T22:17:48
|
|
Translator: Make precise-ness a property of AST nodes
Instead of creating a "set of precise nodes", the nodes themselves are
marked precise. This change is preparation for another change that
overhauls precision propagation through the nodes, and which would also
be storing the promoted precision in the nodes.
Bug: angleproject:4889
Change-Id: Ieec8864be5cd2e95ed6fb4d90b367946d9f33fa1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3065569
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
39c7f077
|
2021-08-05T11:58:29
|
|
Roll vulkan-deps from 2395f179eff3 to 5a3686a46647 (30 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/2395f179eff3..5a3686a46647
Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5737dbb068..366d1be5e8
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/b8c57b0a09..9fe958cdab
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3aeed853ab..4c901a731a
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ba8c411641..8dca1fa770
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7dea9e9e08..27a13fa6a1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: syoussefi@google.com
Change-Id: Ieeab4f85f83433474ede63bc6ae90bbc25f039de
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3074821
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
7754534c
|
2021-08-05T10:01:44
|
|
Roll SwiftShader from d4483095765e to e4b7794ddbee (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/d4483095765e..e4b7794ddbee
2021-08-04 capn@google.com Remove unimplemented MaskedStore/MaskedLoad usage
2021-08-04 capn@google.com Optimize OpImageFetch for single-level mipmaps
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: syoussefi@google.com
Change-Id: I72ddd02f0beb84d61c5fe1978099c9c090e8afbb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3074363
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
32488705
|
2021-08-05T08:29:41
|
|
Roll Chromium from 9177048d3b1a to 4867b99b3f43 (252 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/9177048d3b1a..4867b99b3f43
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/f050dfee22..8607487b3e
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/e2e54e87a4..36299f559a
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..cb61e19efb
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7a262eba20..0a4dd4181a
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/dd02422d01..a6e918faf0
* tools/luci-go: git_revision:b32fc6edde4d5608ec57871438ff6d232155c225..git_revision:467ab48f5ed9f3ef32ae17f5b73a117e0c86566b
* tools/luci-go: git_revision:b32fc6edde4d5608ec57871438ff6d232155c225..git_revision:467ab48f5ed9f3ef32ae17f5b73a117e0c86566b
* tools/luci-go: git_revision:b32fc6edde4d5608ec57871438ff6d232155c225..git_revision:467ab48f5ed9f3ef32ae17f5b73a117e0c86566b
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/2571e59ac5..0026263559
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c2731e757d..42dc1265c0
* tools/skia_goldctl/linux: Pc3OHV2QqhJ1IA5WQWr_kZ72iUVitbAX-iQN7j8sfcQC..H5Ax0_QmNml9Df-r61hCscndRQDsCim7j6-ST_Bqc7QC
* tools/skia_goldctl/mac: KASmGKR0ayqtBOEyjhnO0Bt_YP_U602cxGcJOOjhAPoC..VP9yR_72z50Efyz4lp6uXyLhZowfvEScnoGf8RMWlHAC
* tools/skia_goldctl/win: XfCGeDXrOWGLHwo_HFFlERuqKHW2zZGUGnF1DzCyCP0C..P8MltnujOo50R-Kl3rxhuKLOYs02wz_YJUkzOruEDYwC
Clang version changed llvmorg-13-init-15561-gf98ed74f:llvmorg-14-init-591-g7d9d926a
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/dd02422d012e13533d684953a97ebcdc491b5770..a6e918faf00591d454b99946f298e9603fd6994b/scripts/update.py
Bug: None
Tbr: syoussefi@google.com
Change-Id: If476129c22853a2c07a03179fb4fb6a585af3a48
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3073900
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
9da4e52b
|
2021-08-04T09:13:33
|
|
Tests: Add PUBG Mobile battle royale trace
Test: angle_perftests --gtest_filter="*pubg_mobile_battle_royale"
Bug: b/180418573
Bug: angleproject:6087
Bug: angleproject:6240
Change-Id: I722f249a7aafdd52be96f214d56b7cfa650ae778
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3071662
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
14802390
|
2021-08-04T18:40:40
|
|
Roll Chromium from 0b6b7ef9940d to 9177048d3b1a (237 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/0b6b7ef9940d..9177048d3b1a
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/f8bccc2739..f050dfee22
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/492ff4a1fb..e2e54e87a4
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/ae11d2854e..09da6e47b4
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..cb61e19efb
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a992238bf0..7a262eba20
* tools/luci-go: git_revision:ef18edd2fa067d8bf14c006abc03993f2c1eb1b9..git_revision:b32fc6edde4d5608ec57871438ff6d232155c225
* tools/luci-go: git_revision:ef18edd2fa067d8bf14c006abc03993f2c1eb1b9..git_revision:b32fc6edde4d5608ec57871438ff6d232155c225
* tools/luci-go: git_revision:ef18edd2fa067d8bf14c006abc03993f2c1eb1b9..git_revision:b32fc6edde4d5608ec57871438ff6d232155c225
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5058076121..2571e59ac5
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2e8aac4859..c2731e757d
No update to Clang.
Bug: None
Tbr: syoussefi@google.com,ynovikov@google.com
Change-Id: I9133d321bf3a83355a83813e7a276e680219de66
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3071939
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
e4156549
|
2021-08-04T17:28:53
|
|
Roll googletest
Needed to build latest abseil crrev.com/c/3070639 to roll Chromium
Bug: None
Change-Id: I628b11649bf49936b96e0c74a1b15500b68d5693
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3071944
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
1ce78397
|
2021-07-30T16:51:45
|
|
Remove support for WEBGL_debug_shader_precision
This extension was rejected, and the implementation was hacky. This
clean up is part of an ongoing work to improve precision handling.
Bug: angleproject:6059
Change-Id: If08581ec6f19cf1698ffa3dd6d248dc5e68a1d31
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3064303
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
7c072f7e
|
2021-08-04T09:02:30
|
|
Tests: Add PUBG Mobile skydive trace
Test: angle_perftests --gtest_filter="*pubg_mobile_skydive"
Tbr: jmadill@google.com, timvp@google.com
Bug: b/180418573
Bug: angleproject:6087
Bug: angleproject:6240
Change-Id: Ibcc7a5e84676d7e7e0df3fdad7aada0e23482bf2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3071661
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
884b8674
|
2021-08-04T03:41:14
|
|
Roll Chromium from b3e57670ca16 to 0b6b7ef9940d (588 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/b3e57670ca16..0b6b7ef9940d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/e5cb50de93..f8bccc2739
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/734ceaa3d4..492ff4a1fb
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..56c45f54de
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a806594b95..a992238bf0
* tools/luci-go: git_revision:db421da12bad8e57f97ee45b24147e34ec882007..git_revision:ef18edd2fa067d8bf14c006abc03993f2c1eb1b9
* tools/luci-go: git_revision:db421da12bad8e57f97ee45b24147e34ec882007..git_revision:ef18edd2fa067d8bf14c006abc03993f2c1eb1b9
* tools/luci-go: git_revision:db421da12bad8e57f97ee45b24147e34ec882007..git_revision:ef18edd2fa067d8bf14c006abc03993f2c1eb1b9
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b61f89672a..2e8aac4859
No update to Clang.
Bug: angleproject:6059
Tbr: syoussefi@google.com,ynovikov@google.com
Change-Id: I8527b9a3ff5aabded248465354fab6c97969adc8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3070298
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
091fb9b9
|
2021-07-23T10:44:35
|
|
Reland "Reland "GL: Fix GPU detection""
This is a reland of a8f9b79a14b923e925d4aecb5eb5d973f92ae4e1
It was assumed that getting the GPU info from the system will always
yield a valid Device ID, but this seems to be incorrect on some
platforms (e.g. Apple M1). Reland reverts to the old logic of silently
accepting 0 as Device ID.
Original change's description:
> Reland "GL: Fix GPU detection"
>
> This is a reland of 30dea869a7dc939f94048de23d70705247905c51
>
> Original change's description:
> > GL: Fix GPU detection
> >
> > Always use GL_VENDOR to determine vendor. On multi-GPU systems, this
> > ensures that the correct GPU is used to determine workarounds.
> > GetSystemInfo is still broken in that it assumes the discrete GPU to be
> > active, but with this change it will only affect the test infrastructure
> > (and not users).
> >
> > Bug: chromium:1187475
> > Bug: angleproject:6174
> > Change-Id: I4dffadf0e28c73e01d6b4bf49ab708c0714cdc7c
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3049350
> > Reviewed-by: Kenneth Russell <kbr@chromium.org>
> > Reviewed-by: Jamie Madill <jmadill@chromium.org>
> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
>
> Bug: chromium:1187475
> Bug: angleproject:6174
> Change-Id: Id0e5bae23f60e87d3de384e84dc5b8059013926d
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3067801
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: chromium:1187475
Bug: angleproject:6174
Change-Id: Ie13854da314d8963c33f61f1fd1628a674fae434
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3067768
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
09d5047b
|
2021-08-03T01:31:03
|
|
GL: Remove the rewriteVectorScalarArithmetic workaround
This workaround was implemented for a bug in Nvidia driver 387 which is
end-of-life. More recent driver branches (390 and 4XX) are fixed, and
so this workaround is no longer required. The implementation of the
workaround itself could introduce bugs.
Bug: chromium:772651
Bug: chromium:1201084
Change-Id: I3db179eb90d9124235bdad2daacc712302906d8e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3067952
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
|
10d50f64
|
2021-08-04T14:17:17
|
|
Revert "Reland "GL: Fix GPU detection""
This reverts commit a8f9b79a14b923e925d4aecb5eb5d973f92ae4e1.
Reason for revert: assertion failure on mac ARM bots: anglebug.com/6242
Original change's description:
> Reland "GL: Fix GPU detection"
>
> This is a reland of 30dea869a7dc939f94048de23d70705247905c51
>
> Original change's description:
> > GL: Fix GPU detection
> >
> > Always use GL_VENDOR to determine vendor. On multi-GPU systems, this
> > ensures that the correct GPU is used to determine workarounds.
> > GetSystemInfo is still broken in that it assumes the discrete GPU to be
> > active, but with this change it will only affect the test infrastructure
> > (and not users).
> >
> > Bug: chromium:1187475
> > Bug: angleproject:6174
> > Change-Id: I4dffadf0e28c73e01d6b4bf49ab708c0714cdc7c
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3049350
> > Reviewed-by: Kenneth Russell <kbr@chromium.org>
> > Reviewed-by: Jamie Madill <jmadill@chromium.org>
> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
>
> Bug: chromium:1187475
> Bug: angleproject:6174
> Change-Id: Id0e5bae23f60e87d3de384e84dc5b8059013926d
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3067801
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: chromium:1187475
Bug: angleproject:6174
Change-Id: Ice7a1246cb7ad0c257e685b1da4424aba8eaf406
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3067767
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
215d00b1
|
2021-08-03T23:34:02
|
|
D3D11: Add validation for storages size in updateBufferStorage
The source/dest BufferStorage used by the updateBufferStorage
may have a raw buffer ptr value of null.
Add size validation to prevent null crashes.
Bug: angleproject:6235
Change-Id: I57ed1ae0e558bd2f61273c64ed067958a1603425
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3069000
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
217acac2
|
2021-07-21T12:42:56
|
|
Vulkan: Add support for EXT_primitive_bounding_box
1. Added support for EXT_primitive_bounding_box extension
2. Renamed shader variable gl_BoundingBoxEXT[] to ANGLEBoundingBox[]
Bug: angleproject:3576
Test: dEQP-GLES31.functional.primitive_bounding_box.*
Change-Id: I15fa9af50c6fd8e86d225670ddd8eb39f6e65d35
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3053618
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
cb0b4b7e
|
2021-08-04T08:05:14
|
|
Perf Bots: Upload proper build URL.
We were missing setting the 'project' when communicating with
the upload script.
Bug: chromium:1236071
Bug: angleproject:6090
Change-Id: I984761483d9b47aecfe52366c47a972700266829
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3065831
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
db599f65
|
2021-08-04T10:01:44
|
|
Roll SwiftShader from dcfc0a6e2d84 to d4483095765e (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/dcfc0a6e2d84..d4483095765e
2021-08-03 capn@google.com Fix computing anisotropy factor for single-level mipmap
2021-08-03 swiftshader.regress@gmail.com Regres: Update test lists @ dcfc0a6e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: syoussefi@google.com
Change-Id: I068fe41787f0e207d40b16069ca3ed2e57a280be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3069431
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
35bdaf8d
|
2021-08-03T08:12:26
|
|
Capture/Replay: Minor cleanups.
Removes a duplicate assignment to the enabled variable. In the cpp
it's set to true, and in the header it was false. Also updates a
few variable names to be consistent with the group.
Bug: angleproject:5133
Change-Id: I3fb00ecc474191bea7c3a650ce23805b6f02d667
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3066007
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
5bbaa2c5
|
2021-08-02T15:50:11
|
|
Capture/Replay: Track arrayed uniform locations
Arrayed uniform values consume multiple locations. Until now we've
only tracked the starting location in our lookup table. This breaks
down when applications update uniforms in the middle of an array.
We don't have a location to provide. We need to start tracking a
location per entry.
To support this, pass in the uniform count to UpdateUniformLocation
and track a location for each array entry. Do it with an overload to
preserve functionality with existing traces.
Test: PUBG Mobile MEC
Bug: b/180418573
Bug: angleproject:6087
Bug: angleproject:6234
Change-Id: I74fbe201cb37273d1a5f361ef0c951e00ca89a88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3068199
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
8ca013e1
|
2021-08-03T21:22:31
|
|
Roll Chromium from c96bed01e3be to b3e57670ca16 (245 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/c96bed01e3be..b3e57670ca16
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/9ee6ac6515..e5cb50de93
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/8872b6cf61..734ceaa3d4
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0ad63d2356
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/6075f1fabd..563140dd9c
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d0097bccba..dd02422d01
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/56a35530fc..5058076121
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9c1129d333..b61f89672a
No update to Clang.
Bug: None
Tbr: syoussefi@google.com,ynovikov@google.com
Change-Id: I38e023adaf1a78946475e0fa2ed8fb215df4b470
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3069720
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
f9942640
|
2021-08-03T11:45:31
|
|
Translator: Fix fuzzer crashing on assertion
An assertion was triggered by the fuzzer when generating an invalid
shader that redeclared a built-in. The assertion itself was unnecessary
and the parser would appropriately generate an error if that assertion
would have fired.
Bug: angleproject:4889
Bug: chromium:1235229
Change-Id: I294b2e329491c75d4e87622b602570252555869f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3063910
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
a8f9b79a
|
2021-07-23T10:44:35
|
|
Reland "GL: Fix GPU detection"
This is a reland of 30dea869a7dc939f94048de23d70705247905c51
Original change's description:
> GL: Fix GPU detection
>
> Always use GL_VENDOR to determine vendor. On multi-GPU systems, this
> ensures that the correct GPU is used to determine workarounds.
> GetSystemInfo is still broken in that it assumes the discrete GPU to be
> active, but with this change it will only affect the test infrastructure
> (and not users).
>
> Bug: chromium:1187475
> Bug: angleproject:6174
> Change-Id: I4dffadf0e28c73e01d6b4bf49ab708c0714cdc7c
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3049350
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: chromium:1187475
Bug: angleproject:6174
Change-Id: Id0e5bae23f60e87d3de384e84dc5b8059013926d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3067801
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
a65b4056
|
2021-07-30T23:00:57
|
|
Reland "Translator: Clean up type cloning"
This is a reland of f016c4352f5203c10511df078b1ed5359afc1b35
Original change's description:
> Translator: Clean up type cloning
>
> TType has a constructor that aids cloning + helpers to convert between
> types. A number of places where a type is constructed from the
> information gathered from another type is changed to clone the type and
> then use one of these helpers.
>
> This clean up is part of an ongoing work to improve precision handling.
> This change removes many references to TType::getPrecision().
>
> Bug: angleproject:4889
> Change-Id: Ib85659ab5363b56ad298f8648fca856edc1ebf8b
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3063944
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Tim Van Patten <timvp@google.com>
Bug: angleproject:4889
Change-Id: I35772f178eb4f6cf2b64bfeb37a4a144acdb4daf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3067802
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
c5c8a25a
|
2021-08-03T14:40:33
|
|
Revert "Translator: Clean up type cloning"
This reverts commit f016c4352f5203c10511df078b1ed5359afc1b35.
Reason for revert: Suspect for crbug.com/1236060
Original change's description:
> Translator: Clean up type cloning
>
> TType has a constructor that aids cloning + helpers to convert between
> types. A number of places where a type is constructed from the
> information gathered from another type is changed to clone the type and
> then use one of these helpers.
>
> This clean up is part of an ongoing work to improve precision handling.
> This change removes many references to TType::getPrecision().
>
> Bug: angleproject:4889
> Change-Id: Ib85659ab5363b56ad298f8648fca856edc1ebf8b
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3063944
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Tim Van Patten <timvp@google.com>
Bug: angleproject:4889
Change-Id: I9b5ecacc410b41be382232292ceae2f7ea7906c7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3064393
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Austin Eng <enga@chromium.org>
|
|
|
1f0e2916
|
2021-08-03T13:42:28
|
|
Revert "GL: Fix GPU detection"
This reverts commit 30dea869a7dc939f94048de23d70705247905c51.
Reason for revert: Breaking roll into Chrome, see bug.
Original change's description:
> GL: Fix GPU detection
>
> Always use GL_VENDOR to determine vendor. On multi-GPU systems, this
> ensures that the correct GPU is used to determine workarounds.
> GetSystemInfo is still broken in that it assumes the discrete GPU to be
> active, but with this change it will only affect the test infrastructure
> (and not users).
>
> Bug: chromium:1187475
> Bug: angleproject:6174
> Change-Id: I4dffadf0e28c73e01d6b4bf49ab708c0714cdc7c
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3049350
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: chromium:1187475
Bug: angleproject:6174
Change-Id: I815c456b0e9775115ae6d2577b40399818b5bff5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3067800
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
e990fd0f
|
2021-08-03T10:01:15
|
|
Roll SwiftShader from 44660405ea6c to dcfc0a6e2d84 (6 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/44660405ea6c..dcfc0a6e2d84
2021-08-02 capn@google.com Fix ignoring fragment shader depth for EarlyFragmentTests mode
2021-08-02 capn@google.com Include multisample handling into fragment pipeline stages
2021-08-02 capn@google.com Only process active fragment samples
2021-08-02 capn@google.com Refactor sample shading state determination
2021-08-02 srisser@google.com Add Bias and Fetch to divergent Lod sampling
2021-08-02 srisser@google.com Optimize Lod and Grad texture sampling
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: syoussefi@google.com
Change-Id: I03ec6fa5deb5cceb50786f835101d48ece5e6d9e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3068651
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
|
|
|
747d5323
|
2021-07-27T13:30:59
|
|
gen_restricted_traces: Add kReplayDrawSurfaceColorSpace.
Use default color space if the trace doesn't specify one.
Use Python 3.6 f-strings for the possibility to have default
values at all positions and remove the now redundant defaults string.
This breaks Python 2 compatibility for gen_restricted_traces.py.
See PEP 498: https://www.python.org/dev/peps/pep-0498/
Bug: angleproject:5857
Change-Id: I532014e8e64ea792604a96a42ad998564882d801
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3056372
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
ac5bcdb3
|
2021-08-02T18:04:49
|
|
Vulkan: Use custom volk init function.
This should ensure we're using ANGLE's version of the loader.
Bug: chromium:1235314
Change-Id: Ia7318a922e192ce669a8cece070ab518ea421fd5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3067511
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
262dc97c
|
2021-07-27T11:13:59
|
|
FrameCapture: Capture the EGL color space.
Add a SurfaceParams struct containing extents and color space so
a single map can be used for all draw surface parameters.
Persist the color space in the trace's header.
Bug: angleproject:5857
Change-Id: I327da8c8870f2d76d057954af57d977a10ebb59f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3056371
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
85e49053
|
2021-08-02T07:50:32
|
|
Roll Chromium from 7ad7eb435b84 to c96bed01e3be (1394 revisions)
https://chromium.googlesource.com/chromium/src.git/+log/7ad7eb435b84..c96bed01e3be
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/96a4da9412..9ee6ac6515
* buildtools/linux64: git_revision:c0a2d23c21e87f27f5af3e5dc2a99f2ef3480b9e..git_revision:eea3906f0e2a8d3622080127d2005ff214d51383
* buildtools/mac: git_revision:c0a2d23c21e87f27f5af3e5dc2a99f2ef3480b9e..git_revision:eea3906f0e2a8d3622080127d2005ff214d51383
* buildtools/win: git_revision:c0a2d23c21e87f27f5af3e5dc2a99f2ef3480b9e..git_revision:eea3906f0e2a8d3622080127d2005ff214d51383
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/88e2d8b080..8872b6cf61
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/368be24f93..ae11d2854e
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..4505381167
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/2229323ff7..9ce4c7a678
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/dfbc590f58..6075f1fabd
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/2a8bb1ca80..d0097bccba
* tools/luci-go: git_revision:75ff299b9adf969190cafebe902255856a346f0b..git_revision:db421da12bad8e57f97ee45b24147e34ec882007
* tools/luci-go: git_revision:75ff299b9adf969190cafebe902255856a346f0b..git_revision:db421da12bad8e57f97ee45b24147e34ec882007
* tools/luci-go: git_revision:75ff299b9adf969190cafebe902255856a346f0b..git_revision:db421da12bad8e57f97ee45b24147e34ec882007
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ef691997d9..56a35530fc
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b210baf513..9c1129d333
Clang version changed llvmorg-13-init-16514-gb1777b04:llvmorg-13-init-15561-gf98ed74f
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/2a8bb1ca80b166cb11a81ffc35e8f374af240e04..d0097bccbaab2f439b83ba93c6634ba91ca882fb/scripts/update.py
Bug: None
Tbr: geofflang@google.com
Change-Id: I2dd100192c502e329200d8c94bd013fecbbece05
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3067054
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
30dea869
|
2021-07-23T10:44:35
|
|
GL: Fix GPU detection
Always use GL_VENDOR to determine vendor. On multi-GPU systems, this
ensures that the correct GPU is used to determine workarounds.
GetSystemInfo is still broken in that it assumes the discrete GPU to be
active, but with this change it will only affect the test infrastructure
(and not users).
Bug: chromium:1187475
Bug: angleproject:6174
Change-Id: I4dffadf0e28c73e01d6b4bf49ab708c0714cdc7c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3049350
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
f016c435
|
2021-07-30T23:00:57
|
|
Translator: Clean up type cloning
TType has a constructor that aids cloning + helpers to convert between
types. A number of places where a type is constructed from the
information gathered from another type is changed to clone the type and
then use one of these helpers.
This clean up is part of an ongoing work to improve precision handling.
This change removes many references to TType::getPrecision().
Bug: angleproject:4889
Change-Id: Ib85659ab5363b56ad298f8648fca856edc1ebf8b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3063944
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
61517a16
|
2021-08-02T16:49:32
|
|
Remove extra angle:: uses from ANGLEPestTest.cpp.
Bug: None
Change-Id: I7101398504c547b97b9184c56b252bef5198cecb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3067510
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
fc6ce9ba
|
2021-08-02T13:47:36
|
|
Fix unreachable case in test instantiate.
This error would only trigger when the "null" back-end was
disabled. This would happen on official builds of Chrome.
Bug: chromium:1235656
Change-Id: Icd516513fe28b2b6d6a451503fc690093371acb3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3067759
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
26329cb9
|
2021-07-30T09:55:24
|
|
Test Runner: Allow listing tests on Android.
Because of quirks with the Chromium-provided Android test runner,
we need to use a few tricks to get the test list output. We add
placeholder output for a single test to trick the test runner into
thinking it ran the tests successfully. We also add an end marker
for the tests list so we can parse the list from the more spammy
Android stdout log.
Will enable a Python wrapper script to list and run performance
tests outside of the GTest harness.
Bug: angleproject:6090
Change-Id: I810d4722e9a6efa03ef94208e516401890af1c37
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3062240
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
|
0ce5f85f
|
2021-08-02T12:05:17
|
|
Capture/Replay Tests: Skip crashing test.
PBOCompressedTextureTest.PBOCompressedSubImageWithUnpackRowLength/*
Was added in a CL that didn't test win-trace-rel.
Bug: None
Change-Id: I91b056b50b53a302816564d6f12a0ef0f765e675
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3067758
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
aca9f2e2
|
2021-07-29T17:49:26
|
|
Vulkan: SPIR-V Gen: Fix constructors with uniform parameters
When the constructor contains parameters from interface blocks, they may
have SPIR-V type specializations that was not previously accounted for.
The code is made more robust by retrieving the column/component types
when generating constructors through TTypes instead of modifying
SpirvTypes directly.
Bug was caught by the WebGL CTS.
Bug: angleproject:4889
Change-Id: I6c9df17a97fac8622dea55ed67c7bae1ce16d1bd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3061640
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
3a6a0e91
|
2021-08-02T08:01:33
|
|
Remove ASSERT in computeRowPitch about row length.
Compressed texture image uploads ignore unpack parameters. So it's
not an error if these parameters have non-default values. We just
ignore them anyway. This ASSERT was causing a crash in some edge
cases in debug and dcheck builds.
ASSERT introduced in https://crrev.com/c/348064
Bug: chromium:1235031
Change-Id: I1db6ebc9f5572a92ab16bb13da4c236f6fcb8ce2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3064986
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|