.gn

Branch


Log

Author Commit Date CI Message
Yuly Novikov c5a4aaab 2025-08-21T12:34:30 Roll chromium_revision c57f111ea1..fc7a6f6aa1 (1504489:1504499) This includes fixes to several breakages: 1. Change siso path in DEPS due to https://chromium-review.googlesource.com/c/chromium/src/+/6864442 2. For unknown reason, "gclient sync --deps=all" no longer downloads mac dependencies on linux. Change conditions for buildtools/mac and others from host_os to checkout_mac, so that roll_chromium_deps can process these dependencies. 3. Remove third_party/googletest (BUILD.gn) submodule and copy build files from Chromium verbatim. Then add third_party/googletest/src submodule, which was previously added via recursedeps. This is because old structure had to be updated manually, and now we can autoroll googletest. Making this change now, because is_nacl was removed in https://chromium-review.googlesource.com/c/chromium/src/+/6857278 but the corresponding removal from BUILD.gn https://chromium-review.googlesource.com/c/chromium/src/+/6723712 didn't get rolled in due to crbug.com/440040381. Also roll googletest sources while at it. https://chromium.googlesource.com/external/github.com/google/googletest/+log/c67de117379f4d1c889c7581a0a76aa0979c2083..244cec869d12e53378fa0efb610cd4c32a454ec8 4. Use "use_clang_modules = false" to suppress missing includes in LLVM. 5. Add "tools/win" dependency needed for abseil-cpp after https://chromium-review.googlesource.com/c/chromium/src/+/6857983 Change log: https://chromium.googlesource.com/chromium/src/+log/c57f111ea1..fc7a6f6aa1 Full diff: https://chromium.googlesource.com/chromium/src/+/c57f111ea1..fc7a6f6aa1 Changed dependencies * buildtools/mac: git_revision:cc7c61e105fb56183fd6c5c52bbe3c37ff724a0d..git_revision:ee5b7e32b961a9da1933e9f46a018ba6cac8ef60 * buildtools/win: git_revision:cc7c61e105fb56183fd6c5c52bbe3c37ff724a0d..git_revision:ee5b7e32b961a9da1933e9f46a018ba6cac8ef60 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/fb889d0363..62256178de * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/1e18dc54a0..4862f4f12d * third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/f43e2cc47f..d48cf42075 * third_party/android_build_tools/error_prone/cipd: wQ_Wsj0aINAwt4LrHHM6IEnMhVEAdvQtBFtLv7YL4PoC..vPi1VfStH9EQCdbZI5NAMcK7C_dWs3-8Frr1CAzIafEC * third_party/android_build_tools/lint/cipd: XO6ykSsPN632w1Hwz4YCLW0qC1KhVCn53F8FdJeuhKUC..8i-9CpSofgFA-RhKjreXIK0ZbDC8IhGVe2yvxRX0ku4C * third_party/android_build_tools/nullaway/cipd: mFkUqdlIqmMQ3rAaTHFmOBYjNFgFUQOmMlPG6PGgmHYC..Zk_ffB0B6qGrr2ZDKqCxAgnPmo4-5giVRIauRffZaZYC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/973ea8c7c6..8f103008c5 * third_party/android_sdk: https://chromium.googlesource.com/chromium/src/third_party/android_sdk/+log/e71ef403c5..f1c6b36cde * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8dc29cff6c..8512c34797 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eddc72dce5..778a576e20 * third_party/fuchsia-sdk/sdk: version:29.20250730.5.1..version:29.20250815.6.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6f8fe913d6..91206b4d03 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a6c815c69d..f7f5a32b3e * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/84c5262b57..bdc00ca63e * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/82c07b9654..46fede94c0 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/78c1ca719e..28e24a669f * third_party/r8/cipd: qD5apdNjxRv3dBblf27nEZYf7r_pbLEgfN7hWyXvP_UC..Xyh7Kdh-M2Dj5lwFGH2QRe7TFErRgYCvMFMkPiYnIwsC * third_party/r8/d8/cipd: qD5apdNjxRv3dBblf27nEZYf7r_pbLEgfN7hWyXvP_UC..pBaBgtFdvclLMBwz1H7s88bhc3ioF8iEyFh6rZ81054C * third_party/re2/src: https://chromium.googlesource.com/external/github.com/google/re2.git/+log/85c7c0fb11..6569a9a3df * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/5de5e7b6ba..cc36abecbc * third_party/turbine/cipd: TkTaFqF4Bs-JmFtxFV_Nfh4u5jh_401ZQsLhC7vIEqQC..9ZS5YYFBth7RSqNe7VLip-qJhk00WoicV_Qb0byHna8C * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/363a126ed2..044b44e6de * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/b44ad70ef5..7d8848041e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9d91ec919b..f10114ce19 * tools/luci-go: git_revision:2aa8d904a9f8cc8891d2710e4cf58156057fa4b3..git_revision:230495e01666a7468ff6803179519a5c93317083 * tools/luci-go: git_revision:2aa8d904a9f8cc8891d2710e4cf58156057fa4b3..git_revision:230495e01666a7468ff6803179519a5c93317083 * tools/luci-go: git_revision:2aa8d904a9f8cc8891d2710e4cf58156057fa4b3..git_revision:230495e01666a7468ff6803179519a5c93317083 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c5719eb114..513bc2117e * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/c1a26b544f..88de4dbaab * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/fa1df48579..f2fba99158 * tools/skia_goldctl/linux: 84tAKAqEtqjebJywg8jyXDWUVodNBYZraFt9RZ0A2pwC..46Onf_f3s_Mr84pViZFnexVYU47ArSn3knDqNZcIoYsC * tools/skia_goldctl/mac_amd64: dpgLOuWsqpBYSIj44DbnlJD7fnp640TD4cprUlwV0VMC..itdWmANhuoNsgIG1DuIe7XMdwQR4Vc9kkznuHSuPOekC * tools/skia_goldctl/mac_arm64: AU5OTil4VjYO94g8-Jhq02qBoLka6t-JsgKKEzllcy8C..aFRLGxnuqC86Y3ejs72PnkJfG0caCnrl72QiuxJ1XbkC * tools/skia_goldctl/win: DW55Ki0OZtTTzxrsItNbFeB9IDA9GBVXB647W6SOLN4C..sYuoNL-siny-CypUt4LuqE25k1hWho4rLa3T7ikBQAoC DEPS diff: https://chromium.googlesource.com/chromium/src/+/c57f111ea1..fc7a6f6aa1/DEPS No update to Clang. Bug: chromium:440040381, angleproject:40041909, angleproject:439777063 Change-Id: Id814e849a08a1533c246ed9d1803f8b7c90fa68b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6870430 Reviewed-by: Geoff Lang <geofflang@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Tom Sepez ff95cc93 2025-08-15T22:05:15 Enable clang unsafe buffers warnings for ANGLE. Then suppress all directories containing C++ source code to get a good initial state. Bug: b/436880895 Change-Id: Ib1e23015896078af7a1bec7d22cafdcd1fc713e2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6854299 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tom Sepez 7d8f0748 2025-08-06T20:12:29 Use the chrome plugin in select Angle build recipes Turn on the chrome plugin for use in future CLs so that additional checks may be someday performed against this code base. This CL should not affect any generated code or produce additional warnings. To do so, remove find_bad_constructs as code was not compliant, just not subject to the plugin. Bug: b/436880895 Change-Id: I73bcc263fe0fe1656bce5a75a74e270ecf004362 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6825145 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Junji Watanabe 0a47f441 2025-05-27T16:00:38 Set use_siso=true by default in .gn This CL enables use_siso=true by default. Developers builds will switch to Siso, or get suggestion to run `gn clean` to switch. Bug: b/401959048 Change-Id: I7cf7efecc9cd8c7816dbbd74ea48e66e61a1b6f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6589553 Auto-Submit: Junji Watanabe <jwata@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Yuxin Hu 26e790f7 2025-05-21T14:07:40 Update the gn arg to avoid warning message in gn desc json file After this change https://chromium-review.googlesource.com/c/chromium/src/+/6547915, using android32_ndk_api_level and android64_ndk_api_level gn args will results in a warning message generated at the top of the gn desc json file: WARNING Build argument has no effect. android32_ndk_api_level = 26 ^- Did you mean "android_ndk_api_level"? This causes the json.load() function in generate_android_bp.py failing when parsing the json file json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0) Update roll_aosp.sh to use the android_ndk_apk_level to remove the warning message. Also update the gn arg from android32_ndk_apk_level and android64_ndk_api_level to android_ndk_apk_level in other files. Bug: b/418837345 Change-Id: I12fa48dcb5638b37a9965d0adb339a2dee018297 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6576736 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
angle-autoroll 9554950c 2025-04-14T09:48:39 Roll Chromium from 75621a1b9953 to 95d3d27a122a (1865 revisions) https://chromium.googlesource.com/chromium/src.git/+log/75621a1b9953..95d3d27a122a Set `use_llvm_libatomic = false` per https://chromium-review.googlesource.com/c/chromium/src/+/6402716 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,yuxinhu@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/d580cf25e8..22ae602f01 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/dc03d452a6..4f86145940 * buildtools/linux64: git_revision:c0a46c5e8c316010baf1a0eb2d2ee5a86f73e4c2..git_revision:3468d4868725e310eff5f5cd9b6655110883f55b * buildtools/mac: git_revision:c0a46c5e8c316010baf1a0eb2d2ee5a86f73e4c2..git_revision:3468d4868725e310eff5f5cd9b6655110883f55b * buildtools/win: git_revision:c0a46c5e8c316010baf1a0eb2d2ee5a86f73e4c2..git_revision:3468d4868725e310eff5f5cd9b6655110883f55b * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b5aac41fd7..e7c83274e2 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/1e8b41f1ec..d3d8cbda8c * third_party/android_build_tools/manifest_merger/cipd: as9uz7sX05xpw-A5S-NU9MbMzlggbUhOfJdarGxMJ84C..w1Huot__EcTrBmzEJxI19VH5MTAP3uJJekb1hR_gL-MC * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d4a30bd2e4..df03b99ce9 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/3ea4639ac5..323c3f8758 * third_party/fuchsia-sdk/sdk: version:27.20250402.5.1..version:27.20250409.6.1 * third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/6f6dc922b8..98409c6c09 * third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/78140a7276..e01dce316d * third_party/libunwind/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/e2e6f2a67e..81e2cb40a7 * third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/7f56bd496d..f86693f91c * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/de1750a8ce..d93a5a8790 * third_party/r8/cipd: zwFzxlsxS07IH4Ed1SfJTUKKoelP1ZliLtFWZqW0OioC..S1YW2OlP8ThsNUXDptm52Ouvnwp9t9xpTy5LECvEOw4C * third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/79d087e955..7dabaa2489 * third_party/siso/cipd: git_revision:0dd559fac7db9d72c9cbee525ab596b8a10b79d0..git_revision:7462aaffc7da5c672efbac0f39e14d3a41862799 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/ce5a169f50..780819f635 * tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/9b28bb6693..40226a7819 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/374799d778..a7f7a7df1c * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/2aa6f329bf..3b0c718c2d * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b1212bb2fd..9cf85a5c01 * tools/protoc_wrapper: https://chromium.googlesource.com/chromium/src/tools/protoc_wrapper/+log/dbcbea90c2..8ad6d21544 * tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/b549758ca9..185329703b No update to Clang. Bug: angleproject:389733590, angleproject:410044007 Change-Id: I5eacd110f477717cd19a87fd287810a9726e373f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6453950 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Dirk Pranke 072eec08 2025-01-21T13:09:44 Use `exec_script_allowlist` in GN now that it is available. This CL renames the gn dotfile variable `exec_script_whitelist` to `exec_script_allowlist`, in order to be more inclusive. Bug: chromium:40713186 Change-Id: Iaf5ef131a64f3189e675acfd090c7043c3138df8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6188240 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Shahbaz Youssefi 6afff893 2024-07-24T10:05:37 Roll Rust tools with Chromium Bug: angleproject:349994211 Change-Id: I9360b869e59365ff41d35359ce5af47c878fa89f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5736063 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Yuly Novikov b71fe1c5 2024-05-16T15:10:09 Flatten vulkan-deps. Sub-repos will be now checked out in third_party directly, instead of under third_party/vulkan-deps. Bug: chromium:341002187 Change-Id: Ia1c10ce5e7865c164b29bdcabb6ab8a7e4ae35b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5545577 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Roman Lavrov <romanl@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Liza Burakova e8a3493f 2024-02-14T21:51:00 Initialize DisplayWgpu This change adds basic initialize to DisplayWgpu as well as adding APIs for DisplayGLX and DisplayWgpu. These APIs are necessary to ensure DisplayWgpu doesn't pull in necessary X11 headers that break builds. Bug: angleproject:8477 Change-Id: Icc6d9e7246a741def7a0337a296f9c1f9cec1415 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5259979 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Liza Burakova <liza@chromium.org>
Charlie Lao b8d5a423 2023-08-21T14:43:42 Add static_assert(std::is_trivially_copyable<LinkedUniform>(),"") Since we are using memcpy for LinkedUniform, it is desirable to utilize compile time assertion to ensure that in future if anyone modifies POD struct (and the class of data members of POD struct) and made it that no longer memcopy-able, we would immediately caught at compile time. std::is_trivially_copyable<>is exactly for this reason. In order to make this work, the POD struct and any data it uses can not have user defined copy constructor. The problem is that right now ANGLE is using clang_use_chrome_plugins=true, and chrome-style generates warnings if the complex struct (has more than 10 data members) does not define a copy constructor, and that warning causes build failure with -Werror. So clang_use_chrome_plugins=true and std::is_trivially_copyable have this conflicting requirements that I can not apply both. This has been raised to compiler team, but before we get a solution from them, if we have to make a choice, I think the better choice is to disable clang_use_chrome_plugins and apply std::is_trivially_copyable, since the later is more critical to ensure safety, while chrome-style is mostly trying to minimize the code size, but won't affect correctness/robustness. This CL sets clang_use_chrome_plugins to false, and removes the copy constructor and copy assignment operator from BitSetT and LinkedUniform and added static assertion is_trivially_copyable for LinkedUniform. Same thing applied to ProgramInput as well. In future once we have a better solution from compile team, we can re-enable clang_use_chrome_plugins and disable only for structs that requires is_trivially_copyable assertion. Bug: b/275102061 Change-Id: If33415ea61deda568d855a7dd6a4fd6042058be5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4799342 Reviewed-by: Roman Lavrov <romanl@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
angle-autoroll 219776e2 2023-03-28T09:56:25 Roll Chromium from c83e966b4c7e to f7c2a70f23b1 (1902 revisions) Disable Rust toolchain support in standalone ANGLE, to avoid unnecessary dependencies. https://chromium.googlesource.com/chromium/src.git/+log/c83e966b4c7e..f7c2a70f23b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC angle-team@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/32e94e55de..052437a6e1 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0a6c69640f..c97a3b8902 * buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/e44019bfac..26ace673c4 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f132d63e88..df3b0c9f14 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/4189179faf..115fe1141d * third_party/android_sdk/public: 3Yn5Sn7BMObm8gsoZCF0loJMKg9_PpgU07G9DObCLdQC..EWnL2r7oV5GtE9Ef7GyohyFam42wtMtEKYU4dCb3U1YC * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e838386fa0 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/479e1e9055..df528a9d7a * third_party/fuchsia-sdk/sdk: version:12.20230322.3.1..version:12.20230327.3.1 * third_party/kotlin_stdlib: zeFlVAEGvnpaj3JJujWHzRlUiBEm4XeeaMQzVsdW6D4C..XON2v801ZWS7FjApXO8Ev7Me7cOsIAnmqzyCXJuMwJ0C * third_party/r8: EGf7RQo3stt-vPTw69TaMGuNtnOx0Dbk1O-MBquwswYC..BTs9W6pUBDK8YTePjjF3Q0-ZQo1snO7GBCT6frWMIj8C * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7a7207a7f2..04d87bfe25 * tools/luci-go: git_revision:320bf3ed60cd4d24549d0ea9ee3a94394f2665ce..git_revision:3569ebf36f17a991aa4d26fd6e228cdf6e664d13 * tools/luci-go: git_revision:320bf3ed60cd4d24549d0ea9ee3a94394f2665ce..git_revision:3569ebf36f17a991aa4d26fd6e228cdf6e664d13 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/db6ffdf0ba..993b50afde * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/b55593f4dc..13f0b81ce5 * tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/b87bb2fac8..892ad5cc94 * tools/skia_goldctl/linux: iQ7zKud-gha6r9hEdwqYWRdOpeAs6gFfDxnviDUt4FQC..CHIKK9YvBNPOM_lAlqkfs4dTTbM6I-AKggA94sfc5PoC * tools/skia_goldctl/mac_amd64: 9Wfje1bt82IO9pJokAt9lboy59X_Pe-s0b4EpmH7RT4C..Gwb7laBBhkBhwP1nIoAb1EwklQ5sEon7g7r76v7jAasC * tools/skia_goldctl/mac_arm64: zihT2Lk2afg0XzIZozuGcZXWv7RJujaDEi_6q7QL4DgC..Jh19SHnigVXYxpk7Fp4ZDMF_ZvLpQUie2NMaK5aEISMC * tools/skia_goldctl/win: we56UJIWxJJ2GkQ_ne0o3oGAr7FBJa5T5Jr1xguLn-gC..pUOVquC14y84RkNMzEAPw_7tztey-kvH7KBwGsFViuIC No update to Clang. Bug: chromium:1292038 Change-Id: Ie7f8204e241101673768257be9c003343bc47256 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4376783 Reviewed-by: Geoff Lang <geofflang@chromium.org>
angle-autoroll 7108e069 2021-06-08T09:55:11 Roll Chromium from 3bcc8fd7c291 to 6c5859c895f5 (510 revisions) https://chromium.googlesource.com/chromium/src.git/+log/3bcc8fd7c291..6c5859c895f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/e353b02625..8870cb4120 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0b443d31ef..c793cca886 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/a45949a818..a62f8260df * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/42884eb2ac..887e8d9009 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d598390f02 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a5b6b2f8b7..b508ecd932 * third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/9523daa51d..82f8803671 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0c64e8349d..09481f56be * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d5d794a9f5..94630dfc19 * tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/71214b910d..84ad259424 No update to Clang. Manually added tools/android/modularization/convenience/lookup_dep.py from crrev.com/889754 And updated .gn to use python3 in GN build by default Bug: angleproject:6042 Tbr: syoussefi@google.com Change-Id: I00384f4d38d14b54778d334aec9c633f54d619bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2946825 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill d170f8e1 2021-04-20T19:17:17 infra: Add configs for Android build. Updates the configs to use the new protobuf properties. Adds support for ARM/ARM64 Android builds. Must be landed in conjunction with http://crrev.com/c/2841787 . Bug: angleproject:2344 Bug: angleproject:5114 Change-Id: I49f4f46ceaa7ce9118c9f4b4ceb06353b00429b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842306 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 68f1203d 2021-04-13T21:55:07 Disable location tags in test isolates. The current setup has problems producing tags in an ANGLE checkout. Bug: angleproject:5114 Change-Id: I91864650ddb2a9df0ac533bf4c43259c476a99ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822238 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Jamie Madill acd15cae 2020-10-11T17:16:34 Re-land "Link C++ histogram support into angle_perftests." This is the first step in uploading histogram data instead of a gtest special format. We importing several new libraries: - tools/protoc_wrapper - third_party/protobuf - third_party/catapult (was already used for Android) No functional change. Only affects compilation. Protobuf support is disabled when not available. Bug: angleproject:5161 Change-Id: I64be0977648993b1012ff0d9e0439c5876697e36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497221 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tim Van Patten 4953f03d 2020-10-23T22:57:43 Revert "Link C++ histogram support into angle_perftests." This reverts commit 7a0263547cda936b320d80c650b69d7522ee1a9f. Reason for revert: Breaks roll of ANGLE into AOSP: ERROR at //testing/test.gni:76:5: Assertion failed. assert(_use_raw_android_executable || enable_java_templates) ^----- See //third_party/catapult/tracing/tracing/BUILD.gn:35:1: whence it was called. test("histogram_unittests") { ^---------------------------- See //src/tests/BUILD.gn:262:17: which caused the file to be included. deps += [ "//third_party/catapult/tracing/tracing:histogram" ] ^------------------------------------------------- Original change's description: > Link C++ histogram support into angle_perftests. > > This is the first step in uploading histogram data instead of a gtest > special format. We importing several new libraries: > > - tools/protoc_wrapper > - third_party/protobuf > - third_party/catapult (was already used for Android) > > No functional change. Only affects compilation. Protobuf support is > disabled when not available. > > Bug: angleproject:5161 > Change-Id: Ie28d57d7e142c437ebd51463ce3e2cafd87468d1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2482294 > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> TBR=ynovikov@chromium.org,bsheedy@chromium.org,jmadill@chromium.org Change-Id: I62c4b926cbe82d10e460b28b5f864521e2b1f8ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:5161 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495549 Reviewed-by: Tim Van Patten <timvp@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
Jamie Madill 7a026354 2020-10-11T17:16:34 Link C++ histogram support into angle_perftests. This is the first step in uploading histogram data instead of a gtest special format. We importing several new libraries: - tools/protoc_wrapper - third_party/protobuf - third_party/catapult (was already used for Android) No functional change. Only affects compilation. Protobuf support is disabled when not available. Bug: angleproject:5161 Change-Id: Ie28d57d7e142c437ebd51463ce3e2cafd87468d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2482294 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Trevor David Black e815afbf 2020-09-07T22:09:22 First pass at increasing inclusivity Link to the inclusivity rules https://source.android.com/setup/contribute/respectful-code Bug: b/162834212 Bug: chromium:1097198 Change-Id: Ied5a9e3879d72bff3f77ea6fcda9b82f30c32c2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2396737 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Trevor Black <vantablack@google.com>
Tim Van Patten a42a7f06 2020-09-16T12:39:09 Remove setting a default value for use_custom_libcxx Update the .gn to remove forcing use_custom_libcxx = false. Instead, let //build/config/c++/c++.gni determine the value, which should better match Chromium. In particular, this helps with Abseil integration by supporting Windows component builds by better matching the contents of the .def files. Bug: angleproject:4873 Test: CQ Change-Id: If8c064f16459292bfb95113a4d78e14e8923f86f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2414739 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
Nico Weber f1e3609c 2019-05-13T08:55:54 angle: Stop setting secondary_source. It's no longer needed. Bug: chromium:947060 Change-Id: I873f17a4876b9d0fac313740853054b6867afeb9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610077 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
Geoff Lang 66ae5315 2019-04-01T16:35:53 Add a mac_toolchain update DEP. Update use_system_xcode to match Chrome. BUG=948286 Change-Id: I85f44622efaf4f018d00046e4fc5dc0757f38539 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545127 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
Jamie Madill ab2bfa81 2019-01-15T19:06:47 Enable Chromium clang style plugin for libANGLE. This fixes a few style warnings: * auto should not deduce to raw pointer type * inlined virtual methods are not allowed * non-trivial constructors and destructors should be explicit * inlined non-trivial constructors should not be in-class * missing override keywords Bug: angleproject:3069 Change-Id: I3b3e55683691da3ebf6da06a5d3c729c71b6ee53 Reviewed-on: https://chromium-review.googlesource.com/c/1407640 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Jamie Madill 624ce6a3 2019-01-04T14:17:24 Pass GN header visibility check. Updates angle_util to see the loader includes even if the loader is not enabled. This makes the GN check happy. Bug: angleproject:3052 Change-Id: Ifd23070385beefede4358c7b4c1823dc87b5ded8 Reviewed-on: https://chromium-review.googlesource.com/c/1395809 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Frank Henigman a7f97a27 2018-08-21T00:04:05 Gyp is dead. Long live gn. Remove the gyp build. The .gypi files were not renamed so that diff and rebase would work on this change. They will be renamed in a separate change. BUG=angleproject:1569 Change-Id: If8a217027633293664b820104f91a4ca5889b24e Reviewed-on: https://chromium-review.googlesource.com/1187380 Commit-Queue: Frank Henigman <fjhenigman@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Tobin Ehlis 9d4277b0 2018-05-21T16:22:22 Enable sysroot install on x86 & x64 based-systems For builds set "use_sysroot = true" by default This is intended to fix a bot config that is hitting a build error with latest Vulkan validation layer roll. Bug: angleproject:2560 Change-Id: I06edfc7b74f367bbab23fea6f01b2778b12a470a Reviewed-on: https://chromium-review.googlesource.com/1068031 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tobin Ehlis 9b1462a0 2018-05-21T16:40:57 Roll fwd ANGLE chromium DEPs Roll build, buildtools, clang, testing, googletest, zlib, gyp. Bug: angleproject:2560 Change-Id: Ic7f2a8bbdb9f6ff3bca1cd6d7ba424add7d086ad Reviewed-on: https://chromium-review.googlesource.com/1068064 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
Jamie Madill 7b7ada6a 2018-02-05T14:49:15 Add a dotfile_settings GN config file. This file will be imported into both ANGLE's and Chrome's .gn files so we can share some of the same settings. This will mean we no longer have to patch Chromium to make changes to the exec script whitelist. Bug: angleproject:2339 Change-Id: I2d7dd4237488ffecf5376643447ad95a0c1dbf98 Reviewed-on: https://chromium-review.googlesource.com/902324 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Frank Henigman d0ef13a2 2017-08-28T22:53:24 Stand-alone build with gn. This should do the same things as the stand-alone gyp build, but with gn. You should switch to gn as gyp support will go away. You need a recent enough version of gn. If yours is too old try this one: ./buildtools/linux64/gn If "gclient sync" or anything fails with an ImportError on gyp stuff, try running it with the following PYTHONPATH in the environment: PYTHONPATH=tools/gyp/pylib BUG=angleproject:1569 Change-Id: I56d19bec2d8b649a7bd65062c656cbfc69ea3dd8 Reviewed-on: https://chromium-review.googlesource.com/642588 Reviewed-by: Frank Henigman <fjhenigman@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Frank Henigman <fjhenigman@chromium.org>