|
6bdbe9cc
|
2025-05-01T12:33:41
|
|
Manual roll Chromium from dd275389e023 to cf3a960742c3 (1975 revisions)
Use third_party/depot_tools/gn.py instead of gn to accommodate
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504176
Manual roll requested by ynovikov@google.com
https://chromium.googlesource.com/chromium/src.git/+log/dd275389e023..cf3a960742c3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle-team@google.com,geofflang@google.com,ynovikov@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/88030b3203..aaf578b4fc
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/0f32cb9025..6d4e129ac6
* buildtools/linux64: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45
* buildtools/mac: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45
* buildtools/win: git_revision:90478db6b59b9bebf7ca4cf912d860cf868e724c..git_revision:487f8353f15456474437df32bb186187b0940b45
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/fe092931f1..35b04da37d
* third_party/android_build_tools/error_prone/cipd: -IrkxgAkj3RxGNBPp6b4r9OWZC6_dTbI-jC3c3UPgq8C..2t_u1XEjof609BQE4czlCQzEqRliKS_qY35FOu_VckgC
* third_party/android_build_tools/lint/cipd: gx4NrAApWUVG5HG3WJRIIzZrTssD6H5uGbKe0g77mucC..TEDRB0F7VgCgyepd8FsIxPRqvKjvWQ_YkLV-ybx-GQYC
* third_party/android_build_tools/manifest_merger/cipd: HhXknpcPosMUDHZQD-8Ogve-HaG4HmJ4p082zKKAcnMC..fPGWiT0LVG2_ifxOpHb5KNwTL-_7lb7tYOsB_ZoIiskC
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/1ea2115b17..a86aaa9531
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/000f47cfa3..1591e813b6
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1fcc527019..5982a1aeb3
* third_party/fuchsia-sdk/sdk: version:27.20250424.2.1..version:27.20250501.3.1
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/917609c669..62724eb55f
* third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/912274164f..bf95cc5da6
* third_party/r8/cipd: bA3htCoEd_EArHekDGQSNpmBzQrcby2ioG6SFyl3AtwC..sxgLKZyJNZMVi8cot5yvRzqCFQxX_HbbR0psaeto5RcC
* third_party/r8/d8/cipd: 6qLey8EBp9ivhThnqVPWy2ZDGpsf5Y29EsTbi_rZ1pMC..bA3htCoEd_EArHekDGQSNpmBzQrcby2ioG6SFyl3AtwC
* third_party/rust: https://chromium.googlesource.com/chromium/src/third_party/rust/+log/926ec54499..7c098b791b
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/1e85c01b15..6f9b4e6192
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/60443ebac3..e4c0da2094
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6c4f037a98..5ae6e4bfb4
* tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:a9a10995e2889126ace91faf4052949e38c69d33
* tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:a9a10995e2889126ace91faf4052949e38c69d33
* tools/luci-go: git_revision:fd48b8efe637ea5f431fc371f1617b215b7ba1a2..git_revision:a9a10995e2889126ace91faf4052949e38c69d33
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3b0c718c2d..e3589a5831
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/9c8188cae9..1a0049ce09
* tools/rust: https://chromium.googlesource.com/chromium/src/tools/rust.git/+log/fa679ed68e..7e70cdf64e
* tools/skia_goldctl/linux: M9CSmdri8G3miQpGPQeqstBvQ3TtlngrsiF5GdSTYs0C..srGbc-O6bVQmBoT6VLvP66h6Be4A-nffx4UhixUJ9w0C
* tools/skia_goldctl/mac_amd64: Txs7Izu5kRGbcoAc9qESynBnBHo8RdRIyim5zF9rWbgC..tZvHxy8AcDJhO9A-5UuZKL_-5vfE_wC-RBkElqWZpM4C
* tools/skia_goldctl/mac_arm64: LTzU4UbKV4zw61tWyttEX62vyq7nErr2gD8-jiH8IhgC..2br8hIWKHDAaOt77siYyRUclHBYUZX6dj8jtogL90nwC
* tools/skia_goldctl/win: UKiySjywM8juGVuMwWbOdaBXFD1TbzUOWcGGVTYfem0C..zasiUhQIHGZ2e60_M6g41oz8mYgPta5JmOWV5LwFjGMC
No update to Clang.
Bug: chromium:414330998
Change-Id: I5ce14c5574391c1dd638787c09789f0577ee26a2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6503456
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
64e97940
|
2024-04-22T11:41:05
|
|
Presubmit: improve bug tag check message
* list acceptable options regardless of failure type
* add a note when multiple Change-Id tags are detected (this can happen,
for example, in case of chained CLs)
* add extra info to the same error instead of adding it as another error
Example output:
** Presubmit ERRORS: 1 **
Please ensure that your description contains
Bug: bugtag
directly above the Change-Id tag (no empty line in-between)
Acceptable bugtags:
project:bugnumber - where project is one of (angleproject, chromium, dawn, fuchsia, skia, swiftshader, tint)
b/bugnumber - for Buganizer/IssueTracker bugs
None - for minor changes with full context in description
Bug: None
Change-Id: I9b5fc5db2896bfd332570fa78ba67bd622cd876e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5472983
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Auto-Submit: Roman Lavrov <romanl@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
c0dae760
|
2024-01-10T18:37:03
|
|
Wildcards instead of redundant API specification in expectations
The expectations already specify the API they relate to. As such,
specifying the API tag in the gtest name is redundant. For example, it
is preferred to specify:
1234 MAC OPENGL : Foo.Bar/* = SKIP
instead of:
1234 MAC OPENGL : Foo.Bar/ES2_OpenGL = SKIP
1234 MAC OPENGL : Foo.Bar/ES3_OpenGL = SKIP
This change also adds a presubmit to make sure the latter is not
reintroduced. The only possibly legitimate use case for being specific
about the test name is if only a variant of the test fails (such as
ES3_OpenGL_SomeWorkaround). Note that if the opposite is the case
(i.e. ES3_OpenGL fails, but ES3_OpenGL_SomeWorkaround passes), it's an
indication that the feature that made the test pass should have been
enabled by default.
Bug: angleproject:8465
Change-Id: I11476e36c83cbbeb8148b6e934c42ccd9b988de1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5185675
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuxin Hu <yuxinhu@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
0769e7ce
|
2023-10-02T14:27:10
|
|
decode() subprocess.check_output output
Currently getting this output as a single line:
export_targets.py failed: b'Importing graph\n ( ...'
Bug: b/303079476
Change-Id: Ia6c13822476744efd4a8a2934eaedb30ec463709
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4908347
Commit-Queue: Roman Lavrov <romanl@google.com>
Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
|
|
3dbfa314
|
2023-08-04T15:56:47
|
|
Add Gitmodules to angle.
Commits in the gitlinks should be kept in sync with commits in DEPS.
For repos that are auto-rolled by skia, this is taken care of.
If you have your own autoroll script and it uses `gclient setdep`
to update deps commits, this is also taken care of.
For manual rolls:
1) in DEPS update the commit of some <path> to <new_commit>
2) update the gitlink:
`git update-index --add --cacheinfo 160000,<new_commit>,<path>`
Bug: chromium:1421776
Change-Id: I70d02969b198ea6ae94d042c4ffab31b70eb88fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4752314
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
|
|
c7d46eb8
|
2023-06-05T16:03:11
|
|
Add kwargs to specialized error message
https://crrev.com/c/4505697 started accepting show_callstack. Since
Msg is used as specialized error message, it also needs to accept
show_callstack since CallCommand will pass it.
Bug: chromium:1451607
Change-Id: Ib3aee58b41d2419446e71b8e67392daed407714d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4591539
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
|
|
|
27d412fb
|
2023-02-16T11:41:46
|
|
Presubmit: relax line length rules for quotes
... and : after Roll, Reland etc
Bug: angleproject:4683
Change-Id: Ibe1098402a2fd67b929a71fa74c5a1747a90fc3d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4261310
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
0b3cca88
|
2023-02-03T22:44:31
|
|
Bypass commit message presubmit checks on manual rolls
Bug: angleproject:4683
Change-Id: I7e6b3655acfc7adde5bb0da31133e8eca9904207
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4221696
Reviewed-by: Roman Lavrov <romanl@google.com>
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
67e0c6fc
|
2022-08-11T22:10:36
|
|
PRESUBMIT: Remove unnecessary escape of forward slash
Bug: angleproject:7279
Change-Id: Icf9482fb83c60640d5af6380674b9d857aa9ff0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3828443
Reviewed-by: Roman Lavrov <romanl@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
|
47d2df0e
|
2022-08-10T15:15:18
|
|
Presubmit: Verify ANGLE_SH_VERSION update
... when ShaderLang.h or ShaderVars.h change.
Bug: angleproject:7279
Change-Id: I01f6035ad41a4d92cc9e5d1e509731bb2ff29047
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3823619
Reviewed-by: Roman Lavrov <romanl@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
e7269490
|
2022-07-06T09:48:41
|
|
Remove python version check in presubmit
This script should now always be run under python3 due to
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3739269
Bug: angleproject:7475
Change-Id: I12ddb42b074959aec36731d121282a81c46bc5ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3749136
Commit-Queue: Eddie Hatfield <eddiehatfield@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
|
|
|
ac1af388
|
2022-06-23T14:08:50
|
|
Add presubmit check for .gclient file
Bug: angleproject:4905
Change-Id: I6dbb81ed2d2e102869e5d844fed1bb4c1ef4f449
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3720557
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Eddie Hatfield <eddiehatfield@google.com>
|
|
|
198924c4
|
2022-06-10T15:30:33
|
|
Remove python 2 from presubmit
Bug: chromium:1313804
Change-Id: Ibbb3f3734f0d88016ec2d2a91bb0e0aba12661c2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3697623
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
20820bb4
|
2022-05-13T10:50:47
|
|
Make BitSetArray constexpr
Bug: angleproject:5906
Change-Id: If1ccacfc81e3e01b4bdbd10d47cf4ec860e3fe0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645494
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
14c483f1
|
2022-05-03T21:33:32
|
|
Presubmit: Verify comment before new tests
A new presubmit check is added that looks for lines adding tests, i.e.
matching `+TEST_P(`, and makes sure they are preceded by a pattern such
as:
```
// ...
- ... (optional removals)
+TEST_P(...)
```
or
```
+// ...
- ... (optional removals)
+TEST_P(...)
```
If no comment is found before the test, an error is generated.
Bug: angleproject:2626
Change-Id: Ibf76ae76ad3b1bb0efcf7eab8273153dd5c5162e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3626929
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
2753f20e
|
2021-04-06T14:04:02
|
|
Add tint: to the list of allowed Bug: tags.
Bug: tint:700
Change-Id: I296aa62920688074b2c71b6aaec9505af9c10221
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2807715
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
b6ea6edc
|
2020-12-29T16:30:29
|
|
Remove tabs from volk.c/h
WebKit's SVN continues to abhor tabs.
Bug: angleproject:3439
Change-Id: Ib97fc97c0eb7401f73ea493a7b679f78afc1a8c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606658
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
|
|
f69aaf60
|
2020-10-05T21:50:10
|
|
Replaced allow_list with files_to_check
Link to the inclusivity rules
https://source.android.com/setup/contribute/respectful-code
Bug: b/162834212
Change-Id: I2bb65ca7ae73109dc858c93f3a9f973ebfe9d4cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2451318
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Trevor Black <vantablack@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
e815afbf
|
2020-09-07T22:09:22
|
|
First pass at increasing inclusivity
Link to the inclusivity rules
https://source.android.com/setup/contribute/respectful-code
Bug: b/162834212
Bug: chromium:1097198
Change-Id: Ied5a9e3879d72bff3f77ea6fcda9b82f30c32c2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2396737
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Trevor Black <vantablack@google.com>
|
|
185d9d08
|
2020-08-14T22:48:15
|
|
Re-land "Feedback Loop Redesign 2/3: Track bound FBOs in Texture."
Re-land fixes the crash when drawing with no bound Program executable.
Currently we track feedback loops by counting the times a Texture is
bound as a sampler or image in a particular context. This is a bit
tricky because Texture bindings change frequently. Relative to the
number of times we need to check for a feedback loop this causes excess
overhead.
Usually Framebuffers have a low number of Textures bound (in many cases
just 1). And Textures aren't usually bound to many different FBOs. So
instead of counting the number of times a Texture is bound as a sampler
or image we will track the Framebuffers that the Texture is bound to.
This CL adds a small vector class to gl::Texture which tracks all the
Framebufer Serials of its bound Framebuffers. We can use this set to
quickly check if there's any potential feedback loop between the a FBO
and this Texture.
We also update the feedback loop check to use this new method. We will
be able to remove the old counting method when we switch the Vulkan
feedback loop handling to use the new tracking in this CL.
Bug: angleproject:4500
Bug: angleproject:4959
Change-Id: If2bd25b08298a99f5e64b4055137f9154b0f0860
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2365595
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
cb8eea2f
|
2020-07-01T23:17:43
|
|
Change how multiple commit messages are split
Instead of just splitting commit messages at Change-Id line, now commit
messages will be split at the first blank line after a Change-Id line.
Bug: angleproject:4715
Change-Id: I39d69662560fd67d1361f13e81362c9a1a7af3bd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2279570
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
2df3bf51
|
2020-06-17T17:07:47
|
|
Re-enable presubmit commit message format check
Bug: angleproject:4715
Change-Id: I7dfd00f5a31a2df6751bb1dc9fd271f24294e966
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2249374
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
31bbe1ba
|
2020-06-11T10:46:55
|
|
Change how commit messages are taken + multiple commits handling
Multiple commits are separated and format-checked separately.
Commit message is now taken solely from input_api.
Tags paragraph now covers the very last paragraph until the
first line that doesn't have a ":"
Bug: angleproject:4662
Change-Id: I84fe3fd1ffc30f6892a5c9dbe545acf24b0fc595
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2241617
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
cd4bf5e7
|
2020-06-10T13:08:14
|
|
Temporarily take out commit message format check
Commit message format check is currently unstable and
needs to be taken out until further improvement.
Bug: angleproject:4715
Change-Id: Ia4837c0cd800963f7cc8a0cf9d77f49fab1627fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2239081
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
75037213
|
2020-06-09T17:36:54
|
|
Add 'Reland ' to whitelist and update error messages for clarity.
Commit messages starting with 'Reland ' always pass presubmit test.
Error message now shows offending lines and how to get around them.
Bug: angleproject:4683
Change-Id: If1a1ccfcf59172b10b2ca2066f3a087ff61dd4bd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2237987
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
462e40f2
|
2020-06-04T14:15:59
|
|
Allow lines up to 72 characters in commit messages
72 is the limit, not 71. See:
https://stackoverflow.com/a/17792445/912144
Bug: angleproject:4683
Change-Id: Icb53f2d532b9b55e31e3f1593bd2302a3011095e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2230785
Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
505b6eb1
|
2020-06-04T09:11:21
|
|
Allow line formats to pass description body's line length check
1. Lines starting with 4 spaces will not be checked for line length
2. Lines with no space in it will not be checked for line length
Bug: angleproject:4683
Change-Id: Ic648b8b1084762da208d89ee5fbff2b02b69cf12
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2230899
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
|
|
|
ebc6d0a4
|
2020-05-27T18:21:30
|
|
Presubmit script to enforce commit message formatting
1. The first sentence description should be one line <= 64 characters
2. The description body should be wrapped to <= 71 characters
3. Blank lines between the description and the body,
and the body and the meta-tags like Bugs
Bug: angleproject:4662
Change-Id: I966c79d96175da9eee92ef6da20db50d488137b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2218696
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Manh Nguyen <nguyenmh@google.com>
|
|
|
a89750ec
|
2020-04-30T18:00:00
|
|
Tweaks to presubmit script.
- run the same checks on 'git cl upload' as 'git cl pre'
- show the problematic line on non-ascii presubmit check
Bug: angleproject:4601
Change-Id: I321e22fd49f7a83aa062ebae01d13476e57044e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2174075
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
|
|
f7d44736
|
2020-04-29T16:55:01
|
|
Detect non-ascii characters during presubmit
Clang format and non-ascii characters don't get along well, which are
typically introduced when copy/pasting spec language. This CL will
detect non-ascii characters during presubmit.
Bug: angleproject:4601
Test: git cl presubmit --upload
Change-Id: I80080fc04590ad47c9756f8f969d5c7f44d41793
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2173684
Reviewed-by: Shrek Shao <shrekshao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
13e4cdb2
|
2020-04-16T14:35:54
|
|
Accept b/ for bug IDs in ANGLE CLs.
Bug: b/151095080
Change-Id: Ic9da14a1476958eb00d4499dacdaa9c529b0626c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2152849
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
c2d81731
|
2020-03-09T15:14:23
|
|
Allow referencing buganizer issues with ANGLE CLs.
Based on
http://google3/experimental/users/jsharkey/gitwatcher2/configs.py?l=42&rcl=299145346,
chromium CLs with b: should be found by buganizer.
BUG=b:151095080
Change-Id: Iaf4def18dbe52fe87c9e4655f114fac225d429ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2095595
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
634ee434
|
2019-12-16T11:39:10
|
|
Improve presubmit's Bug: tag check
Specifying the project name is now mandatory. This helps avoid
accidentally referring to chromium bugs by forgetting the project name.
At the same time, it ensures the project name is not misspelled.
Bug: angleproject:4184
Change-Id: I6bbfe1751e2fd0baf424be38018374cce360df5d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1969067
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
4dff9956
|
2019-12-10T17:05:37
|
|
Presubmit check forbidding tab characters in source files.
WebKit's Subversion repository forbids tab characters in source files.
Follow-up to:
https://chromium-review.googlesource.com/c/angle/angle/+/1954410
Bug: angleproject:3439
Change-Id: I7ab170cae6985c62ee2f163c15d2746f620fe648
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1959750
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
|
|
|
8dfc2b05
|
2019-11-25T15:12:58
|
|
Update codegen presubmit error.
Clarifies that gclient sync should happen before codegen to avoid using
stale hashes on upload.
Bug: angleproject:3227
Change-Id: I7777458b6fa659a07307ad1d845ac7d332afa8f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1934313
Reviewed-by: Ethan Lee <flibitijibibo@gmail.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
4210e49b
|
2019-10-10T14:22:03
|
|
Correct presubmit error for missing Bug ID
Having a Bug ID is not enough to silence this error,
the Bug ID must be on the line directly above the
Change ID line to prevent getting this error.
Bug: angleproject:3992
Change-Id: I90ec1169efb77c1be6a1004e579f16e89115be50
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1853604
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
|
|
cc4d8331
|
2019-09-11T17:26:00
|
|
Reland "Add export_targets.py to presubmit"
This is a reland of c40a21f353a2d0a37e83f3dce3a1c3096574be64
Changes: Fixed presubmit failing on Windows due to being unable
to find gn, fixed export_targets.py failing on Windows for
Googlers due to being unable to find Visual Studio files.
Original change's description:
> Add export_targets.py to presubmit
>
> Adds export_targets.py to run as part of presubmit in order to help
> prevent breaking Firefox with BUILD.gn changes.
>
> Bug: chromium:1003151
> Change-Id: I5a7ab00891cd7c094c797e6150f642f803a726b6
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1802038
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Bug: chromium:1003151
Change-Id: I321ade86f2d969601afb8e1ed61c36bf166887b5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1842127
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
a4242146
|
2019-10-04T18:57:25
|
|
Revert "Add export_targets.py to presubmit"
This reverts commit c40a21f353a2d0a37e83f3dce3a1c3096574be64.
Reason for revert: Seems to be failing locally on Windows.
See bug for more info.
Original change's description:
> Add export_targets.py to presubmit
>
> Adds export_targets.py to run as part of presubmit in order to help
> prevent breaking Firefox with BUILD.gn changes.
>
> Bug: chromium:1003151
> Change-Id: I5a7ab00891cd7c094c797e6150f642f803a726b6
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1802038
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
TBR=ynovikov@chromium.org,bsheedy@chromium.org,jgilbert@mozilla.com,jmadill@chromium.org
Change-Id: Ic9a2eb58d847a40349e64b931c369f07c24b799c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1003151
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1841877
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
c40a21f3
|
2019-09-11T17:26:00
|
|
Add export_targets.py to presubmit
Adds export_targets.py to run as part of presubmit in order to help
prevent breaking Firefox with BUILD.gn changes.
Bug: chromium:1003151
Change-Id: I5a7ab00891cd7c094c797e6150f642f803a726b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1802038
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
2538f6b4
|
2019-07-12T14:23:11
|
|
Revert "PRESUBMIT.py: Don't require "Bug:" for autoroller CLs."
This reverts commit 9be098b52fbb59322ee83fd77b3c64442d742822.
Reason for revert: Fixed in the auto-rollers. They should now
include Bug: tags.
Original change's description:
> PRESUBMIT.py: Don't require "Bug:" for autoroller CLs.
>
> BUG=angleproject:3659
>
> Change-Id: I29d77939953e3661ea979f8f7a9f44566079e567
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1692881
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
TBR=geofflang@chromium.org,cwallez@chromium.org,jmadill@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: angleproject:3659
Change-Id: I01a2e82c24918c831a6c444360620d261ec892dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1700141
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
9be098b5
|
2019-07-09T12:00:48
|
|
PRESUBMIT.py: Don't require "Bug:" for autoroller CLs.
BUG=angleproject:3659
Change-Id: I29d77939953e3661ea979f8f7a9f44566079e567
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1692881
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
|
9e438eeb
|
2019-07-05T08:44:23
|
|
Update presubmit checks.
- clarifies error for run_code_generation hashes.
- makes missing format or bug tag an error.
- check for spaces in bug tags.
Bug: angleproject:3659
Change-Id: I069e60d8acdf070961bdf342acf976ddd1138b1b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1689019
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
d7d42395
|
2019-05-06T13:15:35
|
|
Format all of ANGLE's python code.
BUG=angleproject:3421
Change-Id: I1d7282ac513c046de5d8ed87f7789290780d30a6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1595440
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
|
04e9e559
|
2019-04-01T14:40:21
|
|
Use revision.h for glslang dirty checks.
This file changes a lot less than git HEAD. And it should guard against
the same changes. Should reduce the instances of developer confusion
regarding run_code_generation being out of data.
Also update the presubmit check to print a more helpful message in the
case where the code does need to be regenerated.
Bug: angleproject:3333
Change-Id: I190dab5be50fc42512bdfc11c2d200f34f3b2092
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545123
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
|
|
|
73397e8e
|
2019-01-09T10:33:16
|
|
Add presubmit check for GN headers and code formatting.
These two checks are lifted directly from the Chromium code base. Also
adds a presubmit check for a patch description. Also adds some checks
to the "on commit" function so "git cl presubmit" can work.
Also reformats the style of the presubmit script a bit to match the
patterns in the Chromium presubmit.
Bug: angleproject:2626
Bug: angleproject:3054
Change-Id: Iff29b8856cf9eb9531e893cd0b0d80c0834b7676
Reviewed-on: https://chromium-review.googlesource.com/c/1403255
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
98a3550b
|
2019-01-08T22:09:39
|
|
Add a presubmit step to make sure autogenerated code is up-to-date
While here, added a presubmit test for the Bug: tag too.
Bug: angleproject:3046
Change-Id: I7030685230b4ce4bfc435c14ef85324e16b76274
Reviewed-on: https://chromium-review.googlesource.com/c/1402061
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|