|
7d6aa630
|
2025-08-13T15:50:24
|
|
Reland: Rename enums to fix GCC -Wchanges-meaning error
This is a reland of commit dc24ecca9ed920c0269e9d62dfcac4b3f3e5a4d4
Original change's description:
> Renamed enums Key and MouseButton to enum class KeyType and
> MouseButtonType to avoid name conflicts with union members in
> Event.h on GCC, and to follow the ANGLE style guide preference
> for scoped enums.
>
> BUG: angleproject:438226513
> Change-Id: I8892b438b3b05a3ce4e14f8c0769b81722688da8
> Signed-off-by: Sungyong Choi <sywow.choi@samsung.com>
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6845484
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
BUG: angleproject:438226513
Change-Id: Ifc1a7bad661881a1a71bd5380fe431270bc68686
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6874206
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
ccbc9e9b
|
2025-08-20T05:28:12
|
|
Revert "Rename enums to fix GCC -Wchanges-meaning error"
This reverts commit dc24ecca9ed920c0269e9d62dfcac4b3f3e5a4d4.
Reason for revert: breaks ios-simulator build when rolled to Chromium
https://chromium-review.googlesource.com/c/chromium/src/+/6863632
https://ci.chromium.org/ui/p/chromium/builders/try/ios-simulator/2446924/overview
[10968/78005] OBJCXX obj/third_party/angle/util/angle_util_static/IOSWindow.o
sdk/xcode_links/iPhoneSimulator18.2.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSDictionary.h:17:38: error: reference to 'KeyType' is ambiguous
17 | - (nullable ObjectType)objectForKey:(KeyType)aKey;
BUG: angleproject:438226513
Original change's description:
> Rename enums to fix GCC -Wchanges-meaning error
>
> Renamed enums Key and MouseButton to enum class KeyType and
> MouseButtonType to avoid name conflicts with union members in
> Event.h on GCC, and to follow the ANGLE style guide preference
> for scoped enums.
>
> BUG: angleproject:438226513
> Change-Id: I8892b438b3b05a3ce4e14f8c0769b81722688da8
> Signed-off-by: Sungyong Choi <sywow.choi@samsung.com>
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6845484
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
Bug: angleproject:438226513
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Iff0d925b9fa608215cff0e472074a0315f14e861
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6863019
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
dc24ecca
|
2025-08-13T15:50:24
|
|
Rename enums to fix GCC -Wchanges-meaning error
Renamed enums Key and MouseButton to enum class KeyType and
MouseButtonType to avoid name conflicts with union members in
Event.h on GCC, and to follow the ANGLE style guide preference
for scoped enums.
BUG: angleproject:438226513
Change-Id: I8892b438b3b05a3ce4e14f8c0769b81722688da8
Signed-off-by: Sungyong Choi <sywow.choi@samsung.com>
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6845484
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|
|
9d737966
|
2019-08-14T12:25:12
|
|
Standardize copyright notices to project style
For all "ANGLE Project" copyrights, standardize to the format specified
by the style guide. Changes:
- "Copyright (c)" and "Copyright(c)" changed to just "Copyright".
- Removed the second half of date ranges ("Y1Y1-Y2Y2"->"Y1Y1").
- Fixed a small number of files that had no copyright date using the
initial commit year from the version control history.
- Fixed one instance of copyright being "The ANGLE Project" rather than
"The ANGLE Project Authors"
These changes are applied both to the copyright of source file, and
where applicable to copyright statements that are generated by
templates.
BUG=angleproject:3811
Change-Id: I973dd65e4ef9deeba232d5be74c768256a0eb2e5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1754397
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
|
|
f35f1110
|
2019-07-19T09:18:55
|
|
Add script to apply clang-format on all sources
1. python script wrapper to call clang-format over the whole code base
2. Add clang-format rule `IncludeBlocks: Preserve` to tell clang-format
do not merge include blocks
3. Fix existed clang-format issue in code base
Bug: angleproject:3532
Change-Id: I289292dc62c2784ff21688065c87c3f3f5538f17
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1709720
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
1cfaaf8a
|
2014-08-21T10:04:04
|
|
Add a util project to share between samples and tests.
This code shares the Window and EGL logic between the two
projects.
BUG=angle:730
Change-Id: I8940371226a8f7b02579c332f51679c4a5d0e2a5
Reviewed-on: https://chromium-review.googlesource.com/212799
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
|