-
Show log
Commit
-
Hash : 8712495d
Author :
Date : 2021-10-05T11:56:32
Capture/Replay: Don't handle void pointers as const TL;DR: glReadPixels needs a non-const pointer if a pack buffer is bound, so change the code generation to keep TvoidPointer non-const and regenerate the entry points. Long version: When no pack buffer is bound, then in WriteCppReplayForCall param.readBufferSizeBytes is non-zero and the cast of the read buffer pointer is using the type passed by the parameter (TvoidPionter) to write the typecast by calling ParamTypeToString directly, which returns "void *". If. OTOH, a pack buffer is bound, then param.readBufferSizeBytes is zero, and the default WriteParamCaptureReplay is called. This autogenerated function forwards the call to WriteParamValueReplay by using an explicit type specification, and the autogeneration code was translating TvoidPointer to call WriteParamValueReplay<ParamType::TvoidConstPointer> which would then translate to "const void *" in the parameter type cast, and this would lead to a compilation failure, because the parameter must be a non-const pointer. Change the autogeneration code so that TvoidPointer is not forced to be a const pointer and regenerate the entry points. Bug: angleproject:6521 Change-Id: I673c77f803a284fb7dfc08a2e0918aebdf698194 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3204959 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
-
Files
- angle_deqp_test_merge.py
- angle_presubmit_utils.py
- angle_presubmit_utils_unittest.py
- apply_clang_format_on_all_sources.py
- bmp_to_nv12.py
- bootstrap.py
- cl.xml
- code_generation_hashes/
- egl.xml
- egl_angle_ext.xml
- entry_point_packed_egl_enums.json
- entry_point_packed_gl_enums.json
- export_targets.py
- extension_data/
- file_exists.py
- gen_angle_gn_info_json.py
- gen_gl_enum_utils.py
- gen_proc_table.py
- gen_vk_gl_cts_build.py
- generate_android_bp.py
- generate_entry_points.py
- generate_loader.py
- generate_new_renderer.py
- generate_stats.py
- gl.xml
- gl_angle_ext.xml
- msvs_projects.py
- perf_test_runner.py
- process_angle_perf_results.py
- registry_xml.py
- remove_files.py
- roll_aosp.sh
- roll_chromium_deps.py
- run_code_generation.py
- run_gtest_angle_test.py
- trigger.bat
- trigger.py
- update_chrome_angle.py
- update_extension_data.py
- vk_mandatory_format_support_capture_to_json.js
- wgl.xml
