kc3-lang/angle/src

Diff

• Show log

  Commit

• Hash : 233c128b
  Author :
  Date : 2023-01-17T19:21:58
  

  Vulkan: Fix UBs when deleted attachment is used in a RenderPass.
  
  Problem:
  - "RenderbufferVk"/"TextureVk" with "mOwnsImage == false" used as
    RenderPass attachment.
  - "RenderbufferVk"/"TextureVk" deleted.
  - Owning resource is destroyed ("EGLImage" and all siblings /
    "EGLSurface").
  - Crash (UB) may happen when ending RenderPass, flushing or executing
    commands.
  
  Fix adds tracking of "vk::ImageSourceID" value in
  "vk::RenderPassAttachment" - IDs of objects, that originally provide
  "vk::ImageHelper" images. This is necessary, because when using
  EGLImage, there may be multiple "TextureVk" objects with same
  "vk::ImageHelper", and need to call "finalizeImageLayout()" for the
  correct attachment.
  
  Bug: angleproject:8032
  Test: angle_end2end_tests --gtest_filter=ImageTest*DeletedWhileInUse*
  Test: angle_end2end_tests --gtest_filter=PbufferTest.UseAsFramebufferColorThenDestroy*
  Change-Id: I50fdd9d6b6a9677adad2262373303b46de1dee4c
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4296014
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Charlie Lao <cclao@google.com>
  Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
  

• Files

• android_system_settings/
• angle_program_serialize_data_version.gni
• commit_id.py
• common/
• compiler.gni
• compiler/
• copy_compiler_dll.bat
• feature_support_util/
• gpu_info_util/
• image_util/
• libANGLE/
• libEGL/
• libGLESv1_CM/
• libGLESv2.gni
• libGLESv2/
• libOpenCL/
• program_serialize_data_version.py
• tests/
• third_party/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags