• Show log

    Commit

  • Hash : 52152933
    Author : Roman Lavrov
    Date : 2023-06-06T15:36:36

    Add trace_interface: functions and callbacks for traces
    
    Defines the interface between the test suite
    (or an other TraceLibrary class user) and trace libraries.
    
    TraceFunctions defines entry points for calls suite->trace, such as
    SetupReplay() or SetBinaryDataDir().
    
    TraceCallbacks defines entry points for calls trace->suite, for example
    for loading .angledata.gz files.
    
    These are set up via the exported SetupEntryPoints() call. Functions
    like SetupReplay etc no longer need to be exported from the trace
    library.
    
    TraceInfo (parsed representation of the trace json) is moved to
    trace_interface as is. This is convenient for further changes to the
    fixture that will allow to easily move some of the captured parameters
    to json.
    
    This also moves Decompress functionality (and memory ownership) to test
    suite entirely, which avoids Decompress/Delete callbacks - the trace
    just calls LoadBinaryData via TraceCallbacks and TraceLibrary releases
    the memory either on FinishReplay or in its destructor.
    This should also take care of the memory leak described in
    https://crrev.com/c/3858185
    
    Bug: b/286072760
    Change-Id: Ibc6f6f64156ad805b1917c8fc41a3b0d2c0d6375
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4594445
    Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com>
    Commit-Queue: Roman Lavrov <romanl@google.com>
    Reviewed-by: Cody Northrop <cnorthrop@google.com>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    thodg_m kc3_lang_org thodg_w www_kmx_io thodg thodg_l
    Tags