Hash :
42cb6147
Author :
Date :
2022-01-05T07:59:51
Revert workarounds for exception handler code-gen with CFG enabled
This reverts two commits:-
Revert "disable cfguards for all deqp tests"
This reverts commit 1d2752d84f497c8012af1f54b1b3ec52f9b5cc92.
Change-Id: I6d2647340592d3b9b5f2430d4fd077835528ef0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3244256
Revert "Disable cfguard for tcu/depq test files"
This reverts commit 2ca35522660e780a13235d80c9c643dfb0e53faf.
Change-Id: Iae75dc0f911a3430276909f4a14944d0f805fdf2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3241703
A fix in https://reviews.llvm.org/D114914 should make this workaround
unnecessary. See https://crbug.com/1260847 for discussion.
Building Chrome with the following gn args, the following tests pass.
build_angle_deqp_tests = true
dcheck_always_on = true
is_component_build = true
is_debug = false
symbol_level = 2
target_cpu = "x86"
use_goma = true
win_enable_cfg_guards = true
.\out\swangle\angle_deqp_gles2_tests.exe --use-angle=swiftshader --bot-mode
.\out\swangle\angle_deqp_gles31_tests.exe --use-angle=swiftshader --bot-mode
Tests: CQ
Bug: chromium:1260847
Bug: angleproject:6617
Change-Id: Iff3b2a3cedb21bb16bb7dd7b30c3d3b4ecd79d78
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3368184
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>