• Show log

    Commit

  • Hash : 4d66ff7a
    Author : Jonathan Lee
    Date : 2025-02-21T19:21:08

    [gtest] Consume `AssertionResult`s in `Parse_test.cpp`
    
    Wrap each `testing::AssertionResult` in an `EXPECT_TRUE(...)` [0] to
    actually check if the assertion passed. The dropped assertion was
    revealed [1] by Googletest recently marking `AssertionResult` as
    `[[nodiscard]]` [2].
    
    [0]:https://google.github.io/googletest/advanced.html#predicate-assertions-for-better-error-messages
    [1]:https://ci.chromium.org/ui/p/chromium/builders/try/linux-chromeos-rel/2296143/overview
    [2]:https://chromium.googlesource.com/external/github.com/google/googletest.git/+/3fbe4db9a39291ae8d7a9c5f1d75896bb4c5a18f%5E%21/
    
    Bug: chromium:398298306
    Change-Id: I438f817dc6636068664d2bd5bc41b041b867b4c8
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6293847
    Commit-Queue: Geoff Lang <geofflang@chromium.org>
    Reviewed-by: Geoff Lang <geofflang@chromium.org>
    Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
    Auto-Submit: Jonathan Lee <jonathanjlee@google.com>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    kc3_lang_org thodg_w www_kmx_io thodg_l thodg thodg_m
    Tags