kc3-lang/angle/util

Diff

• Show log

  Commit

• Hash : 51a1db16
  Author :
  Date : 2015-04-06T09:02:37
  

  Give Timer a virtual destructor as it's deleted polymorphically.
  
  Found by clang:
  
  ..\..\third_party\angle\src\common/angleutils.h(66,5) :  error: delete called on 'Timer' that is abstract but has non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
      delete resource;
      ^
  ..\..\third_party\angle\src\tests\perf_tests\ANGLEPerfTest.cpp(26,5) :  note: in instantiation of function template specialization 'SafeDelete<Timer>' requested here
      SafeDelete(mTimer);
      ^
  
  BUG=chromium:82385
  
  Change-Id: I69033b1802b5dffbdf2d80889aca7019d710d481
  Reviewed-on: https://chromium-review.googlesource.com/264061
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Tested-by: Geoff Lang <geofflang@chromium.org>
  

• Files

• EGLWindow.cpp
• EGLWindow.h
• Event.h
• OSWindow.cpp
• OSWindow.h
• Timer.h
• keyboard.h
• mouse.h
• path_utils.h
• random_utils.cpp
• random_utils.h
• shader_utils.cpp
• shader_utils.h
• testfixturetypes.h
• util.gyp
• win32/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags