-
Show log
Commit
-
Hash : 2aa5286d
Author :
Date : 2021-10-12T17:05:48
Add Entry Point name to validation errors Add gl/gles entry point names to validation error messages some special cases: 1. Debug::insertPerfWarning() is invoked from multiple places, such as TextureVK, ContextVK, adding an extra entryPoint function parameter in these files will need extra investigations. I am passing the entryPoint name GLInvalid as a temp workaround. 2.ErrorSet::hangleError() is invoked from multiple Context*.cpp files, adding an extra entryPoint function parameter in these files will need extra investigations. I am passing the entryPoint name GLInvalid as a temp workaround. 3. Debug::insertMessage(), Debug::popGroup(), Debug::pushGroup() can be invoked from more than one GL entry points, e.g. Debug::pushGroup() can be invoked from either GL_APIENTRY GL_PushDebugGroup() or GL_APIENTRY GL_PushDebugGroupKHR() through context->pushDebugGroup() call. Right now the same entry point name glPushDebugGroup will be printed out in the error message for both cases. However, we should be able to tell the actual entry point by checking which version: KHR version or core version the application uses, and this helps avoid the confusion. For now we will let the same entry point name getting printed for both cases. Bug: angleproject:6523 Change-Id: I64a5463d9168d8444d376d1f428c3b3d894f2ea9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3215063 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Yuxin Hu <yuxinhu@google.com>
-
Files
- angle_deqp_test_merge.py
- angle_presubmit_utils.py
- angle_presubmit_utils_unittest.py
- apply_clang_format_on_all_sources.py
- bmp_to_nv12.py
- bootstrap.py
- cl.xml
- code_generation_hashes/
- egl.xml
- egl_angle_ext.xml
- entry_point_packed_egl_enums.json
- entry_point_packed_gl_enums.json
- export_targets.py
- extension_data/
- file_exists.py
- gen_angle_gn_info_json.py
- gen_gl_enum_utils.py
- gen_proc_table.py
- gen_vk_gl_cts_build.py
- generate_android_bp.py
- generate_entry_points.py
- generate_loader.py
- generate_new_renderer.py
- generate_stats.py
- gl.xml
- gl_angle_ext.xml
- msvs_projects.py
- perf_test_runner.py
- process_angle_perf_results.py
- registry_xml.py
- remove_files.py
- roll_aosp.sh
- roll_chromium_deps.py
- run_code_generation.py
- run_gtest_angle_test.py
- trigger.bat
- trigger.py
- update_chrome_angle.py
- update_extension_data.py
- vk_mandatory_format_support_capture_to_json.js
- wgl.xml
