-
Show log
Commit
-
Hash : e417bfb0
Author :
Date : 2020-09-15T14:08:36
Android: Set angle_enable_commit_id=false in roll_aosp.sh The current roll_aosp.sh is generating an invalid Android.bp by including the local repo's .git file: cc_genrule { name: "angle_commit_id", tool_files: [ "src/commit_id.py", ], cmd: "$(location) gen $(location commit.h)", srcs: [ ".git/refs/heads/rollAngle", ], sdk_version: "28", out: [ "commit.h", ], } This is fixed by enabling the GN arg 'angle_enable_commit_id=false' in the script: cc_genrule { name: "angle_commit_id", tool_files: [ "src/commit_id.py", ], cmd: "$(location) gen $(location commit.h)", sdk_version: "28", out: [ "commit.h", ], } Bug: angleproject:5050 Test: Manual verification in AOSP checkout Change-Id: I08a08084c4c25411b29b22544c2ed8c06f6f54d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2412790 Reviewed-by: Geoff Lang <geofflang@chromium.org>
-
Files
- angle_presubmit_utils.py
- angle_presubmit_utils_unittest.py
- apply_clang_format_on_all_sources.py
- bmp_to_nv12.py
- bootstrap.py
- code_generation_hashes/
- egl.xml
- egl_angle_ext.xml
- entry_point_packed_gl_enums.json
- export_targets.py
- file_exists.py
- gen_angle_gn_info_json.py
- gen_gl_enum_utils.py
- gen_proc_table.py
- gen_vk_gl_cts_build.py
- generate_android_bp.py
- generate_entry_points.py
- generate_loader.py
- generate_new_renderer.py
- generate_stats.py
- gl.xml
- gl_angle_ext.xml
- msvs_projects.py
- perf_test_runner.py
- registry_xml.py
- remove_files.py
- roll_aosp.sh
- roll_chromium_deps.py
- run_code_generation.py
- run_gtest_angle_test.py
- trigger.bat
- trigger.py
- update_canary_angle.py
- vk_mandatory_format_support_capture_to_json.js
- wgl.xml
