• Show log

    Commit

  • Hash : 6bb47e67
    Author : Amirali Abdolrashidi
    Date : 2025-06-17T13:42:47

    Vulkan: Limit finalizing foreign image layouts
    
      Currently, any submission results in finalizing all foreign images.
    However, if the submission is only limited to the outside render pass
    command buffer, this would result in oldLayout VVL errors (01197), as
    it would be too early to finalize the layout of such images at those
    times. At this time, this type of submission can occur if the size of
    buffer-to-image updates exceeds the following threshold:
    kMaxBufferToImageCopySize
    
    In this change, finalizing the foreign image layouts would only occur
    when all commands are being submitted.
    
    * In ContextVk::submitCommands(), finalizeAllForeignImages() is now
      called only when the submission type is Submit::AllCommands.
    
    * Added new submit tests for foreign images to ImageTest:
      * UploadForeignUntilSubmitDoesNotBreakRenderPass
      * CopyToForeignUntilSubmitDoesNotBreakRenderPass
    
    Bug: b/425987310
    Change-Id: Ia345e176be79017ba18ef52a57256eeeb298e39a
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6653602
    Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
    Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
    Reviewed-by: Charlie Lao <cclao@google.com>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    thodg_m kc3_lang_org thodg_w www_kmx_io thodg thodg_l
    Tags