kc3-lang/angle

Diff

  • Show log

    Commit

  • Hash : 7ad48b84
    Author : Kai Ninomiya
    Date : 2022-05-26T00:23:35 

    Revert "Add Vulkan backend support for texture labels"

This reverts commit 1afb80587e302e2ce9a901a69fd66e5ef98a73b6.

Reason for revert: Null-dereference crash starting here:
https://ci.chromium.org/ui/p/chromium/builders/ci/mac-swangle-chromium-x64/26323/blamelist
(see angle blamelist)

Crash reason:  EXC_BAD_ACCESS / KERN_INVALID_ADDRESS
Crash address: 0x0
Process uptime: 24 seconds

Thread 0 (crashed)
 0  0x0
    rax = 0x0000011c0113c000   rdx = 0x0000011c09094590
    rcx = 0x0000000000000006   rbx = 0x0000011c0e2a0000
    rsi = 0x00007ffedfc11500   rdi = 0x0000011c01378010
    rbp = 0x00007ffedfc11540   rsp = 0x00007ffedfc114f8
     r8 = 0x0000000000000006    r9 = 0x0000000123a6ccc4
    r10 = 0x0000011c011018d0   r11 = 0x00007ffdbc1a4834
    r12 = 0x0000000000000006   r13 = 0x0000011c090944b0
    r14 = 0x0000011c0e34c000   r15 = 0x00007ffedfc11550
    rip = 0x0000000000000000
    Found by: given as instruction pointer in context
 1  libGLESv2.dylib!gl::Context::objectLabel(unsigned int, unsigned int, int, char const*) + 0x156
    rbp = 0x00007ffedfc116a0   rsp = 0x00007ffedfc11550
    rip = 0x00000001357b38e6
    Found by: previous frame's frame pointer
 2  libGLESv2.dylib!_GL_ObjectLabelKHR + 0xa5
    rbp = 0x00007ffedfc116f0   rsp = 0x00007ffedfc116b0
    rip = 0x000000013578e7e5
    Found by: previous frame's frame pointer
 3  Chromium Framework!gpu::gles2::GLES2DecoderPassthroughImpl::DoBindTexture(unsigned int, unsigned int) + 0x1ea
    rbp = 0x00007ffedfc11780   rsp = 0x00007ffedfc11700
    rip = 0x000000011e7dcd4a
    Found by: previous frame's frame pointer

Original change's description:
> Add Vulkan backend support for texture labels
>
> Add onLableUpdate support for textures in the Vulkan backend.
>
> Bug: b/229105865
> Change-Id: Id9e5b2b81352e97b7843a63f27709739005dc2f3
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3645854
> Reviewed-by: Ian Elliott <ianelliott@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Ian Elliott <ianelliott@google.com>

Bug: b/229105865
Change-Id: I5a5e00084e1320a486c43fec9d41b9ae6cb2b1db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3669657
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github
    Users
    		 thodg_m kc3_lang_org thodg_w www_kmx_io thodg thodg_l
    Tags

  • README.md

  • ANGLE - Almost Native Graphics Layer Engine

    The goal of ANGLE is to allow users of multiple operating systems to seamlessly run WebGL and other OpenGL ES content by translating OpenGL ES API calls to one of the hardware-supported APIs available for that platform. ANGLE currently provides translation from OpenGL ES 2.0, 3.0 and 3.1 to Vulkan, desktop OpenGL, OpenGL ES, Direct3D 9, and Direct3D 11. Future plans include ES 3.2, translation to Metal and MacOS, Chrome OS, and Fuchsia support.

    Level of OpenGL ES support via backing renderers

    Direct3D 9 Direct3D 11 Desktop GL GL ES Vulkan Metal
    OpenGL ES 2.0 complete complete complete complete complete complete
    OpenGL ES 3.0 complete complete complete complete in progress
    OpenGL ES 3.1 incomplete complete complete complete
    OpenGL ES 3.2 in progress in progress in progress

    Platform support via backing renderers

    Direct3D 9 Direct3D 11 Desktop GL GL ES Vulkan Metal
    Windows complete complete complete complete complete
    Linux complete complete
    Mac OS X complete in progress
    iOS in progress
    Chrome OS complete planned
    Android complete complete
    GGP (Stadia) complete
    Fuchsia complete

    ANGLE v1.0.772 was certified compliant by passing the OpenGL ES 2.0.3 conformance tests in October 2011.

    ANGLE has received the following certifications with the Vulkan backend:

    • OpenGL ES 2.0: ANGLE 2.1.0.d46e2fb1e341 (Nov, 2019)
    • OpenGL ES 3.0: ANGLE 2.1.0.f18ff947360d (Feb, 2020)
    • OpenGL ES 3.1: ANGLE 2.1.0.f5dace0f1e57 (Jul, 2020)

    ANGLE also provides an implementation of the EGL 1.5 specification.

    ANGLE is used as the default WebGL backend for both Google Chrome and Mozilla Firefox on Windows platforms. Chrome uses ANGLE for all graphics rendering on Windows, including the accelerated Canvas2D implementation and the Native Client sandbox environment.

    Portions of the ANGLE shader compiler are used as a shader validator and translator by WebGL implementations across multiple platforms. It is used on Mac OS X, Linux, and in mobile variants of the browsers. Having one shader validator helps to ensure that a consistent set of GLSL ES shaders are accepted across browsers and platforms. The shader translator can be used to translate shaders to other shading languages, and to optionally apply shader modifications to work around bugs or quirks in the native graphics drivers. The translator targets Desktop GLSL, Vulkan GLSL, Direct3D HLSL, and even ESSL for native GLES2 platforms.

    Sources

    ANGLE repository is hosted by Chromium project and can be browsed online or cloned with

    git clone https://chromium.googlesource.com/angle/angle

    Building

    View the Dev setup instructions.

    Contributing

kmx.io     mail     discord kmxgit v0.4.0