-
Show log
Commit
-
Hash : 1adf46a6
Author :
Date : 2022-06-03T12:44:39
Enable X11 defines on ChromeOS While the typical deployment of ChromeOS on physical hardware does not use X11, the linux-chromeos-rel and linux-lacros-rel builders on the Chromium CQ do. These builders compile a special version of Chrome with all of the ChromeOS features (e.g. the system UI) that runs on top of a generic Linux bot as a windowed application. As a result, this special build of CrOS needs to interface with the windowing system of the host Linux machine, which is X on the CQ bots. These builds still have target_os=chromeos, so we need to include is_chromeos to angle_use_x11 to get the right defines. Unfortunately, this CL breaks the linux-chromeos bots as the X11 define makes ANGLE use VulkanXcbDisplay which in turn fails init as SwANGLE does not support VK_KHR_xcb_surface. There's a Chromium CL that fixes this by explicitly requesting the headless display. Thus, we need to wait for that to land or else the Chromium CQ will break on roll. [1] https://chromium-review.googlesource.com/c/chromium/src/+/3686625 Bug: b/233238923 Change-Id: Ifec50f68826aef2c3d732ae9dedabcd6d61f45a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3689809 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
-
Files
- angle.gni
