• Show log

    Commit

  • Hash : 91f92540
    Author : Kyle Piddington
    Date : 2022-01-14T18:34:44

    Metal: Fix multisample resolves.
    
    1) Only use MTLLoadActionDontCare if store action was
    MTLStoreActionDontCare, ignoring MTLStoreActionMultisampleResolve.
    
    2) For color, depth and stencil attachments, if they have implicit
    multisample textures, use MTLStoreActionStoreAndMultisampleResolve
    rather than MTLStoreActionStore.
    
    This addresses bugs when resolving a multisampled framebuffer and
    copying it to a texture, and fixes these two Three.js demos:
      https://threejs.org/examples/webgl_framebuffer_texture
      https://threejs.org/examples/webgl_decals
    
    Added CopyTextureTestES3.DrawThenCopyThenBlend modeled after new WebGL
    2.0 conformance test in:
      https://github.com/KhronosGroup/WebGL/pull/3379
    
    Confirmed to catch the bug. On Intel Macs, the Metal debug layers and
    load/store action validation must be enabled:
      MTL_DEBUG_LAYER=1 \
      MTL_DEBUG_LAYER_VALIDATE_LOAD_ACTIONS=1 \
      MTL_DEBUG_LAYER_VALIDATE_STORE_ACTIONS=1 \
      MTL_DEBUG_LAYER_VALIDATE_UNRETAINED_RESOURCES=4 \
        angle_end2end_tests ...
    
    Bug: angleproject:6972
    Change-Id: I7bcb7c19e434e22e24b800fdce4c480d10b1fc40
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3450033
    Reviewed-by: Gregg Tavares <gman@chromium.org>
    Reviewed-by: Geoff Lang <geofflang@chromium.org>
    Commit-Queue: Kenneth Russell <kbr@chromium.org>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    thodg_m kc3_lang_org thodg_w www_kmx_io thodg thodg_l
    Tags