• Show log

    Commit

  • Hash : a7bd3f53
    Author : Amirali Abdolrashidi
    Date : 2023-03-31T16:57:35

    Fix the retrace issue for VMA image suballocation
    
    After adding the VMA image suballocation feature, VVL errors were seen
    when using the retracing script for some traces, causing failure. After
    analysis, it was seen that the functionality of the allocation differs
    from the original method when it comes to non-zero memory allocation.
    
    * In allocateAndBindMemory(), the memory property flags from the
      allocated memory are returned to be used for non-zero memory feature
      usage.
    
    * Added mapMemoryAndInitWithNonZeroValue() to ImageMemorySuballocator,
      which is used when allocateNonZeroMemory is enabled and the allocated
      memory is host-visible.
    
    * Merged the following into ImageHelper::initializeNonZeroMemory():
      * mapMemoryAndInitWithNonZeroValue()
      * InitMappableDeviceMemory(); used when VMA image suballocation is
        disabled.
    
    * Moved onMemoryAlloc() inside allocateAndBindMemory().
    
    Test: retrace_restricted_traces.py
    Bug: b/277618656
    Bug: angleproject:8058
    Change-Id: If411a073e900c1c034d40a99e3fffefe30c82548
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4391403
    Reviewed-by: Cody Northrop <cnorthrop@google.com>
    Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
    Reviewed-by: Charlie Lao <cclao@google.com>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    thodg_m kc3_lang_org thodg_w www_kmx_io thodg thodg_l
    Tags