-
Show log
Commit
-
Hash : a79c2440
Author :
Date : 2019-07-29T11:34:21
Make libEGL function pointers hidden in symbol table The libEGL_angle.so and libGLESv2_angle.so libraries are typically loaded into the same process each time, so we need to make sure there aren't any duplicated symbols which could violate ODR and lead to crashes or undefined behavior. In this case, the libEGL_angle.so function pointer names were colliding with libGLESv2_angle.so function names, causing crashes at runtime. The fix here is to mark the libEGL_angle.so function pointer symbols 'hidden', so they don't appear in the symbol table for other executables/libraries to see and can't be overridden by other symbols. Bug: angleproject:3751 Test: Embed ANGLE within dEQP.apk and verify no crashes Change-Id: Ibb78369374a4a68b3489a7dd7775c52e29fa37e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1724909 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>
-
Files
- apply_clang_format_on_all_sources.py
- bmp_to_nv12.py
- bootstrap.py
- code_generation_hashes/
- egl.xml
- egl_angle_ext.xml
- entry_point_packed_gl_enums.json
- export_targets.py
- file_exists.py
- gen_angle_gn_info_json.py
- gen_proc_table.py
- generate_entry_points.py
- generate_loader.py
- generate_new_renderer.py
- generate_stats.py
- generate_vulkan_layers_json.py
- gl.xml
- gl_angle_ext.xml
- msvs_projects.py
- perf_test_runner.py
- registry_xml.py
- remove_files.py
- run_code_generation.py
- trigger.bat
- trigger.py
- update_canary_angle.py
- vk_mandatory_format_support_capture_to_json.js
- wgl.xml
