-
Show log
Commit
-
Hash : a1665d2f
Author :
Date : 2024-05-10T00:15:31
Reland "Document thread-unsafe iterator access to resource maps" This is a reland of commit d1bb6ed8399dd12e79484f30f9e9ded95c25625a The crash was due to another issue (disabling EGL validation in Chrome) Original change's description: > Document thread-unsafe iterator access to resource maps > > By using a proxy type, everywhere resource maps are iterated are clearly > marked as not being thread safe. In most cases, only destruction and > capture/replay iterate over these maps, which means thread safety is not > an issue (or is externally enforced). > > The only case where iterators are used in the presence of other contexts > is with ANGLE_request_extension, which is changed to explicitly require > the application to ensure thread safety. In practice, the user is > Chrome which already guarantees this. > > Bug: angleproject:8667 > Change-Id: I7af13c6433b6955d9c36f9088b3aa4c065e1cfc1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5526428 > Reviewed-by: Charlie Lao <cclao@google.com> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: angleproject:8667 Change-Id: Id539cabac01df5f242150f6684222577003eef3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5531278 Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
-
Files
- ANGLE_base_vertex_base_instance.txt
- ANGLE_base_vertex_base_instance_shader_builtin.txt
- ANGLE_client_arrays.txt
- ANGLE_clip_cull_distance.txt
- ANGLE_compressed_texture_etc.txt
- ANGLE_copy_texture_3d.txt
- ANGLE_depth_texture.txt
- ANGLE_explicit_context_gles1.txt
- ANGLE_external_objects_flags.txt
- ANGLE_external_objects_fuchsia.txt
- ANGLE_framebuffer_blit.txt
- ANGLE_framebuffer_multisample.txt
- ANGLE_get_image.txt
- ANGLE_get_serialized_context_string.txt
- ANGLE_get_tex_level_parameter.txt
- ANGLE_instanced_arrays.txt
- ANGLE_logic_op.txt
- ANGLE_lossy_etc_decode.txt
- ANGLE_memory_size.txt
- ANGLE_multi_draw.txt
- ANGLE_multiview_multisample.txt
- ANGLE_pack_reverse_row_order.txt
- ANGLE_polygon_mode.txt
- ANGLE_program_binary.txt
- ANGLE_program_binary_readiness_query.txt
- ANGLE_program_cache_control.txt
- ANGLE_provoking_vertex.txt
- ANGLE_read_only_depth_stencil_feedback_loops.txt
- ANGLE_relaxed_vertex_attribute_type.txt
- ANGLE_renderability_validation.txt
- ANGLE_request_extension.txt
- ANGLE_rgbx_internal_format.txt
- ANGLE_robust_client_memory.txt
- ANGLE_robust_fragment_shader_output.txt
- ANGLE_robust_resource_initialization.txt
- ANGLE_shader_binary.txt
- ANGLE_shader_pixel_local_storage.txt
- ANGLE_stencil_texturing.txt
- ANGLE_texture_compression_dxt.txt
- ANGLE_texture_multisample.txt
- ANGLE_texture_usage.txt
- ANGLE_translated_shader_source.txt
- ANGLE_vulkan_image.txt
- ANGLE_webgl_compatibility.txt
- ANGLE_yuv_internal_format.txt
- CHROMIUM_bind_generates_resource.txt
- CHROMIUM_bind_uniform_location.txt
- CHROMIUM_compressed_copy_texture.txt
- CHROMIUM_copy_texture.txt
- CHROMIUM_sync_query.txt
- EGL_ANGLE_colorspace_attribute_passthrough.txt
- EGL_ANGLE_context_virtualization.txt
- EGL_ANGLE_create_context_backwards_compatible.txt
- EGL_ANGLE_create_context_client_arrays.txt
- EGL_ANGLE_create_context_extensions_enabled.txt
- EGL_ANGLE_create_context_webgl_compatibility.txt
- EGL_ANGLE_create_surface_swap_interval.txt
- EGL_ANGLE_d3d_share_handle_client_buffer.txt
- EGL_ANGLE_d3d_texture_client_buffer.txt
- EGL_ANGLE_device_cgl.txt
- EGL_ANGLE_device_creation.txt
- EGL_ANGLE_device_creation_d3d11.txt
- EGL_ANGLE_device_d3d.txt
- EGL_ANGLE_device_eagl.txt
- EGL_ANGLE_device_metal.txt
- EGL_ANGLE_device_vulkan.txt
- EGL_ANGLE_direct3d_display.txt
- EGL_ANGLE_direct_composition.txt
- EGL_ANGLE_display_power_preference.txt
- EGL_ANGLE_display_semaphore_share_group.txt
- EGL_ANGLE_display_texture_share_group.txt
- EGL_ANGLE_experimental_present_path.txt
- EGL_ANGLE_explicit_context.txt
- EGL_ANGLE_external_context_and_surface.txt
- EGL_ANGLE_feature_control.txt
- EGL_ANGLE_ggp_stream_descriptor.txt
- EGL_ANGLE_global_fence_sync.txt
- EGL_ANGLE_iosurface_client_buffer.txt
- EGL_ANGLE_keyed_mutex.txt
- EGL_ANGLE_metal_create_context_ownership_identity.txt
- EGL_ANGLE_metal_shared_event_sync.txt
- EGL_ANGLE_metal_texture_client_buffer.txt
- EGL_ANGLE_no_error.txt
- EGL_ANGLE_platform_angle.txt
- EGL_ANGLE_platform_angle_d3d.txt
- EGL_ANGLE_platform_angle_d3d11on12.txt
- EGL_ANGLE_platform_angle_d3d_luid.txt
- EGL_ANGLE_platform_angle_device_context_volatile_cgl.txt
- EGL_ANGLE_platform_angle_device_context_volatile_eagl.txt
- EGL_ANGLE_platform_angle_device_id.txt
- EGL_ANGLE_platform_angle_device_type_egl.txt
- EGL_ANGLE_platform_angle_device_type_swiftshader.txt
- EGL_ANGLE_platform_angle_metal.txt
- EGL_ANGLE_platform_angle_null.txt
- EGL_ANGLE_platform_angle_opengl.txt
- EGL_ANGLE_platform_angle_vulkan.txt
- EGL_ANGLE_platform_angle_webgpu.txt
- EGL_ANGLE_power_preference.txt
- EGL_ANGLE_prepare_swap_buffers.txt
- EGL_ANGLE_program_cache_control.txt
- EGL_ANGLE_query_surface_pointer.txt
- EGL_ANGLE_robust_resource_initialization.txt
- EGL_ANGLE_software_display.txt
- EGL_ANGLE_stream_producer_d3d_texture.txt
- EGL_ANGLE_surface_d3d_texture_2d_share_handle.txt
- EGL_ANGLE_surface_orientation.txt
- EGL_ANGLE_swap_with_frame_token.txt
- EGL_ANGLE_sync_control_rate.txt
- EGL_ANGLE_timestamp_surface_attribute.txt
- EGL_ANGLE_vulkan_display.txt
- EGL_ANGLE_vulkan_image.txt
- EGL_ANGLE_wait_until_work_scheduled.txt
- EGL_ANGLE_window_fixed_size.txt
- EGL_ANGLE_x11_visual.txt
- EGL_CHROMIUM_create_context_bind_generates_resource.txt
- EGL_CHROMIUM_sync_control.txt
- EGL_EXT_device_query.txt
