kc3-lang/angle/src

Diff

• Show log

  Commit

• Hash : 239763d9
  Author :
  Date : 2025-04-04T17:52:10
  

  CL/VK: Fix ArgumentWorkgroup setArg logic
  
  Issue was that clSetKernelArg for ArgumentWorkgroup
  type arguments would blindly push new values into
  kernel's spec-constant FastVector on every clSetKernelArg
  (even on same arg updates).
  
  This would lead to over-pushing due to same arg updates,
  which caused all kinds of issues, mainly erroneous misses
  in compute pipeline cache since the key is based on
  VkSpecializationInfo.
  
  Since kernel object already keeps a vector of kernel args,
  we don't need a separate spec-constant FastVector in CLKernelVk to
  track this. Remove it and derive the spec-constant data
  from the kernel args themselves.
  
  Bug: angleproject:366415134
  Tests-Passing: Geekbench-6.2.2 - Workloads: [ 401 & 601 ]
  Change-Id: Iab7f27fdfdfede33881e1dd717ba3b771cffb985
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6773615
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

• Files

• android_system_settings/
• angle_program_serialize_data_version.gni
• commit_id.py
• common/
• compiler.gni
• compiler/
• copy_compiler_dll.bat
• feature_support_util/
• gpu_info_util/
• image_util/
• libANGLE/
• libEGL/
• libGLESv1_CM/
• libGLESv2.gni
• libGLESv2/
• libOpenCL/
• program_serialize_data_version.py
• tests/
• third_party/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags