• Show log

    Commit

  • Hash : da5a5628
    Author : Sungyong Choi
    Date : 2025-08-11T10:53:06

    bitset_utils: Fix GCC shift-count-overflow warning
    
    GCC triggers a -Werror=shift-count-overflow when kDefaultBitSetSize
    is 64, due to the constructor compiling a branch with `value >>= 64`.
    Although this path is never executed at runtime, GCC still inspects
    the code and emits the warning as an error.
    
    Refactored the constructor to:
    - Move common reset() into a single place
    - Split initialization into initFromValue<S>() overloads
      enabled only for S < 64 or S >= 64 via std::enable_if_t
    - Avoid generating any shift code when S >= 64
    
    This change ensures GCC does not instantiate invalid shift operations
    and keeps the initialization logic cleaner.
    
    BUG: angleproject:438226513
    Change-Id: I1ed0b42540f1bfce469d5738757045bc6d92ac61
    Signed-off-by: Sungyong Choi <sywow.choi@samsung.com>
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6845475
    Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    Reviewed-by: Charlie Lao <cclao@google.com>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    thodg_m kc3_lang_org thodg_w www_kmx_io thodg thodg_l
    Tags