-
Show log
Commit
-
Hash : 624fbdcf
Author :
Date : 2018-10-01T11:54:05
Refactor CompileProgram utility Tests often need to call gl functions to set up program related state after glCreateProgram has been called but prior to glLinkProgram is called. Add a callback function to the CompileProgram utility function to fulfill this need. This reduces code duplication considerably in several tests. An alternative way to improve CompileProgram would be to split it into several different utility functions. This might be slightly easier to read, but would also be a larger refactoring and require more checks at the call site. This will make it easier to implement EXT_blend_func_extended tests, which need to bind fragment outputs to different slots. BUG=angleproject:1085 TEST=angle_end2end_tests Change-Id: I3ac8b7bdc21c6a1f14517bc7df0cf6f35abd7612 Reviewed-on: https://chromium-review.googlesource.com/1254062 Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
-
Files
- EGLWindow.cpp
- EGLWindow.h
- Event.h
- Matrix.cpp
- Matrix.h
- OSPixmap.h
- OSWindow.cpp
- OSWindow.h
- Timer.h
- android/
- com_utils.h
- geometry_utils.cpp
- geometry_utils.h
- keyboard.h
- linux/
- mouse.h
- osx/
- ozone/
- posix/
- random_utils.cpp
- random_utils.h
- shader_utils.cpp
- shader_utils.h
- system_utils.h
- util.gni
- windows/
- x11/
