• Show log

    Commit

  • Hash : a990ba34
    Author : Yuxin Hu
    Date : 2023-08-02T17:21:00

    Fix write out of bounds on non robust contexts crashes
    
    dEQP-EGL.functional.robustness.reset_context.shaders.out_of_bounds_non_robust.reset_status.writes.*
    tests are failing, because the test expectes EGL_SUCCESS
    upon eglMakeCurrent(EGL_NO_CONTEXT), regardless of whether
    the context was lost.
    
    This CL:
    1) Changes the validation function of eglMakeCurrent:
    if the EGLContext passed to eglMakeCurrent
    is EGL_NO_CONTEXT, do not return EGL_CONTEXT_LOST even if
    the context is already lost.
    
    2) Adds a lost context check in checkOneCommandBatch.
    If the context is lost, do not check fence status and
    assume all of the vulkan commands have finished execution,
    so that we can properly destroying all
    the resources before destroying the context.
    
    3) Changes the GL error code from GL_INVALID_OPERATION
    to GL_CONTEXT_LOST when there is a vulkan device lost.
    
    Bug: b/286921997
    Bug: b/289544394
    Change-Id: I91e8a4105f0d7a3ec3b59bae58da80bc64ffa94a
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4728466
    Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
    Commit-Queue: Yuxin Hu <yuxinhu@google.com>
    Reviewed-by: Charlie Lao <cclao@google.com>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    thodg_m kc3_lang_org thodg_w www_kmx_io thodg_l thodg
    Tags